date:20131007

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-07 Thread Aurélien Gâteau



 On Oct. 5, 2013, 10:53 a.m., David Faure wrote:
  Good catch about the format string syntax changes between kde and qt.
  
  But why not just add t to the format string to include the timezone, as 
  it used to do with %Z, instead of the removeTimeZone() function?
 

As far as I can tell, t is not supported in QDateTime format string. There is 
however the, new in 5.2, QTimeZone class. I am going to rework the patch to use 
it instead of ignoring the time zone information.


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113076/#review41267
---


On Oct. 3, 2013, 6 p.m., Aurélien Gâteau wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113076/
 ---
 
 (Updated Oct. 3, 2013, 6 p.m.)
 
 
 Review request for KDE Frameworks and John Layt.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 This fixes kcookiejartest, which was failing to parse the date from the Y2K38 
 check.
 
 The test started failing on build.kde.org when the Qt version here was 
 switched to the stable branch, which seems to parse things differently than 
 the version of Qt build.kde.org used to run.
 
 The code was ported from KDateTime::fromString() to QDateTime::fromString(), 
 whose syntax for date formatting is different, but the format was not updated.
 
 This patch is incomplete, see the FIXME comments in removeTimeZone(). But I 
 want to ensure this is the correct way to go before getting into timezones.
 
 
 Diffs
 -
 
   kioslave/http/kcookiejar/kcookiejar.cpp e943da9 
 
 Diff: http://git.reviewboard.kde.org/r/113076/diff/
 
 
 Testing
 ---
 
 kcookiejartest now passes again (must be run with LANG=C btw)
 
 
 Thanks,
 
 Aurélien Gâteau
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-07 Thread Aurélien Gâteau


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112984/#review41326
---


Looks good to me. One last thing: you need to document the save() = 
saveTheme() change in KDE5PORTING.html

- Aurélien Gâteau


On Oct. 6, 2013, 10:56 p.m., David Gil Oliva wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/112984/
 ---
 
 (Updated Oct. 6, 2013, 10:56 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Adjust API in KEmoticons framework: KEmoticonsProvider::save()
 
 -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save()
 and prefer saveTheme() instead.
 -Adjust plugins.
 -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(),
 which was empty. Now it's a pure virtual function. Therefore, I deprecate
 it and advice subclassing KEmoticonsProvider.
 
 
 Diffs
 -
 
   staging/kemoticons/src/core/kemoticonsprovider.cpp 
 d04c76e87b118f5d45717b3b2ccd9dea47dc2526 
   staging/kemoticons/src/core/kemoticonsprovider.h 
 85fc7efb8923d76476f0a16f70f8ebb15e451081 
   staging/kemoticons/src/core/kemoticonstheme.h 
 b8b25f7607d3741dda78d6302c1ed81fbc9211a0 
   staging/kemoticons/src/core/kemoticonstheme.cpp 
 ed3407cdd45c84d91f2d0057e108b760ff696ff2 
   staging/kemoticons/src/providers/adium/adium_emoticons.h 
 039a267679919c968bbe4d12c35abb90cf1bcc9b 
   staging/kemoticons/src/providers/adium/adium_emoticons.cpp 
 a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 
   staging/kemoticons/src/providers/kde/kde_emoticons.h 
 8cba6b194eee1543bf13f1177a0e4092f1a10943 
   staging/kemoticons/src/providers/kde/kde_emoticons.cpp 
 5b5114a14dd94a6ebcba8a6f7dd163f73048189a 
   staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 
 70bafa3fe4ba25c9d6a69634024b2c157235e674 
   staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp 
 e9f89eecce3d6e6407113a84cb5200ff66564c19 
   staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 
 0873a635a300e0ed8e38b1d59a535d6ec15b99cb 
   staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 
 0dc92ed092d87a559fe7fa1a40e804843ab73d59 
 
 Diff: http://git.reviewboard.kde.org/r/112984/diff/
 
 
 Testing
 ---
 
 It builds. It installs. Tests pass.
 
 
 Thanks,
 
 David Gil Oliva
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113105: Move KWallet to tier2

2013-10-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113105/
---

(Updated Oct. 7, 2013, 10:46 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Valentin Rusu.


Repository: kdelibs


Description
---

Does the move, adds the missing dependencies


Diffs
-

  staging/CMakeLists.txt afa9c87 
  tier2/CMakeLists.txt 3d3d2cf 
  tier2/kwallet/CMakeLists.txt e8be3ef 
  tier2/kwallet/KWalletConfig.cmake.in 4dec013 

Diff: http://git.reviewboard.kde.org/r/113105/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: QTimeZone merged for 5.2

2013-10-07 Thread Kevin Ottens

Hello,

On Thursday 03 October 2013 18:15:22 John Layt wrote:
 On 24 September 2013 19:24, Kevin Ottens er...@kde.org wrote:
  On Tuesday 24 September 2013 19:03:21 John Layt wrote:
  I'll do some analysis on the use of all the widgets and what ones are
  worth keeping, and look at the Qt widgets to see if they're worth
  switching to, if not before then at Qt Dev Days / Qt Contributors Day.
  
  OK, I'll ignore this part of KDE4Attic then and proceed with the rest. We
  really need to put this issue to a rest, it's been lingering for way too
  long. Really looking forward to your analysis!
 
 Replying to all the list, damn gmail not knowing about mailing lists :-\
 
 And here's my analysis :-)
 
 tl;dr:
 * Port KDateTimeEdit, KDatePicker, KDateTable and KTimeZoneWidget to Qt5.
 * Move KDateTimeWidget, KDateWidget, KDateComboBox and KTimeComboBox
 to kde4support
 
 General rule:
 Any widget that uses KDateTime, KCalendarSystem, KTimeZone, or KLocale
 must either go to kde4support or be ported.  Porting would require
 removing all uses of these K classes and using QDateTime, QTimeZone
 and QLocale instead.  KCalendarSystem would be replaced by using
 QLocale, as QLocale will embed the QCalendarSystem class to be used,
 as well as translations, formatters, etc.  The widgets calendar api
 setCalendar(), setCalendarSystem() and calendar() would be replaced by
 setLocale() and locale().

OK, good to know.

 No apps I checked currently use the calendar api on the widgets.  Internal
 code accessing date/time values like day() via KGlobal::calendar() would
 change to directly accessing QDate or QTime for now, after Qt 5.3 they would
 then need changing again to use QCalendarSystem via QLocale::calendar().

OK.
 
 Method: Checked out all of the KDE SC, plus major gui apps from
 extragear and calligra, then grepped for the class names.
 
 Visual guide: https://www.dropbox.com/s/qkdgo5s68pg6tp6/KDateWidgets.png
 
 KDateTimeEdit
 - My new widget to replace many local widgets, added in last kdelibs release
 - Can replace KDateComboBox, KTimeComboBox, api is almost the same - Not
 used anywhere!?!
 - API uses QDate, QTime, KDateTime, KCalendarSystem, KTimeZone
 - Suggest: Port to Qt5
 - KDE4 era apps can start pre-porting?
 - Or add to Qt?

OK, let's port to Qt5 and then move in KWidgetsAddons.

 KDateTimeWidget
 - Used 8 times
 - API uses QDateTime
 - Poor UX
 - Suggest: kde4support, replace with KDateTimeEdit
 
 KDateWidget
 - Used 6 times
 - API uses QDate, KCalendarSystem
 - Poor UX
 - Suggest: kde4support, replace with KDateTimeEdit
 
 KDateComboBox
 - Used 30 times, 29 in kdepim
 - API uses QDate, KCalendarSystem, KLocale::DateFormat
 - Forked by several apps due to lack of features, KDateTimeEdit
 written to replace
 - Suggest: kde4support, replace with KDateTimeEdit
 
 KTimeComboBox
 - Used 10 times, all kdepim
 - API uses QTime, KLocale formats
 - Forked by several apps due to lack of features, KDateTimeEdit
 written to replace
 - Suggest: kde4support, replace with KDateTimeEdit

OK, can all go in kde4support IMO. Makes for poor widgets in the first place.

 KDatePicker
 - Used about 20 times, but hard to tell due to forks and wrappers
 - Forked and/or wrapped by several apps due to lack of features, needs
 to be reviewed
 - Uses QDate, KCalendarSystem
 - Suggest: Port to Qt5

OK, let's port to Qt5 and then move in KWidgetsAddons.

 KDateTable
 - Used directly 2 times, but is part of KDatePicker
 - Forked and/or wrapped by couple apps due to lack of features, needs
 to be reviewed
 - API uses QDate, KCalendarSystem
 - Suggest: Port to Qt5
 - Maybe make private, have flag on KDatePicker to hide chrome?
 - Make KPopupFrame private?
 - Make KDateVaidator private?

What does it bring compared to QCalendarWidget? Couldn't KDatePicker use 
QCalendarWidget instead?

 KTimeZoneWidget
 - Used 4 times
 - API uses KTimeZone
 - Unlikely to be included in Qt, so needed in KF5
 - API looks a little old fashioned, users need major rewrite anyway
 for QTimeZone
 - Suggest: Port to Qt5?  Or start anew?

Eew, indeed it inherits publicly from QTreeWidget. I would say we can move it 
in kde4support renamed as K4TimeZoneWidget... but we need to come up with an 
alternative as it's used two times in the workspace.

Thanks a lot for the work done.

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113142: Move KPty to tier 3

2013-10-07 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113142/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Move KPty to tier 3


Diffs
-

  CMakeLists.txt 6a6b5f5 
  kpty/CMakeLists.txt  
  kpty/KPtyConfig.cmake.in  
  kpty/Mainpage.dox  
  kpty/src/CMakeLists.txt  
  kpty/src/ConfigureChecks.cmake  
  kpty/src/config-pty.h.cmake  
  kpty/src/kgrantpty.c  
  kpty/src/kpty.h  
  kpty/src/kpty.cpp  
  kpty/src/kpty_p.h  
  kpty/src/kptydevice.h  
  kpty/src/kptydevice.cpp  
  kpty/src/kptyprocess.h  
  kpty/src/kptyprocess.cpp  
  kpty/tests/CMakeLists.txt  
  kpty/tests/kptyprocesstest.h  
  kpty/tests/kptyprocesstest.cpp  
  tier3/CMakeLists.txt 53fe81b 

Diff: http://git.reviewboard.kde.org/r/113142/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113142: Move KPty to tier 3

2013-10-07 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113142/#review41334
---



tier3/CMakeLists.txt
http://git.reviewboard.kde.org/r/113142/#comment30272

I wonder if we should put KDESu here too as it needs KPty to build...


- Martin Klapetek


On Oct. 7, 2013, 11:04 a.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113142/
 ---
 
 (Updated Oct. 7, 2013, 11:04 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Move KPty to tier 3
 
 
 Diffs
 -
 
   CMakeLists.txt 6a6b5f5 
   kpty/CMakeLists.txt  
   kpty/KPtyConfig.cmake.in  
   kpty/Mainpage.dox  
   kpty/src/CMakeLists.txt  
   kpty/src/ConfigureChecks.cmake  
   kpty/src/config-pty.h.cmake  
   kpty/src/kgrantpty.c  
   kpty/src/kpty.h  
   kpty/src/kpty.cpp  
   kpty/src/kpty_p.h  
   kpty/src/kptydevice.h  
   kpty/src/kptydevice.cpp  
   kpty/src/kptyprocess.h  
   kpty/src/kptyprocess.cpp  
   kpty/tests/CMakeLists.txt  
   kpty/tests/kptyprocesstest.h  
   kpty/tests/kptyprocesstest.cpp  
   tier3/CMakeLists.txt 53fe81b 
 
 Diff: http://git.reviewboard.kde.org/r/113142/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David Edmundson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113097: KInit splitting

2013-10-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113097/
---

(Updated Oct. 7, 2013, 11:37 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Adapts KInit to be moved to its tier, there's still work to do.

The most important change is the creation of a new KF5_ADD_KDEINIT_EXECUTABLE 
macro.
Also I reorganized the source code in different directories, so it's easier to 
figure out.


Diffs
-

  CMakeLists.txt 3204c11 
  KDE5PORTING.html 88700b0 
  cmake/modules/kde4init_dummy.cpp.in  
  cmake/modules/kde4init_win32lib_dummy.cpp.in 0aa704b 
  kded/CMakeLists.txt 5a09a3a 
  kinit/CMakeLists.txt 2e26d91 
  kinit/ConfigureChecks.cmake  
  kinit/Info.plist.template  
  kinit/Mainpage.dox  
  kinit/README  
  kinit/README.autostart  
  kinit/README.wrapper  
  kinit/autostart.h  
  kinit/autostart.cpp  
  kinit/config-kdeinit.h.cmake  
  kinit/kinit.cpp  
  kinit/kinit_win.cpp  
  kinit/kioslave.cpp  
  kinit/klauncher.h  
  kinit/klauncher.cpp  
  kinit/klauncher_adaptor.h  
  kinit/klauncher_adaptor.cpp  
  kinit/klauncher_cmds.h  
  kinit/klauncher_cmds.cpp  
  kinit/klauncher_main.cpp  
  kinit/kwrapper.cpp d43ffc7 
  kinit/kwrapper_win.cpp  
  kinit/proctitle.h  
  kinit/proctitle.cpp  
  kinit/shell.cpp ccb42ed 
  kinit/start_kdeinit.c  
  kinit/start_kdeinit_wrapper.c  
  kinit/wrapper.cpp  
  kioslave/http/CMakeLists.txt 5dfcbce 
  staging/CMakeLists.txt 5c5c80c 
  staging/kinit/CMakeLists.txt PRE-CREATION 
  staging/kinit/KInitMacros.cmake PRE-CREATION 
  staging/kinit/src/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/kdeinit/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/kioslave/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/klauncher/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/kshell/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/kwrapper/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/start_kdeinit/CMakeLists.txt PRE-CREATION 
  tier1/kwindowsystem/src/CMakeLists.txt 00c92de 

Diff: http://git.reviewboard.kde.org/r/113097/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113097: KInit splitting

2013-10-07 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113097/#review41335
---


This review has been submitted with commit 
f9ded0fbc44c851c9a46149ead8f89098516f24b by Aleix Pol to branch frameworks.

- Commit Hook


On Oct. 4, 2013, 2:48 p.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113097/
 ---
 
 (Updated Oct. 4, 2013, 2:48 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Adapts KInit to be moved to its tier, there's still work to do.
 
 The most important change is the creation of a new KF5_ADD_KDEINIT_EXECUTABLE 
 macro.
 Also I reorganized the source code in different directories, so it's easier 
 to figure out.
 
 
 Diffs
 -
 
   CMakeLists.txt 3204c11 
   KDE5PORTING.html 88700b0 
   cmake/modules/kde4init_dummy.cpp.in  
   cmake/modules/kde4init_win32lib_dummy.cpp.in 0aa704b 
   kded/CMakeLists.txt 5a09a3a 
   kinit/CMakeLists.txt 2e26d91 
   kinit/ConfigureChecks.cmake  
   kinit/Info.plist.template  
   kinit/Mainpage.dox  
   kinit/README  
   kinit/README.autostart  
   kinit/README.wrapper  
   kinit/autostart.h  
   kinit/autostart.cpp  
   kinit/config-kdeinit.h.cmake  
   kinit/kinit.cpp  
   kinit/kinit_win.cpp  
   kinit/kioslave.cpp  
   kinit/klauncher.h  
   kinit/klauncher.cpp  
   kinit/klauncher_adaptor.h  
   kinit/klauncher_adaptor.cpp  
   kinit/klauncher_cmds.h  
   kinit/klauncher_cmds.cpp  
   kinit/klauncher_main.cpp  
   kinit/kwrapper.cpp d43ffc7 
   kinit/kwrapper_win.cpp  
   kinit/proctitle.h  
   kinit/proctitle.cpp  
   kinit/shell.cpp ccb42ed 
   kinit/start_kdeinit.c  
   kinit/start_kdeinit_wrapper.c  
   kinit/wrapper.cpp  
   kioslave/http/CMakeLists.txt 5dfcbce 
   staging/CMakeLists.txt 5c5c80c 
   staging/kinit/CMakeLists.txt PRE-CREATION 
   staging/kinit/KInitMacros.cmake PRE-CREATION 
   staging/kinit/src/CMakeLists.txt PRE-CREATION 
   staging/kinit/src/kdeinit/CMakeLists.txt PRE-CREATION 
   staging/kinit/src/kioslave/CMakeLists.txt PRE-CREATION 
   staging/kinit/src/klauncher/CMakeLists.txt PRE-CREATION 
   staging/kinit/src/kshell/CMakeLists.txt PRE-CREATION 
   staging/kinit/src/kwrapper/CMakeLists.txt PRE-CREATION 
   staging/kinit/src/start_kdeinit/CMakeLists.txt PRE-CREATION 
   tier1/kwindowsystem/src/CMakeLists.txt 00c92de 
 
 Diff: http://git.reviewboard.kde.org/r/113097/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113142: Move KPty to tier 3

2013-10-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113142/#review41337
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Oct. 7, 2013, 11:04 a.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113142/
 ---
 
 (Updated Oct. 7, 2013, 11:04 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Move KPty to tier 3
 
 
 Diffs
 -
 
   CMakeLists.txt 6a6b5f5 
   kpty/CMakeLists.txt  
   kpty/KPtyConfig.cmake.in  
   kpty/Mainpage.dox  
   kpty/src/CMakeLists.txt  
   kpty/src/ConfigureChecks.cmake  
   kpty/src/config-pty.h.cmake  
   kpty/src/kgrantpty.c  
   kpty/src/kpty.h  
   kpty/src/kpty.cpp  
   kpty/src/kpty_p.h  
   kpty/src/kptydevice.h  
   kpty/src/kptydevice.cpp  
   kpty/src/kptyprocess.h  
   kpty/src/kptyprocess.cpp  
   kpty/tests/CMakeLists.txt  
   kpty/tests/kptyprocesstest.h  
   kpty/tests/kptyprocesstest.cpp  
   tier3/CMakeLists.txt 53fe81b 
 
 Diff: http://git.reviewboard.kde.org/r/113142/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David Edmundson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-07 Thread Aurélien Gâteau


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113076/
---

(Updated Oct. 7, 2013, 2:47 p.m.)


Review request for KDE Frameworks and John Layt.


Changes
---

Simplified the code: reading the RFC shows there is no need to handle timezones.

See http://tools.ietf.org/html/rfc2616#section-3.3.1

Relevant quote:

All HTTP date/time stamps MUST be represented in Greenwich Mean Time
   (GMT), without exception. For the purposes of HTTP, GMT is exactly
   equal to UTC (Coordinated Universal Time). This is indicated in the
   first two formats by the inclusion of GMT as the three-letter
   abbreviation for time zone, and MUST be assumed when reading the
   asctime format. HTTP-date is case sensitive and MUST NOT include
   additional LWS beyond that specifically included as SP in the
   grammar.

   HTTP-date= rfc1123-date | rfc850-date | asctime-date
   rfc1123-date = wkday , SP date1 SP time SP GMT
   rfc850-date  = weekday , SP date2 SP time SP GMT
   asctime-date = wkday SP date3 SP time SP 4DIGIT


Repository: kdelibs


Description
---

This fixes kcookiejartest, which was failing to parse the date from the Y2K38 
check.

The test started failing on build.kde.org when the Qt version here was switched 
to the stable branch, which seems to parse things differently than the 
version of Qt build.kde.org used to run.

The code was ported from KDateTime::fromString() to QDateTime::fromString(), 
whose syntax for date formatting is different, but the format was not updated.

This patch is incomplete, see the FIXME comments in removeTimeZone(). But I 
want to ensure this is the correct way to go before getting into timezones.


Diffs (updated)
-

  kioslave/http/kcookiejar/kcookiejar.cpp e943da9 

Diff: http://git.reviewboard.kde.org/r/113076/diff/


Testing
---

kcookiejartest now passes again (must be run with LANG=C btw)


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113142: Move KPty to tier 3

2013-10-07 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113142/
---

(Updated Oct. 7, 2013, 12:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Move KPty to tier 3


Diffs
-

  CMakeLists.txt 6a6b5f5 
  kpty/CMakeLists.txt  
  kpty/KPtyConfig.cmake.in  
  kpty/Mainpage.dox  
  kpty/src/CMakeLists.txt  
  kpty/src/ConfigureChecks.cmake  
  kpty/src/config-pty.h.cmake  
  kpty/src/kgrantpty.c  
  kpty/src/kpty.h  
  kpty/src/kpty.cpp  
  kpty/src/kpty_p.h  
  kpty/src/kptydevice.h  
  kpty/src/kptydevice.cpp  
  kpty/src/kptyprocess.h  
  kpty/src/kptyprocess.cpp  
  kpty/tests/CMakeLists.txt  
  kpty/tests/kptyprocesstest.h  
  kpty/tests/kptyprocesstest.cpp  
  tier3/CMakeLists.txt 53fe81b 

Diff: http://git.reviewboard.kde.org/r/113142/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113142: Move KPty to tier 3

2013-10-07 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113142/#review41342
---


This review has been submitted with commit 
7d0570f639cadcbea79c9f0ff90268f5fe745e4b by David Edmundson to branch 
frameworks.

- Commit Hook


On Oct. 7, 2013, 11:04 a.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113142/
 ---
 
 (Updated Oct. 7, 2013, 11:04 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Move KPty to tier 3
 
 
 Diffs
 -
 
   CMakeLists.txt 6a6b5f5 
   kpty/CMakeLists.txt  
   kpty/KPtyConfig.cmake.in  
   kpty/Mainpage.dox  
   kpty/src/CMakeLists.txt  
   kpty/src/ConfigureChecks.cmake  
   kpty/src/config-pty.h.cmake  
   kpty/src/kgrantpty.c  
   kpty/src/kpty.h  
   kpty/src/kpty.cpp  
   kpty/src/kpty_p.h  
   kpty/src/kptydevice.h  
   kpty/src/kptydevice.cpp  
   kpty/src/kptyprocess.h  
   kpty/src/kptyprocess.cpp  
   kpty/tests/CMakeLists.txt  
   kpty/tests/kptyprocesstest.h  
   kpty/tests/kptyprocesstest.cpp  
   tier3/CMakeLists.txt 53fe81b 
 
 Diff: http://git.reviewboard.kde.org/r/113142/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David Edmundson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1365

2013-10-07 Thread KDE CI System

See http://build.kde.org/job/kdelibs_frameworks_qt5/1365/changes

Changes:

[me] KRoss: Camel case the library names

[me] Kross: Follow frameworks directory scheme

[me] Kross: Add CMake stuff along with KrossConfig.cmake

[me] Kross: Install the plugins in the QT_PLULGIN_INSTALL_DIR

[me] Kross: Add feature_summary

[me] Kross: Do not set EXECUTABLE_OUTPUT_PATH

[me] Kross: Remove module name from the header includes

--
[...truncated 4561 lines...]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘Keyboard’ not handled in switch [-Wswitch]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘PointingDevice’ not handled in switch [-Wswitch]
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksblock.h:25:0,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksstoragevolume.h:25,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksstoragevolume.cpp:22:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:
 In static member function ‘static QStringList 
Solid::Backends::UDisks2::DeviceInterface::toStringList(Solid::DeviceInterface::Type)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘Keyboard’ not handled in switch [-Wswitch]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘PointingDevice’ not handled in switch [-Wswitch]
[ 37%] [ 37%] [ 37%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udisks2/udisksopticaldisc.cpp.o
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.cpp:21:0:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:
 In static member function ‘static QStringList 
Solid::Backends::UDisks2::DeviceInterface::toStringList(Solid::DeviceInterface::Type)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘Keyboard’ not handled in switch [-Wswitch]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘PointingDevice’ not handled in switch [-Wswitch]
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udisks2/udisksstoragevolume.cpp.o
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksblock.h:25:0,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksblock.cpp:28:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:
 In static member function ‘static QStringList 
Solid::Backends::UDisks2::DeviceInterface::toStringList(Solid::DeviceInterface::Type)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘Keyboard’ not handled in switch [-Wswitch]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘PointingDevice’ not handled in switch [-Wswitch]
[ 37%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udisks2/udisksdeviceinterface.cpp.o
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdevicebackend.cpp:196:6:
 warning: unused parameter ‘ifaceName’ [-Wunused-parameter]
[ 37%] [ 37%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udisks2/udisksopticaldrive.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udisks2/udisksstoragedrive.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udisks2/udisksopticaldisc.cpp.o
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksblock.h:25:0,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksstoragevolume.h:25,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.h:29,
 from

Re: Review Request 113112: Notify about palette changes

2013-10-07 Thread Àlex Fiestas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113112/#review41346
---

Ship it!


Awesome, good to go.

- Àlex Fiestas


On Oct. 7, 2013, 12:20 p.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113112/
 ---
 
 (Updated Oct. 7, 2013, 12:20 p.m.)
 
 
 Review request for KDE Frameworks, Àlex Fiestas and Sebastian Kügler.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Make sure the application can react to changes in the application's defaults 
 regarding palette, when using the kde platform plugin.
 
 
 Diffs
 -
 
   staging/frameworkintegration/autotests/kdeplatformtheme_unittest.cpp 
 417e9e1 
   staging/frameworkintegration/src/platformtheme/khintssettings.cpp 5d5bf82 
 
 Diff: http://git.reviewboard.kde.org/r/113112/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Àlex Fiestas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Moved KBuildsyscoca to KService.

I have done the moving and the cleaning in different commits, just unified them 
for reviewboard.


Diffs
-

  kded/CMakeLists.txt 4f9133f 
  kded/applications.menu  
  kded/kbuildmimetypefactory.h  
  kded/kbuildmimetypefactory.cpp 2e81ce7 
  kded/kbuildservicefactory.h  
  kded/kbuildservicefactory.cpp 971f327 
  kded/kbuildservicegroupfactory.h  
  kded/kbuildservicegroupfactory.cpp 5485b1c 
  kded/kbuildservicetypefactory.h  
  kded/kbuildservicetypefactory.cpp f473cd6 
  kded/kbuildsycoca.h  
  kded/kbuildsycoca.cpp 8ea2d2e 
  kded/kbuildsycocainterface.h  
  kded/kctimefactory.h  
  kded/kctimefactory.cpp  
  kded/kmimeassociations.h  
  kded/kmimeassociations.cpp  
  kded/ksycocaresourcelist.h  
  kded/tests/CMakeLists.txt ca392d2 
  kded/tests/kmimeassociationstest.cpp  
  kded/vfolder_menu.h  
  kded/vfolder_menu.cpp  
  staging/kservice/CMakeLists.txt b244731 
  staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
  staging/kservice/tests/CMakeLists.txt 23d4854 

Diff: http://git.reviewboard.kde.org/r/113148/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1366

2013-10-07 Thread KDE CI System

See http://build.kde.org/job/kdelibs_frameworks_qt5/1366/changes

Changes:

[mklapetek] Build KDESu only on UNIX together with KPty

--
[...truncated 4556 lines...]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘Keyboard’ not handled in switch [-Wswitch]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘PointingDevice’ not handled in switch [-Wswitch]
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksblock.h:25:0,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksblock.cpp:28:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:
 In static member function ‘static QStringList 
Solid::Backends::UDisks2::DeviceInterface::toStringList(Solid::DeviceInterface::Type)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘Keyboard’ not handled in switch [-Wswitch]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘PointingDevice’ not handled in switch [-Wswitch]
[ 37%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udisks2/udisksstoragevolume.cpp.o
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksblock.h:25:0,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksstoragevolume.h:25,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksstoragevolume.cpp:22:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:
 In static member function ‘static QStringList 
Solid::Backends::UDisks2::DeviceInterface::toStringList(Solid::DeviceInterface::Type)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘Keyboard’ not handled in switch [-Wswitch]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘PointingDevice’ not handled in switch [-Wswitch]
[ 37%] [ 37%] [ 37%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udisks2/udisksdeviceinterface.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udisks2/udisksstoragevolume.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udisks2/udisksdeviceinterface.cpp.o
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.cpp:21:0:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:
 In static member function ‘static QStringList 
Solid::Backends::UDisks2::DeviceInterface::toStringList(Solid::DeviceInterface::Type)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘Keyboard’ not handled in switch [-Wswitch]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘PointingDevice’ not handled in switch [-Wswitch]
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.cpp:21:0:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:
 In static member function ‘static QStringList 
Solid::Backends::UDisks2::DeviceInterface::toStringList(Solid::DeviceInterface::Type)’:
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘Keyboard’ not handled in switch [-Wswitch]
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h:53:15:
 warning: enumeration value ‘PointingDevice’ not handled in switch [-Wswitch]
In file included from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksblock.h:25:0,
 from 
http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/solid/src/solid/backends/udisks2/udisksstoragevolume.h:25,
 from

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41351
---



kded/kbuildsycoca.cpp
http://git.reviewboard.kde.org/r/113148/#comment30273

Maybe it could be removed?



kded/kbuildsycoca.cpp
http://git.reviewboard.kde.org/r/113148/#comment30274

What happens with this?


- Aleix Pol Gonzalez


On Oct. 7, 2013, 2:43 p.m., Àlex Fiestas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113148/
 ---
 
 (Updated Oct. 7, 2013, 2:43 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Moved KBuildsyscoca to KService.
 
 I have done the moving and the cleaning in different commits, just unified 
 them for reviewboard.
 
 
 Diffs
 -
 
   kded/CMakeLists.txt 4f9133f 
   kded/applications.menu  
   kded/kbuildmimetypefactory.h  
   kded/kbuildmimetypefactory.cpp 2e81ce7 
   kded/kbuildservicefactory.h  
   kded/kbuildservicefactory.cpp 971f327 
   kded/kbuildservicegroupfactory.h  
   kded/kbuildservicegroupfactory.cpp 5485b1c 
   kded/kbuildservicetypefactory.h  
   kded/kbuildservicetypefactory.cpp f473cd6 
   kded/kbuildsycoca.h  
   kded/kbuildsycoca.cpp 8ea2d2e 
   kded/kbuildsycocainterface.h  
   kded/kctimefactory.h  
   kded/kctimefactory.cpp  
   kded/kmimeassociations.h  
   kded/kmimeassociations.cpp  
   kded/ksycocaresourcelist.h  
   kded/tests/CMakeLists.txt ca392d2 
   kded/tests/kmimeassociationstest.cpp  
   kded/vfolder_menu.h  
   kded/vfolder_menu.cpp  
   staging/kservice/CMakeLists.txt b244731 
   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
   staging/kservice/tests/CMakeLists.txt 23d4854 
 
 Diff: http://git.reviewboard.kde.org/r/113148/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Àlex Fiestas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Aurélien Gâteau


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41352
---



staging/kservice/kbuildsycoca/CMakeLists.txt
http://git.reviewboard.kde.org/r/113148/#comment30275

You probably want to update this comment :)


- Aurélien Gâteau


On Oct. 7, 2013, 4:43 p.m., Àlex Fiestas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113148/
 ---
 
 (Updated Oct. 7, 2013, 4:43 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Moved KBuildsyscoca to KService.
 
 I have done the moving and the cleaning in different commits, just unified 
 them for reviewboard.
 
 
 Diffs
 -
 
   kded/CMakeLists.txt 4f9133f 
   kded/applications.menu  
   kded/kbuildmimetypefactory.h  
   kded/kbuildmimetypefactory.cpp 2e81ce7 
   kded/kbuildservicefactory.h  
   kded/kbuildservicefactory.cpp 971f327 
   kded/kbuildservicegroupfactory.h  
   kded/kbuildservicegroupfactory.cpp 5485b1c 
   kded/kbuildservicetypefactory.h  
   kded/kbuildservicetypefactory.cpp f473cd6 
   kded/kbuildsycoca.h  
   kded/kbuildsycoca.cpp 8ea2d2e 
   kded/kbuildsycocainterface.h  
   kded/kctimefactory.h  
   kded/kctimefactory.cpp  
   kded/kmimeassociations.h  
   kded/kmimeassociations.cpp  
   kded/ksycocaresourcelist.h  
   kded/tests/CMakeLists.txt ca392d2 
   kded/tests/kmimeassociationstest.cpp  
   kded/vfolder_menu.h  
   kded/vfolder_menu.cpp  
   staging/kservice/CMakeLists.txt b244731 
   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
   staging/kservice/tests/CMakeLists.txt 23d4854 
 
 Diff: http://git.reviewboard.kde.org/r/113148/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Àlex Fiestas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #789

2013-10-07 Thread KDE CI System

See http://build.kde.org/job/plasma-framework_master_qt5/789/

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace 
http://build.kde.org/job/plasma-framework_master_qt5/ws/
Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson3885755524143216639.sh
+ /home/jenkins/scripts/setup-env.sh
The --set-upstream flag is deprecated and will be removed. Consider using 
--track or --set-upstream-to
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@33831f4c
Checkout:plasma-framework_master_qt5 / 
http://build.kde.org/job/plasma-framework_master_qt5/ws/ - 
hudson.remoting.Channel@604f2d14:LinuxSlave - 3
Using strategy: Default
Last Built Revision: Revision 1757ef8899d193fcc090872c5f60b9921ad1796b 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 1757ef8899d193fcc090872c5f60b9921ad1796b 
(refs/heads/jenkins)
Checking out Revision 1757ef8899d193fcc090872c5f60b9921ad1796b 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson5251332670566450627.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 kdelibs - Branch frameworks
 libstreams - Branch master
 extra-cmake-modules - Branch master
 qt5 - Branch stable
 phonon - Branch master
 libstreamanalyzer - Branch master
 attica - Branch master
 strigidaemon - Branch master
 strigiclient - Branch master
 strigiutils - Branch master

== Cleaning Source Tree

HEAD is now at 1757ef8 Reverse accidental change
Removing build/
Removing install/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
CMake Error at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/find-modules/FindKF5.cmake:136
 (message):
  KF5: requested unknown components KIO
Call Stack (most recent call first):
  CMakeLists.txt:51 (find_package)


-- Configuring incomplete, errors occurred!
See also 
http://build.kde.org/job/plasma-framework_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;.
Configure step exited with non-zero code, assuming failure to configure for 
project plasma-framework.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Skipping Cobertura coverage report as build was not UNSTABLE or better ...
Recording test results
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting Minutes 2013-w40

2013-10-07 Thread Àlex Fiestas

These are the minutes of the Week 40 KF5 meeting. As usual it has been held on 
#kde-devel at 4pm Barcelona (CEST / UTC+2) time.

Present on the meeting: vhanda, teo-, agateau, apol, steveire, d_ed, dfaure, 
mck1982, Sho, shadeslayer, sebas, mgrasslin and afiestas.

Topics discussed:
*vHanda: Moved kio test to their respective places.
*vHanda: Removed KFileMetadataWidget.
*vHanda: kio/kssl won't be split.

*teo-: Finished KencodingFileDialog.
*teo-: Created test for KEncodingFileDIalog.

*agateau: KConfigWidgets ready to move to tier3.
*agateau: Created CMake template for Frameworks.
*agateau: Fixing frameworks tests (only one in kglobalaccel remaning).
*agateau: Waiting for review in kinterprocesswindowing 
(https://git.reviewboard.kde.org/r/112966/).

*apol: KParts has been split.
*apol: KDEWebkit has been split.
*apol: KDNSSD has been split.
*apol: Waiting for review in some CMake stuff and KStringHandler.

*steveire: Brought up some problems with branch names.

*d_ed: Got QLineEdit ctrl+u/e overwrite patch into Qt.
*d_ed: KCMUtils ready to move to a tier.
*d_ed: Fixes in KHTML.

*dfaure: Looking at kio/kfile/kbookmarks dependency problems. At the moment 
got. rid of KRun dependency in KBookmarks. KIO::iconNameForUrl is next.
*dfaure: Will finish KFIle move.

*mck182: Moved KPrintDialog into KPrintUtils.
*mck182: Added test to KPrintUtils.
*mck182: KDESu has been split.

*Sho: Investigating a problem in KWindowSystem.

*shadeslayer: Needs help with KDialogJobUiDelegate.

*sebas: What do we do with dbusmenu-qt ?
*sebas: Kpluginverification has been removed.
*sebas: Working on systemtray port / rewrite: a lot of work to be done.

*mgrasslin: Ported SystemSettings to Qt5/KF5.

*afiestas: Finished splitting KIconThemes.
*afiestas: Finished splitting XMLGui.

If you got questions, feel free to ask.

Cheers !

Ps: Sorry for the delay on sending this.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Àlex Fiestas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/
---

(Updated Oct. 7, 2013, 3:21 p.m.)


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Moved KBuildsyscoca to KService.

I have done the moving and the cleaning in different commits, just unified them 
for reviewboard.


Diffs (updated)
-

  kded/CMakeLists.txt 4f9133f 
  kded/applications.menu  
  kded/kbuildmimetypefactory.h  
  kded/kbuildmimetypefactory.cpp 2e81ce7 
  kded/kbuildservicefactory.h  
  kded/kbuildservicefactory.cpp 971f327 
  kded/kbuildservicegroupfactory.h  
  kded/kbuildservicegroupfactory.cpp 5485b1c 
  kded/kbuildservicetypefactory.h  
  kded/kbuildservicetypefactory.cpp f473cd6 
  kded/kbuildsycoca.h  
  kded/kbuildsycoca.cpp 8ea2d2e 
  kded/kbuildsycocainterface.h  
  kded/kctimefactory.h  
  kded/kctimefactory.cpp  
  kded/kmimeassociations.h  
  kded/kmimeassociations.cpp  
  kded/ksycocaresourcelist.h  
  kded/tests/CMakeLists.txt ca392d2 
  kded/tests/kmimeassociationstest.cpp  
  kded/vfolder_menu.h  
  kded/vfolder_menu.cpp  
  staging/kservice/CMakeLists.txt b244731 
  staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
  staging/kservice/tests/CMakeLists.txt 23d4854 

Diff: http://git.reviewboard.kde.org/r/113148/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

2013-10-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113149/
---

(Updated Oct. 7, 2013, 3:24 p.m.)


Review request for Build System, KDE Frameworks and Sebastian Kügler.


Changes
---

I forgot to add the Config.cmake files


Repository: kdelibs


Description
---

There are some KF5 frameworks that are used through cmake macros instead of by 
linking to its libraries. These frameworks install a Macros.cmake file that 
adds the tools needed to use them. It's not really possible to include those 
Macros files from other projects at the moment.

This patch adds a Config file so these include files can be found using 
find_package (which is the standard way of finding a framework anyway)


Diffs (updated)
-

  staging/kinit/CMakeLists.txt 10c226c 
  staging/kinit/KInitConfig.cmake PRE-CREATION 
  tier2/kdoctools/CMakeLists.txt a74ef92 
  tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113149/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

2013-10-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113149/
---

(Updated Oct. 7, 2013, 3:29 p.m.)


Review request for Build System, KDE Frameworks and Sebastian Kügler.


Changes
---

Properly find the Macros.cmake files


Repository: kdelibs


Description
---

There are some KF5 frameworks that are used through cmake macros instead of by 
linking to its libraries. These frameworks install a Macros.cmake file that 
adds the tools needed to use them. It's not really possible to include those 
Macros files from other projects at the moment.

This patch adds a Config file so these include files can be found using 
find_package (which is the standard way of finding a framework anyway)


Diffs (updated)
-

  staging/kinit/CMakeLists.txt 10c226c 
  staging/kinit/KInitConfig.cmake PRE-CREATION 
  tier2/kdoctools/CMakeLists.txt a74ef92 
  tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113149/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: EcmQt4To5Porting

2013-10-07 Thread Martin Graesslin

On Friday 04 October 2013 10:51:07 Martin Klapetek wrote:
 On Fri, Oct 4, 2013 at 9:22 AM, David Faure fa...@kde.org wrote:
  On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote:
   There were 2 files recently removed from ECM which broke attica's build,
   this puts the removed files as local cmake modules.
   
   
   Diffs
   -
   
 CMakeLists.txt e0efb9b
 cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION
 cmake/modules/FindQt5Transitional.cmake PRE-CREATION
  
  I'm confused. Why have they been removed from ECM?
  (and where was this explained/announced).
 
 I only found out because Attica failed to build for me, so I investigated
 and notified Stephen, he suggested to either copy the files over or do it
 properly as explained in his following email. Being unfamiliar with Attica
 completely, I chose the easier way.
It's not just libattica which failed, but also for example libdbusmenu-qt:

CMake Error at CMakeLists.txt:53 (find_package):
  By not providing FindQt5Transitional.cmake in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  Qt5Transitional, but CMake did not find one.

  Could not find a package configuration file provided by Qt5Transitional
  with any of the following names:

Qt5TransitionalConfig.cmake
qt5transitional-config.cmake

  Add the installation prefix of Qt5Transitional to CMAKE_PREFIX_PATH or
  set Qt5Transitional_DIR to a directory containing one of the above files.
  If Qt5Transitional provides a separate development package or SDK, be
  sure it has been installed.

 
 I too, however, would appreciate these breaking changes to be at least
 announced on this list.
+1000, I think we can do much better to prevent that developers struggle to 
get their build fixed again.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113077: Get Kross ready for tier3

2013-10-07 Thread Martin Gräßlin



 On Oct. 7, 2013, 4:38 p.m., Martin Gräßlin wrote:
  You broke the build (and forgot to include the REVIEW tag ;-):
  [ 41%] Building CXX object 
  kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o
  In file included from 
  /home/martin/kf5/src/kdelibs-frameworks/kross/src/core/krossconfig.cpp:20:0:
  /home/martin/kf5/src/kdelibs-frameworks/kross/src/core/krossconfig.h:23:41: 
  fatal error: kross/core/krosscore_export.h: No such file or directory
   #include kross/core/krosscore_export.h
   ^
  compilation terminated.
  make[2]: *** [kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o] 
  Error 1
  make[1]: *** [kross/src/core/CMakeFiles/KrossCore.dir/all] Error 2

seems like Kevin already fixed it


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113077/#review41350
---


On Oct. 3, 2013, 6:09 p.m., Vishesh Handa wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113077/
 ---
 
 (Updated Oct. 3, 2013, 6:09 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 This patch makes kross ready for moving to tier3. The changes were done in a 
 separate branch (which I can push if required). The git log looks like this -
 
 783b0a3 Kross: Remove module name from the header includes
 8b7ac05 Kross: Do not set EXECUTABLE_OUTPUT_PATH
 6c62ace Kross: Add feature_summary
 d9b63be Kross: Install the plugins in the QT_PLULGIN_INSTALL_DIR
 2c627df Kross: Add CMake stuff along with KrossConfig.cmake
 a28624b Kross: Follow frameworks directory scheme
 741b86c KRoss: Camel case the library names
 
 Kross does not have any unit tests, and some of its normal tests seem to be 
 segfaulting as well. I'm not sure what to do about that. Also when Kross is 
 being split, its other plugins will needs to be added as well. Kdelibs only 
 contains the kjs and QtScript plugins.
 
 And finally, the QtScript plugin has a test - Should that be moved to the 
 tests folder?
 
 
 Diffs
 -
 
   kross/CMakeLists.txt 3424cb8 
   kross/KrossConfig.cmake.in PRE-CREATION 
   kross/console/CMakeLists.txt da73a6f 
   kross/console/main.cpp  
   kross/core/CMakeLists.txt 5a8b845 
   kross/core/action.h 3f4d985 
   kross/core/action.cpp 5c6ee2c 
   kross/core/actioncollection.h 9e90df6 
   kross/core/actioncollection.cpp 89d8282 
   kross/core/childreninterface.h 0b11b2e 
   kross/core/errorinterface.h bb23235 
   kross/core/interpreter.h 95293e4 
   kross/core/interpreter.cpp  
   kross/core/krossconfig.h 481c4b6 
   kross/core/krossconfig.cpp  
   kross/core/manager.h aefdf87 
   kross/core/manager.cpp e0dddf1 
   kross/core/metafunction.h 1413289 
   kross/core/metatype.h 08f7c6c 
   kross/core/object.h 6f2b6a4 
   kross/core/object.cpp  
   kross/core/script.h 1701883 
   kross/core/script.cpp  
   kross/core/wrapperinterface.h  
   kross/kjs/CMakeLists.txt 94af9ae 
   kross/kjs/kjsinterpreter.h  
   kross/kjs/kjsinterpreter.cpp  
   kross/kjs/kjsscript.h  
   kross/kjs/kjsscript.cpp  
   kross/modules/CMakeLists.txt 7391bb0 
   kross/modules/form.h 2da62c7 
   kross/modules/form.cpp 862b71b 
   kross/modules/translation.h  
   kross/modules/translation.cpp  
   kross/qts/CMakeLists.txt b85c1c7 
   kross/qts/interpreter.h  
   kross/qts/interpreter.cpp  
   kross/qts/main.cpp  
   kross/qts/plugin.h  
   kross/qts/plugin.cpp  
   kross/qts/script.h  
   kross/qts/script.cpp  
   kross/qts/test.es  
   kross/qts/values_p.h  
   kross/src/CMakeLists.txt PRE-CREATION 
   kross/src/modules/CMakeLists.txt PRE-CREATION 
   kross/test/CMakeLists.txt c931ec4 
   kross/test/main.cpp da926fb 
   kross/test/profile.py  
   kross/test/testguiform.py  
   kross/test/testguiform.rb  
   kross/test/testguiform.ui  
   kross/test/testguiqt.py  
   kross/test/testguiqt.rb  
   kross/test/testguitk.py  
   kross/test/testkross.js  
   kross/test/testkross.py  
   kross/test/testobject.h 5383073 
   kross/test/testobject.cpp 560d88c 
   kross/test/unittest.es  
   kross/test/unittest.js  
   kross/test/unittest.py  
   kross/test/unittest.rb  
   kross/ui/CMakeLists.txt 14ba2d8 
   kross/ui/model.h 314ff24 
   kross/ui/model.cpp 4849149 
   kross/ui/plugin.h  
   kross/ui/plugin.cpp  
   kross/ui/view.h 4241aad 
   kross/ui/view.cpp  
 
 Diff: http://git.reviewboard.kde.org/r/113077/diff/
 
 
 Testing
 ---
 
 Some tests segfault. Some of them run. I should probably convert them into 
 autotests.
 
 
 Thanks,
 
 Vishesh Handa
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

2013-10-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113149/
---

(Updated Oct. 7, 2013, 3:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, KDE Frameworks and Sebastian Kügler.


Repository: kdelibs


Description
---

There are some KF5 frameworks that are used through cmake macros instead of by 
linking to its libraries. These frameworks install a Macros.cmake file that 
adds the tools needed to use them. It's not really possible to include those 
Macros files from other projects at the moment.

This patch adds a Config file so these include files can be found using 
find_package (which is the standard way of finding a framework anyway)


Diffs
-

  staging/kinit/CMakeLists.txt 10c226c 
  staging/kinit/KInitConfig.cmake PRE-CREATION 
  tier2/kdoctools/CMakeLists.txt a74ef92 
  tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113149/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

2013-10-07 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113149/#review41356
---


This review has been submitted with commit 
222fa49d91bb24a630459af409247c56ae02ea46 by Aleix Pol to branch frameworks.

- Commit Hook


On Oct. 7, 2013, 3:29 p.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113149/
 ---
 
 (Updated Oct. 7, 2013, 3:29 p.m.)
 
 
 Review request for Build System, KDE Frameworks and Sebastian Kügler.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 There are some KF5 frameworks that are used through cmake macros instead of 
 by linking to its libraries. These frameworks install a Macros.cmake file 
 that adds the tools needed to use them. It's not really possible to include 
 those Macros files from other projects at the moment.
 
 This patch adds a Config file so these include files can be found using 
 find_package (which is the standard way of finding a framework anyway)
 
 
 Diffs
 -
 
   staging/kinit/CMakeLists.txt 10c226c 
   staging/kinit/KInitConfig.cmake PRE-CREATION 
   tier2/kdoctools/CMakeLists.txt a74ef92 
   tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION 
 
 Diff: http://git.reviewboard.kde.org/r/113149/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Failing Tests in Kross

2013-10-07 Thread Vishesh Handa

Hey Sebastian

I had taken up the task of moving Kross to tier3, and I noticed that most 
tests (11/12) are failing.

The following tests FAILED:
  1 - kross-guiform-py (Failed)
  2 - kross-guiform-rb (Failed)
  3 - kross-guiqt-py (Failed)
  4 - kross-guiqt-rb (Failed)
  5 - kross-guitk-py (Failed)
  7 - kross-test-py (Failed)
  8 - kross-unittest-es (SEGFAULT)
  9 - kross-unittest-js (SEGFAULT)
 10 - kross-unittest-py (Failed)
 11 - kross-unittest-rb (Failed)

The test in the qts plugin also segfaults. The python and ruby tests fail 
because of the missing kross plugin. However the js/es ones seem to segault. 
Do you think you could have a look at them? I'm not comfortable moving it to 
tier3 with failing tests.

There also seems to be a .ui file in the tests directory, which I'm not sure 
how to run.

When Kross moves to its own git repo we should probably move the ruby and 
python plugin in it as well.

Also, can I add a MAINTAINERS file with your name in it?

-- 
Vishesh Handa
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Àlex Fiestas



 On Oct. 7, 2013, 2:47 p.m., Aleix Pol Gonzalez wrote:
  kded/kbuildsycoca.cpp, line 48
  http://git.reviewboard.kde.org/r/113148/diff/1/?file=199659#file199659line48
 
  What happens with this?
 
 Àlex Fiestas wrote:
 I vote for removing it, any objections ?

Plus I forgot to move some code that sets this in case 
KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION is set. Will wait 
until David comment on this to either move it or simply remove it.


- Àlex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41351
---


On Oct. 7, 2013, 3:21 p.m., Àlex Fiestas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113148/
 ---
 
 (Updated Oct. 7, 2013, 3:21 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Moved KBuildsyscoca to KService.
 
 I have done the moving and the cleaning in different commits, just unified 
 them for reviewboard.
 
 
 Diffs
 -
 
   kded/CMakeLists.txt 4f9133f 
   kded/applications.menu  
   kded/kbuildmimetypefactory.h  
   kded/kbuildmimetypefactory.cpp 2e81ce7 
   kded/kbuildservicefactory.h  
   kded/kbuildservicefactory.cpp 971f327 
   kded/kbuildservicegroupfactory.h  
   kded/kbuildservicegroupfactory.cpp 5485b1c 
   kded/kbuildservicetypefactory.h  
   kded/kbuildservicetypefactory.cpp f473cd6 
   kded/kbuildsycoca.h  
   kded/kbuildsycoca.cpp 8ea2d2e 
   kded/kbuildsycocainterface.h  
   kded/kctimefactory.h  
   kded/kctimefactory.cpp  
   kded/kmimeassociations.h  
   kded/kmimeassociations.cpp  
   kded/ksycocaresourcelist.h  
   kded/tests/CMakeLists.txt ca392d2 
   kded/tests/kmimeassociationstest.cpp  
   kded/vfolder_menu.h  
   kded/vfolder_menu.cpp  
   staging/kservice/CMakeLists.txt b244731 
   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
   staging/kservice/tests/CMakeLists.txt 23d4854 
 
 Diff: http://git.reviewboard.kde.org/r/113148/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Àlex Fiestas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-07 Thread Vishesh Handa


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113154/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Remove KFileMetaDataWidget and friends

These have been deprecated in KDE4.[1] This also removes the
KFileMetaPropsPlugin in the KPropertiesDialog - The code was commented
out so it doesn't really make a difference.

Eventually we will need a proper plugin based system so that the
Nepomuk2::FileMetadataWidget can be used in the KPropertiesDialog

[1] https://git.reviewboard.kde.org/r/113153/


Diffs
-

  staging/kde4support/src/CMakeLists.txt 5eb649c 
  staging/kde4support/src/kio/kcommentwidget.cpp 6223a0c 
  staging/kde4support/src/kio/kcommentwidget_p.h 7a9c710 
  staging/kde4support/src/kio/kfilemetadataconfigurationwidget.h 52735ad 
  staging/kde4support/src/kio/kfilemetadataconfigurationwidget.cpp 018d183 
  staging/kde4support/src/kio/kfilemetadataprovider.cpp 59cb238 
  staging/kde4support/src/kio/kfilemetadataprovider_p.h 0969f53 
  staging/kde4support/src/kio/kfilemetadatareader.cpp 6a7909c 
  staging/kde4support/src/kio/kfilemetadatareader_p.h af054c2 
  staging/kde4support/src/kio/kfilemetadatareaderprocess.cpp 0d2b993 
  staging/kde4support/src/kio/kfilemetadatawidget.h 31dd3c7 
  staging/kde4support/src/kio/kfilemetadatawidget.cpp 2df2312 
  staging/kde4support/src/kio/kmetaprops.h b03dd4c 
  staging/kde4support/src/kio/kmetaprops.cpp 46624c5 
  staging/kde4support/src/kio/knfotranslator.cpp 0494679 
  staging/kde4support/src/kio/knfotranslator_p.h ddbe4a1 
  staging/kio/src/widgets/kpropertiesdialog.cpp 63e4435 

Diff: http://git.reviewboard.kde.org/r/113154/diff/


Testing
---


Thanks,

Vishesh Handa

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

2013-10-07 Thread Vishesh Handa


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113153/
---

Review request for KDE Frameworks and kdelibs.


Repository: kdelibs


Description
---

They will no longer exist in KF5, and everyone should be using the
Nepomuk widgets instead.


Diffs
-

  kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d 
  kio/kfile/kfilemetadatawidget.h 50ddce9 

Diff: http://git.reviewboard.kde.org/r/113153/diff/


Testing
---


Thanks,

Vishesh Handa

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113155: Port all kde4_add_unit_test uses

2013-10-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113155/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Stop using kde4_add_unit_test.

One step less towards no kde4_* uses.


Diffs
-

  kded/tests/CMakeLists.txt ca392d2 
  kfile/tests/CMakeLists.txt d28d642 
  khtml/tests/CMakeLists.txt 0a404d5 
  kio/tests/CMakeLists.txt a60eac0 
  kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 
  kioslave/http/tests/CMakeLists.txt 000c488 

Diff: http://git.reviewboard.kde.org/r/113155/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: more build problems around KIO

2013-10-07 Thread Alexander Neundorf

On Monday 07 October 2013, Sebastian Kügler wrote:
 Hi,
 
 I'm still struggling to get kde-workspace (and kde-runtime) to build after
 Friday's changes. Following Kevin's change in plasma-framework, I've
 removed KIO from the KF5 imports. The problem is now:
 
 
 CMake Warning at
 /home/sebas/kf5/install/lib64/cmake/Kross/KrossConfig.cmake:31
 (find_package):
   By not providing FindKConfigCore.cmake in CMAKE_MODULE_PATH this
 project
   has asked CMake to find a package configuration file provided by
   KConfigCore, but CMake did not find one.
 
   Could not find a package configuration file provided by KConfigCore
 with
   any of the following names:


I recommend to add the MODULE or NO_MODULE keyword to the find_package() 
call, this way you get a better error message and the reader of the file knows 
what is expected, because both cmake and the reader (you) can see whether a 
FindKConfigCore.cmake or a KConfigCoreConfig.cmake file is expected.


 KConfigCoreConfig.cmake
 kconfigcore-config.cmake
 
   Add the installation prefix of KConfigCore to CMAKE_PREFIX_PATH or set
   KConfigCore_DIR to a directory containing one of the above files.  If
   KConfigCore provides a separate development package or SDK, be sure it
   has been installed.
 Call Stack (most recent call first):
   /home/sebas/kf5/install/lib64/cmake/Kross/KrossConfig.cmake:60
 (find_dependency)
   /home/sebas/kf5/install/share/ECM/find-modules/FindKF5.cmake:210
 (find_package)
   CMakeLists.txt:45 (find_package)
 
 
 CMake Warning at
 /home/sebas/kf5/install/lib64/cmake/Kross/KrossConfig.cmake:31
 (find_package):
   By not providing FindKIOWidgets.cmake in CMAKE_MODULE_PATH this project
   has asked CMake to find a package configuration file provided by
   KIOWidgets, but CMake did not find one.
 
   Could not find a package configuration file provided by KIOWidgets with
   any of the following names:
 
 KIOWidgetsConfig.cmake
 kiowidgets-config.cmake
 
   Add the installation prefix of KIOWidgets to CMAKE_PREFIX_PATH or set
   KIOWidgets_DIR to a directory containing one of the above files.  If
   KIOWidgets provides a separate development package or SDK, be sure it
 has
   been installed.
 Call Stack (most recent call first):
   /home/sebas/kf5/install/lib64/cmake/Kross/KrossConfig.cmake:62
 (find_dependency)
   /home/sebas/kf5/install/share/ECM/find-modules/FindKF5.cmake:210
 (find_package)
   CMakeLists.txt:45 (find_package)
 
 
 -- KF5[Kross]: Loaded
 /home/sebas/kf5/install/lib64/cmake/Kross/KrossConfig.cmake
 -- Found KF5:
 /home/sebas/kf5/install/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake} (found
 version 5.0.0) found components:  CMake Compiler InstallDirs KIdleTime
 ItemModels KWidgetsAddons KWindowSystem KCodecs KArchive KCoreAddons Solid
 ThreadWeaver KConfig KAuth KJS KWallet KDBusAddons Sonnet KI18n KGuiAddons
 KService KConfigWidgets ItemViews KNotifications KIconThemes KStyle
 KCompletion KJobWidgets KTextWidgets XmlGui KCrash KBookmarks
 KUnitConversion KDE4Attic KCMUtils Kross
 -- KF5[InstallDirs]: Loaded settings from
 /home/sebas/kf5/install/share/ECM/kde-modules/KDEInstallDirs.cmake
 -- Found KF5: /home/sebas/kf5/install/share/ECM/find-modules/FindKF5.cmake
 (found version 5.0.0) found components:  InstallDirs
 CMake Error at CMakeLists.txt:52 (find_package):
   Found package configuration file:
 

 /home/sebas/kf5/install/lib64/cmake/KDeclarative/KDeclarativeConfig.cmake
 
   but it set KDeclarative_FOUND to FALSE so package KDeclarative is
   considered to be NOT FOUND.  Reason given by package:
 
   The following imported targets are referenced, but are missing:
   KF5::KIOCore
 
 
 
 -- Configuring incomplete, errors occurred!
 See also /home/sebas/kf5/build/kde-workspace/CMakeFiles/CMakeOutput.log.
 
 
 It seems some of these modules aren't happy now anymore when used. I'm
 puzzled what needs to be added where, however.


As the error message says, KDeclarative links against the imported target 
KF5::KIOCore, but that target has not been imported, so cmake errors out.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113112: Notify about palette changes

2013-10-07 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113112/#review41361
---


This review has been submitted with commit 
240b44cf8a47469bff502ba65ecaf248bb127cab by Aleix Pol to branch frameworks.

- Commit Hook


On Oct. 7, 2013, 12:20 p.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113112/
 ---
 
 (Updated Oct. 7, 2013, 12:20 p.m.)
 
 
 Review request for KDE Frameworks, Àlex Fiestas and Sebastian Kügler.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Make sure the application can react to changes in the application's defaults 
 regarding palette, when using the kde platform plugin.
 
 
 Diffs
 -
 
   staging/frameworkintegration/autotests/kdeplatformtheme_unittest.cpp 
 417e9e1 
   staging/frameworkintegration/src/platformtheme/khintssettings.cpp 5d5bf82 
 
 Diff: http://git.reviewboard.kde.org/r/113112/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113112: Notify about palette changes

2013-10-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113112/
---

(Updated Oct. 7, 2013, 5:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Àlex Fiestas and Sebastian Kügler.


Repository: kdelibs


Description
---

Make sure the application can react to changes in the application's defaults 
regarding palette, when using the kde platform plugin.


Diffs
-

  staging/frameworkintegration/autotests/kdeplatformtheme_unittest.cpp 417e9e1 
  staging/frameworkintegration/src/platformtheme/khintssettings.cpp 5d5bf82 

Diff: http://git.reviewboard.kde.org/r/113112/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kio-related build error in plasma-framework

2013-10-07 Thread Alexander Neundorf

On Saturday 05 October 2013, David Faure wrote:
 On Friday 04 October 2013 19:55:52 Sebastian Kügler wrote:
  On Friday, October 04, 2013 17:56:52 Sebastian Kügler wrote:
   Hi,
   
   I'm getting a build error in a few places in plasma-framework, kio
   isn't found. I can't seem to figure out why, maybe someone who has a
   better overview of what in KIO is where, and what I need to tell cmake
   to figure this out?
   
   The error is:
   /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/
   ld: cannot find -lkio
   collect2: error: ld returned 1 exit status
   
   Others reproduce it, too, so it's blocking us right now.
  
  It turns out that removing KDE4_KIO_LIBS from the linker targets it
  needed to build.
 
 I'm seeing the same in other areas, e.g.
 kde-workspace/plasma/generic/wallpapers/image gives
 
 cannot find -lkio
 cannot find -lkfile
 cannot find -lknewstuff3
 
 It seems the -L pointing to the lib dir is missing, all of a sudden.

Usually there should be no -L, and no -l either (neither ?).
The libraries should be linked using their full path, e.g. 
/opt/kf5/libs/libkio.so.
AFAIk the only case where this is not done is if the library is loacted in one 
of the system library directories, then cmake generates only -lkio and 
relies on the directory being found automatically by the linker.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113157: Remove Nepomuk dependency from kde4support

2013-10-07 Thread Vishesh Handa


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113157/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

The only class using it is KFileMetaInfoItem which is just using the
ontology parts in order to get a better name for a property. It can rely
on strigi instead.


Diffs
-

  staging/kde4support/src/CMakeLists.txt 5eb649c 
  staging/kde4support/src/config-kde4support.h.cmake 95a092f 
  staging/kde4support/src/kdebug.areas 2cabd98 
  staging/kde4support/src/kio/kfilemetainfoitem.cpp 9df2602 
  staging/kde4support/src/kio/kfilemetainfoitem_p.h 959fbd6 

Diff: http://git.reviewboard.kde.org/r/113157/diff/


Testing
---


Thanks,

Vishesh Handa

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113160: Move KDeclarative to tier3

2013-10-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113160/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Moves KDeclarative to tier3

Also trim down the test so that it uses the module but it doesn't use something 
from upstream (such as plasma components)


Diffs
-

  tier3/CMakeLists.txt 11be8e4 
  staging/kdeclarative/tests/testobject_p.h  
  staging/kdeclarative/tests/test.qml 060c265 
  staging/kdeclarative/tests/kdeclarativetest.cpp d5b9f96 
  staging/kdeclarative/tests/CMakeLists.txt ad4a7db 
  staging/kdeclarative/src/qmlobject_p.h  
  staging/kdeclarative/src/qmlobject.cpp  
  staging/kdeclarative/src/qmlobject.h  
  staging/kdeclarative/src/private/rootcontext_p.h  
  staging/kdeclarative/src/private/rootcontext.cpp  
  staging/kdeclarative/src/private/kiconprovider_p.h  
  staging/kdeclarative/src/private/kiconprovider.cpp  
  staging/kdeclarative/src/private/kdeclarative_p.h  
  staging/kdeclarative/src/kdeclarative.cpp  
  staging/kdeclarative/src/kdeclarative.h  
  staging/kdeclarative/src/configpropertymap.cpp  
  staging/kdeclarative/src/configpropertymap.h  
  staging/kdeclarative/src/bindings/url.cpp  
  staging/kdeclarative/src/bindings/qscriptnonguibookkeeping.cpp  
  staging/kdeclarative/src/bindings/icon.cpp  
  staging/kdeclarative/src/bindings/i18n_p.h  
  staging/kdeclarative/src/bindings/i18n.cpp  
  staging/kdeclarative/src/bindings/backportglobal.h  
  staging/kdeclarative/src/CMakeLists.txt  
  staging/kdeclarative/KDeclarativeConfig.cmake.in  
  staging/kdeclarative/CMakeLists.txt eefa756 
  staging/CMakeLists.txt 4f64e8a 
  tier3/kdeclarative/tests/CMakeLists.txt PRE-CREATION 
  tier3/kdeclarative/tests/test.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113160/diff/


Testing
---

the test starts and seems to work.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

2013-10-07 Thread Rohan Garg


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113158/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Instead of implementing queueing in KDialogJobUiDelegate, I'm making use of 
QErrorMessage which has queueing built into it. We also inherit the Show this 
message again checkbox, but I have a review request here 
https://codereview.qt-project.org/67243 that adds new API to Qt 5.3 , so we can 
hide that once 5.3 comes out ( if that makes sense ).


Diffs
-

  staging/kjobwidgets/src/kdialogjobuidelegate.h 5d17a4d 
  staging/kjobwidgets/src/kdialogjobuidelegate.cpp 29c2bae 

Diff: http://git.reviewboard.kde.org/r/113158/diff/


Testing
---

Tested by writing a application that uses KIO to fetch an invalid site url. 
Dialog pops up just fine.


Thanks,

Rohan Garg

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113087: Start preparing KHTML for moving

2013-10-07 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113087/
---

(Updated Oct. 7, 2013, 7:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Split into /src and /tests
(file moves not shown as it makes the diff even more impossible to read. Diff 
made with --diff-filter=AM)

Remove references to ${CMAKE_SOURCE_DIR}/khtml/ which won't work when moved

KComboBox - QComboBox

If building standalone load kcookieserver dbus interface from system path


---

Still has quite a few other changes left to do, but this will be easier in 
small chunks (diff is already hard to read)


Diffs
-

  CMakeLists.txt 3204c11 
  khtml/CMakeLists.txt 91b55a3 
  khtml/KHTMLConfig.cmake.in PRE-CREATION 
  khtml/src/CMakeLists.txt PRE-CREATION 
  khtml/tests/CMakeLists.txt 0a404d5 
  khtml/tests/testkhtml.qrc 4cfe54b 
  khtml/tests/testkhtmlnew.h e7b7205 
  khtml/tests/testkhtmlnew.cpp 525c9fd 
  staging/CMakeLists.txt 5c5c80c 

Diff: http://git.reviewboard.kde.org/r/113087/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: more build problems around KIO

2013-10-07 Thread Sebastian Kügler

On Monday, October 07, 2013 19:13:02 Alexander Neundorf wrote:
 As the error message says, KDeclarative links against the imported target 
 KF5::KIOCore, but that target has not been imported, so cmake errors out.

How exactly do I import it?

Putting a find_package(KIOCore ${KF5_VERSION} REQUIRED) into 
kdeclarative/CMakeLists.txt doesn't do it. (And I'm just guessing. :/)

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-07 Thread David Gil Oliva


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112984/
---

(Updated Oct. 7, 2013, 10:08 p.m.)


Review request for KDE Frameworks.


Changes
---

Document the save() = saveTheme() change in KDE5PORTING.html


Repository: kdelibs


Description
---

Adjust API in KEmoticons framework: KEmoticonsProvider::save()

-To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save()
and prefer saveTheme() instead.
-Adjust plugins.
-Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(),
which was empty. Now it's a pure virtual function. Therefore, I deprecate
it and advice subclassing KEmoticonsProvider.


Diffs (updated)
-

  staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 
0dc92ed092d87a559fe7fa1a40e804843ab73d59 
  staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 
0873a635a300e0ed8e38b1d59a535d6ec15b99cb 
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp 
e9f89eecce3d6e6407113a84cb5200ff66564c19 
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 
70bafa3fe4ba25c9d6a69634024b2c157235e674 
  staging/kemoticons/src/providers/kde/kde_emoticons.cpp 
5b5114a14dd94a6ebcba8a6f7dd163f73048189a 
  staging/kemoticons/src/providers/kde/kde_emoticons.h 
8cba6b194eee1543bf13f1177a0e4092f1a10943 
  staging/kemoticons/src/providers/adium/adium_emoticons.cpp 
a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 
  staging/kemoticons/src/providers/adium/adium_emoticons.h 
039a267679919c968bbe4d12c35abb90cf1bcc9b 
  staging/kemoticons/src/core/kemoticonstheme.cpp 
ed3407cdd45c84d91f2d0057e108b760ff696ff2 
  staging/kemoticons/src/core/kemoticonstheme.h 
b8b25f7607d3741dda78d6302c1ed81fbc9211a0 
  staging/kemoticons/src/core/kemoticonsprovider.cpp 
d04c76e87b118f5d45717b3b2ccd9dea47dc2526 
  staging/kemoticons/src/core/kemoticonsprovider.h 
85fc7efb8923d76476f0a16f70f8ebb15e451081 
  KDE5PORTING.html 57ecf2e007e270b634cc8d16462b73e96553c92d 

Diff: http://git.reviewboard.kde.org/r/112984/diff/


Testing
---

It builds. It installs. Tests pass.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

43 matches

Mail list logo