D6687: Adding support to ipv*.route-metric

[Jan Grulich]

jgrulich added a comment.


  Looks good to me now, it looked to me good even before, but didn't read 
carefully the documentation. Lamarque, do you see anything else?

INLINE COMMENTS

> ipv4setting.cpp:455
>  
> +if(routeMetric() >= 0) {
> +setting.insert(QLatin1String(NMQT_SETTING_IP4_CONFIG_ROUTE_METRIC), 
> routeMetric());

Missing space between if and bracket.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D6687

To: pvillani, jgrulich, lvsouza
Cc: #frameworks

D6624: do not crash qaccessible by causing a resize in a resize event

[Christoph Feck]

cfeck added a comment.


  > It probably does.
  
  Were you able to test? I would prefer the simpler patch. I cannot test it, 
because my system does not have accessibility enabled.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D6624

To: sitter, gladhorn
Cc: cfeck, anthonyfieroni, #frameworks

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 20 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/20/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Tue, 18 Jul 2017 02:41:33 +
 Build duration:
56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

build.log
Description: Binary data

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 19 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/19/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 18 Jul 2017 02:41:33 +
 Build duration:
37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

build.log
Description: Binary data

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

[Nicolás Alvarez]

nalvarez added a comment.


  Looks reasonable – although I wonder why on earth you're building KDE stuff 
on Cygwin...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

To: winterz, skelly, #build_system, #windows
Cc: nalvarez, #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

[Aleix Pol Gonzalez]

apol added a reviewer: Windows.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

To: winterz, skelly, #build_system, #windows
Cc: #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

[Allen Winter]

winterz added reviewers: skelly, Build System.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

To: winterz, skelly, #build_system
Cc: #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

[Allen Winter]

winterz created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  Cygwin systems aren't ELF based so don't try to pass --enable-new-dtags to 
'ld'
  else you get 
/usr/lib/gcc/x86_64-pc-cygwin/5.4.0/../../../../x86_64-pc-cygwin/bin/ld: 
unrecognized option '--enable-new-dtags'

TEST PLAN
  see if I can build something on cygwin now

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: winterz
Cc: #frameworks, #build_system

D6672: add KAboutLicense::spdx and introduce orLater qualification

[Michael Pyne]

mpyne added a comment.


  In https://phabricator.kde.org/D6672#126360, @sitter wrote:
  
  > Ah drat. We could still get rid of the second private ctor though, by 
moving the defaults from the private to the public and calling the full private 
ctor:
  
  
  Yes, that would be fine if you want to implement it that way.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D6672

To: sitter, sebas, mpyne
Cc: #frameworks

D6672: add KAboutLicense::spdx and introduce orLater qualification

[Harald Sitter]

sitter added a comment.


  Ah drat. We could still get rid of the second private ctor though, by moving 
the defaults from the private to the public and calling the full private ctor:
  
KAboutLicense::KAboutLicense(const KAboutData *aboutData)
: d(new Private(Unknown, OnlyThisVersion, aboutData))
{
}

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D6672

To: sitter, sebas, mpyne
Cc: #frameworks

D6672: add KAboutLicense::spdx and introduce orLater qualification

[Michael Pyne]

mpyne added a comment.


  I like delegating constructors, but we can't use them in Frameworks yet. :(
  
  The current compiler requirement policy is that we require a C++ compiler 
supported in the last 3 Qt minor releases (see 
https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements).  
This means Qt 5.7's compilers are the oldest compilers we support, and Qt 5.7 
supports GCC 4.6 due to Ubuntu 
.  
But GCC didn't support delegating constructors until GCC 4.7 
.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D6672

To: sitter, sebas, mpyne
Cc: #frameworks

D6687: Adding support to ipv*.route-metric

[Paulo Villani]

pvillani added a comment.


  In https://phabricator.kde.org/D6687#125529, @lvsouza wrote:
  
  > The summary says this patch adds route metric support to IPv4 too, but no 
IPv4 file is touched by this patch. Have you missed the IPv4 changes?
  
  
  Added the missing files. 
  Aboute your comment suggestion, I preferred to change the code and accept the 
value 0, so that it works as specified by the documentation. In the case of 
ipv6, if the value 0 is set, it will be automatically changed to 1024 by 
NetworkManager.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D6687

To: pvillani, jgrulich, lvsouza
Cc: #frameworks

D6687: Adding support to ipv*.route-metric

[Paulo Villani]

pvillani updated this revision to Diff 16836.
pvillani added a comment.


  Adding missing files and making possible to set route-metric as 0, as 
described in NetworkManager documentation.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6687?vs=16697&id=16836

REVISION DETAIL
  https://phabricator.kde.org/D6687

AFFECTED FILES
  TODO
  autotests/settings/ipv4settingtest.cpp
  autotests/settings/ipv6settingtest.cpp
  src/settings/ipv4setting.cpp
  src/settings/ipv4setting.h
  src/settings/ipv4setting_p.h
  src/settings/ipv6setting.cpp
  src/settings/ipv6setting.h
  src/settings/ipv6setting_p.h

To: pvillani, jgrulich, lvsouza
Cc: #frameworks

D6754: [server] Send pointer leave if focused surface gets unbound

[Sebastian Kügler]

sebas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  send-leave-pointer-surface

REVISION DETAIL
  https://phabricator.kde.org/D6754

To: graesslin, #plasma, #frameworks, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein, lukas

D6754: [server] Send pointer leave if focused surface gets unbound

[Martin Flöser]

graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As https://phabricator.kde.org/R127:98e5d269a110dca9cae1e4ed2bb3051f02a69bff 
just for pointer.

REPOSITORY
  R127 KWayland

BRANCH
  send-leave-pointer-surface

REVISION DETAIL
  https://phabricator.kde.org/D6754

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/pointer_interface.cpp

To: graesslin, #plasma, #frameworks
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein, lukas

D6751: [Task Manager] Fix icon size in launcher tooltips

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d28deb6f4ab2: [Task Manager] Fix icon size in launcher 
tooltips (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6751?vs=16809&id=16820

REVISION DETAIL
  https://phabricator.kde.org/D6751

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: broulik, #plasma, hein, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6751: [Task Manager] Fix icon size in launcher tooltips

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6751

To: broulik, #plasma, hein, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6672: add KAboutLicense::spdx and introduce orLater qualification

[Harald Sitter]

sitter marked 2 inline comments as done.
sitter added a comment.


  Oh, actually. Maybe we could/should make `KAboutLicense::KAboutLicense(const 
KAboutData *aboutData)` delegate to the "full" public ctor. Then we can drop 
`Private(const KAboutData *aboutData);` entirely.
  
  Like so
  
KAboutLicense::KAboutLicense(LicenseKey licenseType,
 VersionRestriction versionRestriction,
 const KAboutData *aboutData)
: d(new Private(licenseType, versionRestriction, aboutData))
{
}

KAboutLicense::KAboutLicense(const KAboutData *aboutData)
: KAboutLicense(Unknown, OnlyThisVersion, aboutData)
{
}

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D6672

To: sitter, sebas, mpyne
Cc: #frameworks

D6672: add KAboutLicense::spdx and introduce orLater qualification

[Harald Sitter]

sitter marked 3 inline comments as done.
sitter added inline comments.

INLINE COMMENTS

> mpyne wrote in kaboutdata.cpp:166
> Need a setter here for `_versionRestriction`

I am changing this one to delegate to the other ctor actually. Not much point

> mpyne wrote in kaboutdata.cpp:206
> We use `OnlyThisVersion` elsewhere as a default version restriction; using 
> `OrLaterVersions` here causes the auto test you added to break as well. ;)

Ah yes. Good test that ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D6672

To: sitter, sebas, mpyne
Cc: #frameworks

D6672: add KAboutLicense::spdx and introduce orLater qualification

[Harald Sitter]

sitter updated this revision to Diff 16814.
sitter added a comment.


  rebase

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6672?vs=16813&id=16814

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D6672

AFFECTED FILES
  autotests/kaboutdatatest.cpp
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: sitter, sebas, mpyne
Cc: #frameworks

D6672: add KAboutLicense::spdx and introduce orLater qualification

[Harald Sitter]

sitter updated this revision to Diff 16813.
sitter marked an inline comment as done.
sitter added a comment.


  - change "partial" Private ctor to delegate to "full" ctor so we don't have 
repetitive init lists
  - fix Private cctor to copy version restriction properly
- adjust copy test to assert proper restriction copy by comparing the spdx
  - fix default value I accidently changed to AndLater when it should be 
OnlyThis

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6672?vs=16694&id=16813

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D6672

AFFECTED FILES
  autotests/kaboutdatatest.cpp
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: sitter, sebas, mpyne
Cc: #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 33 - Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/33/
 Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
 Date of build:
Mon, 17 Jul 2017 12:29:44 +
 Build duration:
3 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(10/10)85%
(79/93)85%
(79/93)74%
(6052/8234)43%
(10542/24475)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(33/40)83%
(33/40)97%
(2610/2693)49%
(6474/13211)src.desktoptojson100%
(3/3)100%
(3/3)79%
(84/106)38%
(123/324)src.lib67%
(2/3)67%
(2/3)58%
(302/518)23%
(181/797)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/787)18%
(192/1076)src.lib.io90%
(9/10)90%
(9/10)58%
(817/1397)29%
(925/3158)src.lib.jobs71%
(5/7)71%
(5/7)52%
(159/304)39%
(57/146)src.lib.plugin100%
(8/8)100%
(8/8)86%
(646/748)44%
(984/2216)src.lib.randomness100%
(2/2)100%
(2/2)67%
(66/99)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)46%
(349/764)40%
(748/1867)src.lib.util100%
(10/10)100%
(10/10)82%
(667/818)51%
(814/1604)

build.log
Description: Binary data

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 28 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/28/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 17 Jul 2017 12:29:44 +
 Build duration:
3 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)

build.log
Description: Binary data

D6700: disable compiler warning on testing deprecated function

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:0c33e313d5e2: disable compiler warning on testing 
deprecated function (authored by sitter).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6700?vs=16696&id=16811

REVISION DETAIL
  https://phabricator.kde.org/D6700

AFFECTED FILES
  autotests/kaboutdatatest.cpp

To: sitter, mpyne
Cc: #frameworks

D6751: [Task Manager] Fix icon size in launcher tooltips

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6751

To: broulik, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6751: [Task Manager] Fix icon size in launcher tooltips

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Depending on icon theme the implicit size of the icon may be huge.
  
  BUG:
  FIXED-IN: 5.10.4

TEST PLAN
  Used Ultra-Flat-Icons, icon size for launcher tooltips is consistent with the 
others in plasma now

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6751

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: broulik, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Review Request 129590: KAuth: Make D-Bus dependency optional.

[Ralf Habacker]

> On Jan. 8, 2017, 6:53 nachm., David Faure wrote:
> > autotests/CMakeLists.txt, line 5
> > 
> >
> > Better split this into two, to avoid confusing people.

I've update the patch, but do not have access rights to upload the path, so I 
appended it here:

commit ec98addbfbba62310e050046078380c10192b829
Author: Ralf Habacker 
Date:   Mon Jul 17 11:16:39 2017 +0200

Make building with QtDBus optional

This patch adds an ENABLE_DBUS CMake option defaulting to ON,
which can be used to make KAuth not depend on DBus.
This is useful for some apps that are running on Windows or Mac OSX.

see https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg34246.html

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 13a6129..c53ff15 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -11,8 +11,16 @@ feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND 
FATAL_ON_MISSING_REQUIRED_PACKA
 
 set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})
 
+option(ENABLE_DBUS "Enable D-Bus functionality" ON)
+add_feature_info(D-Bus ENABLE_DBUS "Enable D-Bus functionality")
+
+if(ENABLE_DBUS)
+set(DBUS_PACKAGE DBus)
+set(DBUS_LIBRARY Qt::DBus)
+endif()
+
 set(REQUIRED_QT_VERSION 5.6.0)
-find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED Widgets DBus)
+find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED Widgets 
${DBUS_PACKAGE})
 include(KDEInstallDirs)
 include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
 include(KDECMakeSettings)
diff --git a/autotests/CMakeLists.txt b/autotests/CMakeLists.txt
index b53d760..fe07742 100644
--- a/autotests/CMakeLists.txt
+++ b/autotests/CMakeLists.txt
@@ -5,6 +5,10 @@ if(NOT Qt5Test_FOUND)
 message(STATUS "Qt5Test not found, autotests will not be built.")
 return()
 endif()
+if(NOT ENABLE_DBUS)
+message(STATUS "Autotests will not be built, because DBus was disabled.")
+return()
+endif()
 
 qt5_add_dbus_adaptor(kauth_dbus_adaptor_tests_SRCS
  ../src/backends/dbus/org.kde.kf5auth.xml
@@ -39,7 +43,7 @@ target_include_directories(kauth_tests_static
 ${CMAKE_CURRENT_SOURCE_DIR}/../src
 )
 
-target_link_libraries(kauth_tests_static PUBLIC Qt5::DBus KF5::CoreAddons)
+target_link_libraries(kauth_tests_static PUBLIC ${DBUS_LIBRARY} 
KF5::CoreAddons)
 
 ### next target ###
 
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 662a0dd..5754ceb 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -31,7 +31,7 @@ add_library(KF5::Auth ALIAS KF5Auth)
 target_include_directories(KF5Auth INTERFACE 
"$")
 
 target_link_libraries(KF5Auth PUBLIC Qt5::Core KF5::CoreAddons)  # for KJob
-target_link_libraries(KF5Auth PRIVATE Qt5::Widgets Qt5::DBus)
+target_link_libraries(KF5Auth PRIVATE Qt5::Widgets ${DBUS_LIBRARY})
 set_target_properties(KF5Auth PROPERTIES VERSION   ${KAUTH_VERSION_STRING}
  SOVERSION ${KAUTH_SOVERSION}
  EXPORT_NAME Auth


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129590/#review101885
---


On Nov. 30, 2016, 10:59 vorm., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129590/
> ---
> 
> (Updated Nov. 30, 2016, 10:59 vorm.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> This adds an `ENABLE_DBUS` CMake option defaulting to `ON`, which can be used 
> to make KAuth not depend on DBus. This is useful for some apps that are 
> running on Windows.
> 
> https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg34246.html
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b8b7ba7 
>   autotests/CMakeLists.txt b53d760 
>   src/CMakeLists.txt 1b6930d 
> 
> Diff: https://git.reviewboard.kde.org/r/129590/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

Re: Review Request 126495: Install parsetrigrams tool for cross compiling.

[Ralf Habacker]

> On Mai 6, 2016, 12:10 nachm., Aleix Pol Gonzalez wrote:
> > data/CMakeLists.txt, line 6
> > 
> >
> > Maybe it should be installed in `libexec`?

Libexec is not supported on Windows. All executables are installed in bin dir, 
see https://phabricator.kde.org/D5173#124786


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126495/#review95229
---


On Mai 5, 2016, 9:55 nachm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126495/
> ---
> 
> (Updated Mai 5, 2016, 9:55 nachm.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Add support for running host provided tool parsetrigrams when cross compiling 
> by specifing cmake variable PARSETRIGRAMS_EXECUTABLE on configure time.
> 
> 
> Diffs
> -
> 
>   data/CMakeLists.txt 023ec28b27f9190e3885cf626996aae8b68c4c80 
> 
> Diff: https://git.reviewboard.kde.org/r/126495/diff/
> 
> 
> Testing
> ---
> 
> Cross compiled package build at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF516/mingw32-sonnet
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>