D8958: Fix unintentional breadcrumb menu item activation
aleksejshilin added a comment. So, any comments on the updated revision? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin, #frameworks Cc: broulik, ngraham
KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/5/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Thu, 07 Dec 2017 19:37:52 + Build duration: 7 min 37 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest
KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 5 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/5/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Thu, 07 Dec 2017 19:37:52 + Build duration: 7 min 45 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest
KDE CI: Frameworks baloo kf5-qt5 WindowsMSVCQt5.9 - Build # 26 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.9/26/ Project: Frameworks baloo kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 07 Dec 2017 19:37:53 + Build duration: 5 min 33 sec and counting CONSOLE OUTPUT [...truncated 105.37 KB...]-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Found KF5CoreAddons: C:/CI/workspace/Frameworks baloo kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.41.0") -- Found KF5Config: C:/CI/workspace/Frameworks baloo kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.41.0") -- Found KF5DBusAddons: C:/CI/workspace/Frameworks baloo kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.41.0") -- Found Gettext: C:/CM/msvc2017x64d/dev-utils/bin/msgmerge.exe -- Found PythonInterp: C:/Program Files/Python36-32/python.exe (found version "3.6.2") -- Found KF5I18n: C:/CI/workspace/Frameworks baloo kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.41.0") -- Found KF5IdleTime: C:/CI/workspace/Frameworks baloo kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.41.0") -- Found KF5Solid: C:/CI/workspace/Frameworks baloo kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Solid/KF5SolidConfig.cmake (found version "5.41.0") -- Found KF5FileMetaData: C:/CI/workspace/Frameworks baloo kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5FileMetaData/KF5FileMetaDataConfig.cmake (found version "5.41.0") -- Found KF5Crash: C:/CI/workspace/Frameworks baloo kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.41.0") -- Found KF5KIO: C:/CI/workspace/Frameworks baloo kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.41.0") -- Found KF5: success (found suitable version "5.41.0", minimum required is "5.41.0") found components: CoreAddons Config DBusAddons I18n IdleTime Solid FileMetaData Crash KIO -- Found LMDB: C:/CM/msvc2017x64d/include -- LMDB lib: C:/CM/msvc2017x64d/lib/lmdb.lib-- LMDB include: C:/CM/msvc2017x64d/include-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed-- Performing Test COMPILER_HAS_DEPRECATED-- Performing Test COMPILER_HAS_DEPRECATED - Success-- The following REQUIRED packages have been found: * ECM (required version >= 5.41.0), Extra CMake Modules, * Qt5Core * Qt5DBus * Qt5Gui (required version >= 5.9.3) * Qt5Widgets * Qt5Network (required version >= 5.9.3) * Qt5Qml * Qt5Quick * Qt5Test * Qt5 (required version >= 5.7.0) * KF5CoreAddons (required version >= 5.41.0) * KF5Config (required version >= 5.41.0) * KF5DBusAddons (required version >= 5.41.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.41.0) * KF5IdleTime (required version >= 5.41.0) * KF5Solid (required version >= 5.41.0) * KF5FileMetaData (required version >= 5.41.0) * KF5Crash (required version >= 5.41.0) * KF5KIO (required version >= 5.41.0) * KF5 (required version >= 5.41.0) * LMDB, Lightning Memory-Mapped Database (LMDB), -- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * Inotify Filesystem alteration notifications using inotify-- Configuring doneCMake Error at src/lib/CMakeLists.txt:32 (add_library): Cannot find source file:../file/baloodebug.cpp Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txxCMake Error: CMake can not determine linker language for target: KF5BalooCMake Error in src/lib/CMakeLists.txt: Exporting the target "KF5Baloo" is not allowed since its linker language cannot be determinedCMake Error: CMake can not determine linker language for target: KF5BalooCMake Error in src/lib/CMakeLists.txt: Exporting the target "KF5Baloo" is not allowed since its linker language cannot be determinedCMake Error: Cannot determine link language for target "KF5Baloo".-- Generating done-- Build files have been written to: C:/CI/workspace/Frameworks baloo kf5-qt5 WindowsMSVCQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] bat[Frameworks baloo kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Frameworks baloo kf5-qt5 WindowsMSVCQt5.9>python -u ci-tooling/helpers/capture-workspace.py --environment production [Pipeline] emailextrecipients[Pipeline]
D9240: [RunnerManager] Don't mess with ThreadWeaver thread count
This revision was automatically updated to reflect the committed changes. Closed by commit R308:98aa41f388f4: [RunnerManager] Dont mess with ThreadWeaver thread count (authored by broulik). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9240?vs=23616=23619 REVISION DETAIL https://phabricator.kde.org/D9240 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/runnermanager.cpp To: broulik, #plasma, #frameworks, davidedmundson, sitter Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9240: [RunnerManager] Don't mess with ThreadWeaver thread count
sitter accepted this revision. sitter added a comment. I love it REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D9240 To: broulik, #plasma, #frameworks, davidedmundson, sitter Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9241: Emit 'groupHiddenChanged' signal.
renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot, mwolff Cc: mwolff, #frameworks
D9241: Emit 'groupHiddenChanged' signal.
renatoo updated this revision to Diff 23617. renatoo added a comment. used static_cast() for cast enums REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9241?vs=23614=23617 REVISION DETAIL https://phabricator.kde.org/D9241 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h To: renatoo, franckarrecot, mwolff Cc: mwolff, #frameworks
D9240: [RunnerManager] Don't mess with ThreadWeaver thread count
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D9240 To: broulik, #plasma, #frameworks, davidedmundson Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9240: [RunnerManager] Don't mess with ThreadWeaver thread count
broulik updated this revision to Diff 23616. broulik retitled this revision from "[RunnerManager] Use QThread::idealThreadCount() instead of going through Solid" to "[RunnerManager] Don't mess with ThreadWeaver thread count". broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9240?vs=23613=23616 REVISION DETAIL https://phabricator.kde.org/D9240 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/runnermanager.cpp To: broulik, #plasma, #frameworks Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9241: Emit 'groupHiddenChanged' signal.
mwolff accepted this revision. mwolff added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kfileplacesmodeltest.cpp:1215 > +QList args = groupHiddenSignal.takeFirst(); > +QCOMPARE(args.at(0).toInt(), (int) KFilePlacesModel::SearchForType); > +QCOMPARE(args.at(1).toBool(), true); `static_cast()` would be preferred, also below REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot, mwolff Cc: mwolff, #frameworks
D9241: Emit 'groupHiddenChanged' signal.
renatoo added a reviewer: franckarrecot. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot Cc: #frameworks
D9240: [RunnerManager] Use QThread::idealThreadCount() instead of going through Solid
sitter added a comment. It seems to me the only reason we have custom code to set the max count is because of that `maxThreads` config entry. An entry for which I can't see any UI backing, so it's borderline usless to begin with. The qMin then destroys any remaining use that entry may have head as we basically discard whatever was configured anyway unless it somewhat conforms to the hardcoded notion of how many threads make sense. So, I can't force a given thread count anyway. I for one, would do away with the thread count twiddling and simply defer to whatever threadweaver says makes sense. Perhaps I am missing something though. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D9240 To: broulik, #plasma, #frameworks Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9240: [RunnerManager] Use QThread::idealThreadCount() instead of going through Solid
davidedmundson added inline comments.
INLINE COMMENTS
> runnermanager.cpp:105
> if (numThreads > Queue::instance()->maximumNumberOfThreads()) {
> Queue::instance()->setMaximumNumberOfThreads(numThreads);
> }
Threadweaver defaults to
inventoryMax(qMax(4, 2 * QThread::idealThreadCount()))
At which point we basically have written:
if( X > 2X )
which is never going to happen.
Frankly I'd say let threadweaver do its own thing and not try meddling with it.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D9240
To: broulik, #plasma, #frameworks
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9240: [RunnerManager] Use QThread::idealThreadCount() instead of going through Solid
broulik added inline comments.
INLINE COMMENTS
> runnermanager.cpp:107
> const int maxThreads = config.readEntry("maxThreads", 16);
> -const int numThreads = qMin(maxThreads, 2 + ((numProcs - 1) * 2));
> -//qCDebug(KRUNNER) << "setting up" << numThreads << "threads for" <<
> numProcs << "processors";
Or should we keep this weird logic and substitute `numProcs` for
`idealThreadCount`?
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D9240
To: broulik, #plasma, #frameworks
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D9240: [RunnerManager] Use QThread::idealThreadCount() instead of going through Solid
broulik added reviewers: Plasma, Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D9240 To: broulik, #plasma, #frameworks Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8450: User can now hide an entire places group from KFilePlacesView
renatoo added a dependent revision: D9241: Emit 'groupHiddenChanged' signal.. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent Cc: mwolff, #frameworks
D9241: Emit 'groupHiddenChanged' signal.
renatoo edited the summary of this revision. renatoo added a dependency: D8450: User can now hide an entire places group from KFilePlacesView. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo Cc: #frameworks
D9241: Emit 'groupHiddenChanged' signal.
renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Emit 'groupHiddenChanged' when group hidden value change TEST PLAN Unit test created REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h To: renatoo Cc: #frameworks
D9240: [RunnerManager] Use QThread::idealThreadCount() instead of going through Solid
broulik created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY We query Solid for processors causing a ton of processing to be done just to get the number of CPUs and then some magic math to determin the thread count. Just use `QThread::idealThreadCount()` for simplicity. TEST PLAN It spent 30ms doing this on startup, now it's like 0.05ms The previous code would assign my quadcore machine that is not hyper-threading capable 8 threads, now it gets 4 instead. I do have the feeling that occasionally the baloo runner blocks the calculator but we need to observe whether this patch makes performance worse but from random testing it doesn't seem like a big deal. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D9240 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/runnermanager.cpp To: broulik Cc: #frameworks
D8159: Add API for setting server decoration palettes
davidedmundson abandoned this revision. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8159 To: davidedmundson, #plasma, graesslin Cc: graesslin, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7968: Forward QComboBox signals instead of QComboBox lineedit signals
mwolff added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7968 To: mwolff, apol, dfaure Cc: #frameworks
D7968: Forward QComboBox signals instead of QComboBox lineedit signals
mwolff updated this revision to Diff 23604. mwolff added a comment. use QOverload::of as suggested by apol REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7968?vs=23522=23604 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7968 AFFECTED FILES autotests/kurlrequestertest.cpp src/widgets/kurlrequester.cpp To: mwolff, apol Cc: #frameworks
D8056: Improve usability of "Open With" dialog by adding option to filter the application tree
rkflx added a comment. No problem at all :) Good luck with your thesis! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks
D8056: Improve usability of "Open With" dialog by adding option to filter the application tree
simgunz added a comment. The deadline of my PhD thesis is very close, so my free time is basically zero in this period. Unfortunately, I didn't manage to complete these reviews before entering this critical period. In January I should have free time and I'll complete this. I also can't wait to complete this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks
