D11315: Look first for qhelpgenerator-qt5 for help generation

[Luca Beltrame]

lbeltrame created this revision.
lbeltrame added reviewers: Frameworks, ochurlaud.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added a subscriber: Documentation.
lbeltrame requested review of this revision.

REVISION SUMMARY
  A number of distributions uses the -qt5 suffix for Qt command line
  tools, to make sure they can coexist with the Qt4 equivalents.
  
  This change uses `distutils`'s `find_executable` to look for the -qt5
  suffix of `qhelpgenerator`. If it is not found, it falls back to the
  un-suffixed version.

REPOSITORY
  R264 KApiDox

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11315

AFFECTED FILES
  src/kapidox/generator.py

To: lbeltrame, #frameworks, ochurlaud
Cc: #documentation, michaelh, ngraham, skadinna

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 14 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/14/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 14 Mar 2018 07:33:15 +
 Build duration:
3 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 155 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/155/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 14 Mar 2018 08:06:55 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

rjvbb added reviewers: dfaure, mlaurent, vkrause.
rjvbb edited subscribers, added: kde-frameworks-devel; removed: Frameworks.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

rjvbb added reviewers: dfaure, mlaurent, vkrause.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

To: rjvbb, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham

Re: D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

> You should probably add the sonnet maintainer (or whoever committed
> the most to the repository in recent months) as the reviewer.

Possibly, but they're all supposed to be notified of this via the frameworks-
devel ML already.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 176 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/176/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 14 Mar 2018 08:06:55 +
 Build duration:
7 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31576/59674)38%
(18552/48930)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8591/9139)48%
(5246/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8357/14351)50%
(4881/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3890/7876)33%
(1635/4932)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 13 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/13/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 13 Mar 2018 04:17:27 +
 Build duration:
1 day 3 hr and counting
   CONSOLE OUTPUT
  [...truncated 346.35 KB...]Scanning dependencies of target filtereddiriteratorbenchmark[ 83%] Building CXX object tests/file/CMakeFiles/filtereddiriteratorbenchmark.dir/filtereddiriteratorbenchmark.cpp.o[ 83%] Building CXX object tests/file/CMakeFiles/filtereddiriteratorbenchmark.dir/filtereddiriteratorbenchmark_autogen/mocs_compilation.cpp.o[ 83%] Linking CXX executable ../../bin/filtereddiriteratorbenchmark[ 83%] Built target filtereddiriteratorbenchmark[ 84%] Building CXX object src/tools/balooctl/CMakeFiles/balooctl.dir/__/__/dbus/fileindexerinterface.cpp.o[ 84%] Building CXX object src/tools/balooctl/CMakeFiles/balooctl.dir/__/__/dbus/schedulerinterface.cpp.o[ 84%] Building CXX object src/tools/balooctl/CMakeFiles/balooctl.dir/balooctl_autogen/mocs_compilation.cpp.oScanning dependencies of target filtereddiriteratortest[ 84%] Building CXX object autotests/unit/file/CMakeFiles/filtereddiriteratortest.dir/filtereddiriteratortest.cpp.o[ 84%] Linking CXX executable ../../../bin/balooctl[ 84%] Building CXX object autotests/unit/file/CMakeFiles/filtereddiriteratortest.dir/filtereddiriteratortest_autogen/mocs_compilation.cpp.o[ 84%] Linking CXX executable ../../../bin/filtereddiriteratortest[ 84%] Built target balooctlScanning dependencies of target fileindexerconfigtest[ 84%] Building CXX object autotests/unit/file/CMakeFiles/fileindexerconfigtest.dir/fileindexerconfigtest.cpp.o[ 84%] Built target filtereddiriteratortestScanning dependencies of target basicindexingjobtest[ 84%] Building CXX object autotests/unit/file/CMakeFiles/basicindexingjobtest.dir/basicindexingjobtest.cpp.o[ 85%] Building CXX object autotests/unit/file/CMakeFiles/basicindexingjobtest.dir/basicindexingjobtest_autogen/mocs_compilation.cpp.o[ 85%] Linking CXX executable ../../../bin/basicindexingjobtest[ 86%] Building CXX object autotests/unit/file/CMakeFiles/fileindexerconfigtest.dir/fileindexerconfigtest_autogen/mocs_compilation.cpp.o[ 86%] Linking CXX executable ../../../bin/fileindexerconfigtest[ 86%] Built target basicindexingjobtest[ 86%] Built target fileindexerconfigtestScanning dependencies of target pendingfilequeuetest[ 87%] Building CXX object autotests/unit/file/CMakeFiles/pendingfilequeuetest.dir/pendingfilequeuetest.cpp.o[ 87%] Building CXX object autotests/unit/file/CMakeFiles/pendingfilequeuetest.dir/pendingfilequeuetest_autogen/mocs_compilation.cpp.o[ 87%] Linking CXX executable ../../../bin/pendingfilequeuetest[ 87%] Built target pendingfilequeuetestScanning dependencies of target unindexedfileiteratortest[ 88%] Building CXX object autotests/unit/file/CMakeFiles/unindexedfileiteratortest.dir/unindexedfileiteratortest.cpp.o[ 88%] Building CXX object autotests/unit/file/CMakeFiles/unindexedfileiteratortest.dir/unindexedfileiteratortest_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX executable ../../../bin/unindexedfileiteratortest[ 88%] Built target unindexedfileiteratortestScanning dependencies of target metadatamovertest[ 88%] Building CXX object autotests/unit/file/CMakeFiles/metadatamovertest.dir/metadatamovertest.cpp.o[ 88%] Building CXX object autotests/unit/file/CMakeFiles/metadatamovertest.dir/metadatamovertest_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX executable ../../../bin/metadatamovertest[ 88%] Built target metadatamovertestScanning dependencies of target fileinfotest[ 88%] Building CXX object autotests/unit/file/CMakeFiles/fileinfotest.dir/fileinfotest.cpp.o[ 89%] Building CXX object autotests/unit/file/CMakeFiles/fileinfotest.dir/fileinfotest_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX executable ../../../bin/fileinfotest[ 89%] Built target fileinfotestScanning dependencies of target filewatchtest[ 89%] Building CXX object autotests/unit/file/CMakeFiles/filewatchtest.dir/filewatchtest.cpp.oScanning dependencies of target kinotifytest[ 90%] Building CXX object autotests/unit/file/CMakeFiles/kinotifytest.dir/kinotifytest.cpp.o[ 91%] Building CXX object autotests/unit/file/CMakeFiles/filewatchtest.dir/__/lib/xattrdetector.cpp.o[ 91%] Building CXX object autotests/unit/file/CMakeFiles/filewatchtest.dir/filewatchtest_autogen/mocs_compilation.cpp.o[ 91%] Linking CXX executable ../../../bin/filewatchtest[ 91%] Building CXX object autotests/unit/file/CMakeFiles/kinotifytest.dir/kinotifytest_autogen/mocs_compilation.cpp.o[ 91%] Built target filewatchtestScanning dependencies of target regularexpcachebenchmark[ 91%] Linking CXX executable ../../../bin/kinotifytest[ 91%] Building CXX object autotests/unit/file/CMakeFiles/regularexpcachebenchmark.dir/regularexpcachebenchmark.cpp.o[ 91%] Built target kinotifytestScanning dependencies of target filemonitortest[ 91%] Building CXX object 

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.9 - Build # 127 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.9/127/
 Project:
Frameworks kirigami kf5-qt5 AndroidQt5.9
 Date of build:
Wed, 14 Mar 2018 07:19:02 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 1.40 KB...][Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/kirigami > git init /home/user/workspace/Frameworks kirigami kf5-qt5 AndroidQt5.9 # timeout=10Fetching upstream changes from git://anongit.kde.org/kirigami > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/kirigami +refs/heads/*:refs/remotes/origin/* # timeout=120 > git config remote.origin.url git://anongit.kde.org/kirigami # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://anongit.kde.org/kirigami # timeout=10Fetching upstream changes from git://anongit.kde.org/kirigami > git fetch --tags --progress git://anongit.kde.org/kirigami +refs/heads/*:refs/remotes/origin/* # timeout=120 > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 8a72bb018dedbc48721087d8c348fcada26dc11d (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 8a72bb018dedbc48721087d8c348fcada26dc11dCommit message: "Fix ActionButton size" > git rev-list --no-walk 8cf844dd9f1c2ab6de65ed5af920c4ec440de0ab # timeout=10[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init /home/user/workspace/Frameworks kirigami kf5-qt5 AndroidQt5.9/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 5b123d004dbaa89416aa026ab55b48ba09736866 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 5b123d004dbaa89416aa026ab55b48ba09736866Commit message: "Android: Port from Qt 5.9 to Qt 5.10"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks kirigami kf5-qt5 AndroidQt5.9/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 68f339a1d473acff5eae8bcb3937f271caca1e69 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 68f339a1d473acff5eae8bcb3937f271caca1e69Commit message: "There's no unstable kdelibs4 based branch for amarok anymore"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks kirigami kf5-qt5 AndroidQt5.9/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 6a812c85e7bf683faf8ac4e29c5f52f2eafcea16 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/26/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 14 Mar 2018 08:06:55 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31643/59675)38%
(18589/48926)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8591/9139)48%
(5247/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8415/14352)50%
(4905/9728)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3890/7876)33%
(1635/4932)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf updated this revision to Diff 29473.
rominf added a comment.


  - Move isNtfsHidden to file ioslave

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11204?vs=29141=29473

BRANCH
  ntfs-hidden

REVISION DETAIL
  https://phabricator.kde.org/D11204

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/ioslaves/file/file_unix.cpp

To: rominf, #dolphin, #frameworks, markg
Cc: markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, 
#dolphin, michaelh, ngraham

D11320: Fix QVariantMapList operator >> implementation

[Aleksander Morgado]

aleksanderm created this revision.
aleksanderm added reviewers: Frameworks, jgrulich.
Restricted Application added a project: Frameworks.
aleksanderm requested review of this revision.

REVISION SUMMARY
Thread 1 "united-airlion" received signal SIGSEGV, Segmentation fault.
0x7255776f in _dbus_type_reader_recurse () from 
/usr/lib/libdbus-1.so.3
(gdb) bt
#0  0x7255776f in _dbus_type_reader_recurse () at 
/usr/lib/libdbus-1.so.3
#1  0x76a821d0 in  () at /usr/lib/libQt5DBus.so.5
#2  0x76a825b8 in QDBusArgument::beginArray() const () at 
/usr/lib/libQt5DBus.so.5
#3  0x76443ec9 in operator>>(QDBusArgument const&, 
QList >&) () at /usr/lib/libKF5ModemManagerQt.so.6
#4  0x76443f2d in operator>>(QDBusArgument const&, 
QList >&) () at /usr/lib/libKF5ModemManagerQt.so.6
#5  0x76443f2d in operator>>(QDBusArgument const&, 
QList >&) () at /usr/lib/libKF5ModemManagerQt.so.6
#6  0x76443f2d in operator>>(QDBusArgument const&, 
QList >&) () at /usr/lib/libKF5ModemManagerQt.so.6
#7  0x76a87d30 in QDBusMetaType::demarshall(QDBusArgument const&, 
int, void*) () at /usr/lib/libQt5DBus.so.5

REPOSITORY
  R281 ModemManagerQt

BRANCH
  fix-qvariantmaplist-demarshalling

REVISION DETAIL
  https://phabricator.kde.org/D11320

AFFECTED FILES
  src/generictypes.cpp

To: aleksanderm, #frameworks, jgrulich
Cc: michaelh, ngraham

D10366: cmake: don't flag libnm-util as found when ModemManager is found

[Luca Beltrame]

This revision was automatically updated to reflect the committed changes.
Closed by commit R281:d3c573483257: cmake: dont flag libnm-util as found 
when ModemManager is found (authored by aleksanderm, committed by lbeltrame).

REPOSITORY
  R281 ModemManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10366?vs=26707=29484

REVISION DETAIL
  https://phabricator.kde.org/D10366

AFFECTED FILES
  cmake/FindModemManager.cmake

To: aleksanderm, #frameworks, jgrulich
Cc: michaelh, ngraham

D11326: [ToolTip] Check file name in KDirWatch handler

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  `KDirWatch::self()` is a singleton so we would get change events also for 
other files like `plasma-appletsrc` needlessly reloading `plasmarc` all the 
time.

TEST PLAN
  It reloaded `plasmarc` 103 times on startup for me, now it only does it like 
3 times

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11326

AFFECTED FILES
  src/declarativeimports/core/tooltip.cpp
  src/declarativeimports/core/tooltip.h

To: broulik, #plasma
Cc: #frameworks, michaelh, ngraham

D11326: [ToolTip] Check file name in KDirWatch handler

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11326

To: broulik, #plasma
Cc: #frameworks, michaelh, ngraham

D11323: [UDevManager] Also explicitly query for cameras

[David Edmundson]

davidedmundson added a comment.


  didn't we establish that devicesByProperty didn't work?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11323

To: broulik, #frameworks, davidedmundson
Cc: michaelh, ngraham

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf updated this revision to Diff 29475.
rominf added a comment.


  - Cleanup

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11204?vs=29473=29475

BRANCH
  ntfs-hidden

REVISION DETAIL
  https://phabricator.kde.org/D11204

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: rominf, #dolphin, #frameworks, markg
Cc: markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, 
#dolphin, michaelh, ngraham

D11278: [KateCompletionWidget] Create configuration interface on demand

[Martin Kostolný]

martinkostolny added a comment.


  Hi! After this commit I don't see a completion dropdown anymore. And after it 
should be opened an one presses backspace, kate or kwrite crashes. Simple 
example:
  
  1. open empty Kate
  2. write "", enter, "", backspace
  
  I will provide backtrace on demand :). I'm running on kdesrc-build 
environment, therefore frameworks and KDE applications are built from git. I 
have stable Qt version 5.10.1.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11278

To: broulik, #ktexteditor, dhaumann, kfunk, cullmann
Cc: martinkostolny, cullmann, kfunk, #frameworks, michaelh, kevinapavew, 
ngraham, demsking, sars, dhaumann

D10809: autotests: Refactor fileindexerconfigtest

[Michael Heidelbach]

michaelh updated this revision to Diff 29472.
michaelh added a comment.


  - Keep closer to original
  - Check directory existence

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10809?vs=27950=29472

BRANCH
  fileindexerconfigtest-rebuild (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10809

AFFECTED FILES
  autotests/unit/file/fileindexerconfigtest.cpp
  autotests/unit/file/fileindexerconfigtest.h

To: michaelh, #baloo, #frameworks, ngraham
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, alexeymin

D11290: [UDevManager] Already filter for subsystem before querying

[Kai Uwe Broulik]

broulik added a comment.


  I wasn't sure if that really fixes it, it might mitigate it? If you could 
perhaps retry with your strace skills. If you consider it good enough, feel 
free to close the bug

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

To: broulik, #frameworks, davidedmundson
Cc: mpyne, ngraham, michaelh

D11279: [FileIndexerConfig] Delay populating folders until actually used

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:76c207a14142: [FileIndexerConfig] Delay populating 
folders until actually used (authored by broulik).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11279?vs=29384=29485

REVISION DETAIL
  https://phabricator.kde.org/D11279

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h

To: broulik, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/15/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 14 Mar 2018 10:48:25 +
 Build duration:
7 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D11323: [UDevManager] Also explicitly query for cameras

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  Only camers with ID_GPHOTO2=1 are considered by the backend so we might as 
well just query for those in the first place.

TEST PLAN
  Forgot that when resurrecting David's previous patch
  
  My phone still shows up fine as "Camera" when connected via PTP instead of MTP
  
  Saves 70ms time on plasmashell startup for me (hotplugengine)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11323

AFFECTED FILES
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson
Cc: michaelh, ngraham

D11318: Support NTFS hidden files

[Roman Inflianskas]

rominf abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11318

To: rominf
Cc: #frameworks, michaelh, ngraham

D9221: [KLineEdit] Use Qt's built-in clear button functionality

[Kai Uwe Broulik]

broulik updated this revision to Diff 29479.
broulik retitled this revision from "WIP: [KLineEdit] Use Qt's built-in clear 
button functionality" to "[KLineEdit] Use Qt's built-in clear button 
functionality".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9221?vs=23546=29479

REVISION DETAIL
  https://phabricator.kde.org/D9221

AFFECTED FILES
  src/klineedit.cpp
  src/klineedit.h
  src/klineedit_p.h

To: broulik, #frameworks
Cc: michaelh, ngraham

D10809: autotests: Refactor fileindexerconfigtest

[Kai Uwe Broulik]

broulik added a comment.


  lgtm but not really an expert in `QTemporaryFile`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10809

To: michaelh, #baloo, #frameworks, ngraham
Cc: broulik, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, alexeymin

D11320: Fix QVariantMapList operator >> implementation

[Kai Uwe Broulik]

broulik added a comment.


  Is that custom marshaller even neccessary? I thought Qt could resolve QList 
and QVariantMap (even nested) automatically? Can you try just removing that 
entire thing?

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D11320

To: aleksanderm, #frameworks, jgrulich
Cc: broulik, michaelh, ngraham

D11190: Make sure we are taking into account hte size of the element when styling

[Nathaniel Graham]

ngraham added a dependent revision: D11189: Force a content size into the 
background style item.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11190

To: apol, #frameworks, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf added inline comments.

INLINE COMMENTS

> markg wrote in file_unix.cpp:546-550
> Why here?
> This should be done inside the createUDSEntry function (it's in file.cpp).

The logic behind this is that `getxattr` exists only on Linux 
(https://www.gnu.org/software/gnulib/manual/html_node/getxattr.html#getxattr) 
and `file_unix.cpp` is more Linux-y than `file.cpp`. If you think that I'm 
wrong, I can move it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, markg
Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, 
#frameworks, #dolphin, michaelh, ngraham

D11190: Make sure we are taking into account hte size of the element when styling

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:c41339d7ed30: Make sure we are taking into account hte 
size of the element when styling (authored by apol).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11190?vs=29112=29509

REVISION DETAIL
  https://phabricator.kde.org/D11190

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: apol, #frameworks, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11290: [UDevManager] Already filter for subsystem before querying

[Michael Pyne]

mpyne added a comment.


  I never had the bug myself, I just grepped through the attached log to see if 
it made sense or not.  :) I'll close the bug for now, if it doesn't fix the 
issue then it'll just get reopened.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

To: broulik, #frameworks, davidedmundson
Cc: mpyne, ngraham, michaelh

D10749: Add ECMSetupQtPluginMacroNames

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks, apol
Cc: apol, michaelh, ngraham

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/24/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 15 Mar 2018 02:32:38 +
 Build duration:
4 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: TestSuite.ktooltipwidgettest

D10749: Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D10749#225709 , @apol wrote:
  
  > LGTM
  
  
  Thanks for having had a look :)
  
  > Do you think it would be possible to come up with a test for it?
  
  Sadly no experience with cmake stuff testing and no initial idea how to write 
such tests. So would need some days of work, where I have other things more 
appealing to me :(

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: apol, michaelh, ngraham

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/7/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 15 Mar 2018 02:32:38 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: TestSuite.ktooltipwidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)30%
(4587/15123)23%
(1937/8396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1696/1715)52%
(994/1912)src44%
(52/117)44%
(52/117)24%
(2891/12280)15%
(943/6307)tests0%
(0/37)0%
(0/37)0%
(0/1128)0%
(0/177)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/32/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 15 Mar 2018 02:32:38 +
 Build duration:
6 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: TestSuite.ktooltipwidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)30%
(4576/15121)23%
(1935/8396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1696/1715)52%
(994/1912)src44%
(52/117)44%
(52/117)23%
(2880/12278)15%
(941/6307)tests0%
(0/37)0%
(0/37)0%
(0/1128)0%
(0/177)

D11346: Only set iconText() if actually changed

[Christoph Feck]

cfeck created this revision.
cfeck added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
cfeck requested review of this revision.

REVISION SUMMARY
  QAction::setIconText() breaks the feature that QAction::iconText() is 
returning text() when the iconText is empty.
  
  BUG: 391002

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D11346

AFFECTED FILES
  src/kacceleratormanager.cpp

To: cfeck, #frameworks
Cc: chehrlic, michaelh, ngraham

D10809: autotests: Refactor fileindexerconfigtest

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems sane. Code looks acceptable and the tests pass.

REPOSITORY
  R293 Baloo

BRANCH
  fileindexerconfigtest-rebuild (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10809

To: michaelh, #baloo, #frameworks, ngraham
Cc: broulik, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, alexeymin

D11315: Look first for qhelpgenerator-qt5 for help generation

[Olivier Churlaud]

ochurlaud accepted this revision.
ochurlaud added a comment.
This revision is now accepted and ready to land.


  Thx for this change

REPOSITORY
  R264 KApiDox

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11315

To: lbeltrame, #frameworks, ochurlaud
Cc: fvogt, #documentation, michaelh, ngraham, skadinna

D11331: add gaming_input devices and others to Battery

[Florian Dollinger]

dollinger created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
dollinger requested review of this revision.

REVISION SUMMARY
  automatically add new types like gaming_input, as discussed here:
  https://forum.kde.org/viewtopic.php?f=204=151433=395938#p395938
  
  especially necessary for:
  https://github.com/atar-axis/xpadneo/issues/21

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

AFFECTED FILES
  src/solid/devices/backends/upower/upowerdevice.cpp

To: dollinger
Cc: #frameworks, michaelh, ngraham

D10749: Add ECMSetupQtPluginMacroNames

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM
  Do you think it would be possible to come up with a test for it?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: apol, michaelh, ngraham

D11204: Support NTFS hidden files

[Mark Gaiser]

markg requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, markg
Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, 
#frameworks, #dolphin, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

[Florian Dollinger]

dollinger added a comment.


  Btw, this "new" type (`UP_DEVICE_KIND_GAMING_INPUT`) was added half an year 
ago ;)
  
https://cgit.freedesktop.org/upower/tree/libupower-glib/up-types.h?h=UPOWER_0_99_5
  **vs**
  
https://cgit.freedesktop.org/upower/tree/libupower-glib/up-types.h?h=UPOWER_0_99_6

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D11204: Support NTFS hidden files

[Mark Gaiser]

markg added a subscriber: dfaure.
markg added a comment.


  @dfaure I've been looking over the file.cpp and file_unix.cpp code a bit and 
i'm rather surprised that UDS_HIDDEN isn't being set at all here. Which makes 
me wonder, why is the hidden logic missing and how is it working now?
  I don't know for the "why", i'm hoping you can share some insight on this?
  I do know for the "how"; "KFileItem::isHidden()" is taking care of that. It 
checks the first character for a dot and returns true if it does (thus hidden 
for any app that uses KFileItem).
  
  Would it be OK to move this logic from KFileItem::isHidden to the file.cpp 
side? Imho, that is the right place to check as operating systems apparently 
have a different way of showing files as hidden.
  Note that this will cause regressions. IOSlaves that don't set UDS_HIDDEN 
will then show the hidden files. That imho is a bug for those respective 
IOSlaves not for KFileItem.

INLINE COMMENTS

> file_unix.cpp:546-550
> +#ifdef Q_OS_LINUX
> +if (isNtfsHidden(filename)) {
> +entry.insert(KIO::UDSEntry::UDS_HIDDEN, 1);
> +}
> +#endif

Why here?
This should be done inside the createUDSEntry function (it's in file.cpp).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, markg
Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, 
#frameworks, #dolphin, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

[Bhushan Shah]

bshah added reviewers: broulik, Plasma.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: #frameworks, michaelh, ngraham

D11330: Remove shebangs from non-executable files

[Luca Beltrame]

lbeltrame created this revision.
lbeltrame added reviewers: Frameworks, ochurlaud.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added a subscriber: Documentation.
lbeltrame requested review of this revision.

REVISION SUMMARY
  These files are meant to be used as part of the import, not directly.
  Therefore it makes no sense to have /usr/bin/env python calls on top.
  (Other files correctly don't have shebangs)

REPOSITORY
  R264 KApiDox

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11330

AFFECTED FILES
  src/kapidox/depdiagram/generate.py
  src/kapidox/hlfunctions.py

To: lbeltrame, #frameworks, ochurlaud
Cc: #documentation, michaelh, ngraham, skadinna

D11331: add gaming_input devices and others to Battery

[Алексей Шилин]

aleksejshilin added inline comments.

INLINE COMMENTS

> upowerdevice.cpp:98
> + */
> +return (uptype != 0 && uptype != 1 && uptype != 4);
>  default:

So you're changing from 'whitelist' to 'blacklist' behavior here. What will 
happen when another UPower device type is added by the upstream?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

[Florian Dollinger]

dollinger added inline comments.

INLINE COMMENTS

> aleksejshilin wrote in upowerdevice.cpp:98
> So you're changing from 'whitelist' to 'blacklist' behavior here. What will 
> happen when another UPower device type is added by the upstream?

Well then it is added automatically, which is what you would expect I think, 
and that is the reason why gaming_input wasn't detected.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

[Florian Dollinger]

dollinger added inline comments.

INLINE COMMENTS

> dollinger wrote in upowerdevice.cpp:98
> Well then it is added automatically, which is what you would expect I think, 
> and that is the reason why gaming_input wasn't detected.

But we can also do it the following way, personally I don't  care to be honest:

  return (uptype == 2 || uptype == 3 || uptype == 5 || uptype == 6 || uptype == 
7 || uptype == 8 || uptype == 12);

While `12` is `UP_DEVICE_KIND_GAMING_INPUT`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D10918: taglibextractor: Refactor for better readability

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> astippich wrote in taglibextractor.cpp:331
> I think we should check explicitly for the appropriate mimetypes here

You mean other than lines 225, 233, 240?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

D10918: taglibextractor: Refactor for better readability

[Michael Heidelbach]

michaelh added a comment.


  In D10918#225927 , @astippich 
wrote:
  
  > @mgallien as the maintainer must also give his ok.
  
  
  @mgallien: You're the maintainer of kfilemetadata? Great! I didn't know. I 
thought all of Vishesh's heritage was unmaintained.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

D11330: Remove shebangs from non-executable files

[Olivier Churlaud]

ochurlaud accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R264 KApiDox

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11330

To: lbeltrame, #frameworks, ochurlaud
Cc: #documentation, michaelh, ngraham, skadinna

D11287: Introduce baloodb CLI tool

[Nathaniel Graham]

ngraham added a comment.


  This is really nice, I like it! Should make debugging a lot easier. Noticed a 
couple of things:
  
$ baloodb -v
baloodb

$ baloodb devices
command "devices"
Listing database contents...
Device:2049 14855 items
Found 14855 matching items
Elapsed: 0.326553 secs

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks
Cc: ngraham, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11287: Introduce baloodb CLI tool

[Michael Heidelbach]

michaelh updated this revision to Diff 29524.
michaelh edited the test plan for this revision.
michaelh added a comment.


  - Add KAboutData
  - Remove debug statement

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11287?vs=29406=29524

BRANCH
  sanitize-cmd (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11287

AFFECTED FILES
  src/tools/CMakeLists.txt
  src/tools/baloodb/CMakeLists.txt
  src/tools/baloodb/Messages.sh
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: ngraham, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11285: Introduce sanitizer class

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:200
> +
> +DocumentUrlDB DatabaseSanitizer::getDocuments(Transaction* txn)
> +{

This is the best I could think of to make `getDocuments` accessible to 
DatabaseSanitizerImpl. But I don't like it.
This method definitely should not be part of the interface.

REPOSITORY
  R293 Baloo

BRANCH
  sanitize-class (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks, ngraham
Cc: ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11285: Introduce sanitizer class

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good to me!

REPOSITORY
  R293 Baloo

BRANCH
  sanitize-class (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks, ngraham
Cc: ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11287: Introduce baloodb CLI tool

[Michael Heidelbach]

michaelh updated this revision to Diff 29525.
michaelh added a comment.


  - Remove obsolete include

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11287?vs=29524=29525

BRANCH
  sanitize-cmd (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11287

AFFECTED FILES
  src/tools/CMakeLists.txt
  src/tools/baloodb/CMakeLists.txt
  src/tools/baloodb/Messages.sh
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: ngraham, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10918: taglibextractor: Refactor for better readability

[Alexander Stippich]

astippich requested changes to this revision.
astippich added a comment.
This revision now requires changes to proceed.


  Looks good imho, just one small comment inline. of course, @mgallien as the 
maintainer must also give his ok.

INLINE COMMENTS

> taglibextractor.cpp:331
> +} else {
> +extractOgg(stream, mimeType, data);
>  }

I think we should check explicitly for the appropriate mimetypes here

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

D11287: Introduce baloodb CLI tool

[Michael Heidelbach]

michaelh added a comment.


  In D11287#225860 , @ngraham wrote:
  
  > This is really nice, I like it! Should make debugging a lot easier. Noticed 
a couple of things:
  
  
  This is how the output now does and should look.
  
$ baloodb devices
Listing database contents...
Device:22 3 items 
Device:43 76 items
Device:42 3627 items
Device:41 40 items
Device:2053 6438 items
Device:2049 22 items
Device:2069 1533 items
Device:2066 11643 items
Device:2064 99 items
Device:2086 220 items
Device:2098 1450 items
Found 25151 matching items
Elapsed: 4.42067 secs
  
  or
  
$ baloodb devices 2>/dev/null
Device:22 3 items
Device:41 40 items
Device:42 3627 items
Device:43 76 items
Device:2069 1533 items
Device:2064 99 items
Device:2066 11643 items
Device:2053 6438 items
Device:2049 22 items
Device:2098 1450 items
Device:2086 220 items
  
  Are there more things?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks
Cc: ngraham, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10918: taglibextractor: Refactor for better readability

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> taglibextractor.cpp:157
> +if (itAlbumArtists != allTags.end()) {
> +data.albumArtists = 
> itAlbumArtists->second.toStringList().toString(", ");
>  }

This is an example for what we're discussing. Why the join??? We might lose 
info, when the album artist contains a comma.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, 
alexeymin

D11342: Include the "stdcpp-path" in the json file

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
apol requested review of this revision.

REVISION SUMMARY
  qmake also generates it and androiddeployqt consumes it.

TEST PLAN
  built and ran kalgebra

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11342

AFFECTED FILES
  toolchain/deployment-file.json.in

To: apol, #frameworks
Cc: #build_system, michaelh, ngraham

D11315: Look first for qhelpgenerator-qt5 for help generation

[Luca Beltrame]

This revision was automatically updated to reflect the committed changes.
Closed by commit R264:27a1126b1d79: Look first for qhelpgenerator-qt5 for help 
generation (authored by lbeltrame).

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11315?vs=29468=29538

REVISION DETAIL
  https://phabricator.kde.org/D11315

AFFECTED FILES
  src/kapidox/generator.py

To: lbeltrame, #frameworks, ochurlaud
Cc: fvogt, #documentation, michaelh, ngraham, skadinna

D11330: Remove shebangs from non-executable files

[Luca Beltrame]

This revision was automatically updated to reflect the committed changes.
Closed by commit R264:642fd8a06fca: Remove shebangs from non-executable files 
(authored by lbeltrame).

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11330?vs=29501=29539

REVISION DETAIL
  https://phabricator.kde.org/D11330

AFFECTED FILES
  src/kapidox/depdiagram/generate.py
  src/kapidox/hlfunctions.py

To: lbeltrame, #frameworks, ochurlaud
Cc: #documentation, michaelh, ngraham, skadinna