[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #7 from Magnus Enger --- Created attachment 39112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39112&action=edit Bug 14189 - [SIGNED-OFF] Made text persist when clicking the tabs under the searchbox To test: Apply the patch and see that the text now is there in the search box when clicking the tabs: check in, check out etc.. (More files changed for persistent text in searchbox) Sponsored-by: Halland County Library http://bugs.koha-community.org/show_bug.cgi?id=14189 Signed-off-by: Magnus Enger This is something I have wanted quite a few times over the years... Tested by going to every main area of Koha, entering some random text into the search box and then clicking on all the available tabs to check that the entered text is carried over to all the boxes. There are a couple of places where text is not carried over, but I guess that might be because one of the boxes is structurally different to the others. These are: - "Vendor search" and "Orders search" in Acquisitions - "Search subscriptions" in Serials I have not looked at how this is implemented, just that it works as it should. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no Attachment #39110|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #8 from Eivin Giske Skaaren --- What Magnus discovered with the few places it is not implemented was done intentionally as it did not make sense from a UX perspective for example when there is 2 search boxes on one tab and 1 on the other. It should work for most daily use cases where this would be helpful. The templates should probably at some point be refactored since there was some duplication of HTML, but that is not needed for this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 --- Comment #8 from Katrin Fischer --- I have tried to check the checkbox with jQuery, but it doesn't work quite right - the checkbox is checked, but the checkouts don't load... I think this patch would improve things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14193] New: Accessibility: Searching patrons using the alphabetic index doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Bug ID: 14193 Summary: Accessibility: Searching patrons using the alphabetic index doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It's not possible to use the alphabetic index search using only the keyboard. The librarian reporting this is using braille line, screenreader and keyboard for navigating and using Koha. After selecting a character from the alphabetic index list and pressing enter to trigger the feature, the table of patrons is loaded, but it always shows 'no results found', even if there are patrons for that letter in the database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 --- Comment #9 from Katrin Fischer --- Argh, I see now that this is already in 3.18. Sorry for the confusion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 --- Comment #3 from Katrin Fischer --- I realized that the patch Owen pointed to is already in 3.18, but this is still a problem to the library - maybe because of restrictive cookie settings? In general it would be nice if there was an option to just always load and get rid of the checkbox for some libraires. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 Indranil Das Gupta changed: What|Removed |Added Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 --- Comment #2 from Indranil Das Gupta --- Comment on attachment 39057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39057 Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl Review of attachment 39057: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14186&attachment=39057) - Hi Aleisha, Would you be considering making the small change mtomp...@hotmail.com suggested in bug 14185, comment 3 for this patch? If you do, then I'll wait for your update, before I sign off on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 Indranil Das Gupta changed: What|Removed |Added Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14184] Noisy warns in C4/CourseReserves.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184 Indranil Das Gupta changed: What|Removed |Added Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Indranil Das Gupta changed: What|Removed |Added Assignee|gmcha...@gmail.com |wsale...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Indranil Das Gupta changed: What|Removed |Added CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14192] Noisy warns in Koha/XSLT_Handler.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14192 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #0) > Module isn't locating XSLT file. Please provide more information. Or copy the error log line here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #5 from Kyle M Hall --- (In reply to Katrin Fischer from comment #4) > I think Sheila has a good point - maybe the dependence on HomeOrHolding is > not the best option here and we need something that is a bit more flexible? > > Only other thing is maybe the column name - refund_lost_item_fee_on_return > is quite a bit to write, maybe just refund_lost_on_return? :) (In reply to Jonathan Druart from comment #2) > The plan of attack looks good to me. > I am just wondering if the field branches.refund_lost_item_fee_on_return > makes sense. > Don't you think it would be better to set this rule in the "Circulation and > fine rules" page (admin/smart-rules.pl)? It would be easy to change the > behavior for all libraries (if only a default rule is defined). Jonathan, I believe moving this to the circulation rules is at odds with what Sheila is looking for. The only way to make both work will be to add a new system preference to choose which circulation rule to select. Something like RefundLostOnReturnControl. The options could be CheckinLibrary, PatronLibrary, ItemHomeBranch and ItemHoldingbranch. What do you think? Given this, should we still make this a circulation rule setting? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #6 from Kyle M Hall --- (In reply to Katrin Fischer from comment #4) > I think Sheila has a good point - maybe the dependence on HomeOrHolding is > not the best option here and we need something that is a bit more flexible? See above for a new idea! > Only other thing is maybe the column name - refund_lost_item_fee_on_return > is quite a bit to write, maybe just refund_lost_on_return? :) Sure! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #13 from Kyle M Hall --- (In reply to Robin Sheat from comment #12) > How does this compare to bug 13413? > > As for the packaging stuff, what Tomás says looks like the right idea to me, > it shouldn't be too complicated. The biggest advantages of this patch vs bug 13413 are a) Simplicity of implementation b) Incredibly powerful configurability by just editing a configuration file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13839] Force item holds on item type level
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13839 Marcel de Rooy changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #2) > Hi Marcel - can this be closed with the new option in the circulation > conditions? Yes, I assume so :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #37 from Julian Maurice --- New version of Swagger2 on CPAN (0.31) now requires Mojolicious 5.54 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Tomás Cohen Arazi changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11599] itemBarcodeFallbackSearch should work even for items that don't have barcodes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11599 Jeremy Evans changed: What|Removed |Added CC||jeremy.ev...@nibsc.org --- Comment #2 from Jeremy Evans --- I encountered this problem earlier. We had received a couple of new books required urgently by one of our users so they were sent straight to him. Therefore I was not able to put a barcode into the books when cataloguing/issuing them. When I tried to issue them to the user the books did not appear on the list of titles if I did a title search in the checkout. one other point - a filter on the holding library would be useful here as it brings up a long list of items held by other branches without giving details of the location. I got round the issuing problem using the method Galen mentioned - i.e. using a dummy barcode in the format of temp1234. On the default item view screen there is a place hold button so maybe an additional checkout link from there would be another useful way to handle these items. Or a checkout link from the list of holds? The barcode not being in the book/item record when it is returned would not be a problem for us - as we would at that point edit the item to put in a barcode number. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38926|0 |1 is obsolete|| --- Comment #326 from Bernardo Gonzalez Kriegel --- Created attachment 39113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39113&action=edit [SIGNED-OFF] Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38927|0 |1 is obsolete|| --- Comment #327 from Bernardo Gonzalez Kriegel --- Created attachment 39114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39114&action=edit [SIGNED-OFF] Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38928|0 |1 is obsolete|| --- Comment #328 from Bernardo Gonzalez Kriegel --- Created attachment 39115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39115&action=edit [SIGNED-OFF] Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.765.066.7100.0 100.00.286.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38929|0 |1 is obsolete|| --- Comment #329 from Bernardo Gonzalez Kriegel --- Created attachment 39116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39116&action=edit [SIGNED-OFF] Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38931|0 |1 is obsolete|| --- Comment #331 from Bernardo Gonzalez Kriegel --- Created attachment 39118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39118&action=edit [SIGNED-OFF] Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38930|0 |1 is obsolete|| --- Comment #330 from Bernardo Gonzalez Kriegel --- Created attachment 39117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39117&action=edit [SIGNED-OFF] Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38932|0 |1 is obsolete|| --- Comment #332 from Bernardo Gonzalez Kriegel --- Created attachment 39119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39119&action=edit [SIGNED-OFF] Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38933|0 |1 is obsolete|| --- Comment #333 from Bernardo Gonzalez Kriegel --- Created attachment 39120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39120&action=edit [SIGNED-OFF] Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN - 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38934|0 |1 is obsolete|| --- Comment #334 from Bernardo Gonzalez Kriegel --- Created attachment 39121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39121&action=edit [SIGNED-OFF] Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, in that the protocol is assumed in the OpacBaseURL system preference. It also adds improved error handling. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38935|0 |1 is obsolete|| --- Comment #335 from Bernardo Gonzalez Kriegel --- Created attachment 39122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39122&action=edit [SIGNED-OFF] Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #38936|0 |1
is obsolete||
--- Comment #336 from Bernardo Gonzalez Kriegel ---
Created attachment 39123
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39123&action=edit
[SIGNED-OFF] Bug 6874: Catch warnings for clean tests.
I hate noisy tests, so I cleaned them up.
MEGA TEST PLAN
--
git checkout -b bug_6874 origin/master
git bz apply 6874
-- yes, it should all apply smoothly.
I intentionally restored an old backup from a couple months ago to force the
upgrade.
staff client:
-- upgrade
-- login
Koha administration
MARC Bibliographic framework
MARC structure (for BKS)
Search for 856
Subfields
Edit (for u)
Other options
Plugin: upload.pl
Save changes
Search the catalog tab
{choose a word, any word. I used fancy, because I knew we had a cookbook}
click first link
Edit
Edit record
8 (that's the tab name)
click the name for 856
scroll down to u and click the plugin icon
-- Correctly got a configuration error message.
At a command prompt:
vi ~/koha-dev/etc/koha-conf.xml
/enable_plug
-- add in:
{appropriate path. I used /home/mtompset/uploads}
:wq
mkdir {appropriate path used}
-- I even added some subdirectories
sudo chown -R -v www-data.www-data {appropriate path used}
Back in staff client:
click the plugin icon again
-- this time an upload screen pops up
click the 'Upload file' button
-- message about no file or destination
browse for a file, select one
click the 'Upload file' button
-- message about no destination
click the 'Cancel' button
click the plugin icon
click a destination radio button
click the 'Upload file' button
-- message about no file
browse for a file, select one
click the 'Upload file' button
-- message about success
click the 'close' button.
-- the text box has been filled in with a nice URL
click the plugin icon
click cancel
click the plugin icon
click delete
-- the test box should be blanked, and a success message given
click Close
-- reupload a file properly
click the plugin icon
click delete
click upload file
browse for a file, select a destination, click upload file
click close on success message
click 'Clone this subfield'
click the second plugin icon
click delete
click close
click the first plugin icon
-- Nice error message about a URL which points to nothing.
click cancel
In the second 856$u type in a URL (eg. www.google.com)
click the second plugin icon
-- this jumps immediately to the upload screen, but does not give an error
message, because the URL does not have opac-retrieve-file in it.
click save (we need to save the bibliographic record)
In OPAC:
search for the same word (I used fancy)
find the entry you just updated with links
click the two links. The dangling entry should give you a 500 error, and the
other link should work just fine.
get back to the detail page
In staff client:
edit
edit record
8
change the 856$u to a valid file in the first link.
save
In OPAC:
refresh the detail page, and click the first link again
this time it should get downloaded nicely.
>From a command line:
prove -v t/db_dependent/UploadedFiles.t
perldoc C4::Biblio
perldoc C4::UploadedFiles
One more round of tests tomorrow, and this should be ready. :)
Signed-off-by: Bernardo Gonzalez Kriegel
Tested on top of 5010
Followed mostly mega test plan, seems to work :)
Can upload, delete, modify, etc
Test runs Ok
No koha-qa errors
I view this as valuable addition, dangling since 2011!
As with 5010, I consider this can be pushed (for 3.22)
and we can fix anything wrong later.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #40 from Kyle M Hall --- Created attachment 39125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39125&action=edit Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What|Removed |Added Attachment #36692|0 |1 is obsolete|| Attachment #36693|0 |1 is obsolete|| Attachment #36694|0 |1 is obsolete|| Attachment #36695|0 |1 is obsolete|| Attachment #36696|0 |1 is obsolete|| --- Comment #39 from Kyle M Hall --- Created attachment 39124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39124&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #42 from Kyle M Hall --- Created attachment 39127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39127&action=edit Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #43 from Kyle M Hall --- Created attachment 39128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39128&action=edit Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #41 from Kyle M Hall --- Created attachment 39126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39126&action=edit Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart changed: What|Removed |Added Blocks||14194 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] New: Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Bug ID: 14194 Summary: Date due for on-site checkouts defaults to 00:00 for hh:mm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: jonathan.dru...@biblibre.com Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 13601 Introduced by bug 13601. To reproduce: 1/ Enable On-site checkouts 2/ Go on the checkouts page 3/ Click on the "On-site checkout" checkbox => The default date due is today with 00:00 as hh:mm instead of 23:59 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14195] New: TestBuilder does not generate the good length for text fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Bug ID: 14195 Summary: TestBuilder does not generate the good length for text fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@biblibre.com Reporter: jonathan.dru...@biblibre.com QA Contact: gmcha...@gmail.com Depends on: 12603 t::lib::TestBuilder::_gen_text does not use correctly the regex and the max parameter to generate the random string (String::Random). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Jonathan Druart changed: What|Removed |Added Blocks||14195 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #36489|0 |1 is obsolete|| --- Comment #86 from Bernardo Gonzalez Kriegel --- Created attachment 39129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39129&action=edit [SIGNED-OFF] Bug 7683: Cataloguing statistics wizard improvements - Add 3 options for cells value - Titles count "COUNT (biblionumber)" - Items count "COUNT (itemnumber)" (current behavior) - Deleted items count "COUNT (deleteditems.itemnumber)" - Add to selectable rows, colums and filters: - items.notforloan - items.materials - items.statisticvalue For each of these fields, retrieve the label in the default cataloging framework. If no MARC field is mapped to the field in question, it does not show this line in the wizard. If the MARC field is associated with a list of authorized values, it displays a dropdown list for the filter, otherwise it displays a text field. - Add to selectable rows, columns and filters: - items.dateaccessioned (creation date) - deleteditems.timestamp (deletion date) (Only if the third option (eg count deleted items) is selected) - Add unit tests for GetMarcSubfieldStructureFromKohaField Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Owen Leonard Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #36491|0 |1 is obsolete|| --- Comment #88 from Bernardo Gonzalez Kriegel --- Created attachment 39131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39131&action=edit [SIGNED-OFF] Bug 7683: Remove use of items.statisticvalue and DHTMLcalendar() Also fix indexes of @filters array Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #36490|0 |1 is obsolete|| --- Comment #87 from Bernardo Gonzalez Kriegel --- Created attachment 39130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39130&action=edit [SIGNED-OFF] Bug 7683: [Follow-up] Move unit tests in t/db_dependent/Biblio.t Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #36493|0 |1 is obsolete|| --- Comment #90 from Bernardo Gonzalez Kriegel --- Created attachment 39133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39133&action=edit [SIGNED-OFF] Bug 7683: Fix a shift in date filter indexes Date filter indexes are 13, 14, 15, 16, not 14, 15, 16, 17 Signed-off-by: Bernardo Gonzalez Kriegel Works, no koha-qa errors (some message for the deleted file) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #36492|0 |1 is obsolete|| --- Comment #89 from Bernardo Gonzalez Kriegel --- Created attachment 39132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39132&action=edit [SIGNED-OFF] Bug 7683: Remove dead code about dewey and lccn filters $hasdewey and $haslccn were hardcoded to 0 Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Bernardo Gonzalez Kriegel --- Sorry, this patchset references files from OPAC prog :( CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt deleted in HEAD and modified in Bug 7706 - Do not display authorized value image if url is empty. Version Bug 7706 - Do not display authorized value image if url is empty of koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt left in tree. CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt deleted in HEAD and modified in Bug 7706 - Do not display authorized value image if url is empty. Version Bug 7706 - Do not display authorized value image if url is empty of koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt left in tree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194
--- Comment #1 from Jonathan Druart ---
Created attachment 39134
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39134&action=edit
Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts
(Introduced by bug 13601)
Test plan:
1/ Enable On-site checkouts
2/ Go on the checkouts page
3/ Click on the "On-site checkout" checkbox
=> The default date due should be today with 23:59 as HH:MM (not 00:00).
Technical note: There is a confusion with iso and sql date formats at
some places in the code.
A better way should be provided (later) to fix globally the mismatch
between these 2 formats.
What happened before this patch: the DateTime was cast to a string and
the template received "-MM-DDTHH:MM:SS" which is an iso formatted
date. BUT this format is not managed by Koha::DateUtils::output_pref
("iso" and "sql" are considered as indentical which is wrong).
As I did not estimated the problem (how big it is) I prefer to fix it
easily (and dirty) for now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #11 from Fridolin SOMERS --- Created attachment 39135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39135&action=edit Bug 14053 - Acquisition db tables are missing indexes Acquisition db tables are missing some indexes to have performance queries. This patch adds an index on some columns very often used in search queries, such as aqbooksellers.name and aqbudgets.budget_code. Also adds an index on aqorders.orderstatus, very often used with hardcoded value like 'cancelled', in various queries. Test plan : - Check SQL syntax is correct - Try to compare performance after and before database update. I think query contained in C4::Acquistion::GetInvoices could be a good example -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #12 from Fridolin SOMERS --- Created attachment 39136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39136&action=edit Bug 14053 - Acquisition db tables are missing indexes - atomicupdates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #13 from Fridolin SOMERS --- Patches updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14196] New: Encoding error adding new biblio in custom framework
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14196 Bug ID: 14196 Summary: Encoding error adding new biblio in custom framework Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: pablo.jime...@ext.satec.es QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Hi. I have created my own framework (from BKS), with less fields in the structure, and with new Labels in spanish. When I try to add a new record (biblio) with ñ or Ñ character, the h1 field remove those characters, and diacritical marks are showed wrong (Jiménez as Jimňez). The info in the database is correct. This is not happening in detail.tt OS: CenOS 7 Locale: LANG=es_ES.utf8 LC_CTYPE="es_ES.utf8" LC_NUMERIC="es_ES.utf8" LC_TIME="es_ES.utf8" LC_COLLATE="es_ES.utf8" LC_MONETARY="es_ES.utf8" LC_MESSAGES="es_ES.utf8" LC_PAPER="es_ES.utf8" LC_NAME="es_ES.utf8" LC_ADDRESS="es_ES.utf8" LC_TELEPHONE="es_ES.utf8" LC_MEASUREMENT="es_ES.utf8" LC_IDENTIFICATION="es_ES.utf8" LC_ALL= Apache with AddDefaultCharset UTF-8 Mysql 5.6 char variables: +--++ | Variable_name| Value | +--++ | character_set_client | utf8 | | character_set_connection | utf8 | | character_set_database | utf8 | | character_set_filesystem | binary | | character_set_results| utf8 | | character_set_server | utf8 | | character_set_system | utf8 | | character_sets_dir | /usr/share/mysql/charsets/ | +--++ Regards. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14196] Encoding error adding new biblio in custom framework
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14196 --- Comment #1 from pablo.jime...@ext.satec.es --- I was wrong about the data in database, after a query it looks like is double utf-8 encoded SELECT title, LENGTH(title), CHAR_LENGTH(title) FROM biblio WHERE LENGTH(title) != CHAR_LENGTH(title); +--+---++ | title| LENGTH(title) | CHAR_LENGTH(title) | +--+---++ | España | 7 | 6 | | ÑAM | 4 | 3 | | ñññí | 8 | 4 | | Ñam3 | 5 | 4 | | ÑM | 7 | 6 | | ñ|10 | 5 | | eñí | 9 | 7 | | bbbíóo |20 | 14 | +--+---++ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194
Jonathan Druart changed:
What|Removed |Added
Attachment #39134|0 |1
is obsolete||
--- Comment #2 from Jonathan Druart ---
Created attachment 39137
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39137&action=edit
Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts
(Introduced by bug 13601)
Test plan:
1/ Enable On-site checkouts
2/ Go on the checkouts page
3/ Click on the "On-site checkout" checkbox
=> The default date due should be today with 23:59 as HH:MM (not 00:00).
Technical note: There is a confusion with iso and sql date formats at
some places in the code.
A better way should be provided (later) to fix globally the mismatch
between these 2 formats.
What happened before this patch: the DateTime was cast to a string and
the template received "-MM-DDTHH:MM:SS" which is an iso formatted
date. BUT this format is not managed by Koha::DateUtils::output_pref
("iso" and "sql" are considered as indentical which is wrong).
As I did not estimated the problem (how big it is) I prefer to fix it
easily (and dirty) for now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 --- Comment #1 from Jonathan Druart --- Created attachment 39138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39138&action=edit Bug 14105: TestBuilder - A random string should not be longer than the DB field t::lib::TestBuilder::_gen_text does not use correctly the regex and the max parameter to generate the random string (String::Random). This can cause future tests to fail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 --- Comment #2 from Jonathan Druart --- Created attachment 39139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39139&action=edit To reproduce the issue Launch this script several times, without applying the patch. If the generated string for categorycode has a length > 10, you will see a difference. After applying the patch, the difference should never occur. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #6 from Marcel de Rooy --- Created attachment 39142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39142&action=edit Bug 13437: Trivial edits on marc21 plugins before conversion marc21_field_003.pl: copy-pasta comment about date removed marc21_field_005.pl: commented use removed marc21_field_006.pl: old/irrelevant pod lines marc21_field_007.pl: old/irrelevant pod lines marc21_field_008.pl: old/irrelevant pod lines, move sub par line twice marc21_field_008_authorities.pl: whitespace, old/irrelevant pod lines marc21_field_040c.pl: two commented lines removed marc21_field_040d.pl: whitespace, commented lines, old/irrelevant pod marc21_field_245h.pl: whitespace marc21_linking_section.pl: relocated some comment lines, and replaced a new CGI object by the one passed in via the plugin launcher (agreed, this may not be so trivial as the other changes) Test plan: These (trivial) changes are hard to test. Pick a few plugins and verify that behavior is not changed in the marc editor. For the brave: Try marc21_linking_section.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #5 from Marcel de Rooy --- Created attachment 39141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39141&action=edit Bug 13437: Preliminary changes for marc21 plugins field 008 Preliminary work on marc21_field_008.pl and 008_authorities.pl. Moving $dateentered en $defaultval to lower scope level. Test plan: Use both plugins in the marc21 editor (biblios/authorities). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What|Removed |Added Attachment #39093|0 |1 is obsolete|| Attachment #39095|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 39140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39140&action=edit Bug 13437: Perltidy some plugin files before conversion Preliminary work before converting to new plugin style. Several files still contained tabs or had strange indentation. Perltidied: marc21_linking_section.pl Perltidied: marc21_field_007.pl Perltidied: marc21_leader_authorities.pl Perltidied: marc21_leader.pl Perltidied: marc21_leader_book.pl Perltidied: marc21_leader_computerfile.pl Perltidied: marc21_leader_video.pl Test plan: Run perltidy -pro=xt/perltidyrc on marc21_linking_section and compare. Try another one too :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #7 from Marcel de Rooy --- Two more coming -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #37028|0 |1 is obsolete|| --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 39143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39143&action=edit [SIGNED-OFF] Bug 7793: Simplify db update Since message_id is not linked to anything else in the database, we can ensure the message_id's are unique by simply dropping the column and recreating it. Signed-off-by: Bernardo Gonzalez Kriegel Moved updatedatabase to atomicupdate First patch signed. No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m CC||jonathan.dru...@biblibre.co ||m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #91 from Marc Véron --- Created attachment 39144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39144&action=edit [Signed-off] Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears http://bugs.koha-community.org/show_bug.cgi?id=13068 Author:Maxime Beaulieu Followed test plan. Works as described. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194
Indranil Das Gupta changed:
What|Removed |Added
Attachment #39137|0 |1
is obsolete||
--- Comment #3 from Indranil Das Gupta ---
Created attachment 39145
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39145&action=edit
Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts
(Introduced by bug 13601)
Test plan
=
1/ enable 'OnSiteCheckouts' pref under Circulation Preferences
2/ go to the checkouts page and try to issue an item to any user.
3/ when the item barcode entry form shows, select the 'On-site
checkout' checkbox
4/ the default date due should show as today with 00:00 as HH:MM
5/ apply the patch
6/ repeat steps 2 - 3. The default date due should show today's
date with 23:59 as HH:MM.
7/ run koha-qa.pl -c 1 -v 2
Remarks: Testing result match expected test plan output. The QA tests
pass with "OK" for the commit.
Technical note: There is a confusion with iso and sql date formats at
some places in the code.
A better way should be provided (later) to fix globally the mismatch
between these 2 formats.
What happened before this patch: the DateTime was cast to a string and
the template received "-MM-DDTHH:MM:SS" which is an iso formatted
date. BUT this format is not managed by Koha::DateUtils::output_pref
("iso" and "sql" are considered as indentical which is wrong).
As I did not estimated the problem (how big it is) I prefer to fix it
easily (and dirty) for now.
Signed-off-by: Indranil Das Gupta (L2C2 Technologies)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Indranil Das Gupta changed: What|Removed |Added CC||indr...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc Véron changed: What|Removed |Added Attachment #39049|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Indranil Das Gupta changed: What|Removed |Added CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] New: Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Bug ID: 14197 Summary: Warning raised by TestBuilder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@biblibre.com Reporter: jonathan.dru...@biblibre.com QA Contact: gmcha...@gmail.com (in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 318 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #1 from Jonathan Druart --- Created attachment 39146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39146&action=edit Bug 14197: Remove the warning on destroying TestBuilder objects This module will be called by db_dependent tests, which already create a transaction. TestBuilder creates a new one (which is certainly useless) and the rollback does not do anything. To see the warning see patches on bug 14045. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14197 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14045 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Jonathan Druart changed: What|Removed |Added Blocks||14045 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What|Removed |Added Depends on||14194 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045
--- Comment #1 from Jonathan Druart ---
Created attachment 39147
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39147&action=edit
Bug 14045: Add specific quotas to on-site checkouts
This patch set adds the ability to defined independent quotas for on-site
checkouts.
This will be done using the circulation rules matrix where a new column
“Current on-site checkouts allow” will be added.
This feature is going to use the same method as the existing fields maxissueqty
("Current checkouts allowed"), the new fields will be added to the
different tables (see the "DB changes" patch) and will be named
maxonsiteissueqty (for consistency).
In order to keep the existing behavior and to let more flexibility,
a new system preference is added (ConsiderOnSiteCheckoutsAsNormalCheckouts).
This syspref will let the liberty to the library to decide if an on-site
checkout should be considered as a "normal" checkout or not.
To keep the existing behavior, the syspref will be disabled (i.e. an on-site
checkout is considered as a normal checkout) and the number of on-site
checkouts will be the same as the number of checkout (maxissueqty ==
maxonsiteissueqty).
Technically:
There are only very few tests for the Circulation module, and the 2
subroutines impacted by this patch set were not tested at all.
It is necessary to introduce non-regression tests for this area.
The 2 subroutines are: C4::Circulation::GetBranchBorrowerCircRule
and C4::Circulation::TooMany (only called by
C4::Circulation::CanBookBeIssued, so we will take the liberty to change
the prototype to raise a better warning to the end user).
Test plan:
I. Confirm there is no regression and the existing behavior is kept
0/ Let the syspref disabled
1/ Set a rule to limit to 2 the number of checkouts allowed
2/ Do a normal checkout
3/ Do an on-site checkout
4/ Try to checkout (on-site or normal) an item again.
You should not be allowed.
II. Test the new feature - pref disabled
0/ Let the syspref disabled
1/ Set a rule to limit to 2 the number of checkouts allowed and to 1
the number of on-site checkouts allowed.
2/ Do an on-site checkout
3/ Try to do another one, you should not be allowed to do it.
4/ A normal checkout should pass successfully
Note that it does not make sense to have the number of on-site checkouts
alowed > number of checkouts allowed.
III. Test the new feature - pref enabled
0/ Enable the syspref
Now an on-site checkout is *not* counted as a normal checkout.
This means you can have the number of on-site checkouts > number of
checkouts allowed.
1/ Set the values you want for the 2 types of checkouts (normal vs
on-site).
2/ Even if a patron has reached the maximum of checkouts allowed, he
will be allowed to do a on-site checkout (vice versa).
IV. Stress the developper
Using the different configurations available in the circulation matrix,
try to find one where the checkout is allowed and not should be.
Sponsored-by: BULAC - http://www.bulac.fr/
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #2 from Jonathan Druart --- Created attachment 39148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39148&action=edit Bug 14045: Change prototype of TooMany to raise a better warning With this patch, the user will know why the checkout is refused. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #3 from Jonathan Druart --- Created attachment 39149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39149&action=edit Bug 14045: Introduce the maxonsiteissueqty field as a copy of maxissueqty This patch adds the new fields maxonsiteissueqty as a copy of the existing maxissueqty field. There is no brainy code here, it only adds the ability to fill the new field from the admin interface (admin/smart-rules.pl). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #6 from Jonathan Druart --- Created attachment 39152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39152&action=edit Bug 14045: DBIC Changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #5 from Jonathan Druart --- Created attachment 39151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39151&action=edit Bug 14045: DB Changes This patch is the DB changes for the feature. It adds 5 new columns named 'maxonsiteissueqty' to the following tables: - branch_borrower_circ_rules - default_borrower_circ_rules - default_branch_circ_rules - default_circ_rules - issuingrules It also adds the pref ConsiderOnSiteCheckoutsAsNormalCheckouts. See main patch for more details. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #4 from Jonathan Druart --- Created attachment 39150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39150&action=edit Bug 14045: Make GetBranchBorrowerCircRule return maxonsiteissueqty GetBranchBorrowerCircRule should return the value for maxissueqty and maxonsiteissueqty. It's what this patch does. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
CC||bgkrie...@gmail.com
Status|Needs Signoff |Failed QA
--- Comment #32 from Bernardo Gonzalez Kriegel ---
Hi,
on your first patch you add on kohastructure.pl
`printed` tinyint(1) DEFAULT NULL,
for reserves and old_reserves
But on final updatedatabase.pl (needs to be on atomicupdate!), you
"only" alter reserves but using a different type
$dbh->do("ALTER TABLE reserves ADD printed DATETIME NULL AFTER suspend_until");
Both patches have conflicts
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Jonathan Druart changed: What|Removed |Added Blocks||14045 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What|Removed |Added Depends on||14195 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What|Removed |Added Blocks||5010 Depends on|5010| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What|Removed |Added Blocks|14111 | Depends on||14111 --- Comment #103 from M. Tompsett --- I may have gotten the Depends on direction wrong for the: prove t/Auth_with_shibboleth.t I retested all this yesterday on the kohadev box. I ended up making the same sorts of changes that are in bug 14111 in order for it to pass the t/Auth_with_shibboleth.t tests. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #7 from Indranil Das Gupta --- Comment on attachment 39151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39151 Bug 14045: DB Changes Review of attachment 39151: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14045&attachment=39151) - Hi Jonathan, I've a newbie question. Why are you putting in this code in the updatedatabase.pl, instead of in the atomicupdates? Or did I get it wrong? http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39151&action=diff#a/installer/data/mysql/updatedatabase.pl_sec1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #1) > (In reply to Kyle M Hall from comment #0) > > In previous versions of Koha, a marc modfication rules like "Copy field > > XXX$Y to 952$x" would add the field to an existing 952 field if there was > > one already, and only create a 952 field if none existed. Now an entirely > > new 952 field is created to store the subfield even if there is already one! > > Hello Kyle, > I would say it's the way it should work. > Or maybe should we create a new action and let the choice to the user? Owen has created a template that relied on the previous behavior, so I think it's a regression. However, if adding a new behavior would allow him to get his previous template to work by changing its' rules, that seems like a fine compromise. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
