[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #105 from Jonathan Druart --- You can still add your signed-off-by stamp on the patch set to tell QA you agree with it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26124] Console errors on tools_koha-news when editing with TinyMCE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26124 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26124] Console errors on tools_koha-news when editing with TinyMCE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26124 ByWater Sandboxes changed: What|Removed |Added Attachment #107725|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 107726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107726&action=edit Bug 26124: Load TinyMCE assets in correct order 1. Make sure NewsToolEditor is set to TinyMCE 2. Go to Home › Tools › News › Add news item 3. Observe console error 4. Apply patch 5. No console error Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26131] console errors when attempting to open SCO related system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26131] console errors when attempting to open SCO related system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 ByWater Sandboxes changed: What|Removed |Added Attachment #107722|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 107727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107727&action=edit Bug 26131: Remove parentheses in circulation.pref To test: 1. Search for a SCO system preference like SCOUserJS. 2. Note that there is a console error on that screen and you cannot open editor. 3. Apply patch 4. Reload the page. 5. No more console error and you can now edit the system pref! Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25906] Style corrections for OPAC serial pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Timothy Alexis Vass changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Timothy Alexis Vass --- Looks great in both Firefox and Chrome. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jonathan Druart changed: What|Removed |Added Blocks||26132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 [Bug 26132] Improve readability of TooMany -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] New: Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Bug ID: 26132 Summary: Improve readability of TooMany Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 21946 This is a follow-up of bug 21946. We need to improve the readability of C4::Circulation::TooMany to prevent regressions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 [Bug 21946] Group circulation by item type -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107676|0 |1 is obsolete|| --- Comment #76 from Martin Renvoize --- Created attachment 107728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107728&action=edit Bug 24201: (QA follow-up) Do not unbless a list from search in Desks template plugin Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107677|0 |1 is obsolete|| --- Comment #77 from Martin Renvoize --- Created attachment 107729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107729&action=edit Bug 24201: (QA follow-up) Remove unneeded use Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107680|0 |1 is obsolete|| --- Comment #80 from Martin Renvoize --- Created attachment 107732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107732&action=edit Bug 24201: (QA follow-up) Make desk and branch selects on login page consistant Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107678|0 |1 is obsolete|| --- Comment #78 from Martin Renvoize --- Created attachment 107730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107730&action=edit Bug 24201: (QA follow-up) Fix desks select box selected attribute Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107679|0 |1 is obsolete|| --- Comment #79 from Martin Renvoize --- Created attachment 107731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107731&action=edit Bug 24201: (QA follow-up) Remove setdesk variable and add desk selection script only on pages in need Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #81 from Martin Renvoize --- Thanks for the additional followups and QA run Josef.. I've verified the followups all make sense so setting to PQA as it's had two QA team eyes on it now :) Great work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #135 from Jonathan Druart --- Created attachment 107733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107733&action=edit Bug 21946: Restore defined vs "" The tests still pass. Was the original change really useful? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #1 from Jonathan Druart --- Created attachment 107734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107734&action=edit Bug 26132: TooMany refactoring The different calls to _check_max_qty can be improved to highlight what is really changing between each of them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #136 from Jonathan Druart --- Nick, I did not find a reason for this change (see last patch), what do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #3 from Jonathan Druart --- Created attachment 107736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107736&action=edit Bug 26132: Remove raw SQL query for patron_maxissueqty Same as before but for patron_maxissueqty -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #2 from Jonathan Druart --- Created attachment 107735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107735&action=edit Bug 26132: Remove raw sql query Making use of Koha::Checkouts make the code much more readable here. It fixes 2 flaws: * $type was not quote escaped * the effective itemtype was not used which could lead to wrong calculation (for instance item-level_itypes is set but the item does not have the itype defined) However there is something to note, we are going to make things a bit less effective as we are now fetching the items to get their effective itemtype (vs a SUM done at DB level) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #137 from Jonathan Druart --- I've written some follow-up patches that I attached to bug 26132. Could you have a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #107145|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 107739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107739&action=edit Bug 24786: Allow setting a register for the session This patch adds the ability to set a register for the current session from the 'set library' page. Upon entering the page, the current selection will be displayed. Changing the branch will trigger the register select list to update to display only those registers associated with the updated branch and will automatically select either 'no register' or the 'branch default' register. The user can then override that selection to choose a different register for the session. Test plan 1/ Enable cash registers with the 'UseCashRegisters' system preference 2/ Select the 'Set library' option from the top right menu 3/ Note that you can now select a cash register from the subsequent page 4/ Change the branch and note that the cash register selection is updated to reflect the change 5/ Note that the 'branch default' register is auto-selected upon branch selection if one has been defined, otherwise '-- None --' is selected 6/ You can then alter the selection before submitting the form 7/ Once submitted note that you are returned to the page you were on prior to attempting to change the library and register 8/ Note the present of the register name next to the library name at the top of the screen. 9/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132
--- Comment #5 from Jonathan Druart
---
Created attachment 107738
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107738&action=edit
Bug 26132: Tidy _check_max_qty
This is only a perltidy of _check_max_qty to remove some space
inconsistencies, like:
if( $max_checkouts_allowed eq '' ){ return;}
if ( $checkout_count - $onsite_checkout_count >= $max_checkouts_allowed ) {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #4 from Jonathan Druart --- Created attachment 107737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107737&action=edit Bug 26132: Don't prefetch if not needed We only need to prefetch items if CircControl is set to ItemHomeLibrary -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #107146|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 107740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107740&action=edit Bug 24786: Allow selection of cash register at login -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #107147|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 107741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107741&action=edit Bug 24786: Update point of sale to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the sale. Test plan 1/ Enable cash registers via the 'UseCashRegisters' system preference 2/ Enable point of sale via the 'EnablePointOfSale' system preference 3/ Navigate to the point of sale page 4/ Note that if you are logged in at a branch with no cash registers yet defined, then an alert should appear 5/ Note that when you are logged in at a branch with cash regsiters defined, but without a cash register associated with your session then the cash 'Cash register' select box is populated with '-- None --' and you are required to select a register prior to submission 6/ Note that upon selection, the '-- None --' option is disabled 7/ Note that when you have a register associated with your session then the 'Cash register' select box is pre-populated with that register. 8/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #107148|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 107742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107742&action=edit Bug 24786: Update paycollect to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the payment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #107149|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 107743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107743&action=edit Bug 24786: Update borroaccount to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the refund or payout action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Martin Renvoize --- Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #82 from Martin Renvoize --- I decided to rebase bug 24786 atop this and is highlighted a few more minor things.. setting back to SO whilst I post some further followups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #13 from Martin Renvoize --- Hold off testing here until the next upload.. I'm going to rebase it upon bug 24201 as that's nearly hit PQA now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26127] When reporting an Error from the OPAC, the URL does not display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26127 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26127] When reporting an Error from the OPAC, the URL does not display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26127 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26127] When reporting an Error from the OPAC, the URL does not display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26127 Jonathan Druart changed: What|Removed |Added Attachment #107704|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 107744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107744&action=edit Bug 26127: local_referer should not compare with OPACBaseURL case insensitive In our test data we have OPACBaseURL that is filled with http://kohadev.myDNSname.org:8080, but the CGI referer in local_referer is lowercase We should compare it without case sensitivity Test plan: - Use koha-testing-docker - Notice the value of OPACBaseURL => http://kohadev.myDNSname.org:8080 - Use the "reports a problem" feature at the OPAC - Notice that the "Problem found on page" is correctly filled with the referer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26127] When reporting an Error from the OPAC, the URL does not display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26127 --- Comment #10 from Jonathan Druart --- The original problem is also due to an issue in koha-sandboxes-docker, reported at https://github.com/bywatersolutions/koha-sandboxes-docker/issues/37 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25639] Add search queries to HTML so queries can be retrieved via JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25639 Nick Clemens changed: What|Removed |Added Attachment #107711|0 |1 is obsolete|| Attachment #107712|0 |1 is obsolete|| Attachment #107713|0 |1 is obsolete|| Attachment #107714|0 |1 is obsolete|| Attachment #107715|0 |1 is obsolete|| --- Comment #19 from Nick Clemens --- Created attachment 107745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107745&action=edit Bug 25639: (alternate) make query strings global variables Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845 --- Comment #9 from Nick Clemens --- (In reply to Aleisha Amohia from comment #8) > enhancement, not backported to 19.11.x Hi Aliesha, the api logs exist in 19.11 but cannot be searched specifically, the patch adds a string to allow selecting them. Would you reconsider? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18599] "Record URL" link href is broken for multiple 856$u links in MARC record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18599 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Version|16.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26000] Holiday exceptions are incorrectly cached for an individual branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 --- Comment #10 from Nick Clemens --- Created attachment 107747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107747&action=edit Bug 26000: Make exception_holidays cache with branch in key In light of 25723 offering a simpler solution here. This would just let us avoid backporting larger changes, but this can be marked as a duplicate if 25723 is preferred to this change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26000] Holiday exceptions are incorrectly cached for an individual branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Nick Clemens changed: What|Removed |Added Attachment #106968|0 |1 is obsolete|| Attachment #106969|0 |1 is obsolete|| Attachment #106987|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 107746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107746&action=edit Bug 26000: Unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26000] Holiday exceptions are incorrectly cached for an individual branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 --- Comment #11 from Nick Clemens --- (In reply to Aleisha Amohia from comment #8) > I did not backport Bug 25723 to 19.11.x because it was framed as an > enhancement. If this patch could be reworked on top of that for 19.11.x, I'd > be happy to backport this fix as it sorts a bug. These apply cleanly to 19.11.x and tests pass - you only need this or 25723, not both. It would be nice to get an SO on this one. Martin, could you check as you wrote the other fix? :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26133] New: Unneeded calls in detail.pl can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26133 Bug ID: 26133 Summary: Unneeded calls in detail.pl can be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org There are several calls in catalogue/detail.pl that can be removed: GetMarcISBN, GetMarcAuthors, GetMarcSubjects, GetMarcSeries, GetMarcUrls and GetMarcHosts They pass a variable to the template that is never used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26133] Unneeded calls in detail.pl can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26133 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26133] Unneeded calls in detail.pl can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26133 --- Comment #1 from Jonathan Druart --- Created attachment 107748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107748&action=edit Bug 26133: Remove GetMarc* calls in detail.pl There are several calls in catalogue/detail.pl that can be removed: GetMarcISBN, GetMarcAuthors, GetMarcSubjects, GetMarcSeries, GetMarcUrls and GetMarcHosts They pass a variable to the template that is never used. Test plan: Confirm that this TT variable is never used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26133] Unneeded calls in detail.pl can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26133 --- Comment #2 from Jonathan Druart --- Created attachment 107749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107749&action=edit Bug 26133: Remove GetMarcHosts We removed the single occurrence of this subroutine in the previous patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Patron login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #23 from Nick Clemens --- (In reply to Aleisha Amohia from comment #22) > not backporting to 19.11.x because of the db updates. Hi Aleisha, The patches here fix a problem caused by an upgrade in 17.06.00.009 We need the DB updates to restore the intended settings and prevent password reset problems for upgraded databases. Would you reconsider this one? -Nick -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Andrew Fuerste-Henry changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||and...@bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry --- This works as intended, testing on master. Clarifying test process. 1) Have at least one field mapped in MARCItemFieldsToOrder, but do not map CCODE or location - I used "homebranch: 947$a" 2) Set AcqCreateItem to Placing an Order 3) Have a MARC record with at least one valid value in one of the fields mapped in MARCItemFieldsToOrder - I had a record with "947$aCPL" 4) Create a basket in acq, use default item creation of Placing an Order 5) Add to basket from a new file, selecting your MARC file 6) After the file has uploaded and you've clicked "Add staged file to basket," you're taken to addorderiso2709.pl 7) On addorderiso2709.pl, click to select your bib for import 8) If your values mapped via MARCItemFieldsToOrder was set successfully, your order should include an inset "Item Record 1" box with an abbreviated item record 9) Note that collection code and location have defaulted to the first authorized value and cannot be set to empty 10) Apply patch, restart 11) Repeat steps 1-8 12) Note that collection code and location are blank by default and can be set to other values 13) Add ccode and location to you MARCItemFieldsToOrder values and your MARC record 14) Add to your basket via your updated file 15) Note that CCODE and loc populate values as desired -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25811] authentication.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25811 --- Comment #19 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #17) > The last failure uploaded the content of the page: https://gdf3.com/FBHWZ7YH > > Which does contain the '' node... As the analysis of the failure happens after it, the missing elements can have the time to be loaded. Thanks for the patch, fingers crossed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Andrew Fuerste-Henry changed: What|Removed |Added Depends on||26134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26134 [Bug 26134] Error when adding to basket from new/staged file when using MARCItemFieldsToOrder -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26134] Error when adding to basket from new/staged file when using MARCItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26134 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||21539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26134] New: Error when adding to basket from new/staged file when using MARCItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26134 Bug ID: 26134 Summary: Error when adding to basket from new/staged file when using MARCItemFieldsToOrder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: - set at least one value in MARCItemFieldsToOrder - add to a basket via staged file with at least one value matching your MARCItemFields mappings - set required fields for your order and click Save - receive error: "DBIx::Class::Storage::DBI::_dbh_execute(): Column 'itemnumber' cannot be null at /kohadevbox/koha/Koha/Acquisition/Order.pm line 113 at /usr/share/perl5/DBIx/Class/Exception.pm line 77" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #84 from Martin Renvoize --- Created attachment 107751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107751&action=edit Bug 24201: (QA follow-up) Capitalisation fix 'Set desk' vs 'Set Desk'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Attachment #107672|0 |1 is obsolete|| --- Comment #83 from Martin Renvoize --- Created attachment 107750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107750&action=edit Bug 24201: (QA follow-up) Only display desks picker if enabled I missed a case on the authentication page with the prior patch of the same name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #86 from Martin Renvoize --- Three more tiny QA followups.. would appreciate your eyes on them Josef for the final switch to PQA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #85 from Martin Renvoize --- Created attachment 107752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107752&action=edit Bug 24201: (QA follow-up) Correct call to set_userenv One call to set_userenv had been implimented incorrectly with the parameters out of order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26135] New: MARCItemFieldsToOrder should use "location" rather than "loc"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26135 Bug ID: 26135 Summary: MARCItemFieldsToOrder should use "location" rather than "loc" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In the syspref description for MARCItemFieldsToOrder, one is instructed to enter database field names. However, the syspref requires one to use "LOC" rather than the field name "location" for shelving location. We should use "location" here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5428] Back to results after deleting a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 --- Comment #5 from Jonathan Druart --- Created attachment 107753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107753&action=edit Bug 5428: Jump back to the search result after deleting a record This patch adds the ability to jump back to the search result after a record has been deleted. Also it keeps the "browser" when all items are deleted from a bibliographic record Test plan: - Start a new search - Select a record with items - Delete all the items => You still see the browser - Delete the record => You are back to the adv search form but we new link "Go back to the results" is present at the top of the page Limitation: As we delete the record we do not longer know the offset, we are back to the first page of the result list -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5428] Back to results after deleting a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c ||ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5428] Back to results after deleting a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25914] Relative's checkouts have empty title in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Missing dependencies for 19.05.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #107739|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 107754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107754&action=edit Bug 24786: Allow setting a register for the session This patch adds the ability to set a register for the current session from the 'set library' page. Upon entering the page, the current selection will be displayed. Changing the branch will trigger the register select list to update to display only those registers associated with the updated branch and will automatically select either 'no register' or the 'branch default' register. The user can then override that selection to choose a different register for the session. Test plan 1/ Enable cash registers with the 'UseCashRegisters' system preference 2/ Select the 'Set library' option from the top right menu 3/ Note that you can now select a cash register from the subsequent page 4/ Change the branch and note that the cash register selection is updated to reflect the change 5/ Note that the 'branch default' register is auto-selected upon branch selection if one has been defined, otherwise '-- None --' is selected 6/ You can then alter the selection before submitting the form 7/ Once submitted note that you are returned to the page you were on prior to attempting to change the library and register 8/ Note the present of the register name next to the library name at the top of the screen. 9/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #107743|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 107758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107758&action=edit Bug 24786: Update borroaccount to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the refund or payout action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #107742|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 107757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107757&action=edit Bug 24786: Update paycollect to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the payment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #107740|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 107755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107755&action=edit Bug 24786: Allow selection of cash register at login -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #107741|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 107756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107756&action=edit Bug 24786: Update point of sale to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the sale. Test plan 1/ Enable cash registers via the 'UseCashRegisters' system preference 2/ Enable point of sale via the 'EnablePointOfSale' system preference 3/ Navigate to the point of sale page 4/ Note that if you are logged in at a branch with no cash registers yet defined, then an alert should appear 5/ Note that when you are logged in at a branch with cash regsiters defined, but without a cash register associated with your session then the cash 'Cash register' select box is populated with '-- None --' and you are required to select a register prior to submission 6/ Note that upon selection, the '-- None --' option is disabled 7/ Note that when you have a register associated with your session then the 'Cash register' select box is pre-populated with that register. 8/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 --- Comment #19 from Martin Renvoize --- Created attachment 107759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107759&action=edit Bug 24786: (follow-up) Cache the register_name in the session This leads to one DB hit less per page load in the staff client when cash registers are enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Depends on||24201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 [Bug 24201] Attach desk to intranet session -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Blocks||24786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 [Bug 24786] Allow setting a cash register for a login session -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24201 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24786 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 --- Comment #20 from Martin Renvoize --- This should be ready for testing again now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #38 from Arthur Suzuki --- Created attachment 107760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107760&action=edit Bug 22806: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #39 from Arthur Suzuki --- (In reply to Nick Clemens from comment #37) > This works as described, I do see that we have checks for this in reserve.pl > and opac-reserve.pl - can they be removed now that they are being added to > the modules? Indeed! Done in the QA patch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26131] console errors when attempting to open SCO related system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26131] console errors when attempting to open SCO related system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 Nick Clemens changed: What|Removed |Added Attachment #107727|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 107761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107761&action=edit Bug 26131: Remove parentheses in circulation.pref To test: 1. Search for a SCO system preference like SCOUserJS. 2. Note that there is a console error on that screen and you cannot open editor. 3. Apply patch 4. Reload the page. 5. No more console error and you can now edit the system pref! Signed-off-by: Sally Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26131] console errors when attempting to open SCO related system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 Nick Clemens changed: What|Removed |Added Patch complexity|--- |String patch CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26000] Holiday exceptions are incorrectly cached for an individual branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Martin Renvoize changed: What|Removed |Added Attachment #107746|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 107762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107762&action=edit Bug 26000: Unit test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26000] Holiday exceptions are incorrectly cached for an individual branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Martin Renvoize changed: What|Removed |Added Attachment #107747|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 107763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107763&action=edit Bug 26000: Make exception_holidays cache with branch in key In light of 25723 offering a simpler solution here. This would just let us avoid backporting larger changes, but this can be marked as a duplicate if 25723 is preferred to this change Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26136] New: Prevent double submit of checkin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26136 Bug ID: 26136 Summary: Prevent double submit of checkin form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com We have seen reports of sites where checkins appear to be failing due to corrupt data with the error: The checkin for the following issue failed, Please go to the about page, section 'data corrupted' to know how to fix this problem (DBIx::Class::Row::update(): Can't update Koha::Schema::Result::Issue=HASH(0x55c471ef6c28): row not found at /usr/share/koha/lib/Koha/Object.pm line 158 This seems to be caused by a double submission / race condition - the checkout is returned twice - the first succeeeds, the second fails because the row is moved to old_issues Sometimes it succeeds an is logged as a return + localuse We should prevent this from happening -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26000] Holiday exceptions are incorrectly cached for an individual branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26000] Holiday exceptions are incorrectly cached for an individual branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- Passing QA Works well and is basically a simplified version of but 25723 for backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26136] Prevent double submit of checkin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26136
--- Comment #1 from Nick Clemens ---
Created attachment 107764
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107764&action=edit
Bug 26136: Prevent double submit on checkin-form
To test:
1 - Browse to Circulation->Check-in
2 - Type a barcode into the Check in box
3 - Hit Enter as many as times as you can
4 - Check the statistics table:
SELECT * FROM statistics WHERE itemnumber={itemnumber} AND
DATE(datetime)=CURDATE();
5 - Note you have multiple lines for the same item at the same time
6 - Apply patch
7 - Reload the page
8 - Type the barcode
9 - Press Enter even more fast and more furiously
10 - Check the statistics table
11 - Only one entry, huzzah!
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26136] Prevent double submit of checkin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26136 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26136] Prevent double submit of checkin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26136 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26067] Member email validation based on MX record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26067 --- Comment #7 from Martin Renvoize --- I think a syspref sounds optimal.. as you say, there may be issues with locally hosted installations and I'm not 100% sure on how widely supported MX lookup is.. but I do think it's a great idea to add the option.. probably enabled by default too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26067] Member email validation based on MX record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26067 --- Comment #8 from Amit Gupta --- (In reply to Martin Renvoize from comment #7) > I think a syspref sounds optimal.. as you say, there may be issues with > locally hosted installations and I'm not 100% sure on how widely supported > MX lookup is.. but I do think it's a great idea to add the option.. probably > enabled by default too. Thank Martin for the feedback. System preference is a good idea. Will make the patch on master branch and submit for review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #40 from Nick Clemens --- (In reply to Arthur Suzuki from comment #39) > (In reply to Nick Clemens from comment #37) > > This works as described, I do see that we have checks for this in reserve.pl > > and opac-reserve.pl - can they be removed now that they are being added to > > the modules? > > Indeed! Done in the QA patch :) Thanks Arthur! Two things I note: 1 - With this patchset the message to the patron changes from" This title cannot be requested because it's already in your possession. To: There are no items that can be placed on hold. We should pass the exact reason if possible 2 - On the staff side before these patches I am warned that patron has this in possession, but I can still place the hold After the patches I cannot place a hold unless AllowHoldPolicyOverride is set This is probably appropriate, but it is a behaviour change and should be noted in release notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26017] Cashup registers never shows on tools page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26017 --- Comment #8 from Martin Renvoize --- (In reply to Jonathan Druart from comment #7) > There is no flagsrequired passed to get_template_and_user in > pos/registers.pl. That sounds wrong, can you have a look? See bug 26023. The page should display without a specific cashup permission; bug 26017 adds the proper permissions check to the submission. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26017] Cashup registers never shows on tools page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26017 Martin Renvoize changed: What|Removed |Added Attachment #107368|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 107765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107765&action=edit Bug 26017: Correct permission check on tools page The 'Cashup registers' link from the tools page retained an previous verions of the permission name. This patch corrects it to use the final name we sebtled on and thus now correctly displays the link when appropriate. Test plan 1/ Enable cash registers via the 'UseCashRegisters' system preference 2/ Ensure you are logged in as a user who has the cash management cashup permission. 3/ Verify that the 'Cashup registers' option appears on the tools page. Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26017] Cashup registers never shows on tools page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26017 --- Comment #10 from Martin Renvoize --- Created attachment 107766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107766&action=edit Bug 26017: (follow-up) Serverside permission check on registers page This patch adds a serverside permissions check for the display of the registers summary page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26017] Cashup registers never shows on tools page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26017 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #11 from Martin Renvoize --- On second thoughts.. we can catch the same permissions as we do in the followup bug here.. 's' vs ''. Followup attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26017] Cashup registers never shows on tools page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26017 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26023] Incorrect permissions handling for cashup actions on the library level registers summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26023 Martin Renvoize changed: What|Removed |Added Attachment #107082|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 107767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107767&action=edit Bug 26023: Properly secure the cashup action for libraries The libraries summary page for cash management is available for users wit the 'anonymous_refund' permission to allow them to navigate to alternate cash registers and search for the prior transaction to refund. However, currently the cashup option appears, and is not blocked at the server, for all user who may access the page. It should be blocked for those users without the 'cashup' permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26017] Cashup registers never shows on tools page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26017 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26023] Incorrect permissions handling for cashup actions on the library level registers summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26023 --- Comment #5 from Martin Renvoize --- Created attachment 107768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107768&action=edit Bug 26023: Properly secure the cashup and refund actions The cash register summary page for cash management is available for users with the 'anonymous_refund' or 'cashup' permission and the actions available are appropriately displayed. However, the actions are not yet correctly tested for at the server and so a user may force submit to accomplish the action. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26023] Incorrect permissions handling for cashup actions on the library level registers summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26023 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26023] Incorrect permissions handling for cashup actions on the library level registers summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26023 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #14 from Jonathan Druart
---
Some comments:
1. You really should avoid indentation spaces outside of the block you are
editing. It makes rebase a nightmare for you and for those who will have to
rebase on top of it.
2. Why are you using the "%010d" format?
Why are not you dumping (using Data::Dumper) the whole $budget?
I have not tested but
+sprintf("%010d", $del_adj->invoiceid) .
+sprintf("%010d", $del_adj->budget_id) .
That will produce a concat of 0101 (for invoiceid=1 and
budget_id=1
Is it really what we expect?
And why 10? rrp_tax_excluded is decimal(28,6) for instance
3. +eval { output_pref({ dt => dt_from_string(
$input->param('budget_period_startdate') ), dateformat => 'iso', dateonly => 1
} ); } .
I don't think we should store formatted dates.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #15 from Jonathan Druart --- 4. You should also consider adding tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
