[Bug 1242678] Re: evince cannot render some EPS files
** Changed in: evince (Ubuntu Trusty) Status: Triaged => Won't Fix -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
** Bug watch removed: freedesktop.org Bugzilla #87588 https://bugs.freedesktop.org/show_bug.cgi?id=87588 -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
As far as I remember the fix only worked for some versions of GS. Anyway, I'll try to find some time too look at this in detail again. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Carlos, any hope of getting a review on Marek latest patch ? -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
** Changed in: evince (Ubuntu Trusty) Importance: Undecided => Medium ** Project changed: gs-gpl => ubuntu-translations ** Changed in: ubuntu-translations Importance: Unknown => Undecided ** Changed in: ubuntu-translations Status: Unknown => New ** Changed in: ubuntu-translations Remote watch: Ghostscript (AFPL) Bugzilla #694979 => None ** No longer affects: ubuntu-translations -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
*** Bug 87588 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Created attachment 111047 erase page before its drawing This patch is simplified version of the one with setpagedevice, it just erase the page instead of calling whole setpagedevice. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to Carlos Garcia Campos from comment #34) Still doesn't work here, it seems to rotate the first page only of a multipage document. I can not reproduce this. Could you point me to a document which triggers this problem? -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to Pacho Ramos from comment #36) (In reply to Carlos Garcia Campos from comment #35) I've reverted the patch in master for now, until we find a proper solution. Do you know when a new tarball is planned including this and other fixes? Thanks No plans, but I can make a new release once this problem is fixed, for example. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to Carlos Garcia Campos from comment #35) I've reverted the patch in master for now, until we find a proper solution. Do you know when a new tarball is planned including this and other fixes? Thanks -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Still doesn't work here, it seems to rotate the first page only of a multipage document. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
** Changed in: evince Importance: Medium = Unknown ** Changed in: evince Status: New = Unknown ** Changed in: evince Remote watch: GNOME Bug Tracker #710957 = GNOME Bug Tracker #731786 ** Bug watch removed: GNOME Bug Tracker #710957 https://bugzilla.gnome.org/show_bug.cgi?id=710957 -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
This bug was fixed in the package libspectre - 0.2.7-2ubuntu1.1 --- libspectre (0.2.7-2ubuntu1.1) trusty; urgency=medium * fix-document-rotation.patch: Some PostScript and EPS files do not get displayed by evince when rotated by 90 or 270 degrees. This is due to a bug in libspectre fixed by this upstream patch (LP: #1242678, Freedesktop bug #76450). -- Till Kamppeter till.kamppe...@gmail.com Tue, 10 Jun 2014 22:13:44 +0200 ** Changed in: libspectre (Ubuntu Trusty) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
The attachment libspectre_0.2.7-2ubuntu1_0.2.7-2ubuntu2.debdiff seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the patch flag from the attachment, remove the patch tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to comment #22) (In reply to comment #20) (In reply to comment #19) Thanks Marek! Do you still plan to look at the evince side as well (since the rotation seems to still be wrong when using it, as mentioned in previous comments) Hi Sebastien, thank you for reminding me this. I'll look at that but not now since I have several tasks I have to finish before I can jump on this. Maybe at the end of the next week. I've filled a bug for this here: https://bugzilla.gnome.org/show_bug.cgi?id=731786. A patch is attached there which solves it for me. (In reply to comment #21) I've been trying this and I'm getting the opposite results, the attached ps file is rotated without the patch but nothing is rendered when rotated with the patch. I've just tried it with evince from master with patched libspectre and it works for me as expected :(. Maybe it has to do with the gs version? $ gs --version 9.05 From Debian testing. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to comment #20) (In reply to comment #19) Thanks Marek! Do you still plan to look at the evince side as well (since the rotation seems to still be wrong when using it, as mentioned in previous comments) Hi Sebastien, thank you for reminding me this. I'll look at that but not now since I have several tasks I have to finish before I can jump on this. Maybe at the end of the next week. I've filled a bug for this here: https://bugzilla.gnome.org/show_bug.cgi?id=731786. A patch is attached there which solves it for me. (In reply to comment #21) I've been trying this and I'm getting the opposite results, the attached ps file is rotated without the patch but nothing is rendered when rotated with the patch. I've just tried it with evince from master with patched libspectre and it works for me as expected :(. Marek -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to comment #23) (In reply to comment #22) (In reply to comment #20) (In reply to comment #19) Thanks Marek! Do you still plan to look at the evince side as well (since the rotation seems to still be wrong when using it, as mentioned in previous comments) Hi Sebastien, thank you for reminding me this. I'll look at that but not now since I have several tasks I have to finish before I can jump on this. Maybe at the end of the next week. I've filled a bug for this here: https://bugzilla.gnome.org/show_bug.cgi?id=731786. A patch is attached there which solves it for me. (In reply to comment #21) I've been trying this and I'm getting the opposite results, the attached ps file is rotated without the patch but nothing is rendered when rotated with the patch. I've just tried it with evince from master with patched libspectre and it works for me as expected :(. Maybe it has to do with the gs version? $ gs --version 9.05 From Debian testing. I've just tried it with the ghostscript 9.05 and the documents are rotated in opposite direction compared to the libspectre without the patch but it renders the documents correctly otherwise. I'll prepare a patch which will change the direction of rotation. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Created attachment 101589 Change direction of rotation The promised patch. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
** Changed in: libspectre Status: Fix Released = Confirmed -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
** Patch added: fix-document-rotation.patch https://bugs.launchpad.net/ubuntu/+source/libspectre/+bug/1242678/+attachment/4135449/+files/fix-document-rotation.patch -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
Thanks Till, Sebastien and other contributors! I enabled proposed repository and tested the new libspectre build. The documents are shown now, but the rotation is incorrect (upside down). So I marked as verification-failed. I examined your debdiff file and I realized that the following fact causes a new issue. Ghostscript consideres +90deg rotation as rotate 90deg CLOCKWISE but PostScript considers +90deg rotation as rotate 90 deg COUNTER-CLOCKWISE. So you should change the sign when you pass a rotation angle as a PostScript command. I will attach a new patch file fixing this issue. Can you review my patch? ** Tags removed: verification-done ** Tags added: verification-failed -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
(note that your change might be correct, but the right place to discuss that approach would be on the freedesktop or GNOME bugs) -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
@epil: thanks, but that's not an issue with this change, evince needs to be fixed, see the upstream bug or https://bugzilla.gnome.org/show_bug.cgi?id=731786 for details. I'm marking it back as verification-done, the fix is correct for the library and having documents opening with an incorrect rotation is better than having them not loading. We are going to upload a fixed evince as well, once upstream is happy with the change ** Tags removed: verification-failed ** Tags added: verification-done ** Bug watch added: GNOME Bug Tracker #731786 https://bugzilla.gnome.org/show_bug.cgi?id=731786 -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
Here we need to agree with libspectre and evince upstream. The libspectre patch proposed for the SRU is from this upstream bug https://bugs.freedesktop.org/show_bug.cgi?id=76450 but they also tell that an additional fix on evince is needed, supplied as a patch on this bug https://bugzilla.gnome.org/show_bug.cgi?id=731786 To follow this, we should post a second SRU for evince (and let this go to -updates). -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
Hello epii, or anyone else affected, Accepted libspectre into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/libspectre/0.2.7-2ubuntu1.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: libspectre (Ubuntu Trusty) Status: In Progress = Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
** Branch linked: lp:ubuntu/trusty-proposed/libspectre -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
I've been trying this and I'm getting the opposite results, the attached ps file is rotated without the patch but nothing is rendered when rotated with the patch. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to comment #19) Thanks Marek! Do you still plan to look at the evince side as well (since the rotation seems to still be wrong when using it, as mentioned in previous comments) Hi Sebastien, thank you for reminding me this. I'll look at that but not now since I have several tasks I have to finish before I can jump on this. Maybe at the end of the next week. Regards Marek -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678] Re: evince cannot render some EPS files
This bug was fixed in the package libspectre - 0.2.7-2ubuntu2 --- libspectre (0.2.7-2ubuntu2) utopic; urgency=medium * fix-document-rotation.patch: Some PostScript and EPS files do not get displayed by evince when rotated by 90 or 270 degrees. This is due to a bug in libspectre fixed by this upstream patch (LP: #1242678, Freedesktop bug #76450). -- Till Kamppeter till.kamppe...@gmail.com Tue, 10 Jun 2014 22:13:44 +0200 ** Changed in: libspectre (Ubuntu) Status: In Progress = Fix Released -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Comment on attachment 99331
Rotate documents correctly
Review of attachment 99331:
-
This looks good to me, except the confusing NONE/LANDSCAPE thing.
Adrian, does the PostScript part looks good to you?
::: libspectre/spectre-device.c
@@ +206,4 @@
return SPECTRE_STATUS_RENDER_ERROR;
}
+ if (rc-orientation == NONE || rc-orientation == LANDSCAPE) {
Why NONE and LANDSCAPE? shouldn't we invert width/height when
orientation is LANDSCAPE and SEASCAPE? Ah, I know what's going on, you
are using the internal values of the parser (my fault, I think I
suggested it) but rc-orientation is actually a SpectreOrientation enum
value, so you should use SPECTRE_ORIENTATION_PORTRAIT ||
SPECTRE_ORIENTATION_REVERSE_PORTRAIT that are 0 and 2 like NONE and
LANDSCAPE in the internal parser.
@@ +269,4 @@
args[arg++] = -dNOPLATFONTS;
if (rc-width != -1 rc-height != -1) {
+ if (rc-orientation == NONE || rc-orientation == LANDSCAPE) {
Same here.
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to libspectre in Ubuntu.
https://bugs.launchpad.net/bugs/1242678
Title:
evince cannot render some EPS files
To manage notifications about this bug go to:
https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions
--
kubuntu-bugs mailing list
kubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to comment #15) Adrian, does the PostScript part looks good to you? Looks good. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Created attachment 99156 Rotate documents correctly This patch solves the problem with the problematic PostScript file for me but it is kind of a hack. It replaces occurrences of setpagedevice with pop so that its parameters don't influence the rendering to the display device. I have looked into PostScript LANGUAGE REFERENCE and it seems to me that the parameters which are set by setpagedevice are not important for rendering to display device (but I'm not really sure here). Marek -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Seb, can you do an appropriate patch on evince and report a bug upstream? -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Seb, you could use https://bugzilla.gnome.org/show_bug.cgi?id=710957 for this. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
@Till, yes using https://bugzilla.gnome.org/show_bug.cgi?id=710957 seems fine to me. @Marek, do you plan to follow up with the evince team about that rotation issue? It seems like both libspectre and evince need to be updated together to give a correct result there @Carlos, what do you think about those changes? -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to comment #5) @Marek, do you plan to follow up with the evince team about that rotation issue? It seems like both libspectre and evince need to be updated together to give a correct result there Sure, I can continue on this in evince too. I'll try look for a solution. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Comment on attachment 96165
Rotate documents correctly
Review of attachment 96165:
-
Thanks for the patch!
::: libspectre/spectre-device.c
@@ +206,5 @@
return SPECTRE_STATUS_RENDER_ERROR;
}
+ scaled_width = (int) ((width * rc-x_scale) + 0.5);
+ scaled_height = (int) ((height * rc-y_scale) + 0.5);
I think it would be clearer if we set these values depending on the
orientation, and then we just use scale_width, scaled_height below.
@@ +226,5 @@
rc-text_alpha_bits);
args[arg++] = graph_alpha = _spectre_strdup_printf
(-dGraphicsAlphaBits=%d,
rc-graphic_alpha_bits);
+
+ if (rc-orientation == 0 || rc-orientation == 2) {
Don't use magic numbers here, use NONE and LANDSCAPE instead.
@@ +232,5 @@
+ args[arg++] = resolution = _spectre_strdup_printf (-r%fx%f,
+rc-x_scale
* rc-x_dpi,
+rc-y_scale
* rc-y_dpi);
+ }
+ else {
} else {
::: libspectre/spectre-gs.c
@@ +237,5 @@
+ switch (rotation) {
+ default:
+ tmp_xoffset = xoffset + x;
+ tmp_yoffset = yoffset + y;
I don't think we need the tmp_ variables, we can just modify the
existing xoffset/yoffset.
@@ +277,5 @@
doc-endsetup))
return FALSE;
+ if (rotation != 0) {
+ set = _spectre_strdup_printf (%d rotate, rotation);
Where does this end up? After the setup and before the pages? Isn't it
recommended to apply the rotation after the translation? I think we
could move this to spectre_gs_process, after the translate. We pass the
rotation to spectre_gs_process and when it's != NONE we inject the
rotate command there. What do you think?
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to libspectre in Ubuntu.
https://bugs.launchpad.net/bugs/1242678
Title:
evince cannot render some EPS files
To manage notifications about this bug go to:
https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions
--
kubuntu-bugs mailing list
kubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Created attachment 99100
Rotate documents correctly
Thank you for the review.
(In reply to comment #7)
Comment on attachment 96165 [details] [review]
Rotate documents correctly
Review of attachment 96165 [details] [review]:
-
Thanks for the patch!
::: libspectre/spectre-device.c
@@ +206,5 @@
return SPECTRE_STATUS_RENDER_ERROR;
}
+ scaled_width = (int) ((width * rc-x_scale) + 0.5);
+ scaled_height = (int) ((height * rc-y_scale) + 0.5);
I think it would be clearer if we set these values depending on the
orientation, and then we just use scale_width, scaled_height below.
Done.
@@ +226,5 @@
rc-text_alpha_bits);
args[arg++] = graph_alpha = _spectre_strdup_printf
(-dGraphicsAlphaBits=%d,
rc-graphic_alpha_bits);
+
+ if (rc-orientation == 0 || rc-orientation == 2) {
Don't use magic numbers here, use NONE and LANDSCAPE instead.
Done.
@@ +232,5 @@
+ args[arg++] = resolution = _spectre_strdup_printf (-r%fx%f,
+ rc-x_scale
* rc-x_dpi,
+ rc-y_scale
* rc-y_dpi);
+ }
+ else {
} else {
Done.
::: libspectre/spectre-gs.c
@@ +237,5 @@
+ switch (rotation) {
+ default:
+ tmp_xoffset = xoffset + x;
+ tmp_yoffset = yoffset + y;
I don't think we need the tmp_ variables, we can just modify the existing
xoffset/yoffset.
I removed them but I had to reintroduce them back because of the next
item.
@@ +277,5 @@
doc-endsetup))
return FALSE;
+ if (rotation != 0) {
+ set = _spectre_strdup_printf (%d rotate, rotation);
Where does this end up? After the setup and before the pages?
Yes, it ends up there.
Isn't it recommended to apply the rotation after the translation? I think we
could
move this to spectre_gs_process, after the translate. We pass the rotation
to spectre_gs_process and when it's != NONE we inject the rotate command
there. What do you think?
I moved it there.
Unfortunately I've found a PostScript file on which the patch doesn't work. It
shows the file with the original rotation for each rotation. It is due to
setpagedevice and PageSize are employed there (see next attachment). I'm
not sure what to do with it yet.
Regards
Marek
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to libspectre in Ubuntu.
https://bugs.launchpad.net/bugs/1242678
Title:
evince cannot render some EPS files
To manage notifications about this bug go to:
https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions
--
kubuntu-bugs mailing list
kubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Created attachment 99101 The problematic PostScript file. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
