Re: File reg_startend patch
On Sunday 15 April 2007 10:29, M.Canales.es wrote: > El Sábado, 7 de Abril de 2007 18:57, Matthew Burgess escribió: > > Thanks Greg, I'll remove the patch some time this week. > > Matt, don't forget this one, there is no trac entry for it. Yep. thanks. It's in my working copy and I'll be kicking a build off soon with all the other package upgrades in Trac. Matt. -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
Re: File reg_startend patch
El Sábado, 7 de Abril de 2007 18:57, Matthew Burgess escribió: > Thanks Greg, I'll remove the patch some time this week. > Matt, don't forget this one, there is no trac entry for it. -- Manuel Canales Esparcia Usuario de LFS nº2886: http://www.linuxfromscratch.org LFS en castellano: http://www.escomposlinux.org/lfs-es http://www.lfs-es.info TLDP-ES: http://es.tldp.org -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
Re: File reg_startend patch
On Saturday 07 April 2007 13:35, Greg Schafer wrote: > Umm, why are you applying this patch? Just because it appears on the ftp > site? Nope, I did actually take a look at the source code and erroneously concluded it was necessary as REG_STARTEND wasn't defined. Obviously, I forgot to take into account system headers. /usr/include/regex.h defines REG_STARTEND, and this file is included by src/file.h, which, in turn, is included by src/softmagic.c. Thanks Greg, I'll remove the patch some time this week. Matt. -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
File reg_startend patch
> Author: matthew > Date: 2007-03-04 12:28:29 -0700 (Sun, 04 Mar 2007) > New Revision: 7956 > Upgrade to File-4.20. Fixes #1968. > +Apply a patch to fix a bug caused by an undefined constant: > + > +patch -Np1 -i > ../&file-reg_startend-patch; Umm, why are you applying this patch? Just because it appears on the ftp site? AFAICT it does nothing for us. It applies only to those platforms who don't define REG_STARTEND in their system headers eg: Solaris. You can easily confirm it does nothing on Linux/Glibc by compiling with and without the patch then diffing the binaries. They are identical (except for usual date stamps in the *.a archive). Regards Greg -- http://www.diy-linux.org/ -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page