[Bug 158918] Calc,API:queryContentCells(23) incorrectly recognizes outside Used Area
https://bugs.documentfoundation.org/show_bug.cgi?id=158918 --- Comment #1 from nobu --- Created attachment 191621 --> https://bugs.documentfoundation.org/attachment.cgi?id=191621=edit sample file -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158918] New: Calc,API:queryContentCells(23) incorrectly recognizes outside Used Area
https://bugs.documentfoundation.org/show_bug.cgi?id=158918 Bug ID: 158918 Summary: Calc,API:queryContentCells(23) incorrectly recognizes outside Used Area Product: LibreOffice Version: 7.4.7.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tac...@hotmail.co.jp Description: Calc,API:queryContentCells(23) incorrectly recognizes outside Used Area. Steps to Reproduce: 1. Open Attached File 2. Select the empty cells on the right after columns [ D1:D31 ]. (A button for selection is placed in column B) ex. Select [ E8:E15 ] 3. Execute the macro from the button in A1. Examine the contents of the cells by queryContentCells(23). Actual Results: 4. A message will be displayed indicating that column C contains the result of the selection. ex. Indicates that C13 and C14 have values. Expected Results: 4. displays the results of the selected range. ex. Shows that all are empty. Reproducible: Always User Profile Reset: No Additional Info: It appears that queryContentCells(23) is searching the last column of Used Area. It appears to be resolved by entering something in the cell to the right of the last column of Used Area. For example, [D1]. --- Not Reproduced with Version: 7.3.7.2 (x64) / LibreOffice Community Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f CPU threads: 4; OS: Windows 10.0 Build 10240; UI render: Skia/Raster; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL --- Reproducible with Version: 7.4.7.2 (x64) / LibreOffice Community Build ID: 723314e595e8007d3cf785c16538505a1c878ca5 CPU threads: 4; OS: Windows 10.0 Build 10240; UI render: Skia/Raster; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL Reproducible with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 90b12c9bad55e8f50b75a6d7b68caa27d82cc2b9 CPU threads: 4; OS: Windows 10.0 Build 10240; UI render: Skia/Raster; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158917] bugs in libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=158917 Telesto changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158917] bugs in libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=158917 Telesto changed: What|Removed |Added Component|LibreOffice |deletionRequest -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158917] bugs in libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=158917 Telesto changed: What|Removed |Added Component|BASIC |LibreOffice Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158915] Very slow file-opening if embedded font being enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=158915 Telesto changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from Telesto --- (In reply to m.a.riosv from comment #1) yes -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - editeng/inc editeng/source
editeng/inc/ContentNode.hxx| 179 +
editeng/inc/editdoc.hxx| 152 ---
editeng/source/editeng/editdoc.cxx | 172 +--
3 files changed, 267 insertions(+), 236 deletions(-)
New commits:
commit beb2b1d6b1b23e941d1a6a34dc68a16ec7167c1b
Author: Tomaž Vajngerl
AuthorDate: Sat Dec 23 20:09:42 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Dec 29 07:29:42 2023 +0100
editeng: prefix members of ContentNode, CharAttribList, ContentAttribs
Change-Id: I2af96b6525ee0d4410200775ce4daf71bcc80db4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161354
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/inc/ContentNode.hxx b/editeng/inc/ContentNode.hxx
index 1d44e3469a36..d89612ddeac8 100644
--- a/editeng/inc/ContentNode.hxx
+++ b/editeng/inc/ContentNode.hxx
@@ -37,8 +37,8 @@ class SvxTabStop;
class ContentAttribs
{
private:
-SfxStyleSheet* pStyle;
-SfxItemSetFixed aAttribSet;
+SfxStyleSheet* mpStyle;
+SfxItemSetFixed maAttribSet;
public:
ContentAttribs(SfxItemPool& rItemPool);
@@ -46,10 +46,10 @@ public:
void dumpAsXml(xmlTextWriterPtr pWriter) const;
SvxTabStop FindTabStop(sal_Int32 nCurPos, sal_uInt16 nDefTab);
-SfxItemSet& GetItems() { return aAttribSet; }
-const SfxItemSet& GetItems() const { return aAttribSet; }
-const SfxStyleSheet* GetStyleSheet() const { return pStyle; }
-SfxStyleSheet* GetStyleSheet() { return pStyle; }
+SfxItemSet& GetItems() { return maAttribSet; }
+const SfxItemSet& GetItems() const { return maAttribSet; }
+const SfxStyleSheet* GetStyleSheet() const { return mpStyle; }
+SfxStyleSheet* GetStyleSheet() { return mpStyle; }
void SetStyleSheet(SfxStyleSheet* pS);
const SfxPoolItem& GetItem(sal_uInt16 nWhich) const;
@@ -66,9 +66,9 @@ public:
typedef std::vector> AttribsType;
private:
-AttribsType aAttribs;
-SvxFont aDefFont; // faster than ever from the pool!
-bool bHasEmptyAttribs;
+AttribsType maAttribs;
+SvxFont maDefFont; // faster than ever from the pool!
+bool mbHasEmptyAttribs;
public:
CharAttribList();
@@ -91,15 +91,15 @@ public:
void InsertAttrib(EditCharAttrib* pAttrib);
-SvxFont& GetDefFont() { return aDefFont; }
+SvxFont& GetDefFont() { return maDefFont; }
-bool HasEmptyAttribs() const { return bHasEmptyAttribs; }
+bool HasEmptyAttribs() const { return mbHasEmptyAttribs; }
void SetHasEmptyAttribs(bool b);
bool HasBoundingAttrib(sal_Int32 nBound) const;
bool HasAttrib(sal_Int32 nStartPos, sal_Int32 nEndPos) const;
-AttribsType& GetAttribs() { return aAttribs; }
-const AttribsType& GetAttribs() const { return aAttribs; }
+AttribsType& GetAttribs() { return maAttribs; }
+const AttribsType& GetAttribs() const { return maAttribs; }
void Remove(const EditCharAttrib* p);
void Remove(sal_Int32 nPos);
@@ -113,8 +113,8 @@ class ContentNode
{
private:
OUString maString;
-ContentAttribs aContentAttribs;
-CharAttribList aCharAttribList;
+ContentAttribs maContentAttribs;
+CharAttribList maCharAttribList;
std::unique_ptr mpWrongList;
void UnExpandPosition(sal_Int32& rStartPos, bool bBiasStart);
@@ -128,10 +128,10 @@ public:
void dumpAsXml(xmlTextWriterPtr pWriter) const;
-ContentAttribs& GetContentAttribs() { return aContentAttribs; }
-const ContentAttribs& GetContentAttribs() const { return aContentAttribs; }
-CharAttribList& GetCharAttribs() { return aCharAttribList; }
-const CharAttribList& GetCharAttribs() const { return aCharAttribList; }
+ContentAttribs& GetContentAttribs() { return maContentAttribs; }
+const ContentAttribs& GetContentAttribs() const { return maContentAttribs;
}
+CharAttribList& GetCharAttribs() { return maCharAttribList; }
+const CharAttribList& GetCharAttribs() const { return maCharAttribList; }
void ExpandAttribs(sal_Int32 nIndex, sal_Int32 nNewChars);
void CollapseAttribs(sal_Int32 nIndex, sal_Int32 nDelChars);
@@ -140,7 +140,7 @@ public:
void SetStyleSheet(SfxStyleSheet* pS, bool bRecalcFont = true);
void SetStyleSheet(SfxStyleSheet* pS, const SvxFont& rFontFromStyle);
-SfxStyleSheet* GetStyleSheet() { return aContentAttribs.GetStyleSheet(); }
+SfxStyleSheet* GetStyleSheet() { return maContentAttribs.GetStyleSheet(); }
void CreateDefFont();
diff --git a/editeng/source/editeng/editdoc.cxx
b/editeng/source/editeng/editdoc.cxx
index b28773e71977..8bac8f2cf67b 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -1164,12 +1164,14 @@ bool operator != ( const EditPaM& r1, const EditPaM& r2
)
return !( r1 == r2 );
}
-ContentNode::ContentNode( SfxItemPool& rPool ) : aContentAttribs( rPool )
+ContentNode::ContentNode( SfxItemPool& rPool )
+:
core.git: editeng/inc editeng/source
editeng/inc/ItemList.hxx | 53 -
editeng/source/editeng/editdoc.cxx | 28 ---
2 files changed, 29 insertions(+), 52 deletions(-)
New commits:
commit 985b6c4a7fd00d1859ce3a32ab141d94526e989c
Author: Tomaž Vajngerl
AuthorDate: Fri Dec 22 20:24:37 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Dec 29 07:29:12 2023 +0100
editeng: ItemList - prefix members, move methods in class
- Move methods into class def. as the class is simple enough.
- Prefix member variables.
- Remove unneeded includes.
Change-Id: Ide567c64dad3606f1a9faf837571ae2a5c3d69ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161352
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/inc/ItemList.hxx b/editeng/inc/ItemList.hxx
index 29c2b0dcddd2..a060fc6e29e7 100644
--- a/editeng/inc/ItemList.hxx
+++ b/editeng/inc/ItemList.hxx
@@ -19,38 +19,43 @@
#pragma once
-#include "editattr.hxx"
-#include "edtspell.hxx"
-#include "eerdll2.hxx"
-#include
-#include
-#include
-#include
#include
-#include
-#include
-#include
-#include "TextPortion.hxx"
-
-#include
-#include
-#include
#include
class ItemList
{
private:
-typedef std::vector DummyItemList;
-DummyItemList aItemPool;
-sal_Int32 CurrentItem;
+std::vector maItemPool;
+sal_Int32 maCurrentItem = 0;
public:
-ItemList();
-const SfxPoolItem* First();
-const SfxPoolItem* Next();
-sal_Int32 Count() const { return aItemPool.size(); };
-void Insert(const SfxPoolItem* pItem);
-void Clear() { aItemPool.clear(); };
+ItemList() = default;
+
+const SfxPoolItem* First()
+{
+maCurrentItem = 0;
+return maItemPool.empty() ? nullptr : maItemPool[0];
+}
+
+const SfxPoolItem* Next()
+{
+if (maCurrentItem + 1 < sal_Int32(maItemPool.size()))
+{
+++maCurrentItem;
+return maItemPool[maCurrentItem];
+}
+return nullptr;
+}
+
+sal_Int32 Count() const { return maItemPool.size(); }
+
+void Insert(const SfxPoolItem* pItem)
+{
+maItemPool.push_back(pItem);
+maCurrentItem = maItemPool.size() - 1;
+}
+
+void Clear() { maItemPool.clear(); }
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/editeng/source/editeng/editdoc.cxx
b/editeng/source/editeng/editdoc.cxx
index 0856a594f7ae..b28773e71977 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -1862,34 +1862,6 @@ void ContentAttribs::dumpAsXml(xmlTextWriterPtr pWriter)
const
(void)xmlTextWriterEndElement(pWriter);
}
-
-ItemList::ItemList() : CurrentItem( 0 )
-{
-}
-
-const SfxPoolItem* ItemList::First()
-{
-CurrentItem = 0;
-return aItemPool.empty() ? nullptr : aItemPool[ 0 ];
-}
-
-const SfxPoolItem* ItemList::Next()
-{
-if ( CurrentItem + 1 < static_cast(aItemPool.size()) )
-{
-++CurrentItem;
-return aItemPool[ CurrentItem ];
-}
-return nullptr;
-}
-
-void ItemList::Insert( const SfxPoolItem* pItem )
-{
-aItemPool.push_back( pItem );
-CurrentItem = aItemPool.size() - 1;
-}
-
-
EditDoc::EditDoc( SfxItemPool* pPool ) :
nLastCache(0),
pItemPool(pPool ? pPool : new EditEngineItemPool()),
core.git: editeng/inc
editeng/inc/ItemList.hxx | 56 +++
editeng/inc/editdoc.hxx | 24
2 files changed, 57 insertions(+), 23 deletions(-)
New commits:
commit 27afa3fa1321bc55d6063115c4ad3558d68eb76e
Author: Tomaž Vajngerl
AuthorDate: Fri Dec 22 20:16:14 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Dec 29 07:28:31 2023 +0100
editeng: move ItemList in its own header file
Change-Id: I52f3f2a557db7058aa584ca7c1cee08eae58d726
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161351
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/inc/ItemList.hxx b/editeng/inc/ItemList.hxx
new file mode 100644
index ..29c2b0dcddd2
--- /dev/null
+++ b/editeng/inc/ItemList.hxx
@@ -0,0 +1,56 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include "editattr.hxx"
+#include "edtspell.hxx"
+#include "eerdll2.hxx"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "TextPortion.hxx"
+
+#include
+#include
+#include
+#include
+
+class ItemList
+{
+private:
+typedef std::vector DummyItemList;
+DummyItemList aItemPool;
+sal_Int32 CurrentItem;
+
+public:
+ItemList();
+const SfxPoolItem* First();
+const SfxPoolItem* Next();
+sal_Int32 Count() const { return aItemPool.size(); };
+void Insert(const SfxPoolItem* pItem);
+void Clear() { aItemPool.clear(); };
+};
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/editeng/inc/editdoc.hxx b/editeng/inc/editdoc.hxx
index 240bcbfc9e37..aa6232c1f486 100644
--- a/editeng/inc/editdoc.hxx
+++ b/editeng/inc/editdoc.hxx
@@ -31,6 +31,7 @@
#include
#include
#include "TextPortion.hxx"
+#include "ItemList.hxx"
#include
#include
@@ -103,31 +104,8 @@ public:
void AppendCharAttrib(EditCharAttrib* pNew);
};
-
-
typedef std::vector SvxColorList;
-
-
-
-class ItemList
-{
-private:
-typedef std::vector DummyItemList;
-DummyItemList aItemPool;
-sal_Int32 CurrentItem;
-
-public:
-ItemList();
-const SfxPoolItem* First();
-const SfxPoolItem* Next();
-sal_Int32 Count() const { return aItemPool.size(); };
-voidInsert( const SfxPoolItem* pItem );
-voidClear() { aItemPool.clear(); };
-};
-
-
-
class ContentAttribs
{
private:
[Bug 158917] New: bugs in libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=158917 Bug ID: 158917 Summary: bugs in libreoffice Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ummesadiqamu...@gmail.com Description: bugs is generated in libreoffice Steps to Reproduce: 1.wrriter paint spreadsheet 2. 3. Actual Results: jydyu Expected Results: kueydfiu Reproducible: Always User Profile Reset: No Additional Info: uduiwa -- You are receiving this mail because: You are the assignee for the bug.
[Bug 80181] FILEOPEN: bad display of .pptx background theme color from slide master
https://bugs.documentfoundation.org/show_bug.cgi?id=80181 --- Comment #18 from Lars Jødal --- Still reproducible in Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: da-DK Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 122671] Impress: Lines don't connect/ align properly in slide show mode
https://bugs.documentfoundation.org/show_bug.cgi?id=122671 --- Comment #9 from Lars Jødal --- Still reproducible in Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: da-DK Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/core/layout/trvlfrm.cxx | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
New commits:
commit aaff1bfa765539068d837404ca016608490aaf11
Author: Mike Kaganski
AuthorDate: Fri Dec 29 06:22:18 2023 +0100
Commit: Mike Kaganski
CommitDate: Fri Dec 29 07:16:38 2023 +0100
Simplify a bit
Change-Id: I4b88160f27434588730082fc0b6853ba10df4603
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161411
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/source/core/layout/trvlfrm.cxx
b/sw/source/core/layout/trvlfrm.cxx
index 5f8e3aa995a3..27922156b31d 100644
--- a/sw/source/core/layout/trvlfrm.cxx
+++ b/sw/source/core/layout/trvlfrm.cxx
@@ -191,16 +191,8 @@ bool SwLayoutFrame::GetModelPositionForViewPoint(
SwPosition *pPos, Point
bool SwPageFrame::GetModelPositionForViewPoint( SwPosition *pPos, Point
,
SwCursorMoveState* pCMS, bool bTestBackground )
const
{
-Point aPoint( rPoint );
-
-// check, if we have to adjust the point
-if ( !getFrameArea().Contains( aPoint ) )
-{
-aPoint.setX( std::max( aPoint.X(), getFrameArea().Left() ) );
-aPoint.setX( std::min( aPoint.X(), getFrameArea().Right() ) );
-aPoint.setY( std::max( aPoint.Y(), getFrameArea().Top() ) );
-aPoint.setY( std::min( aPoint.Y(), getFrameArea().Bottom() ) );
-}
+Point aPoint(std::clamp(rPoint.X(), getFrameArea().Left(),
getFrameArea().Right()),
+ std::clamp(rPoint.Y(), getFrameArea().Top(),
getFrameArea().Bottom()));
bool bRet = false;
//Could it be a free flying one?
[Bug 142494] Word Count not 0 when no words are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=142494 Jamie Douglass changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jdougla...@me.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112023] Copying data from Base truncates precision to the shown format
https://bugs.documentfoundation.org/show_bug.cgi?id=112023 --- Comment #14 from Lars Jødal --- Still reproducible in Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: da-DK Calc: threaded As before, "Copy" copies only with the precision shown on the screen, while drag & drop (correctly) retains the full precision. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155494] Cursor goes beyond margins when typing spaces at the end of a line
https://bugs.documentfoundation.org/show_bug.cgi?id=155494 --- Comment #59 from Mike Kaganski --- (In reply to Mike Kaganski from comment #58) > IMO, instead of the spaces over margins, our usual metaphor for text not > fitting to the space - which is a red triangle showing "more content outside > of the bounds" - could be used instead. Cf. to a fixed-size table cell / > frame, having too much text. Or - in this specific case - maybe use a dedicated icon, not a red triangle, but some image resembling ellipsis. This would mean, that on margin, with enabled formatting marks it could look like (| means right page margin; [...] means the new ellipsis icon; ¬ means the existing line break mark): ... text + many trailing spaces | [...] ... text text text text line 2 | ... text line 3 with line break | ¬ ... line 4 - spaces + line break | [...]¬ and the marks would take fixed width, regardless of the number of spaces that were eaten when breaking lines. Note that currently, the marks on margins (like paragraph marks, line break marks in block adjust mode) aren't marked when selecting text. I don't think it's really a problem. But if it's really wanted that they all also change they background, it should be a separate request; the display of cut spaces and cursor travelling is separate from that. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155494] Cursor goes beyond margins when typing spaces at the end of a line
https://bugs.documentfoundation.org/show_bug.cgi?id=155494 --- Comment #58 from Mike Kaganski --- (In reply to William Friedman from comment #56) > This bug report involved two different elements which got conflated. My main > issue was the cursor display issue, which results in actually buggy behavior > (see my comment 22 and Laszlo's confirmation in comment 46) like > disappearing cursors and invalid selection areas, and which IMO should be > reverted. IMO, instead of the spaces over margins, our usual metaphor for text not fitting to the space - which is a red triangle showing "more content outside of the bounds" - could be used instead. Cf. to a fixed-size table cell / frame, having too much text. However, the cursor would still not move to the next line immediately, since it will walk through every space in the hidden space run. It is IMO the only sane behavior - skipping all the whitespace at once is inconsistent. > The question of how the spaces are actually treated is a secondary > issue to this bug. OK - got confused then by the text in comment 0. But then, are the bugs marked as duplicates actually duplicates? -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-7-6' - vcl/osx
vcl/osx/DataFlavorMapping.cxx | 25 ++---
vcl/osx/DataFlavorMapping.hxx |4 ++--
vcl/osx/clipboard.cxx |2 +-
3 files changed, 25 insertions(+), 6 deletions(-)
New commits:
commit 97f075ab95a592e9bd482031468b85e8bb7dc469
Author: Patrick Luby
AuthorDate: Tue Dec 26 10:45:08 2023 -0500
Commit: Mike Kaganski
CommitDate: Fri Dec 29 05:14:18 2023 +0100
tdf#151679 Do not push FLAVOR_LINK to macOS general pasteboard
When copying text from a Writer document and the
FLAVOR_LINK flavor is pasted, Writer will edit the
copied text in order to create a bookmark for DDE.
The problem is that many macOS clipboard managers
fetch *all* available flavors that are available in
the macOS general pasteboard instead of just one
flavor and this triggers the FLAVOR_LINK flavor's
unusual editing behavor in Writer every time the
user copies Writer text.
Users have reported in tdf#1515679 that on macOS,
Microsoft Writer, Excel, and PowerPoint do not
recognize this flavor like is done on Windows so,
in theory, we can just filter out this flavor when
adding flavors to the macOS general pasteboard.
With this change, the FLAVOR_LINK flavor will still
be visible when copying and pasting within a single
LibreOffice instance as well as when dragging from
LibreOffice to other applications.
Change-Id: Ia391398286fa8795ac65b4702a15caf59fb3ae70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161305
Reviewed-by: Mike Kaganski
Tested-by: Jenkins
Reviewed-by: Patrick Luby
(cherry picked from commit 29cc78b12315083ac5cfb2f59101d25e76b4f662)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161316
diff --git a/vcl/osx/DataFlavorMapping.cxx b/vcl/osx/DataFlavorMapping.cxx
index 274a2b4a4be7..361e268bcd6d 100644
--- a/vcl/osx/DataFlavorMapping.cxx
+++ b/vcl/osx/DataFlavorMapping.cxx
@@ -545,7 +545,7 @@ DataFlavor DataFlavorMapper::systemToOpenOfficeFlavor(
const NSString* systemDat
return oOOFlavor;
}
-const NSString* DataFlavorMapper::openOfficeToSystemFlavor( const DataFlavor&
oOOFlavor, bool& rbInternal) const
+const NSString* DataFlavorMapper::openOfficeToSystemFlavor( const DataFlavor&
oOOFlavor, bool& rbInternal, bool bIsSystemClipboard ) const
{
const NSString* sysFlavor = nullptr;
rbInternal = false;
@@ -554,6 +554,25 @@ const NSString*
DataFlavorMapper::openOfficeToSystemFlavor( const DataFlavor& oO
{
if
(oOOFlavor.MimeType.startsWith(OUString::createFromAscii(flavorMap[i].OOoFlavor)))
{
+// tdf#151679 Do not push FLAVOR_LINK to macOS general pasteboard
+// When copying text from a Writer document and the FLAVOR_LINK
+// flavor is pasted, Writer will edit the copied text in order
+// to create a bookmark for DDE.
+// The problem is that many macOS clipboard managers fetch *all*
+// available flavors that are available in the macOS general
+// pasteboard instead of just one flavor and this triggers the
+// FLAVOR_LINK flavor's unusual editing behavor in Writer every
+// time the user copies Writer text.
+// Users have reported in tdf#1515679 that on macOS, Microsoft
+// Writer, Excel, and PowerPoint do not recognize this flavor
+// like is done on Windows so, in theory, we can just filter out
+// this flavor when adding flavors to the macOS general pasteboard.
+// With this change, the FLAVOR_LINK flavor will still be visible
+// when copying and pasting within a single LibreOffice instance
+// as well as when dragging from LibreOffice to other applications.
+if (bIsSystemClipboard && !strcmp(FLAVOR_LINK,
flavorMap[i].OOoFlavor))
+return nullptr;
+
if (flavorMap[i].SystemFlavor != nil)
sysFlavor = flavorMap[i].SystemFlavor;
else
@@ -695,7 +714,7 @@ bool DataFlavorMapper::isValidMimeContentType(const
OUString& contentType) const
return result;
}
-NSArray* DataFlavorMapper::flavorSequenceToTypesArray(const
css::uno::Sequence& flavors) const
+NSArray* DataFlavorMapper::flavorSequenceToTypesArray(const
css::uno::Sequence& flavors, bool
bIsSystemClipboard) const
{
sal_uInt32 nFlavors = flavors.getLength();
NSMutableArray* array = [[NSMutableArray alloc] initWithCapacity: 1];
@@ -710,7 +729,7 @@ NSArray* DataFlavorMapper::flavorSequenceToTypesArray(const
css::uno::Sequence& flavors) const;
+ NSArray* flavorSequenceToTypesArray(const
css::uno::Sequence& flavors, bool
bIsSystemClipboard = false) const;
/* Translate an NSArray of system types into a sequence of DataFlavors.
Only those types for which a suitable mapping to a DataFlavor
diff --git a/vcl/osx/clipboard.cxx b/vcl/osx/clipboard.cxx
index 2dc2d5eef888..5d925b3b1954
core.git: Branch 'libreoffice-24-2' - vcl/osx
vcl/osx/DataFlavorMapping.cxx | 25 ++---
vcl/osx/DataFlavorMapping.hxx |4 ++--
vcl/osx/clipboard.cxx |2 +-
3 files changed, 25 insertions(+), 6 deletions(-)
New commits:
commit 7e4fd3c226d440d167a6581f82d8a83b628bcaa4
Author: Patrick Luby
AuthorDate: Tue Dec 26 10:45:08 2023 -0500
Commit: Mike Kaganski
CommitDate: Fri Dec 29 05:14:07 2023 +0100
tdf#151679 Do not push FLAVOR_LINK to macOS general pasteboard
When copying text from a Writer document and the
FLAVOR_LINK flavor is pasted, Writer will edit the
copied text in order to create a bookmark for DDE.
The problem is that many macOS clipboard managers
fetch *all* available flavors that are available in
the macOS general pasteboard instead of just one
flavor and this triggers the FLAVOR_LINK flavor's
unusual editing behavor in Writer every time the
user copies Writer text.
Users have reported in tdf#1515679 that on macOS,
Microsoft Writer, Excel, and PowerPoint do not
recognize this flavor like is done on Windows so,
in theory, we can just filter out this flavor when
adding flavors to the macOS general pasteboard.
With this change, the FLAVOR_LINK flavor will still
be visible when copying and pasting within a single
LibreOffice instance as well as when dragging from
LibreOffice to other applications.
Change-Id: Ia391398286fa8795ac65b4702a15caf59fb3ae70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161305
Reviewed-by: Mike Kaganski
Tested-by: Jenkins
Reviewed-by: Patrick Luby
(cherry picked from commit 29cc78b12315083ac5cfb2f59101d25e76b4f662)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161315
diff --git a/vcl/osx/DataFlavorMapping.cxx b/vcl/osx/DataFlavorMapping.cxx
index 274a2b4a4be7..361e268bcd6d 100644
--- a/vcl/osx/DataFlavorMapping.cxx
+++ b/vcl/osx/DataFlavorMapping.cxx
@@ -545,7 +545,7 @@ DataFlavor DataFlavorMapper::systemToOpenOfficeFlavor(
const NSString* systemDat
return oOOFlavor;
}
-const NSString* DataFlavorMapper::openOfficeToSystemFlavor( const DataFlavor&
oOOFlavor, bool& rbInternal) const
+const NSString* DataFlavorMapper::openOfficeToSystemFlavor( const DataFlavor&
oOOFlavor, bool& rbInternal, bool bIsSystemClipboard ) const
{
const NSString* sysFlavor = nullptr;
rbInternal = false;
@@ -554,6 +554,25 @@ const NSString*
DataFlavorMapper::openOfficeToSystemFlavor( const DataFlavor& oO
{
if
(oOOFlavor.MimeType.startsWith(OUString::createFromAscii(flavorMap[i].OOoFlavor)))
{
+// tdf#151679 Do not push FLAVOR_LINK to macOS general pasteboard
+// When copying text from a Writer document and the FLAVOR_LINK
+// flavor is pasted, Writer will edit the copied text in order
+// to create a bookmark for DDE.
+// The problem is that many macOS clipboard managers fetch *all*
+// available flavors that are available in the macOS general
+// pasteboard instead of just one flavor and this triggers the
+// FLAVOR_LINK flavor's unusual editing behavor in Writer every
+// time the user copies Writer text.
+// Users have reported in tdf#1515679 that on macOS, Microsoft
+// Writer, Excel, and PowerPoint do not recognize this flavor
+// like is done on Windows so, in theory, we can just filter out
+// this flavor when adding flavors to the macOS general pasteboard.
+// With this change, the FLAVOR_LINK flavor will still be visible
+// when copying and pasting within a single LibreOffice instance
+// as well as when dragging from LibreOffice to other applications.
+if (bIsSystemClipboard && !strcmp(FLAVOR_LINK,
flavorMap[i].OOoFlavor))
+return nullptr;
+
if (flavorMap[i].SystemFlavor != nil)
sysFlavor = flavorMap[i].SystemFlavor;
else
@@ -695,7 +714,7 @@ bool DataFlavorMapper::isValidMimeContentType(const
OUString& contentType) const
return result;
}
-NSArray* DataFlavorMapper::flavorSequenceToTypesArray(const
css::uno::Sequence& flavors) const
+NSArray* DataFlavorMapper::flavorSequenceToTypesArray(const
css::uno::Sequence& flavors, bool
bIsSystemClipboard) const
{
sal_uInt32 nFlavors = flavors.getLength();
NSMutableArray* array = [[NSMutableArray alloc] initWithCapacity: 1];
@@ -710,7 +729,7 @@ NSArray* DataFlavorMapper::flavorSequenceToTypesArray(const
css::uno::Sequence& flavors) const;
+ NSArray* flavorSequenceToTypesArray(const
css::uno::Sequence& flavors, bool
bIsSystemClipboard = false) const;
/* Translate an NSArray of system types into a sequence of DataFlavors.
Only those types for which a suitable mapping to a DataFlavor
diff --git a/vcl/osx/clipboard.cxx b/vcl/osx/clipboard.cxx
index 2dc2d5eef888..5d925b3b1954
core.git: sw/source
sw/source/core/text/portxt.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit f011086f38775182ed3e05fc7a79ddfd8605af19 Author: Mike Kaganski AuthorDate: Thu Dec 28 19:02:44 2023 +0100 Commit: Mike Kaganski CommitDate: Fri Dec 29 04:58:21 2023 +0100 Avoid static_casts Change-Id: I57d7aa4cf7dbadc5a40b69da789a16a269c92544 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161326 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/sw/source/core/text/portxt.cxx b/sw/source/core/text/portxt.cxx index bcc547d1796b..1042dcf54165 100644 --- a/sw/source/core/text/portxt.cxx +++ b/sw/source/core/text/portxt.cxx @@ -517,9 +517,9 @@ void SwTextPortion::FormatEOL( SwTextFormatInfo ) Width( Width() - nBlankSize ); rInf.X( rInf.X() - nBlankSize ); SetLen( GetLen() - nHoleLen ); -SwLinePortion *pHole = new SwHolePortion( *this ); -static_cast( pHole )->SetBlankWidth( nBlankSize ); -static_cast( pHole )->SetLen( nHoleLen ); +SwHolePortion* pHole = new SwHolePortion(*this); +pHole->SetBlankWidth(nBlankSize); +pHole->SetLen(nHoleLen); Insert( pHole ); }
[Bug 158708] Empty cell in Writer table with footnote breaks formulas involving that cell
https://bugs.documentfoundation.org/show_bug.cgi?id=158708 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155674] MAILMERGE: next record hides all fields during edit (output result is OK)
https://bugs.documentfoundation.org/show_bug.cgi?id=155674 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158889] Macro kill => any attempt to access macros crashes LOo
https://bugs.documentfoundation.org/show_bug.cgi?id=158889 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158889] Macro kill => any attempt to access macros crashes LOo
https://bugs.documentfoundation.org/show_bug.cgi?id=158889 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155606] Can't edit file on samba shares
https://bugs.documentfoundation.org/show_bug.cgi?id=155606 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158841] Numbering of the chapters is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=158841 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158841] Numbering of the chapters is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=158841 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155606] Can't edit file on samba shares
https://bugs.documentfoundation.org/show_bug.cgi?id=155606 --- Comment #3 from QA Administrators --- Dear Vibhu, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155603] Shortcut of submenu need to display in below of menubar
https://bugs.documentfoundation.org/show_bug.cgi?id=155603 --- Comment #3 from QA Administrators --- Dear Biren, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155578] Configure fails
https://bugs.documentfoundation.org/show_bug.cgi?id=155578 --- Comment #3 from QA Administrators --- Dear Anubhav, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155487] Crash when zoomed too much at the flow chart
https://bugs.documentfoundation.org/show_bug.cgi?id=155487 --- Comment #11 from QA Administrators --- Dear anedroid, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107872] [META] Unified Office Format (UOF) issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107872 Bug 107872 depends on bug 149852, which changed state. Bug 149852 Summary: Opening Spreadsheet Saved as .UOS fails https://bugs.documentfoundation.org/show_bug.cgi?id=149852 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 149852] Opening Spreadsheet Saved as .UOS fails
https://bugs.documentfoundation.org/show_bug.cgi?id=149852 --- Comment #7 from QA Administrators --- Dear cvroblee, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108908 Bug 108908 depends on bug 140696, which changed state. Bug 140696 Summary: vba initialisation of variables https://bugs.documentfoundation.org/show_bug.cgi?id=140696 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 140696] vba initialisation of variables
https://bugs.documentfoundation.org/show_bug.cgi?id=140696 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 90993] EDITING: Objects anchored to frame disappear when frame anchor is changed.
https://bugs.documentfoundation.org/show_bug.cgi?id=90993 --- Comment #12 from QA Administrators --- Dear Gordo, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 140696] vba initialisation of variables
https://bugs.documentfoundation.org/show_bug.cgi?id=140696 --- Comment #10 from QA Administrators --- Dear Harald Langheinrich, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 90858] Shape doesnt return to original position after Undoing anchor
https://bugs.documentfoundation.org/show_bug.cgi?id=90858 --- Comment #7 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138153] Image off page after changing anchor to 'to character' inside a caption frame (and undo doesn't solve it)
https://bugs.documentfoundation.org/show_bug.cgi?id=138153 --- Comment #5 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 90693] FORMATTING list: paragraph underline extends to tab when image has no wrap
https://bugs.documentfoundation.org/show_bug.cgi?id=90693 --- Comment #20 from QA Administrators --- Dear Thomas Ascher, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 86812] Redlining: On save, 2nd bullet is lost in ODT
https://bugs.documentfoundation.org/show_bug.cgi?id=86812 --- Comment #7 from QA Administrators --- Dear Jan Holesovsky, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 67764] FORMATTING: Spaces removed when pasting from windows clipboard data stored as HTML format
https://bugs.documentfoundation.org/show_bug.cgi?id=67764 --- Comment #13 from QA Administrators --- Dear nubile, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 135147] Image disappearing after changing anchor from to page to to paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=135147 --- Comment #5 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 128471] If shapes are anchored "to frame" and then the anchoring of the frame is changed, then the Shapes become hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=128471 --- Comment #5 from QA Administrators --- Dear sdc.blanco, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 114712] Chart anchored as character not shown on page
https://bugs.documentfoundation.org/show_bug.cgi?id=114712 --- Comment #4 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112023] Copying data from Base truncates precision to the shown format
https://bugs.documentfoundation.org/show_bug.cgi?id=112023 --- Comment #13 from QA Administrators --- Dear Lars Jødal, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155045] [META] RTF Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=155045 Bug 155045 depends on bug 158826, which changed state. Bug 158826 Summary: FILEOPEN RTF Floating table with image creates unexpected page break https://bugs.documentfoundation.org/show_bug.cgi?id=158826 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158826] FILEOPEN RTF Floating table with image creates unexpected page break
https://bugs.documentfoundation.org/show_bug.cgi?id=158826 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158826] FILEOPEN RTF Floating table with image creates unexpected page break
https://bugs.documentfoundation.org/show_bug.cgi?id=158826 --- Comment #7 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/8d37b8e6430715860934ccaec8c0d1b448ac4d8c tdf#158826 rtfimport: ignore page break before document starts It will be available in 24.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158826] FILEOPEN RTF Floating table with image creates unexpected page break
https://bugs.documentfoundation.org/show_bug.cgi?id=158826 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 |target:24.8.0 ||target:24.2.0.2 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - sw/qa writerfilter/source
sw/qa/extras/rtfexport/data/tdf158826_extraCR.rtf | 23 ++
sw/qa/extras/rtfexport/rtfexport8.cxx | 14 +
writerfilter/source/rtftok/rtfdispatchflag.cxx|4 ++-
3 files changed, 40 insertions(+), 1 deletion(-)
New commits:
commit 8d37b8e6430715860934ccaec8c0d1b448ac4d8c
Author: Justin Luth
AuthorDate: Wed Dec 27 18:58:33 2023 -0500
Commit: Justin Luth
CommitDate: Fri Dec 29 03:44:03 2023 +0100
tdf#158826 rtfimport: ignore page break before document starts
This avoids a 24.2 exposed bug from my
commit 016f779ee6c7f601be3ae19dc57497e63a5bf817
RTF import simply cannot be relied upon to create paragraphs
where they need to be. A side effect of fixing frames
is that spurious paragraphs can be created,
and if a frame starts the document, then an otherwise
ignored page break can be attached to the second paragraph
and thus become exposed.
This seems pretty much like the RTF implementation of
what was done for DOC and DOCX for tdf#118711.
At least it is related.
make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158826_extraCR
The following unit tests trigger this code (with no visible change)
abi10076.odt tdf121623.rtf tdf129513.rtf tdf131963.docx
Change-Id: I21afa826b6f6fbb735591603a0620b8b47de517e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161374
Tested-by: Jenkins
Reviewed-by: Justin Luth
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161395
diff --git a/sw/qa/extras/rtfexport/data/tdf158826_extraCR.rtf
b/sw/qa/extras/rtfexport/data/tdf158826_extraCR.rtf
new file mode 100644
index ..5461327da3ca
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/tdf158826_extraCR.rtf
@@ -0,0 +1,23 @@
+{
tf1
+\landscape\paperh5953\paperw8391\margl720\margr720\margt432\margb1728\gutter0\ltrsect
+
+
+\pagebb
+\intbl
+\pvpg\phpg
+
+\posx720\posy432
+\dxfrtext187\dfrmtxtx187\dfrmtxty0
+\wraparoundspalphaspnum
+ aautodjustright
+
in0\lin0bsnoovrlp1\pararsid5332093\yts39
+
+
+\shp
+
+
+a +++
+}
diff --git a/sw/qa/extras/rtfexport/rtfexport8.cxx
b/sw/qa/extras/rtfexport/rtfexport8.cxx
index f8d800380cba..9848d0573db8 100644
--- a/sw/qa/extras/rtfexport/rtfexport8.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport8.cxx
@@ -36,6 +36,8 @@
using namespace css;
+namespace
+{
class Test : public SwModelTestBase
{
public:
@@ -84,6 +86,18 @@ DECLARE_RTFEXPORT_TEST(testTdf158586_lostFrame,
"tdf158586_lostFrame.rtf")
// CPPUNIT_ASSERT_EQUAL(2, getPages());
}
+DECLARE_RTFEXPORT_TEST(testTdf158826_extraCR, "tdf158826_extraCR.rtf")
+{
+// Note: this is a hand-minimized sample, and very likely doesn't follow
RTF { } rules...
+
+// The page break defined before the document content should not cause a
page break
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+
+// There is a two-column floating table [that SHOULD be
getParagraphOrTable(1)]
+uno::Reference xTable(getParagraphOrTable(2),
uno::UNO_QUERY_THROW);
+}
+
+} // end of anonymous namespace
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/rtftok/rtfdispatchflag.cxx
b/writerfilter/source/rtftok/rtfdispatchflag.cxx
index 72c777aab1fb..753f1c3fbba9 100644
--- a/writerfilter/source/rtftok/rtfdispatchflag.cxx
+++ b/writerfilter/source/rtftok/rtfdispatchflag.cxx
@@ -520,7 +520,9 @@ RTFError RTFDocumentImpl::dispatchFlag(RTFKeyword nKeyword)
}
break;
case RTFKeyword::PAGEBB:
-nParam = NS_ooxml::LN_CT_PPrBase_pageBreakBefore;
+// ignore a page break that is defined before the document content
has even started
+if (!m_bFirstRun)
+nParam = NS_ooxml::LN_CT_PPrBase_pageBreakBefore;
break;
default:
break;
[Bug 154339] Plain text copied to clipboard and pasted to CSV is not saved.
https://bugs.documentfoundation.org/show_bug.cgi?id=154339 ady changed: What|Removed |Added CC||saywel...@gmail.com --- Comment #11 from ady --- *** Bug 158916 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158916] Calc data lost during saving .csv
https://bugs.documentfoundation.org/show_bug.cgi?id=158916 ady changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from ady --- *** This bug has been marked as a duplicate of bug 154339 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158915] Very slow file-opening if embedded font being enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=158915 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO --- Comment #1 from m.a.riosv --- Maybe an only Mac issue, open instantly on: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a22ac6caece8da5add6800bdfba9865bdcfde064 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Have you tested in Menu/Help/Restart in Safe Mode. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158909] changing Font Size Issue
https://bugs.documentfoundation.org/show_bug.cgi?id=158909 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- Some cells have 'verdana, arial' fonts size 7. Not fine, not showing the same once you double-click on the cell. A cell with two fonts inside doesn't allow changing the size. After clearing direct format [Ctrl+M], the change is possible. Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded and in Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a22ac6caece8da5add6800bdfba9865bdcfde064 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - editeng/inc editeng/source
editeng/inc/TextPortion.hxx | 147
editeng/inc/editdoc.hxx | 124 --
editeng/source/editeng/editdoc.cxx | 26 --
editeng/source/editeng/impedit.hxx | 10 +-
editeng/source/editeng/impedit3.cxx |1
5 files changed, 155 insertions(+), 153 deletions(-)
New commits:
commit 629f55de24aca6eed7cb3bb8ad2bd8f4a6593d46
Author: Tomaž Vajngerl
AuthorDate: Fri Dec 22 20:04:01 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Dec 29 02:42:21 2023 +0100
editeng: simplify FormatterFontMetric
We don't really need a custom constructor and default values can
now be set directly.
Change-Id: I7e8aabf2c60d3b63abf1764bbff512685803f71e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161349
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/source/editeng/impedit.hxx
b/editeng/source/editeng/impedit.hxx
index 89339b11dc3e..4b283106 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -181,11 +181,13 @@ struct ConvInfo
struct FormatterFontMetric
{
-sal_uInt16 nMaxAscent;
-sal_uInt16 nMaxDescent;
+sal_uInt16 nMaxAscent = 0;
+sal_uInt16 nMaxDescent = 0;
-FormatterFontMetric() : nMaxAscent(0), nMaxDescent(0) { /* nMinLeading =
0x; */ }
-sal_uInt16 GetHeight() const { return nMaxAscent+nMaxDescent; }
+sal_uInt16 GetHeight() const
+{
+return nMaxAscent + nMaxDescent;
+}
};
class IdleFormattter : public Idle
commit 1958805f61612a7b23f1c5c2d532be4d5dc24a2a
Author: Tomaž Vajngerl
AuthorDate: Sat Dec 9 15:26:34 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Dec 29 02:42:14 2023 +0100
editeng: move TextPortion to own header file
Change-Id: I54d0bbad4ef142705191672319774f26abf3e735
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161348
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/inc/TextPortion.hxx b/editeng/inc/TextPortion.hxx
new file mode 100644
index ..e5560f260326
--- /dev/null
+++ b/editeng/inc/TextPortion.hxx
@@ -0,0 +1,147 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include "editattr.hxx"
+#include "edtspell.hxx"
+#include "eerdll2.hxx"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+enum class PortionKind
+{
+TEXT = 0,
+TAB = 1,
+LINEBREAK = 2,
+FIELD = 3,
+HYPHENATOR = 4
+};
+
+enum class AsianCompressionFlags
+{
+Normal = 0x00,
+Kana = 0x01,
+PunctuationLeft = 0x02,
+PunctuationRight = 0x04,
+};
+namespace o3tl
+{
+template <> struct typed_flags :
is_typed_flags
+{
+};
+}
+
+struct ExtraPortionInfo
+{
+ExtraPortionInfo() {}
+
+tools::Long nOrgWidth = 0;
+tools::Long nWidthFullCompression = 0;
+
+tools::Long nPortionOffsetX = 0;
+
+sal_uInt16 nMaxCompression100thPercent = 0;
+
+AsianCompressionFlags nAsianCompressionTypes =
AsianCompressionFlags::Normal;
+bool bFirstCharIsRightPunktuation = false;
+bool bCompressed = false;
+
+std::unique_ptr pOrgDXArray;
+std::vector lineBreaksList;
+
+void SaveOrgDXArray(const sal_Int32* pDXArray, sal_Int32 nLen)
+{
+if (pDXArray)
+{
+pOrgDXArray.reset(new sal_Int32[nLen]);
+memcpy(pOrgDXArray.get(), pDXArray, nLen * sizeof(sal_Int32));
+}
+else
+pOrgDXArray.reset();
+}
+};
+
+class TextPortion
+{
+private:
+std::unique_ptr xExtraInfos;
+sal_Int32 nLen;
+Size aOutSz = Size(-1, -1);
+PortionKind nKind = PortionKind::TEXT;
+sal_uInt8 nRightToLeftLevel = 0;
+sal_Unicode nExtraValue = 0;
+
+public:
+TextPortion(sal_Int32 nL)
+: nLen(nL)
+{
+}
+
+TextPortion(const TextPortion& r)
+: nLen(r.nLen)
+, aOutSz(r.aOutSz)
+, nKind(r.nKind)
+, nRightToLeftLevel(r.nRightToLeftLevel)
+, nExtraValue(r.nExtraValue)
+{
+}
+
+sal_Int32 GetLen() const { return nLen; }
+
[Bug 158906] Libreoffice Calc can't save files after update to v.7.6.2 and later version of libreoffice.
https://bugs.documentfoundation.org/show_bug.cgi?id=158906 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- Please take a look: https://wiki.documentfoundation.org/Faq/General/Defender_Controlled_folder_access_exception -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158903] LibreCalc cut and browser bug Version: 7.4.7.2
https://bugs.documentfoundation.org/show_bug.cgi?id=158903 m.a.riosv changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- It is not possible, that kind of selection. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103437] [META] Animation deck/tab of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=103437 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||158710 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158710 [Bug 158710] All icons and descriptions of animations behaviour in the animation list have disappeared -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158710] All icons and descriptions of animations behaviour in the animation list have disappeared
https://bugs.documentfoundation.org/show_bug.cgi?id=158710 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.6.4.1 release |7.6.0.0 alpha0+ CC||stephane.guillou@libreoffic ||e.org Ever confirmed|0 |1 OS|Windows (All) |All Keywords||bibisectRequest, regression Status|UNCONFIRMED |NEW Blocks||103437 --- Comment #3 from Stéphane Guillou (stragu) --- Not reproduced with the gtk3 VCL plugin, but reproduced with gen: Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 29097009b1f8c0dcb050367d3f2acfcaf2074a56 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded No repro in 7.5 -> regression. Bibisection with linux-64-7.6 repo: - Still good at [fa609c12e] source sha:33c2443134cfd2110258d5424645ace9e1db127f - Can't start Impress since [b458474ec] (source sha:26bf26272bf525b59b4a4ce18b3ce14c1febfd7b) and up to [595710182] (source sha:10cf767884de2c465304ef4b617d924e2d13630f) because of bug 155034 - Bad at [9cb93f1cb] source sha:1770d3ba3313f2166153d39be6ae1212c00da6d8 So relevant range is: https://git.libreoffice.org/core/+log/26bf26272bf525b59b4a4ce18b3ce14c1febfd7b..1770d3ba3313f2166153d39be6ae1212c00da6d8 This range could be bibisected on e.g. Windows or Ubuntu 22.04. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103437 [Bug 103437] [META] Animation deck/tab of the sidebar -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158916] New: Calc data lost during saving .csv
https://bugs.documentfoundation.org/show_bug.cgi?id=158916 Bug ID: 158916 Summary: Calc data lost during saving .csv Product: LibreOffice Version: 7.5.8.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: saywel...@gmail.com Data is lost when modifying and then saving a .csv. This occurs in 7.5.8.2 and 7.6.4.1 but not in 7.3.1.3. From https://ask.libreoffice.org/t/bug-202312-calc-data-lost-during-saving-csv/99947 Steps to recreate: 1. Create new spreadsheet and enter 0 in A1 & A2, a in B1 & B2 2. Save as Text CSV (*.csv), filters: * Unicode (UTF-8) * Filter delimiter ; * String delimiter " * Save cell content as shown * Quote all text cells 3. In another spreadsheet in each of cells A:A3 enter b Copy the three cells then paste as unformatted text into B1 in test spreadsheet 4. Select cells A1:A3 and press Ctrl+D to fill down 5. Click Save. 6. Click *File > Reload*. Only 2 rows of data are available, not three Expected result, all 6 cells are saved -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158712] Crash with bookmarks menu extension
https://bugs.documentfoundation.org/show_bug.cgi?id=158712 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||133092 Ever confirmed|0 |1 CC||stephane.guillou@libreoffic ||e.org Summary|Bookmarks menu extention|Crash with bookmarks menu ||extension Status|UNCONFIRMED |NEW --- Comment #1 from Stéphane Guillou (stragu) --- I get some freezes and crashes after opening the Edit Bookmarks dialog, and then executing some actions like resizing the panels / the window, tagging a file and closing the dialog, with different crash signatures: - libc.so.6 (with LO 7.6.4) https://crashreport.libreoffice.org/stats/crash_details/bd817147-5f2c-461b-bf22-eba026228440 - accessibility::AccessibleGridControlTable::getAccessibleChild(long) (with LO 7.6.4) https://crashreport.libreoffice.org/stats/crash_details/8d311d18-5e24-44a2-a287-347b2e5d6376 - libc-2.31.so (with LO 6.0) https://crashreport.libreoffice.org/stats/crash_details/f3b09fca-cf66-4e5c-95ca-495bef017870 Some reliable steps for me: 1. Bookmark a file 2. Bookmarks > Edit bookmarks 3. Select bookmarked file and add a value in the Tags field (or change the Name value) 4. Click out of the Tags or Name field 5. Close the dialog Is it something similar that you see? Do you have a crash report you can link to? Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 29097009b1f8c0dcb050367d3f2acfcaf2074a56 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||158712 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158712 [Bug 158712] Crash with bookmarks menu extension -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158886] Drag-and-drop selection of text with the mouse no longer shows highlight, or leaves a trail of highlight and cursors (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=158886 --- Comment #4 from Telesto --- I don't reproduce Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 40617d867346956588ac023511f31210107217f4 CPU threads: 8; OS: macOS 13.6.3; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded It sounds like a variant of bug 155266, IMHO. Reverting to 7.6.3 should solve the issue until the release of 7.6.5 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158879] direct-formatting of INDIVIDUAL list symbols
https://bugs.documentfoundation.org/show_bug.cgi?id=158879 libretist changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8835 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158835] Discrepancy of direct formatting precedence over list number/bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=158835 libretist changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8879 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150517] Borders from a character style in "list context" not displayed (wokaround: assign font color)
https://bugs.documentfoundation.org/show_bug.cgi?id=150517 libretist changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8835 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158835] Discrepancy of direct formatting precedence over list number/bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=158835 libretist changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0517 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158893] [RFE] add "related bugs" to bug submission template
https://bugs.documentfoundation.org/show_bug.cgi?id=158893 --- Comment #4 from libretist --- (In reply to Stéphane Guillou (stragu) from comment #3) sorry, I missed it because "blocks" and "depends on" both have a form field. This is why I missed the "see also" field, although I kept looking hard for it. So maybe give it a form field so that is not overlooked (and also for the sake of consistency) ? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158889] Macro kill => any attempt to access macros crashes LOo
https://bugs.documentfoundation.org/show_bug.cgi?id=158889 --- Comment #10 from LOO Debugger --- Comment on attachment 191620 --> https://bugs.documentfoundation.org/attachment.cgi?id=191620 Attempting to debug with GDB Attempting to do as recommended. - As user => GDB cannot attach to process - Ass root => LOo seems to crash too strongly ; results in message "no bt" in GDB -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158889] Macro kill => any attempt to access macros crashes LOo
https://bugs.documentfoundation.org/show_bug.cgi?id=158889 --- Comment #9 from LOO Debugger --- Created attachment 191620 --> https://bugs.documentfoundation.org/attachment.cgi?id=191620=edit Attempting to debug with GDB -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-7-6' - android/source
android/source/res/values-fr/strings.xml | 17 +++ android/source/res/values-hu/strings.xml | 58 + android/source/res/values-it/strings.xml | 70 +++ 3 files changed, 145 insertions(+) New commits: commit f064b10479040f80e99cc3f32364ba41da1a759c Author: Weblate AuthorDate: Thu Dec 28 16:40:04 2023 +0100 Commit: Michael Weghorn CommitDate: Fri Dec 29 00:37:45 2023 +0100 android-viewer translated using Weblate Italian currently translated at 92.3% (120 of 130 strings) Change-Id: Iefd35175f5b0e37f6057e2d8d7b53c7fa6869dd4 android-viewer translated using Weblate Italian currently translated at 92.3% (120 of 130 strings) Change-Id: I78056d3ba57c377b223b20575ebb23781d971d60 android-viewer translated using Weblate Italian currently translated at 87.6% (114 of 130 strings) Change-Id: I81efd4352d003cbc7bc1f48878e8e8a91669b8df android-viewer translated using Weblate Italian currently translated at 87.6% (114 of 130 strings) Change-Id: Ibf62594e7bcd41bab7440f328e1116353c7c51b9 android-viewer translated using Weblate Italian currently translated at 87.6% (114 of 130 strings) Change-Id: Ie72a2287df3b957ac0924a1f80af7c2d9207f7b8 android-viewer translated using Weblate Italian currently translated at 87.6% (114 of 130 strings) Change-Id: Ia9b85741e155eaf675140b7b4d6c123e31e61366 android-viewer translated using Weblate Italian currently translated at 83.8% (109 of 130 strings) Change-Id: I490a6eadd89a3f838c97264d90b0474c824fae3d android-viewer translated using Weblate Italian currently translated at 83.8% (109 of 130 strings) Change-Id: I578b413f9e022fee0dc75034c9fb55e873ede716 android-viewer translated using Weblate Italian currently translated at 83.0% (108 of 130 strings) Change-Id: I75a25cfbf77e520fad14e93800cf639ab58feb89 android-viewer translated using Weblate Italian currently translated at 81.5% (106 of 130 strings) Change-Id: I21e000a8e908bb52aa1243108573f1890e4a4845 android-viewer translated using Weblate Italian currently translated at 81.5% (106 of 130 strings) Change-Id: Id917cffa252a1e85b00227519a3a878911d98bc5 android-viewer translated using Weblate Italian currently translated at 71.5% (93 of 130 strings) Change-Id: Iae0d6889f7b8fde95eb1f4798e438f0b1ad1aa49 android-viewer translated using Weblate Italian currently translated at 71.5% (93 of 130 strings) Change-Id: If69ae31a8e283fb87b14f49ac02743cb97183a99 android-viewer translated using Weblate Italian currently translated at 70.7% (92 of 130 strings) Change-Id: I23616539267a880972722327b80fd628e2fab552 android-viewer translated using Weblate Italian currently translated at 70.7% (92 of 130 strings) Change-Id: I49a199188f7ba8d8f7b7c21207e97a536bbf81a0 android-viewer translated using Weblate Italian currently translated at 67.6% (88 of 130 strings) Change-Id: I7104d0a048440b2b93885b177f0c2db1126e9376 android-viewer translated using Weblate Italian currently translated at 67.6% (88 of 130 strings) Change-Id: I1097af1bee7e1a06c9adc8705daa2ff9a52a946c android-viewer translated using Weblate Italian currently translated at 66.9% (87 of 130 strings) Change-Id: I790431c7f5aa2fe163745c02ade392ba8a73b47b android-viewer translated using Weblate Italian currently translated at 66.9% (87 of 130 strings) Change-Id: Ic9494bd784a82c14511a65da4564cfbca3791ced android-viewer translated using Weblate Italian currently translated at 61.5% (80 of 130 strings) Change-Id: Ie2de44b3c0e3a005dec644c57d7ae36e4b5ba45f android-viewer translated using Weblate Italian currently translated at 61.5% (80 of 130 strings) Change-Id: Ie3a92c17c1cdd5c83fbd45aea289a9fd9597c327 android-viewer translated using Weblate Italian currently translated at 58.4% (76 of 130 strings) Change-Id: Ibe6177e4b93658d85ef751df7f20867f28b3565f android-viewer translated using Weblate Italian currently translated at 56.1% (73 of 130 strings) Change-Id: Ifd8dc5198fba048a7c7bb73890c04db9603f72d4 android-viewer translated using Weblate Italian currently translated at 56.1% (73 of 130 strings) Change-Id: I15b25c5b1fe8aefaaecce4352d176bd1e5f9e1f6 android-viewer translated using Weblate Italian currently translated at 53.0% (69 of 130 strings) Change-Id: Ia70a115ee3dfbf810f59be8a2c95141f5906d968 android-viewer translated using Weblate Hungarian currently translated at
core.git: accessibility/source
accessibility/source/extended/AccessibleBrowseBox.cxx |2 +-
accessibility/source/extended/AccessibleBrowseBoxBase.cxx |2 +-
accessibility/source/extended/AccessibleBrowseBoxCheckBoxCell.cxx |2 +-
accessibility/source/extended/AccessibleBrowseBoxHeaderBar.cxx|2 +-
accessibility/source/extended/AccessibleBrowseBoxHeaderCell.cxx |2 +-
accessibility/source/extended/AccessibleBrowseBoxTable.cxx|2 +-
accessibility/source/extended/AccessibleBrowseBoxTableCell.cxx|2 +-
accessibility/source/extended/AccessibleGridControl.cxx |2 +-
accessibility/source/extended/AccessibleGridControlBase.cxx |2 +-
accessibility/source/extended/AccessibleGridControlHeader.cxx |2 +-
accessibility/source/extended/AccessibleGridControlHeaderCell.cxx |2 +-
accessibility/source/extended/AccessibleGridControlTable.cxx |2 +-
accessibility/source/extended/AccessibleGridControlTableCell.cxx |2 +-
accessibility/source/extended/accessibleeditbrowseboxcell.cxx |2 +-
accessibility/source/extended/accessibleiconchoicectrl.cxx|8
accessibility/source/extended/accessibleiconchoicectrlentry.cxx |8
accessibility/source/extended/accessiblelistbox.cxx |8
accessibility/source/extended/accessiblelistboxentry.cxx |8
accessibility/source/extended/accessibletabbar.cxx|4 ++--
accessibility/source/extended/accessibletabbarpage.cxx|4 ++--
accessibility/source/extended/accessibletabbarpagelist.cxx|4 ++--
accessibility/source/extended/accessibletablistboxtable.cxx |2 +-
accessibility/source/standard/vclxaccessiblebutton.cxx|4 ++--
accessibility/source/standard/vclxaccessiblecheckbox.cxx |4 ++--
accessibility/source/standard/vclxaccessiblecombobox.cxx |4 ++--
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx |4 ++--
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx |4 ++--
accessibility/source/standard/vclxaccessibleedit.cxx |4 ++--
accessibility/source/standard/vclxaccessiblefixedhyperlink.cxx|4 ++--
accessibility/source/standard/vclxaccessiblefixedtext.cxx |4 ++--
accessibility/source/standard/vclxaccessibleheaderbar.cxx |4 ++--
accessibility/source/standard/vclxaccessiblemenu.cxx |4 ++--
accessibility/source/standard/vclxaccessiblepopupmenu.cxx |4 ++--
accessibility/source/standard/vclxaccessiblescrollbar.cxx |4 ++--
accessibility/source/standard/vclxaccessiblestatusbar.cxx |4 ++--
accessibility/source/standard/vclxaccessiblestatusbaritem.cxx |4 ++--
accessibility/source/standard/vclxaccessibletabcontrol.cxx|4 ++--
accessibility/source/standard/vclxaccessibletabpage.cxx |4 ++--
accessibility/source/standard/vclxaccessibletextfield.cxx |4 ++--
accessibility/source/standard/vclxaccessibletoolbox.cxx |4 ++--
accessibility/source/standard/vclxaccessibletoolboxitem.cxx | 10
+-
41 files changed, 78 insertions(+), 78 deletions(-)
New commits:
commit 0f6f5048d223731aa52b768a77244d0208711391
Author: Arnaud VERSINI
AuthorDate: Tue Dec 26 14:18:14 2023 +0100
Commit: Michael Weghorn
CommitDate: Fri Dec 29 00:36:51 2023 +0100
use string OUString literals in a11y for XServiceInfo impl.
Used in getImplementationName and getSupportedServiceNames
Change-Id: I003db960123c66d4d47b99aec678b156bf4c4d91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161301
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/accessibility/source/extended/AccessibleBrowseBox.cxx
b/accessibility/source/extended/AccessibleBrowseBox.cxx
index 6085ff9ec3ce..8408c0abe23a 100644
--- a/accessibility/source/extended/AccessibleBrowseBox.cxx
+++ b/accessibility/source/extended/AccessibleBrowseBox.cxx
@@ -171,7 +171,7 @@ void SAL_CALL AccessibleBrowseBox::grabFocus()
OUString SAL_CALL AccessibleBrowseBox::getImplementationName()
{
-return "com.sun.star.comp.svtools.AccessibleBrowseBox";
+return u"com.sun.star.comp.svtools.AccessibleBrowseBox"_ustr;
}
diff --git a/accessibility/source/extended/AccessibleBrowseBoxBase.cxx
b/accessibility/source/extended/AccessibleBrowseBoxBase.cxx
index 121655d78823..8d9a0577e638 100644
--- a/accessibility/source/extended/AccessibleBrowseBoxBase.cxx
+++ b/accessibility/source/extended/AccessibleBrowseBoxBase.cxx
@@ -304,7 +304,7 @@ sal_Bool SAL_CALL AccessibleBrowseBoxBase::supportsService(
Sequence< OUString > SAL_CALL
AccessibleBrowseBoxBase::getSupportedServiceNames()
{
-return { "com.sun.star.accessibility.AccessibleContext" };
+return { u"com.sun.star.accessibility.AccessibleContext"_ustr };
}
// other public methods
[Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast
https://bugs.documentfoundation.org/show_bug.cgi?id=119745 --- Comment #71 from carrt7 --- The excessive scrolling speed also occurs in HORIZONTAL scrolling under certain conditions. Viewing the middle of a large text-only document in a left-half-screen window: - scroll up/dn using 2-finger swipe on touch pad = too fast (F) - scroll up/dn using click horizontal scroll bar = F - scroll up/dn using click = F - scroll L/R using 2-finger swipe on touch pad = F - scroll L/R using click on horizontal scroll bar = Normal (N) - scroll L/R using click = N "F" (fast) scrolls across the entire width/height of the screen when I move my fingers about 1/8 inch across/down the touch pad. Thinkpad Extreme Gen 2, windows 11 Home, Chrome, Libre Office 7.4.6.1,Dec 2023. Carrt7 -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/uibase/uno/unotxdoc.cxx |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
New commits:
commit 029d761b92d7a5754ad7066238b8c20ae420d263
Author: Caolán McNamara
AuthorDate: Thu Dec 28 20:54:42 2023 +
Commit: Caolán McNamara
CommitDate: Fri Dec 29 00:31:42 2023 +0100
simplify this a little
Change-Id: I839a5b2277be4a03432d83177228e647ec7a6b85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161393
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/uibase/uno/unotxdoc.cxx
b/sw/source/uibase/uno/unotxdoc.cxx
index 3a14cb0f8f96..fab67cbd6e83 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -3723,14 +3723,11 @@ OUString SwXTextDocument::hyperlinkInfoAtPosition(int
x, int y)
if (pWrtShell->GetContentAtPos(point, aContentAtPos))
{
-OUString url = static_cast(aContentAtPos.aFnd.pAttr)->GetValue();
-return url;
+return static_cast(aContentAtPos.aFnd.pAttr)->GetValue();
}
-else
-return OUString();
}
-else
-return OUString();
+
+return OUString();
}
uno::Reference SwXTextDocument::getSelection()
[Bug 155674] MAILMERGE: next record hides all fields during edit (output result is OK)
https://bugs.documentfoundation.org/show_bug.cgi?id=155674 Luiz Angelo Daros de Luca changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #6 from Luiz Angelo Daros de Luca --- 3. Edit the first field (Record Number) "Num: Field1:..." 4. Add database file -> Add downloaded file "data.ods" 5. Select the table from data->tb1 Now you can use the "Mail Merge" toolbox to navigate between records. At first, you'll be at record -1 (because you were missing the database at start). When you select the first record, you'll get (# means empty field): Num: # Field1: a Field2: 1 Field3: ! Num: 1 Field1: # Field2: # Field3: # While it should be: Num: 1 Field1: a Field2: 1 Field3: ! Num: 2 Field1: b Field2: 2 Field3: @ Now we have multiple issues: 1) The field we edited (record number or any other) seems to be broken, although it is the same as the one in the second line (if you show field names with ctrl+f9). If we copy the one from the second line, over it, it works as expected. If we duplicate it, the copy is kept broken 2) The record number after the "Next Record:data.tb1" is still 1 while it should be 2 3) All other fields in the second line are empty during edition but they do work while merging the doc 4) If you reload this file a couple of times, LibreOffice frequently crashes. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158886] Drag-and-drop selection of text with the mouse no longer shows highlight, or leaves a trail of highlight and cursors (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=158886 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.6.4.1 release |7.5.9.2 release Keywords||bibisectRequest, regression --- Comment #3 from Stéphane Guillou (stragu) --- Also in 7.5.9: Version: 7.5.9.2 (X86_64) / LibreOffice Community Build ID: cdeefe45c17511d326101eed8008ac4092f278a9 CPU threads: 2; OS: Mac OS X 13.2.1; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Not in 7.3.3: Version: 7.3.3.2 / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 2; OS: Mac OS X 10.16; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -> regression -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158913] Error: attempt to increment a singular iterator.
https://bugs.documentfoundation.org/show_bug.cgi?id=158913 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords|bibisected | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||158913 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158913 [Bug 158913] Error: attempt to increment a singular iterator. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158913] Error: attempt to increment a singular iterator.
https://bugs.documentfoundation.org/show_bug.cgi?id=158913
Stéphane Guillou (stragu) changed:
What|Removed |Added
Regression By||Armin Le Grand
Ever confirmed|0 |1
CC||stephane.guillou@libreoffic
||e.org
Keywords||bibisected, bisected,
||regression
Status|UNCONFIRMED |NEW
Blocks||133092
--- Comment #2 from Stéphane Guillou (stragu)
---
Struggles but manages to convert with debug build from before the bisected
commit:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fdc87dd56548622e13353b4cf9864232ee0110fb
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Reproduced with recent debug build:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 29097009b1f8c0dcb050367d3f2acfcaf2074a56
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
In console:
/opt/rh/gcc-toolset-12/root/usr/include/c++/12/debug/safe_iterator.h:332:
In function:
gnu_debug::_Safe_iterator<_Iterator, _Sequence, _Category>&
gnu_debug::_Safe_iterator<_Iterator, _Sequence, _Category>::operator++()
[with _Iterator = std::
_Deque_iterator,
const rtl::Reference&, const
rtl::Reference*>; _Sequence
= std::
debug::deque
>; _Category = std::forward_iterator_tag]
Error: attempt to increment a singular iterator.
Objects involved in the operation:
iterator "this" @ 0x7ffe594ee120 {
type =
std::_Deque_iterator,
rtl::Reference const&,
rtl::Reference const*> (constant
iterator);
state = singular;
}
Unspecified Application Error
No repro in non-debug build:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 40617d867346956588ac023511f31210107217f4
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 77915] FILEOPEN [vsdx] shape color not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=77915 --- Comment #12 from Andras Timar --- I hacked on this bug. https://gerrit.libreoffice.org/c/libvisio/+/161397 https://gerrit.libreoffice.org/c/core/+/161396 (until fixed libvisio is released) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158886] Drag-and-drop selection of text with the mouse no longer shows highlight, or leaves a trail of highlight and cursors (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=158886 --- Comment #2 from Stéphane Guillou (stragu) --- Created attachment 191619 --> https://bugs.documentfoundation.org/attachment.cgi?id=191619=edit screenshot of lack of highlight, trail in its place Note that the text is indeed highlighted, as pressing Backspace removes it. It's the visual feedback that's badly broken. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112182] [META] Selection of text, cells and objects
https://bugs.documentfoundation.org/show_bug.cgi?id=112182 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||158886 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158886 [Bug 158886] Drag-and-drop selection of text with the mouse no longer shows highlight, or leaves a trail of highlight and cursors (macOS) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||158886 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158886 [Bug 158886] Drag-and-drop selection of text with the mouse no longer shows highlight, or leaves a trail of highlight and cursors (macOS) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158886] Drag-and-drop selection of text with the mouse no longer shows highlight, or leaves a trail of highlight and cursors (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=158886 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||112182, 42082 Summary|Selecting text with the |Drag-and-drop selection of |mouse no longer highlights |text with the mouse no |text. |longer shows highlight, or ||leaves a trail of highlight ||and cursors (macOS) Status|UNCONFIRMED |NEW CC||stephane.guillou@libreoffic ||e.org Ever confirmed|0 |1 --- Comment #1 from Stéphane Guillou (stragu) --- Reproduced: Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 2; OS: Mac OS X 13.2.1; UI render: Skia/Raster; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Same with "use Skia for all rendering" turned off (i.e. with "UI render: default"). Even after releasing the mouse button, the broken trail of small highlight chunks and cursors continues. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=42082 [Bug 42082] [META] Make LibreOffice shine and glow on macOS https://bugs.documentfoundation.org/show_bug.cgi?id=112182 [Bug 112182] [META] Selection of text, cells and objects -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155212] Writer is very slow when opening a file that includes embedded fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=155212 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8915 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158915] Very slow file-opening if embedded font being enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=158915 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||5212 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158915] New: Very slow file-opening if embedded font being enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=158915 Bug ID: 158915 Summary: Very slow file-opening if embedded font being enabled Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Very slow file-opening if embedded font being enabled Steps to Reproduce: 1. Open https://www.uni-bielefeld.de/verwaltung/dezernat-p-o/dokumente/hk-lehrbeauftragte/Arbeitszeitkonto_MiLoG.ods 2. Wait a minute before file opens Actual Results: 60 seconds opening time Expected Results: 5 seconds Reproducible: Always User Profile Reset: No Additional Info: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0cd74b5be297f638d455b9b267462192f2e6620c CPU threads: 8; OS: macOS 13.6.3; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded Unsure if this is mac specific -- You are receiving this mail because: You are the assignee for the bug.
[Bug 114363] TOC: Index update causes entries to duplicate if ToC created from Outline and Additional heading styles (in a specific document)
https://bugs.documentfoundation.org/show_bug.cgi?id=114363 --- Comment #31 from ironr...@protonmail.com --- [Runnning v7.6.4.1 (X86_64) on Fedora 39 Cinnamon] I can confirm that this issue still exists. NOTE: In my case, I had several DOCX with existing indexes which I have brought over (moving from Windows to Linux) and opened in LibreWriter. Upon right-clicking the index and selecting "Update Index" it duplicated every entry as all of my index entries are Header 1. Given the earlier descriptions on this bug I doubt the fact these are imported contribute to the issue but wanted it to be known. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158908] Bug: Error of window when editing a page break
https://bugs.documentfoundation.org/show_bug.cgi?id=158908 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Stéphane Guillou (stragu) --- Can you please share the full version information from Help > About LibreOffice? There is a button to copy it. If you are actually using version 5.4, please update to 7.6 and see if the issue still exists: https://www.libreoffice.org/download/download-libreoffice/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158891] VIEWING: make cell cursor more accessible to colourblind users
https://bugs.documentfoundation.org/show_bug.cgi?id=158891 Stéphane Guillou (stragu) changed: What|Removed |Added URL|https://doramasmp4.dev/ | Whiteboard|nhi hai | Ever confirmed|1 |0 Status|NEW |UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158893] [RFE] add "related bugs" to bug submission template
https://bugs.documentfoundation.org/show_bug.cgi?id=158893 --- Comment #3 from Stéphane Guillou (stragu) --- Ah, sorry, should have been clearer: the "related bugs" field you are after is called "see also". A description of the field: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/See_Also "Blocks" and "Depends on" also allow you to link to other reports, if one bug depends on the other getting fixed. (But in practice, they are mostly used for categorising with meta bugs.) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156797] A open polyline with start point = end point is saved as polygon instead of polyline
https://bugs.documentfoundation.org/show_bug.cgi?id=156797 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords|bibisected, bisected|bibisectRequest --- Comment #4 from Stéphane Guillou (stragu) --- (In reply to raal from comment #3) > 404 Not Found - Stephane, is it correct guid? It's the build commit, so the automatic linking wouldn't lead anywhere. Setting back to "bibisectRequest" for someone to bibisect in 4.2 before beta1. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 149284] LO Base freeze when using a form with macro to enter MySQL data
https://bugs.documentfoundation.org/show_bug.cgi?id=149284 --- Comment #10 from Alex Thurgood --- @J-Paul : the error message points to a gdk issue, and my own searching with the error message leads to a suggestion that the problem of freezing is linked to the use of Wayland as the desktop UI default provided by Ubuntu. I have encountered many such UI freezes with Wayland unfortunately, not just with LibreOffice, some requiring force kill of the application. One way to test this is to start an Xorg session instead of Wayland when you open a desktop session from the user login screen. If the problem still persists in LibreOffice when using a Xorg session, then the problem is 'likely with the Gnome core snap package used by Ubuntu. In any of these eventualities, the problem would not lie with LibreOffice, this would therefore not be our bug. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 32700] UI: Make Track Changes Color "by author" adjustable
https://bugs.documentfoundation.org/show_bug.cgi?id=32700 --- Comment #20 from Ron --- 13 years? Maybe I'm missing something here, but if there are a limited set of pallets for authors, why not allow a drop-down selection from author1 set, author2 set, authorN set? At least this would permit someone to associate a different, and more visually palatable, changes colour set with their author account. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158826] FILEOPEN RTF Floating table with image creates unexpected page break
https://bugs.documentfoundation.org/show_bug.cgi?id=158826 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/qa writerfilter/source
sw/qa/extras/rtfexport/data/tdf158826_extraCR.rtf | 23 ++
sw/qa/extras/rtfexport/rtfexport8.cxx | 11 ++
writerfilter/source/rtftok/rtfdispatchflag.cxx|4 ++-
3 files changed, 37 insertions(+), 1 deletion(-)
New commits:
commit 4399bccc5ee5a3fa69a8818e7ae265c144d33d64
Author: Justin Luth
AuthorDate: Wed Dec 27 18:58:33 2023 -0500
Commit: Justin Luth
CommitDate: Thu Dec 28 22:51:13 2023 +0100
tdf#158826 rtfimport: ignore page break before document starts
This avoids a 24.2 exposed bug from my
commit 016f779ee6c7f601be3ae19dc57497e63a5bf817
RTF import simply cannot be relied upon to create paragraphs
where they need to be. A side effect of fixing frames
is that spurious paragraphs can be created,
and if a frame starts the document, then an otherwise
ignored page break can be attached to the second paragraph
and thus become exposed.
This seems pretty much like the RTF implementation of
what was done for DOC and DOCX for tdf#118711.
At least it is related.
make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158826_extraCR
The following unit tests trigger this code (with no visible change)
abi10076.odt tdf121623.rtf tdf129513.rtf tdf131963.docx
Change-Id: I21afa826b6f6fbb735591603a0620b8b47de517e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161374
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/rtfexport/data/tdf158826_extraCR.rtf
b/sw/qa/extras/rtfexport/data/tdf158826_extraCR.rtf
new file mode 100644
index ..5461327da3ca
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/tdf158826_extraCR.rtf
@@ -0,0 +1,23 @@
+{
tf1
+\landscape\paperh5953\paperw8391\margl720\margr720\margt432\margb1728\gutter0\ltrsect
+
+
+\pagebb
+\intbl
+\pvpg\phpg
+
+\posx720\posy432
+\dxfrtext187\dfrmtxtx187\dfrmtxty0
+\wraparoundspalphaspnum
+ aautodjustright
+
in0\lin0bsnoovrlp1\pararsid5332093\yts39
+
+
+\shp
+
+
+a +++
+}
diff --git a/sw/qa/extras/rtfexport/rtfexport8.cxx
b/sw/qa/extras/rtfexport/rtfexport8.cxx
index 3023e51dcb21..9848d0573db8 100644
--- a/sw/qa/extras/rtfexport/rtfexport8.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport8.cxx
@@ -86,6 +86,17 @@ DECLARE_RTFEXPORT_TEST(testTdf158586_lostFrame,
"tdf158586_lostFrame.rtf")
// CPPUNIT_ASSERT_EQUAL(2, getPages());
}
+DECLARE_RTFEXPORT_TEST(testTdf158826_extraCR, "tdf158826_extraCR.rtf")
+{
+// Note: this is a hand-minimized sample, and very likely doesn't follow
RTF { } rules...
+
+// The page break defined before the document content should not cause a
page break
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+
+// There is a two-column floating table [that SHOULD be
getParagraphOrTable(1)]
+uno::Reference xTable(getParagraphOrTable(2),
uno::UNO_QUERY_THROW);
+}
+
} // end of anonymous namespace
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/rtftok/rtfdispatchflag.cxx
b/writerfilter/source/rtftok/rtfdispatchflag.cxx
index 72c777aab1fb..753f1c3fbba9 100644
--- a/writerfilter/source/rtftok/rtfdispatchflag.cxx
+++ b/writerfilter/source/rtftok/rtfdispatchflag.cxx
@@ -520,7 +520,9 @@ RTFError RTFDocumentImpl::dispatchFlag(RTFKeyword nKeyword)
}
break;
case RTFKeyword::PAGEBB:
-nParam = NS_ooxml::LN_CT_PPrBase_pageBreakBefore;
+// ignore a page break that is defined before the document content
has even started
+if (!m_bFirstRun)
+nParam = NS_ooxml::LN_CT_PPrBase_pageBreakBefore;
break;
default:
break;
[Bug 158914] New: Calc leaks RAM in response to any action
https://bugs.documentfoundation.org/show_bug.cgi?id=158914 Bug ID: 158914 Summary: Calc leaks RAM in response to any action Product: LibreOffice Version: 7.6.4.1 release Hardware: ARM OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: al...@gtf.org I'm currently using the latest 7.6.4.1 Apple Silicon release of LibreOffice Calc on a Mac M1 Mini 16GB. It's kept up to date and currently running MacOS Sonoma 14.2.1. That said, I've been experiencing what appears to be the same issue for quite some time before realizing what was happening. In short, Calc leaks vast amounts of memory during normal use until finally at ~9GB or so, it is running too slowly to use. At that point, I can save my work, close (which takes minutes) or Force Kill Calc, and then start over. No data is lost, but it's bizarre. Initially I thought this was related to a particular document in which I was often working. After more testing, it turns out that any document will behave the same way. Even a fresh, empty Calc document on a freshly-started copy of LO will exhibit the issue. I can reproduce as follows: 1. Start LibreOffice 2. Under "Create:" on the left-hand menu, select "Calc Spreadsheet" At this point, Activity Monitor shows 362.0 MB "Memory", 296.3 MB "Real Mem", 108.0 MB "Private Mem", and 77.7MB "Shared Mem". The numbers are stable as the application sits, open on a blank sheet "Untitled 1". 3. Click on random cells in the empty document. Not moving around via scroll bars, not typing anything, just selecting one cell and then another and another. Not groups or anything, just moving the pointer and left-clicking. I've now clicked about 50 times and see the following stabilized memory numbers in Activity Monitor: 1005.0 MB "Memory", 956.0 MB "Real Mem", 750.3 MB "Private Mem", 77.7 MB "Shared Mem". Once again these numbers are stable now that I'm no longer clicking. Once I start clicking again, the memory footprint resumes growing. In the case of doing real work in a document, Calc will eventually become very slow and ultimately unusable, after which the cycle above begins again. A few things worth mentioning: 1. Writer does not exhibit any strange behavior. 2. No other application on the Mac (and I use it constantly) behaves strangely. 3. I do have Homebrew installed w/ various dev tools and whatnot. 4. I'm completely aware that this sounds crazy, and that it's surely tied to something about my environment, but I haven't been able to identify it. Am hoping perhaps there are diagnostics and logging that I can run to provide you with additional information. It does seem to be a bug in Calc though, despite being triggered by some unique(?) conditions. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155494] Cursor goes beyond margins when typing spaces at the end of a line
https://bugs.documentfoundation.org/show_bug.cgi?id=155494 --- Comment #57 from V Stuart Foote --- (In reply to Mike Kaganski from comment #55) > (In reply to V Stuart Foote from comment #54) > > However, I still would like to see us implement a convenient trim function > > as enhancement. Perhaps follow the MS "on center" truncation as noted > > comment 18 > > Implemented in bug 104668; see "Word-compatible trailing blanks" last > element under Options->Writer->Compatibility. Hmm, enabled that Writer Compatibility option (undocumented bug 131235) but that doesn't seem to provide this behavior: MS Word user forums suggest: 'Select' the full line of text (including all over the edge spaces), and 'Center' it (with +E shorcut) to delete all extra spaces, then still selected 'Align it' where preferred. Unfortunately, in LO Writer the selection and centering action does not remove the extra spaces in similar fashion. Looking at the commit it only looked to affect the space characters of text set RTL. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155494] Cursor goes beyond margins when typing spaces at the end of a line
https://bugs.documentfoundation.org/show_bug.cgi?id=155494 --- Comment #56 from William Friedman --- > The discussion got too long. What is the current status of the discussion? This bug report involved two different elements which got conflated. My main issue was the cursor display issue, which results in actually buggy behavior (see my comment 22 and Laszlo's confirmation in comment 46) like disappearing cursors and invalid selection areas, and which IMO should be reverted. The question of how the spaces are actually treated is a secondary issue to this bug. -- You are receiving this mail because: You are the assignee for the bug.
