Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString
On 19/04/11 22:09, Caolán McNamara wrote: You*did* run the smoketest didn't you. I'm sure you did. you *are* joking right? such confidence in me doing the right thing is completely misplaced, I am ashamed I didn't run it :-( I did some touch testing with basic but I have to admit running the smoketest just didn't even occur to me. Ok, tried it now, and it works :-) ( phew ) Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString
On Wed, 20 Apr 2011 09:22:46 +0100 Noel Power nopo...@novell.com wrote: On 19/04/11 22:09, Caolán McNamara wrote: You*did* run the smoketest didn't you. I'm sure you did. you *are* joking right? such confidence in me doing the right thing is completely misplaced, I am ashamed I didn't run it :-( I cant help a bit of sarcastic grinning while watching this exchange from the sidelines. ;) Best Regards, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString
On Tue, 2011-03-22 at 17:22 +, Caolán McNamara wrote: On Tue, 2011-03-22 at 16:39 +, Caolán McNamara wrote: among others Yeah, the catch is that there's a hierarchy of virtual methods in there, we can't change *some* of the signatures on impls of a specific virtual method we need to change all or none. I'll have to revert this for a bit because it breaks basic, e.g. make check fails due to various oddities from this. We can still back in the bits that don't partially change virtual method sigs afterwards. sigh I am sorry it seems I am reverting your revert ( I didn't see your mail at all, only saw it now from searching the archives because I didn't see my own mail due some mail client problems :-( ) I committed this today ( hopefully with the virtually function related functions hunks removed ) at least I didn't get any errors. Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString
On Tue, 2011-04-19 at 20:31 +0100, Noel Power wrote: sigh I am sorry it seems I am reverting your revert ( I didn't see your mail at all, only saw it now from searching the archives because I didn't see my own mail due some mail client problems :-( ) I committed this today ( hopefully with the virtually function related functions hunks removed ) at least I didn't get any errors. My revert was back in March, I only remembered to mention today that the new compiler warnings would catch this. If the smoketest passes then the changes are good because the smoketest (being in basic) catches the error. You *did* run the smoketest didn't you. I'm sure you did. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString
On Tue, Mar 15, 2011 at 01:10:58PM +0100, Xisco Faulí wrote: Hello, It's the first time I do it so I searched for previous commits in order to get a referent. i couldn't find any example for String.AssignAscii so I replace it with OUStringBuffer.appendAscii. Yeah, that is good. I only added RTL_CONSTASCII_STRINGPARAM around string literals. I also replaced occurrences of aStr.equals(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(foo))) by aStr.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(foo)) (similarly for equalsIgnoreAsciiCase and equalsIgnoreAsciiCaseAsciiL) and aStr.getLen() in conditions by !aStr.isEmpty(). D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString
On Tue, 2011-03-22 at 08:11 +0100, David Tardon wrote: On Tue, Mar 15, 2011 at 01:10:58PM +0100, Xisco Faulí wrote: Hello, It's the first time I do it so I searched for previous commits in order to get a referent. i couldn't find any example for String.AssignAscii so I replace it with OUStringBuffer.appendAscii. Yeah, that is good. You might have missed my mail on the other variant of this patch, i.e. there's a little bug in the new Dbg_SbxDataType2String impl, the old one had... String aRet( RTL_CONSTASCII_USTRINGPARAM(Unknown Sbx-Type!) ); ... aRet = something ... return aRet; while the new one has... ::rtl::OUStringBuffer aRet; aRet.appendAscii(Unknown Sbx-Type!); ... aRet.appendAscii(something); i.e. now its Unknown Sbx-Type!something instead of something. so that one needs fixing. among others C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString
On Tue, 2011-03-22 at 16:39 +, Caolán McNamara wrote: among others Yeah, the catch is that there's a hierarchy of virtual methods in there, we can't change *some* of the signatures on impls of a specific virtual method we need to change all or none. I'll have to revert this for a bit because it breaks basic, e.g. make check fails due to various oddities from this. We can still back in the bits that don't partially change virtual method sigs afterwards. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
