[Mahara-contributors] [Bug 1579145] Re: Ability to include live link on image description

[Son Nguyen]

** Changed in: mahara
   Status: Confirmed => In Progress

** Changed in: mahara
 Assignee: (unassigned) => Son Nguyen (ngson2000)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1579145

Title:
  Ability to include live link on image description

Status in Mahara:
  In Progress

Bug description:
  It would be very helpful to have the ability to include a live link in
  the image description to allow users to provide useful citations.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1579145/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1632717] Re: Bugs after updating Mahara

[Lilian HUGUES]

Hi Robert,
Many thanks for your diagnose.
It is exactly the issue, it happens when the grouphomepage for the group does 
not exist. If we manually create one in the base, it fixes the issue.
Actually, the issue is when a user creates a new group.
It show the message : 
"
Medzone.fr: Site unavailable
Something in the way you're interacting with Medzone.fr is causing an error.
Details if any, follow:

User with id "0" is not known"

The group is however created but without any grouphomepage. Moreover, if
we want to reenter in the parameters of the groupe, it drives us to a
error 500.

Do you have any idea to fix it ?

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1632717

Title:
  Bugs after updating Mahara

Status in Mahara:
  Incomplete

Bug description:
  Hello,

  After the update to the latest version of Mahara (16.04) I have
  problems with the display pages of the groups.

  Here is an example :

  [WAR] 1b (lib/group.php:2338) Trying to get property of non-object
  Call stack (most recent first):

  log_message(string(size 36), integer, true, true, string(size 53), 
integer) at /mypath/maha/lib/errors.php:513
  error(integer, string(size 36), string(size 53), integer, array(size 2)) 
at /mypath/maha/lib/group.php:2338
  group_get_homepage_view(string(size 2)) at /mypath/maha/lib/view.php:5734
  View->display_author() at /mypath/maha/view/view.php:362

  [WAR] 1b (lib/errors.php:820) Failed to get a recordset: mysqli error: [1452: 
Cannot add or update a child row: a foreign key constraint fails 
("mybdd"."view", CONSTRAINT "view_ibfk_7" FOREIGN KEY ("type") REFERENCES 
"view_type" ("type"))] in EXECUTE("INSERT INTO "view" ("ctime", "mtime", 
"atime", "copynewuser", "anonymise") VALUES ('2016-10-12 15:32:22', '2016-10-12 
15:32:22', '2016-10-12 15:32:22', 0, 0)")
  Command was: INSERT INTO "view" ("ctime", "mtime", "atime", "copynewuser", 
"anonymise") VALUES (?, ?, ?, ?, ?) and values was 
(ctime:2016-10-1215:32:22,mtime:2016-10-1215:32:22,atime:2016-10-1215:32:22,copynewuser:0,anonymise:0)
  Call stack (most recent first):

  log_message(string(size 618), integer, true, true) at 
/mypath/maha/lib/errors.php:95
  log_warn(string(size 618)) at /mypath/maha/lib/errors.php:820
  SQLException->__construct(string(size 618)) at 
/mypath/maha/lib/dml.php:1088
  insert_record(string(size 4), object(stdClass), string(size 2), true) at 
/mypath/maha/lib/view.php:728
  View->commit() at /mypath/maha/lib/view.php:702
  View->__destruct() at /mypath/maha/view/view.php:362
  View->display_author() at /mypath/maha/view/view.php:362

  [WAR] 1b (lib/dml.php:1088) Failed to get a recordset: mysqli error: [1452: 
Cannot add or update a child row: a foreign key constraint fails 
("mybdd"."view", CONSTRAINT "view_ibfk_7" FOREIGN KEY ("type") REFERENCES 
"view_type" ("type"))] in EXECUTE("INSERT INTO "view" ("ctime", "mtime", 
"atime", "copynewuser", "anonymise") VALUES ('2016-10-12 15:32:22', '2016-10-12 
15:32:22', '2016-10-12 15:32:22', 0, 0)")
  Command was: INSERT INTO "view" ("ctime", "mtime", "atime", "copynewuser", 
"anonymise") VALUES (?, ?, ?, ?, ?) and values was 
(ctime:2016-10-1215:32:22,mtime:2016-10-1215:32:22,atime:2016-10-1215:32:22,copynewuser:0,anonymise:0)
  Call stack (most recent first):

  insert_record(string(size 4), object(stdClass), string(size 2), true) at 
/mypath/maha/lib/view.php:728
  View->commit() at /mypath/maha/lib/view.php:702
  View->__destruct() at /mypath/maha/view/view.php:362
  View->display_author() at /mypath/maha/view/view.php:362

  Untitled
  Mywebsite Mahara : Site unavailable
  A nonrecoverable error occurred. This probably means you have encountered a 
bug in the system

  Thank you for your help.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1632717/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1634591] [NEW] Show last updated date and time when seeing a portfolio page

[Son Nguyen]

Public bug reported:

Version: master(17.04), 16.10, 16.04

It would be good to see when a portfolio page has been updated

The last updated date and time will be shown next to the page visits
when seeing a page.

** Affects: mahara
 Importance: Wishlist
 Assignee: Son Nguyen (ngson2000)
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1634591

Title:
  Show last updated date and time when seeing a portfolio page

Status in Mahara:
  In Progress

Bug description:
  Version: master(17.04), 16.10, 16.04

  It would be good to see when a portfolio page has been updated

  The last updated date and time will be shown next to the page visits
  when seeing a page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1634591/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1634591] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/7152

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1634591

Title:
  Show last updated date and time when seeing a portfolio page

Status in Mahara:
  In Progress

Bug description:
  Version: master(17.04), 16.10, 16.04

  It would be good to see when a portfolio page has been updated

  The last updated date and time will be shown next to the page visits
  when seeing a page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1634591/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1579145] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/7151

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1579145

Title:
  Ability to include live link on image description

Status in Mahara:
  In Progress

Bug description:
  It would be very helpful to have the ability to include a live link in
  the image description to allow users to provide useful citations.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1579145/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1634297] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7141
Committed: 
https://git.mahara.org/mahara/mahara/commit/5d4e6f7510f5b9f93851ca9ff27d8089c7e3ee8c
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 5d4e6f7510f5b9f93851ca9ff27d8089c7e3ee8c
Author: Robert Lyon 
Date:   Tue Oct 18 11:42:33 2016 +1300

Bug 1634297: Use table prefix for sql calls

In rest/locallib.php and lib/mahara.php

behatnotneeded

Change-Id: I5120656913d39b69d2f8c9492b485a12e7c58f90
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1634297

Title:
  table prefix syntax needed for sql query in rest/locallib.php

Status in Mahara:
  Fix Committed

Bug description:
  The delete records sql call on line 86 of webservice/rest/locallib.php
  can be changed to use delete_records() function so it can handle table
  prefixes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1634297/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1633213] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7158
Committed: 
https://git.mahara.org/mahara/mahara/commit/2a529380f8a1009a71270146784d5e395b1a7bd5
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit 2a529380f8a1009a71270146784d5e395b1a7bd5
Author: Robert Lyon 
Date:   Tue Oct 18 09:17:13 2016 +1300

Bug 1633213: Removing check for local file

An earlier rendition of the way we added new matrix files was to place
them into the matrices dir and then upload them by name only.

But now we use the file upload field and so don't need this check
anymore

behatnotneeded

Change-Id: Ia37ca05370cdc53dd7836b572320c14e4e3bfcfc
Signed-off-by: Robert Lyon 
(cherry picked from commit e62618110fd455d176621eee694ecef1d3fd7fb6)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1633213

Title:
   Uploading new/existing SmartEvidence framework doesn't work

Status in Mahara:
  Fix Committed

Bug description:
  When I try to upload new SmartEvidence framework (in administration
  section) it does't work. The matrix file is a valid JSON file. I have
  also deleted existing SmartEvidence framework and tried to re-install
  it. The result is the same.

  This is probably due to OS, since I am working / testing that on
  Windows.

  The debug message was:

  [WAR] 58 (module\framework\lib.php:72)
  
file_get_contents(D:\xampp\htdocs\mahara1610\module/framework/matrices/D:\xampp\tmp\php91F8.tmp):
  failed to open stream: Invalid argument

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1633213/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1633213] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7158

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1633213

Title:
   Uploading new/existing SmartEvidence framework doesn't work

Status in Mahara:
  Fix Committed

Bug description:
  When I try to upload new SmartEvidence framework (in administration
  section) it does't work. The matrix file is a valid JSON file. I have
  also deleted existing SmartEvidence framework and tried to re-install
  it. The result is the same.

  This is probably due to OS, since I am working / testing that on
  Windows.

  The debug message was:

  [WAR] 58 (module\framework\lib.php:72)
  
file_get_contents(D:\xampp\htdocs\mahara1610\module/framework/matrices/D:\xampp\tmp\php91F8.tmp):
  failed to open stream: Invalid argument

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1633213/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1633213] Re: Uploading new/existing SmartEvidence framework doesn't work

[Robert Lyon]

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1633213

Title:
   Uploading new/existing SmartEvidence framework doesn't work

Status in Mahara:
  Fix Committed

Bug description:
  When I try to upload new SmartEvidence framework (in administration
  section) it does't work. The matrix file is a valid JSON file. I have
  also deleted existing SmartEvidence framework and tried to re-install
  it. The result is the same.

  This is probably due to OS, since I am working / testing that on
  Windows.

  The debug message was:

  [WAR] 58 (module\framework\lib.php:72)
  
file_get_contents(D:\xampp\htdocs\mahara1610\module/framework/matrices/D:\xampp\tmp\php91F8.tmp):
  failed to open stream: Invalid argument

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1633213/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1634297] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7161

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1634297

Title:
  table prefix syntax needed for sql query in rest/locallib.php

Status in Mahara:
  Fix Committed

Bug description:
  The delete records sql call on line 86 of webservice/rest/locallib.php
  can be changed to use delete_records() function so it can handle table
  prefixes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1634297/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1629144] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7154

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629144

Title:
  Problems with copying a SmartEvidence collection with annotations

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  1. Set up a SmartEvidence collection.
  2. Put a couple of annotations on the page.
  3. Add a couple of feedbacks to the annotations.
  4. Copy the collection in the same user account.
  5. Open a page that has an annotation.

  I get the following error message multiple times:

  [WAR] 5f (artefact/annotation/lib.php:1294) Trying to get property of 
non-object
  Call stack (most recent first):

  log_message("Trying to get property of non-object", 8, true, true, 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Trying to get property of non-object", 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294, array(size 13)) 
at /home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1294
  
ArtefactTypeAnnotationfeedback::add_annotation_feedback_form(object(ArtefactTypeAnnotation),
 object(View), null, "1061", false, "0") at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1132
  
ArtefactTypeAnnotationfeedback::get_annotation_feedback_for_view(object(ArtefactTypeAnnotation),
 object(View), "1061", true, false) at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/blocktype/annotation/lib.php:134
  PluginBlocktypeAnnotation::render_instance(object(BlockInstance)) at 
Unknown:0
  call_user_func_array(array(size 2), array(size 1)) at 
/home/kristina/code/1610stable/htdocs/lib/mahara.php:1730
  call_static_method("PluginBlocktypeAnnotation", "render_instance", 
object(BlockInstance)) at 
/home/kristina/code/1610stable/htdocs/blocktype/lib.php:1007
  BlockInstance->render_viewing(false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:2037
  View->build_column(1, 1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1991
  View->build_columns(1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1976
  View->build_rows() at 
/home/kristina/code/1610stable/htdocs/view/view.php:281

  

  If possible, the annotations should be linked to the map in the copied
  collection. Currently, the annotations display on the page, but their
  status doesn't shop up on the smartEvidence overview page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629144/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1629144] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7153

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629144

Title:
  Problems with copying a SmartEvidence collection with annotations

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  1. Set up a SmartEvidence collection.
  2. Put a couple of annotations on the page.
  3. Add a couple of feedbacks to the annotations.
  4. Copy the collection in the same user account.
  5. Open a page that has an annotation.

  I get the following error message multiple times:

  [WAR] 5f (artefact/annotation/lib.php:1294) Trying to get property of 
non-object
  Call stack (most recent first):

  log_message("Trying to get property of non-object", 8, true, true, 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Trying to get property of non-object", 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294, array(size 13)) 
at /home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1294
  
ArtefactTypeAnnotationfeedback::add_annotation_feedback_form(object(ArtefactTypeAnnotation),
 object(View), null, "1061", false, "0") at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1132
  
ArtefactTypeAnnotationfeedback::get_annotation_feedback_for_view(object(ArtefactTypeAnnotation),
 object(View), "1061", true, false) at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/blocktype/annotation/lib.php:134
  PluginBlocktypeAnnotation::render_instance(object(BlockInstance)) at 
Unknown:0
  call_user_func_array(array(size 2), array(size 1)) at 
/home/kristina/code/1610stable/htdocs/lib/mahara.php:1730
  call_static_method("PluginBlocktypeAnnotation", "render_instance", 
object(BlockInstance)) at 
/home/kristina/code/1610stable/htdocs/blocktype/lib.php:1007
  BlockInstance->render_viewing(false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:2037
  View->build_column(1, 1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1991
  View->build_columns(1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1976
  View->build_rows() at 
/home/kristina/code/1610stable/htdocs/view/view.php:281

  

  If possible, the annotations should be linked to the map in the copied
  collection. Currently, the annotations display on the page, but their
  status doesn't shop up on the smartEvidence overview page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629144/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1629144] Re: Problems with copying a SmartEvidence collection with annotations

[Robert Lyon]

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629144

Title:
  Problems with copying a SmartEvidence collection with annotations

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  1. Set up a SmartEvidence collection.
  2. Put a couple of annotations on the page.
  3. Add a couple of feedbacks to the annotations.
  4. Copy the collection in the same user account.
  5. Open a page that has an annotation.

  I get the following error message multiple times:

  [WAR] 5f (artefact/annotation/lib.php:1294) Trying to get property of 
non-object
  Call stack (most recent first):

  log_message("Trying to get property of non-object", 8, true, true, 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Trying to get property of non-object", 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294, array(size 13)) 
at /home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1294
  
ArtefactTypeAnnotationfeedback::add_annotation_feedback_form(object(ArtefactTypeAnnotation),
 object(View), null, "1061", false, "0") at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1132
  
ArtefactTypeAnnotationfeedback::get_annotation_feedback_for_view(object(ArtefactTypeAnnotation),
 object(View), "1061", true, false) at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/blocktype/annotation/lib.php:134
  PluginBlocktypeAnnotation::render_instance(object(BlockInstance)) at 
Unknown:0
  call_user_func_array(array(size 2), array(size 1)) at 
/home/kristina/code/1610stable/htdocs/lib/mahara.php:1730
  call_static_method("PluginBlocktypeAnnotation", "render_instance", 
object(BlockInstance)) at 
/home/kristina/code/1610stable/htdocs/blocktype/lib.php:1007
  BlockInstance->render_viewing(false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:2037
  View->build_column(1, 1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1991
  View->build_columns(1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1976
  View->build_rows() at 
/home/kristina/code/1610stable/htdocs/view/view.php:281

  

  If possible, the annotations should be linked to the map in the copied
  collection. Currently, the annotations display on the page, but their
  status doesn't shop up on the smartEvidence overview page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629144/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1629147] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7155

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629147

Title:
  Error message about non-existent framework url

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  This might be related to bug #1629144

  When I want to delete a copied page from a collection that has
  SmartEvidence, I get the following error message on the page deletion
  page:

  [WAR] 64 (lib/collection.php:950) Undefined property: 
Collection::$frameworkurl
  Call stack (most recent first):

  log_message("Undefined property: Collection::$frameworkurl", 8, true, 
true, "/home/kristina/code/1610stable/htdocs/lib/collecti...", 950) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Undefined property: Collection::$frameworkurl", 
"/home/kristina/code/1610stable/htdocs/lib/collecti...", 950, array(size 6)) at 
/home/kristina/code/1610stable/htdocs/lib/collection.php:950
  Collection->get_url() at 
/home/kristina/code/1610stable/htdocs/view/delete.php:30

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629147/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1629144] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7153
Committed: 
https://git.mahara.org/mahara/mahara/commit/1f5eb705557c6d8217be8e927464efc4a53baca3
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit 1f5eb705557c6d8217be8e927464efc4a53baca3
Author: Robert Lyon 
Date:   Mon Oct 3 11:01:42 2016 +1300

Bug 1629144: Allow self copying of an annotation to duplicate artefact

Because unlike image/note blocks where we want the blocks to reference
the same underlying artefact here we want to create a new artefact
otherwise updating the block on one page will update the artefact for
all the related blocks.

To do this we need to add a new copytype called 'fullinclself' that
means make a full copy of blockinstance including when doing a self copy

Also we need to allow for the self copying to ignore the
annotationfeedback artefact type as we dont' want to copt the feedback.

behatnotneeded

Change-Id: Icc9e375e3180ff3f25d84ba9695926d5b24bb17d
Signed-off-by: Robert Lyon 
(cherry picked from commit a9360f18ba59ba48358add888cf83a036556f076)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629144

Title:
  Problems with copying a SmartEvidence collection with annotations

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  1. Set up a SmartEvidence collection.
  2. Put a couple of annotations on the page.
  3. Add a couple of feedbacks to the annotations.
  4. Copy the collection in the same user account.
  5. Open a page that has an annotation.

  I get the following error message multiple times:

  [WAR] 5f (artefact/annotation/lib.php:1294) Trying to get property of 
non-object
  Call stack (most recent first):

  log_message("Trying to get property of non-object", 8, true, true, 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Trying to get property of non-object", 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294, array(size 13)) 
at /home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1294
  
ArtefactTypeAnnotationfeedback::add_annotation_feedback_form(object(ArtefactTypeAnnotation),
 object(View), null, "1061", false, "0") at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1132
  
ArtefactTypeAnnotationfeedback::get_annotation_feedback_for_view(object(ArtefactTypeAnnotation),
 object(View), "1061", true, false) at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/blocktype/annotation/lib.php:134
  PluginBlocktypeAnnotation::render_instance(object(BlockInstance)) at 
Unknown:0
  call_user_func_array(array(size 2), array(size 1)) at 
/home/kristina/code/1610stable/htdocs/lib/mahara.php:1730
  call_static_method("PluginBlocktypeAnnotation", "render_instance", 
object(BlockInstance)) at 
/home/kristina/code/1610stable/htdocs/blocktype/lib.php:1007
  BlockInstance->render_viewing(false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:2037
  View->build_column(1, 1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1991
  View->build_columns(1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1976
  View->build_rows() at 
/home/kristina/code/1610stable/htdocs/view/view.php:281

  

  If possible, the annotations should be linked to the map in the copied
  collection. Currently, the annotations display on the page, but their
  status doesn't shop up on the smartEvidence overview page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629144/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1625380] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7156
Committed: 
https://git.mahara.org/mahara/mahara/commit/a1924752aaafd90a35e1069a07c5d7b9006ee4ab
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit a1924752aaafd90a35e1069a07c5d7b9006ee4ab
Author: Robert Lyon 
Date:   Mon Sep 26 14:13:11 2016 +1300

Bug 1625380: Stopping an annotation being set to another standard

If the annotation has feedback and/or assessment set to something
other than 'begun'

behatnotneeded

Change-Id: I1a97e91c453628d1f79a09ef8ee588ac1829f163
Signed-off-by: Robert Lyon 
(cherry picked from commit 70a3b094cd1f836afa18ea4847817509951ae5cf)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625380

Title:
  Able to select a standard from Collection Edit page

Status in Mahara:
  Fix Committed

Bug description:
  Tested in Chrome, Firefox, Safari and IE Edge for php5

  Pre req: Confirm that standard is pre selected via SE map/matrix 
(Collection>matrix>annotation) 
   From standard drop down menu, pre selected is highlighted and not 
able to select a diff standard 

  
  Test step:
  From Page>Edit this page>Annotation (enter Annotation) 
  Standard drop down menu>select a standard (different from existing)
  Save

  To confirm that the change is accepted: Collection>matrix>Annotation


  You should not be able to update the standard once it had already been
  selected as the annotation wouldn't fit anymore. This is a bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1625380/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1634297] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7161
Committed: 
https://git.mahara.org/mahara/mahara/commit/ba0311f9f6baad7a9355f83a6a58e47afa3c4e4f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit ba0311f9f6baad7a9355f83a6a58e47afa3c4e4f
Author: Robert Lyon 
Date:   Tue Oct 18 11:42:33 2016 +1300

Bug 1634297: Use table prefix for sql calls

In rest/locallib.php and lib/mahara.php

behatnotneeded

Change-Id: I5120656913d39b69d2f8c9492b485a12e7c58f90
Signed-off-by: Robert Lyon 
(cherry picked from commit 5d4e6f7510f5b9f93851ca9ff27d8089c7e3ee8c)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1634297

Title:
  table prefix syntax needed for sql query in rest/locallib.php

Status in Mahara:
  Fix Committed

Bug description:
  The delete records sql call on line 86 of webservice/rest/locallib.php
  can be changed to use delete_records() function so it can handle table
  prefixes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1634297/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1568619] Re: Open Badge details aren't accessible with screenreader

[Robert Lyon]

** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

** No longer affects: mahara/17.04

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568619

Title:
  Open Badge details aren't accessible with screenreader

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  When you have an Open Badge in a page and you just use a screenreader
  and click on the Open Badge image, the modal with the information
  about the badge does not appear. I suspect the on.click Javascript is
  the culprit.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568619/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1568619] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7149
Committed: 
https://git.mahara.org/mahara/mahara/commit/0093c118735a469cee3979f858d800fd6f8224d1
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit 0093c118735a469cee3979f858d800fd6f8224d1
Author: Robert Lyon 
Date:   Tue Oct 4 16:38:55 2016 +1300

Bug 1568619: Allowing openbadge info modal to open via enter key

Also allow one to tab through the modal and close it and put the focus
back on the badge we used to open the modal

behatnotneeded

Change-Id: I45c428f7abfa6e20be3b1a6d0c6867ec6f62f199
Signed-off-by: Robert Lyon 
(cherry picked from commit e9f806db39fe050506700dbd33da3507c3602a58)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568619

Title:
  Open Badge details aren't accessible with screenreader

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  When you have an Open Badge in a page and you just use a screenreader
  and click on the Open Badge image, the modal with the information
  about the badge does not appear. I suspect the on.click Javascript is
  the culprit.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568619/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1630753] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7145
Committed: 
https://git.mahara.org/mahara/mahara/commit/a925c357eb660c105fd6ab667a9cecdfccff74e0
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit a925c357eb660c105fd6ab667a9cecdfccff74e0
Author: Robert Lyon 
Date:   Thu Oct 6 09:46:16 2016 +1300

Bug 1630753: Save the studentid and preferredname fields via webservices

When creating a user

behatnotneeded

Change-Id: I8e442cbda497cfc1cb39fd5395d7c07c7c148dd2
Signed-off-by: Robert Lyon 
(cherry picked from commit befa5bc854020926779bb0e3dc69336b9cfabb15)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1630753

Title:
  Webservices create user has problems with preferredname and studentid
  fields

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  This issue was fixed for 16.10+ but needs to be backported to earlier
  versions using webservices

  We need the studentid and preferredname parts of commit
  4bc12f6abbc832fbcd9766518796ae4a45351034

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1630753/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1630764] Re: Webservices update user has problems with preferredname and studentid fields

[Robert Lyon]

** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1630764

Title:
  Webservices update user has problems with preferredname and studentid
  fields

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is like bug 1630753 but this also needs to be fixed for 16.10+ as
  well

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1630764/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1631809] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7159

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1631809

Title:
  Allow image preview in modal - not working for file lists within
  modals

Status in Mahara:
  Fix Committed

Bug description:
  The patch for bug 1572356 only dealt with the files list on the
  Content -> files page.

  But what would be more useful is if the picker worked within other
  modal popups, like when picking an image to an image block or picking
  an image within the tinymce image picker.

  So I've added a patch to deal with this and also fixed the issue where
  profileicon images could not be chosen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1631809/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1630753] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7146
Committed: 
https://git.mahara.org/mahara/mahara/commit/bf5693e5a4122df12e9658154734989fdb65f70d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit bf5693e5a4122df12e9658154734989fdb65f70d
Author: Robert Lyon 
Date:   Thu Oct 6 09:46:16 2016 +1300

Bug 1630753: Save the studentid and preferredname fields via webservices

When creating a user

behatnotneeded

Change-Id: I8e442cbda497cfc1cb39fd5395d7c07c7c148dd2
Signed-off-by: Robert Lyon 
(cherry picked from commit befa5bc854020926779bb0e3dc69336b9cfabb15)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1630753

Title:
  Webservices create user has problems with preferredname and studentid
  fields

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  This issue was fixed for 16.10+ but needs to be backported to earlier
  versions using webservices

  We need the studentid and preferredname parts of commit
  4bc12f6abbc832fbcd9766518796ae4a45351034

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1630753/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1630753] Re: Webservices create user has problems with preferredname and studentid fields

[Robert Lyon]

** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1630753

Title:
  Webservices create user has problems with preferredname and studentid
  fields

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  This issue was fixed for 16.10+ but needs to be backported to earlier
  versions using webservices

  We need the studentid and preferredname parts of commit
  4bc12f6abbc832fbcd9766518796ae4a45351034

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1630753/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1629154] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7157

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629154

Title:
  Fatal error displayed when deleting the institution which has a logo

Status in Mahara:
  Fix Committed

Bug description:
  Version 16.10

  All possible browsers

  Steps to reproduce:

  1) Create an institution and make sure to attach a logo
  2) Now go back to institutions and delete it

  Expected result: Institution should be deleted
  Actual Result: A fatal error is displayed ( see attached)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629154/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1634297] Re: table prefix syntax needed for sql query in rest/locallib.php

[Robert Lyon]

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1634297

Title:
  table prefix syntax needed for sql query in rest/locallib.php

Status in Mahara:
  Fix Committed

Bug description:
  The delete records sql call on line 86 of webservice/rest/locallib.php
  can be changed to use delete_records() function so it can handle table
  prefixes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1634297/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1631809] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7159
Committed: 
https://git.mahara.org/mahara/mahara/commit/2933ccf89514b3ea163caa3f1b52817943fda8d5
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit 2933ccf89514b3ea163caa3f1b52817943fda8d5
Author: Robert Lyon 
Date:   Mon Oct 10 10:57:18 2016 +1300

Bug 1631809: Allow image preview modal use within other modals

Like adding image block modal or tinymce insert image modal

behatnotneeded

Change-Id: If608f87b852b8ee2e4d6c74bdf2a31124599eb03
Signed-off-by: Robert Lyon 
(cherry picked from commit 6601edd07bcd347a4e4c640cb07d73a775dde11e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1631809

Title:
  Allow image preview in modal - not working for file lists within
  modals

Status in Mahara:
  Fix Committed

Bug description:
  The patch for bug 1572356 only dealt with the files list on the
  Content -> files page.

  But what would be more useful is if the picker worked within other
  modal popups, like when picking an image to an image block or picking
  an image within the tinymce image picker.

  So I've added a patch to deal with this and also fixed the issue where
  profileicon images could not be chosen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1631809/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1630764] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7147
Committed: 
https://git.mahara.org/mahara/mahara/commit/bda64db581dbcbccbef4f49487a557283dadf964
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit bda64db581dbcbccbef4f49487a557283dadf964
Author: Robert Lyon 
Date:   Thu Oct 6 10:11:05 2016 +1300

Bug 1630764: fixing for update user via webservices

behatnotneeded

Change-Id: Id9ad96fd651423b1a8078ddc8cf7de87a857bf39
Signed-off-by: Robert Lyon 
(cherry picked from commit 01a34a7cb7224dfd3924cd6cd45f1693e23a078e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1630764

Title:
  Webservices update user has problems with preferredname and studentid
  fields

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is like bug 1630753 but this also needs to be fixed for 16.10+ as
  well

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1630764/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1631809] Re: Allow image preview in modal - not working for file lists within modals

[Robert Lyon]

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1631809

Title:
  Allow image preview in modal - not working for file lists within
  modals

Status in Mahara:
  Fix Committed

Bug description:
  The patch for bug 1572356 only dealt with the files list on the
  Content -> files page.

  But what would be more useful is if the picker worked within other
  modal popups, like when picking an image to an image block or picking
  an image within the tinymce image picker.

  So I've added a patch to deal with this and also fixed the issue where
  profileicon images could not be chosen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1631809/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1629154] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7157
Committed: 
https://git.mahara.org/mahara/mahara/commit/91029f40749f7fafb75092f01a903b84538bedd1
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit 91029f40749f7fafb75092f01a903b84538bedd1
Author: Robert Lyon 
Date:   Tue Oct 4 09:07:01 2016 +1300

Bug 1629154: Fixing issues when deleting an institution

When an institution has artefacts attached, eg Logo image we
include the artefact/lib.php file

Change-Id: I5da9ee684ac3520c682d25cf359ae1e009053e64
Signed-off-by: Robert Lyon 
(cherry picked from commit c1e55766bf3b334f66604ebc086dc793d1d11441)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629154

Title:
  Fatal error displayed when deleting the institution which has a logo

Status in Mahara:
  Fix Committed

Bug description:
  Version 16.10

  All possible browsers

  Steps to reproduce:

  1) Create an institution and make sure to attach a logo
  2) Now go back to institutions and delete it

  Expected result: Institution should be deleted
  Actual Result: A fatal error is displayed ( see attached)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629154/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1630764] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7148
Committed: 
https://git.mahara.org/mahara/mahara/commit/8995297e2bb671dd1796264706bd4634e7f1bd56
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 8995297e2bb671dd1796264706bd4634e7f1bd56
Author: Robert Lyon 
Date:   Thu Oct 6 10:11:05 2016 +1300

Bug 1630764: fixing for update user via webservices

behatnotneeded

Change-Id: Id9ad96fd651423b1a8078ddc8cf7de87a857bf39
Signed-off-by: Robert Lyon 
(cherry picked from commit 01a34a7cb7224dfd3924cd6cd45f1693e23a078e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1630764

Title:
  Webservices update user has problems with preferredname and studentid
  fields

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is like bug 1630753 but this also needs to be fixed for 16.10+ as
  well

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1630764/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1629147] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7155
Committed: 
https://git.mahara.org/mahara/mahara/commit/982ada76389ccc643e4c18a0c2a8404e1a5ed2a4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit 982ada76389ccc643e4c18a0c2a8404e1a5ed2a4
Author: Robert Lyon 
Date:   Mon Oct 3 15:01:49 2016 +1300

Bug 1629147: Returning correct collection url

behatnotneeded

Change-Id: Ia78f7329be80c51dafb77be298883fa4fe1de032
Signed-off-by: Robert Lyon 
(cherry picked from commit b40e7c4779f96aa7c7e204d17539d451e0fbda0f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629147

Title:
  Error message about non-existent framework url

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  This might be related to bug #1629144

  When I want to delete a copied page from a collection that has
  SmartEvidence, I get the following error message on the page deletion
  page:

  [WAR] 64 (lib/collection.php:950) Undefined property: 
Collection::$frameworkurl
  Call stack (most recent first):

  log_message("Undefined property: Collection::$frameworkurl", 8, true, 
true, "/home/kristina/code/1610stable/htdocs/lib/collecti...", 950) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Undefined property: Collection::$frameworkurl", 
"/home/kristina/code/1610stable/htdocs/lib/collecti...", 950, array(size 6)) at 
/home/kristina/code/1610stable/htdocs/lib/collection.php:950
  Collection->get_url() at 
/home/kristina/code/1610stable/htdocs/view/delete.php:30

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629147/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1629144] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7154
Committed: 
https://git.mahara.org/mahara/mahara/commit/f4ac2cfa718fac310cd262a45f43ea04d6d1a085
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit f4ac2cfa718fac310cd262a45f43ea04d6d1a085
Author: Robert Lyon 
Date:   Mon Oct 3 14:40:47 2016 +1300

Bug 1629144: Allow copying of the framework evidence

If the user copying the collection is also the owner

Copies the annotation block's evidence mapping
but not the assessment/feedback.

behatnotneeded

Change-Id: I0b587889912f18f39035eb200cbe76a7cc7ae893
Signed-off-by: Robert Lyon 
(cherry picked from commit 4254e377519daed79148b4c39c35e0adb17bbfc1)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629144

Title:
  Problems with copying a SmartEvidence collection with annotations

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  1. Set up a SmartEvidence collection.
  2. Put a couple of annotations on the page.
  3. Add a couple of feedbacks to the annotations.
  4. Copy the collection in the same user account.
  5. Open a page that has an annotation.

  I get the following error message multiple times:

  [WAR] 5f (artefact/annotation/lib.php:1294) Trying to get property of 
non-object
  Call stack (most recent first):

  log_message("Trying to get property of non-object", 8, true, true, 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Trying to get property of non-object", 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294, array(size 13)) 
at /home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1294
  
ArtefactTypeAnnotationfeedback::add_annotation_feedback_form(object(ArtefactTypeAnnotation),
 object(View), null, "1061", false, "0") at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1132
  
ArtefactTypeAnnotationfeedback::get_annotation_feedback_for_view(object(ArtefactTypeAnnotation),
 object(View), "1061", true, false) at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/blocktype/annotation/lib.php:134
  PluginBlocktypeAnnotation::render_instance(object(BlockInstance)) at 
Unknown:0
  call_user_func_array(array(size 2), array(size 1)) at 
/home/kristina/code/1610stable/htdocs/lib/mahara.php:1730
  call_static_method("PluginBlocktypeAnnotation", "render_instance", 
object(BlockInstance)) at 
/home/kristina/code/1610stable/htdocs/blocktype/lib.php:1007
  BlockInstance->render_viewing(false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:2037
  View->build_column(1, 1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1991
  View->build_columns(1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1976
  View->build_rows() at 
/home/kristina/code/1610stable/htdocs/view/view.php:281

  

  If possible, the annotations should be linked to the map in the copied
  collection. Currently, the annotations display on the page, but their
  status doesn't shop up on the smartEvidence overview page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629144/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1157543] Re: Record page editing history

[Kristina Hoeppner]

** Changed in: mahara
 Assignee: Nigel Cunningham (nigelc-g) => (unassigned)

** Changed in: mahara
   Status: In Progress => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1157543

Title:
  Record page editing history

Status in Mahara:
  Confirmed

Bug description:
  I'd like to "dogfood" Mahara's developer documentation by moving it
  from Mediawiki to the Mahara platform itself, probably as group pages
  so it could still be edited by many people. One of the features that
  is lacking to make this feasible, though, is having an edit history.
  The wiki allows us to keep track of who made what edits, and to revert
  to older versions if necessary.

  So, I'd like to see Mahara gain the ability to keep track of a page's
  edit history. At a minimum it needs:

  1. Who made changes, at what time
  2. What the page looked like at each revision
  3. Ability to revert the page to a previous version

  Also good would be:

  4. Ability to "diff" versions and highlight what changed
  5. Comments that go in the history log
  6. "Publish" ability (including publishing at a later time/date)
  7. Versioning file attachments, see also 
https://bugs.launchpad.net/mahara/+bug/548195

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1157543/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1625380] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7156

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625380

Title:
  Able to select a standard from Collection Edit page

Status in Mahara:
  Fix Committed

Bug description:
  Tested in Chrome, Firefox, Safari and IE Edge for php5

  Pre req: Confirm that standard is pre selected via SE map/matrix 
(Collection>matrix>annotation) 
   From standard drop down menu, pre selected is highlighted and not 
able to select a diff standard 

  
  Test step:
  From Page>Edit this page>Annotation (enter Annotation) 
  Standard drop down menu>select a standard (different from existing)
  Save

  To confirm that the change is accepted: Collection>matrix>Annotation


  You should not be able to update the standard once it had already been
  selected as the annotation wouldn't fit anymore. This is a bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1625380/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1568613] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7160

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568613

Title:
  The screenreader "Remove" doesn't do anything

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  When you want to remove a tag (in the new tag search) or a person
  (when sending a message) just using a screenreader, clicking the
  "Remove" item doesn't do anything. The tag / user is not removed.

  Remove "interesting"

  It's just a screenreader issue and works fine for sighted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568613/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1568613] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7160
Committed: 
https://git.mahara.org/mahara/mahara/commit/aec2699112641e7ac5928bd087d0fa7ddbf4b91f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit aec2699112641e7ac5928bd087d0fa7ddbf4b91f
Author: Robert Lyon 
Date:   Tue Oct 4 15:00:10 2016 +1300

Bug 1568613: Allow keypress to delete a selected option in select2

So that it is more keyboard accessible

behatnotneeded

Change-Id: I7dd437ae6cc4a70e6817fad570df884b5f8b12cb
Signed-off-by: Robert Lyon 
(cherry picked from commit 5ec92cddcf24fca18fdb1b24707216a5ea24bde8)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568613

Title:
  The screenreader "Remove" doesn't do anything

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  When you want to remove a tag (in the new tag search) or a person
  (when sending a message) just using a screenreader, clicking the
  "Remove" item doesn't do anything. The tag / user is not removed.

  Remove "interesting"

  It's just a screenreader issue and works fine for sighted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568613/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1634591] Re: Show last updated date and time when seeing a portfolio page

[Kristina Hoeppner]

** Changed in: mahara
Milestone: None => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1634591

Title:
  Show last updated date and time when seeing a portfolio page

Status in Mahara:
  In Progress

Bug description:
  Version: master(17.04), 16.10, 16.04

  It would be good to see when a portfolio page has been updated

  The last updated date and time will be shown next to the page visits
  when seeing a page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1634591/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1381228] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/7163

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1381228

Title:
  Problem with journal entry only showing creation date and not modified
  date

Status in Mahara:
  Confirmed

Bug description:
  From forum:
  https://mahara.org/interaction/forum/topic.php?id=6470=0=10

  'It appears to me that students can "game" assignment deadlines by
  creating incomplete Journal entries before the assignment deadline,
  then editing them after the deadline, since the Journal entry time
  stamps don't update after editing'

  Taking a quick look at this - a journal entry displays the creation
  date - which should never change.

  What would be needed is to either display the modification date
  instead of the creation date (which are the same initially but change
  on editing) or have both display if different, eg

  Posted on Wednesday, 8 October 2014, 9:37 AM
  Last edited on Thursday, 9 October 2014, 19:45 PM

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1381228/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1381228] A patch has been submitted for review

[Mahara Bot]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7162

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1381228

Title:
  Problem with journal entry only showing creation date and not modified
  date

Status in Mahara:
  Confirmed

Bug description:
  From forum:
  https://mahara.org/interaction/forum/topic.php?id=6470=0=10

  'It appears to me that students can "game" assignment deadlines by
  creating incomplete Journal entries before the assignment deadline,
  then editing them after the deadline, since the Journal entry time
  stamps don't update after editing'

  Taking a quick look at this - a journal entry displays the creation
  date - which should never change.

  What would be needed is to either display the modification date
  instead of the creation date (which are the same initially but change
  on editing) or have both display if different, eg

  Posted on Wednesday, 8 October 2014, 9:37 AM
  Last edited on Thursday, 9 October 2014, 19:45 PM

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1381228/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1568613] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7144
Committed: 
https://git.mahara.org/mahara/mahara/commit/8635f84d0f3452ac00e3ed1196be3940ec4e9c82
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 8635f84d0f3452ac00e3ed1196be3940ec4e9c82
Author: Robert Lyon 
Date:   Tue Oct 4 15:00:10 2016 +1300

Bug 1568613: Allow keypress to delete a selected option in select2

So that it is more keyboard accessible

behatnotneeded

Change-Id: I7dd437ae6cc4a70e6817fad570df884b5f8b12cb
Signed-off-by: Robert Lyon 
(cherry picked from commit 5ec92cddcf24fca18fdb1b24707216a5ea24bde8)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568613

Title:
  The screenreader "Remove" doesn't do anything

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  When you want to remove a tag (in the new tag search) or a person
  (when sending a message) just using a screenreader, clicking the
  "Remove" item doesn't do anything. The tag / user is not removed.

  Remove "interesting"

  It's just a screenreader issue and works fine for sighted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568613/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1568613] Re: The screenreader "Remove" doesn't do anything

[Robert Lyon]

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568613

Title:
  The screenreader "Remove" doesn't do anything

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  When you want to remove a tag (in the new tag search) or a person
  (when sending a message) just using a screenreader, clicking the
  "Remove" item doesn't do anything. The tag / user is not removed.

  Remove "interesting"

  It's just a screenreader issue and works fine for sighted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568613/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1568619] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7150
Committed: 
https://git.mahara.org/mahara/mahara/commit/37d9d39c1df43adb6fe97f815a618eee4939faca
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 37d9d39c1df43adb6fe97f815a618eee4939faca
Author: Robert Lyon 
Date:   Tue Oct 4 16:38:55 2016 +1300

Bug 1568619: Allowing openbadge info modal to open via enter key

Also allow one to tab through the modal and close it and put the focus
back on the badge we used to open the modal

behatnotneeded

Change-Id: I45c428f7abfa6e20be3b1a6d0c6867ec6f62f199
Signed-off-by: Robert Lyon 
(cherry picked from commit e9f806db39fe050506700dbd33da3507c3602a58)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568619

Title:
  Open Badge details aren't accessible with screenreader

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  When you have an Open Badge in a page and you just use a screenreader
  and click on the Open Badge image, the modal with the information
  about the badge does not appear. I suspect the on.click Javascript is
  the culprit.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568619/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1631809] Re: Allow image preview in modal - not working for file lists within modals

[Kristina Hoeppner]

** Tags added: nominatedfeature

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1631809

Title:
  Allow image preview in modal - not working for file lists within
  modals

Status in Mahara:
  Fix Committed

Bug description:
  The patch for bug 1572356 only dealt with the files list on the
  Content -> files page.

  But what would be more useful is if the picker worked within other
  modal popups, like when picking an image to an image block or picking
  an image within the tinymce image picker.

  So I've added a patch to deal with this and also fixed the issue where
  profileicon images could not be chosen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1631809/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1629144] Re: Problems with copying a SmartEvidence collection with annotations

[Kristina Hoeppner]

** Tags added: usermanualupdate

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629144

Title:
  Problems with copying a SmartEvidence collection with annotations

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  1. Set up a SmartEvidence collection.
  2. Put a couple of annotations on the page.
  3. Add a couple of feedbacks to the annotations.
  4. Copy the collection in the same user account.
  5. Open a page that has an annotation.

  I get the following error message multiple times:

  [WAR] 5f (artefact/annotation/lib.php:1294) Trying to get property of 
non-object
  Call stack (most recent first):

  log_message("Trying to get property of non-object", 8, true, true, 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Trying to get property of non-object", 
"/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294, array(size 13)) 
at /home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1294
  
ArtefactTypeAnnotationfeedback::add_annotation_feedback_form(object(ArtefactTypeAnnotation),
 object(View), null, "1061", false, "0") at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1132
  
ArtefactTypeAnnotationfeedback::get_annotation_feedback_for_view(object(ArtefactTypeAnnotation),
 object(View), "1061", true, false) at 
/home/kristina/code/1610stable/htdocs/artefact/annotation/blocktype/annotation/lib.php:134
  PluginBlocktypeAnnotation::render_instance(object(BlockInstance)) at 
Unknown:0
  call_user_func_array(array(size 2), array(size 1)) at 
/home/kristina/code/1610stable/htdocs/lib/mahara.php:1730
  call_static_method("PluginBlocktypeAnnotation", "render_instance", 
object(BlockInstance)) at 
/home/kristina/code/1610stable/htdocs/blocktype/lib.php:1007
  BlockInstance->render_viewing(false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:2037
  View->build_column(1, 1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1991
  View->build_columns(1, false, false) at 
/home/kristina/code/1610stable/htdocs/lib/view.php:1976
  View->build_rows() at 
/home/kristina/code/1610stable/htdocs/view/view.php:281

  

  If possible, the annotations should be linked to the map in the copied
  collection. Currently, the annotations display on the page, but their
  status doesn't shop up on the smartEvidence overview page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629144/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1579145] Re: Ability to include live link on image description

[Kristina Hoeppner]

** Changed in: mahara
Milestone: None => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1579145

Title:
  Ability to include live link on image description

Status in Mahara:
  In Progress

Bug description:
  It would be very helpful to have the ability to include a live link in
  the image description to allow users to provide useful citations.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1579145/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1625380] Re: Able to select a standard from Collection Edit page

[Kristina Hoeppner]

** Tags added: usermanualupdate

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625380

Title:
  Able to select a standard from Collection Edit page

Status in Mahara:
  Fix Committed

Bug description:
  Tested in Chrome, Firefox, Safari and IE Edge for php5

  Pre req: Confirm that standard is pre selected via SE map/matrix 
(Collection>matrix>annotation) 
   From standard drop down menu, pre selected is highlighted and not 
able to select a diff standard 

  
  Test step:
  From Page>Edit this page>Annotation (enter Annotation) 
  Standard drop down menu>select a standard (different from existing)
  Save

  To confirm that the change is accepted: Collection>matrix>Annotation


  You should not be able to update the standard once it had already been
  selected as the annotation wouldn't fit anymore. This is a bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1625380/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 732462] Re: Allow re-ordering of files for File(s) to Download block

[Kristina Hoeppner]

** Changed in: mahara
   Status: Triaged => In Progress

** Changed in: mahara
   Status: In Progress => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/732462

Title:
  Allow re-ordering of files for File(s) to Download block

Status in Mahara:
  Confirmed

Bug description:
  Files can be selected in the order in which they should appear in the
  File(s) to Download block. However, when additional files are added,
  the order can't be changed to drop them in further up the list. Re-
  order buttons are needed. The block would basically stay the same but
  have ordering buttons like on the Manage Collections screen so that
  you can move files up and down.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/732462/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1381228] Re: Problem with journal entry only showing creation date and not modified date

[Robert Lyon]

I've added a simple proof of concept patch
https://reviews.mahara.org/#/c/7163/1 to indicate what I was thinking
when it comes to created and last updated dates.

Note: The patch was quickly put together and not fully tested

Feel free to take the concept and flesh it out more.

Hopefully a more robust patch will be available for Mahara 17.04

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1381228

Title:
  Problem with journal entry only showing creation date and not modified
  date

Status in Mahara:
  Confirmed

Bug description:
  From forum:
  https://mahara.org/interaction/forum/topic.php?id=6470=0=10

  'It appears to me that students can "game" assignment deadlines by
  creating incomplete Journal entries before the assignment deadline,
  then editing them after the deadline, since the Journal entry time
  stamps don't update after editing'

  Taking a quick look at this - a journal entry displays the creation
  date - which should never change.

  What would be needed is to either display the modification date
  instead of the creation date (which are the same initially but change
  on editing) or have both display if different, eg

  Posted on Wednesday, 8 October 2014, 9:37 AM
  Last edited on Thursday, 9 October 2014, 19:45 PM

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1381228/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1568619] Re: Open Badge details aren't accessible with screenreader

[Robert Lyon]

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568619

Title:
  Open Badge details aren't accessible with screenreader

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  When you have an Open Badge in a page and you just use a screenreader
  and click on the Open Badge image, the modal with the information
  about the badge does not appear. I suspect the on.click Javascript is
  the culprit.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568619/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1631806] Re: Page descriptions not retained from group, institution and site pages

[Kristina Hoeppner]

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1631806

Title:
  Page descriptions not retained from group, institution and site pages

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Reported at https://mahara.org/interaction/forum/topic.php?id=7731

  When copying a group, institution or site page, the page description
  is not copied, which makes it less useful for templates.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1631806/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1632717] Re: Bugs after updating Mahara

[Kristina Hoeppner]

Lilian and Antonella, did you customize the group creation process?
Normally, when you create a group, a group homepage is always added by
default because without it, the group couldn't exist.

Also, maybe a long shot, do you still see the "Group homepage" page
under Administration -> configure site -> Pages? That's the default
group homepage.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1632717

Title:
  Bugs after updating Mahara

Status in Mahara:
  Incomplete

Bug description:
  Hello,

  After the update to the latest version of Mahara (16.04) I have
  problems with the display pages of the groups.

  Here is an example :

  [WAR] 1b (lib/group.php:2338) Trying to get property of non-object
  Call stack (most recent first):

  log_message(string(size 36), integer, true, true, string(size 53), 
integer) at /mypath/maha/lib/errors.php:513
  error(integer, string(size 36), string(size 53), integer, array(size 2)) 
at /mypath/maha/lib/group.php:2338
  group_get_homepage_view(string(size 2)) at /mypath/maha/lib/view.php:5734
  View->display_author() at /mypath/maha/view/view.php:362

  [WAR] 1b (lib/errors.php:820) Failed to get a recordset: mysqli error: [1452: 
Cannot add or update a child row: a foreign key constraint fails 
("mybdd"."view", CONSTRAINT "view_ibfk_7" FOREIGN KEY ("type") REFERENCES 
"view_type" ("type"))] in EXECUTE("INSERT INTO "view" ("ctime", "mtime", 
"atime", "copynewuser", "anonymise") VALUES ('2016-10-12 15:32:22', '2016-10-12 
15:32:22', '2016-10-12 15:32:22', 0, 0)")
  Command was: INSERT INTO "view" ("ctime", "mtime", "atime", "copynewuser", 
"anonymise") VALUES (?, ?, ?, ?, ?) and values was 
(ctime:2016-10-1215:32:22,mtime:2016-10-1215:32:22,atime:2016-10-1215:32:22,copynewuser:0,anonymise:0)
  Call stack (most recent first):

  log_message(string(size 618), integer, true, true) at 
/mypath/maha/lib/errors.php:95
  log_warn(string(size 618)) at /mypath/maha/lib/errors.php:820
  SQLException->__construct(string(size 618)) at 
/mypath/maha/lib/dml.php:1088
  insert_record(string(size 4), object(stdClass), string(size 2), true) at 
/mypath/maha/lib/view.php:728
  View->commit() at /mypath/maha/lib/view.php:702
  View->__destruct() at /mypath/maha/view/view.php:362
  View->display_author() at /mypath/maha/view/view.php:362

  [WAR] 1b (lib/dml.php:1088) Failed to get a recordset: mysqli error: [1452: 
Cannot add or update a child row: a foreign key constraint fails 
("mybdd"."view", CONSTRAINT "view_ibfk_7" FOREIGN KEY ("type") REFERENCES 
"view_type" ("type"))] in EXECUTE("INSERT INTO "view" ("ctime", "mtime", 
"atime", "copynewuser", "anonymise") VALUES ('2016-10-12 15:32:22', '2016-10-12 
15:32:22', '2016-10-12 15:32:22', 0, 0)")
  Command was: INSERT INTO "view" ("ctime", "mtime", "atime", "copynewuser", 
"anonymise") VALUES (?, ?, ?, ?, ?) and values was 
(ctime:2016-10-1215:32:22,mtime:2016-10-1215:32:22,atime:2016-10-1215:32:22,copynewuser:0,anonymise:0)
  Call stack (most recent first):

  insert_record(string(size 4), object(stdClass), string(size 2), true) at 
/mypath/maha/lib/view.php:728
  View->commit() at /mypath/maha/lib/view.php:702
  View->__destruct() at /mypath/maha/view/view.php:362
  View->display_author() at /mypath/maha/view/view.php:362

  Untitled
  Mywebsite Mahara : Site unavailable
  A nonrecoverable error occurred. This probably means you have encountered a 
bug in the system

  Thank you for your help.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1632717/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1529775] Re: MySql concat string needs to be used instead of ||

[Robert Lyon]

Back in commit 1a4c340b6959f7d1bd5bf2b6147686a0d627af8a  (circa 2007)
the line 
  $db->_Execute("SET SQL_MODE='POSTGRESQL'");

was added to make mysql being used by Mahara act like postgres so that
it can do the pipes (||)

So this shouldn't be an issue.

I did not when I copied sql commands from code to try directly in mysql
I'd need to do SET SQL_MODE='POSTGRESQL'; first

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1529775

Title:
  MySql concat string needs to be used instead of ||

Status in Mahara:
  Invalid

Bug description:
  Mahara 15.10
  OS: Ubuntu 14.04
  DB: Mysql 5.5
  Browser: any

  I've noticed that in htdocs/search/internal/lib.php, the SQL used to
  concatenate strings is '||'.

  For example, line 275:
  $sql = $alias . '.' . $field . ' ' . db_ilike() . " '%' || ? || '%'";

  
  Unfortunately, this doesn't always work with Mysql. In order for this to work 
we would need to set PIPES_AS_CONCAT

  Please refer to the documentation:
  http://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_pipes_as_concat

  Otherwise, strings need to be concatenated using: 'CONCAT'.

  This function is also available in Postgres.

  So, perhaps we should be using CONCAT instead of '||'.

  So, the above line 275 would be:
  $sql = $alias . '.' . $field . ' ' . db_ilike() . " concat('%', ? , '%')";

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1529775/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1529775] Re: MySql concat string needs to be used instead of ||

[Aaron Wells]

As Robert mentioned, we do "SET SQL_MODE='POSTGRESQL'" when using MySQL.
This is equivalent to the "PIPES_AS_CONCAT" directive Ghada mentioned,
as well as several other options:

Equivalent to PIPES_AS_CONCAT, ANSI_QUOTES, IGNORE_SPACE,
NO_KEY_OPTIONS, NO_TABLE_OPTIONS, NO_FIELD_OPTIONS.

http://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_postgresql

** Changed in: mahara
   Status: Confirmed => Invalid

** Changed in: mahara
Milestone: 16.10.0 => None

** Changed in: mahara
   Status: Invalid => Won't Fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1529775

Title:
  MySql concat string needs to be used instead of ||

Status in Mahara:
  Won't Fix

Bug description:
  Mahara 15.10
  OS: Ubuntu 14.04
  DB: Mysql 5.5
  Browser: any

  I've noticed that in htdocs/search/internal/lib.php, the SQL used to
  concatenate strings is '||'.

  For example, line 275:
  $sql = $alias . '.' . $field . ' ' . db_ilike() . " '%' || ? || '%'";

  
  Unfortunately, this doesn't always work with Mysql. In order for this to work 
we would need to set PIPES_AS_CONCAT

  Please refer to the documentation:
  http://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_pipes_as_concat

  Otherwise, strings need to be concatenated using: 'CONCAT'.

  This function is also available in Postgres.

  So, perhaps we should be using CONCAT instead of '||'.

  So, the above line 275 would be:
  $sql = $alias . '.' . $field . ' ' . db_ilike() . " concat('%', ? , '%')";

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1529775/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1529775] Re: MySql concat string needs to be used instead of ||

[Aaron Wells]

The main gotcha to this, is that if you're debugging a Mahara instance
that's running in MySQL, and you copy out one of the SQL queries
generated by Mahara and try to run it manually in a separate MySQL
client.

If you do that, and the query uses ||, it'll error out unless you have
first manually run

SET SQL_MODE='POSTGRESQL';

The full list of things we do when setting up a connection to a MySQL
DB, is in the "configure_dbconnection()" function in htdocs/lib/dml.php.
It's actually:

SET NAMES 'utf8';
SET SQL_MODE='POSTGRESQL';
SET CHARACTER SET utf8;
SET SQL_BIG_SELECTS=1;

And if you're using $CFG->dbtimezone, we also do

SET time_zone='{$CFG->dbtimezone}';

So if you notice discrepancies when running Mahara-generated SQL queries
in a MySQL client, one thing to try is to run all of those in the client
and see if it makes a difference.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1529775

Title:
  MySql concat string needs to be used instead of ||

Status in Mahara:
  Won't Fix

Bug description:
  Mahara 15.10
  OS: Ubuntu 14.04
  DB: Mysql 5.5
  Browser: any

  I've noticed that in htdocs/search/internal/lib.php, the SQL used to
  concatenate strings is '||'.

  For example, line 275:
  $sql = $alias . '.' . $field . ' ' . db_ilike() . " '%' || ? || '%'";

  
  Unfortunately, this doesn't always work with Mysql. In order for this to work 
we would need to set PIPES_AS_CONCAT

  Please refer to the documentation:
  http://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_pipes_as_concat

  Otherwise, strings need to be concatenated using: 'CONCAT'.

  This function is also available in Postgres.

  So, perhaps we should be using CONCAT instead of '||'.

  So, the above line 275 would be:
  $sql = $alias . '.' . $field . ' ' . db_ilike() . " concat('%', ? , '%')";

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1529775/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1577251] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7066
Committed: 
https://git.mahara.org/mahara/mahara/commit/6cfb0274081b55dade4edb526a2db580b15dc2c4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 6cfb0274081b55dade4edb526a2db580b15dc2c4
Author: Robert Lyon 
Date:   Tue Oct 4 13:54:44 2016 +1300

Bug 1577251: Delete password requests when changing primary email

behatnotneeded

Change-Id: I63080b651e08e8e747a891e9f7f2283bfecb72f1
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577251

Title:
  Should invalidate password reset links when a user changes their
  primary email address

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  As reported to us through the mahara.org security bug email address,
  by Sajibe kanti.

  When a user completes the "Forgot password?" password reset process,
  we delete any remaining password reset links for that user. However,
  we do not delete these if a user changes their primary email address.
  As the initial email points out, that could lead to an attack like
  this:

  1. Attacker compromises victim's Mahara account (without changing victim's 
password).
  2. Attacker changes their account's primary email address to the attacker's 
email address.
  3. Attacker uses "Forgot password" page to request a password reset email. 
They don't immediately use the link in the password reset email; instead they 
store it for later.
  4. Victim realizes their Mahara account is compromised, and logs in to their 
account.
  5. Victim attempts to secure their account by changing their password 
(through account settings page), and changing their primary email address back 
to their own.

  Expected result: The attacker is locked out of the victim's Mahara
  account

  Actual result: The attacker uses their stored password reset email to
  change the user's password and re-gain access to their account.

  
  We could help reduce this attack vector, by deleting any outstanding password 
reset emails for a user, when the user updates their account's primary email 
address. We should probably also delete any outstanding password reset emails 
for a user, when they change their account password through the account 
settings page. It may be worth considering other situations where password 
reset emails should be deleted, as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1634702] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/7168

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1634702

Title:
  Unable to decline email validation in mysql

Status in Mahara:
  In Progress

Bug description:
  Reported by community member

  
https://mahara.org/interaction/forum/topic.php?id=7742=0=10#post31146

  In the artefact_internal_profile_email we have a column called 'key'
  which turns out to be a reserved word in MySQL - and there is an sql
  query with WHERE key=? in it.

  We will need to wrap the 'key' in double quotes

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1634702/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1634675] [NEW] Select the institution theme that you want to use when creating/editing a page

[Kristina Hoeppner]

Public bug reported:

This is a follow-on wishlist item to bug #1632917.

When a user is in multiple institutions, the institution theme currently
selected in account settings is the one under which a page is created.
If the user switches institutions in the account settings, the page
theme is not updated to reflect that change.

That is good if the user wants to keep the other theme on the page in
order to distinguish pages created under different institutions.

This is bad though if the user created the page using the wrong
institution theme or wants to have all the pages in a particular theme
at some point.

There is no way to edit the institution theme. Furthermore, if the user
did want to differentiate pages created in different institutions,
they'd need to go to the account settings all the time.

It would be better to display the theme switcher on the page edit screen
when you are in multiple institutions so you can decide which theme to
use.

Or we could rethink page themes and skins altogether and try to merge
them.

** Affects: mahara
 Importance: Wishlist
 Status: Confirmed


** Tags: theming

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1634675

Title:
  Select the institution theme that you want to use when
  creating/editing a page

Status in Mahara:
  Confirmed

Bug description:
  This is a follow-on wishlist item to bug #1632917.

  When a user is in multiple institutions, the institution theme
  currently selected in account settings is the one under which a page
  is created. If the user switches institutions in the account settings,
  the page theme is not updated to reflect that change.

  That is good if the user wants to keep the other theme on the page in
  order to distinguish pages created under different institutions.

  This is bad though if the user created the page using the wrong
  institution theme or wants to have all the pages in a particular theme
  at some point.

  There is no way to edit the institution theme. Furthermore, if the
  user did want to differentiate pages created in different
  institutions, they'd need to go to the account settings all the time.

  It would be better to display the theme switcher on the page edit
  screen when you are in multiple institutions so you can decide which
  theme to use.

  Or we could rethink page themes and skins altogether and try to merge
  them.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1634675/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1632917] Re: Page created in wrong institution theme

[Kristina Hoeppner]

The patch here fixes only that the correct institution theme is selected
when creating the page. The remainder is a wishlist item and reported
now at bug #1634675

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1632917

Title:
  Page created in wrong institution theme

Status in Mahara:
  In Progress

Bug description:
  Tested on Mahara 16.10dev

  When you are a member of 2 or more institutions, you can switch the
  themes in your account settings page to the institution theme that you
  want to browse the site in.

  When you create a page though, one of the institution themes is chosen
  and in my case it wasn't the one of the institution I had selected.

  To replicate:

  1. Set up institutions "School" and "University" and give each a different 
theme, i.e. not the site theme.
  2. Set up a user who is a member in both institutions.
  3. Log in and in the account settings, choose the school theme.
  4. Create a page -> it takes on the school theme, which is correct.
  5. Switch the theme in the account settings to "University".
  6. The site displays in the university institution theme -> correct.
  7. Create a page -> The school theme is selected -> This is not correct. It 
should display the university theme.
  8. When you go to the page that you created under 4, it also still displays 
the school theme when it should show the university theme as that is your 
browsing theme.

  The theme displayed to the user when browsing the site or creating a
  page should always be the one selected in account settings as that is
  the only way to know what the user's preference is.

  This is unrelated to being able to choose a page theme. When that
  functionality is enabled, users should be able to "pin" a specific
  theme to a page, but only then. At all other times, the institution
  theme / theme chosen in their account settings page should be the one
  used for browsing their own portfolio.

  There is no way to switch the theme to a "new" / other institution
  when page themes aren't turned on (which they aren't always).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1632917/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1634702] [NEW] Unable to decline email validation in mysql

[Robert Lyon]

Public bug reported:

Reported by community member

https://mahara.org/interaction/forum/topic.php?id=7742=0=10#post31146

In the artefact_internal_profile_email we have a column called 'key'
which turns out to be a reserved word in MySQL - and there is an sql
query with WHERE key=? in it.

We will need to wrap the 'key' in double quotes

** Affects: mahara
 Importance: High
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1634702

Title:
  Unable to decline email validation in mysql

Status in Mahara:
  In Progress

Bug description:
  Reported by community member

  
https://mahara.org/interaction/forum/topic.php?id=7742=0=10#post31146

  In the artefact_internal_profile_email we have a column called 'key'
  which turns out to be a reserved word in MySQL - and there is an sql
  query with WHERE key=? in it.

  We will need to wrap the 'key' in double quotes

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1634702/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1577251] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7164
Committed: 
https://git.mahara.org/mahara/mahara/commit/4a51beb36d4bfb0619024b2917c4e103eb0bae30
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit 4a51beb36d4bfb0619024b2917c4e103eb0bae30
Author: Robert Lyon 
Date:   Tue Oct 4 13:54:44 2016 +1300

Bug 1577251: Delete password requests when changing primary email

behatnotneeded

Change-Id: I63080b651e08e8e747a891e9f7f2283bfecb72f1
Signed-off-by: Robert Lyon 
(cherry picked from commit 6cfb0274081b55dade4edb526a2db580b15dc2c4)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577251

Title:
  Should invalidate password reset links when a user changes their
  primary email address

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  As reported to us through the mahara.org security bug email address,
  by Sajibe kanti.

  When a user completes the "Forgot password?" password reset process,
  we delete any remaining password reset links for that user. However,
  we do not delete these if a user changes their primary email address.
  As the initial email points out, that could lead to an attack like
  this:

  1. Attacker compromises victim's Mahara account (without changing victim's 
password).
  2. Attacker changes their account's primary email address to the attacker's 
email address.
  3. Attacker uses "Forgot password" page to request a password reset email. 
They don't immediately use the link in the password reset email; instead they 
store it for later.
  4. Victim realizes their Mahara account is compromised, and logs in to their 
account.
  5. Victim attempts to secure their account by changing their password 
(through account settings page), and changing their primary email address back 
to their own.

  Expected result: The attacker is locked out of the victim's Mahara
  account

  Actual result: The attacker uses their stored password reset email to
  change the user's password and re-gain access to their account.

  
  We could help reduce this attack vector, by deleting any outstanding password 
reset emails for a user, when the user updates their account's primary email 
address. We should probably also delete any outstanding password reset emails 
for a user, when they change their account password through the account 
settings page. It may be worth considering other situations where password 
reset emails should be deleted, as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1577251] Re: Should invalidate password reset links when a user changes their primary email address

[Robert Lyon]

** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: Confirmed => In Progress

** Changed in: mahara/15.10
   Status: Confirmed => In Progress

** Changed in: mahara/15.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577251

Title:
  Should invalidate password reset links when a user changes their
  primary email address

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  As reported to us through the mahara.org security bug email address,
  by Sajibe kanti.

  When a user completes the "Forgot password?" password reset process,
  we delete any remaining password reset links for that user. However,
  we do not delete these if a user changes their primary email address.
  As the initial email points out, that could lead to an attack like
  this:

  1. Attacker compromises victim's Mahara account (without changing victim's 
password).
  2. Attacker changes their account's primary email address to the attacker's 
email address.
  3. Attacker uses "Forgot password" page to request a password reset email. 
They don't immediately use the link in the password reset email; instead they 
store it for later.
  4. Victim realizes their Mahara account is compromised, and logs in to their 
account.
  5. Victim attempts to secure their account by changing their password 
(through account settings page), and changing their primary email address back 
to their own.

  Expected result: The attacker is locked out of the victim's Mahara
  account

  Actual result: The attacker uses their stored password reset email to
  change the user's password and re-gain access to their account.

  
  We could help reduce this attack vector, by deleting any outstanding password 
reset emails for a user, when the user updates their account's primary email 
address. We should probably also delete any outstanding password reset emails 
for a user, when they change their account password through the account 
settings page. It may be worth considering other situations where password 
reset emails should be deleted, as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1577251] A patch has been submitted for review

[Mahara Bot]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7165

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577251

Title:
  Should invalidate password reset links when a user changes their
  primary email address

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  As reported to us through the mahara.org security bug email address,
  by Sajibe kanti.

  When a user completes the "Forgot password?" password reset process,
  we delete any remaining password reset links for that user. However,
  we do not delete these if a user changes their primary email address.
  As the initial email points out, that could lead to an attack like
  this:

  1. Attacker compromises victim's Mahara account (without changing victim's 
password).
  2. Attacker changes their account's primary email address to the attacker's 
email address.
  3. Attacker uses "Forgot password" page to request a password reset email. 
They don't immediately use the link in the password reset email; instead they 
store it for later.
  4. Victim realizes their Mahara account is compromised, and logs in to their 
account.
  5. Victim attempts to secure their account by changing their password 
(through account settings page), and changing their primary email address back 
to their own.

  Expected result: The attacker is locked out of the victim's Mahara
  account

  Actual result: The attacker uses their stored password reset email to
  change the user's password and re-gain access to their account.

  
  We could help reduce this attack vector, by deleting any outstanding password 
reset emails for a user, when the user updates their account's primary email 
address. We should probably also delete any outstanding password reset emails 
for a user, when they change their account password through the account 
settings page. It may be worth considering other situations where password 
reset emails should be deleted, as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1577251] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7164

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577251

Title:
  Should invalidate password reset links when a user changes their
  primary email address

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  As reported to us through the mahara.org security bug email address,
  by Sajibe kanti.

  When a user completes the "Forgot password?" password reset process,
  we delete any remaining password reset links for that user. However,
  we do not delete these if a user changes their primary email address.
  As the initial email points out, that could lead to an attack like
  this:

  1. Attacker compromises victim's Mahara account (without changing victim's 
password).
  2. Attacker changes their account's primary email address to the attacker's 
email address.
  3. Attacker uses "Forgot password" page to request a password reset email. 
They don't immediately use the link in the password reset email; instead they 
store it for later.
  4. Victim realizes their Mahara account is compromised, and logs in to their 
account.
  5. Victim attempts to secure their account by changing their password 
(through account settings page), and changing their primary email address back 
to their own.

  Expected result: The attacker is locked out of the victim's Mahara
  account

  Actual result: The attacker uses their stored password reset email to
  change the user's password and re-gain access to their account.

  
  We could help reduce this attack vector, by deleting any outstanding password 
reset emails for a user, when the user updates their account's primary email 
address. We should probably also delete any outstanding password reset emails 
for a user, when they change their account password through the account 
settings page. It may be worth considering other situations where password 
reset emails should be deleted, as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1577251] A patch has been submitted for review

[Mahara Bot]

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/7166

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577251

Title:
  Should invalidate password reset links when a user changes their
  primary email address

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  As reported to us through the mahara.org security bug email address,
  by Sajibe kanti.

  When a user completes the "Forgot password?" password reset process,
  we delete any remaining password reset links for that user. However,
  we do not delete these if a user changes their primary email address.
  As the initial email points out, that could lead to an attack like
  this:

  1. Attacker compromises victim's Mahara account (without changing victim's 
password).
  2. Attacker changes their account's primary email address to the attacker's 
email address.
  3. Attacker uses "Forgot password" page to request a password reset email. 
They don't immediately use the link in the password reset email; instead they 
store it for later.
  4. Victim realizes their Mahara account is compromised, and logs in to their 
account.
  5. Victim attempts to secure their account by changing their password 
(through account settings page), and changing their primary email address back 
to their own.

  Expected result: The attacker is locked out of the victim's Mahara
  account

  Actual result: The attacker uses their stored password reset email to
  change the user's password and re-gain access to their account.

  
  We could help reduce this attack vector, by deleting any outstanding password 
reset emails for a user, when the user updates their account's primary email 
address. We should probably also delete any outstanding password reset emails 
for a user, when they change their account password through the account 
settings page. It may be worth considering other situations where password 
reset emails should be deleted, as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1577251] A patch has been submitted for review

[Mahara Bot]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/7167

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577251

Title:
  Should invalidate password reset links when a user changes their
  primary email address

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  As reported to us through the mahara.org security bug email address,
  by Sajibe kanti.

  When a user completes the "Forgot password?" password reset process,
  we delete any remaining password reset links for that user. However,
  we do not delete these if a user changes their primary email address.
  As the initial email points out, that could lead to an attack like
  this:

  1. Attacker compromises victim's Mahara account (without changing victim's 
password).
  2. Attacker changes their account's primary email address to the attacker's 
email address.
  3. Attacker uses "Forgot password" page to request a password reset email. 
They don't immediately use the link in the password reset email; instead they 
store it for later.
  4. Victim realizes their Mahara account is compromised, and logs in to their 
account.
  5. Victim attempts to secure their account by changing their password 
(through account settings page), and changing their primary email address back 
to their own.

  Expected result: The attacker is locked out of the victim's Mahara
  account

  Actual result: The attacker uses their stored password reset email to
  change the user's password and re-gain access to their account.

  
  We could help reduce this attack vector, by deleting any outstanding password 
reset emails for a user, when the user updates their account's primary email 
address. We should probably also delete any outstanding password reset emails 
for a user, when they change their account password through the account 
settings page. It may be worth considering other situations where password 
reset emails should be deleted, as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp