[jira] [Commented] (MAPREDUCE-5861) finishedSubMaps field in LocalContainerLauncher does not need to be volatile

2014-05-20 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003261#comment-14003261
 ] 

Hudson commented on MAPREDUCE-5861:
---

FAILURE: Integrated in Hadoop-Yarn-trunk #562 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/562/])
MAPREDUCE-5861. finishedSubMaps field in LocalContainerLauncher does not need 
to be volatile. (Contributed by Tsuyoshi OZAWA) (junping_du: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1594795)
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/LocalContainerLauncher.java


 finishedSubMaps field in LocalContainerLauncher does not need to be volatile
 

 Key: MAPREDUCE-5861
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5861
 Project: Hadoop Map/Reduce
  Issue Type: Improvement
Reporter: Ted Yu
Assignee: Tsuyoshi OZAWA
Priority: Minor
 Fix For: 2.5.0

 Attachments: MAPREDUCE-5861.1.patch, MAPREDUCE-5861.2.patch


 Around line 374:
 {code}
   if (++finishedSubMaps == numMapTasks) {
 doneWithMaps = true;
   }
 {code}
 The increment of finishedSubMaps is not atomic.
 See the answer to 
 http://stackoverflow.com/questions/9749746/what-is-the-difference-of-atomic-volatile-synchronize
  .
 AtomicInteger can be used to achieve atomicity.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAPREDUCE-5861) finishedSubMaps field in LocalContainerLauncher does not need to be volatile

2014-05-20 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003296#comment-14003296
 ] 

Hudson commented on MAPREDUCE-5861:
---

FAILURE: Integrated in Hadoop-Hdfs-trunk #1754 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1754/])
MAPREDUCE-5861. finishedSubMaps field in LocalContainerLauncher does not need 
to be volatile. (Contributed by Tsuyoshi OZAWA) (junping_du: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1594795)
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/LocalContainerLauncher.java


 finishedSubMaps field in LocalContainerLauncher does not need to be volatile
 

 Key: MAPREDUCE-5861
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5861
 Project: Hadoop Map/Reduce
  Issue Type: Improvement
Reporter: Ted Yu
Assignee: Tsuyoshi OZAWA
Priority: Minor
 Fix For: 2.5.0

 Attachments: MAPREDUCE-5861.1.patch, MAPREDUCE-5861.2.patch


 Around line 374:
 {code}
   if (++finishedSubMaps == numMapTasks) {
 doneWithMaps = true;
   }
 {code}
 The increment of finishedSubMaps is not atomic.
 See the answer to 
 http://stackoverflow.com/questions/9749746/what-is-the-difference-of-atomic-volatile-synchronize
  .
 AtomicInteger can be used to achieve atomicity.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAPREDUCE-5861) finishedSubMaps field in LocalContainerLauncher does not need to be volatile

2014-05-20 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003473#comment-14003473
 ] 

Hudson commented on MAPREDUCE-5861:
---

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1780 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1780/])
MAPREDUCE-5861. finishedSubMaps field in LocalContainerLauncher does not need 
to be volatile. (Contributed by Tsuyoshi OZAWA) (junping_du: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1594795)
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/LocalContainerLauncher.java


 finishedSubMaps field in LocalContainerLauncher does not need to be volatile
 

 Key: MAPREDUCE-5861
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5861
 Project: Hadoop Map/Reduce
  Issue Type: Improvement
Reporter: Ted Yu
Assignee: Tsuyoshi OZAWA
Priority: Minor
 Fix For: 2.5.0

 Attachments: MAPREDUCE-5861.1.patch, MAPREDUCE-5861.2.patch


 Around line 374:
 {code}
   if (++finishedSubMaps == numMapTasks) {
 doneWithMaps = true;
   }
 {code}
 The increment of finishedSubMaps is not atomic.
 See the answer to 
 http://stackoverflow.com/questions/9749746/what-is-the-difference-of-atomic-volatile-synchronize
  .
 AtomicInteger can be used to achieve atomicity.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAPREDUCE-5861) finishedSubMaps field in LocalContainerLauncher does not need to be volatile

2014-05-16 Thread Tsuyoshi OZAWA (JIRA) 

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997833#comment-13997833
 ] 

Tsuyoshi OZAWA commented on MAPREDUCE-5861:
---

Thank you for the review, Sangjin and Junping! 

 finishedSubMaps field in LocalContainerLauncher does not need to be volatile
 

 Key: MAPREDUCE-5861
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5861
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Reporter: Ted Yu
Assignee: Tsuyoshi OZAWA
Priority: Minor
 Attachments: MAPREDUCE-5861.1.patch, MAPREDUCE-5861.2.patch


 Around line 374:
 {code}
   if (++finishedSubMaps == numMapTasks) {
 doneWithMaps = true;
   }
 {code}
 The increment of finishedSubMaps is not atomic.
 See the answer to 
 http://stackoverflow.com/questions/9749746/what-is-the-difference-of-atomic-volatile-synchronize
  .
 AtomicInteger can be used to achieve atomicity.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAPREDUCE-5861) finishedSubMaps field in LocalContainerLauncher does not need to be volatile

2014-05-16 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999017#comment-13999017
 ] 

Hudson commented on MAPREDUCE-5861:
---

SUCCESS: Integrated in Hadoop-trunk-Commit #5605 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/5605/])
MAPREDUCE-5861. finishedSubMaps field in LocalContainerLauncher does not need 
to be volatile. (Contributed by Tsuyoshi OZAWA) (junping_du: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1594795)
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/LocalContainerLauncher.java


 finishedSubMaps field in LocalContainerLauncher does not need to be volatile
 

 Key: MAPREDUCE-5861
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5861
 Project: Hadoop Map/Reduce
  Issue Type: Improvement
Reporter: Ted Yu
Assignee: Tsuyoshi OZAWA
Priority: Minor
 Fix For: 2.5.0

 Attachments: MAPREDUCE-5861.1.patch, MAPREDUCE-5861.2.patch


 Around line 374:
 {code}
   if (++finishedSubMaps == numMapTasks) {
 doneWithMaps = true;
   }
 {code}
 The increment of finishedSubMaps is not atomic.
 See the answer to 
 http://stackoverflow.com/questions/9749746/what-is-the-difference-of-atomic-volatile-synchronize
  .
 AtomicInteger can be used to achieve atomicity.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAPREDUCE-5861) finishedSubMaps field in LocalContainerLauncher does not need to be volatile

2014-05-15 Thread Junping Du (JIRA) 

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996234#comment-13996234
 ] 

Junping Du commented on MAPREDUCE-5861:
---

Agree volatile is not help here so better to remove it to get rid of confusing. 
+1. Patch LGTM. Will commit it shortly.

 finishedSubMaps field in LocalContainerLauncher does not need to be volatile
 

 Key: MAPREDUCE-5861
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5861
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Reporter: Ted Yu
Assignee: Tsuyoshi OZAWA
Priority: Minor
 Attachments: MAPREDUCE-5861.1.patch, MAPREDUCE-5861.2.patch


 Around line 374:
 {code}
   if (++finishedSubMaps == numMapTasks) {
 doneWithMaps = true;
   }
 {code}
 The increment of finishedSubMaps is not atomic.
 See the answer to 
 http://stackoverflow.com/questions/9749746/what-is-the-difference-of-atomic-volatile-synchronize
  .
 AtomicInteger can be used to achieve atomicity.



--
This message was sent by Atlassian JIRA
(v6.2#6252)