Re: [Moses-support] ProbingPT tests not building
Done. Thanks for spotting it. On Wed, Apr 1, 2015 at 4:49 PM, Jeroen Vermeulen < j...@precisiontranslationtools.com> wrote: > On 01/04/15 22:29, Nikolay Bogoychev wrote: > > > Those tests are indeed obsolete, I used them to test some behavior when > > I was building probingPT but the function in question became part of the > > HuffmanDecoder class as getTargetWordFromID > > You don't need to build or worry about those tests (there isn't a > > Jamfile in that directory) I still don't have __proper__ tests for > > probingPT. > > Thanks for the quick response! > > If they're not being built, maybe it's better to delete both the tests > in ProbingPT/tess/ then, so that they don't give people a false sense of > security? > > They'll still be in revision control if you want to refer to them for > writing new tests. Somebody else who wants to write tests won't know > that, but in my experience, it's often better for people to start from > scratch in that situation anyway. > > > Jeroen > ___ Moses-support mailing list Moses-support@mit.edu http://mailman.mit.edu/mailman/listinfo/moses-support
Re: [Moses-support] ProbingPT tests not building
On 01/04/15 22:29, Nikolay Bogoychev wrote: > Those tests are indeed obsolete, I used them to test some behavior when > I was building probingPT but the function in question became part of the > HuffmanDecoder class as getTargetWordFromID > You don't need to build or worry about those tests (there isn't a > Jamfile in that directory) I still don't have __proper__ tests for > probingPT. Thanks for the quick response! If they're not being built, maybe it's better to delete both the tests in ProbingPT/tess/ then, so that they don't give people a false sense of security? They'll still be in revision control if you want to refer to them for writing new tests. Somebody else who wants to write tests won't know that, but in my experience, it's often better for people to start from scratch in that situation anyway. Jeroen ___ Moses-support mailing list Moses-support@mit.edu http://mailman.mit.edu/mailman/listinfo/moses-support
Re: [Moses-support] ProbingPT tests not building
Hey Jeroen, Those tests are indeed obsolete, I used them to test some behavior when I was building probingPT but the function in question became part of the HuffmanDecoder class as getTargetWordFromID You don't need to build or worry about those tests (there isn't a Jamfile in that directory) I still don't have __proper__ tests for probingPT. Cheers, Nick On Wed, Apr 1, 2015 at 2:39 PM, Jeroen Vermeulen < j...@precisiontranslationtools.com> wrote: > Here's another case where I may be breaking things because I'm building > manually, or something might be genuinely wrong. For me, > moses/TranslationModel/ProbingPT/tests/vocabid_test.cpp doesn't build. > > The problem is that main() calls getStringFromID(), which is not defined > anywhere in the codebase that I can see. Obsolete test? > > > Jeroen > ___ > Moses-support mailing list > Moses-support@mit.edu > http://mailman.mit.edu/mailman/listinfo/moses-support > ___ Moses-support mailing list Moses-support@mit.edu http://mailman.mit.edu/mailman/listinfo/moses-support
[Moses-support] ProbingPT tests not building
Here's another case where I may be breaking things because I'm building manually, or something might be genuinely wrong. For me, moses/TranslationModel/ProbingPT/tests/vocabid_test.cpp doesn't build. The problem is that main() calls getStringFromID(), which is not defined anywhere in the codebase that I can see. Obsolete test? Jeroen ___ Moses-support mailing list Moses-support@mit.edu http://mailman.mit.edu/mailman/listinfo/moses-support
