Change in asterixdb[master]: ASTERIXDB-1088: fixed a secondary index compact issue
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1088: fixed a secondary index compact issue .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/487/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1123 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide9191fce61b767c08d2298070e64d455ee34f0b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Closed] (ASTERIXDB-1577) Confusing error message when conditions in where clause reference fields in dataset using dataset's name instead of alias
[
https://issues.apache.org/jira/browse/ASTERIXDB-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yingyi Bu closed ASTERIXDB-1577.
Resolution: Fixed
The query is an invalid one.
Fixed error handling and added a regression test.
> Confusing error message when conditions in where clause reference fields in
> dataset using dataset's name instead of alias
> ---
>
> Key: ASTERIXDB-1577
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1577
> Project: Apache AsterixDB
> Issue Type: Bug
> Environment: Master branch with latest commit id:
> bd3a535b171a5cc7486175
>Reporter: Vignesh Raghunathan
>Assignee: Yingyi Bu
> Labels: soon
>
> To reproduce this issue, run the following sqlpp statements:
> {code}
> drop dataverse sampdb if exists;
> create dataverse sampdb;
> use sampdb;
> drop dataset samptable if exists;
> drop type samptabletype if exists;
> create type samptabletype as closed {
> id: int8
> };
> create dataset samptable1(samptabletype) primary key id;
> insert into samptable1 ({'id' : 0});
> insert into samptable1 ({'id' : 1});
> select id
> from samptable1 s2
> where samptable1.id = 1;
> {code}
> {code}
> org.apache.hyracks.algebricks.common.exceptions.AlgebricksException:
> Inappropriate use of function 'dataset'
> at
> org.apache.asterix.runtime.evaluators.common.FunctionManagerImpl.lookupFunction(FunctionManagerImpl.java:46)
> at
> org.apache.asterix.runtime.formats.NonTaggedDataFormat.resolveFunction(NonTaggedDataFormat.java:354)
> at
> org.apache.asterix.jobgen.QueryLogicalExpressionJobGen.createScalarFunctionEvaluatorFactory(QueryLogicalExpressionJobGen.java:137)
> at
> org.apache.asterix.jobgen.QueryLogicalExpressionJobGen.createEvaluatorFactory(QueryLogicalExpressionJobGen.java:108)
> at
> org.apache.hyracks.algebricks.core.algebra.expressions.LogicalExpressionJobGenToExpressionRuntimeProviderAdapter.createEvaluatorFactory(LogicalExpressionJobGenToExpressionRuntimeProviderAdapter.java:41)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:217)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:151)
> at
> org.apache.hyracks.algebricks.core.algebra.expressions.ScalarFunctionCallExpression.accept(ScalarFunctionCallExpression.java:55)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.changeRec(ConstantFoldingRule.java:259)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:183)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:151)
> at
> org.apache.hyracks.algebricks.core.algebra.expressions.ScalarFunctionCallExpression.accept(ScalarFunctionCallExpression.java:55)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.changeRec(ConstantFoldingRule.java:259)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:183)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:151)
> at
> org.apache.hyracks.algebricks.core.algebra.expressions.ScalarFunctionCallExpression.accept(ScalarFunctionCallExpression.java:55)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.transform(ConstantFoldingRule.java:161)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.SelectOperator.acceptExpressionTransform(SelectOperator.java:83)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule.rewritePost(ConstantFoldingRule.java:148)
> at
> org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:126)
> at
> org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:100)
> at
> org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:100)
> at
> org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:100)
> at
> org.apache.hyracks.algebricks.compiler.rewriter.rulecontrollers.SequentialFixpointRuleController.rewriteWithRuleCollection(SequentialFixpointRuleCont
[jira] [Commented] (ASTERIXDB-159) count( dataset('dataset-name') ); should return count
[
https://issues.apache.org/jira/browse/ASTERIXDB-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15442796#comment-15442796
]
ASF subversion and git services commented on ASTERIXDB-159:
---
Commit 8fec331e46539bd85d5988937626b6c8907a9396 in asterixdb's branch
refs/heads/master from [~buyingyi]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=8fec331 ]
ASTERIXDB-1577: fix error handling for field access over a dataset.
- add a rewrite rule to handle unnesting functions that do not appear
in an unnest operator or left outer unnest operator;
- ASTERIXDB-159 is fixed as well.
Change-Id: Id0dc4db91a6251d55dafd734d9ea5bfb6c11c315
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1113
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Yingyi Bu
> count( dataset('dataset-name') ); should return count
> -
>
> Key: ASTERIXDB-159
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-159
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: AsterixDB, Optimizer
>Reporter: Khurram Faraaz
>Assignee: Yingyi Bu
>Priority: Minor
>
> count( dataset('dataset-name') ); should return count
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (ASTERIXDB-159) count( dataset('dataset-name') ); should return count
[
https://issues.apache.org/jira/browse/ASTERIXDB-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yingyi Bu closed ASTERIXDB-159.
---
Resolution: Fixed
Fixed with regression tests.
> count( dataset('dataset-name') ); should return count
> -
>
> Key: ASTERIXDB-159
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-159
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: AsterixDB, Optimizer
>Reporter: Khurram Faraaz
>Assignee: Yingyi Bu
>Priority: Minor
>
> count( dataset('dataset-name') ); should return count
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ASTERIXDB-1577) Confusing error message when conditions in where clause reference fields in dataset using dataset's name instead of alias
[
https://issues.apache.org/jira/browse/ASTERIXDB-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15442795#comment-15442795
]
ASF subversion and git services commented on ASTERIXDB-1577:
Commit 8fec331e46539bd85d5988937626b6c8907a9396 in asterixdb's branch
refs/heads/master from [~buyingyi]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=8fec331 ]
ASTERIXDB-1577: fix error handling for field access over a dataset.
- add a rewrite rule to handle unnesting functions that do not appear
in an unnest operator or left outer unnest operator;
- ASTERIXDB-159 is fixed as well.
Change-Id: Id0dc4db91a6251d55dafd734d9ea5bfb6c11c315
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1113
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Yingyi Bu
> Confusing error message when conditions in where clause reference fields in
> dataset using dataset's name instead of alias
> ---
>
> Key: ASTERIXDB-1577
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1577
> Project: Apache AsterixDB
> Issue Type: Bug
> Environment: Master branch with latest commit id:
> bd3a535b171a5cc7486175
>Reporter: Vignesh Raghunathan
>Assignee: Yingyi Bu
> Labels: soon
>
> To reproduce this issue, run the following sqlpp statements:
> {code}
> drop dataverse sampdb if exists;
> create dataverse sampdb;
> use sampdb;
> drop dataset samptable if exists;
> drop type samptabletype if exists;
> create type samptabletype as closed {
> id: int8
> };
> create dataset samptable1(samptabletype) primary key id;
> insert into samptable1 ({'id' : 0});
> insert into samptable1 ({'id' : 1});
> select id
> from samptable1 s2
> where samptable1.id = 1;
> {code}
> {code}
> org.apache.hyracks.algebricks.common.exceptions.AlgebricksException:
> Inappropriate use of function 'dataset'
> at
> org.apache.asterix.runtime.evaluators.common.FunctionManagerImpl.lookupFunction(FunctionManagerImpl.java:46)
> at
> org.apache.asterix.runtime.formats.NonTaggedDataFormat.resolveFunction(NonTaggedDataFormat.java:354)
> at
> org.apache.asterix.jobgen.QueryLogicalExpressionJobGen.createScalarFunctionEvaluatorFactory(QueryLogicalExpressionJobGen.java:137)
> at
> org.apache.asterix.jobgen.QueryLogicalExpressionJobGen.createEvaluatorFactory(QueryLogicalExpressionJobGen.java:108)
> at
> org.apache.hyracks.algebricks.core.algebra.expressions.LogicalExpressionJobGenToExpressionRuntimeProviderAdapter.createEvaluatorFactory(LogicalExpressionJobGenToExpressionRuntimeProviderAdapter.java:41)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:217)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:151)
> at
> org.apache.hyracks.algebricks.core.algebra.expressions.ScalarFunctionCallExpression.accept(ScalarFunctionCallExpression.java:55)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.changeRec(ConstantFoldingRule.java:259)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:183)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:151)
> at
> org.apache.hyracks.algebricks.core.algebra.expressions.ScalarFunctionCallExpression.accept(ScalarFunctionCallExpression.java:55)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.changeRec(ConstantFoldingRule.java:259)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:183)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.visitScalarFunctionCallExpression(ConstantFoldingRule.java:151)
> at
> org.apache.hyracks.algebricks.core.algebra.expressions.ScalarFunctionCallExpression.accept(ScalarFunctionCallExpression.java:55)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule$ConstantFoldingVisitor.transform(ConstantFoldingRule.java:161)
> at
> org.apache.hyracks.algebricks.core.algebra.operators.logical.SelectOperator.acceptExpressionTransform(SelectOperator.java:83)
> at
> org.apache.asterix.optimizer.rules.ConstantFoldingRule.rewritePost(ConstantFoldingRule.java:148)
> at
> org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(Ab
Change in asterixdb[master]: ASTERIXDB-1577: fix error handling for field access over a d...
Yingyi Bu has submitted this change and it was merged. Change subject: ASTERIXDB-1577: fix error handling for field access over a dataset. .. ASTERIXDB-1577: fix error handling for field access over a dataset. - add a rewrite rule to handle unnesting functions that do not appear in an unnest operator or left outer unnest operator; - ASTERIXDB-159 is fixed as well. Change-Id: Id0dc4db91a6251d55dafd734d9ea5bfb6c11c315 Reviewed-on: https://asterix-gerrit.ics.uci.edu/1113 Sonar-Qube: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Yingyi Bu --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ListifyUnnestingFunctionRule.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/aggregate/count-dataset.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/aggregate/list-dataset.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-159-3.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/count-dataset.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/list-dataset.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-159-3.plan A asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.4.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/global-aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/global-aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/global-aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/global-aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-range/list-range.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-2/query-ASTERIXDB-159-2.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-2/query-ASTERIXDB-159-2.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-2/query-ASTERIXDB-159-2.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-2/query-ASTERIXDB-159-2.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-3/query-ASTERIXDB-159-3.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-3/query-ASTERIXDB-159-3.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-3/query-ASTERIXDB-159-3.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-3/query-ASTERIXDB-159-3.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1577/query-ASTERIXDB-1577.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1577/query-ASTERIXDB-1577.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1577/query-ASTERIXDB-1577.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1577/query-ASTERIXDB-1577.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/global-aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/list/list-range/list-range.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/list/query-ASTERIXDB-159-2/query-ASTERIXDB-159-2.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/list/query-ASTERIXDB-159-3/query-ASTERIXDB-159-3.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml 36 files changed, 902 insertions(+), 1 deletion(-) Approvals: Yingyi Bu: Looks good to me, approved Jenkins: Verified; No violations found; Verified diff --gi
Change in asterixdb[master]: ASTERIXDB-1577: fix error handling for field access over a d...
Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1577: fix error handling for field access over a dataset. .. Patch Set 8: Code-Review+2 Fwd Till's +2. -- To view, visit https://asterix-gerrit.ics.uci.edu/1113 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0dc4db91a6251d55dafd734d9ea5bfb6c11c315 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1088: fixed a secondary index compact issue
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1088: fixed a secondary index compact issue .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/487/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1123 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide9191fce61b767c08d2298070e64d455ee34f0b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Remove Unused Duplicated Class
Jenkins has posted comments on this change. Change subject: Remove Unused Duplicated Class .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/486/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1122 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I103b6e063d85b9e2659371fb341ed6f234ae3547 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1577: fix error handling for field access over a d...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1577: fix error handling for field access over a dataset. .. Patch Set 8: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/485/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1113 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0dc4db91a6251d55dafd734d9ea5bfb6c11c315 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1088: fixed a secondary index compact issue
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1088: fixed a secondary index compact issue .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2425/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1123 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide9191fce61b767c08d2298070e64d455ee34f0b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1088: fixed a secondary index compact issue
Taewoo Kim has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1123
Change subject: ASTERIXDB-1088: fixed a secondary index compact issue
..
ASTERIXDB-1088: fixed a secondary index compact issue
- Secondary index is now properly compacted
Change-Id: Ide9191fce61b767c08d2298070e64d455ee34f0b
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/23/1123/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index 24c678c..6390b9d 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@ -2487,9 +2487,14 @@
if (ds.getDatasetType() == DatasetType.INTERNAL) {
for (int j = 0; j < indexes.size(); j++) {
if (indexes.get(j).isSecondaryIndex()) {
-jobsToExecute
-.add(DatasetOperations.compactDatasetJobSpec(
-dataverse, datasetName,
metadataProvider));
+CompiledIndexCompactStatement cics = new
CompiledIndexCompactStatement(dataverseName,
+datasetName, indexes.get(j).getIndexName(),
indexes.get(j).getKeyFieldNames(),
+indexes.get(j).getKeyFieldTypes(),
indexes.get(j).isEnforcingKeyFileds(),
+indexes.get(j).getGramLength(),
indexes.get(j).getIndexType());
+List keySourceIndicators =
indexes.get(j).getKeyFieldSourceIndicators();
+
+
jobsToExecute.add(IndexOperations.buildSecondaryIndexCompactJobSpec(cics,
aRecordType,
+metaRecordType, keySourceIndicators,
enforcedType, metadataProvider));
}
}
} else {
--
To view, visit https://asterix-gerrit.ics.uci.edu/1123
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide9191fce61b767c08d2298070e64d455ee34f0b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim
[jira] [Commented] (ASTERIXDB-1088) handleCompactStatement() in AqlTranslator.java has a bug
[
https://issues.apache.org/jira/browse/ASTERIXDB-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15442734#comment-15442734
]
Taewoo Kim commented on ASTERIXDB-1088:
---
This has not been fixed yet. Based on Young-Seok's proposed code above, line
2,487 in
https://github.com/apache/asterixdb/blob/master/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
needs to be changed.
{code}
if (ds.getDatasetType() == DatasetType.INTERNAL) {
for (int j = 0; j < indexes.size(); j++) {
if (indexes.get(j).isSecondaryIndex()) {
jobsToExecute
.add(DatasetOperations.compactDatasetJobSpec(
dataverse, datasetName,
metadataProvider));
}
}
}
{code}
should be changed as follows:
{code}
if (ds.getDatasetType() == DatasetType.INTERNAL) {
for (int j = 0; j < indexes.size(); j++) {
if (indexes.get(j).isSecondaryIndex()) {
CompiledIndexCompactStatement cics = new
CompiledIndexCompactStatement(dataverseName,
datasetName, indexes.get(j).getIndexName(),
indexes.get(j).getKeyFieldNames(),
indexes.get(j).getKeyFieldTypes(),
indexes.get(j).isEnforcingKeyFileds(),
indexes.get(j).getGramLength(),
indexes.get(j).getIndexType());
List keySourceIndicators =
indexes.get(j).getKeyFieldSourceIndicators();
jobsToExecute.add(IndexOperations.buildSecondaryIndexCompactJobSpec(cics,
aRecordType,
metaRecordType, keySourceIndicators,
enforcedType, metadataProvider));
}
}
}
{code}
> handleCompactStatement() in AqlTranslator.java has a bug
>
>
> Key: ASTERIXDB-1088
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1088
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: AsterixDB, Storage, Translator - AQL
>Reporter: Young-Seok Kim
>Assignee: Taewoo Kim
> Labels: soon
>
> The following code in handleCompactStatement() in AqlTranslator.java
> (https://github.com/apache/incubator-asterixdb/blob/master/asterix-app/src/main/java/org/apache/asterix/aql/translator/AqlTranslator.java)
> 1) doesn't compact secondary indexes if any
> 2) instead compact primary index as many as the number of secondary indexes.
> from line 2421.
> if (ds.getDatasetType() == DatasetType.INTERNAL) {
> for (int j = 0; j < indexes.size(); j++) {
> if (indexes.get(j).isSecondaryIndex()) {
> CompiledIndexCompactStatement cics = new
> CompiledIndexCompactStatement(dataverseName,
> datasetName, indexes.get(j).getIndexName(),
> indexes.get(j).getKeyFieldNames(), indexes
> .get(j).getKeyFieldTypes(),
> indexes.get(j).isEnforcingKeyFileds(), indexes.get(
> j).getGramLength(),
> indexes.get(j).getIndexType());
> Dataverse dataverse =
> MetadataManager.INSTANCE.getDataverse(
> metadataProvider.getMetadataTxnContext(),
> dataverseName);
>
> jobsToExecute.add(DatasetOperations.compactDatasetJobSpec(dataverse,
> datasetName,
> metadataProvider));
> }
> }
> The code should fixed something as follows:
> if (ds.getDatasetType() == DatasetType.INTERNAL) {
> for (int j = 0; j < indexes.size(); j++) {
> if (indexes.get(j).isSecondaryIndex()) {
>
> CompiledIndexCompactStatement cics = new
> CompiledIndexCompactStatement(dataverseName,
> datasetName, indexes.get(j).getIndexName(),
> indexes.get(j).getKeyFieldNames(),
> indexes.get(j).getKeyFieldTypes(),
> indexes.get(j).getIndexType(), null,
> indexes.get(j).isEnforcingKeyFileds());
>
> jobsToExecute.add(IndexOperations.buildSecondaryIndexCompactJobSpec(cics,
> metadataProvider, ds));
> }
> }
> Dataverse dataverse = MetadataManager.INSTANCE.getDataverse(
> metadataProvider.getMetadataTxnContext(),
> dataverseName);
>
> jobsToExecute.add(DatasetOperations.compactDatasetJobSpec(dataverse,
> datasetName,
>
Change in asterixdb[master]: Remove Unused Duplicated Class
Jenkins has posted comments on this change. Change subject: Remove Unused Duplicated Class .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/486/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1122 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I103b6e063d85b9e2659371fb341ed6f234ae3547 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1577: fix error handling for field access over a d...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1577: fix error handling for field access over a dataset. .. Patch Set 8: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/485/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1113 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0dc4db91a6251d55dafd734d9ea5bfb6c11c315 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Remove Unused Duplicated Class
Jenkins has posted comments on this change. Change subject: Remove Unused Duplicated Class .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2424/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1122 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I103b6e063d85b9e2659371fb341ed6f234ae3547 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Remove Unused Duplicated Class
Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1122
Change subject: Remove Unused Duplicated Class
..
Remove Unused Duplicated Class
Change-Id: I103b6e063d85b9e2659371fb341ed6f234ae3547
---
D
asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/error/OutputHandler.java
1 file changed, 0 insertions(+), 96 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/22/1122/1
diff --git
a/asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/error/OutputHandler.java
b/asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/error/OutputHandler.java
deleted file mode 100644
index 4c83706..000
---
a/asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/error/OutputHandler.java
+++ /dev/null
@@ -1,96 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.asterix.installer.error;
-
-import java.io.ByteArrayInputStream;
-import java.io.IOException;
-import java.util.Properties;
-
-import org.apache.asterix.event.management.IOutputHandler;
-import org.apache.asterix.event.management.OutputAnalysis;
-import org.apache.asterix.event.model.EventList.EventType;
-import org.apache.asterix.event.schema.pattern.Event;
-
-public class OutputHandler implements IOutputHandler {
-
-public static IOutputHandler INSTANCE = new OutputHandler();
-
-private OutputHandler() {
-
-}
-
-@Override
-public OutputAnalysis reportEventOutput(Event event, String output) {
-
-EventType eventType = EventType.valueOf(event.getType().toUpperCase());
-boolean ignore = true;
-String trimmedOutput = output.trim();
-StringBuffer errorMessage = new StringBuffer();
-switch (eventType) {
-case FILE_TRANSFER:
-if (trimmedOutput.length() > 0) {
-if (output.contains("Permission denied") ||
output.contains("cannot find or open")) {
-ignore = false;
-break;
-}
-}
-break;
-
-case BACKUP:
-case RESTORE:
-if (trimmedOutput.length() > 0) {
-if (trimmedOutput.contains("AccessControlException")) {
-errorMessage.append("Insufficient permissions on back
up directory");
-ignore = false;
-}
-if (output.contains("does not exist") ||
output.contains("File exist")
-|| (output.contains("No such file or directory")))
{
-ignore = true;
-} else {
-ignore = false;
-}
-}
-break;
-
-case NODE_INFO:
-Properties p = new Properties();
-try {
-p.load(new ByteArrayInputStream(trimmedOutput.getBytes()));
-} catch (IOException e) {
-}
-String javaVersion = (String) p.get("java_version");
-if (p.get("java_version") == null) {
-errorMessage.append("Java not installed on " +
event.getNodeid().getValue().getAbsvalue());
-ignore = false;
-} else if (!javaVersion.contains("1.7")) {
-errorMessage.append("Asterix requires Java 1.7.x.
Incompatible version found on "
-+ event.getNodeid().getValue().getAbsvalue() +
"\n");
-ignore = false;
-}
-break;
-default:
-break;
-}
-if (ignore) {
-return new OutputAnalysis(true, null);
-} else {
-return new OutputAnalysis(false, errorMessage.toString());
-}
-}
-}
--
To view, visit https://asterix-gerrit.ics.uci.edu/1122
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I103b6e063d85b9e2659371fb341ed6f234ae3547
Gerrit-PatchSet
Change in asterixdb[master]: ASTERIXDB-1577: fix error handling for field access over a d...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1577: fix error handling for field access over a dataset. .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2423/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1113 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0dc4db91a6251d55dafd734d9ea5bfb6c11c315 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1577: fix error handling for field access over a d...
Hello Till Westmann, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1113 to look at the new patch set (#8). Change subject: ASTERIXDB-1577: fix error handling for field access over a dataset. .. ASTERIXDB-1577: fix error handling for field access over a dataset. - add a rewrite rule to handle unnesting functions that do not appear in an unnest operator or left outer unnest operator; - ASTERIXDB-159 is fixed as well. Change-Id: Id0dc4db91a6251d55dafd734d9ea5bfb6c11c315 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ListifyUnnestingFunctionRule.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/aggregate/count-dataset.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/aggregate/list-dataset.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-159-3.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/count-dataset.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/list-dataset.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-159-3.plan A asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.4.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/global-aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/global-aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/global-aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/global-aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/list-range/list-range.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-2/query-ASTERIXDB-159-2.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-2/query-ASTERIXDB-159-2.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-2/query-ASTERIXDB-159-2.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-2/query-ASTERIXDB-159-2.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-3/query-ASTERIXDB-159-3.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-3/query-ASTERIXDB-159-3.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-3/query-ASTERIXDB-159-3.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/query-ASTERIXDB-159-3/query-ASTERIXDB-159-3.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1577/query-ASTERIXDB-1577.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1577/query-ASTERIXDB-1577.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1577/query-ASTERIXDB-1577.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1577/query-ASTERIXDB-1577.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/global-aggregate/query-ASTERIXDB-159/query-ASTERIXDB-159.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/list/list-range/list-range.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/list/query-ASTERIXDB-159-2/query-ASTERIXDB-159-2.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/list/query-ASTERIXDB-159-3/query-ASTERIXDB-159-3.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml 36 files changed, 902 insertions(+), 1 deletion(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/13/1113/8 -- To view, visit https://asterix-gerrit.ics.uci.edu/1113 To unsubsc
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1611: reasonable names for threads .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/484/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1611: reasonable names for threads .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/484/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: minor console changes
Michael Blow has posted comments on this change.
Change subject: minor console changes
..
Patch Set 2:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1120/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java
File
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java:
Line 295: o.put("classpath", new
JSONArray(Arrays.asList(classpath.split(":";
File.pathSeparator? (e.g. Windows) (same for next two)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1120
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ec6b38e122f1c206f431d3902ad9039adce5078
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Yingyi Bu
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1611: reasonable names for threads .. Patch Set 7: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1611: reasonable names for threads .. Patch Set 6: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1092 to look at the new patch set (#7). Change subject: ASTERIXDB-1611: reasonable names for threads .. ASTERIXDB-1611: reasonable names for threads Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java 7 files changed, 29 insertions(+), 24 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/92/1092/7 -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1611: reasonable names for threads .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2422/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Add Flag To ExecutionTest To Enable Test Repeats
Michael Blow has submitted this change and it was merged.
Change subject: Add Flag To ExecutionTest To Enable Test Repeats
..
Add Flag To ExecutionTest To Enable Test Repeats
- Also, fix tests to be able to be repeated
Change-Id: Ib263ff475bb7640bb3b4309e6804e4ab2e2702fb
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1121
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Till Westmann
---
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/query-issue382/query-issue382.1.ddl.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/query-issue433/query-issue433.1.ddl.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/similarity/similarity-jaccard-sorted-check_query/similarity-jaccard-sorted-check_query.1.ddl.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/query-issue382/query-issue382.1.ddl.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/query-issue433/query-issue433.1.ddl.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/similarity/similarity-jaccard-sorted-check_query/similarity-jaccard-sorted-check_query.1.ddl.sqlpp
7 files changed, 25 insertions(+), 2 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
index baa3923..adc691f 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
@@ -55,6 +55,7 @@
private static final boolean cleanupOnStart = true;
private static final boolean cleanupOnStop = true;
private static TestLibrarian librarian;
+private static final int repeat = Integer.getInteger("test.repeat", 1);
@BeforeClass
public static void setUp() throws Exception {
@@ -66,6 +67,9 @@
List libraryManagers =
ExecutionTestUtil.setUp(cleanupOnStart);
librarian = new TestLibrarian(libraryManagers);
testExecutor.setLibrarian(librarian);
+if (repeat != 1) {
+System.out.println("FYI: each test will be run " + repeat + "
times.");
+}
} catch (Throwable th) {
th.printStackTrace();
throw th;
@@ -106,7 +110,16 @@
@Test
public void test() throws Exception {
-librarian.cleanup();
-testExecutor.executeTest(PATH_ACTUAL, tcCtx, null, false,
ExecutionTestUtil.FailedGroup);
+try {
+for (int i = 1; i <= repeat; i++) {
+if (repeat > 1) {
+System.err.print("[" + i + "/" + repeat + "] ");
+}
+librarian.cleanup();
+testExecutor.executeTest(PATH_ACTUAL, tcCtx, null, false,
ExecutionTestUtil.FailedGroup);
+}
+} finally {
+System.err.flush();
+}
}
}
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/query-issue382/query-issue382.1.ddl.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/query-issue382/query-issue382.1.ddl.aql
index 4838505..4568a83 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/query-issue382/query-issue382.1.ddl.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/query-issue382/query-issue382.1.ddl.aql
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+drop dataverse SocialNetworkData if exists;
create dataverse SocialNetworkData;
use dataverse SocialNetworkData;
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/query-issue433/query-issue433.1.ddl.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/query-issue433/query-issue433.1.ddl.aql
index 85efa49..87970ef 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/query-issue433/query-issue433.1.ddl.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/query-issue433/query-issue433.1.ddl.aql
@@ -23,6 +23,7 @@
* Date : 3th April 2013
*/
+drop dataverse insertIssue if exists;
create dataverse insertIssue;
use dataverse insertIssue;
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/similarity/similarity-jaccard-sorted-check_query/similarity-jaccard-sorted-check_query.1.ddl.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/similarity/similarity-jaccard-sorted-check_query/similarity-jaccard-sorted-check_query.1.ddl.aql
index 8b171ed..0426ae
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Till Westmann has posted comments on this change.
Change subject: ASTERIXDB-1611: reasonable names for threads
..
Patch Set 5:
(5 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1092/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java:
Line 206: LOGGER.severe("Global recovery was not
completed successfully: " + e);
> Can we not lose the exception, i.e. LOGGER.severe(msg + e); -> LOGGER.log(L
Done
Line 211: LOGGER.severe("Exception in aborting"
+ e.getMessage());
> same as above
Done
Line 222: while (recoveryThread.isAlive()) {
> I assume it's OK to block until recovery has completed? Should we rename t
I'm actually not sure if it's ok/desirable. Need to understand the lifecycle
better ...
https://asterix-gerrit.ics.uci.edu/#/c/1092/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
File
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java:
Line 251: Iterator iter = nodeNames.iterator();
> for (String nodeName : nodeNames) ...?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1092/5/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
File
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java:
Line 105: setName("Worker" + super.getName());
> will these names potentially be confusing since the numbers will be indepen
As there's only one thread per queue, I've added an identifier for the queue
and derive the thread name from the identifier.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1092
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1611: reasonable names for threads .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2421/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1092 to look at the new patch set (#6). Change subject: ASTERIXDB-1611: reasonable names for threads .. ASTERIXDB-1611: reasonable names for threads Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java 7 files changed, 30 insertions(+), 24 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/92/1092/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: ASTERIXDB-1577: fix error handling for field access over a d...
Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1577: fix error handling for field access over a dataset. .. Patch Set 7: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1113 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0dc4db91a6251d55dafd734d9ea5bfb6c11c315 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Add Flag To ExecutionTest To Enable Test Repeats
Till Westmann has posted comments on this change. Change subject: Add Flag To ExecutionTest To Enable Test Repeats .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1121 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib263ff475bb7640bb3b4309e6804e4ab2e2702fb Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Michael Blow has posted comments on this change.
Change subject: ASTERIXDB-1611: reasonable names for threads
..
Patch Set 5:
(5 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1092/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java:
Line 206: LOGGER.severe("Global recovery was not
completed successfully: " + e);
Can we not lose the exception, i.e. LOGGER.severe(msg + e); ->
LOGGER.log(Level.SEVERE, msg, e);
Line 211: LOGGER.severe("Exception in aborting"
+ e.getMessage());
same as above
Line 222: while (recoveryThread.isAlive()) {
I assume it's OK to block until recovery has completed? Should we rename this
API to runGlobalRecovery instead of startGlobalRecovery?
https://asterix-gerrit.ics.uci.edu/#/c/1092/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
File
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java:
Line 251: Iterator iter = nodeNames.iterator();
for (String nodeName : nodeNames) ...?
https://asterix-gerrit.ics.uci.edu/#/c/1092/5/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
File
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java:
Line 105: setName("Worker" + super.getName());
will these names potentially be confusing since the numbers will be independent
of the number of worker threads?
--
To view, visit https://asterix-gerrit.ics.uci.edu/1092
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-HasComments: Yes
Change in asterixdb[master]: AsterixDB Schema Inferencer
Jenkins has posted comments on this change. Change subject: AsterixDB Schema Inferencer .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2420/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6077216ba457a182e8034ed47536fc5f4dcb639 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: AsterixDB Schema Inferencer
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1003 to look at the new patch set (#5). Change subject: AsterixDB Schema Inferencer .. AsterixDB Schema Inferencer Add schema builder to the clean JSON output format. Change-Id: Ia6077216ba457a182e8034ed47536fc5f4dcb639 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultSchemaAPIServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java M asterixdb/asterix-app/src/main/resources/webui/querytemplate.html M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/app/SessionConfig.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/IApplicationMessage.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/SchemaUtils.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java M asterixdb/asterix-om/pom.xml A asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/schema/AFlatPrinterFactory.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/schema/AObjectPrinterFactory.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/schema/AOptionalFieldPrinterFactory.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/schema/AOrderedlistPrinterFactory.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/schema/ARecordPrinterFactory.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/schema/AUnionPrinterFactory.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/schema/AUnorderedlistPrinterFactory.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/schema/AbstractPrinterWithSchemaFactory.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/schema/IPrinterWithSchemaFactory.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/base/IDataFormat.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlCleanJSONWithSchemaPrinterFactoryProvider.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/AListPrinter.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/json/clean/schema/AListPrinterSchema.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/json/clean/schema/APrintVisitor.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/json/clean/schema/ARecordPrinterSchema.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/schema/builder/HeterogeneousTypeComputerLoader.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/schema/builder/SchemaBuilder.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/formats/NonTaggedDataFormat.java A asterixdb/asterix-schema-spark/pom.xml A asterixdb/asterix-schema-spark/src/main/java/org/apache/asterix/schema/spark/SparkHeterogeneousTypeComputer.java A asterixdb/asterix-schema/pom.xml A asterixdb/asterix-schema/src/main/java/org/apache/asterix/schema/message/SchemaMessage.java A asterixdb/asterix-schema/src/main/java/org/apache/asterix/schema/message/SchemaRegisterMessage.java A asterixdb/asterix-schema/src/main/java/org/apache/asterix/schema/node/AbstractNestedSchemaNode.java A asterixdb/asterix-schema/src/main/java/org/apache/asterix/schema/node/AbstractSchemaNode.java A asterixdb/asterix-schema/src/main/java/org/apache/asterix/schema/node/FlatSchemaNode.java A asterixdb/asterix-schema/src/main/java/org/apache/asterix/schema/node/IHeterogeneousTypeComputer.java A asterixdb/asterix-schema/src/mai
Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...
Wenhai Li has posted comments on this change.
Change subject: Applied the multiway fuzzyjoin based on the prefix-based join
and the selectFuzzyJoin testCases.
..
Patch Set 4:
(8 comments)
@Tawoo
Will patch those issues soon.
https://asterix-gerrit.ics.uci.edu/#/c/1076/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AsterixExtractFunctionsFromJoinConditionRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AsterixExtractFunctionsFromJoinConditionRule.java:
Line 45: public class AsterixExtractFunctionsFromJoinConditionRule extends
ExtractFunctionsFromJoinConditionRule {
> Can we put detailed explanation here? What does this rule do and why it is
Done
https://asterix-gerrit.ics.uci.edu/#/c/1076/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java:
Line 124: // GROUPBY_LEFT, GROUPBY_RIGHT
> If the group_by will be added later, we can remove this comment.
Done
Line 129: // JOIN_COND_RIGHT JOIN_COND_LEFT
> This too.
Done
Line 157: // Currently, we limit the prefix based fuzzy join times so
as to restrict the memory assumption.
> Remove this comment.
Done
Line 220: // Avoid the duplicated pk generation in
findPrimaryKeysInSubplan, especially for multiway fuzzy join.
> Can we put an example here?
We can exemplify this offline?
https://asterix-gerrit.ics.uci.edu/#/c/1076/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java:
Line 256: public class InlineSubplanInputForNestedTupleSourceRule implements
IAlgebraicRewriteRule {
> Why does "hasRun" boolean variable need to be deleted?
Omm, if the subplan is inlined by another subplan, this rule will return
directly, without further handling the subplan. Once we setup multiple join
more than three-way, this issue will make the generated plan nested and will
result in group by inlined by subplan error in algebricks.
https://asterix-gerrit.ics.uci.edu/#/c/1076/4/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractFunctionsFromJoinConditionRule.java
File
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractFunctionsFromJoinConditionRule.java:
Line 66: throws AlgebricksException {
> Format issue? There is no actual change. You may replace this file with the
Done
Line 108: new
MutableObject(exprRef.getValue().cloneExpression()));
> Format issue? There is no actual change. You may replace this file with the
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Taewoo Kim
Gerrit-Reviewer: Wenhai Li
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1611: reasonable names for threads .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/483/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1611: reasonable names for threads
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1611: reasonable names for threads .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/483/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
