date:20170718

[Jenkins] FAILURE: CouchDB » jenkins-build-packages #42

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. 
https://builds.apache.org/job/CouchDB/job/jenkins-build-packages/42/

[Jenkins] FAILURE: CouchDB » jenkins-build-packages #43

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. 
https://builds.apache.org/job/CouchDB/job/jenkins-build-packages/43/

[GitHub] wohali commented on issue #689: Replications can reuse http-based endpoints after upgrading to https

2017-07-18 Thread git

wohali commented on issue #689:  Replications can reuse http-based endpoints 
after upgrading to https
URL: https://github.com/apache/couchdb/pull/689#issuecomment-315977664
 
 
   Please hold this until after the 2.1 release. I'd like to keep master clean 
until we re-fork for 2.1.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Jenkins] FAILURE: CouchDB » jenkins-build-packages #44

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. 
https://builds.apache.org/job/CouchDB/job/jenkins-build-packages/44/

[Jenkins] FAILURE: CouchDB » jenkins-build-packages #46

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. 
https://builds.apache.org/job/CouchDB/job/jenkins-build-packages/46/

[Jenkins] FAILURE: CouchDB » jenkins-build-packages #47

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. 
https://builds.apache.org/job/CouchDB/job/jenkins-build-packages/47/

[Jenkins] FAILURE: CouchDB » jenkins-build-packages #48

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. 
https://builds.apache.org/job/CouchDB/job/jenkins-build-packages/48/

[GitHub] wohali opened a new pull request #690: fix double export of wait_updated/3

2017-07-18 Thread git

wohali opened a new pull request #690: fix double export of wait_updated/3
URL: https://github.com/apache/couchdb/pull/690
 
 
   "couch_changes.erl:33: Warning: function wait_updated/3 already exported"
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Jenkins] SUCCESS: CouchDB » jenkins-packages-2 #1

2017-07-18 Thread Apache Jenkins Server

Yay, we passed. https://builds.apache.org/job/CouchDB/job/jenkins-packages-2/1/

[jira] [Commented] (COUCHDB-3337) End-point _local_docs doesn't conform to query params of _all_docs

2017-07-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/COUCHDB-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091235#comment-16091235
 ] 

ASF subversion and git services commented on COUCHDB-3337:
--

Commit c40f66d06bafbeb2e04c989e1a3ecfe5c034fde4 in couchdb's branch 
refs/heads/jenkins-packages-2 from [~eiri]
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=c40f66d0 ]

Fix _local_docs end-point

This is a second attempt to fix _local_docs end-point. The previous one didn't
work on big enough btree_local, because local btree doesn't have reduction fun,
so reuse of couch_db_updater:btree_by_id_reduce/2 was crashing on a bad match
as soon as btree_local was getting kp_node. Also using full fold to calculate
total_rows value turned out to be resource expensive when a database have
significant number of local documents.

This fix avoids calculating of total_rows and offset instead always setting
them to null and also setting to null update_seq when requested, since it
doesn't have meaning in context of local documents.

A fabric module fabric_view_all_docs.erl was copied and modified as
fabric_view_local_docs.erl, because re-using it for processing of both types of
the documents was getting rather convoluted.

Jira: COUCHDB-3337


> End-point _local_docs doesn't conform to query params of _all_docs
> --
>
> Key: COUCHDB-3337
> URL: https://issues.apache.org/jira/browse/COUCHDB-3337
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Eric Avdey
>Assignee: Eric Avdey
>
> There are following issues with {{/db/_local_doc end-point}}
> # It ignores include_docs parameter
> # It reports incorrect total_rows value, returning total rows of non-local 
> docs instead
> # It crashes with {{badrecord}} {{full_doc_info}} when query trying to skip 
> records



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[Jenkins] FAILURE: CouchDB » jenkins-packages-2 #3

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. https://builds.apache.org/job/CouchDB/job/jenkins-packages-2/3/

[GitHub] glynnbird opened a new pull request #53: bring follow library under Nano's wing

2017-07-18 Thread git

glynnbird opened a new pull request #53: bring follow library under Nano's wing
URL: https://github.com/apache/couchdb-nano/pull/53
 
 
   ## Overview
   
   Currently Nano uses a the [follow](https://www.npmjs.com/package/follow) 
library as a dependency to handle changes feed subscription. Unfortunately, 
`follow` is not maintained. The nice people at Cloudant have taken the code and 
fixed it up and published it 
[here](https://github.com/cloudant-labs/cloudant-follow).  This 
[PR](https://github.com/apache/couchdb-nano/pull/51) proposes to depend on the  
cloudant-follow fork, but I am proposing something different:
   
   1) Bring the follow codebase into the Nano project (it is published under an 
Apache-2.0 license)
   2) Remove follow as a dependency
   3) In the future refactor the follow code to be more in keeping with the 
   
   ## Testing recommendations
   
   This should be a drop-in replacement of the previous version. The only 
difference is that the `follow` code lives in this repo and not as a dependency.
   
   I've brought in the `follow` tests too. Unfortunately they rely on 
CouchDB1.6 so I've altered the testing sequence to run our core tests with 
CouchDB2 then switch over to CouchDB1.6 for the follow tests.
   
   See `npm run coretests` & `npm run followtests` in package.json.
   
   ## GitHub issue number
   
   
   
   ## Related Pull Requests
   
   See issue #28 & pull #51 
   
   ## Checklist
   
   - [x ] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x ] Documentation reflects the changes;
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SinanGabel commented on issue #53: bring follow library under Nano's wing

2017-07-18 Thread git

SinanGabel commented on issue #53: bring follow library under Nano's wing
URL: https://github.com/apache/couchdb-nano/pull/53#issuecomment-316040321
 
 
   Really good plan!
   
   On 18 July 2017 at 13:41, Glynn Bird  wrote:
   
   > Overview
   >
   > Currently Nano uses a the follow 
   > library as a dependency to handle changes feed subscription. Unfortunately,
   > follow is not maintained. The nice people at Cloudant have taken the code
   > and fixed it up and published it here
   > . This PR
   >  proposes to depend on
   > the cloudant-follow fork, but I am proposing something different:
   >
   >1. Bring the follow codebase into the Nano project (it is published
   >under an Apache-2.0 license)
   >2. Remove follow as a dependency
   >3. In the future refactor the follow code to be more in keeping with
   >the
   >
   > Testing recommendations
   >
   > This should be a drop-in replacement of the previous version. The only
   > difference is that the follow code lives in this repo and not as a
   > dependency.
   >
   > I've brought in the follow tests too. Unfortunately they rely on
   > CouchDB1.6 so I've altered the testing sequence to run our core tests with
   > CouchDB2 then switch over to CouchDB1.6 for the follow tests.
   >
   > See npm run coretests & npm run followtests in package.json.
   > GitHub issue number Related Pull Requests
   >
   > See issue #28  & pull
   > #51 
   > Checklist
   >
   >- [x ] Code is written and works correctly;
   >- Changes are covered by tests;
   >- [x ] Documentation reflects the changes;
   >
   > --
   > You can view, comment on, or merge this pull request online at:
   >
   >   https://github.com/apache/couchdb-nano/pull/53
   > Commit Summary
   >
   >- bring follow library under Nano's wing
   >
   > File Changes
   >
   >- *M* README.md
   > (7)
   >- *A* follow.md
   > (210)
   >- *A* follow_tests/couch.js
   > (176)
   >- *A* follow_tests/follow.js
   > (258)
   >- *A* follow_tests/issues.js
   > (92)
   >- *A* follow_tests/stream.js
   > (574)
   >- *A* lib/follow/api.js
   > (35)
   >- *A* lib/follow/lib/feed.js
   > (694)
   >- *A* lib/follow/lib/index.js
   > (51)
   >- *A* lib/follow/lib/stream.js
   > (312)
   >- *M* lib/nano.js
   > (2)
   >- *M* package.json
   > (12)
   >- *A* scripts/run_couchdb16_on_travis.sh
   > (13)
   >- *A* scripts/stop_couchdb16_on_travis.sh
   > (7)
   >
   > Patch Links:
   >
   >- https://github.com/apache/couchdb-nano/pull/53.patch
   >- https://github.com/apache/couchdb-nano/pull/53.diff
   >
   > ?
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > , or mute the thread
   > 

   > .
   >
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SCdF opened a new issue #54: socket hangup on db.list with large numbers of ids

2017-07-18 Thread git

SCdF opened a new issue #54: socket hangup on db.list with large numbers of ids
URL: https://github.com/apache/couchdb-nano/issues/54
 
 
   ## Expected Behavior
   The `db.list` function should return doc metadata based on the ids you pass 
it, if any.
   
   ## Current Behavior
   With large numbers of docs you instead get:
   ```
   > { Error: socket hang up
   at createHangUpError (_http_client.js:254:15)
   at Socket.socketOnEnd (_http_client.js:346:23)
   at emitNone (events.js:91:20)
   at Socket.emit (events.js:185:7)
   at endReadableNT (_stream_readable.js:974:12)
   at _combinedTickCallback (internal/process/next_tick.js:74:11)
   at process._tickDomainCallback (internal/process/next_tick.js:122:9)
 name: 'Error',
 scope: 'socket',
 errid: 'request',
 code: 'ECONNRESET',
 description: 'socket hang up',
 stacktrace:
  [ 'Error: socket hang up',
'at createHangUpError (_http_client.js:254:15)',
'at Socket.socketOnEnd (_http_client.js:346:23)',
'at emitNone (events.js:91:20)',
'at Socket.emit (events.js:185:7)',
'at endReadableNT (_stream_readable.js:974:12)',
'at _combinedTickCallback (internal/process/next_tick.js:74:11)',
'at process._tickDomainCallback 
(internal/process/next_tick.js:122:9)' ] }
   ```
   
   ## Steps to Reproduce (for bugs)
   Run this (modifying as needed for your local env etc):
   ```
   const nano = require('nano')('http://admin:pass@localhost:5984');
   nano.db.create('too-many-ids');
   const db = nano.db.use('too-many-ids');
   
   let ids = [];
   for (let i = 0; i < 240; i++) {
 ids.push(`This-is-a-fake-id-${i}`);
   }
   
   let result = db.list({ids: ids}, console.log);
   ```
   
   At least on my system, and in this test case, 239/240 is when the failure 
starts.
   
   ## Context
   NB: One clear solution would be to use batching. However, I'm raising this 
because it seems unintentional.
   
   ## Your Environment
   * Version used: Nano 6.4.0
   * CouchDB used: Tested against both 1.6 and 2.0
   * Operating System and version (desktop or mobile): MacOS 10.12.5
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SCdF commented on issue #54: socket hangup on db.list with large numbers of ids

2017-07-18 Thread git

SCdF commented on issue #54: socket hangup on db.list with large numbers of ids
URL: https://github.com/apache/couchdb-nano/issues/54#issuecomment-316062559
 
 
   This looks like it's somewhere in Request, but I'm not too familiar with 
this code base.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SCdF commented on issue #54: socket hangup on db.list with large numbers of ids

2017-07-18 Thread git

SCdF commented on issue #54: socket hangup on db.list with large numbers of ids
URL: https://github.com/apache/couchdb-nano/issues/54#issuecomment-316070310
 
 
   Looks to be something to do with all params being put on the query string, 
and presumably something in the stack not liking that (perhaps CouchDB).
   
   One option is to change 
[list](https://github.com/apache/couchdb-nano/blob/master/lib/nano.js#L503-L510)
 to put params as part of the body instead in the query string:
   
   ```patch
   diff --git a/lib/nano.js b/lib/nano.js
   index 19f6177..9a4a1d6 100644
   --- a/lib/nano.js
   +++ b/lib/nano.js
   @@ -506,7 +506,7 @@ module.exports = exports = nano = function dbScope(cfg) {
qs = {};
  }

   -  return relax({db: dbName, path: '_all_docs', qs: qs}, callback);
   +  return relax({db: dbName, path: '_all_docs', body: qs}, callback);
}

// 
http://docs.couchdb.org/en/latest/api/database/bulk-api.html#post--db-_all_docs
   ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp commented on a change in pull request #597: Move view index files to .view_deleted when db is deleted

2017-07-18 Thread git

davisp commented on a change in pull request #597: Move view index files to 
.view_deleted when db is deleted
URL: https://github.com/apache/couchdb/pull/597#discussion_r127991059
 
 

 ##
 File path: src/couch/src/couch_file.erl
 ##
 @@ -272,14 +286,18 @@ deleted_filename(Original) ->
 ++ filename:extension(Original), [Y, Mon, D, H, Min, S])),
 filename:rootname(Original) ++ Suffix.
 
-nuke_dir(RootDelDir, Dir) ->
+nuke_dir(RootDir, Dir) ->
+nuke_dir(RootDir, Dir, []).
+nuke_dir(RootDelDir, Dir, Options) ->
 EnableRecovery = config:get_boolean("couchdb",
 "enable_database_recovery", false),
+Context = couch_util:get_value(context, Options, compaction),
 case EnableRecovery of
-true ->
-rename_file(Dir);
-false ->
-delete_dir(RootDelDir, Dir)
+true when Context == delete ->
+DbName = couch_util:get_value(db_name, Options),
+rename_dir(RootDelDir, Dir, DbName);
+true -> rename_file(Dir);
 
 Review comment:
   Ah, gotchya. For some reason I was thinking that was somewhere else but I 
forgot what module i was reading.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp commented on a change in pull request #597: Move view index files to .view_deleted when db is deleted

2017-07-18 Thread git

davisp commented on a change in pull request #597: Move view index files to 
.view_deleted when db is deleted
URL: https://github.com/apache/couchdb/pull/597#discussion_r127994880
 
 

 ##
 File path: src/couch/src/couch_file.erl
 ##
 @@ -264,6 +265,19 @@ rename_file(Original) ->
 Else -> Else
 end.
 
+rename_dir(RootDelDir, Original, DbName) ->
+DbDir = binary_to_list(DbName) ++ "_design",
+[DbPureName | _R] = lists:reverse(filename:split(binary_to_list(DbName))),
 
 Review comment:
   Where was the discussion on grouping them like that? I don't see any 
immediate reason why the first approach of just mirroring the 
shards/$range/dbname/_design... hierarchy under the .recovery directory.
   
   And the particular case I was referring to is if your dbname has an embedded 
/ in it which is feasible. Because given your example it reads to me like if we 
had a dbname <<"foo/bar">> then we'd end up with files under 
.recovery/bar/shards/... which would be wrong as far as I can tell.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp commented on a change in pull request #597: Move view index files to .view_deleted when db is deleted

2017-07-18 Thread git

davisp commented on a change in pull request #597: Move view index files to 
.view_deleted when db is deleted
URL: https://github.com/apache/couchdb/pull/597#discussion_r127995624
 
 

 ##
 File path: src/couch/src/couch_file.erl
 ##
 @@ -264,6 +265,19 @@ rename_file(Original) ->
 Else -> Else
 end.
 
+rename_dir(RootDelDir, Original, DbName) ->
+DbDir = binary_to_list(DbName) ++ "_design",
+[DbPureName | _R] = lists:reverse(filename:split(binary_to_list(DbName))),
 
 Review comment:
   Also, while users is a Cloudant specific issue it doesn't change the logic 
here as if you had a database name hierarchy you'd end up just chopping off the 
last element for the group which seems like it'd be super confusing to any 
administrator trying to use file recovery. You'd basically have to write the 
same scripts to search for files as you would without the whole grouping effort 
which makes me think there's not much benefit to doing it in the first place.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp commented on issue #684: Simplify regression test for COUCHDB-1283

2017-07-18 Thread git

davisp commented on issue #684: Simplify regression test for COUCHDB-1283
URL: https://github.com/apache/couchdb/pull/684#issuecomment-316101547
 
 
   Nothing related to this change.
   
   These three jobs are instances of #687
   
   * https://travis-ci.org/apache/couchdb/jobs/254582139
   * https://travis-ci.org/apache/couchdb/jobs/254582142
   * https://travis-ci.org/apache/couchdb/jobs/254581858
   
   And then this error that I'll look into:
   
   * https://travis-ci.org/apache/couchdb/jobs/254581856
   
   ```
   module 'couch_log_server_test'
 couch_log_server_test: couch_log_server_test_...*timed out*
 undefined
   ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] iilyak opened a new pull request #691: 3367 fix test case

2017-07-18 Thread git

iilyak opened a new pull request #691: 3367 fix test case
URL: https://github.com/apache/couchdb/pull/691
 
 
   ## Overview
   
   This fixes the problematic test case which was failing in the case when 
users db exists.
   
   ## Testing recommendations
   
   Run `make eunit apps=chttpd tests=all_test` twice
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva commented on issue #684: Simplify regression test for COUCHDB-1283

2017-07-18 Thread git

nickva commented on issue #684: Simplify regression test for COUCHDB-1283
URL: https://github.com/apache/couchdb/pull/684#issuecomment-316102724
 
 
   +1
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp commented on issue #687: mem3_sync_security test failure

2017-07-18 Thread git

davisp commented on issue #687: mem3_sync_security test failure
URL: https://github.com/apache/couchdb/issues/687#issuecomment-316103155
 
 
   Hrm. Pretty sure this is the mango tests being bad and not stopping things 
correctly. NFC why they all of a sudden started breaking things though. Will 
try and fix those up and see if that fixes this.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva commented on issue #691: 3367 fix test case

2017-07-18 Thread git

nickva commented on issue #691: 3367 fix test case
URL: https://github.com/apache/couchdb/pull/691#issuecomment-316104365
 
 
   +1
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp opened a new pull request #692: Fix test teardown

2017-07-18 Thread git

davisp opened a new pull request #692: Fix test teardown
URL: https://github.com/apache/couchdb/pull/692
 
 
   We weren't stopping the correct set of applications as well as
   forgetting to unload meck. I've also changed the test generators so that
   they execute all of the provided assertions.
   
   Fix #687
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali commented on issue #692: Fix test teardown

2017-07-18 Thread git

wohali commented on issue #692: Fix test teardown
URL: https://github.com/apache/couchdb/pull/692#issuecomment-316109605
 
 
   +1 once Travis is green
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali commented on issue #53: bring follow library under Nano's wing

2017-07-18 Thread git

wohali commented on issue #53: bring follow library under Nano's wing
URL: https://github.com/apache/couchdb-nano/pull/53#issuecomment-316110105
 
 
   @glynnbird FYI, any new code to be brought under an ASF repository (and thus 
ownership) directly must go through the code clearance process as outlined here:
   
   https://incubator.apache.org/guides/ip_clearance.html
   
   It's not just a matter of "they licensed it AL v2.0 so we can just bring it 
into our repo." That may be true of dependencies (we can depend on compatibly 
licensed code with no extra paperwork) but it's not true when that code is 
going to live in our repositories.
   
   Now, that said, if Cloudant people have "maintained out" most of the 
original developers' changes, i.e. "git blame" doesn't show their contributions 
as still being in place, then we can waive that process under the outstanding 
Cloudant CCLA + jhs's outstanding ICLA. You'll need to do the legwork here to 
ensure that is the case.
   
   - Joan with her "PMC hat" on.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali closed pull request #690: fix double export of wait_updated/3

2017-07-18 Thread git

wohali closed pull request #690: fix double export of wait_updated/3
URL: https://github.com/apache/couchdb/pull/690
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva commented on issue #692: Fix test teardown

2017-07-18 Thread git

nickva commented on issue #692: Fix test teardown
URL: https://github.com/apache/couchdb/pull/692#issuecomment-316111013
 
 
   +1
   
   ```make eunit apps=mango,mem3 suites=mem3_sync_security_test``` passes now 
and it failed before.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] glynnbird commented on issue #53: bring follow library under Nano's wing

2017-07-18 Thread git

glynnbird commented on issue #53: bring follow library under Nano's wing
URL: https://github.com/apache/couchdb-nano/pull/53#issuecomment-316112358
 
 
   Thanks for the clarification @wohali I'll make some enquiries.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dainyl opened a new issue #55: Feature: CouchDB 2.0 - Multiple View Queries

2017-07-18 Thread git

dainyl opened a new issue #55: Feature: CouchDB 2.0 - Multiple View Queries
URL: https://github.com/apache/couchdb-nano/issues/55
 
 
   CouchDB 2.0 now supports bulk querying views via 
http://docs.couchdb.org/en/2.0.0/api/ddoc/views.html#api-ddoc-view-multiple-queries
   
   ## Expected Behavior
   This would work via the `db.view` function 
https://github.com/apache/couchdb-nano#dbviewdesignname-viewname-params-callback
   
   ## Current Behavior
   `db.view` assumes that it's a GET request, but a POST request is required
   
   ## Possible Solution
   Update `db.view` to perform a POST request if `queries` is present in 
`params`
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp commented on issue #692: Fix test teardown

2017-07-18 Thread git

davisp commented on issue #692: Fix test teardown
URL: https://github.com/apache/couchdb/pull/692#issuecomment-316121113
 
 
   All green.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp closed pull request #692: Fix test teardown

2017-07-18 Thread git

davisp closed pull request #692: Fix test teardown
URL: https://github.com/apache/couchdb/pull/692
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp closed issue #687: mem3_sync_security test failure

2017-07-18 Thread git

davisp closed issue #687: mem3_sync_security test failure
URL: https://github.com/apache/couchdb/issues/687
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Jenkins] FAILURE: CouchDB » master #104

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/104/

[GitHub] davisp commented on issue #684: Simplify regression test for COUCHDB-1283

2017-07-18 Thread git

davisp commented on issue #684: Simplify regression test for COUCHDB-1283
URL: https://github.com/apache/couchdb/pull/684#issuecomment-316121420
 
 
   Looks like I've fixed the mango/mem3 interaction. Re-running these tests now.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp commented on issue #678: TMP: Add debug logging for failed assertion

2017-07-18 Thread git

davisp commented on issue #678: TMP: Add debug logging for failed assertion
URL: https://github.com/apache/couchdb/pull/678#issuecomment-316122114
 
 
   I can't get this to fail on the PR. Anyone mind if I just commit this to 
master until we see a reproduction? /cc @wohali @iilyak @nickva 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (COUCHDB-3337) End-point _local_docs doesn't conform to query params of _all_docs

2017-07-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/COUCHDB-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091811#comment-16091811
 ] 

ASF subversion and git services commented on COUCHDB-3337:
--

Commit 860f23cb57e0af84b668609676ba93c5edb769d5 in couchdb's branch 
refs/heads/680-fix-couchdb-1283-test from [~eiri]
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=860f23c ]

Fix _local_docs end-point

This is a second attempt to fix _local_docs end-point. The previous one didn't
work on big enough btree_local, because local btree doesn't have reduction fun,
so reuse of couch_db_updater:btree_by_id_reduce/2 was crashing on a bad match
as soon as btree_local was getting kp_node. Also using full fold to calculate
total_rows value turned out to be resource expensive when a database have
significant number of local documents.

This fix avoids calculating of total_rows and offset instead always setting
them to null and also setting to null update_seq when requested, since it
doesn't have meaning in context of local documents.

A fabric module fabric_view_all_docs.erl was copied and modified as
fabric_view_local_docs.erl, because re-using it for processing of both types of
the documents was getting rather convoluted.

Jira: COUCHDB-3337


> End-point _local_docs doesn't conform to query params of _all_docs
> --
>
> Key: COUCHDB-3337
> URL: https://issues.apache.org/jira/browse/COUCHDB-3337
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Eric Avdey
>Assignee: Eric Avdey
>
> There are following issues with {{/db/_local_doc end-point}}
> # It ignores include_docs parameter
> # It reports incorrect total_rows value, returning total rows of non-local 
> docs instead
> # It crashes with {{badrecord}} {{full_doc_info}} when query trying to skip 
> records



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (COUCHDB-1283) Impossible to compact view groups when number of active databases > max_dbs_open

2017-07-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/COUCHDB-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091812#comment-16091812
 ] 

ASF subversion and git services commented on COUCHDB-1283:
--

Commit c8f340e11c8fb34c960e98309bd514df0bd7b222 in couchdb's branch 
refs/heads/680-fix-couchdb-1283-test from [~paul.joseph.davis]
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=c8f340e ]

Simplify regression test for COUCHDB-1283

The previous version of this test relied on trying to bump into the
all_dbs_active error from the couch_server LRU. This proves to be rather
difficult to reliably provide assertions on behavior. In hindsight all
we really care about is that the compactor holds a monitor against the
database and then we can trust couch_server will not evict anything that
is actively monitored.

Fixes #680


> Impossible to compact view groups when number of active databases > 
> max_dbs_open
> 
>
> Key: COUCHDB-1283
> URL: https://issues.apache.org/jira/browse/COUCHDB-1283
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Filipe Manana
>Assignee: Paul Joseph Davis
> Fix For: 1.1.1, 1.2
>
> Attachments: couchdb-1283_12x.patch, couchdb-1283_trunk.patch
>
>
> Mike Leddy recently reported this issue in the users mailing list:
> http://mail-archives.apache.org/mod_mbox/couchdb-user/201109.mbox/%3c1315949945.22123.22.ca...@mike.loop.com.br%3E
> The attached patch is the simplest solution I can think of - keeping the 
> database open until the view compaction finishes.
> The patch includes a test case.
> It will need to be updated after Paul's view index refactoring (COUCHDB-1270).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] davisp commented on issue #684: Simplify regression test for COUCHDB-1283

2017-07-18 Thread git

davisp commented on issue #684: Simplify regression test for COUCHDB-1283
URL: https://github.com/apache/couchdb/pull/684#issuecomment-316125861
 
 
   And I totally forgot to rebase it onto master before restarting the tests... 
lets try that again.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dainyl opened a new pull request #56: Added support for multiple view queries

2017-07-18 Thread git

dainyl opened a new pull request #56: Added support for multiple view queries
URL: https://github.com/apache/couchdb-nano/pull/56
 
 
   This is a quick fix to add support for multiple view queries, which were 
introduced in CouchDB 2.0
   
   It fixes #55 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Jenkins] FAILURE: CouchDB » master #105

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/105/

[GitHub] wohali commented on issue #678: TMP: Add debug logging for failed assertion

2017-07-18 Thread git

wohali commented on issue #678: TMP: Add debug logging for failed assertion
URL: https://github.com/apache/couchdb/pull/678#issuecomment-316134875
 
 
   +1 for XKCD error ;)
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] iilyak closed pull request #691: 3367 fix test case

2017-07-18 Thread git

iilyak closed pull request #691: 3367 fix test case
URL: https://github.com/apache/couchdb/pull/691
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (COUCHDB-3367) Require admin privileges for clustered _compact and _view_cleanup

2017-07-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/COUCHDB-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091850#comment-16091850
 ] 

ASF subversion and git services commented on COUCHDB-3367:
--

Commit 3e14510b4578c846f01fb4bb1e461dad75af29e9 in couchdb's branch 
refs/heads/master from ILYA Khlopotov
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=3e14510 ]

Use hashed password when we create admin in test

couch_server is responsible for calling hash_admin_passwords whenever
"admin" section of config changes. However as you can see it from
[here](https://github.com/apache/couchdb/blob/master/src/couch/src/couch_server.erl#L219)
the call is asynchronous. This means that our test cases might fail when
we try to using admin user while admin password is not yet hashed.

COUCHDB-3367


> Require admin privileges for clustered _compact and _view_cleanup
> -
>
> Key: COUCHDB-3367
> URL: https://issues.apache.org/jira/browse/COUCHDB-3367
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Frederick Kämpfer
>
> Contrary to what is stated in the security docs 
> (http://docs.couchdb.org/en/2.0.0/intro/security.html) admin privileges are 
> not enforced for the db/_compact and db/_view_cleanup clustered endpoints.
> Since normal users should not be able to trigger compaction, either system 
> level or db level admin privileges should be enforced by couchdb.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (COUCHDB-3367) Require admin privileges for clustered _compact and _view_cleanup

2017-07-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/COUCHDB-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091849#comment-16091849
 ] 

ASF subversion and git services commented on COUCHDB-3367:
--

Commit 3523bab304cc031b9fcc150080ff539d9f76dabb in couchdb's branch 
refs/heads/master from ILYA Khlopotov
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=3523bab ]

Rename unused variables

COUCHDB-3367


> Require admin privileges for clustered _compact and _view_cleanup
> -
>
> Key: COUCHDB-3367
> URL: https://issues.apache.org/jira/browse/COUCHDB-3367
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Frederick Kämpfer
>
> Contrary to what is stated in the security docs 
> (http://docs.couchdb.org/en/2.0.0/intro/security.html) admin privileges are 
> not enforced for the db/_compact and db/_view_cleanup clustered endpoints.
> Since normal users should not be able to trigger compaction, either system 
> level or db level admin privileges should be enforced by couchdb.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] iilyak opened a new pull request #693: Use test_util:stop_config in mem3_util_test

2017-07-18 Thread git

iilyak opened a new pull request #693: Use test_util:stop_config in 
mem3_util_test
URL: https://github.com/apache/couchdb/pull/693
 
 
   ## Overview
   
   The config:stop is asynchronous which causes test failures with error
   like the following
   
   ```
   {error,{already_started,<0.32662.3>}
   ```
   
   ## Testing recommendations
   
   This is rather hard to test since it is a flaky test. Just make sure that it 
doesn't make things worse by calling `make eunit apps=mem3 tests=n_val_tes`
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva commented on issue #693: Use test_util:stop_config in mem3_util_test

2017-07-18 Thread git

nickva commented on issue #693: Use test_util:stop_config in mem3_util_test
URL: https://github.com/apache/couchdb/pull/693#issuecomment-316162947
 
 
   +1
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] iilyak closed pull request #693: Use test_util:stop_config in mem3_util_test

2017-07-18 Thread git

iilyak closed pull request #693: Use test_util:stop_config in mem3_util_test
URL: https://github.com/apache/couchdb/pull/693
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva opened a new pull request #694: Remove get_details replicator job gen_server call

2017-07-18 Thread git

nickva opened a new pull request #694: Remove get_details replicator job 
gen_server call
URL: https://github.com/apache/couchdb/pull/694
 
 
   This was used from a test only and it wasn't reliable. Because of replicator
   job delays initialization the `State` would be either #rep_state{} or #rep. 
If
   replication job hasn't finished initializing, then state would be #rep{} and 
a
   call like get_details which matches the state with #rep_state{] would fail 
with
   the badmatch error.
   
   As seen in issue #686
   
   So remove `get_details` call and let the test rely on task polling as all 
other
   tests do.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] iilyak commented on issue #694: Remove get_details replicator job gen_server call

2017-07-18 Thread git

iilyak commented on issue #694: Remove get_details replicator job gen_server 
call
URL: https://github.com/apache/couchdb/pull/694#issuecomment-316168310
 
 
   @nickva: While on it could you fix a compile warning on line 100?
   
   ```
   couchdb/src/couch_replicator/test/couch_replicator_compact_tests.erl:100: 
Warning: variable 'RepId' is unused
   ```
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva opened a new issue #695: Test failure in couch_db_mpr_tests

2017-07-18 Thread git

nickva opened a new issue #695: Test failure in couch_db_mpr_tests
URL: https://github.com/apache/couchdb/issues/695
 
 
   ```
   [os_mon] cpu supervisor port (cpu_sup): Erlang has closed
   
   [done in 3.409 s]
   
 [done in 3.552 s]
   
   module 'couch_db_mpr_tests'
   
 multi-part attachment tests
   
   couch_db_mpr_tests: couch_db_mpr_test_...*timed out*
   
   undefined
   ```
   
   No log file: `COUCHAUTH credentials unavailable! Unable to upload logfiles.`
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva closed pull request #694: Remove get_details replicator job gen_server call

2017-07-18 Thread git

nickva closed pull request #694: Remove get_details replicator job gen_server 
call
URL: https://github.com/apache/couchdb/pull/694
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva opened a new pull request #696: Fix cancellation race in replication.js tests

2017-07-18 Thread git

nickva opened a new pull request #696: Fix cancellation race in replication.js 
tests
URL: https://github.com/apache/couchdb/pull/696
 
 
   Replication cancelation doesn't immediately update active tasks. Instead, use
   the new `waitReplicationTaskStop(rep_id)` function to propery wait for the
   task status.
   
   Issue #634
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp commented on issue #684: Simplify regression test for COUCHDB-1283

2017-07-18 Thread git

davisp commented on issue #684: Simplify regression test for COUCHDB-1283
URL: https://github.com/apache/couchdb/pull/684#issuecomment-316171569
 
 
   All green.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp closed pull request #684: Simplify regression test for COUCHDB-1283

2017-07-18 Thread git

davisp closed pull request #684: Simplify regression test for COUCHDB-1283
URL: https://github.com/apache/couchdb/pull/684
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp closed issue #680: EUnit: couchdb_1283: View group shutdown fails

2017-07-18 Thread git

davisp closed issue #680: EUnit: couchdb_1283: View group shutdown fails
URL: https://github.com/apache/couchdb/issues/680
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (COUCHDB-1283) Impossible to compact view groups when number of active databases > max_dbs_open

2017-07-18 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/COUCHDB-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092045#comment-16092045
 ] 

ASF subversion and git services commented on COUCHDB-1283:
--

Commit 0f46cdeceb4d8c12a7e95ef110b381fdc6c3b2da in couchdb's branch 
refs/heads/master from [~paul.joseph.davis]
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=0f46cde ]

Simplify regression test for COUCHDB-1283

The previous version of this test relied on trying to bump into the
all_dbs_active error from the couch_server LRU. This proves to be rather
difficult to reliably provide assertions on behavior. In hindsight all
we really care about is that the compactor holds a monitor against the
database and then we can trust couch_server will not evict anything that
is actively monitored.

Fixes #680


> Impossible to compact view groups when number of active databases > 
> max_dbs_open
> 
>
> Key: COUCHDB-1283
> URL: https://issues.apache.org/jira/browse/COUCHDB-1283
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Filipe Manana
>Assignee: Paul Joseph Davis
> Fix For: 1.1.1, 1.2
>
> Attachments: couchdb-1283_12x.patch, couchdb-1283_trunk.patch
>
>
> Mike Leddy recently reported this issue in the users mailing list:
> http://mail-archives.apache.org/mod_mbox/couchdb-user/201109.mbox/%3c1315949945.22123.22.ca...@mike.loop.com.br%3E
> The attached patch is the simplest solution I can think of - keeping the 
> database open until the view compaction finishes.
> The patch includes a test case.
> It will need to be updated after Paul's view index refactoring (COUCHDB-1270).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[Jenkins] FAILURE: CouchDB » master #107

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/107/

[GitHub] iilyak commented on a change in pull request #696: Fix cancellation race in replication.js tests

2017-07-18 Thread git

iilyak commented on a change in pull request #696: Fix cancellation race in 
replication.js tests
URL: https://github.com/apache/couchdb/pull/696#discussion_r128074498
 
 

 ##
 File path: test/javascript/tests/replication.js
 ##
 @@ -1841,7 +1841,7 @@ couchTests.replication = function(debug) {
   headers: {"Content-Type": "application/json"}
   });
   TEquals(200, xhr.status, "Replication cancel request success");
-
+  waitReplicationTaskStop(rep_id);
 
 Review comment:
   Should it be `repId`?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva commented on a change in pull request #696: Fix cancellation race in replication.js tests

2017-07-18 Thread git

nickva commented on a change in pull request #696: Fix cancellation race in 
replication.js tests
URL: https://github.com/apache/couchdb/pull/696#discussion_r128075158
 
 

 ##
 File path: test/javascript/tests/replication.js
 ##
 @@ -1841,7 +1841,7 @@ couchTests.replication = function(debug) {
   headers: {"Content-Type": "application/json"}
   });
   TEquals(200, xhr.status, "Replication cancel request success");
-
+  waitReplicationTaskStop(rep_id);
 
 Review comment:
   Ah good catch. Fixed.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva closed pull request #696: Fix cancellation race in replication.js tests

2017-07-18 Thread git

nickva closed pull request #696: Fix cancellation race in replication.js tests
URL: https://github.com/apache/couchdb/pull/696
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Jenkins] FAILURE: CouchDB » master #108

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/108/

[Jenkins] SUCCESS: CouchDB » master #109

2017-07-18 Thread Apache Jenkins Server

Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/109/

[Jenkins] SUCCESS: CouchDB » master #110

2017-07-18 Thread Apache Jenkins Server

Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/110/

[GitHub] davisp commented on issue #678: TMP: Add debug logging for failed assertion

2017-07-18 Thread git

davisp commented on issue #678: TMP: Add debug logging for failed assertion
URL: https://github.com/apache/couchdb/pull/678#issuecomment-316247928
 
 
   Makes it easy to grep for. :D
   
   On Tue, Jul 18, 2017 at 12:21 PM Joan Touzet 
   wrote:
   
   > +1 for XKCD error ;)
   >
   > ?
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > , or 
mute
   > the thread
   > 

   > .
   >
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jiangphcn commented on a change in pull request #597: Move view index files to .view_deleted when db is deleted

2017-07-18 Thread git

jiangphcn commented on a change in pull request #597: Move view index files to
.view_deleted when db is deleted
URL: https://github.com/apache/couchdb/pull/597#discussion_r128146806

##
File path: src/couch/src/couch_file.erl
##
@@ -264,6 +265,19 @@ rename_file(Original) ->
Else -> Else
end.

+rename_dir(RootDelDir, Original, DbName) ->
+DbDir = binary_to_list(DbName) ++ "_design",
+[DbPureName | _R] = lists:reverse(filename:split(binary_to_list(DbName))),

Review comment:
The discussion was reflected in summary of this commit
(https://github.com/apache/couchdb/pull/597/commits/9b1dbfd5a2d770a4f2c2a5cb79c6e4575dad36c1).
```
- Introduce dbname directory between .recovery and shards so that
all view files belonging to the same db can be located at the
the central place. Thus, these view files can be easily sorted
by atime at /srv/data/.recovery level.
When these view files from same db needs to be recovered, they
can be easily moved back to view directory.
```

However, considering the user information in DBName and situation where "/"
is included in dbname, I changed back to
`/srv/view_index/.recovery/shards/e000-/testdb1.1500350972_design`
approach.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

With regards,
Apache Git Services

[GitHub] jiangphcn commented on issue #597: Move view index files to .view_deleted when db is deleted

2017-07-18 Thread git

jiangphcn commented on issue #597: Move view index files to .view_deleted when 
db is deleted
URL: https://github.com/apache/couchdb/pull/597#issuecomment-316264573
 
 
   @davisp Hi Paul, I removed dbname directory between .recovery and shards in 
new commit. Would you please take another look? Thanks
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Jenkins] FAILURE: CouchDB » jenkins-packages-2 #4

2017-07-18 Thread Apache Jenkins Server

Boo, we failed. https://builds.apache.org/job/CouchDB/job/jenkins-packages-2/4/

69 matches

Mail list logo