[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313718#comment-16313718
]
ASF GitHub Bot commented on FREEMARKER-55:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/42
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313714#comment-16313714
]
ASF GitHub Bot commented on FREEMARKER-55:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/42
FREEMARKER-55: cleanups by improving StringToIndexMap and CallableUtils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-55-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
commit 0f45c1da0b372b56d3c3808837a4060778c97834
Author: Woonsan Ko
Date: 2018-01-05T18:54:03Z
FREEMARKER-55: cleanups with new #of(StringToIndexMap, Entry...)
commit ba39a0bc5031dc1fe02b422895f0518ce7a5e713
Author: Woonsan Ko
Date: 2018-01-05T18:56:49Z
FREEMARKER-55: remove unused _ArrayUtils
commit ce78134ece2ad0df653538ebdd244bd0a5806679
Author: Woonsan Ko
Date: 2018-01-05T19:20:40Z
FREEMARKER-55: moving #getLastPredefinedNamedArgumentIndex() to
CallableUtils
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311932#comment-16311932
]
ASF GitHub Bot commented on FREEMARKER-55:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/41
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309125#comment-16309125
]
ASF GitHub Bot commented on FREEMARKER-55:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/41
FREEMARKER-55: Spring MVC Form Support (1) - :form and :input directives
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-55-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
commit 150ad7f6039446e2d0e3ee66010abe5be920d8d1
Author: Woonsan Ko
Date: 2017-12-23T04:21:37Z
FREEMARKER-55: skeletal design
commit fb2ae5cc81c4160c7bc694e0d85b8d979a61db49
Author: Woonsan Ko
Date: 2017-12-23T22:43:33Z
FREEMARKER-55: skeletal unit test for input tag
commit ff2feb0402d806731bd64e6132952d1c14026b85
Author: Woonsan Ko
Date: 2017-12-27T05:29:52Z
FREEMARKER-55: Adding TagOutputter
commit 2b5e9b7cb8bda5065e475339f3ec9dd854848b0a
Author: Woonsan Ko
Date: 2017-12-28T06:26:54Z
FREEMARKER-55: make attribute arguments explicit
commit ae94a3d494ac1da64c89e70a4f021170f064730c
Author: Woonsan Ko
Date: 2017-12-30T04:54:07Z
FREEMARKER-55: unit tests for form.input directive
commit aa264af1bce93e0891c9551b8c494185471e5727
Author: Woonsan Ko
Date: 2017-12-30T04:59:13Z
FREEMARKER-55: make it public for consistency
commit 1f7100cee9ca2e1c2c28e4bc5bded6e4857677ec
Author: Woonsan Ko
Date: 2017-12-30T06:07:12Z
FREEMARKER-55: Adding skeletal form directive
commit 045c980cfcbc96b258334aaf467145914864
Author: Woonsan Ko
Date: 2018-01-03T04:03:55Z
FREEMARKER-55: Adding tests and polishing
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-56) FM3 Gradle build TODO-s
[ https://issues.apache.org/jira/browse/FREEMARKER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293928#comment-16293928 ] ASF GitHub Bot commented on FREEMARKER-56: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-freemarker/pull/40 > FM3 Gradle build TODO-s > --- > > Key: FREEMARKER-56 > URL: https://issues.apache.org/jira/browse/FREEMARKER-56 > Project: Apache Freemarker > Issue Type: Task >Reporter: Daniel Dekany > > There are various TODO comments in our FreeMarker 3 Gradle build scripts... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FREEMARKER-56) FM3 Gradle build TODO-s
[ https://issues.apache.org/jira/browse/FREEMARKER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293630#comment-16293630 ] ASF GitHub Bot commented on FREEMARKER-56: -- GitHub user smoothreggae reopened a pull request: https://github.com/apache/incubator-freemarker/pull/40 FREEMARKER-56 publish source and JavaDoc JARs I have signed and submitted an [Individual Contributor License Agreement](https://www.apache.org/dev/new-committers-guide.html#cla) and have received acknowledgement that it has been filed in the Apache Software Foundation records. You can merge this pull request into a Git repository by running: $ git pull https://github.com/smoothreggae/incubator-freemarker pr/3/publish-source-and-javadoc-jars Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-freemarker/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit 7620a24948de7438d71dd9123611e78875f45ac8 Author: george thomas Date: 2017-12-15T17:54:15Z FREEMARKER-56 publish source and JavaDoc JARs > FM3 Gradle build TODO-s > --- > > Key: FREEMARKER-56 > URL: https://issues.apache.org/jira/browse/FREEMARKER-56 > Project: Apache Freemarker > Issue Type: Task >Reporter: Daniel Dekany > > There are various TODO comments in our FreeMarker 3 Gradle build scripts... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FREEMARKER-56) FM3 Gradle build TODO-s
[ https://issues.apache.org/jira/browse/FREEMARKER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293629#comment-16293629 ] ASF GitHub Bot commented on FREEMARKER-56: -- Github user smoothreggae closed the pull request at: https://github.com/apache/incubator-freemarker/pull/40 > FM3 Gradle build TODO-s > --- > > Key: FREEMARKER-56 > URL: https://issues.apache.org/jira/browse/FREEMARKER-56 > Project: Apache Freemarker > Issue Type: Task >Reporter: Daniel Dekany > > There are various TODO comments in our FreeMarker 3 Gradle build scripts... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FREEMARKER-56) FM3 Gradle build TODO-s
[ https://issues.apache.org/jira/browse/FREEMARKER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292936#comment-16292936 ] ASF GitHub Bot commented on FREEMARKER-56: -- GitHub user smoothreggae opened a pull request: https://github.com/apache/incubator-freemarker/pull/40 FREEMARKER-56 publish source and JavaDoc JARs I have signed and submitted an [Individual Contributor License Agreement](https://www.apache.org/dev/new-committers-guide.html#cla) and have received acknowledgement that it has been filed in the Apache Software Foundation records. You can merge this pull request into a Git repository by running: $ git pull https://github.com/smoothreggae/incubator-freemarker pr/3/publish-source-and-javadoc-jars Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-freemarker/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit 34b6b1f8515cb673b6539d2a191c29402c8db4b4 Author: george thomas Date: 2017-12-15T17:54:15Z FREEMARKER-56 publish source and JavaDoc JARs > FM3 Gradle build TODO-s > --- > > Key: FREEMARKER-56 > URL: https://issues.apache.org/jira/browse/FREEMARKER-56 > Project: Apache Freemarker > Issue Type: Task >Reporter: Daniel Dekany > > There are various TODO comments in our FreeMarker 3 Gradle build scripts... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171156#comment-16171156
]
ASF GitHub Bot commented on FREEMARKER-55:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/36
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167951#comment-16167951
]
ASF GitHub Bot commented on FREEMARKER-55:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/36
FREEMARKER-55: stringifying string/boolean/date model in url function…
…. otherwise exception
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-55-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
commit 4779234b67bb9c6ab0f0812d72ebe4b2152de04a
Author: Woonsan Ko
Date: 2017-09-15T14:39:26Z
FREEMARKER-55: stringifying string/boolean/date model in url function.
otherwise exception
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165982#comment-16165982
]
ASF GitHub Bot commented on FREEMARKER-55:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/35
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164923#comment-16164923
]
ASF GitHub Bot commented on FREEMARKER-55:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/35
FREEMARKER-55:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-55-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
commit 40bd07b718262e30345c082ec4794ab2535b5fd8
Author: Woonsan Ko
Date: 2017-09-13T14:49:36Z
FREEMARKER-55: narrow class/method visibilities as possible.
commit 3f6ee183ab87e193c4eaa465652d5d8b204cd992
Author: Woonsan Ko
Date: 2017-09-13T16:14:08Z
FREEMARKER-55: introducing CallableUtils#getAndUnwrap...(...) utils.
commit f6abc3054e1fb571c221d874c2c2ed37bb8ecf7c
Author: Woonsan Ko
Date: 2017-09-13T16:21:10Z
FREEMARKER-55: simplifying test examples with no interim vars
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164402#comment-16164402
]
ASF GitHub Bot commented on FREEMARKER-55:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/34
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[ https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164044#comment-16164044 ] ASF GitHub Bot commented on FREEMARKER-55: -- GitHub user woonsan opened a pull request: https://github.com/apache/incubator-freemarker/pull/34 FREEMARKER-55: Spring Directives/Functions to replace spring.tld tags You can merge this pull request into a Git repository by running: $ git pull https://github.com/woonsan/incubator-freemarker feature/FREEMARKER-55-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-freemarker/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit 6709117683e29b34a6e155cac30a160f86f95745 Author: Woonsan Ko Date: 2017-08-26T05:17:07Z FREEMARKER-55: trying with a directive to replace spring:bind jsp tag. commit 19a3277c5809e30243a921a2ee42d3a40ecf9ebc Author: Woonsan Ko Date: 2017-08-29T03:11:12Z FREEMARKER-55: using namespace variable for status variable. commit b656f1e1f7c1b0875526f2224db1fc793e1172d2 Author: Woonsan Ko Date: 2017-08-29T18:58:34Z FREEMARKER-55: use nested content parameter instead of variable commit aeaf0307736008b2921c7efa42cf7d31b2df6dbc Author: Woonsan Ko Date: 2017-08-30T03:02:21Z FREEMARKER-55: splitting abstract class to keep common things commit 64adad829926532b17ce5a5965a2c40e594dd6fc Author: Woonsan Ko Date: 2017-08-30T03:07:29Z FREEMARKER-55: simple clean up commit 2de73b082f1bf7c36d616263688f77d27bc50227 Author: Woonsan Ko Date: 2017-08-30T13:07:02Z FREEMARKER-55: code clean ups commit 63f42c3dfcb06b7873e7aec58c90894e8b291ced Author: Woonsan Ko Date: 2017-08-30T13:21:55Z FREEMARKER-55: Adding javadocs commit f1e8a4df1a745164bcf48ab9a92cec5beb598bc2 Author: Woonsan Ko Date: 2017-09-03T02:11:45Z Merge branch '3' into feature/FREEMARKER-55-2 commit 3b83475f111019842b6070581ca310890ba199d1 Author: Woonsan Ko Date: 2017-09-03T03:49:38Z FREEMARKER-55: Adding initial message function. commit 8f5eaaaf2df1914fef461802f2d7b511d4a99870 Author: Woonsan Ko Date: 2017-09-03T04:08:31Z FREEMARKER-55: read message args from positioned vargs. commit b0aceddab9ac55c622fb596d2ed03444c2ff0884 Author: Woonsan Ko Date: 2017-09-03T04:27:08Z FREEMARKER-55: use vargs for code and args commit a8e73ec77a735b643be986e0c190205f3b7a2192 Author: Woonsan Ko Date: 2017-09-05T12:33:55Z Using CallableUtils to throw exceptions; use positional param for code commit 12f70fff2db494e91bbc9926c76e529d781f4f18 Author: Woonsan Ko Date: 2017-09-06T14:01:10Z FREEMARKER-55: Adding more spring callable models. commit d0bd43c8e42a9b5b2834a2d5c139401fcb8fda2d Author: Woonsan Ko Date: 2017-09-06T14:02:01Z Merge branch '3' into feature/FREEMARKER-55-2 commit 234f96ec2c2868c72f797bda42a8d0c854e63b87 Author: Woonsan Ko Date: 2017-09-08T16:21:53Z FREEMARKER-55: Adding more functions. commit 9eedd86da2dc6aeac011e0e1553871599b80ab18 Author: Woonsan Ko Date: 2017-09-11T17:41:52Z Merge branch '3' into feature/FREEMARKER-55-2 commit 6f025c79534117a0f87eb17445e1a76cf06be418 Author: Woonsan Ko Date: 2017-09-11T18:13:56Z FREEMARKER-55: use Environment variables instead of pageContext in eval function. commit 8bdc5fdcf6507a00113e8f396cdf9a90c8c3857c Author: Woonsan Ko Date: 2017-09-11T19:45:46Z FREEMARKER-55: Adding url function commit 075bd88777888a12a194844f8b961c8bd7333a49 Author: Woonsan Ko Date: 2017-09-11T19:51:01Z FREEMARKER-55: fixing NPE when there's no params commit 834abd7d6f338ee7fcc5bdaa060ce2d36495fc8b Author: Woonsan Ko Date: 2017-09-11T20:50:45Z FREEMARKER-55: code cleanups commit 2076c5e83786b5253ea80651f4a47ea87f263fd0 Author: Woonsan Ko Date: 2017-09-11T21:14:39Z FREEMARKER-55: Removing mvcUrl function as it's not in earlier version of spring 4.0.x commit 96c038d9ccc4a5d38cc8896370870d27af46af1f Author: Woonsan Ko Date: 2017-09-12T03:21:50Z FREEMARKER-55: unit test template code commit d5c31a1b4e5753e7dbbeb1b1971c3b9bcf5643e4 Author: Woonsan Ko Date: 2017-09-12T03:24:37Z FREEMARKER-55: unit test template code commit 77b7f30c5f61158c138f42e0f61c3b47b8df6d2d Author: Woonsan Ko Date: 2017-09-12T14:58:28Z FREEMARKER-55: Adding unit test for message function. commit a274d2a6149b432656c5aa61eedd5b6213168378 Author: Woonsan Ko Date: 2017-09-12T15:22:15Z FREEMARKER-55: Adding unit test for theme function. commit 9987acfe0f399ad81d0373a8e7ee81e47674f614 Author: Woonsan Ko Date: 2017-09-12T15:33:39Z FREEMARKER-55: adding unit test for theme function. commit d7916709f9897c4ff8c6ae146ee191df77a43427 Author: Woonsan Ko Date: 2017-09-12T17:41:02Z FREEMAR
[jira] [Commented] (FREEMARKER-64) FM3 Unification and improvement of function-like constructs
[
https://issues.apache.org/jira/browse/FREEMARKER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118241#comment-16118241
]
ASF GitHub Bot commented on FREEMARKER-64:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/33
> FM3 Unification and improvement of function-like constructs
> ---
>
> Key: FREEMARKER-64
> URL: https://issues.apache.org/jira/browse/FREEMARKER-64
> Project: Apache Freemarker
> Issue Type: New Feature
> Components: engine
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>Assignee: Daniel Dekany
>
> FREEMARKER-63 has introduced {{TemplateFunctionModel}}, which is the type of
> values that {{#function}} creates. It should also replace
> {{TemplateMethodModel}} and {{TemplateMethodModelEx}}, so that we have only
> one interface for function-like things. (If that doesn't work out well, we at
> least should remove the deprecated {{TemplateMethodModel}}, and then rename
> {{TemplateMethodModelEx}} to that name. Also, we need to support the explicit
> selection overloaded Java methods - see in {{CallPlace}}).
> As {{TemplateFunctionModel}} supports both positional and named parameters,
> the expression language has to be upgraded to support that too.
> Things like `?isMethod` and `?isFunction` have to be reworked as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-64) FM3 Unification and improvement of function-like constructs
[
https://issues.apache.org/jira/browse/FREEMARKER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118228#comment-16118228
]
ASF GitHub Bot commented on FREEMARKER-64:
--
GitHub user ddekany opened a pull request:
https://github.com/apache/incubator-freemarker/pull/33
FREEMARKER-64: Function (and thus also method) call syntax now suppor…
…ts passing parameter by name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ddekany/incubator-freemarker FREEMARKER-64
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
commit b59a03a8add0f47427ddd9594852f7bd86a8a7e9
Author: ddekany
Date: 2017-08-08T11:46:50Z
FREEMARKER-64: Function (and thus also method) call syntax now supports
passing parameter by name.
> FM3 Unification and improvement of function-like constructs
> ---
>
> Key: FREEMARKER-64
> URL: https://issues.apache.org/jira/browse/FREEMARKER-64
> Project: Apache Freemarker
> Issue Type: New Feature
> Components: engine
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>Assignee: Daniel Dekany
>
> FREEMARKER-63 has introduced {{TemplateFunctionModel}}, which is the type of
> values that {{#function}} creates. It should also replace
> {{TemplateMethodModel}} and {{TemplateMethodModelEx}}, so that we have only
> one interface for function-like things. (If that doesn't work out well, we at
> least should remove the deprecated {{TemplateMethodModel}}, and then rename
> {{TemplateMethodModelEx}} to that name. Also, we need to support the explicit
> selection overloaded Java methods - see in {{CallPlace}}).
> As {{TemplateFunctionModel}} supports both positional and named parameters,
> the expression language has to be upgraded to support that too.
> Things like `?isMethod` and `?isFunction` have to be reworked as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-64) FM3 Unification and improvement of function-like constructs
[
https://issues.apache.org/jira/browse/FREEMARKER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117466#comment-16117466
]
ASF GitHub Bot commented on FREEMARKER-64:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/32
> FM3 Unification and improvement of function-like constructs
> ---
>
> Key: FREEMARKER-64
> URL: https://issues.apache.org/jira/browse/FREEMARKER-64
> Project: Apache Freemarker
> Issue Type: New Feature
> Components: engine
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>Assignee: Daniel Dekany
>
> FREEMARKER-63 has introduced {{TemplateFunctionModel}}, which is the type of
> values that {{#function}} creates. It should also replace
> {{TemplateMethodModel}} and {{TemplateMethodModelEx}}, so that we have only
> one interface for function-like things. (If that doesn't work out well, we at
> least should remove the deprecated {{TemplateMethodModel}}, and then rename
> {{TemplateMethodModelEx}} to that name. Also, we need to support the explicit
> selection overloaded Java methods - see in {{CallPlace}}).
> As {{TemplateFunctionModel}} supports both positional and named parameters,
> the expression language has to be upgraded to support that too.
> Things like `?isMethod` and `?isFunction` have to be reworked as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-64) FM3 Unification and improvement of function-like constructs
[
https://issues.apache.org/jira/browse/FREEMARKER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117461#comment-16117461
]
ASF GitHub Bot commented on FREEMARKER-64:
--
GitHub user ddekany opened a pull request:
https://github.com/apache/incubator-freemarker/pull/32
FREEMARKER-64: FM3 Unification and improvement of function-like constructs
What's done: Replaced TemplateMethodModel and TemplateMethodModelEx with
TemplateFunctionModel. Some refinements in other TemplateCallableModel API-s.
Built-ins like `?isMethod`, `?isTransform`, `?isMacro` are not removed, in
favor of `?isDirective` and `?isFunction`.
What's still missing: calling functions with named parameters.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ddekany/incubator-freemarker FREEMARKER-64
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
> FM3 Unification and improvement of function-like constructs
> ---
>
> Key: FREEMARKER-64
> URL: https://issues.apache.org/jira/browse/FREEMARKER-64
> Project: Apache Freemarker
> Issue Type: New Feature
> Components: engine
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>Assignee: Daniel Dekany
>
> FREEMARKER-63 has introduced {{TemplateFunctionModel}}, which is the type of
> values that {{#function}} creates. It should also replace
> {{TemplateMethodModel}} and {{TemplateMethodModelEx}}, so that we have only
> one interface for function-like things. (If that doesn't work out well, we at
> least should remove the deprecated {{TemplateMethodModel}}, and then rename
> {{TemplateMethodModelEx}} to that name. Also, we need to support the explicit
> selection overloaded Java methods - see in {{CallPlace}}).
> As {{TemplateFunctionModel}} supports both positional and named parameters,
> the expression language has to be upgraded to support that too.
> Things like `?isMethod` and `?isFunction` have to be reworked as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-63) FM3 Unification and improvement of directive-like constructs
[
https://issues.apache.org/jira/browse/FREEMARKER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117453#comment-16117453
]
ASF GitHub Bot commented on FREEMARKER-63:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/30
> FM3 Unification and improvement of directive-like constructs
>
>
> Key: FREEMARKER-63
> URL: https://issues.apache.org/jira/browse/FREEMARKER-63
> Project: Apache Freemarker
> Issue Type: New Feature
> Components: engine
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>Assignee: Daniel Dekany
>
> In FreeMarker 3 all kind of directive-like user defined objects (macros,
> {{TemplateDirectiveModel}}-s, {{TempalteTransfromModel}}-s, etc) has to be
> united under a single {{TemplateModel}} subinterface, which support all the
> features supported by the replaced FM2 concepts (e.g. nested content
> execution, loop variables, passing parameters by position and by name,
> varargs in both cases, call place bound caching, etc.). Obviously, the
> template language has to support calling this new interface, and then the old
> ones has to be removed.
> Furthermore, as a new feature in FM3, passing parameter both by position and
> by name in the same invocation (as in {{<@image "foo.jpg" alt="Foo" />}})
> need to be supported.
> (Similarly, {{#function}} and {{TempalteMethodModel}} will have to be
> generalized and united, but that will be in a separate issue.)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116639#comment-16116639
]
ASF GitHub Bot commented on FREEMARKER-55:
--
Github user woonsan closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/31
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115649#comment-16115649
]
ASF GitHub Bot commented on FREEMARKER-55:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/31
FREEMARKER-55: spring.ftl marco lib support
- Support <#import "/spring.ftl" as spring> like Spring Framework does.
- By default, the system lib from /spring.ftl is read from the specific
classpath, not from app's template path.
The system template aliases map can be customized through
SpringResourceTemplateLoader.systemTemplateAliases property.
- The same macros and functions are defined in /spring.ftl as Spring
Framework's, with syntax changes to comply with FM3.
- Note: As the system template lib support is handled by
SpringTemplateLoader in this PR, it means developers should always use
SpringTemplateLoader directly or indirectly in order to use the system macro
library. Please review this decision.
- TODOs: review/test/refine each macro and functions in spring.ftl.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-55
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
commit 8e0f33c419d982279d7fb22a9dfdc66f47abaf2c
Author: Woonsan Ko
Date: 2017-07-14T15:27:17Z
FREEMARKER-55: Renaming Freemarker to FreeMarker
commit ec8d687d4ce2c0e1bb3e3ca073b139eacc198527
Author: Woonsan Ko
Date: 2017-07-14T15:53:51Z
Merge branch '3' into feature/FREEMARKER-55
commit e7cb6f7cfc241689c85527971bf6e1ea7ced9127
Author: Woonsan Ko
Date: 2017-07-14T17:57:29Z
Merge branch '3' into feature/FREEMARKER-55
commit c6eb09de91e57035c1e0e3c4d3490b3b96622bab
Author: Woonsan Ko
Date: 2017-07-16T18:24:55Z
Merge branch '3' into feature/FREEMARKER-55
commit 870209fa8e0acd0bb3186053dfd549b5c758e37d
Author: Woonsan Ko
Date: 2017-07-18T00:38:03Z
Merge branch '3' into feature/FREEMARKER-55
commit 4481406a2f4eeb30d6d044a4ac158efab7ba7a7b
Author: Woonsan Ko
Date: 2017-08-06T01:28:54Z
Merge branch '3' into feature/FREEMARKER-55
commit fcd9e672ec515e3042bc5efd229b7d12c23e7d88
Author: Woonsan Ko
Date: 2017-08-06T05:09:12Z
FREEMARKER-55: system template lib for spring app: spring.ftl.
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-63) FM3 Unification and improvement of directive-like constructs
[ https://issues.apache.org/jira/browse/FREEMARKER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113517#comment-16113517 ] ASF GitHub Bot commented on FREEMARKER-63: -- GitHub user ddekany opened a pull request: https://github.com/apache/incubator-freemarker/pull/30 FREEMARKER-63: Unification and improvement of directive-like constructs Redesigned `TemplateDirectiveModel` now support both by position and by name parameter passing, even mixed in the same call. `#macros`-s also create `TemplateDirectiveModel`-s, and supports defining if a parameter is positional or named. Removed deprecated `TemplateTransformModel`. Added `TemplateFunctionModel`, which meant to replace `TemplateMethodModel` and `TemplateMethodModelEx` in another Jira issue, but for now it's only what `#function` creates. This also supports both positional and named parameters (though the call syntax in the expression language isn't updated in this issue, so it still only can pass positional parameters). `#function` was upgraded to support the same new features as `#macro`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ddekany/incubator-freemarker FREEMARKER-63 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-freemarker/pull/30.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #30 commit c28a78bd8dad4bfd3a37a90a26fbb15639d33604 Author: ddekany Date: 2017-07-24T18:26:29Z FREEMARKER-63: Very early state. Until it's fully functional, the new interface is called TemplateDirectiveModel2, and is invoked with <~...> instead of <@...>. Later it will replace TemplateDirectiveModel and the syntax will be <@...>. commit 46c750109ffe9e4c7e52e4c3df94b78c3445f780 Author: ddekany Date: 2017-07-26T21:48:11Z FREEMARKER-63: Very early state. Added support for nested content and loop variables. Added StringToIndexMap, which is used for mapping names to their index in the value arrays (a concept that we use at a few places now). commit fbbfadb443efac2009439564f1d3c664ff8a51b0 Author: ddekany Date: 2017-07-27T16:20:37Z FREEMARKER-63: Very early state. Some cleanups. Temporarily added support for calling legacy ASTDirMacro-s with the also temporary <~...>syntax. commit 146c42572c440dd4ef911d437239d3e54a7fe95b Author: ddekany Date: 2017-07-27T16:43:05Z FREEMARKER-63: Very early state. Simplified capturing assignment implementation commit 1e27397dd9570ac2f48be6100afd2bba7b42b8b8 Author: ddekany Date: 2017-07-27T18:45:01Z Removed the legacy predefined shared variables: "html_escape", "normalize_newlines", "xml_escape", "capture_output", "compress". It had to be done now as TemplateTransformModel will be removed as part of FREEMARKER-63. commit a6399a793f54f531a11a7a9d13b9eb47d648563a Author: ddekany Date: 2017-07-27T19:24:14Z FREEMARKER-63: Bit of API/javadoc cleanup commit 52a5f9eb8881a2c976a2b84ff683d8c11238efca Author: ddekany Date: 2017-07-30T00:04:56Z FREEMARKER-63: Removed TemplateTransformModel and the old TemplateDirectiveModel, renamed TemplateDirectiveModel2 to TemplateDirectiveModel. Removed the temporary `<~...>` syntax; now `<@...>` is used to call the new TemplateDirectiveModel. Lot of API refinement, like introduced ArgumentArrayLayout class. Several test cases won't yet pass... work in progress. commit 126c506984ea1e006b719ebb3ae92a4207c4c9f2 Author: ddekany Date: 2017-07-30T13:57:46Z FREEMARKER-63: Fixed failing test. (Now the test suite passes.) commit 589d9b80e218a39d2ac128b1108952992868cc40 Author: ddekany Date: 2017-07-30T18:38:01Z FREEMARKER-63: Change 1: Replaced the "loop variable" term with the more generic "nested content parameter" term. (In FM2, loop variables were introduced earlier than nested content parameter, so the two term coulnd't be unified. So it's just one less term in FM3.) Change 2: CallPlace.executeNestedContent now requires the nested content paramter value array to have exactly the same length as the number of parameters declared by the caller. commit 5bd19adeb8dd24cde34987c4724c7a5d5d227f52 Author: ddekany Date: 2017-07-30T21:07:29Z FREEMARKER-63: Added isNestedContentSupported() to templateDirectiveModel commit da4c33292d5d73cdfb53613ca64bd0834fcfb5fd Author: ddekany Date: 2017-07-30T21:20:34Z FREEMARKER-63: Removed NestedContentNotSupportedException, as TemplateDirectiveModel.isNestedContentSupported() now takes care of that problem. commit 3cacd9ed04a231af67e3964525fd592b97da1665 Author: ddekany Date: 2017-08-03T21:11:57Z FREEMARKER-63: Lot of refinement in the API-s and implementation. #macro now creates a `TemplateDirectiveModel`, and
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090837#comment-16090837
]
ASF GitHub Bot commented on FREEMARKER-55:
--
Github user woonsan closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/28
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087489#comment-16087489
]
ASF GitHub Bot commented on FREEMARKER-55:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/28
FREEMARKER-55: Renaming Freemarker to FreeMarker
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-55
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/28.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #28
commit 8e0f33c419d982279d7fb22a9dfdc66f47abaf2c
Author: Woonsan Ko
Date: 2017-07-14T15:27:17Z
FREEMARKER-55: Renaming Freemarker to FreeMarker
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087172#comment-16087172
]
ASF GitHub Bot commented on FREEMARKER-55:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/27
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086310#comment-16086310
]
ASF GitHub Bot commented on FREEMARKER-55:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/27
FREEMARKER-55: Add default tld sources
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-55
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
commit 576b0ff3b266da40b26e46a8d66efe6353884a36
Author: Woonsan Ko
Date: 2017-07-13T19:42:19Z
FREEMARKER-55: Add default tld sources (tld files in web-inf/lib/*.jar)
like FreemarkerServlet does.
commit 36e04dfceff14d6604067e3e05e59f0cf8b042f7
Author: Woonsan Ko
Date: 2017-07-13T19:43:26Z
Merge branch '3' into feature/FREEMARKER-55
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076147#comment-16076147
]
ASF GitHub Bot commented on FREEMARKER-55:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/26
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075716#comment-16075716
]
ASF GitHub Bot commented on FREEMARKER-55:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/26
FREEMARKER-55: polishing and cleanups in TaglibFactory builder
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-55
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
commit 519680accbb42aaf48eda1e656008249559d0ae8
Author: Woonsan Ko
Date: 2017-07-05T17:54:01Z
FREEMARKER-55: remove unnecessary exposures and package name change.
commit 3c91ecb65ac12973c05421ec6a265020cfccdc5b
Author: Woonsan Ko
Date: 2017-07-05T18:11:18Z
FREEMARKER-55: use servlet api 3.0, jsp-api 2.2, jsp-el 2.2 and spring 4.0.x
commit dcbebe9b19e85dff067a46c4394e107916fb7845
Author: Woonsan Ko
Date: 2017-07-05T20:30:09Z
FREEMARKER-55: moving builder into TaglibFactory
commit c0bb4903c6494c873c97d9a0190de68288e4a1bb
Author: Woonsan Ko
Date: 2017-07-05T20:37:32Z
FREEMARKER-55: simplify builder constructor
commit 78071707b4ed13e1bcec4dc16fb55ffdf62e12e0
Author: Woonsan Ko
Date: 2017-07-05T20:45:44Z
FREEMARKER-55: TaglibFactory must be created only by builder.
commit 8621226442bc5bdcdc9b594a688e6f9ce0e80097
Author: Woonsan Ko
Date: 2017-07-05T21:10:32Z
FREEMARKER-55: removing mutable setters in TaglibFactory
commit 196158b03c18534466d8a0275052515317475474
Author: Woonsan Ko
Date: 2017-07-05T21:52:05Z
FREEMARKER-55: code cleanup in TaglibFactory, using generics and some
formatting
commit 2a8d76179ba783de5d81e24fa2ec1ec7ad001e39
Author: Woonsan Ko
Date: 2017-07-05T22:45:50Z
FREEMARKER-55: cleanups (while loop and input streams)
commit e12792ea4e845baf739191ec07b34d60e2653aa9
Author: Woonsan Ko
Date: 2017-07-05T22:49:32Z
FREEMARKER-55: allow building only once.
commit 14396c83635d2b34612a429312c223afa8836fd4
Author: Woonsan Ko
Date: 2017-07-06T00:19:21Z
FREEMARKER-55: cleaning up TaglibFactory.Builder
commit 28102af69bca00e3cf29c2dc8a3a6a9d25c56ade
Author: Woonsan Ko
Date: 2017-07-06T00:49:32Z
FREEMARKER-55: code cleanups using generics
commit 42cfb3261b4f591d822ca91d443f82e12f3e98a5
Author: Woonsan Ko
Date: 2017-07-06T00:51:00Z
Merge branch '3' into feature/FREEMARKER-55
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073253#comment-16073253
]
ASF GitHub Bot commented on FREEMARKER-55:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/25
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support
[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073085#comment-16073085
]
ASF GitHub Bot commented on FREEMARKER-55:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/25
FREEMARKER-55: Freemarker View and ViewResolver implementation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-55
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
commit 584b46b86aee16134f1f1c9e6d2cdb79bb7f8016
Author: Woonsan Ko
Date: 2017-06-28T20:18:14Z
FREEMARKER-55: Adding skeletal FreemarkerView
commit ec2d37c6dbf19ec4aca839b9bea737e0881e0f02
Author: Woonsan Ko
Date: 2017-06-28T20:19:19Z
Merge branch '3' into feature/FREEMARKER-55
commit 334d9cde950f06e480027d3064e53b6c1cfa54e2
Author: Woonsan Ko
Date: 2017-06-29T03:36:49Z
FREEMARKER-55: adding model building code.
commit 36b0694f335c319946f908729be95f1808f23b2a
Author: Woonsan Ko
Date: 2017-06-29T04:41:17Z
FREEMARKER-55: Adding more tests regarding FreemarkerView's model
commit 8e8c724b6f2ae003c67c4bc0c41fb026c0b9f6ad
Author: Woonsan Ko
Date: 2017-06-29T05:21:40Z
FREEMARKER-55: Adding test for Application attributes.
commit cb4fab3ae483d2fb645d296aff0ab94c78a8d4b9
Author: Woonsan Ko
Date: 2017-06-30T03:30:47Z
FREEMARKER-55: Add TaglibFactoryBuilder to reuse TaglibFactory creation
logic
commit c2589eeb0517006715d427b591d186fafff7a32b
Author: Woonsan Ko
Date: 2017-06-30T03:31:44Z
Merge branch '3' into feature/FREEMARKER-55
commit 83e896c01ebe2fd3fa5b0997f6ee177ccbeed2f5
Author: Woonsan Ko
Date: 2017-06-30T03:56:20Z
FREEMARKER-55: Adding FreemarkerViewResolver
commit 9083de1ba04d9d54b80109ed86941da72337cba5
Author: Woonsan Ko
Date: 2017-07-02T05:25:01Z
Adding FreemarkerViewResolver and improving FreemarkerViewTest with
JspTaglibFactory and example.
commit b375e1478f3ef3f5c12ac51890454c810e3dc057
Author: Woonsan Ko
Date: 2017-07-02T05:25:49Z
Merge branch '3' into feature/FREEMARKER-55
commit 4088f91f62b678d2c4bebc25375d7fc822f47420
Author: Woonsan Ko
Date: 2017-07-02T06:22:52Z
FREEMARKER-55: Adding FreemarkerViewResolverTest
commit 6ff7849be9bc71ee6fe81f4db6ab3530d7c8296e
Author: Woonsan Ko
Date: 2017-07-04T02:23:05Z
Merge branch '3' into feature/FREEMARKER-55
commit c5e9fe30857c3175a777df62416caff283ed6fea
Author: Woonsan Ko
Date: 2017-07-04T04:03:43Z
polishing API and javadocs.
commit 53d9ef941514945310f6df642faf558d996256bf
Author: Woonsan Ko
Date: 2017-07-04T04:13:26Z
FREEMARKER-55: polising javadocs
> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053701#comment-16053701
]
ASF GitHub Bot commented on FREEMARKER-54:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/24
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053436#comment-16053436
]
ASF GitHub Bot commented on FREEMARKER-54:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/24
FREEMARKER-54: Remove unnecessary #setSettings(); Logging correction;
VersionEditor for conversion between string and Version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-54
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
commit 94828521fc30f0d51c7728d37b537404c8096bfe
Author: Woonsan Ko
Date: 2017-06-19T02:12:03Z
FREEMARKER-54: Remove ConfigurationFactoryBean#setSettings(...) because
ancestor already contains equivalent one. Also, separate spring logger.
commit cb43725a79e851c11d4552d3a5ab0b6d70d43e9d
Author: Woonsan Ko
Date: 2017-06-19T03:13:56Z
FREEMARKER-54: Support Version convertion editor between string and Version
object for spring community
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053213#comment-16053213
]
ASF GitHub Bot commented on FREEMARKER-54:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/23
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-7) Maven Build
[ https://issues.apache.org/jira/browse/FREEMARKER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053068#comment-16053068 ] ASF GitHub Bot commented on FREEMARKER-7: - Github user woonsan closed the pull request at: https://github.com/apache/incubator-freemarker/pull/8 > Maven Build > --- > > Key: FREEMARKER-7 > URL: https://issues.apache.org/jira/browse/FREEMARKER-7 > Project: Apache Freemarker > Issue Type: New Feature >Reporter: Woonsan Ko > > Build with Maven instead of Ant/Ivy. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053065#comment-16053065
]
ASF GitHub Bot commented on FREEMARKER-54:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/23
FREEMARKER-54: FM3 freemareker-spring module, basic functionality
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-54
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
commit dbbfe99074d22fa59437a6d90499f3f3199040ba
Author: Woonsan Ko
Date: 2017-06-15T01:03:35Z
FREEMARKER-54: Adding skeletal freemarker-spring module
commit 57270ecf85744c5c6ca566c89f21f721a7a9d59a
Author: Woonsan Ko
Date: 2017-06-15T04:10:58Z
FREEMARKER-54: initial ConfigurationFactoryBean design
commit 2783387eb495331042e72449f02b2a18527a9e13
Author: Woonsan Ko
Date: 2017-06-15T04:37:24Z
feature/FREEMARKER-54: ConfigurationFactoryBean tests
commit 99c3c0cb45cf500a0fc914332a88f78e17c9d5e6
Author: Woonsan Ko
Date: 2017-06-16T03:15:08Z
FREEMARKER-54: More setting tests through ConfigurationFactoryBean
commit 18ee8a0846dbbbf4b853af8f76509f331bfb07ae
Author: Woonsan Ko
Date: 2017-06-16T03:23:42Z
FREEMARKER-54: use property wherever easier than settings map.
commit a571c24f6fc9544e164eeaf71347044b3fe88182
Author: Woonsan Ko
Date: 2017-06-18T03:44:46Z
FREEMARKER-54: Adding SpringResourceTemplateLoader and test
commit fc1f429cc4174b8ced71617074718715b81ee575
Author: Woonsan Ko
Date: 2017-06-18T03:45:59Z
Merge branch '3' into feature/FREEMARKER-54
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-7) Maven Build
[ https://issues.apache.org/jira/browse/FREEMARKER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986807#comment-14986807 ] ASF GitHub Bot commented on FREEMARKER-7: - GitHub user woonsan opened a pull request: https://github.com/apache/incubator-freemarker/pull/8 FREEMARKER-7 Build with Maven Initial PR to build with Maven instead of Ant/Ivy: - Adding initial pom.xml with javacc plugin configuration, dependencies, etc. - To support multiple incompatible jython versions, I decided to use Reflection APIs for old jython versions because those two classes for the older version of jython APIs are very small and it seems more effective to use Reflection API for those than using complex dependencies and separate compilations. - To support older version of jsp-api, I simply added an unsupported operation, by which both versions can work without any problem at runtime, while supporting multiple provided jsp-api versions at runtime. I think this approach is simpler and more effective. - Still I noticed that two unit test operations failing (RealServletContainertTest#basicTrivial() and RealServletContainertTest#basicELFunctions()). I think we'd better separate modules for this kind of real web application runtime tests. Until that, I decided to mark those two operations as @Ignore, to also ask for other's opinions. Anyway, you can run the following command. Then it will create a freemarker-x.x.x.jar in target/ dir: ``` mvn clean package ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/woonsan/incubator-freemarker feature/FREEMARKER-maven-build Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-freemarker/pull/8.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8 commit 3b4bc0eb386d5b151c58f7c39055156c67588d04 Author: Woonsan Ko Date: 2015-11-03T06:46:00Z FREEMARKER-7 initial maven build support commit d401ece5a68b9450a9e9677747b1d53a5a58f16f Author: Woonsan Ko Date: 2015-11-03T06:46:16Z FREEMARKER-7 initial maven build support commit ab88e1751fbe4342d6ce384e5b3e9a1459adef99 Author: Woonsan Ko Date: 2015-11-03T06:48:00Z Merge remote-tracking branch 'upstream/2.3-gae' into feature/FREEMARKER-maven-build > Maven Build > --- > > Key: FREEMARKER-7 > URL: https://issues.apache.org/jira/browse/FREEMARKER-7 > Project: Apache Freemarker > Issue Type: New Feature >Reporter: Woonsan Ko > > Build with Maven instead of Ant/Ivy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FREEMARKER-2) Option to set request locale from the given servlet request
[
https://issues.apache.org/jira/browse/FREEMARKER-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975249#comment-14975249
]
ASF GitHub Bot commented on FREEMARKER-2:
-
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/7
> Option to set request locale from the given servlet request
> ---
>
> Key: FREEMARKER-2
> URL: https://issues.apache.org/jira/browse/FREEMARKER-2
> Project: Apache Freemarker
> Issue Type: Improvement
>Reporter: Woonsan Ko
>Priority: Minor
>
> Currently templates are executed with a specific global locale all the time
> because FreemarkerServlet.deduceLocale() uses config.getLocale().
> This can result in wrong date/currency formatting issue for instance (when
> using JSTL tags).
> It should be able to read HttpServletRequest#getLocale().
> Normally web application frameworks sets the request locale before rendering
> a view.
> Daniel's remark on this in old ML:
> {quote}
> Then, I think, the default implementation of deduceLocale() should take the a
> new init-param into account, let's call it "LocaleFromRequest". The default
> of that should be false for backward compatibility. But if someone sets that
> setting to true, and the request locale isn't null, we use that instead of
> the Freemarker Configuration setting. And here again, you could override what
> the
> *default* is.
> Just like with "OverrideResponseContentType", the default can depend
> on the IcI on the long run.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FREEMARKER-2) Option to set request locale from the given servlet request
[
https://issues.apache.org/jira/browse/FREEMARKER-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973269#comment-14973269
]
ASF GitHub Bot commented on FREEMARKER-2:
-
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/7
FREEMARKER-2 adding 'OverrideResponseLocale' init param option
in FreemarkerServlet
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-2-option-request-locale
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
commit 1e4c64f1c0230ec9f6ddc70fed6e142d3b8199ca
Author: Woonsan Ko
Date: 2015-10-25T14:41:04Z
FREEMARKER-2 adding 'OverrideResponseLocale' init param option in
FreemarkerServlet
> Option to set request locale from the given servlet request
> ---
>
> Key: FREEMARKER-2
> URL: https://issues.apache.org/jira/browse/FREEMARKER-2
> Project: Apache Freemarker
> Issue Type: Improvement
>Reporter: Woonsan Ko
>Priority: Minor
>
> Currently templates are executed with a specific global locale all the time
> because FreemarkerServlet.deduceLocale() uses config.getLocale().
> This can result in wrong date/currency formatting issue for instance (when
> using JSTL tags).
> It should be able to read HttpServletRequest#getLocale().
> Normally web application frameworks sets the request locale before rendering
> a view.
> Daniel's remark on this in old ML:
> {quote}
> Then, I think, the default implementation of deduceLocale() should take the a
> new init-param into account, let's call it "LocaleFromRequest". The default
> of that should be false for backward compatibility. But if someone sets that
> setting to true, and the request locale isn't null, we use that instead of
> the Freemarker Configuration setting. And here again, you could override what
> the
> *default* is.
> Just like with "OverrideResponseContentType", the default can depend
> on the IcI on the long run.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FREEMARKER-1) Option to not to overwrite response ContentType in FreemarkerServlet
[
https://issues.apache.org/jira/browse/FREEMARKER-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961990#comment-14961990
]
ASF GitHub Bot commented on FREEMARKER-1:
-
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/5
> Option to not to overwrite response ContentType in FreemarkerServlet
>
>
> Key: FREEMARKER-1
> URL: https://issues.apache.org/jira/browse/FREEMARKER-1
> Project: Apache Freemarker
> Issue Type: Improvement
>Reporter: Woonsan Ko
>Assignee: Daniel Dekany
>Priority: Minor
>
> FreemarkerServlet doesn't have to set response ContentType by default.
> Especially when a controller in an MVC framework sets the response
> ContentType, it's better to not set the response ContentType again by the
> default ContentType setting in FreemarkerServlet according to servlet
> specification (SRV.5.2 and SRV.14.2.22.1):
> {quote}
> Servlet programmers are responsible for ensuring that the Content-Type header
> is appropriately set in the response object for the content the servlet is
> generating. The HTTP 1.1 specification does not require that this header be
> set in an HTTP response. Servlet containers must not set a default content
> type when the servlet programmer does not set the type.
> {quote}
> {quote}
> ServletResponse#getContentType() should "Returns the content type used for
> the MIME body sent in this response. The content type proper must have been
> specified using setContentType(String) before the response is committed. If
> no content type has been specified, this method returns null. If a content
> type has been specified and a character encoding has been explicitly or
> implicitly specified as described in getCharacterEncoding() , the charset
> parameter is included in the string returned. If no character encoding has
> been specified, the charset parameter is omitted.
> Returns: a String specifying the content type, for example, text/html;
> charset=UTF-8, or null
> Since: 2.4
> {quote}
> So, optionally, if #getContentType() returns null, then FreemarkerServlet can
> detect that the Content-Type was never set before.
> Actually, frameworks or containers don't have to set Content-Type if
> programmers don't. However, I think setting Content-Type header in the
> framework level (freemarker servlet in this case) to a reasonable default
> value seems fine.
> Daniels's remarks/suggestions on this in the old ML:
> {quote}
> The contentType matter... thanks for looking after these! So then,
> FreemarkerServlet surely should set the HttpServletResponse contentType when
> it's still null. OTOH there should be an option to only set it then (if it's
> not null), not always as it happens now. So then the "ContetType" init-param
> remains as is, and we add a new init-param, "OverrideResponseContentType"
> (better name?), whose default is true for backward compatibility, but this
> default can be changed to false by extending FreemarkerServlet. WDYT?
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FREEMARKER-3) FileTemplateLoaderTest and ASTTest fails test on non-Windows env
[
https://issues.apache.org/jira/browse/FREEMARKER-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961197#comment-14961197
]
ASF GitHub Bot commented on FREEMARKER-3:
-
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/4
> FileTemplateLoaderTest and ASTTest fails test on non-Windows env
>
>
> Key: FREEMARKER-3
> URL: https://issues.apache.org/jira/browse/FREEMARKER-3
> Project: Apache Freemarker
> Issue Type: Bug
> Environment: - OS X 10.10.5 x86_64
> - Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> - Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
>Reporter: Woonsan Ko
>
> From master, if you run `ant test' on OS X (Ant 1.9 / Java 1.8), two tests
> fail:
> {noformat}
> [junit] TEST freemarker.cache.FileTemplateLoaderTest FAILED
> [junit] TEST freemarker.core.ASTTest FAILED
> {noformat}
> Those look like an environment related issue. FileTemplateLoaderTest seems
> failing when resolving file in case-sensitive way and ASTTest seems failing
> due to EOL issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FREEMARKER-1) Option to not to overwrite response ContentType in FreemarkerServlet
[
https://issues.apache.org/jira/browse/FREEMARKER-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953122#comment-14953122
]
ASF GitHub Bot commented on FREEMARKER-1:
-
Github user woonsan closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/1
> Option to not to overwrite response ContentType in FreemarkerServlet
>
>
> Key: FREEMARKER-1
> URL: https://issues.apache.org/jira/browse/FREEMARKER-1
> Project: Apache Freemarker
> Issue Type: Improvement
>Reporter: Woonsan Ko
>Priority: Minor
>
> FreemarkerServlet doesn't have to set response ContentType by default.
> Especially when a controller in an MVC framework sets the response
> ContentType, it's better to not set the response ContentType again by the
> default ContentType setting in FreemarkerServlet according to servlet
> specification (SRV.5.2 and SRV.14.2.22.1):
> {quote}
> Servlet programmers are responsible for ensuring that the Content-Type header
> is appropriately set in the response object for the content the servlet is
> generating. The HTTP 1.1 specification does not require that this header be
> set in an HTTP response. Servlet containers must not set a default content
> type when the servlet programmer does not set the type.
> {quote}
> {quote}
> ServletResponse#getContentType() should "Returns the content type used for
> the MIME body sent in this response. The content type proper must have been
> specified using setContentType(String) before the response is committed. If
> no content type has been specified, this method returns null. If a content
> type has been specified and a character encoding has been explicitly or
> implicitly specified as described in getCharacterEncoding() , the charset
> parameter is included in the string returned. If no character encoding has
> been specified, the charset parameter is omitted.
> Returns: a String specifying the content type, for example, text/html;
> charset=UTF-8, or null
> Since: 2.4
> {quote}
> So, optionally, if #getContentType() returns null, then FreemarkerServlet can
> detect that the Content-Type was never set before.
> Actually, frameworks or containers don't have to set Content-Type if
> programmers don't. However, I think setting Content-Type header in the
> framework level (freemarker servlet in this case) to a reasonable default
> value seems fine.
> Daniels's remarks/suggestions on this in the old ML:
> {quote}
> The contentType matter... thanks for looking after these! So then,
> FreemarkerServlet surely should set the HttpServletResponse contentType when
> it's still null. OTOH there should be an option to only set it then (if it's
> not null), not always as it happens now. So then the "ContetType" init-param
> remains as is, and we add a new init-param, "OverrideResponseContentType"
> (better name?), whose default is true for backward compatibility, but this
> default can be changed to false by extending FreemarkerServlet. WDYT?
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FREEMARKER-1) Option to not to overwrite response ContentType in FreemarkerServlet
[
https://issues.apache.org/jira/browse/FREEMARKER-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953120#comment-14953120
]
ASF GitHub Bot commented on FREEMARKER-1:
-
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/5
FREEMARKER-1 adding OverrideResponseContentType init param in
FreemarkerServlet
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-1-option-overrideResponseContentType-on-2.3-gae
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
commit e89dbfce5f2d2274653062dfd6911a62c354c39b
Author: Woonsan Ko
Date: 2015-10-12T13:31:16Z
FREEMARKER-1 adding OverrideResponseContentType init param in
FreemarketServlet
> Option to not to overwrite response ContentType in FreemarkerServlet
>
>
> Key: FREEMARKER-1
> URL: https://issues.apache.org/jira/browse/FREEMARKER-1
> Project: Apache Freemarker
> Issue Type: Improvement
>Reporter: Woonsan Ko
>Priority: Minor
>
> FreemarkerServlet doesn't have to set response ContentType by default.
> Especially when a controller in an MVC framework sets the response
> ContentType, it's better to not set the response ContentType again by the
> default ContentType setting in FreemarkerServlet according to servlet
> specification (SRV.5.2 and SRV.14.2.22.1):
> {quote}
> Servlet programmers are responsible for ensuring that the Content-Type header
> is appropriately set in the response object for the content the servlet is
> generating. The HTTP 1.1 specification does not require that this header be
> set in an HTTP response. Servlet containers must not set a default content
> type when the servlet programmer does not set the type.
> {quote}
> {quote}
> ServletResponse#getContentType() should "Returns the content type used for
> the MIME body sent in this response. The content type proper must have been
> specified using setContentType(String) before the response is committed. If
> no content type has been specified, this method returns null. If a content
> type has been specified and a character encoding has been explicitly or
> implicitly specified as described in getCharacterEncoding() , the charset
> parameter is included in the string returned. If no character encoding has
> been specified, the charset parameter is omitted.
> Returns: a String specifying the content type, for example, text/html;
> charset=UTF-8, or null
> Since: 2.4
> {quote}
> So, optionally, if #getContentType() returns null, then FreemarkerServlet can
> detect that the Content-Type was never set before.
> Actually, frameworks or containers don't have to set Content-Type if
> programmers don't. However, I think setting Content-Type header in the
> framework level (freemarker servlet in this case) to a reasonable default
> value seems fine.
> Daniels's remarks/suggestions on this in the old ML:
> {quote}
> The contentType matter... thanks for looking after these! So then,
> FreemarkerServlet surely should set the HttpServletResponse contentType when
> it's still null. OTOH there should be an option to only set it then (if it's
> not null), not always as it happens now. So then the "ContetType" init-param
> remains as is, and we add a new init-param, "OverrideResponseContentType"
> (better name?), whose default is true for backward compatibility, but this
> default can be changed to false by extending FreemarkerServlet. WDYT?
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FREEMARKER-3) FileTemplateLoaderTest and ASTTest fails test on non-Windows env
[
https://issues.apache.org/jira/browse/FREEMARKER-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953093#comment-14953093
]
ASF GitHub Bot commented on FREEMARKER-3:
-
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/4
FREEMARKER-3: fixing unit tests - env issues on OSX or non-Windows systems.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-3-fix-unit-tests-on-2.3-gae
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
commit 76c56a59abca3799409329b244a328b31e754a6b
Author: Woonsan Ko
Date: 2015-10-12T13:04:13Z
FREEMARKER-3: fixing unit tests - env issues on OSX or non-Windows systems
> FileTemplateLoaderTest and ASTTest fails test on non-Windows env
>
>
> Key: FREEMARKER-3
> URL: https://issues.apache.org/jira/browse/FREEMARKER-3
> Project: Apache Freemarker
> Issue Type: Bug
> Environment: - OS X 10.10.5 x86_64
> - Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> - Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
>Reporter: Woonsan Ko
>
> From master, if you run `ant test' on OS X (Ant 1.9 / Java 1.8), two tests
> fail:
> {noformat}
> [junit] TEST freemarker.cache.FileTemplateLoaderTest FAILED
> [junit] TEST freemarker.core.ASTTest FAILED
> {noformat}
> Those look like an environment related issue. FileTemplateLoaderTest seems
> failing when resolving file in case-sensitive way and ASTTest seems failing
> due to EOL issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FREEMARKER-3) FileTemplateLoaderTest and ASTTest fails test on non-Windows env
[
https://issues.apache.org/jira/browse/FREEMARKER-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953091#comment-14953091
]
ASF GitHub Bot commented on FREEMARKER-3:
-
Github user woonsan closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/2
> FileTemplateLoaderTest and ASTTest fails test on non-Windows env
>
>
> Key: FREEMARKER-3
> URL: https://issues.apache.org/jira/browse/FREEMARKER-3
> Project: Apache Freemarker
> Issue Type: Bug
> Environment: - OS X 10.10.5 x86_64
> - Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> - Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
>Reporter: Woonsan Ko
>
> From master, if you run `ant test' on OS X (Ant 1.9 / Java 1.8), two tests
> fail:
> {noformat}
> [junit] TEST freemarker.cache.FileTemplateLoaderTest FAILED
> [junit] TEST freemarker.core.ASTTest FAILED
> {noformat}
> Those look like an environment related issue. FileTemplateLoaderTest seems
> failing when resolving file in case-sensitive way and ASTTest seems failing
> due to EOL issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FREEMARKER-3) FileTemplateLoaderTest and ASTTest fails test on non-Windows env
[
https://issues.apache.org/jira/browse/FREEMARKER-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952314#comment-14952314
]
ASF GitHub Bot commented on FREEMARKER-3:
-
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/2
FREEMARKER-3: fixing unit tests - env issues on OSX or non-Windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-3-fix-unit-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
commit 8bb53f42d5243c8efc3ed0ec42b93c8138c2e733
Author: Woonsan Ko
Date: 2015-10-11T15:29:10Z
FREEMARKER-3: fixing unit tests - env issues on OSX or non-Windows systems
> FileTemplateLoaderTest and ASTTest fails test on non-Windows env
>
>
> Key: FREEMARKER-3
> URL: https://issues.apache.org/jira/browse/FREEMARKER-3
> Project: Apache Freemarker
> Issue Type: Bug
> Environment: - OS X 10.10.5 x86_64
> - Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> - Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
>Reporter: Woonsan Ko
>
> From master, if you run `ant test' on OS X (Ant 1.9 / Java 1.8), two tests
> fail:
> {noformat}
> [junit] TEST freemarker.cache.FileTemplateLoaderTest FAILED
> [junit] TEST freemarker.core.ASTTest FAILED
> {noformat}
> Those look like an environment related issue. FileTemplateLoaderTest seems
> failing when resolving file in case-sensitive way and ASTTest seems failing
> due to EOL issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FREEMARKER-1) Option to not to overwrite response ContentType in FreemarkerServlet
[
https://issues.apache.org/jira/browse/FREEMARKER-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952136#comment-14952136
]
ASF GitHub Bot commented on FREEMARKER-1:
-
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/1
FREEMARKER-1 OverrideResponseContentType init param in FreemarkerServlet
Added OverrideResponseContentType init param, setting it to true, for
backward compatibility.
Also, added a unit test with spring-test dependency (for easier servlet api
mocking).
Please take a review. (Once this accepted, FREEMARKER-2 should be easier
because of the unit test.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-1-option-overrideResponseContentType
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/1.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1
commit 93f1b4049667fdc955f071e8a9ea77d5ccc62ab3
Author: Woonsan Ko
Date: 2015-10-11T02:31:27Z
FREEMARKER-1 adding OverrideResponseContentType init param in
FreemarkerServlet
> Option to not to overwrite response ContentType in FreemarkerServlet
>
>
> Key: FREEMARKER-1
> URL: https://issues.apache.org/jira/browse/FREEMARKER-1
> Project: Apache Freemarker
> Issue Type: Improvement
>Reporter: Woonsan Ko
>Priority: Minor
>
> FreemarkerServlet doesn't have to set response ContentType by default.
> Especially when a controller in an MVC framework sets the response
> ContentType, it's better to not set the response ContentType again by the
> default ContentType setting in FreemarkerServlet according to servlet
> specification (SRV.5.2 and SRV.14.2.22.1):
> {quote}
> Servlet programmers are responsible for ensuring that the Content-Type header
> is appropriately set in the response object for the content the servlet is
> generating. The HTTP 1.1 specification does not require that this header be
> set in an HTTP response. Servlet containers must not set a default content
> type when the servlet programmer does not set the type.
> {quote}
> {quote}
> ServletResponse#getContentType() should "Returns the content type used for
> the MIME body sent in this response. The content type proper must have been
> specified using setContentType(String) before the response is committed. If
> no content type has been specified, this method returns null. If a content
> type has been specified and a character encoding has been explicitly or
> implicitly specified as described in getCharacterEncoding() , the charset
> parameter is included in the string returned. If no character encoding has
> been specified, the charset parameter is omitted.
> Returns: a String specifying the content type, for example, text/html;
> charset=UTF-8, or null
> Since: 2.4
> {quote}
> So, optionally, if #getContentType() returns null, then FreemarkerServlet can
> detect that the Content-Type was never set before.
> Actually, frameworks or containers don't have to set Content-Type if
> programmers don't. However, I think setting Content-Type header in the
> framework level (freemarker servlet in this case) to a reasonable default
> value seems fine.
> Daniels's remarks/suggestions on this in the old ML:
> {quote}
> The contentType matter... thanks for looking after these! So then,
> FreemarkerServlet surely should set the HttpServletResponse contentType when
> it's still null. OTOH there should be an option to only set it then (if it's
> not null), not always as it happens now. So then the "ContetType" init-param
> remains as is, and we add a new init-param, "OverrideResponseContentType"
> (better name?), whose default is true for backward compatibility, but this
> default can be changed to false by extending FreemarkerServlet. WDYT?
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
