Re: Patch on unsupported AT command

2009-11-13 Thread Marcel Holtmann
Hi Yang,

   If some unsupported AT command is issued, different modem may have 
 their own response. Now at my hand is a Huawei modem (EM770W), and it returns 
 COMMAND NOT SUPPORT. In my case, this modem doesn't support AT+CGAUTO=0 
 in atmodem/gprs.c. Current oFono will hang there for it's not a valid return.
   We may have some quirk to handle this problem, the same way as current 
 code in network-registration.c with CALYPSO. But I wonder if it's better to 
 add the response string into terminator table, so that we don't need this 
 kind of quirk here and there. I'm not sure if this is the better/best way to 
 handle this problem. After all, the table may become larger and larger is 
 more and more specific terminator like this are added. 
   Comments are welcome!

this lovely broken Huawei modem where the firmware developers were
incapable of reading the specification and just made up a new response.

I think this might need a GAtChat quirk function where we can add extra
terminator responses that will be recognized. And maybe even translated
into something meaningful.

Denis, or do you want this quirked in every plugin or modem driver?

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: ppp

2009-11-13 Thread Rémi Denis-Courmont

On Thu, 12 Nov 2009 19:39:40 + (GMT), Chris Pitchford
of...@intrepid.cx wrote:
 I'm not sure if the requirements of ppp in the kernel have chagned, but
 couldn't something like this be repeated in this situation.. allowing
pppd
 to speak to a local socket/fifo/pair of pipes that is terminated in user
 space?

In my understanding, PPP is a line discipline, meaning it can only run on a
TTY character device device, not just any character device, and definitely
not any random file descriptor.

-- 
Rémi Denis-Courmont

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: ppp

2009-11-13 Thread Chris Pitchford


Quoting Rémi Denis-Courmont r...@remlab.net:



On Thu, 12 Nov 2009 19:39:40 + (GMT), Chris Pitchford
of...@intrepid.cx wrote:

I'm not sure if the requirements of ppp in the kernel have chagned, but
couldn't something like this be repeated in this situation.. allowing

pppd

to speak to a local socket/fifo/pair of pipes that is terminated in user
space?


In my understanding, PPP is a line discipline, meaning it can only run on a
TTY character device device, not just any character device, and definitely
not any random file descriptor.


turns out that the software I mentioned (virtmodem from 1995) does  
indeed use a pty pair. Although I've not had time during the week to  
get it running again, I suspect it would probably work on a recent  
kernel/pppd.


Is the line discipline so much of an issue when using ppp connected to  
a fake tty? could that not be handed on the proxy side inside ofono?


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: Patch on unsupported AT command

2009-11-13 Thread Marcel Holtmann
Hi Denis,

  I think this might need a GAtChat quirk function where we can add extra
  terminator responses that will be recognized. And maybe even translated
  into something meaningful.
 
 Originally I had the terminators freely definable on the GAtChat + some 
 hardcoded ones, but abandoned that approach since it didn't seem useful.  
 Perhaps this needs to be resurrected.
 
 
  Denis, or do you want this quirked in every plugin or modem driver?
 
 I do prefer non-standard terminators to be setup in the plugin/driver.

I meant adding something like g_at_chat_add_terminator() or so.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: Patch on unsupported AT command

2009-11-13 Thread Denis Kenzior
Hi Marcel,

 Hi Denis,

   I think this might need a GAtChat quirk function where we can add extra
   terminator responses that will be recognized. And maybe even translated
   into something meaningful.
 
  Originally I had the terminators freely definable on the GAtChat + some
  hardcoded ones, but abandoned that approach since it didn't seem useful.
  Perhaps this needs to be resurrected.
 
   Denis, or do you want this quirked in every plugin or modem driver?
 
  I do prefer non-standard terminators to be setup in the plugin/driver.

 I meant adding something like g_at_chat_add_terminator() or so.

Yes, that is what I meant as well.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono