Re: [OpenWrt-Devel] [PATCH-v5] samba 3.0.37 update
2011/9/19 Maarten Bezemer > I was a bit busy lately, so sorry for the late reply. > > Update in this patch (compared to v4): > * Removed ldap, kerebos and activedirectory support > * Added iconv support, by adding --with-libiconv=$(ICONV_PREFIX) as > configure flag and by removing some check (which do not work because of > cross-compilation) > > As usual any replies, comments or critics are still welcome of course. > Although, I got several questions for the patch, so it seems that people > are eager to have this patch added. So maybe if it is acceptable, it > could get commited? As I am still willing to become the maintainer, I'll > continue to try and implement suggestion and ideas. Do I need to do > something to become 'official' maintainer? It doesn't apply here: [jan@srv samba3 (patches)]$ git apply --whitespace=fix -p0 ../../smb.diff net/samba3/files/config-lfs.h:2664: space before tab in indent. slprintf( name, sizeof( name)-1, "%s-%s", program_name, net/samba3/files/config-lfs.h:2665: space before tab in indent. short_configfile ); net/samba3/files/config-lfs.h:2697: space before tab in indent. return dlopen(name, flags); net/samba3/files/config-lfs.h:2700: space before tab in indent. return NULL; net/samba3/files/config-lfs.h:3097: space before tab in indent. return True; error: patch failed: net/samba3/files/samba.init:1 error: net/samba3/files/samba.init: patch does not apply error: patch failed: net/samba3/Makefile:1 error: net/samba3/Makefile: patch does not apply Can you send an update? Also, please create patches in the top-level directory, not net/samba3/ thanks, jan ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH-v5] samba 3.0.37 update
Hi Maarten, 2011/9/19 Maarten Bezemer > I was a bit busy lately, so sorry for the late reply. > > Update in this patch (compared to v4): > * Removed ldap, kerebos and activedirectory support > * Added iconv support, by adding --with-libiconv=$(ICONV_PREFIX) as > configure flag and by removing some check (which do not work because of > cross-compilation) > > As usual any replies, comments or critics are still welcome of course. > Although, I got several questions for the patch, so it seems that people > are eager to have this patch added. So maybe if it is acceptable, it > could get commited? As I am still willing to become the maintainer, I'll > continue to try and implement suggestion and ideas. Do I need to do > something to become 'official' maintainer? It doesn't apply here: [jan@srv samba3 (patches)]$ git apply -p0 ../../smb.diff net/samba3/files/config-lfs.h:2664: space before tab in indent. slprintf( name, sizeof( name)-1, "%s-%s", program_name, net/samba3/files/config-lfs.h:2665: space before tab in indent. short_configfile ); net/samba3/files/config-lfs.h:2697: space before tab in indent. return dlopen(name, flags); net/samba3/files/config-lfs.h:2700: space before tab in indent. return NULL; net/samba3/files/config-lfs.h:3097: space before tab in indent. return True; error: patch failed: net/samba3/files/samba.init:1 error: net/samba3/files/samba.init: patch does not apply error: patch failed: net/samba3/Makefile:1 error: net/samba3/Makefile: patch does not apply Can you send an update? I will commit it then. Also please create patches from the toplevel-directory, not net/samba3 thanks, jan ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH-v5] samba 3.0.37 update
(Got married and just came back from honeymoon, so sorry for the late reply) On Thursday 06 October 2011 11:53:59 Jan Willies wrote: > Hi Maarten, > > Can you send an update? I will commit it then. I saw that the package got modified to use the new service functions (see #29075), so I'll modify my patches again... I guess they will be updated and tested by the end of the day. > Also please create patches from the toplevel-directory, not net/samba3 Will do! Greetings, Maarten ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
