[Bug 1133950] Review Request: mariadb_client - Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases
https://bugzilla.redhat.com/show_bug.cgi?id=1133950 Matej Mužila mmuz...@redhat.com changed: What|Removed |Added CC||mmuz...@redhat.com Flags||fedora-cvs? --- Comment #7 from Matej Mužila mmuz...@redhat.com --- New Package SCM Request === Package Name: mariadb-connector-c Short Description: The MariaDB Native Client library (C driver) Upstream URL: https://mariadb.org/ Owners: mmuzila Branches: f19 f20 f21 InitialCC: mmuzila -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1133950] Review Request: mariadb_client - Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases
https://bugzilla.redhat.com/show_bug.cgi?id=1133950 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- WARNING: Requested package name mariadb-connector-c doesn't match bug summary mariadb_client, please correct. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1133950] Review Request: mariadb_client - Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases
https://bugzilla.redhat.com/show_bug.cgi?id=1133950 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1133950] Review Request: mariadb_client - Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases
https://bugzilla.redhat.com/show_bug.cgi?id=1133950 Honza Horak hho...@redhat.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #6 from Honza Horak hho...@redhat.com --- I don't want to be nit-picker, just few details that would make the spec more close to form what we usually use in Fedora, not that the last one would be explicitly. Just feel free to adopt the changes if you like. Also I've noticed that generated html files have different IDs for every build, which will cause issues on multilib systems. This is not issue for review, but we should take a look to make it work on multilib systems, since -devel packages are often installed this way. Anyway, I don't see any issues blocking the review, so giving ACK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1133950] Review Request: mariadb_client - Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases
https://bugzilla.redhat.com/show_bug.cgi?id=1133950 --- Comment #5 from Matej Mužila mmuz...@redhat.com --- I've made required changes. SRPM: https://mmuzila.fedorapeople.org/mariadb-connector-c-2.0.0-2.fc20.src.rpm SPEC: https://mmuzila.fedorapeople.org/mariadb-connector-c.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1133950] Review Request: mariadb_client - Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases
https://bugzilla.redhat.com/show_bug.cgi?id=1133950
--- Comment #4 from Honza Horak hho...@redhat.com ---
Issues that should be fixed before acking the review:
- LGPLv2+ should be used as a license IMHO
- mariadb_config should be in -devel subpackage.
- ncurses may be removed
- Directory without known owners: /usr/lib64/mariadb
- %{?_smp_mflags} should be used in make call
- there is a typo: '==' instead of '=' in the -devel requirement on the base
package
Things to do, that do not block review (might be done later):
- necessary changes (patch, removing wrongly installed files,
incorrect-fsf-address) should be reported to upstream
- the summary might be shorter, e.g.: The MariaDB Native Client library (C
driver)
- there is %clean; well, it is empty, but should be removed entirely
- egrep can be replaced by grep
Few another suggestions:
- docs can be build using make:
pushd docs
%cmake .
make
popd
- removing files in %install and listing files in %files section is better to
be done by name, more specifically, since that brings it to maintainer's
attention when upstream makes some changes, so e.g.:
%files
%{_libdir}/mariadb/libmariadb.so.2
%{_bindir}/mariadb_config
%doc README COPYING.LIB
%files devel
%{_libdir}/mariadb/libmariadb.so
%{_libdir}/mariadb/libmysql.so
%{_libdir}/mariadb/libmysqlclient.so
%{_libdir}/mariadb/libmysqlclient_r.so
%{_includedir}/mariadb
%doc docs/html
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2 or later), Unknown or generated, LGPL (v2 or later) (with
incorrect FSF address), zlib/libpng, BSD (2 clause), *No copyright*
LGPL (v2 or later) (with incorrect FSF address), PHP (v3.01) LGPL (v2
or later), PHP (v3.01). 21 files have unknown license. Detailed output
of licensecheck in /home/hhorak/tmp/mariadb-native/1133950-mariadb-
connector-c/licensecheck.txt
- LGPLv2+ should be used as a license IMHO
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/mariadb
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
- mariadb_config should be in -devel subpackage.
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
- ncurses may be removed
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 532480 bytes in 100 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot}
[Bug 1133950] Review Request: mariadb_client - Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases
https://bugzilla.redhat.com/show_bug.cgi?id=1133950 --- Comment #3 from Matej Mužila mmuz...@redhat.com --- I've made required changes. Names of SRPM and SPEC file were changed too. SRPM URL: https://mmuzila.fedorapeople.org/mariadb-connector-c-2.0.0-1.src.rpm SPEC URL: https://mmuzila.fedorapeople.org/mariadb-connector-c.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1133950] Review Request: mariadb_client - Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases
https://bugzilla.redhat.com/show_bug.cgi?id=1133950 --- Comment #2 from Honza Horak hho...@redhat.com --- Some notes before doing a proper formal review. Matej, please, look at them and the issues already reported by Christopher and I'll do a proper formal review after these issues are fixed. * Name of the package should be the same as upstream project name if possible, but I'm not sure if tar ball name actually is that name, I'd rather use launchpad's project name mariadb-native-client [1] or even consult the name with upstream. * There should be -devel sub-package created that would include mariadb_config script, header files and unversioned library (link) [2]. * Changelog should contain version-release after packager contact [3]. * Removing $RPM_BUILD_ROOT is not necessary in %install nor %clean have be there any more [4]. * Build should use default compiler flags [5]. * Static libraries should be removed or disabled in cmake, if it is possible, but definitely not packaged [6]. * The tar ball bundles zlib, just be sure it is not compiled and used, and system zlib is used instead. * The doc in xml needs to be generated into html doc first (which needs xmlto package as BuildRequires). The generated docs could be included in the -devel or in a separeted subpackage. * The path to installed libraries is /usr/lib instead of /usr/lib64 on x86_64, some cmake option will have to be used maybe. [1] https://launchpad.net/mariadb-native-client [2] https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages [3] https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs [4] https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean [5] https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags [6] https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1133950] Review Request: mariadb_client - Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases
https://bugzilla.redhat.com/show_bug.cgi?id=1133950 Honza Horak hho...@redhat.com changed: What|Removed |Added CC||hho...@redhat.com Assignee|nob...@fedoraproject.org|hho...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1133950] Review Request: mariadb_client - Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases
https://bugzilla.redhat.com/show_bug.cgi?id=1133950 Christopher Meng i...@cicku.me changed: What|Removed |Added CC||i...@cicku.me --- Comment #1 from Christopher Meng i...@cicku.me --- 1. Do not use -f install_manifest.txt, list files explicitly. 2. BuildRequires: bzr = 2.0 Why? 3. BuildRequires: libtool = 1.5.24 Why? 4. BuildRequires: bison ncurses zlib-devel autoconf automake cmake ncurses is wrong, should be ncurses-devel autoconf and automake are needed by projects using autofools. This project uses cmake. I couldn't see reasons of BRing them. 5. Use %cmake instead of cmake . -DCMAKE_INSTALL_PREFIX=/usr 6. Drop [ $RPM_BUILD_ROOT != / ] rm -rf $RPM_BUILD_ROOT 7. changelog section invalid syntax. 8. License: LGPLv2.1 LGPLv2.1 Wrong 9. Release: 1 Wrong 10. Too long: Summary: Client library used to connect apps. developed in C/C++ to MariaDB and MySQL databases -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
