[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #18 from Fedora Update System --- haxe-3.2.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2015-11-15 22:22:03 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- haxe-3.2.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update haxe' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-b031c6bd08 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #16 from Fedora Update System --- haxe-3.2.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-b031c6bd08 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #15 from Fedora Update System --- haxe-3.2.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- haxe-3.2.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update haxe' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-146c543280 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #13 from Fedora Update System --- haxe-3.2.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-146c543280 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Miroslav Suchý changed: What|Removed |Added Status|NEW |ASSIGNED CC||msu...@redhat.com Blocks|177841 (FE-NEEDSPONSOR) | Assignee|nob...@fedoraproject.org|msu...@redhat.com Flags||fedora-review+ --- Comment #12 from Miroslav Suchý --- > * I'm not sure whether I have to add "Requires" to the debuginfo package. I > browse around the Internet and couldn't find an example of that. No you do not. > I'm not sure about the install error. I do not see this error on my workstation. All issues addressed (I will not past here the review as it is nearly the same as in #5 sans those addressed issues). Andy - Any time you have question about some Fedora process feel free to ask me. I just sponsored you into packager group. APPROVED. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #11 from Andy Li --- I've revised the package as suggested. The updated files: Spec URL: https://dl.dropboxusercontent.com/u/2661116/fedora/haxe/haxe.spec SRPM URL: https://dl.dropboxusercontent.com/u/2661116/fedora/haxe/haxe-3.2.1-1.fc24.src.rpm Summary of changes: * Package the latest upstream version (3.2.1). * Introduce subpackage, haxe-stdlib, for the Haxe standard library to be installed in /usr/share/haxe/. * Fix permission of "haxe". * Add license breakdown in spec. Also requested license fix in https://github.com/HaxeFoundation/haxe/issues/4602. * Fix srpm-spec mismatched versions. Those were introduced by the openSUSE build service I was using. This time I used my machine to build and uploaded to dropbox instead. * Use help2man to generate man pages for haxe and haxelib. * Use pushd/popd instead of cd. Things I'm not sure: * I'm not sure about the install error. I've tested with fedora-review, and there is indeed an error saying "Error: cannot install both haxe-debuginfo-3.2.1-1.fc24.x86_64 and haxe-debuginfo-3.2.1-1.fc24.x86_64" but that's totally weird to me. Full log can be found at https://dl.dropboxusercontent.com/u/2661116/fedora/haxe/root.log. I can manually install the rpms without error by `sudo rpm -i *.rpm`. * I'm not sure whether I have to add "Requires" to the debuginfo package. I browse around the Internet and couldn't find an example of that. * I don't think there is anything that fits into a haxe-devel package. There is no such thing as "to develop software that uses haxe", because haxe itself is a dev tool and it is not designed to be linkable and there is no plug-in system. * The remaining "incorrect-fsf-address" are fixed in upstream. They were fixed by the patch in the first version of this package. I haven't included the patch in the revised package. Thank you and best regards, Andy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Christopher Meng changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #10 from Christopher Meng --- Reset to original status because he needs a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Christopher Meng changed: What|Removed |Added CC||i...@cicku.me Assignee|projects...@smart.ms|nob...@fedoraproject.org Summary|Review Request: Haxe - |Review Request: haxe - |Multi-target universal |Multi-target universal |programming language|programming language Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: Haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Raphael Groner changed: What|Removed |Added Alias||haxe --- Comment #9 from Raphael Groner --- %prep %setup -q cd libs && tar -xf %{SOURCE1} --strip-components=1 && cd .. cd extra/haxelib_src && tar -xf %{SOURCE2} --strip-components=1 && cd ../.. - Use pushd/popd instead of cd, it logs the current working path changes. http://www.eriwen.com/bash/pushd-and-popd/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: Haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #8 from Raphael Groner --- - Maybe execute the tests/ files in %check. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: Haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #7 from Upstream Release Monitoring --- raphgro's scratch build of haxe-3.2.0-9.1.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11418047 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: Haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #6 from Raphael Groner --- Created attachment 1082101 --> https://bugzilla.redhat.com/attachment.cgi?id=1082101&action=edit licensecheck.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: Haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #5 from Raphael Groner --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - Please verify License: tag, there are files with LGPL, GPL (in different versions), BSD and MIT. - Correct the name of SRPM (and link), weird/wrong Release there? - Is it possible to have some development files in a devel subpackage? - Version 3.2.1 is available at upstream, please update. - Use a data sub package for the large content in /usr/share/haxe/ . - Fix at least all errors of rpmlint (optionally plus warnings), see below. = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later) (with incorrect FSF address)", "Unknown or generated", "MIT/X11 (BSD like)", "*No copyright* LGPL (v2.1 or later) (with incorrect FSF address)", "zlib/libpng", "BSD (3 clause)", "GPL (unversioned/unknown version)", "GPL (v2 or later) (with incorrect FSF address)", "BSD (2 clause)", "LGPL (v2.1 or later)", "*No copyright* MIT/X11 (BSD like)". 2086 files have unknown license. Detailed output of licensecheck in /home/builder/fedora- review/1270554-haxe/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. => # note that the Makefile does not support parallel building [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [?]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must matc
[Bug 1270554] Review Request: Haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #4 from Andy Li --- Thanks for the review. Here are the updated files revised according to your comment: Spec URL: https://build.opensuse.org/source/home:onthewings/haxe/haxe.spec SRPM URL: http://download.opensuse.org/repositories/home:/onthewings/Fedora_22/src/haxe-3.2.0-9.1.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: Haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Raphael Groner changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|projects...@smart.ms Flags||fedora-review? --- Comment #3 from Raphael Groner --- # The source of this package was pulled from upstreams's vcs. # It is because the Github-created tar does not inslude submodules. - You may use Source0: and Source1: (value is accessible respectively as %{SOURCE1}) for both individual tar downloads. Arrange the files in %prep after untar with %setup0 and %setup1 or use directly the tar command. - Please remove the now obsolete Group: and Buildroot: tags. # https://github.com/HaxeFoundation/ocamllibs/pull/19 Patch0: haxe-libs-license.patch - It's okay to ask upstream and suggest a patch. But please remove it from the package, license is completely a thing of upstream and shouldn't be modified at all in Fedora. %install rm -rf %{buildroot} - You can remove the rm line, it's useless. - Use cp -p to preserve timestamps. %files %defattr(-,root,root,-) - Please remove %defattr, it's not needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: Haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 --- Comment #2 from Andy Li --- The url to the raw spec is https://build.opensuse.org/source/home:onthewings/haxe/haxe.spec Hope it works for you. Best regards, Andy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: Haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #1 from Raphael Groner --- Please use a valid Spec URL that gives raw content, fedora-review is not able to read html formatted pages, therefore you can ask for some space at fedorapeople.org . Otherwise, I am interested in doing the official review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1270554] Review Request: Haxe - Multi-target universal programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1270554 Andy Li changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=460780 Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review