[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-08-23 21:14:32 EDT --- ranger-1.1.2-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-08-21 00:27:53 EDT --- ranger-1.1.2-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||ranger-1.1.2-2.fc13 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|ranger-1.1.2-2.fc13 |ranger-1.1.2-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-08-21 00:30:44 EDT --- ranger-1.1.2-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 --- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-08-04 13:41:05 EDT --- Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-08-02 19:32:01 EDT --- ranger-1.1.2-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ranger-1.1.2-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-08-02 19:32:07 EDT --- ranger-1.1.2-2.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/ranger-1.1.2-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-08-02 19:31:56 EDT --- ranger-1.1.2-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/ranger-1.1.2-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-08-02 22:13:32 EDT --- ranger-1.1.2-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ranger'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ranger-1.1.2-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 --- Comment #6 from Kevin Fenzi ke...@tummy.com 2010-07-26 18:36:03 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=617797
--- Comment #2 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-07-24
13:44:40 EDT ---
Well, another interesting file manager :)
Some notes:
! python2 vs python3
- As your spec file uses %{python_sitelib} which is python2
specific macro, I think explicitly writing BR: python2-devel
rather than BR: python-devel is preferable.
https://fedoraproject.org/wiki/Packaging/Python#BuildRequires
! BuildRoot
- BuildRoot tag is no longer needed on Fedora (only needed
on EPEL5)
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
! default %setup
- By default %setup uses %{name}-%{version}. so explicitly writing
-n %{name}-%{version} is not needed.
* rpmlint issue
-
ranger.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/ranger/__main__.py 0644L /usr/bin/env
-
- This file need not have shebang.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=617797
--- Comment #3 from Ben Boeckel maths...@gmail.com 2010-07-24 14:29:20 EDT ---
(In reply to comment #2)
Well, another interesting file manager :)
I have another one queued up, but it still needs some work and isn't actively
maintained AFAICS. :)
Some notes:
! python2 vs python3
- As your spec file uses %{python_sitelib} which is python2
specific macro, I think explicitly writing BR: python2-devel
rather than BR: python-devel is preferable.
https://fedoraproject.org/wiki/Packaging/Python#BuildRequires
Done.
! BuildRoot
- BuildRoot tag is no longer needed on Fedora (only needed
on EPEL5)
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
Oops, yeah. rpmdev-newspec template got me here.
! default %setup
- By default %setup uses %{name}-%{version}. so explicitly writing
-n %{name}-%{version} is not needed.
Yeah, I do this out of habit because some of the packages I maintain I do
snapshots at times (Rawhide and my personal repo) and this keeps the diffs low.
Looking closer at the release windows, it looks like I won't need to do many
here. Removing.
* rpmlint issue
-
ranger.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/ranger/__main__.py 0644L /usr/bin/env
-
- This file need not have shebang.
Patch included. Bug filed upstream (link in request).
% lintmock fedora-13-x86_64-bb
ranger.src: W: strange-permission ranger-1.1.2-remove-shebang.patch 0640L
ranger.src: W: strange-permission ranger.spec 0640L
ranger.src: W: strange-permission ranger-1.1.2.tar.gz 0640L
ranger.src: W: no-buildroot-tag
2 packages and 0 specfiles checked; 0 errors, 4 warnings
Spec URL: http://blipper.dev.benboeckel.net/files/pkg/ranger.spec
SRPM URL:
http://blipper.dev.benboeckel.net/yum/13/x86_64/src/ranger-1.1.2-2.fc13.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-07-24 15:40:39 EDT --- Okay. - This package (ranger) is APPROVED by mtasaka - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 Ben Boeckel maths...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Ben Boeckel maths...@gmail.com 2010-07-24 15:51:51 EDT --- New Package CVS Request === Package Name:ranger Short Description: A flexible console file manager Owners: mathstuf Branches:F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617797] Review Request: ranger - A flexible console file manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review? --- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-07-24 00:22:29 EDT --- Hi, Ben: I will review this. Instead I would appreciate it if you would review my review request (bug 617764 , also python package) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
