[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 Hedayat Vatankhah changed: What|Removed |Added CC||heday...@gmail.com AssignedTo|nob...@fedoraproject.org|heday...@gmail.com Flag||fedora-review? --- Comment #1 from Hedayat Vatankhah 2011-04-29 19:20:55 EDT --- Hi! This is my review for your package: MUST Items: RpmLint Output: % rpmlint csdp-6.1.1-1.fc14.src.rpm csdp.src: W: spelling-error %description -l en_US semidefinite -> semi definite, semi-definite, definiteness 1 packages and 0 specfiles checked; 0 errors, 1 warnings. % rpmlint noarch/csdp-octave-6.1.1-1.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. % rpmlint csdp-* csdp.x86_64: W: spelling-error %description -l en_US semidefinite -> semi definite, semi-definite, definiteness csdp.x86_64: W: shared-lib-calls-exit /usr/lib64/libsdp.so.6.1.1 exit@GLIBC_2.2.5 4 packages and 0 specfiles checked; 0 errors, 2 warnings. --- Built successfully in Koji. http://koji.fedoraproject.org/koji/taskinfo?taskID=3036616 Passes other MUST and SHOULD items, including Packaging Guidelines. Some notes before accepting the package: - semidefinite looks like to be an acceptable word, but if semi-definite is a better replacement please replace it - defattr can be removed from the %files sections as recently added to the Packaging Guidelines - Where does Csdp.INDEX file in src.rpm come from? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 Hedayat Vatankhah changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 --- Comment #2 from Jerry James 2011-05-03 13:52:54 EDT --- Thanks for the review! (In reply to comment #1) > - semidefinite looks like to be an acceptable word, but if semi-definite is a > better replacement please replace it All of the web sites that talk about this approach use "semidefinite", so I would like to leave it that way. > - defattr can be removed from the %files sections as recently added to the > Packaging Guidelines Okay. If I don't need to make any other changes, I'll do this before importing the package into git. > - Where does Csdp.INDEX file in src.rpm come from? I made it. I can add a comment to that effect in the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 Hedayat Vatankhah changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Hedayat Vatankhah 2011-05-03 19:19:56 EDT --- (In reply to comment #2) > Thanks for the review! :) You're welcome > > (In reply to comment #1) > > - semidefinite looks like to be an acceptable word, but if semi-definite is > > a > > better replacement please replace it > > All of the web sites that talk about this approach use "semidefinite", so I > would like to leave it that way. OK. > > > - defattr can be removed from the %files sections as recently added to the > > Packaging Guidelines > > Okay. If I don't need to make any other changes, I'll do this before > importing > the package into git. > > > - Where does Csdp.INDEX file in src.rpm come from? > > I made it. I can add a comment to that effect in the spec file. Yes, please add a comment to the spec file about this. Considering that the above 2 minor edits will be applied upon import to git, this package is considered to be APPROVED by me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 Jerry James changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Jerry James 2011-05-03 23:27:33 EDT --- New Package SCM Request === Package Name: csdp Short Description: C library for SemiDefinite Programming Owners: jjames Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 --- Comment #5 from Jason Tibbitts 2011-05-05 14:20:30 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 --- Comment #6 from Fedora Update System 2011-05-05 15:03:12 EDT --- csdp-6.1.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/csdp-6.1.1-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 --- Comment #7 from Fedora Update System 2011-05-05 15:03:19 EDT --- csdp-6.1.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/csdp-6.1.1-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System 2011-05-05 17:52:25 EDT --- csdp-6.1.1-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||csdp-6.1.1-1.fc15 Resolution||ERRATA Last Closed||2011-05-09 23:33:12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 --- Comment #9 from Fedora Update System 2011-05-09 23:33:07 EDT --- csdp-6.1.1-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 --- Comment #10 from Fedora Update System 2011-05-16 20:50:37 EDT --- csdp-6.1.1-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689039 Fedora Update System changed: What|Removed |Added Fixed In Version|csdp-6.1.1-1.fc15 |csdp-6.1.1-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review