[Bug 970956] Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Blocks||1010897 CC||mmcki...@umich.edu --- Comment #10 from Christopher Meng cicku...@gmail.com --- *** Bug 1036299 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1010897 [Bug 1010897] mg-20131118 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970956] Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 --- Comment #9 from Michael Schwendt bugs.mich...@gmx.net --- We don't apply a lib prefix to libraries. We prefer the upstream tarball or project name, which often means the src.rpm %name matches the tarball name. rpm -qf /usr/lib*/lib*.so*|grep -v ^lib|sort|uniq Sometimes, depending on what components a software project builds, it can make sense to build a -libs subpackage. In other cases, the project may include programs, and then the added lib prefix would be a hindrance (and it would be necessary to redefine the binary rpm names completely to be closer to the upstream name). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970956] Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #8 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to Christopher Meng from comment #6) Hi Bjorn, what should I do now? Can I only package headers? I'm not sure, but there was an attempt to do so: https://bugzilla.redhat.com/show_bug.cgi?id=865116 Unfortunately, the review was never completed, because there was no need anymore for it as a dependency for another package. (In reply to Christopher Meng from comment #7) Hi all, before update this review, I want to know which name is better? clens(tarball name) or libclens(more like a library)? There's no unique guideline for, just that: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming You might use the tarball name, but to see directly that it is a library, you might use the lib prefix. It is your choice. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970956] Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 --- Comment #7 from Christopher Meng cicku...@gmail.com --- Hi all, before update this review, I want to know which name is better? clens(tarball name) or libclens(more like a library)? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970956] Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 --- Comment #6 from Christopher Meng cicku...@gmail.com --- Hi Bjorn, what should I do now? Can I only package headers? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L96yS0Q4gca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970956] Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 --- Comment #2 from Christopher Meng cicku...@gmail.com --- (In reply to Björn Esser from comment #1) There's only a static lib generated during %build, which isn't packaged at all. Please get in touch with upstream to have it build a shlib and I'll take another run. Hi, quoted from upstream: Clens is not intended to be a shared library. There is a library that already provides some BSD compatibility functions (libbsd) which clens does not endeavor to imitate. After discussing this with the other folks, we've decided to keep it static only. We do understand the implications of this and think it is quite unfortunate that Fedora policy doesn't provide support for static libraries, but not everything should be a shared library. So I want to make this package like a -devel like pacakge, only ontains headers. Is it OK? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T1Ac4UeQNXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970956] Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 --- Comment #3 from Michael Schwendt mschwe...@gmail.com --- There's a hint in comment 1: | There's only a static lib generated during %build, | which isn't packaged at all. You cannot simply delete the compiled/built library in %install. You need to package it in accordance with https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bucM9ROjT5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970956] Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 --- Comment #4 from Björn Esser bjoern.es...@gmail.com --- (In reply to Michael Schwendt from comment #3) There's a hint in comment 1: | There's only a static lib generated during %build, | which isn't packaged at all. You cannot simply delete the compiled/built library in %install. You need to package it in accordance with https://fedoraproject.org/wiki/Packaging: Guidelines#Packaging_Static_Libraries The other way would be patching Makefile(.am) to build a shlib instead, regenerate with `autoreconf -vfi` (if applicable) and package it that way. Just having headers is usually (best known exception is boost-base, but it's specially designed this way) not enough in C/C++. There need to be binary-libs to link against. Just packaging the static lib is not such a good approach, since on main goal in development of Fedora is to get rid of them. The other problem I see is, if someone ports a daemon-app from bsd to Fedora using libclens-static, usefully hardening this is close to impossible. Linking against static libs doesn't allow PIE and RELRO with immeditate binding. The next question comming into my mind: What does libclens provide additionally to libbsd? Is it really worth the affort? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BwNETTfeY0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970956] Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 --- Comment #5 from Christopher Meng cicku...@gmail.com --- In fact this package is a base of assl: https://opensource.conformal.com/wiki/Agglomerated_SSL -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BFiPQ8ULDVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970956] Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added CC||bjoern.es...@gmail.com --- Comment #1 from Björn Esser bjoern.es...@gmail.com --- There's only a static lib generated during %build, which isn't packaged at all. Please get in touch with upstream to have it build a shlib and I'll take another run. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u345FGxD3Ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
