[Perl/perl5] dcc242: comp/retainedlines.t - use a test case that croaks
Branch: refs/heads/yves/tests_for_20161 Home: https://github.com/Perl/perl5 Commit: dcc2422a6520a2f4bab8703bc96ac4776dda7d72 https://github.com/Perl/perl5/commit/dcc2422a6520a2f4bab8703bc96ac4776dda7d72 Author: Yves Orton Date: 2022-08-27 (Sat, 27 Aug 2022) Changed paths: M t/comp/retainedlines.t Log Message: --- comp/retainedlines.t - use a test case that croaks This is to demonstrate the issue reported in GH Issue #20161, that we leak debug data from eval statements that croak during compilation. We fail test when the parser croaks during compilation, but the old code did not trigger a croak. With this change the test fails in a large number of ways, many of which are false positives. A follow up patch will remove the false positives, but still leave failing tests. Commit: 9887f343227eef26a38171bb309331e129c5b346 https://github.com/Perl/perl5/commit/9887f343227eef26a38171bb309331e129c5b346 Author: Yves Orton Date: 2022-08-27 (Sat, 27 Aug 2022) Changed paths: M t/comp/retainedlines.t Log Message: --- retainedlines.t - deterministic results and fixup tests under failure The existing logic is only "correct" when all the tests pass. When they fail the tests are revealed to be non-determinstic. The other problem is that once a single test case fails and leaks an entry in the stash the following tests are all contaminated and trigger "false failures". The combination makes things look much more broken than they are. This patch fixes the tests so that they are deterministic and the "leaking" between test cases is stopped. Compare: https://github.com/Perl/perl5/compare/dcc2422a6520%5E...9887f343227e
[Perl/perl5] 305697: perl.h - move defines out of incorrect ifdef
Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 305697f3995f7ddfba2e200c5deb2e274e1136c0 https://github.com/Perl/perl5/commit/305697f3995f7ddfba2e200c5deb2e274e1136c0 Author: Yves Orton Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M perl.h Log Message: --- perl.h - move defines out of incorrect ifdef Not sure how that happened in the original commit, but the PERL_RAND_SEED related defines should not be conditional on anything related to doubles.
[Perl/perl5] 289530: DRAFT: Stop parsing on first syntax error.
Branch: refs/heads/yves/stop_first_error Home: https://github.com/Perl/perl5 Commit: 2895300131c8b1a572535a7231f0570a033a27d6 https://github.com/Perl/perl5/commit/2895300131c8b1a572535a7231f0570a033a27d6 Author: Yves Orton Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M embed.fnc M perl.c M perl.h M pod/perldiag.pod M pp_ctl.c M proto.h M t/comp/retainedlines.t M t/lib/croak/toke M t/lib/subs/subs M t/lib/warnings/7fatal M t/lib/warnings/toke M t/op/lex.t M t/op/tie.t M t/run/fresh_perl.t M toke.c Log Message: --- DRAFT: Stop parsing on first syntax error. We try to keep parsing after many types of errors, up to a (current) maximum of 10 errors. Continuing after a semantic error (like undeclared variables) can be helpful, for instance showing a set of common errors, but continuing after a syntax error isn't helpful most of the time and will produce sometimes completely bizarre errors which just obscures the actual error. This patch makes the parser stop after the first syntax error, while preserving the current behavior for other errors. An error is considered a syntax error if the error message from our internals is the literal text "syntax error". This may not be a complete list. This patch will fail test in t/comp/retainedlines.t but what that file tries to testis already buggy, this change just exposes the bug inside of the tests that retainedlines.t runs where it used to not to tickle the bug. More details can be found in GH Issue #20161.
[Perl/perl5] 0d4292: gv.c - use SVf_QUOTEDPREFIX in error message
Branch: refs/heads/yves/quoted_prefix_followup Home: https://github.com/Perl/perl5 Commit: 0d429258d1ae456c9a10c1951487ee9443e3c7d5 https://github.com/Perl/perl5/commit/0d429258d1ae456c9a10c1951487ee9443e3c7d5 Author: Yves Orton Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M gv.c Log Message: --- gv.c - use SVf_QUOTEDPREFIX in error message I overlooked this case when SVf_QUOTEDPREFIX was introduced
[Perl/perl5] 815f7c: Change variable names in test
Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 815f7cab0e120536f5b9091ca1aa117587ed18ea https://github.com/Perl/perl5/commit/815f7cab0e120536f5b9091ca1aa117587ed18ea Author: James E Keenan Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M t/perf/opcount.t Log Message: --- Change variable names in test To avoid "subroutine redefined" warning. For: https://github.com/Perl/perl5/issues/20164
[Perl/perl5] 5104f2: error messages - do not repeat class names twice i...
Branch: refs/heads/yves/no_repeat_package Home: https://github.com/Perl/perl5 Commit: 5104f2c3fe351260e6fb95e34895d49a237b5c7c https://github.com/Perl/perl5/commit/5104f2c3fe351260e6fb95e34895d49a237b5c7c Author: Yves Orton Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M gv.c M pod/perldiag.pod M pp_sys.c M t/lib/warnings/gv M t/op/tie.t M t/run/fresh_perl.t Log Message: --- error messages - do not repeat class names twice in our error messages Showing the classname twice in the error message just increases cognitive load understanding the message when the class/package name is more than a few components long, and can easily make what should be a simple one line error message wrap and be unreadable. We can simply replace the second invocation of the class name by saying "it" instead, and that is what this patch does. It is still friendly, but not repetitive. Thus: $ perl -le'("x" x 50)->new()' Can't locate object method "new" via package "xx" (perhaps you forgot to load "xx"?) at -e line 1. Turns into: $ ./perl -le'("x" x 50)->new()' Can't locate object method "new" via package "xx" (perhaps you forgot to load it?) at -e line 1.
[Perl/perl5] b3a0a5: gv.c - use SVf_QUOTEDPREFIX in error message
Branch: refs/heads/yves/quoted_prefix_followup Home: https://github.com/Perl/perl5 Commit: b3a0a5e1356f495dc935458a9ee5b38085e130f8 https://github.com/Perl/perl5/commit/b3a0a5e1356f495dc935458a9ee5b38085e130f8 Author: Yves Orton Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M gv.c Log Message: --- gv.c - use SVf_QUOTEDPREFIX in error message I overlooked this case when SVf_QUOTEDPREFIX was introduced
[Perl/perl5] 4984cb: perl.h - move defines out of incorrect ifdef
Branch: refs/heads/yves/move_endif Home: https://github.com/Perl/perl5 Commit: 4984cb5d8ae2615a762a0ed4e5cca7e66969271a https://github.com/Perl/perl5/commit/4984cb5d8ae2615a762a0ed4e5cca7e66969271a Author: Yves Orton Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M perl.h Log Message: --- perl.h - move defines out of incorrect ifdef Not sure how that happened in the original commit, but the PERL_RAND_SEED related defines should not be conditional on anything related to doubles.
[Perl/perl5] b3a0a5: gv.c - use SVf_QUOTEDPREFIX in error message
Branch: refs/heads/yves/move_endif Home: https://github.com/Perl/perl5 Commit: b3a0a5e1356f495dc935458a9ee5b38085e130f8 https://github.com/Perl/perl5/commit/b3a0a5e1356f495dc935458a9ee5b38085e130f8 Author: Yves Orton Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M gv.c Log Message: --- gv.c - use SVf_QUOTEDPREFIX in error message I overlooked this case when SVf_QUOTEDPREFIX was introduced Commit: f1886e10a63297209ad9c385b054717c4a089d8b https://github.com/Perl/perl5/commit/f1886e10a63297209ad9c385b054717c4a089d8b Author: Yves Orton Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M perl.h Log Message: --- perl.h - move defines out of incorrect ifdef Not sure how that happened in the original commit, but the PERL_RAND_SEED related defines should not be conditional on anything related to doubles. Commit: ebc2efe6583f7cf7ea29a7f94f7b7887a75ad3a7 https://github.com/Perl/perl5/commit/ebc2efe6583f7cf7ea29a7f94f7b7887a75ad3a7 Author: Yves Orton Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M gv.c M pod/perldiag.pod M pp_sys.c M t/lib/warnings/gv M t/op/tie.t M t/run/fresh_perl.t Log Message: --- error messages - do not repeat class names twice in our error messages Showing the classname twice in the error message just increases cognitive load understanding the message when the class/package name is more than a few components long, and can easily make what should be a simple one line error message wrap and be unreadable. We can simply replace the second invocation of the class name by saying "it" instead, and that is what this patch does. It is still friendly, but not repetitive. Thus: Compare: https://github.com/Perl/perl5/compare/b3a0a5e1356f%5E...ebc2efe6583f
[Perl/perl5] 15e081: [doc] Update File::stat synopsis
Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 15e0811d172ece0da5948cb83a0af21ba2a34569 https://github.com/Perl/perl5/commit/15e0811d172ece0da5948cb83a0af21ba2a34569 Author: Elvin Aslanov Date: 2022-08-26 (Fri, 26 Aug 2022) Changed paths: M lib/File/stat.pm Log Message: --- [doc] Update File::stat synopsis Added `my` to Synopsis for better practice. Repository points to GH: https://metacpan.org/pod/File::stat