D11631: Fixes pixelated icon scaling for HiDPI screens This enables HiDPI pixmaps in the main window. This commit also replaces QPixmap and KIconLoader with QIcon to load properly scaled icons in the

[Andrew Crouthamel]

acrouthamel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
acrouthamel requested review of this revision.

TEST PLAN
  Open icon selection in main window. Expand tree menu and ensure selection 
works.

REPOSITORY
  R103 KMenu Editor

BRANCH
  fix-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11631

AFFECTED FILES
  main.cpp
  treeview.cpp

To: acrouthamel
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11253: Improve discoverability for changing the wallpaper

[Richard Bowen]

richardbowen added a comment.


  In D11253#232632 , @ngraham wrote:
  
  > In D11253#232607 , @richardbowen 
wrote:
  >
  > > Since wallpaper is a feature of the desktop I don't think mentioning 
wallpaper in the context menu title is necessary.
  >
  >
  > The entire point of this patch is my assertion that making the mental leap 
"desktop contains wallpaper" is too high a bar for many users. It's obvious for 
developers like us, but for normal users, it's... less than obvious.
  >
  > > the word "Configure" is used throught plasma so  maybe that's a case to 
work with it.
  >
  > That was what I started with, but people thought "Configure Desktop and 
Wallpaper" was too long.
  
  
  I just asked my sister who never tried to change the desktop wallpaper on a 
computer before to change the wallpaper on Plasma and...she did, quite easily. 
She right clicked, read the menu options, and chose the one that made sense. I 
think you underestimate the general user.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11253: Improve discoverability for changing the wallpaper

[Nathaniel Graham]

ngraham added a comment.


  In D11253#232607 , @richardbowen 
wrote:
  
  > Since wallpaper is a feature of the desktop I don't think mentioning 
wallpaper in the context menu title is necessary.
  
  
  The entire point of this patch is my assertion that making the mental leap 
"desktop contains wallpaper" is too high a bar for many users. It's obvious for 
developers like us, but for normal users, it's... less than obvious.
  
  > the word "Configure" is used throught plasma so  maybe that's a case to 
work with it.
  
  That was what I started with, but people thought "Configure Desktop and 
Wallpaper" was too long.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11561: fix typos in UI strings

[Frederik Schwarzer]

schwarzer closed this revision.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D11561

To: schwarzer, ivan, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11561: fix typos in UI strings

[Frederik Schwarzer]

schwarzer added a comment.


  In D11561#231670 , @ivan wrote:
  
  > You can also switch to 'can't' as far as I'm concerned
  
  
  "can't" should not be used in formal writings. Not sure how formal 
documentation is considered to be.

REPOSITORY
  R845 Plasma Vault

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11561

To: schwarzer, ivan, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11253: Improve discoverability for changing the wallpaper

[Richard Bowen]

richardbowen added a comment.


  Since wallpaper is a feature of the desktop I don't mentioning wallpaper in 
the context menu title is necessary. "Configure Desktop" sounds a little 
technical but with the wallpaper image beside it it should be more clear. the 
word Configure is used throught plasma so  maybe thats a case to work with it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10184: Port mediawiki runner to Plasma5/Qt5

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:d9d708debf6c: Port mediawiki runner to Plasma5/Qt5 
(authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10184?vs=26662=30363

REVISION DETAIL
  https://phabricator.kde.org/D10184

AFFECTED FILES
  runners/CMakeLists.txt
  runners/mediawiki/CMakeLists.txt
  runners/mediawiki/mediawiki.cpp
  runners/mediawiki/mediawiki.h
  runners/mediawiki/mediawikirunner.cpp
  runners/mediawiki/mediawikirunner.h
  runners/mediawiki/plasma-runner-techbase.desktop
  runners/mediawiki/plasma-runner-userbase.desktop
  runners/mediawiki/plasma-runner-wikipedia.desktop
  runners/mediawiki/plasma-runner-wikitravel.desktop

To: kossebau, broulik, jriddell, davidedmundson, sebas, mart
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 88 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/88/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 24 Mar 2018 00:06:23 +
 Build duration:
1 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 67.69 KB...]JAVA_HOME = '/usr/local/openjdk8-jre'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at CMakeLists.txt:27 (include):  include could not find load file:ECMSetupQtPluginMacroNames-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.45.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.45.0") -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.45.0") -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5XmlGui: /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.45.0") -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.45.0") -- Found KF5Package: /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.45.0") -- Found KF5Kirigami2: /usr/home/jenkins/install-prefix/lib/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.45.0") -- Found KF5Wayland: /usr/home/jenkins/install-prefix/lib/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5: success (found suitable version "5.45.0", minimum required is "5.44.0") found components:  Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 Wayland DocTools -- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so-- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so - found-- 

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 87 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/87/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 23 Mar 2018 23:45:08 +
 Build duration:
1 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 67.99 KB...]JOB_NAME  = 'Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9'JENKINS_NODE_COOKIE   = '93e11c73-78bb-48e7-8528-9fd413aea83a'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at CMakeLists.txt:27 (include):  include could not find load file:ECMSetupQtPluginMacroNames-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.45.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.45.0") -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.45.0") -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5XmlGui: /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.45.0") -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.45.0") -- Found KF5Package: /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.45.0") -- Found KF5Kirigami2: /usr/home/jenkins/install-prefix/lib/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.45.0") -- Found KF5Wayland: /usr/home/jenkins/install-prefix/lib/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5: success (found suitable version "5.45.0", minimum required is "5.44.0") found components:  Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 Wayland DocTools -- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so-- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so - found-- Looking for gethostbyname-- 

D11625: Unify padding on all sides of app icons in delegates

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11625

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11625: Unify padding on all sides of app icons in delegates

[Nathaniel Graham]

ngraham updated this revision to Diff 30356.
ngraham added a comment.


  Very very slightly increase padding (2 -> 3) in compact mode for better 
aesthetics

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11625?vs=30354=30356

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11625

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11625: Unify padding on all sides of app icons in delegates

[Nathaniel Graham]

ngraham updated this revision to Diff 30354.
ngraham added a comment.


  Improve spacing in compact view with this new style

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11625?vs=30353=30354

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11625

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11625: Unify padding on all sides of app icons in delegates

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Without this patch, delegate app icons got more padding on the top and bottom 
than they did on the sides, which was especialyl noticeable with icons that are 
square or fit into a square.
  
  This patch makes sides of the icon get the same padding, improving the 
presentation.

TEST PLAN
  [images go here]

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11625

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 250 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.9/250/
 Project:
Plasma plasma-framework kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 23 Mar 2018 19:02:41 +
 Build duration:
6 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)49%
(78/159)49%
(78/159)39%
(5251/13482)29%
(3041/10583)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(26/26)100%
(26/26)96%
(1099/1144)50%
(746/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core56%
(10/18)56%
(10/18)33%
(753/2267)27%
(403/1494)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma64%
(14/22)64%
(14/22)49%
(1712/3515)37%
(1081/2917)src.plasma.packagestructure57%
(4/7)57%
(4/7)35%
(51/144)43%
(6/14)src.plasma.private58%
(14/24)58%
(14/24)59%
(961/1637)41%
(458/1121)src.plasma.scripting67%
(2/3)67%
(2/3)21%
(36/168)11%
(15/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)29%
(594/2018)18%
(327/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid33%
(2/6)33%
(2/6)1%
(14/1179)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/62)0%
(0/16)tests.testengine0%

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 86 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/86/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 23 Mar 2018 19:02:41 +
 Build duration:
1 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 67.57 KB...]PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'MM_CHARSET= 'UTF-8'JENKINS_HOME  = '/home/production/data'BUILD_TAG = 'jenkins-Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9-86'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at CMakeLists.txt:27 (include):  include could not find load file:ECMSetupQtPluginMacroNames-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.45.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.45.0") -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.45.0") -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5XmlGui: /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.45.0") -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.45.0") -- Found KF5Package: /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.45.0") -- Found KF5Kirigami2: /usr/home/jenkins/install-prefix/lib/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.45.0") -- Found KF5Wayland: /usr/home/jenkins/install-prefix/lib/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5: success (found suitable version "5.45.0", minimum required is "5.44.0") found components:  Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 Wayland DocTools -- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so-- Looking for XOpenDisplay in 

D10234: LibInput: Queue native libinput events instead of LibInput::Event

[Fabian Vogt]

fvogt abandoned this revision.
fvogt added a comment.


  In D10234#232304 , @mart wrote:
  
  > for @fvogt: as an alternative approach has been pushed, can this be closed?
  
  
  Yup.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10234

To: fvogt, #plasma, graesslin
Cc: mart, kwin, plasma-devel, #kwin, iodelay, zzag, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D9875: Extend parsing ssh prompt

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  Sorry that you had to wait so long - it seems there's no active maintainer 
for this.
  
  I just wanted to give this a try. Unfortunately the patch doesn't apply to 
current master anymore. Can you rebase?
  
  Phab says the same, "Context not available."

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: pali, fvogt
Cc: fvogt, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:45a19fa16c45: Remove long-time deprecated Encoding=UTF-8 
from desktop format files (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11563?vs=30164=30338

REVISION DETAIL
  https://phabricator.kde.org/D11563

AFFECTED FILES
  applets/appmenu/package/metadata.desktop
  applets/batterymonitor/package/metadata.desktop
  applets/calendar/package/metadata.desktop
  applets/digital-clock/package/metadata.desktop
  applets/lock_logout/metadata.desktop
  applets/mediacontroller/metadata.desktop
  applets/notifications/package/metadata.desktop
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/metadata.desktop
  applets/systemtray/container/package/metadata.desktop
  applets/systemtray/package/metadata.desktop
  dataengines/executable/plasma-dataengine-executable.desktop
  dataengines/favicons/plasma-dataengine-favicons.desktop
  dataengines/geolocation/plasma-dataengine-geolocation.desktop
  dataengines/network/plasma-dataengine-network.desktop
  dataengines/packagekit/plasma-dataengine-packagekit.desktop
  dataengines/rss/plasma-dataengine-rss.desktop
  dataengines/systemmonitor/plasma-dataengine-systemmonitor.desktop
  kioslave/desktop/Home.desktop
  kioslave/desktop/directory.desktop
  kioslave/desktop/directory.trash
  lookandfeel/metadata.desktop
  menu/desktop/hidden.directory
  menu/desktop/kf5-development-translation.directory
  menu/desktop/kf5-development-webdevelopment.directory
  menu/desktop/kf5-development.directory
  menu/desktop/kf5-editors.directory
  menu/desktop/kf5-edu-languages.directory
  menu/desktop/kf5-edu-mathematics.directory
  menu/desktop/kf5-edu-miscellaneous.directory
  menu/desktop/kf5-edu-science.directory
  menu/desktop/kf5-edu-tools.directory
  menu/desktop/kf5-education.directory
  menu/desktop/kf5-games-arcade.directory
  menu/desktop/kf5-games-board.directory
  menu/desktop/kf5-games-card.directory
  menu/desktop/kf5-games-kids.directory
  menu/desktop/kf5-games-logic.directory
  menu/desktop/kf5-games-roguelikes.directory
  menu/desktop/kf5-games-strategy.directory
  menu/desktop/kf5-games.directory
  menu/desktop/kf5-graphics.directory
  menu/desktop/kf5-internet-terminal.directory
  menu/desktop/kf5-internet.directory
  menu/desktop/kf5-main.directory
  menu/desktop/kf5-more.directory
  menu/desktop/kf5-multimedia.directory
  menu/desktop/kf5-office.directory
  menu/desktop/kf5-science.directory
  menu/desktop/kf5-settingsmenu.directory
  menu/desktop/kf5-system-terminal.directory
  menu/desktop/kf5-system.directory
  menu/desktop/kf5-toys.directory
  menu/desktop/kf5-unknown.directory
  menu/desktop/kf5-utilities-accessibility.directory
  menu/desktop/kf5-utilities-desktop.directory
  menu/desktop/kf5-utilities-file.directory
  menu/desktop/kf5-utilities-peripherals.directory
  menu/desktop/kf5-utilities-pim.directory
  menu/desktop/kf5-utilities-xutils.directory
  menu/desktop/kf5-utilities.directory
  plasma.desktop.cmake
  plasmawayland.desktop.cmake
  wallpapers/color/metadata.desktop
  wallpapers/image/imagepackage/metadata.desktop
  wallpapers/image/slideshowpackage/metadata.desktop

To: kossebau, #plasma, fvogt, broulik, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10263: Fix being unable to close the toolbox menu by clicking outside

[Eike Hein]

hein added a comment.


  Yup.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10263

To: hein, #plasma, mart
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Nathaniel Graham]

ngraham added a comment.


  All right, how about this?
  
  F5763759: Better 2.png 
  
  F5763758: better.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Nathaniel Graham]

ngraham updated this revision to Diff 30327.
ngraham added a comment.


  Use a more appropriate icon and shorten the string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11253?vs=30313=30327

BRANCH
  arcpatch-D11253

REVISION DETAIL
  https://phabricator.kde.org/D11253

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11516: use plasma_install_bundled_package

[Friedrich W . H . Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> mart wrote in main.qml:24
> ah, to me it appeared to break fifteenpuzzle, can you test if also for you 
> using the qrc way, but keeping this unaltered, breaks it?

Sadly cannot test currently, self-compiled plasma-frameworks in custom prefix 
started to fail/conflict somewhere with system one recently.

Given the Private is not used, so this seems just done to move qml 
class/symbols out of global namespace, could possibly the whole "import" be 
removed? Or would it still be needed for some secret init triggered by that?

> kossebau wrote in fifteenpuzzleplugin.cpp:32
> Unrelated?

What is the purpose of this line in general? I do not understand the purpose, 
both with old qmlName and new qmlName argument.

It was also not discussed in https://git.reviewboard.kde.org/r/120949/ so 
picture me with big ? in my eyes :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11516

To: mart, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 30325.
progwolff added a comment.


  - giant comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28856=30325

BRANCH
  arcpatch-D11064

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart, davidedmundson, ngraham
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10234: LibInput: Queue native libinput events instead of LibInput::Event

[Marco Martin]

mart added a comment.


  for @fvogt: as an alternative approach has been pushed, can this be closed?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10234

To: fvogt, #plasma, graesslin
Cc: mart, kwin, plasma-devel, #kwin, iodelay, zzag, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D11516: use plasma_install_bundled_package

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:c505a726b3f1: use plasma_install_bundled_package 
(authored by mart).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11516?vs=30297=30324

REVISION DETAIL
  https://phabricator.kde.org/D11516

AFFECTED FILES
  CMakeLists.txt
  applets/CMakeLists.txt
  applets/binary-clock/CMakeLists.txt
  applets/calculator/CMakeLists.txt
  applets/colorpicker/CMakeLists.txt
  applets/comic/CMakeLists.txt
  applets/dict/CMakeLists.txt
  applets/diskquota/CMakeLists.txt
  applets/fifteenPuzzle/CMakeLists.txt
  applets/fifteenPuzzle/package/contents/ui/main.qml
  applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp
  applets/fuzzy-clock/CMakeLists.txt
  applets/grouping/CMakeLists.txt
  applets/grouping/container/CMakeLists.txt
  applets/mediaframe/CMakeLists.txt
  applets/minimizeall/CMakeLists.txt
  applets/notes/CMakeLists.txt
  applets/quicklaunch/CMakeLists.txt
  applets/quickshare/CMakeLists.txt
  applets/showdesktop/CMakeLists.txt
  applets/systemloadviewer/CMakeLists.txt
  applets/timer/CMakeLists.txt
  applets/userswitcher/CMakeLists.txt
  applets/weather/CMakeLists.txt
  applets/webbrowser/CMakeLists.txt

To: mart, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10263: Fix being unable to close the toolbox menu by clicking outside

[Marco Martin]

mart added a comment.


  still can't reproduce the popup not closing when clicking on empty areas of 
desktop, does the problem persists for you?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10263

To: hein, #plasma, mart
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

[Nathaniel Graham]

ngraham added a comment.


  FYI Linus doesn't have a developer account, so someone will need to commit 
this for him.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D10304

REVISION DETAIL
  https://phabricator.kde.org/D10305

To: lshoravi, #plasma, #plasma_accessibility, mart
Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update

[Marco Martin]

mart added a comment.


  janitor message: review process on this should start again (or abandoned if 
doesn't make sense anymore)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10291

To: graesslin, #kwin, #plasma
Cc: mart, romangg, plasma-devel, kwin, iodelay, zzag, bwowk, ZrenBot, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

[Marco Martin]

mart added a comment.


  any update on this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces, hein
Cc: mart, mwolff, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10344: Create panel on current screen

[Marco Martin]

mart added a comment.


  btw, this  was ignored for a long time as there weren't reviewers specified

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10344

To: hoffmannrobert, #plasma
Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10344: Create panel on current screen

[Marco Martin]

mart added a comment.


  I like the idea, needs a bit of thinking to work on wayland

INLINE COMMENTS

> shellcorona.cpp:1816
> +// find out current screen to create new panels on
> +const QPoint cursorPos(QCursor::pos());
> +int screenNum = -1;

this is probably going to break in Wayland.. maybe with an heuristic which 
takes the current focus window of the app?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10344

To: hoffmannrobert
Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10429: Disable the title bar separator by default

[Nathaniel Graham]

ngraham added a comment.


  +1 for tri-state as a compromise, but I still don't really see the point, as 
in Breeze light it's almost invisible even when on. Would also approve of 
off-by-default or even removing it entirely.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10429

To: fvogt, #vdg, #plasma, ngraham
Cc: mart, abetts, rizzitello, mmustac, broulik, anthonyfieroni, januz, 
rikmills, anemeth, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D10383: Fix pinning apps when their .desktop file has a space in the file name.

[Marco Martin]

mart added a comment.


  any update on this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10383

To: hein, #plasma, broulik, ivan
Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10429: Disable the title bar separator by default

[Marco Martin]

mart added a comment.


  shouldn't make it worse for everybody to make it better for the subset who 
use a dark theme.
  at most, should be if the palette color is darker than something, draw it, 
otherwise don't
  
  so +1 for 3state

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10429

To: fvogt, #vdg, #plasma, ngraham
Cc: mart, abetts, rizzitello, mmustac, broulik, anthonyfieroni, januz, 
rikmills, anemeth, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D11516: use plasma_install_bundled_package

[Marco Martin]

mart added a comment.


  In D11516#232097 , @kossebau wrote:
  
  > Cannot test at the moment, but looks straight forward, so no objection from 
me.
  >
  > Besides the unrelated changes, they want to have their own commits :)

INLINE COMMENTS

> kossebau wrote in main.qml:24
> Unrelated?

ah, to me it appeared to break fifteenpuzzle, can you test if also for you 
using the qrc way, but keeping this unaltered, breaks it?

REPOSITORY
  R114 Plasma Addons

BRANCH
  phab/bundle

REVISION DETAIL
  https://phabricator.kde.org/D11516

To: mart, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> progwolff wrote in previewrenderengine.cpp:136
> It's a bug in Qt: https://bugreports.qt.io/browse/QTBUG-38127
> 
> Workaround: set the sourceSize to something.

can you put the workaround with a giant comment that points to the qt bug?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson, ngraham
Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

[Friedrich W . H . Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> ConfigWeatherStation.qml:33
> +
> +property bool acceptOnReturnPressed: !searchStringEdit.activeFocus || 
> searchStringEdit.length === 0
>  

could be "readonly property" as well, no?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10660

To: broulik, #plasma, kossebau
Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10660: [Weather applet] Let Return invoke search

[Marco Martin]

mart added a comment.


  yeah, for me that other patch is ok, is not optimal but should all be 
documented in line in that file
  
  maaaybe introducing a root component for those config uis.. not sure

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10660

To: broulik, #plasma, kossebau
Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10659: [AppletConfiguration] Let applet override Return closing the dialog

[Marco Martin]

mart added a comment.


  to me is fine..
  already the  main item can implement functions that can do $stuff, which is 
not abvious and could be bertter.
  i guess the best thing is to put a big text comment here what are the 
supported comments/functions

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10659

To: broulik, #plasma, kossebau
Cc: mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D10660: [Weather applet] Let Return invoke search

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D10660#232255 , @mart wrote:
  
  > any news on this?
  
  
  Blocked a little by me having the desire to have the secret API used here 
made public documented, cmp. question to you in 
https://phabricator.kde.org/D10659#212230
  
  No alternative solution from myself otherwise, so if you think this is a 
future-proof solution, fine with me.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10660

To: broulik, #plasma, kossebau
Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11611: Move to KRunner's second results item with a single keypress

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11611

To: ngraham, #plasma, broulik, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

[Marco Martin]

mart added a comment.


  any news on this?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10660

To: broulik, #plasma, kossebau
Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10855: Emit clicked when double click expires

[Marco Martin]

mart added a comment.


  on the link i see mostly the motivation as a personal opinion of Thomas L.
  The fact i kinda defend this diff is that the vdg is pushing to limit and 
drop the long press buttons menus on most places.
  this is a thing i think should take proper discussion in the vdg and codified 
as a specific HIG, whatever the final outcome is

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10855

To: broulik, #plasma, graesslin
Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11611: Move to KRunner's second results item with a single keypress

[Nathaniel Graham]

ngraham updated this revision to Diff 30319.
ngraham added a comment.


  Also don't lose focus when there are no search results

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11611?vs=30311=30319

BRANCH
  fix-krunner-double-down-key-issue (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11611

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: ngraham, #plasma, broulik, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10838: [joystick kcm] Fix translation catalog name to follow patterns

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1e266200ecae: [joystick kcm] Fix translation catalog name 
to follow patterns (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10838?vs=28051=30318#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10838?vs=28051=30318

REVISION DETAIL
  https://phabricator.kde.org/D10838

AFFECTED FILES
  kcms/hardware/joystick/CMakeLists.txt
  kcms/hardware/joystick/Messages.sh

To: kossebau, #plasma, kde-i18n-doc, davidedmundson
Cc: ltoscano, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10850: Rename wallpaper translation catalogs to follow pattern

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f945ad4bae01: Rename wallpaper translation catalogs to 
follow pattern (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10850?vs=28087=30317

REVISION DETAIL
  https://phabricator.kde.org/D10850

AFFECTED FILES
  wallpapers/color/Messages.sh
  wallpapers/color/contents/ui/config.qml
  wallpapers/image/CMakeLists.txt
  wallpapers/image/Messages.sh
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml

To: kossebau, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11611: Move to KRunner's second results item with a single keypress

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  I guess this could go into 5.12 also

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-krunner-double-down-key-issue (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11611

To: ngraham, #plasma, broulik, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[David Edmundson]

davidedmundson added a comment.


  There's a pre-existing discussion on bugzilla about the latter comment.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Marco Martin]

mart added a comment.


  active window control is a 3rd party plasmoid, right?

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

To: Pitel, #plasma, martinkostolny
Cc: mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D11613: call beginRemoveRows before removing the data

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It's perfectly valid to call ::data() from within beginRemoveRows, proxy
  models will do it all the time. Also at the time of calling rowCount()
  should be correct at the time of calling beginRemoveRows, this throws an
  assert on Qt5.11.
  
  This patch follows the normal beginRemoveRows / actual removal /
  endRemoveRows policy.
  
  Data insertion is unchaged in this patch, it's less of an issue to have
  data before you announce it than the other way round.

TEST PLAN
  Plasma stayed up for more than a few minutes

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11613

AFFECTED FILES
  src/maps.h
  src/pulseaudio.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Marco Martin]

mart added a comment.


  In D11253#232219 , @richardbowen 
wrote:
  
  > Also how about a preferences shortcut for "Desktop Wallpaper" (or some 
other suitable text) searchable from the start menu and krunner? This would be 
similar to the other desktop preferences that are searchable like "Desktop 
Theme", "Desktop Effects", etc..
  >
  > F5763672: Screenshot_20180323_085008.png 
 F5763671: Screenshot_20180323_085252.png 

  
  
  from an ui pov makes sense, tough may not be super easy as wallpaper config 
is not a kcm.. perhaps a dbus methos exposed by plasmashell

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Richard Bowen]

richardbowen added a comment.


  Also how about a preferences shortcut for "Desktop Wallpaper" (or some other 
suitable text) searchable from the start menu and krunner? This would be 
similar to the other desktop preferences that are searchable like "Desktop 
Theme", "Desktop Effects", etc..
  
  F5763672: Screenshot_20180323_085008.png 
 F5763671: Screenshot_20180323_085252.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11073: [RFC] [Active Window Control] Elide appmenu when it is too long

[Marco Martin]

mart added a comment.


  we are starting to use more the "overflow-menu" icon for this use case

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11073

To: Pitel, #plasma, martinkostolny
Cc: mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D10838: [joystick kcm] Fix translation catalog name to follow patterns

[Luigi Toscano]

ltoscano added a comment.


  Historical note: the few kcm catalogs called kcm5_ have been renamed by 
me to avoid conflict with the files with kde-runtime, which is co-installable 
with KF5. While this is not going to be a problem for the transition between 
KF5 and KF6, we can never be sure that we won't have some KCM required at the 
same time in both versions, so better be safe with a small change now (given 
that we need to rename the catalog anyway). Same for any future KCM :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improvekcmjoystickcatalogname

REVISION DETAIL
  https://phabricator.kde.org/D10838

To: kossebau, #plasma, kde-i18n-doc, davidedmundson
Cc: ltoscano, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Nathaniel Graham]

ngraham updated this revision to Diff 30313.
ngraham added a comment.


  Rebase on master, it's been a while

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11253?vs=29300=30313

BRANCH
  arcpatch-D11253

REVISION DETAIL
  https://phabricator.kde.org/D11253

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Richard Bowen]

richardbowen added a comment.


  In D11253#232189 , @mart wrote:
  
  > what about as text using Configure-desktop and as icon 
preferences-desktop-wallpaper?F5763655: Spectacle.T27450.png 

  
  
  +1
  
  A big part of the desktop experience is the wallpaper so this looks good. 
Also the wallpaper setting is the first option in the "Configure Desktop" 
window so having this as the wallpaper icon beside "Configure Desktop" gives a 
good hint that setting the wallpaper is a function of Configure Desktop.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11611: Move to KRunner's second results item with a single keypress

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, to navigate the list of results after typing a search term, you 
need to press the down arrow twice: first to focus the result list, and a 
second time to actually change the selection. This patch fixes that by changing 
the selection during the focus oprtation.
  
  BUG: 392197

TEST PLAN
  Deployed change, killed, restarted, and activated KRunner, typed a search term
  
  - The down arrow key now moves to the second item
  - Clicked on the text field; up arrow now moved to the previous item in the 
results list
  
  Activating the Open Containing Folder button for the first result via the 
keyboard changes slightly with this patch:
  
  - Currently, it's down arrow > tab key
  - With this patch, it's tab key three times or down arrow > shift + tab
  
  Seems like an acceptable change to me to better support the common case of 
just wanting to navigate the list items

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-krunner-double-down-key-issue (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11611

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: ngraham, #plasma, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11220: option to force FolderView icon-only presentation

[Marco Martin]

mart added a comment.


  i don't see much use case for it, but...
  Eike, i think the final word would be up to you, what do you think about it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart, hein
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D10838: [joystick kcm] Fix translation catalog name to follow patterns

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D10838#230049 , @ltoscano wrote:
  
  > (you can add the #Localization 
 group too)
  >
  > I would suggest kcm5_joystick in order to be future-proof.
  
  
  Okay. Had proposed just "kcm" as the majority of existing catalogs is 
prefixed like that (consistency), and just a few have kcm5, so any next-gen 
plasma6 versions would need to bump all to kcm6 anyway to avoid conflicts, but 
might not hurt to apply versioning already now when touching anyway, so people 
get used to the concept :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improvekcmjoystickcatalogname

REVISION DETAIL
  https://phabricator.kde.org/D10838

To: kossebau, #plasma, kde-i18n-doc, davidedmundson
Cc: ltoscano, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Marco Martin]

mart added a comment.


  what about as text using Configure-desktop and as icon 
preferences-desktop-wallpaper?F5763655: Spectacle.T27450.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11262: KDE logout screen background color fix

[Marco Martin]

mart added a comment.


  In D11262#224843 , @Pitel wrote:
  
  > I see that relative luminance formula is more correct but I would like to 
point out that we do not need here to calculate precise luminance. The point of 
the `?:` statement is to collapse colors close to back to real black because 
gray overlay with 50 % opacity does not look good. So the current formula looks 
good enough for me and I would even think about moving the threshold down a bit 
to 0.4 or 0.3. (Generally not collapsing to black is the save way, it may not 
look so good but the text will be still easy to read.)
  
  
  yep, gray background definitely doesn't look good.
  can you try with the luminance formula and put a screenshot on how it looks?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11410: [RFC] Add option to make applet fixed width

[Marco Martin]

mart added a comment.


  In D11410#229494 , @Pitel wrote:
  
  > In D11410#229277 , @mart wrote:
  >
  > > it's moving on the right track.. i would like the checkbox to appear like 
the one in the panel spacer, in the context menu could be tricky as would need 
to inject into the applet's contextualactons, so let's forget about it for now.
  >
  >
  > I'm not sure that is good idea: There are already some items injected in 
context menus (e.g. Unlock widgets action) and looking at my panel some 
applets' context menus are not injected. I believe it is because they have 
multiple menus bound to specific parts of itself and only applet's global menu 
is (and can) be injected. Most notable examples are systray except the 
expansion arrow and task icon manager except empty space (if it has set 
`fixedWidth` I was unable to find a place in it which would show me context 
menu containing Unlock widget action).
  
  
  I'm fine with dropping the context menu action, would be nice for the spacer 
to share the same mechanism and ui, definitely!
  
  >> one thing that could be done is to put that button in the applet handle 
that appears on hover when the panel controller is open, with the same icon of 
the add panel spacer in a checkable toolbutton (just icon, tooltip on hover) 
the panel spacer should use the same config ui.
  > 
  > The combox is currently in the popup showing on hover when panel controller 
is open. I can make it replace spacer's specific option. I can just remove 
spacer's option from its context menu and add some temporary code to convert 
spacer's option into the new one. (And a few version later we can drop this 
code.) Is it what you meant or did I misunderstand you?
  
  i would like it as a checkable toolbutton with no label (but a tooltip) in 
handleRow, between configureButton and the label

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11410

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D10838: [joystick kcm] Fix translation catalog name to follow patterns

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  If toscano is for it, then I'm for it.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improvekcmjoystickcatalogname

REVISION DETAIL
  https://phabricator.kde.org/D10838

To: kossebau, #plasma, kde-i18n-doc, davidedmundson
Cc: ltoscano, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11352: [RFC] Auto ordered systray

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> AbstractItem.qml:80
>  
> -onEffectiveStatusChanged: updateItemVisibility(abstractItem);
> +property int creationId // used for item order tie breaking
> +onEffectiveStatusChanged: updateItemVisibility(abstractItem)

This is probably not necessary: both plasmoids and statusnotifieritems have ids 
that you can access (numeric for plasmoids, alphanumeric for statusnotifiers, 
which would then make them ordered after plasmoids but that's fine)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart
Cc: ngraham, wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11182: org.freedesktop.PowerManagement.Inhibit should only prevent suspend

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:152400c1b688: org.freedesktop.PowerManagement.Inhibit 
should only prevent suspend (authored by broulik).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11182?vs=29093=30307

REVISION DETAIL
  https://phabricator.kde.org/D11182

AFFECTED FILES
  daemon/powerdevilfdoconnector.cpp

To: broulik, #plasma, oliverhenshaw, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11352: [RFC] Auto ordered systray

[Marco Martin]

mart added a comment.


  In D11352#230681 , @Pitel wrote:
  
  > Great, but I found one more bug (and it affected order of items). This 
fixes it.
  >
  > - Add tie breaking (for the unlikely case of the same category & text)
  > - Add debug print
  
  
  i would prefer the final version to be quiet
  
  > - Fix sorting algorithm (the order was wrong if item was created with empty 
text and filled it in later)
  > 
  >   Note that I do not have write access, so I cannot land this myself.
  
  you can apply for it, you're more than welcome

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart
Cc: ngraham, wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11182: org.freedesktop.PowerManagement.Inhibit should only prevent suspend

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Given it's relying on other applications being sane, which is generally 
unreliable, maybe it's best to only put this in master.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D11182

To: broulik, #plasma, oliverhenshaw, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11607: Update systemsettings docbook to 5.12

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread
  bump date + releaseinfo
  System Splash renamed to Boot Splash
  Other Notifications not in plasma workspace
  add Sidebar View

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11607

AFFECTED FILES
  doc/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11590: Add mutex round static member used in a thread

[David Edmundson]

davidedmundson updated this revision to Diff 30298.
davidedmundson added a comment.


  shallow-copy QStringList outside mutex

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11590?vs=30264=30298

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11590

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11590: Add mutex round static member used in a thread

[David Edmundson]

davidedmundson added a comment.


  Very well spotted!
  
  In this specific case it's probably fine as it's never modified after 
construction, but I'll change anyway.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11590

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11516: use plasma_install_bundled_package

[Friedrich W . H . Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Cannot test at the moment, but looks straight forward, so no objection from 
me.
  
  Besides the unrelated changes, they want to have their own commits :)

INLINE COMMENTS

> main.qml:24
>  import org.kde.plasma.core 2.0 as PlasmaCore
> -import org.kde.plasma.private.fifteenpuzzle 0.1
> +import org.kde.plasma.private.fifteenpuzzle 0.1 as Private
>  

Unrelated?

> fifteenpuzzleplugin.cpp:32
>  Q_ASSERT(QLatin1String(uri) == 
> QLatin1String("org.kde.plasma.private.fifteenpuzzle"));
> -qmlRegisterTypeNotAvailable(uri, 0, 1, "fifteenpuzzle", 
> QStringLiteral("fifteenpuzzle"));
> +qmlRegisterTypeNotAvailable(uri, 0, 1, "FifteenPuzzle", 
> QStringLiteral("fifteenpuzzle"));
>  }

Unrelated?

REPOSITORY
  R114 Plasma Addons

BRANCH
  phab/bundle

REVISION DETAIL
  https://phabricator.kde.org/D11516

To: mart, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11516: use plasma_install_bundled_package

[Marco Martin]

mart updated this revision to Diff 30297.
mart added a comment.


  - bump frameworks dep for new install bundled package

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11516?vs=30012=30297

BRANCH
  phab/bundle

REVISION DETAIL
  https://phabricator.kde.org/D11516

AFFECTED FILES
  CMakeLists.txt
  applets/CMakeLists.txt
  applets/binary-clock/CMakeLists.txt
  applets/calculator/CMakeLists.txt
  applets/colorpicker/CMakeLists.txt
  applets/comic/CMakeLists.txt
  applets/dict/CMakeLists.txt
  applets/diskquota/CMakeLists.txt
  applets/fifteenPuzzle/CMakeLists.txt
  applets/fifteenPuzzle/package/contents/ui/main.qml
  applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp
  applets/fuzzy-clock/CMakeLists.txt
  applets/grouping/CMakeLists.txt
  applets/grouping/container/CMakeLists.txt
  applets/mediaframe/CMakeLists.txt
  applets/minimizeall/CMakeLists.txt
  applets/notes/CMakeLists.txt
  applets/quicklaunch/CMakeLists.txt
  applets/quickshare/CMakeLists.txt
  applets/showdesktop/CMakeLists.txt
  applets/systemloadviewer/CMakeLists.txt
  applets/timer/CMakeLists.txt
  applets/userswitcher/CMakeLists.txt
  applets/weather/CMakeLists.txt
  applets/webbrowser/CMakeLists.txt

To: mart, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11600: Pass proper click coordinates to SNI ContextMenu calls

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a4a0d5bfd0da: Pass proper click coordinates to SNI 
ContextMenu calls (authored by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11600?vs=30282=30296

REVISION DETAIL
  https://phabricator.kde.org/D11600

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11586: libdbusmenu-qt: Remove nonexistant actions directly from the menu

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8827bb38806e: libdbusmenu-qt: Remove nonexistant actions 
directly from the menu (authored by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11586?vs=30249=30294

REVISION DETAIL
  https://phabricator.kde.org/D11586

AFFECTED FILES
  libdbusmenuqt/dbusmenuimporter.cpp

To: fvogt, #plasma, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11584: Set a transient parent for SNI context menus

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cf2d64fa9718: Set a transient parent for SNI context 
menus (authored by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11584?vs=30279=30293

REVISION DETAIL
  https://phabricator.kde.org/D11584

AFFECTED FILES
  applets/systemtray/systemtray.cpp

To: fvogt, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11606: [WebBrowser Plasmoid] Support opening external links

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This implements a context menu for opening links externally. There is 
unfortunately currently no way to add custom context menu entries to 
`WebEngineView`'s context menu, so the link menu is completely replaced.
  It also lets websites open new windows and fixes `target="_blank"` links
  
  CCBUG: 371023

TEST PLAN
  F5763534: Screenshot_20180323_112038.png 

  Verified that clicking a `` 
link does not result in that file being executed.
  Unwanted popups are successfully blocked and show a hint
  F5763531: Screenshot_20180323_111931.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11606

AFFECTED FILES
  applets/webbrowser/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11600: Pass proper click coordinates to SNI ContextMenu calls

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Currently it always passes the top left corner of the SNI icon as coordinates,
  but now it passes the actual click coordinates.
  They can be outside of the icon's bounds (for instance if you click on the
  label in the expanded tray), but they are converted to global coordinates
  anyway.

TEST PLAN
  Now the context menu drawn by the application properly follows the
  cursor.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  contextcoords

REVISION DETAIL
  https://phabricator.kde.org/D11600

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11584: Set a transient parent for SNI context menus

[Fabian Vogt]

fvogt updated this revision to Diff 30279.
fvogt added a comment.


  Split mouse.xy stuff into separate patch.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11584?vs=30251=30279

BRANCH
  snitest

REVISION DETAIL
  https://phabricator.kde.org/D11584

AFFECTED FILES
  applets/systemtray/systemtray.cpp

To: fvogt, #plasma
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11584: Set a transient parent for SNI context menus

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> broulik wrote in StatusNotifierItem.qml:63
> I think this change is fine. Except that the `MouseArea` covers the entire 
> list item, so for hidden SNIs the app might get coordinates outside of its 
> icon.
> 
> For context menu we ignore the coordinates anyway and place the menu relative 
> to the icon (so it never covers it). For `Activate` the app might want to 
> know where it was clicked. In any case this needs a bit of cleaning up, we 
> pass parameters around in places where they're ignored and so on.

I think I'll do it differently.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11584

To: fvogt, #plasma
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11584: Set a transient parent for SNI context menus

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> StatusNotifierItem.qml:63
>  onClicked: {
> -var pos = plasmoid.nativeInterface.popupPosition(taskIcon, 0, 0);
> +var pos = plasmoid.nativeInterface.popupPosition(taskIcon, mouse.x, 
> mouse.y);
>  

I think this change is fine. Except that the `MouseArea` covers the entire list 
item, so for hidden SNIs the app might get coordinates outside of its icon.

For context menu we ignore the coordinates anyway and place the menu relative 
to the icon (so it never covers it). For `Activate` the app might want to know 
where it was clicked. In any case this needs a bit of cleaning up, we pass 
parameters around in places where they're ignored and so on.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11584

To: fvogt, #plasma
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11584: Set a transient parent for SNI context menus

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> davidedmundson wrote in StatusNotifierItem.qml:63
> This change is unrelated, and not a change I would support.

Why not?

It is a fix for an oversight, which is currently a no-op due to another bug.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11584

To: fvogt, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 30273.
Kanedias marked an inline comment as done.
Kanedias added a comment.


  - Merge branch 'master' into gbm-vnc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1231?vs=30272=30273

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1231

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_remote_access.cpp
  src/client/CMakeLists.txt
  src/client/protocols/remote-access.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/remote_access.cpp
  src/client/remote_access.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/remote_access_interface.cpp
  src/server/remote_access_interface.h
  src/server/remote_access_interface_p.h
  src/tools/mapping.txt

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 30272.
Kanedias added a comment.


  Remove already merged changes

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1231?vs=30271=30272

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1231

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_remote_access.cpp
  src/client/CMakeLists.txt
  src/client/output.cpp
  src/client/protocols/remote-access.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/remote_access.cpp
  src/client/remote_access.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/output_interface.cpp
  src/server/remote_access_interface.cpp
  src/server/remote_access_interface.h
  src/server/remote_access_interface_p.h
  src/tools/mapping.txt

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 30271.
Kanedias added a comment.


  - Implement releasing of client-freed output
  - Review fixes

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1231?vs=25976=30271

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1231

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_remote_access.cpp
  src/client/CMakeLists.txt
  src/client/output.cpp
  src/client/protocols/remote-access.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/remote_access.cpp
  src/client/remote_access.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/output_interface.cpp
  src/server/remote_access_interface.cpp
  src/server/remote_access_interface.h
  src/server/remote_access_interface_p.h
  src/tools/mapping.txt

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein