Re: svn commit: r497090 - in /jakarta/poi/trunk/src/scratchpad: src/org/apache/poi/hslf/record/RecordTypes.java testcases/org/apache/poi/hslf/record/TestExHyperlink.java

2007-01-17 Thread Mark Thomas
Nick,

Your recent additions don't appear to have the standard svn properties
(svn:eol-style and svn:keywords) set. There is a standard config file
available (http://www.apache.org/dev/version-control.html#https-svn)
for svn clients that configures this and a few other useful things.

HTH,

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

2007-01-16 Thread Mark Thomas
Avik Sengupta wrote:
>> 2. Add a some trademark usage words (like that on
>> http://tomcat.apache.org/legal.html
> 
> I was never a fan or stating the obvious, but that'll probably make me a bad 
> lawyer. What's the apache legal team view on stuff like this? Have they 
> approved the tomcat page? I'm loath to do this without some sort of official 
> word
> 
> regards
> -
> Avik

The legal team have approved the wording (they actually made a few
changes) and were very much for the idea of having the text. It came
out of some commercial projects unintentionally infringing the Tomcat
trademark. If we had had the text in place before the discussions with
them started it would have made the whole process a lot smoother.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

2007-01-15 Thread Mark Thomas
Avik Sengupta wrote:
> Thanks for the effort Mark.
> 
> Can I  just ask that if you're doing any changes to the build, you run it 
> past 
> this list, since it'll interest everybody?

Happy to. I am not planning any changes to the build at the moment. If
this changes I'll let the list know. Most of what I still have to
commit is setting svn properties and inserting / changing licence text
which should, unless I mess something up, have zero impact on poi
functionality or on the build.

Two things I think it would be good to do but some feedback before I
do then would be nice are:
1. Delete /src/documentation/content/xdocs/dtd since they aren't used
for validation and the xml doesn't conform to them (older dtds from
forrest are used instead)
2. Add a some trademark usage words (like that on
http://tomcat.apache.org/legal.html

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

2007-01-15 Thread Mark Thomas
Yegor Kozlov wrote:
> We still have files without the proper ASF header.

I have patches ready to go for all of these and a few others. I've
just seen Martin has enabled my commit access so I should have these
fixed soon - I want to do a few more tests before committing.

The committers repository contains a couple of useful licensing tools.
I have been using insert_license.pl that does a good audit of all file
types (properties, java, html, xml etc)

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

2007-01-15 Thread Mark Thomas
Martin van den Bemt wrote:
> I have add you to the jakarta-poi group.. Let me know if there are any 
> problems..

All is working perfectly. Many thanks.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

2007-01-14 Thread Mark Thomas
Andrew C. Oliver wrote:
> Oh nm.  Didn't see the @apache.org address.  Can you please state that
> you are not bound and have never been bound by an NDA or other such
> exclusionary agreement with Microsoft?  If so I remove my objection.
> 
> -andy

I am not, and have never been, bound by an NDA or other such
exclusionary agreement with Microsoft.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

2007-01-14 Thread Mark Thomas
Andrew C. Oliver wrote:
> -1 for granting karma for a promise to commit.  Past experience teaches
> us that patches come first.

Fair enough. I'll create a bugzilla entry once I have some patches
ready to go.

Mark

> Martin van den Bemt wrote:
>> If the current POI committers don't have an objection, I can add the
>> necessary karma.
>>
>> Mvgr,
>> Martin


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

2007-01-11 Thread Mark Thomas
Avik Sengupta wrote:
> Most important  issue was the file headers. Been fixed. Key signing needs to 
> be arranged.

A number if source files have no header at all. I haven't done an
exhaustive check but the ones I found on my random wander through the
source were:
font_metrics.properties
various package.html files
various xml files

My reading of http://www.apache.org/legal/src-headers.html is that
most, if not all, of these files require headers and that this really
does need to be fixed before the next release.

I should have some time to fix these over the next week or so. It
would be easier to grant me the necessary karma to fix these myself
but I can provide patches on a bugzilla entry if you prefer. Let me know.

I also spotted a handful of "nice to have"s whilst I was looking at
the build process. Again karma or patches? Let me know.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Forrest and POI docs

2007-01-02 Thread Mark Thomas
Avik Sengupta wrote:
> Having looked, I doubt it will be a trivial 
> task, given that the learning curve in forrest is a difficult one... among 
> other things I dont understand, apparently forrest now bundles its own 
> version of ant (why on earth?)

Having spent the best part of a day trying and failing to do this
(admittedly I am no forrest expert) staying with 0.5.1 until forrest
is stable looks to be a sound plan to me.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Updated dist and jar tasks

2007-01-01 Thread Mark Thomas
Mark Thomas wrote:
> dist - I can't build with forrest 0.7 due to antproxy support being
> removed. I am working on what changes are required to get this working

Having tried, and failed, to get the build working with both 0.7 and
the latest source from svn I reverted to 0.5.1

I am still getting a build error in the documentation - a broken link
with hslf/hslf_shapes.gif

I am not familiar with forrest or the POI documentation structure but
I believe the following change is required to fix it:
move hslf_shapes.gif from src/documentation/content/xdocs/hslf to
src/documentation/resources/images

With this change the dist target works for me.

For consistency with the other docs, the img tag in
src/documentation/content/xdocs/hslf/how-to-shapes.xml should change
from  to


On a related note the DTDs in src/documentation/content/xdocs/dtd
appear to be ignored. The documentation certainly doesn't conform to
them - it appears modified versions supplied by forrest are used
instead. It is probably worth removing these to prevent confusion.

HTH,

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Updated dist and jar tasks

2006-12-30 Thread Mark Thomas
Nick Burch wrote:
> Hi All
> 
> I've gone through Henri's list of suggested improvements to the build
> artificats, and hopefully implemented all of them.
> 
> The main updates are:
> * The jars (binary and maven) now include NOTICE and LEGAL, at their
>top level

I think NOTICE and LICENSE should be under META-INF rather than in the
root of the JAR. I have tried to find a reference for this but can't.

The maven sources don't include:
font_metrics.properties
empty.ppt
should they? (I don't use maven so don't know what is required here)

> * The zips and tgzs now unpack into a directory called poi-/,
>rather than into the current directory. In there, you will also now
>find NOTICE and LEGAL (and not in some subdirectory)
> * The KEYS file is now updated
> 
> It'd be great if a few people could try the "jar", "maven-dist" and "dist"
> ant tasks, and check that they're outputting the artifacts that would be
> expected. 

jar - builds fine, no problems
dist - I can't build with forrest 0.7 due to antproxy support being
removed. I am working on what changes are required to get this working
maven-dist - builds fine no problems

> Any further suggested improvements gratefully accepted :)
Some source files do not contain the licence header. These include:
font_metrics.properties
various package.html files
various xml files

It is probably required for some of these files. The definitive
guidance is in "What files in an Apache release do not require a
license header?" at http://www.apache.org/legal/src-headers.html

If we decide a large number of files need this text added, I'm happy
to lend a had to do it but I don't want to start doing something we
later decide is unnecessary.

On Tomcat we have had problems with people mis-using the Tomcat name
and/or logo. We should consider adding something similar to the
Trademarks text at http://tomcat.apache.org/legal.html to the POI
legal page.

HTH,

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: Help needed?

2006-12-20 Thread Mark Thomas
Nick Burch wrote:
> On Mon, 18 Dec 2006, Mark Thomas wrote:
>> Following up on the recent thread on [EMAIL PROTECTED] is there anything I
>> can do to lend a hand around releases and the like?
> 
> Henri's given us a long list of things we should try to sort out in the
> builds. I'm planning to try to fix all of them over Christmas (few long
> train journeys should help), but it'd be useful to have another set of
> eyes looking over the new build process when it's sorted.
> 
> It looks like we're going to aim for a FINAL release in the early new
> year, so whoever opts to be release manager for it will probably ping you
> to check they've remembered everything, if that's ok?

Happy to. I'll check out trunk and get the build running on my machine
in the mean time. If you want a hand with any of the specific tasks -
just shout.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Help needed?

2006-12-18 Thread Mark Thomas
Hi,

Following up on the recent thread on [EMAIL PROTECTED] is there anything
I can do to lend a hand around releases and the like?

Regards,

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/