[issue25698] test regressions introduced with the fix for #22995

[Martin Panter]

Martin Panter added the comment:

Duplicate or related to Issue 25601?

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24731] Incorrect assert in str_subtype_new

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your report Kevin and sorry for the delay. I confirm the bug and 
agree with your solution. The same bug exists for ints and floats.

Here are patches that fix crashes.

--
keywords: +patch
nosy: +mark.dickinson
stage: needs patch -> patch review
Added file: http://bugs.python.org/file41126/issue24731.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25691] Crash on deleting Element attribute

[Martin Panter]

Martin Panter added the comment:

The patch looks good to me.

This may be a side effect of poor documentation. I guess the documentation at 
 
and/or the referenced functions should mention that the they also delete 
attributes when the name argument is null.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25695] test___all__ and test_support alter execution environment

[Martin Panter]

Martin Panter added the comment:

This was introduced with revision f8fa7bc837a3. I guess I overlooked the new 
messages because I run the tests with -Wall, which is affected by Issue 18383.

It seems a bad idea to create a temporary directory when you import the 
test_support module. I propose this patch to defer creation until the one test 
that uses it is run.

As for your patch Silent Ghost, I’m not sure. It kind of side-steps the real 
issue by tweaking a heuristic. Maybe we should keep the heuristic as it is, 
because it is simpler.

--
nosy: +martin.panter
type:  -> behavior
Added file: http://bugs.python.org/file41128/defer-TESTDIRN.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

tp_setattro and tp_setattr fields of PyTypeObject are used for deleting 
attributes. In this case the third argument is NULL. This should be documented. 
Not awareness of this can cause a segmentation fail (for example see 
issue25698).

--
assignee: docs@python
components: Documentation
messages: 255130
nosy: docs@python, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Document that tp_setattro and tp_setattr are used for deleting attributes
type: crash
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25688] File leak in ElementTree.iterparse()

[Martin Panter]

Martin Panter added the comment:

What’s the point of the catch_warnings() and filterwarnings() calls in the 
tests? They don’t seem to be doing much; I think the CleanContext manager is 
already enabling warnings. Perhaps you could call simplefilter("error", 
ResourceWarning) instead.

Also I’m not enthusiastic about the iterparse() API when passing a file name. 
If it has to stay, maybe there should be an explicit way to clean it up without 
exhausting the iterator, like a generator.close() method.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25688] File leak in ElementTree.iterparse()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Warning is emitted in destructor, and exceptions in destructors are ignored. 
Hence turning it into error makes the test passed.

Tests were not correct, here is fixed patch.

Yes, CleanContext does the work. But depending on it looks fragile. 
CleanContext can be removed after getting rid of all deprecated methods.

I agree that we have to add the close() method to iterparse object. But this is 
new feature and separate issue.

--
Added file: http://bugs.python.org/file41129/etree_iterparse_leak_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25624] shutil.make_archive makes invalid directory entries

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you Benjamin.

--
resolution:  -> fixed
stage: test needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25691] Crash on deleting Element attribute

[Roundup Robot]

Roundup Robot added the comment:

New changeset 852c9ed9115c by Serhiy Storchaka in branch '3.4':
Issue #25691: Fixed crash on deleting ElementTree.Element attributes.
https://hg.python.org/cpython/rev/852c9ed9115c

New changeset 3a44f06907f1 by Serhiy Storchaka in branch '3.5':
Issue #25691: Fixed crash on deleting ElementTree.Element attributes.
https://hg.python.org/cpython/rev/3a44f06907f1

New changeset 936fcd0ba6b1 by Serhiy Storchaka in branch 'default':
Issue #25691: Fixed crash on deleting ElementTree.Element attributes.
https://hg.python.org/cpython/rev/936fcd0ba6b1

New changeset e3dea2e4f93d by Serhiy Storchaka in branch '2.7':
Issue #25691: Added tests on deleting cElementTree.Element attributes.
https://hg.python.org/cpython/rev/e3dea2e4f93d

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
Removed message: http://bugs.python.org/msg255130

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

tp_setattro and tp_setattr fields of PyTypeObject are used for deleting 
attributes. In this case the third argument is NULL. This should be documented. 
Not awareness of this can cause a segmentation fail (for example see 
issue25691).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
priority: normal -> high

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25691] Crash on deleting Element attribute

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your review Martin. Opened issue25701 for documenting.

Interestingly, 2.7 is free from this bug. It has a check for NULL.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8304] time.strftime() and Unicode characters on Windows

[Eryk Sun]

Eryk Sun added the comment:

The problem from issue 10653 is that internally the CRT encodes the time zone 
name using the ANSI codepage (i.e. the default system codepage). wcsftime 
decodes this string using mbstowcs (i.e. multibyte string to wide-character 
string), which uses Latin-1 in the C locale. In other words, in the C locale on 
Windows, mbstowcs just casts the byte values to wchar_t. 

With the new Universal CRT, strftime is implemented by calling wcsftime, so the 
accepted solution for issue 10653 is broken in 3.5+. A simple way around the 
problem is to switch back to using wcsftime and temporarily (or permanently) 
set the thread's LC_CTYPE locale to the system default. This makes the internal 
mbstowcs call use the ANSI codepage. Note that on POSIX platforms 3.x already 
sets the default via setlocale(LC_CTYPE, "") in Python/pylifecycle.c. Why not 
set this for all platforms that have setlocale?

> I only tested with my default US locale.

If your system locale uses codepage 1252 (a superset of Latin-1), then you can 
still test this on a per thread basis if your system has additional language 
packs. For example:

import ctypes

kernel32 = ctypes.WinDLL('kernel32', use_last_error=True)

if kernel32.GetModuleHandleW('ucrtbased'):  # debug build
crt = ctypes.CDLL('ucrtbased', use_errno=True)
else:
crt = ctypes.CDLL('ucrtbase', use_errno=True)

MUI_LANGUAGE_NAME = 8
LC_CTYPE = 2

class tm(ctypes.Structure):
pass

crt._gmtime64.restype = ctypes.POINTER(tm)

# set a Russian locale for the current thread
kernel32.SetThreadPreferredUILanguages(MUI_LANGUAGE_NAME,
   'ru-RU\0', None)
crt._wsetlocale(LC_CTYPE, 'ru-RU')
# update the time zone name based on the thread locale
crt._tzset() 

# get a struct tm *
ltime = ctypes.c_int64()
crt._time64(ctypes.byref(ltime))
tmptr = crt._gmtime64(ctypes.byref(ltime))

# call wcsftime using C and Russian locales 
buf = (ctypes.c_wchar * 100)()
crt._wsetlocale(LC_CTYPE, 'C')
size = crt.wcsftime(buf, 100, '%Z\r\n', tmptr)
tz1 = buf[:size]
crt._wsetlocale(LC_CTYPE, 'ru-RU')
size = crt.wcsftime(buf, 100, '%Z\r\n', tmptr)
tz2 = buf[:size]

hcon = kernel32.GetStdHandle(-11)
pn = ctypes.pointer(ctypes.c_uint())

>>> _ = kernel32.WriteConsoleW(hcon, tz1, len(tz1), pn, None)
Âðåìÿ â ôîðìàòå UTC
>>> _ = kernel32.WriteConsoleW(hcon, tz2, len(tz2), pn, None)
Время в формате UTC

The first result demonstrates the ANSI => Latin-1 mojibake problem in the C 
locale. You can encode this result as Latin-1 and then decode it back as 
codepage 1251:

>>> tz1.encode('latin-1').decode('1251') == tz2
True

But transcoding isn't a general workaround since the format string shouldn't be 
restricted to ANSI, unless you can smuggle the Unicode through like Takayuki 
showed.

--
nosy: +eryksun
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25624] shutil.make_archive makes invalid directory entries

[Larry Hastings]

Larry Hastings added the comment:

This change didn't make it into 3.5.1.  It will be released with 3.5.2.  I've 
already updated the Misc/NEWS entry.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25691] Crash on deleting Element attribute

[Larry Hastings]

Larry Hastings added the comment:

This change didn't make it into 3.5.1.  It will be released with 3.5.2.  I've 
already updated the Misc/NEWS entry.

--
nosy: +larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25697] Fix rough alphabetical order in Misc/ACKS

[Martin Panter]

Martin Panter added the comment:

I left one review comment about Maćkowiak. The other changes look okay.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25680] Selector.select() hangs when there is nothing to select

[Guido van Rossum]

Guido van Rossum added the comment:

I don't think we should "fix" the select module; it's advertised as a wrapper 
around the various syscalls, and if the platforms disagree on what that syscall 
(e.g. select()) does we shouldn't try to fix it. (Documenting the differences 
is fine.)

However the *selectors* module is a different thing. It defines a better 
abstraction that's supposedly independent from the underlying syscall. I agree 
with Aleksey that it should just hang when no FDs are registered and no timeout 
is given -- this is the only logical extension of its behavior when a FD is 
registered or a timeout is given. This could be used to wait until e.g. a 
signal arrives.

It's illogical that it would behave differently if a FD was registered that 
will never fire, or if a timeout of a billion seconds was given (although that 
may be an easy hack to wait forever if the underlying syscall doesn't like 
this).

The asyncio package would probably be broken because of this except that it 
always has a FD registered (the self-pipe).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25698] test regressions introduced with the fix for #22995

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

In your report test_cpickle has number 93. What other 92 tests were ran before? 
Could you run tests few times and find minimal list of tests that precede 
failing test_cpickle?

This failure is not related to issue22995 because the same failure was reported 
in issue25601 5 commits before first commit in issue22995.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24731] Incorrect assert in str_subtype_new

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: http://bugs.python.org/file41127/issue24731-2.7.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25698] test regressions introduced with the fix for #22995

[Matthias Klose]

Matthias Klose added the comment:

looks like re-running the tests in verbose mode using -w is affected by this 
issue.

the first cpickle subtest failing is:

==
ERROR: test_recursive_dict_subclass_and_inst 
(test.test_cpickle.cStringIOCPicklerFastTests)
--
Traceback (most recent call last):
  File 
"/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/test/test_cpickle.py", line 
175, in wrapper
func(self)
  File 
"/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/test/pickletester.py", line 
819, in test_recursive_dict_subclass_a
nd_inst
self.check_recursive_collection_and_inst(MyDict.fromkeys)
  File 
"/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/test/pickletester.py", line 
790, in check_recursive_collection_and
_inst
s = self.dumps(y, proto)
  File 
"/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/test/test_cpickle.py", line 
141, in dumps
p.dump(arg)
AttributeError: 'module' object has no attribute '_reduce_ex'

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25698] test regressions introduced with the fix for #22995

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Yes, it is a duplicate of issue25601. And I can't reproduce it locally.

Matthias, can you reproduce test failure every time when run tests? If yes, 
could you please run tests in verbose mode and found what tests in test_cpickle 
were failed first?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25700] namedtuple documentation

[Laur Joost]

New submission from Laur Joost:

collections.namedtuple documentation has an example about changing the 
resulting class docstrings:

  Docstrings can be customized by making direct assignments to the
  ``__doc__`` fields:
  
 >>> Book = namedtuple('Book', ['id', 'title', 'authors'])
 >>> Book.__doc__ += ': Hardcover book in active collection'

This seems to work for the resulting class, but not the field names:

MsgPacket = namedtuple('MsgPacket', ['sender', 'target', 'sig', 'ser_msg'])
MsgPacket.__doc__ = '. Message packet format. This is the data added to 
client queues.'
MsgPacket.sender.__doc__ = 'Sender public key.'

gives

Traceback (most recent call last):
  File "C:/UTCloud/UT/DS/S11/server.py", line 42, in 
MsgPacket.sender.__doc__ = 'Sender public key.'
AttributeError: readonly attribute

--
assignee: docs@python
components: Documentation
messages: 255121
nosy: Laur Joost, docs@python
priority: normal
severity: normal
status: open
title: namedtuple documentation
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25700] namedtuple documentation

[Zachary Ware]

Zachary Ware added the comment:

I wonder if it's worth a ..versionchanged note in the namedtuple docs pointing 
out that __doc__ assignment on fields only works in 3.5+ due to property 
docstrings becoming writable.

--
nosy: +zach.ware
stage:  -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25624] shutil.make_archive makes invalid directory entries

[Roundup Robot]

Roundup Robot added the comment:

New changeset 43208b0f2535 by Benjamin Peterson in branch '2.7':
Issue #25624: ZipFile now always writes a ZIP_STORED header for directory 
entries. Patch by Dingyuan Wang.
https://hg.python.org/cpython/rev/43208b0f2535

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25700] namedtuple documentation

[Laur Joost]

Laur Joost added the comment:

Did my testing on 3.4.3 (other computer). My apologies.

--
resolution:  -> not a bug
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25694] test.libregrtest not installed

[Arfrever Frehtes Taifersar Arahesis]

New submission from Arfrever Frehtes Taifersar Arahesis:

test.libregrtest is not installed, which breaks running of test suite from 
installed Python.
Probably LIBSUBDIRS in Makefile.pre.in should be updated.

$ python3.5 -m test test_int
[1/1] test_int
1 test OK.
$ python3.6 -m test test_int
Traceback (most recent call last):
  File "/usr/lib64/python3.6/runpy.py", line 170, in _run_module_as_main
"__main__", mod_spec)
  File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
  File "/usr/lib64/python3.6/test/__main__.py", line 1, in 
from test import regrtest
  File "/usr/lib64/python3.6/test/regrtest.py", line 14, in 
from test.libregrtest import main, main_in_temp_cwd
ImportError: No module named 'test.libregrtest'

--
assignee: haypo
components: Tests
messages: 255087
nosy: Arfrever, haypo
priority: normal
severity: normal
status: open
title: test.libregrtest not installed
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25693] test_asyncio prints some messages

[Arfrever Frehtes Taifersar Arahesis]

New submission from Arfrever Frehtes Taifersar Arahesis:

When running full test suite, test_asyncio prints some messages.
ResourceWarnings should be fixed.
Other messages should not be shown, at least without --verbose.

[171/398] test_epoll
[172/398] test_optparse
[173/398] test_socket
[174/398] test_sax
[175/398] test_weakref
[176/398] test_codecmaps_tw
[177/398] test_property
[178/398] test_asyncio
Executing .start() done, defined at 
/tmp/cpython/Lib/test/test_asyncio/test_pep492.py:146> result=None created at 
/tmp/cpython/Lib/asyncio/base_events.py:317> took 0.252 seconds
/tmp/cpython/Lib/threading.py:864: ResourceWarning: unclosed 
  self._target(*self._args, **self._kwargs)
returning true from eof_received() has no effect when using ssl
returning true from eof_received() has no effect when using ssl
/tmp/cpython/Lib/asyncio/base_events.py:379: ResourceWarning: unclosed event 
loop <_UnixSelectorEventLoop running=False closed=False debug=False>
  warnings.warn("unclosed event loop %r" % self, ResourceWarning)
[179/398] test_os
[180/398] test_enumerate
[181/398] test_math
[182/398] test_zipfile
[183/398] test_tarfile
[184/398] test_pep380
[185/398] test_with
[186/398] test_mmap
[187/398] test_trace
[188/398] test_eintr

--
components: Tests, asyncio
messages: 255086
nosy: Arfrever, giampaolo.rodola, gvanrossum, haypo, pitrou, yselivanov
priority: normal
severity: normal
status: open
title: test_asyncio prints some messages
versions: Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25695] test___all__ and test_support alter execution environment

[Arfrever Frehtes Taifersar Arahesis]

New submission from Arfrever Frehtes Taifersar Arahesis:

test___all__ and test_support alter execution environment.
Problem seems to be present only in Python 3.6.

$ python3.5 -m test test___all__ test_support
[1/2] test___all__
[2/2] test_support
All 2 tests OK.
$ python3.6 -m test test___all__ test_support
[1/2] test___all__
Warning -- files was modified by test___all__
[2/2] test_support
Warning -- files was modified by test_support
2 tests altered the execution environment:
test___all__ test_support


When running these test files separately, problem is only present for 
test___all__:

$ python3.5 -m test test___all__
[1/1] test___all__
1 test OK.
$ python3.6 -m test test___all__
[1/1] test___all__
Warning -- files was modified by test___all__
1 test altered the execution environment:
test___all__
$ python3.5 -m test test_support
[1/1] test_support
1 test OK.
$ python3.6 -m test test_support
[1/1] test_support
1 test OK.

--
components: Tests
messages: 255088
nosy: Arfrever, ezio.melotti, haypo
priority: normal
severity: normal
status: open
title: test___all__ and test_support alter execution environment
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25696] "make install" fails because bininstall target requires the libainstall target

[STINNER Victor]

STINNER Victor added the comment:

Output:
---
$ make install --debug=v
(...)
  Must remake target 'bininstall'.
(...)
(cd /opt/py36/lib/pkgconfig; ln -s python-3.6.pc python-3.6dm.pc); (...)
(...)
/bin/sh: ligne 4 : cd: /opt/py36/lib/pkgconfig: Aucun fichier ou dossier de ce 
type
---

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25697] Fix rough alphabetical order in Misc/ACKS

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

the list in Misc/ACKS is intended to be in rough alphabetical order by last 
names. But some lines breaks this order. Proposed patch restores ordering. It 
also removes duplicates for Richard Oudkerk.

Correct sorting is not easy due to different letter order in different 
alphabets and different collation rules in different languages. I tried to take 
it into account, but can make a mistake.

--
assignee: docs@python
components: Documentation
files: acks_order-3.6.patch
keywords: patch
messages: 255106
nosy: docs@python, georg.brandl, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Fix rough alphabetical order in Misc/ACKS
Added file: http://bugs.python.org/file41125/acks_order-3.6.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25680] Selector.select() hangs when there is nothing to select

[Aleksey Kladov]

Aleksey Kladov added the comment:

>I disagree, we can do better than documenting "bugs" :-)

The result of `select.select([], [], [], None)` should defintelly be 
documented. 

Three platoforms made three different decisions in similar situation, so any 
behavior is reasonable and it should be made clear which one is used by Python.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25696] "make install" fails because bininstall target requires the libainstall target

[STINNER Victor]

New submission from STINNER Victor:

I'm unable to install Python 3.6, "make install" doesn't copy .py files because 
the bininstall target failed. It failed because /opt/py36/lib/pkgconfig doesn't 
exist.

Try:
---
export MAKEFLAGS=-j9
rm -rf /opt/py36
./configure --prefix=/opt/py36
make
make install   # you may need 'sudo make install'
---

Attached patch fixes the Makefile, but I don't know if my change is correct.

--
components: Build
files: bininstall.patch
keywords: patch
messages: 255102
nosy: Arfrever, doko, haypo
priority: normal
severity: normal
status: open
title: "make install" fails because bininstall target requires the libainstall 
target
versions: Python 3.6
Added file: http://bugs.python.org/file41124/bininstall.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25694] test.libregrtest not installed

[STINNER Victor]

STINNER Victor added the comment:

Hum, not only libregrtest was not installable, but test_regrtest didn't work on 
installed Python.

Can you please retry?

It would be nice to modify test_regrtest to *not* write into the test package, 
but I failed to find a way to load tests from a different directory :-/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25680] Selector.select() hangs when there is nothing to select

[STINNER Victor]

STINNER Victor added the comment:

Aleksey Kladov: "To show surprising platform-dependent API behavior."

Hum ok, it makes sense :-) I agree that it would be better to have a portable 
behaviour in the selectors module which is supposed to be an abstraction 
providing a portable behaviour. We already wrote code to have the same 
behaviour when a file descriptor is closed (handle EBADF).

Aleksey Kladov: "I think this special case should also be mentioned in the 
docs."

I disagree, we can do better than documenting "bugs" :-)

select.select([], [], [], None) raise an OSError "An invalid argument was 
supplied" on Windows. I propose to use this behaviour on all platforms for all 
selectors.

I should be easy to write a patch in selectors, is anyone interested to write a 
patch?

--
components: +asyncio
nosy: +gvanrossum, neologix, yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25694] test.libregrtest not installed

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1f563b259f09 by Victor Stinner in branch 'default':
Issue #25694: Install test.libregrtest to be able to run tests on the installed
https://hg.python.org/cpython/rev/1f563b259f09

New changeset fea86d0049d2 by Victor Stinner in branch 'default':
Issue #25694: Fix test_regrtest for installed Python
https://hg.python.org/cpython/rev/fea86d0049d2

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Christian's patch fixes two things: integer overflow and memory leak. First 
I'll commit a fix for memory leak (with cleanup and tests). Integer overflow 
looks already fixed in recent releases, there is nothing to commit. This part 
should be applied only to old releases.

--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Roundup Robot]

Roundup Robot added the comment:

New changeset d51d420f3e9d by Serhiy Storchaka in branch '3.4':
Issue #19687: Fixed memory leak on failed Element slice assignment.
https://hg.python.org/cpython/rev/d51d420f3e9d

New changeset 4d5417444961 by Serhiy Storchaka in branch '3.5':
Issue #19687: Fixed memory leak on failed Element slice assignment.
https://hg.python.org/cpython/rev/4d5417444961

New changeset de5a11836ad4 by Serhiy Storchaka in branch 'default':
Issue #19687: Fixed memory leak on failed Element slice assignment.
https://hg.python.org/cpython/rev/de5a11836ad4

New changeset c33e4881721f by Serhiy Storchaka in branch '2.7':
Issue #19687: Fixed memory leak on failed Element slice assignment.
https://hg.python.org/cpython/rev/c33e4881721f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22218] Fix more compiler warnings "comparison between signed and unsigned integers"

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

a patch for 3.6 for the unicodeobject.c file

--
versions: +Python 3.6 -Python 3.5
Added file: http://bugs.python.org/file41121/issue22218-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is updated patch for 3.4.

Added new overflow checks in element_resize(), some runtime checks are replaced 
with asserts (conditions are always true), check for buffer size is copied from 
3.5, followed Eli's suggestions about nchildren and index.

--
Added file: http://bugs.python.org/file41123/elementtree_overflow3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25455] Some repr implementations don't check for self-referential structures

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Raymond, could you please make a review of the first patch?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12869] PyOS_StdioReadline is printing the prompt on stderr

[Adam Bartoš]

Adam Bartoš added the comment:

> * The interactive interpreter always reads from the original standard input, 
> whether Readline is used or not.

This is not true – the interactive interpreter reads via PyOS_Readline, which 
may call whatever readline hook is installed.

I think the situation would be much more clear if something like my proposal 
was implemented 
(https://mail.python.org/pipermail/python-dev/2015-November/142246.html).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25684] ttk.OptionMenu radiobuttons aren't unique between two instances of OptionMenu

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Could you provide a patch Bryan?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25695] test___all__ and test_support alter execution environment

[SilentGhost]

SilentGhost added the comment:

test_support has this line:

TESTDIRN = os.path.basename(tempfile.mkdtemp(dir='.'))

Which is the culprit. The reason it gets so far as to import the module is due 
to the "fuzzy logic" check looking for __all__ 
What I'd suggest is replacing simple "in" string search with re.search for 
'\b__all__\b'. The downside of this is that the test execution time increased 
from .4 s to .7 s on my machine.

--
keywords: +needs review, patch
nosy: +SilentGhost
stage:  -> patch review
Added file: http://bugs.python.org/file41122/issue25695.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25694] test.libregrtest not installed

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25624] shutil.make_archive makes invalid directory entries

[Roundup Robot]

Roundup Robot added the comment:

New changeset e7d1df56f70b by Serhiy Storchaka in branch '3.4':
Issue #25624: ZipFile now always writes a ZIP_STORED header for directory
https://hg.python.org/cpython/rev/e7d1df56f70b

New changeset 0f8d426e0d0c by Serhiy Storchaka in branch '3.5':
Issue #25624: ZipFile now always writes a ZIP_STORED header for directory
https://hg.python.org/cpython/rev/0f8d426e0d0c

New changeset 09ed44192995 by Serhiy Storchaka in branch 'default':
Issue #25624: ZipFile now always writes a ZIP_STORED header for directory
https://hg.python.org/cpython/rev/09ed44192995

New changeset de5582c569ff by Serhiy Storchaka in branch '2.7':
Issue #25624: ZipFile now always writes a ZIP_STORED header for directory
https://hg.python.org/cpython/rev/de5582c569ff

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25693] test_asyncio prints some messages

[Martin Panter]

Changes by Martin Panter :


--
resolution:  -> duplicate
status: open -> closed
superseder:  -> asyncio tests are getting noisy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4744] asynchat documentation needs to be more precise

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

Ping, what's the status of this issue ? maybe we can close it and open an new 
one with a new description.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25624] shutil.make_archive makes invalid directory entries

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your contribution Dingyuan.

Benjamin, I think this fix should be in 2.7.11. It was a regression in 2.7.11 
that had made shutil.make_archive() unusable with the zip format.

--
nosy: +benjamin.peterson, larry
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25455] Some repr implementations don't check for self-referential structures

[Raymond Hettinger]

Raymond Hettinger added the comment:

>Raymond, could you please make a review of the first patch?
Will do.

Also, we should ask Antoine Pitrou to look at the TextIO patch and ask Stephan 
Krah to look at the ElementTree patch.

--
nosy: +skrah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25698] test regressions introduced with the fix for #22995

[Matthias Klose]

New submission from Matthias Klose:

seen with the 2.7.11 release candidate; I'm not yet 100% if this is the fix for 
#22995 causing these test regressions.

[ 93/395] test_cpickle
test test_cpickle failed -- multiple errors occurred; run in verbose mode for 
details
[101/395/2] test_decimal
test test_decimal failed -- Traceback (most recent call last):
  File 
"/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/test/test_decimal.py", line 
1774, in test_pickle
e = pickle.loads(pickle.dumps(c, proto))
  File "/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/pickle.py", line 
1380, in dumps
Pickler(file, protocol).dump(obj)
  File "/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/pickle.py", line 
224, in dump
self.save(obj)
  File "/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/pickle.py", line 
306, in save
rv = reduce(self.proto)
AttributeError: 'module' object has no attribute '_reduce_ex'

[108/395/4] test_dictviews
test test_dictviews failed -- Traceback (most recent call last):
  File 
"/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/test/test_dictviews.py", 
line 201, in test_pickle
pickle.dumps, d.viewkeys(), proto)
  File "/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/unittest/case.py", 
line 473, in assertRaises
callableObj(*args, **kwargs)
  File "/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/pickle.py", line 
1380, in dumps
Pickler(file, protocol).dump(obj)
  File "/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/pickle.py", line 
224, in dump
self.save(obj)
  File "/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/pickle.py", line 
306, in save
rv = reduce(self.proto)
AttributeError: 'module' object has no attribute '_reduce_ex'

[177/395/7] test_imp
test test_imp failed -- Traceback (most recent call last):
  File "/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/test/test_imp.py", 
line 60, in test_source
imp.reload(os)
  File "/home/packages/python/2.7/python2.7-2.7.11~rc1/Lib/os.py", line 727, in 

_copy_reg.pickle(stat_result, _pickle_stat_result, _make_stat_result)
AttributeError: 'module' object has no attribute 'pickle'

[184/395/10] test_int_literal
[185/395/10] test_ioctl
test test_ioctl crashed -- : 'module' object 
has no attribute 'pickle'
[186/395/11] test_isinstance
[187/395/11] test_iter
[188/395/11] test_iterlen
[189/395/11] test_itertools
[190/395/11] test_json
test test_json crashed -- : 'module' object 
has no attribute 'pickle'
[191/395/12] test_kqueue
test_kqueue skipped -- test works only on BSD
[192/395/12] test_largefile
test test_largefile crashed -- : 'module' 
object has no attribute 'pickle'
[193/395/13] test_lib2to3
test test_lib2to3 crashed -- : 'module' 
object has no attribute 'pickle'
[194/395/14] test_linecache
test test_linecache crashed -- : 'module' 
object has no attribute 'pickle'
[195/395/15] test_list
test test_list crashed -- : 'module' object 
has no attribute 'pickle'
[196/395/16] test_locale
[197/395/16] test_logging
test test_logging crashed -- : 'module' 
object has no attribute 'pickle'
[198/395/17] test_long
[199/395/17] test_long_future
[200/395/17] test_longexp
[201/395/17] test_macos
test test_macos crashed -- : 'module' object 
has no attribute 'pickle'
[202/395/18] test_macostools
test test_macostools crashed -- : 'module' 
object has no attribute 'pickle'
[203/395/19] test_macpath
[204/395/19] test_macurl2path
[205/395/19] test_mailbox
test test_mailbox crashed -- : 'module' 
object has no attribute 'pickle'
[206/395/20] test_marshal
test test_marshal crashed -- : 'module' 
object has no attribute 'pickle'
[207/395/21] test_math
test test_math crashed -- : 'module' object 
has no attribute 'pickle'
[208/395/22] test_md5
[209/395/22] test_memoryio
test test_memoryio failed -- multiple errors occurred; run in verbose mode for 
details
[210/395/23] test_memoryview
[211/395/23] test_mhlib
test test_mhlib crashed -- : 'module' object 
has no attribute 'pickle'

--
components: Extension Modules
messages: 255109
nosy: benjamin.peterson, doko, serhiy.storchaka
priority: release blocker
severity: normal
status: open
title: test regressions introduced with the fix for #22995
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25696] "make install" fails because bininstall target requires the libainstall target

[Arfrever Frehtes Taifersar Arahesis]

Arfrever Frehtes Taifersar Arahesis added the comment:

This problem in bininstall target seems to exist since Python 2.7 and 3.1.

bininstall target depends on altbininstall target, which contains:

@for i in $(BINDIR) $(LIBDIR); \
do \
if test ! -d $(DESTDIR)$$i; then \
echo "Creating directory $$i"; \
$(INSTALL) -d -m $(DIRMODE) $(DESTDIR)$$i; \
elsetrue; \
fi; \
done

For consistency with other things, I would suggest to add the following at the 
beginning of bininstall target (instead of making bininstall target depend on 
libainstall target):

@for i in $(LIBPC); \
do \
if test ! -d $(DESTDIR)$$i; then \
echo "Creating directory $$i"; \
$(INSTALL) -d -m $(DIRMODE) $(DESTDIR)$$i; \
elsetrue; \
fi; \
done

--
versions: +Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24858] python3 -m test -ugui -v test_tk gives 3 failures under Debian unstable (sid)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Matthias, can you confirm that this is Debian packaging issue?

--
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25699] Easier way to specify reduced globals for doctest

[John Mark Vandenberg]

New submission from John Mark Vandenberg:

Currently doctest.testmod `globals` defaults to including everything in the 
module scope, and tools like pyflakes assume that doctests run with globals as 
a copy of __dict__ .

It is relatively simple to exclude everything using doctest.testmod(globs={}).

However to use a limited scope, such as only including attributes in __all__, 
we need to use `doctest.testmod(globs=[(name, globals()[name]) for name in 
__all__])`

However those solutions require that each module includes a `if __name__ == 
"__main__":` block that invokes doctest.testmod, and then other doctest related 
tools (pyflakes, nose, etc) need to *parse* the invocation to determine the 
desired globals contents.

It would be easier to control the globals using a module attribute that works 
like __all__, so that all doctest tools could easily determine the desired 
contents of globals.

e.g. the following could provide a sane reduced globals for doctests

__test_all__ = __all__ = ['foo']

As people sometimes add docstrings/doctest for functions not exported in 
__all__ for external use, in addition to the list of symbols in __test_all__, 
the doctest globals should include the function/class which the 
docstring/doctest is attached to.

See https://bugs.launchpad.net/pyflakes/+bug/1178807 for background to this 
enhancement request.

--
components: Tests
messages: 255111
nosy: John.Mark.Vandenberg
priority: normal
severity: normal
status: open
title: Easier way to specify reduced globals for doctest
type: enhancement
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4744] asynchat documentation needs to be more precise

[Martin Panter]

Martin Panter added the comment:

I think it would be okay to keep this issue open to address the other mentions 
of “strings”.

Nitika’s patch is missing the special --- and @@ indicator lines at the top, 
which is probably why it was rejected. Usually you make a patch by using a 
“diff” command (standalone, with Mercurial, etc).

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25251] Unknown MS Compiler version 1900

[Matt Hickford]

Matt Hickford added the comment:

Hi Ateik. Find cygwinccompiler.py on your computer and copy the patch to
the same folder. Then run the command `patch < patch.diff`. It that doesn't
work, just open both files in a text editor and copy and paste the lines to
the right place, you'll work it out.

It may or not solve your problem.

On 15 November 2015 at 12:30, Ateik Al-Zehla  wrote:

>
> Ateik Al-Zehla added the comment:
>
> how to apply patch file : patch.diff ? plz help
>
> --
> nosy: +Ateik Al-Zehla
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com