Re: Freeze break request for mutter!486

2019-03-08 Thread Carlos Garnacho 
Hey,

On Fri, Mar 8, 2019 at 5:22 PM  wrote:
>
>
> +1 / 2
>
> This new fix is more code, which triggers my "risky last-minute commit"
> instincts, but I trust you're proposing it because you think it's safer
> than the originally-accepted solution, in light of the "other reported
> issues."

Thanks! that makes 2/2 with Emmanuele's :). The fix itself could have
been more self contained, cleaning up the then pointless
vfunc/argument added up a bit.

The previous fix solved animations/screenshots, but didn't help for
these later problems (running "XWAYLAND_NO_GLAMOR=1 mutter --wayland
--nested" and running a x11 app there should reproduce), this one
fixes both.

Cheers,
  Carlos

>
> Michael
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter!486

2019-03-08 Thread mcatanzaro 



+1 / 2

This new fix is more code, which triggers my "risky last-minute commit" 
instincts, but I trust you're proposing it because you think it's safer 
than the originally-accepted solution, in light of the "other reported 
issues."


Michael

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2018-03-09 Thread Florian Müllner 
On Fri, Mar 9, 2018 at 8:05 PM, Michael Catanzaro  wrote:
> Approval 2 of 2, but I recommend reverting this on master as well to make
> sure it doesn't slip into 3.30 by mistake.

Good point, but no worries - we haven't branched yet and I'll release
3.28.0 from master :-)

Thanks everyone,
Florian
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2018-03-09 Thread Michael Catanzaro 

On Fri, Mar 9, 2018 at 7:05 AM, Andre Klapper  wrote:

r-t approval 1 of 2.


Approval 2 of 2, but I recommend reverting this on master as well to 
make sure it doesn't slip into 3.30 by mistake. Branches are cheap. :)


Michael

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2018-03-09 Thread Andre Klapper 
On Fri, 2018-03-09 at 12:24 +0100, Florian Müllner wrote:
> Hey everyone!
> 
> As you may know, the tiling improvements in 3.26 involved a grouping
> behavior that turned out rather unpopular, and after some discussion
> we decided that the feature needed more work to be actually useful
> and
> reverted the change on the stable branch:
> 
> https://gitlab.gnome.org/GNOME/mutter/commit/415584344a5d4b5
> 
> Our idea was to refine the grouping behavior this cycle, but in the
> end it didn't happen. So I would like to apply that revert to the
> upcoming 3.28.0 release as well.
> 
> I'm sorry this slipped into the hard code freeze period, I should
> have remembered this before :-(

r-t approval 1 of 2.

andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2016-09-19 Thread Matthias Clasen 
I just remembered that I actually added api for this a while ago, for anaconda:

gtk_get_locale_direction
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2016-09-19 Thread Michael Catanzaro 
On Mon, 2016-09-19 at 17:27 +, Florian Müllner wrote:
> (*) besides bringing back the entire translation infrastructure for a
> single string - though I'm not sure multiple translation domains per
> module
> are even supported

You could just have a list of which locales should use RTL?
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2016-09-19 Thread Florian Müllner 
On Mon, Sep 19, 2016 at 4:39 PM Matthias Clasen 
wrote:

> On Mon, Sep 19, 2016 at 7:14 AM, Andre Klapper  wrote:
>
> > After applying the patch, correct gnome-shell behavior in RTL languages
> > depends on the proper translation of one string in GTK+ for those
> > languages?
>
> Well, gtk uses this approach for its own rtl support. And it has been
> working ok for many years. I guess the only slightly objectionable
> thing here is to use this implementation detail of GTK+ in another
> module.
>

Right, The only alternative I can think of(*) is linking with GTK+ and
making the mutter-clutter API a wrapper around
gtk_widget_get_default_direction(). Not great either, though I guess it
doesn't really matter, given that gtk+ is already a dependency of mutter ...


(*) besides bringing back the entire translation infrastructure for a
single string - though I'm not sure multiple translation domains per module
are even supported
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter and gnome-shell

2016-09-19 Thread Matthias Clasen 
On Mon, Sep 19, 2016 at 9:59 AM, Andre Klapper  wrote:
> On Mon, 2016-09-19 at 18:32 +0200, Rui Tiago Cação Matos wrote:
>> I'd like to request a freeze break request for these 2 simple fixes:
>>
>> gnome-shell crash when taking screenshots in wayland sessions:
>> https://bugzilla.gnome.org/show_bug.cgi?id=771656
>>
>> mutter wrongly offsetting area screenshots:
>> https://bugzilla.gnome.org/show_bug.cgi?id=771502
>
> r-t approval 1 of 2.

second approval.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter and gnome-shell

2016-09-19 Thread Andre Klapper 
On Mon, 2016-09-19 at 18:32 +0200, Rui Tiago Cação Matos wrote:
> I'd like to request a freeze break request for these 2 simple fixes:
> 
> gnome-shell crash when taking screenshots in wayland sessions:
> https://bugzilla.gnome.org/show_bug.cgi?id=771656
> 
> mutter wrongly offsetting area screenshots:
> https://bugzilla.gnome.org/show_bug.cgi?id=771502

r-t approval 1 of 2.

andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2016-09-19 Thread Matthias Clasen 
On Mon, Sep 19, 2016 at 7:14 AM, Andre Klapper  wrote:
> On Mon, 2016-09-19 at 14:12 +0200, Frederic Peters wrote:
>> Florian Müllner wrote:
>> I'd like to request (yet another) freeze break for mutter, namely
>> > the patch in
>> > https://bugzilla.gnome.org/show_bug.cgi?id=771549.
>>
>> Ok, first approval. Fred
>

Approval 2/2

> After applying the patch, correct gnome-shell behavior in RTL languages
> depends on the proper translation of one string in GTK+ for those
> languages?

Well, gtk uses this approach for its own rtl support. And it has been
working ok for many years. I guess the only slightly objectionable
thing here is to use this implementation detail of GTK+ in another
module.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2016-09-19 Thread Andre Klapper 
On Mon, 2016-09-19 at 14:12 +0200, Frederic Peters wrote:
> Florian Müllner wrote:
> I'd like to request (yet another) freeze break for mutter, namely
> > the patch in
> > https://bugzilla.gnome.org/show_bug.cgi?id=771549.
> 
> Ok, first approval. Fred

After applying the patch, correct gnome-shell behavior in RTL languages
depends on the proper translation of one string in GTK+ for those
languages?

Probably good as a workaround, hence r-t approval 2 of 2. 

I hope there are plans to fix this properly?

andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2016-09-19 Thread Frederic Peters 
Hi Florian,

Florian Müllner wrote:

> I'd like to request (yet another) freeze break for mutter, namely the patch
> in
> https://bugzilla.gnome.org/show_bug.cgi?id=771549.

Ok, first approval.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2016-09-14 Thread Michael Catanzaro 
On Wed, 2016-09-14 at 09:21 -0400, Matthias Clasen wrote:
> Those patches all look good to me. In particular the rotation fix is
> important to claim Wayland feature-completeness, so +1 from me for
> the
> release team.

+2
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2016-09-14 Thread Matthias Clasen 
On Wed, Sep 14, 2016 at 8:04 AM, Jonas Ådahl  wrote:
> Hi,
>
> I'd like to request freeze breaks for 5 (five) Wayland related bugs.
>
> One is a feature bug fix, one avoids possibly aborting valid (GTK+)
> clients, and three are crash fixes. I'm listing them below:
>
> Fix output rotation of not-left-most monitors on Wayland:
> https://bugzilla.gnome.org/show_bug.cgi?id=770672
>
> Fix crash happening with pointer warp emulated Xwayland (needs the
> xserver patches on xorg-devel to reproduce):
> https://bugzilla.gnome.org/show_bug.cgi?id=771345
>
> Crash fix for Xdnd interoperability race condition:
> https://bugzilla.gnome.org/show_bug.cgi?id=770940
>
> Don't disconnect (i.e. effectively abort) valid dnd clients when hitting
> race condition:
> https://bugzilla.gnome.org/show_bug.cgi?id=770937
>
> Crash fix for mapping popups on systems without pointer device:
> https://bugzilla.gnome.org/show_bug.cgi?id=771305
>

Those patches all look good to me. In particular the rotation fix is
important to claim Wayland feature-completeness, so +1 from me for the
release team.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Freeze break request for mutter

2012-03-23 Thread Javier Jardón 
2012/3/23 Matthias Clasen matthias.cla...@gmail.com:
 2012/3/23 Rui Tiago Cação Matos tiagoma...@gmail.com:
 Hi,

 Pavel Vasin has filed patches to plug several memory leaks in mutter
 found with valgrind[1].

 At least 2 of those patches[2] fix serious memory leaks since those
 code paths are often taken (especially the 1st one).

 Is it OK to commit those 2 patches?

 approval 1 of 2 for the release team.

2/2 from the R-T



-- 
Javier Jardón Cabezas
___
release-team@gnome.org
http://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.