Re: A question on the marking of differences in between revisions of a review
Ah, I see what's going on. It's being filtered out because it's not included in any of the changed regions in the new diff. This happens so that we can filter out unrelated changes from other commits that happen in between the diffs. It's not ideal, but I don't know that we can do anything about this without bringing back all of the other unrelated changes. -David On Tue, Nov 25, 2014 at 10:00 AM, Andrew MacLeod wrote: > Thanks David although that is not what not I am seeing now that I tracked > down the review again. > > The interdiff between the revision where the code was removed and any > revision after it got added back does not show as an added diff. > > One correction to my original description, the code was added back in > revision 6. I have added screenshots to show the behavior. Screenshot of > the changes from the original to #1 (where the code was removed), 5-6 where > the code was added back in and finally 1-6. > > If I understand you explanation below then this is a bug and the addition > from 1-6 should be highlighted? This is Review Board version 2.0.11 if that > makes a difference. > Thanks, > > -amac > > On Thursday, November 20, 2014 4:40:48 PM UTC-8, David Trowbridge wrote: >> >> This is the case because if you apply rev #2 to the upstream code, those >> lines are present, and if you apply rev #6 to the upstream code, those >> lines are also present (so there's no difference between them). If you view >> the interdiff between 1 and 6, you should see those lines as added. >> >> -David >> >> On Thu, Nov 20, 2014 at 4:25 PM, Andrew MacLeod >> wrote: >> >>> The scenario is as follow. >>> >>> In the first diff posting (rev #1) of a review, lines 5-10 are removed >>> in one particular file. There are lots of other changes in this file and >>> others. >>> >>> In the second diff posting (rev #2) of the review, the lines are added >>> back in. >>> >>> We get several more diff postings on this review until we are at rev#6. >>> Now if you look at the >>> inter-diff changes from rev #2 -> rev #6, the addition of lines 5-10 >>> does *not* show as an addition >>> (ie. in green) on the right hand panel of the diff screen. >>> >>> I can argue why that is the case but my question is this intended >>> behavior? >>> >>> Thanks, >>> >>> -amac >>> >>> -- >>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >>> --- >>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >>> --- >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: SVN connection failure
Are you using the pysvn or subvertpy backend?
-David
On Tue, Nov 25, 2014 at 9:19 AM, Dan Holmes wrote:
> I switched to Ubuntu but am still having SVN connection problems. I went
> back over the installation for SVN python tools and it said it was all
> installed. What am i missing?
>
> from the apache error.log
> [Tue Nov 25 17:14:27.246518 2014] [:error] [pid 8713] ERROR:root:SVN:
> Failed to get repository information for
> https://10.7.0.1:8443/svn/RouteMatch/: ("Unable to connect to a
> repository at URL 'https://10.7.0.1:8443/svn/RouteMatch'", 230001)
>
> however both svn and curl will return without problem.
>
> notroot@RMDevTools01:~$ svn info https://10.7.0.1:8443/svn/RouteMatch/
> Path: RouteMatch
> URL: https://10.7.0.1:8443/svn/RouteMatch
> Relative URL: ^/
> Repository Root: https://10.7.0.1:8443/svn/RouteMatch
> Repository UUID: 34830635-b4d3-f84e-9563-fed92939f730
> Revision: 61143
> Node Kind: directory
> Last Changed Author:
> Last Changed Rev: 61143
> Last Changed Date: 2014-11-25 12:11:56 -0500 (Tue, 25 Nov 2014)
>
> notroot@RMDevTools01:~$ curl https://10.7.0.1:8443/svn/RouteMatch/
> --insecure -u xx
>
>
>
> hrefCDATA #REQUIRED>
>
> pathCDATA #IMPLIED
> rev CDATA #IMPLIED
> baseCDATA #IMPLIED>
>
>
>
> hrefCDATA #REQUIRED>
>
> hrefCDATA #REQUIRED>
> ]>
> href="http://subversion.apache.org/";>
>
> ...
>
>
> --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
SVN connection failure
I switched to Ubuntu but am still having SVN connection problems. I went
back over the installation for SVN python tools and it said it was all
installed. What am i missing?
from the apache error.log
[Tue Nov 25 17:14:27.246518 2014] [:error] [pid 8713] ERROR:root:SVN:
Failed to get repository information for
https://10.7.0.1:8443/svn/RouteMatch/: ("Unable to connect to a repository
at URL 'https://10.7.0.1:8443/svn/RouteMatch'", 230001)
however both svn and curl will return without problem.
notroot@RMDevTools01:~$ svn info https://10.7.0.1:8443/svn/RouteMatch/
Path: RouteMatch
URL: https://10.7.0.1:8443/svn/RouteMatch
Relative URL: ^/
Repository Root: https://10.7.0.1:8443/svn/RouteMatch
Repository UUID: 34830635-b4d3-f84e-9563-fed92939f730
Revision: 61143
Node Kind: directory
Last Changed Author:
Last Changed Rev: 61143
Last Changed Date: 2014-11-25 12:11:56 -0500 (Tue, 25 Nov 2014)
notroot@RMDevTools01:~$ curl https://10.7.0.1:8443/svn/RouteMatch/
--insecure -u xx
]>
http://subversion.apache.org/";>
...
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
easy_install errors - i don't know if these are bad but i thought i would share
On Ubuntu 14.04.01 server, following the instructions i get the following
error(s) when i run the easy_install ReviewBoard command. I haven't yet
tried to run it yet so i don't know if this is fatal but i thought i would
throw this out here before i lost the error messages.
Installing pilprint.py script to /usr/local/bin
Installed
/usr/local/lib/python2.7/dist-packages/Pillow-2.6.1-py2.7-linux-x86_64.egg
Searching for futures>=2.1.3
Reading https://pypi.python.org/simple/futures/
Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
self.run()
File "/usr/lib/python2.7/threading.py", line 763, in run
self.__target(*self.__args, **self.__kwargs)
File "/usr/lib/python2.7/multiprocessing/pool.py", line 330, in
_handle_workers
debug('worker handler exiting')
TypeError: 'NoneType' object is not callable
Exception in thread Thread-2:
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
self.run()
File "/usr/lib/python2.7/threading.py", line 763, in run
self.__target(*self.__args, **self.__kwargs)
File "/usr/lib/python2.7/multiprocessing/pool.py", line 357, in
_handle_tasks
debug('task handler got sentinel')
TypeError: 'NoneType' object is not callable
Best match: futures 2.2.0
Downloading
https://pypi.python.org/packages/source/f/futures/futures-2.2.0.tar.gz#md5=310e446de8609ddb59d0886e35edb534
Processing futures-2.2.0.tar.gz
Writing /tmp/easy_install-pWNWPg/futures-2.2.0/setup.cfg
Running futures-2.2.0/setup.py -q bdist_egg --dist-dir
/tmp/easy_install-pWNWPg/futures-2.2.0/egg-dist-tmp-S1hA5L
Adding futures 2.2.0 to easy-install.pth file
Installed /usr/local/lib/python2.7/dist-packages/futures-2.2.0-py2.7.egg
Finished processing dependencies for ReviewBoard
Exception TypeError: TypeError("'NoneType' object does not support item
deletion",) in ignored
notroot@RMDevTools01:~$
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
