Re: Review Request 57137: Table statistics is not getting computed when 'include columns' is checked

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57137/
---

(Updated March 2, 2017, 4:31 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Changes
---

updated patch after resolving conflicts.


Bugs: AMBARI-20091
https://issues.apache.org/jira/browse/AMBARI-20091


Repository: ambari


Description
---

1) analyze table compute stats for columns
2) analyze table compute stats
 
First one is to collect column statistics and second one is to collect basic 
stats. numRows, dataSize etc. is computed via 2)
To get all stats one has to run both statements. 

Hence implemented in that way.


Diffs (updated)
-

  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
 dbe9d43 
  
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
 7bc5850 


Diff: https://reviews.apache.org/r/57137/diff/2/

Changes: https://reviews.apache.org/r/57137/diff/1-2/


Testing
---

added spock test AnalyzeTableQueryGeneratorSpecTest.groovy


Thanks,

Nitiraj Rathore

Review Request 57228: AMBARI-20265 - Blueprint deployment with auto-restart settings enabled, auto-restart UI is incomplete.

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57228/
---

Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-20265
https://issues.apache.org/jira/browse/AMBARI-20265


Repository: ambari


Description
---

Show UI even when count is 0


Diffs
-

  ambari-web/app/controllers/main/admin/service_auto_start.js 3365cae 


Diff: https://reviews.apache.org/r/57228/diff/1/


Testing
---

Manually tested on live cluster, all unit tests passed.
  30365 passing (22s)
  157 pending


Thanks,

Richard Zang

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

[Alejandro Fernandez]

> On March 1, 2017, 6:57 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
> > Lines 164 (patched)
> > 
> >
> > Is this because of some sort of security concern?
> > Why hide properties from the API?
> > 
> > If you do want to hide props, perhaps it's best added as a new 
> > [blacklisted] section to the current file so that both files can be kept 
> > in-sync.
> 
> Anita Jebaraj wrote:
> Hi Alejandro, hiding the properties from the API would help the users to 
> remove the properties which has information such as database name, database 
> user name etc,  that are not used in the ambari-web, but exposed in the API. 
> 
> I would like to follow the approach suggested by Di to create a property 
> in ambari.properties which would point to the file containing the list that 
> needs to blacklisted. Eventually if there are many properties that are 
> blacklisted, adding a section [blacklisted] would cause the ambari.properties 
> file to grow and make it difficult to maintain. Once the jira is accepted I 
> can write a wiki about how to use this feature.

I'm ok with this approach. Thank you for explaining


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review167543
---


On March 2, 2017, 1:05 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 2, 2017, 1:05 a.m.)
> 
> 
> Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  eaecf35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  51114f8 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/3/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

[Anita Jebaraj]

> On March 1, 2017, 6:57 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
> > Lines 164 (patched)
> > 
> >
> > Is this because of some sort of security concern?
> > Why hide properties from the API?
> > 
> > If you do want to hide props, perhaps it's best added as a new 
> > [blacklisted] section to the current file so that both files can be kept 
> > in-sync.

Hi Alejandro, hiding the properties from the API would help the users to remove 
the properties which has information such as database name, database user name 
etc,  that are not used in the ambari-web, but exposed in the API. 

I would like to follow the approach suggested by Di to create a property in 
ambari.properties which would point to the file containing the list that needs 
to blacklisted. Eventually if there are many properties that are blacklisted, 
adding a section [blacklisted] would cause the ambari.properties file to grow 
and make it difficult to maintain. Once the jira is accepted I can write a wiki 
about how to use this feature.


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review167543
---


On March 2, 2017, 1:05 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 2, 2017, 1:05 a.m.)
> 
> 
> Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  eaecf35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  51114f8 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/3/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/
---

(Updated March 2, 2017, 1:05 a.m.)


Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20243
https://issues.apache.org/jira/browse/AMBARI-20243


Repository: ambari


Description
---

Currently all the details from the ambari.properties file is being returned by 
the API call.

Some of those information may not be utilized and hence an option can be 
provided to filter the properties

A ambari-blacklist.properties file can be created, the properties that are 
entered in the file, will be removed from the api call that returns the 
ambari.properties.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 eaecf35 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
 dadcf09 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 51114f8 


Diff: https://reviews.apache.org/r/57168/diff/3/

Changes: https://reviews.apache.org/r/57168/diff/2-3/


Testing
---

Added 1 test case
Ran mvn test


Thanks,

Anita Jebaraj

Re: Review Request 57215: Startup Annotation Scanning Takes Too Long

[Jonathan Hurley]

> On March 1, 2017, 4:52 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
> > Line 695 (original), 694 (patched)
> > 
> >
> > Minor question:  Should these log messages really be at the INFO level? 
> >  
> > 
> > It seems like we already have too much noise in the ambari-server 
> > startup log, so it's not clear to me why these would be moved from DEBUG.

I debated this as well. I think it's nice to know that they were picked up, but 
then again, we probably don't need them at info ... I'll move these to `debug`


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57215/#review167580
---


On March 1, 2017, 3:51 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57215/
> ---
> 
> (Updated March 1, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-20262
> https://issues.apache.org/jira/browse/AMBARI-20262
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, Ambari uses Spring's 
> {{ClassPathScanningCandidateComponentProvider}} along with an 
> {{AnnotationTypeFilter}} to find classes annotated in our classpath:
> 
> ```
>   ClassPathScanningCandidateComponentProvider scanner =
>   new ClassPathScanningCandidateComponentProvider(false);
> 
>   // match only singletons that are eager listeners
>   for (Class cls : classes) {
> scanner.addIncludeFilter(new AnnotationTypeFilter(cls));
>   }
> 
>   beanDefinitions = scanner.findCandidateComponents(AMBARI_PACKAGE);
> ```
> 
> This takes roughly 19 seconds on normal deployments. We can reduce this time 
> to roughly 8 seconds by switching over to Google's {{ClassPath}} via our 
> internal {{ClasspathScannerUtils}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java
>  d8b8466 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/ClasspathScannerUtils.java
>  01487f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupModule.java
>  d2a7583 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  8646e51 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  3090108 
> 
> 
> Diff: https://reviews.apache.org/r/57215/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 57215: Startup Annotation Scanning Takes Too Long

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57215/#review167580
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
Line 695 (original), 694 (patched)


Minor question:  Should these log messages really be at the INFO level?  

It seems like we already have too much noise in the ambari-server startup 
log, so it's not clear to me why these would be moved from DEBUG.


- Robert Nettleton


On March 1, 2017, 8:51 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57215/
> ---
> 
> (Updated March 1, 2017, 8:51 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-20262
> https://issues.apache.org/jira/browse/AMBARI-20262
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, Ambari uses Spring's 
> {{ClassPathScanningCandidateComponentProvider}} along with an 
> {{AnnotationTypeFilter}} to find classes annotated in our classpath:
> 
> ```
>   ClassPathScanningCandidateComponentProvider scanner =
>   new ClassPathScanningCandidateComponentProvider(false);
> 
>   // match only singletons that are eager listeners
>   for (Class cls : classes) {
> scanner.addIncludeFilter(new AnnotationTypeFilter(cls));
>   }
> 
>   beanDefinitions = scanner.findCandidateComponents(AMBARI_PACKAGE);
> ```
> 
> This takes roughly 19 seconds on normal deployments. We can reduce this time 
> to roughly 8 seconds by switching over to Google's {{ClassPath}} via our 
> internal {{ClasspathScannerUtils}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java
>  d8b8466 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/ClasspathScannerUtils.java
>  01487f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupModule.java
>  d2a7583 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  8646e51 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  3090108 
> 
> 
> Diff: https://reviews.apache.org/r/57215/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 57215: Startup Annotation Scanning Takes Too Long

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57215/#review167568
---




ambari-server/src/main/java/org/apache/ambari/server/cleanup/ClasspathScannerUtils.java
Line 99 (original), 100 (patched)


This was previously comparing `Annotation` to `Class` which didn't match.



ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
Lines 526-527 (original), 526-527 (patched)


This is really the only important change here - essentially Spring's 
annotation scanning was taking like 19 seconds. We have a classpath scanner 
that uses Google's Reflections library which is much faster.


- Jonathan Hurley


On March 1, 2017, 3:51 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57215/
> ---
> 
> (Updated March 1, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-20262
> https://issues.apache.org/jira/browse/AMBARI-20262
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, Ambari uses Spring's 
> {{ClassPathScanningCandidateComponentProvider}} along with an 
> {{AnnotationTypeFilter}} to find classes annotated in our classpath:
> 
> ```
>   ClassPathScanningCandidateComponentProvider scanner =
>   new ClassPathScanningCandidateComponentProvider(false);
> 
>   // match only singletons that are eager listeners
>   for (Class cls : classes) {
> scanner.addIncludeFilter(new AnnotationTypeFilter(cls));
>   }
> 
>   beanDefinitions = scanner.findCandidateComponents(AMBARI_PACKAGE);
> ```
> 
> This takes roughly 19 seconds on normal deployments. We can reduce this time 
> to roughly 8 seconds by switching over to Google's {{ClassPath}} via our 
> internal {{ClasspathScannerUtils}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java
>  d8b8466 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/ClasspathScannerUtils.java
>  01487f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupModule.java
>  d2a7583 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  8646e51 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  3090108 
> 
> 
> Diff: https://reviews.apache.org/r/57215/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 57215: Startup Annotation Scanning Takes Too Long

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57215/
---

Review request for Ambari, Nate Cole and Robert Levas.


Bugs: AMBARI-20262
https://issues.apache.org/jira/browse/AMBARI-20262


Repository: ambari


Description
---

Currently, Ambari uses Spring's {{ClassPathScanningCandidateComponentProvider}} 
along with an {{AnnotationTypeFilter}} to find classes annotated in our 
classpath:

```
  ClassPathScanningCandidateComponentProvider scanner =
  new ClassPathScanningCandidateComponentProvider(false);

  // match only singletons that are eager listeners
  for (Class cls : classes) {
scanner.addIncludeFilter(new AnnotationTypeFilter(cls));
  }

  beanDefinitions = scanner.findCandidateComponents(AMBARI_PACKAGE);
```

This takes roughly 19 seconds on normal deployments. We can reduce this time to 
roughly 8 seconds by switching over to Google's {{ClassPath}} via our internal 
{{ClasspathScannerUtils}}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java
 d8b8466 
  
ambari-server/src/main/java/org/apache/ambari/server/cleanup/ClasspathScannerUtils.java
 01487f0 
  
ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupModule.java 
d2a7583 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 8646e51 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
 3090108 


Diff: https://reviews.apache.org/r/57215/diff/1/


Testing
---

PENDING


Thanks,

Jonathan Hurley

Re: Review Request 57214: Unexpected popup after disable kerberos "You are in the process of disabling security on your cluster"

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57214/#review167566
---


Ship it!




Ship It!

- Alexandr Antonenko


On March 1, 2017, 8:27 p.m., Denys Buzhor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57214/
> ---
> 
> (Updated March 1, 2017, 8:27 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-20261
> https://issues.apache.org/jira/browse/AMBARI-20261
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> * Disable Security
> * Click on "Complete" button
> 
> Confirmation popup is shown instead of closing *Disable Security* popup.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/routes/main.js d7d27857fd 
> 
> 
> Diff: https://reviews.apache.org/r/57214/diff/1/
> 
> 
> Testing
> ---
> 
> 20574 passing (28s)
>   153 pending
> 
> 
> Thanks,
> 
> Denys Buzhor
> 
>

Review Request 57214: Unexpected popup after disable kerberos "You are in the process of disabling security on your cluster"

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57214/
---

Review request for Ambari.


Bugs: AMBARI-20261
https://issues.apache.org/jira/browse/AMBARI-20261


Repository: ambari


Description
---

STR:

* Disable Security
* Click on "Complete" button

Confirmation popup is shown instead of closing *Disable Security* popup.


Diffs
-

  ambari-web/app/routes/main.js d7d27857fd 


Diff: https://reviews.apache.org/r/57214/diff/1/


Testing
---

20574 passing (28s)
  153 pending


Thanks,

Denys Buzhor

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Robert Levas]

> On March 1, 2017, 2:04 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json
> > Line 18 (original), 18 (patched)
> > 
> >
> > I thought Spark2 was supposed to have its own keytab.

Apparently Spark and Spark2 work better if they share the same Kerberos 
identity. Since Ambari does not handle the same principal name in multiple 
keytab files, both services need to use the same keytab file - which is 
preferred since Ambari has to do less work.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/#review167546
---


On March 1, 2017, 6:18 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56980/
> ---
> 
> (Updated March 1, 2017, 6:18 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20140
> https://issues.apache.org/jira/browse/AMBARI-20140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2 and Spark1 shares the same principal name. This casuses a problem when 
> adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
> keytab to Spark2 because it thinks it already exists.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> cf7eeba 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
> 01ee87e 
> 
> 
> Diff: https://reviews.apache.org/r/56980/diff/4/
> 
> 
> Testing
> ---
> 
> - Created a cluster with Spark
> - Enabled Kerberos
> - Added Spark2
> - Checked if Spark2 started successfully 
> - removed spark
> - restarted spark2 successfully, checked the exitance of the spark keytab
> 
> Existing tests ran without failure.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57201: Service Alert Popup - Unexpected User Experience

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57201/
---

(Updated March 1, 2017, 7:16 p.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Changes
---

Increased the height of modal popup. Verified manually.


Bugs: AMBARI-20254
https://issues.apache.org/jira/browse/AMBARI-20254


Repository: ambari


Description
---

AMBARI-19049 introduced some UI changes that causes regression in UX for the 
Service Alert popup.

With the change, the user has to click on the expander to see any alert 
context. And the expander UX is strange too. Clicking anywhere (including the 
hyperlinked text as well as the background) in the header takes the user to the 
alerts page. This is not the experience the user would expect based on 
conventions.

The cases in which too much context is displayed and therefore needs special 
handling is not the norm, so crippling UX for the special case is not the way 
to go.


Diffs (updated)
-

  ambari-web/app/controllers/main/service/info/summary.js b3d7b35 
  ambari-web/app/models/alerts/alert_definition.js 4da7199 
  ambari-web/app/styles/alerts.less e31ea30 
  ambari-web/app/templates/main/service/info/service_alert_popup.hbs 6ab6b3f 


Diff: https://reviews.apache.org/r/57201/diff/2/

Changes: https://reviews.apache.org/r/57201/diff/1-2/


Testing
---

Verified Manually.

Ambari-web unit tests pass
20571 passing (19s)
153 pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 57204: After regenerate keytabs post Ambari upgrade yarn.nodemanager.linux-container-executor.cgroups.mount-path property got added with blank value

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57204/#review167548
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
Lines 457-458 (patched)


There is no need to worry about the existing value in the service's 
configration. The idea is to sync up the user-defined Kerberos Descriptor with 
the stack-level Kerberos Descriptor.  Any existing service configuration will 
be untouched, and by removing the relelvant configuration specification from 
the user-defined Kerberos descriptor, the config will remain untouched during 
Kerberos-related operations, as desired.


- Robert Levas


On March 1, 2017, 11:12 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57204/
> ---
> 
> (Updated March 1, 2017, 11:12 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20237
> https://issues.apache.org/jira/browse/AMBARI-20237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR
> 1. Deployed cluster with Ambari version: 2.4.1 and HDP version: 2.5.0(secure 
> cluster)
> 2. Upgrade Ambari to 2.5
> 3. Regenerate keytabs for missing hosts and let it complete
> 4. Go to YARN - configs
> Result
> Observed that yarn.nodemanager.linux-container-executor.cgroups.mount-path 
> got added as a property with blank value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  39a129d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  64536cb 
>   
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_5_infra_solr.json
>  172ad05 
> 
> 
> Diff: https://reviews.apache.org/r/57204/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [1.412s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.063s]
> [INFO] Ambari Web  SUCCESS [2:43.041s]
> [INFO] Ambari Views .. SUCCESS [2.060s]
> [INFO] Ambari Admin View . SUCCESS [53.373s]
> [INFO] utility ... SUCCESS [0.964s]
> [INFO] ambari-metrics  SUCCESS [0.232s]
> [INFO] Ambari Metrics Common . SUCCESS [6.656s]
> [INFO] Ambari Server . SUCCESS 
> [26:02.995s]
> [INFO] Ambari Agent .. SUCCESS [1:23.748s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 31:15.402s
> [INFO] Finished at: Wed Mar 01 17:58:13 EET 2017
> [INFO] Final Memory: 242M/2931M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57147: Added support for processing custom command script timeout

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57147/#review167547
---




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml
Lines 64 (patched)


I'm still opposed to this patch fundamentally because no command should be 
able to run for 2 hours. That will block other commands on the client that 
decided to run it, which is extremely problematic.

Please make this call return right away and check the existence of the 
/system/balancer.id file


- Alejandro Fernandez


On Feb. 28, 2017, 6:01 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57147/
> ---
> 
> (Updated Feb. 28, 2017, 6:01 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20175
> https://issues.apache.org/jira/browse/AMBARI-20175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS rebalance operation can last for a long time (hours/days) thus when 
> triggered from the UI the command may be timed out by the Ambari server.
> This behavior may confuse users, making them to trigger the rebalancer again 
> which will fail with "another balancer is running"  error.
> 
> The patch provides support for setting a reasonably long timeout for the 
> rebalance custo action so that Ambari server doesnt time out the command.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  867ebff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> fd7f2f6 
> 
> 
> Diff: https://reviews.apache.org/r/57147/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests OK.
> Manually tested on local dev-env.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57203: Log Search upgrade to 2.5 should handle renamed properties safely

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57203/#review167545
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 1, 2017, 3:33 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57203/
> ---
> 
> (Updated March 1, 2017, 3:33 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20257
> https://issues.apache.org/jira/browse/AMBARI-20257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search upgrade to 2.5 renames some variables. If for some reason the 
> upgrade is repeated, it tries to rename them again, which causes some 
> problem, as the original variables are not present anymore.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  39a129d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  d57b98b 
> 
> 
> Diff: https://reviews.apache.org/r/57203/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster by upgrading it, re-set 2.4.2 in the database, then 
> upgradeing it again.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167538
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
Lines 603 (patched)


Also remove any leading or trailing whitespace


- Alejandro Fernandez


On March 1, 2017, 12:36 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> ---
> 
> (Updated March 1, 2017, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding dependency of kafka broker's listeners config to populate accurate 
> port for Atlas atlas.kafka.bootstrap.servers property.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  15cc73b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 6f3dfa7 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> cf1c0ee 
> 
> 
> Diff: https://reviews.apache.org/r/57139/diff/2/
> 
> 
> Testing
> ---
> 
> Verified dependency of : listeners propert for following cases: 
> 
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:
> 
> 2) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:
> 
> 3) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:,PLAINTEXT://localhost:
> 
> 4) Kerberos environment with listener's value as : 
> PLAINTEXT://localhost: :: in this case it will pickup the port given 
> for PLAINTEXT protocol only (as SASL port is not specified).
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 57204: After regenerate keytabs post Ambari upgrade yarn.nodemanager.linux-container-executor.cgroups.mount-path property got added with blank value

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57204/#review167514
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
Lines 457 (patched)


What if the property is already deleted?


- Alejandro Fernandez


On March 1, 2017, 4:12 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57204/
> ---
> 
> (Updated March 1, 2017, 4:12 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20237
> https://issues.apache.org/jira/browse/AMBARI-20237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR
> 1. Deployed cluster with Ambari version: 2.4.1 and HDP version: 2.5.0(secure 
> cluster)
> 2. Upgrade Ambari to 2.5
> 3. Regenerate keytabs for missing hosts and let it complete
> 4. Go to YARN - configs
> Result
> Observed that yarn.nodemanager.linux-container-executor.cgroups.mount-path 
> got added as a property with blank value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  39a129d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  64536cb 
>   
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_5_infra_solr.json
>  172ad05 
> 
> 
> Diff: https://reviews.apache.org/r/57204/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [1.412s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.063s]
> [INFO] Ambari Web  SUCCESS [2:43.041s]
> [INFO] Ambari Views .. SUCCESS [2.060s]
> [INFO] Ambari Admin View . SUCCESS [53.373s]
> [INFO] utility ... SUCCESS [0.964s]
> [INFO] ambari-metrics  SUCCESS [0.232s]
> [INFO] Ambari Metrics Common . SUCCESS [6.656s]
> [INFO] Ambari Server . SUCCESS 
> [26:02.995s]
> [INFO] Ambari Agent .. SUCCESS [1:23.748s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 31:15.402s
> [INFO] Finished at: Wed Mar 01 17:58:13 EET 2017
> [INFO] Final Memory: 242M/2931M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

[Sriharsha Chintalapani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167513
---


Ship it!




This looks good. I suggest you to add one more test or test manually if the 
protocol is SASL_PLAINTEXT. As per the code it looks like handling it but good 
to test this part.

- Sriharsha Chintalapani


On March 1, 2017, 12:36 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> ---
> 
> (Updated March 1, 2017, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding dependency of kafka broker's listeners config to populate accurate 
> port for Atlas atlas.kafka.bootstrap.servers property.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  15cc73b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 6f3dfa7 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> cf1c0ee 
> 
> 
> Diff: https://reviews.apache.org/r/57139/diff/2/
> 
> 
> Testing
> ---
> 
> Verified dependency of : listeners propert for following cases: 
> 
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:
> 
> 2) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:
> 
> 3) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:,PLAINTEXT://localhost:
> 
> 4) Kerberos environment with listener's value as : 
> PLAINTEXT://localhost: :: in this case it will pickup the port given 
> for PLAINTEXT protocol only (as SASL port is not specified).
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 57204: After regenerate keytabs post Ambari upgrade yarn.nodemanager.linux-container-executor.cgroups.mount-path property got added with blank value

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57204/#review167458
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 1, 2017, 6:12 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57204/
> ---
> 
> (Updated March 1, 2017, 6:12 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20237
> https://issues.apache.org/jira/browse/AMBARI-20237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR
> 1. Deployed cluster with Ambari version: 2.4.1 and HDP version: 2.5.0(secure 
> cluster)
> 2. Upgrade Ambari to 2.5
> 3. Regenerate keytabs for missing hosts and let it complete
> 4. Go to YARN - configs
> Result
> Observed that yarn.nodemanager.linux-container-executor.cgroups.mount-path 
> got added as a property with blank value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  39a129d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  64536cb 
>   
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_5_infra_solr.json
>  172ad05 
> 
> 
> Diff: https://reviews.apache.org/r/57204/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [1.412s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.063s]
> [INFO] Ambari Web  SUCCESS [2:43.041s]
> [INFO] Ambari Views .. SUCCESS [2.060s]
> [INFO] Ambari Admin View . SUCCESS [53.373s]
> [INFO] utility ... SUCCESS [0.964s]
> [INFO] ambari-metrics  SUCCESS [0.232s]
> [INFO] Ambari Metrics Common . SUCCESS [6.656s]
> [INFO] Ambari Server . SUCCESS 
> [26:02.995s]
> [INFO] Ambari Agent .. SUCCESS [1:23.748s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 31:15.402s
> [INFO] Finished at: Wed Mar 01 17:58:13 EET 2017
> [INFO] Final Memory: 242M/2931M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57198: HiveView2.0: Can not create a table with space in column name with upload table feature

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57198/
---

(Updated March 1, 2017, 6:16 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Changes
---

update patch to remove conflicts


Bugs: AMBARI-20181
https://issues.apache.org/jira/browse/AMBARI-20181


Repository: ambari


Description
---

added back ticks in the query


Diffs (updated)
-

  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java
 9f179d1 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGenerator.java
 eab3a4b 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
 b544100 
  
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGeneratorTest.java
 f5a9778 
  
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGeneratorSpecTest.groovy
 PRE-CREATION 


Diff: https://reviews.apache.org/r/57198/diff/2/

Changes: https://reviews.apache.org/r/57198/diff/1-2/


Testing
---

added InsertFromQueryGeneratorSpecTest.groovy test class


Thanks,

Nitiraj Rathore

Re: Review Request 57209: AMBARI-20244 : HBase indicates restart required after upgrade from Amabri-2.4+HDP-2.5

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57209/#review167315
---


Ship it!




Ship It!

- Sid Wagle


On March 1, 2017, 5:59 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57209/
> ---
> 
> (Updated March 1, 2017, 5:59 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20244
> https://issues.apache.org/jira/browse/AMBARI-20244
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HBase indicates restart required after upgrade to Ambari-2.5 from Ambari-2.4 
> + HDP-2.6. The root cause seems to be the addition of a property to 
> ams-ssl-client config type
> 
> Ambari-2.4 deployed
> "properties" : {
> "ssl.client.truststore.location" : "/etc/security/clientKeys/all.jks",
> "ssl.client.truststore.password" : 
> "SECRET:ams-ssl-client:1:ssl.client.truststore.password",
> "ssl.client.truststore.type" : "jks"
>   }
> 
> Post upgrade it became the following - *ssl.client.truststore.alias* got 
> added.
> 
> "properties" : {
> "ssl.client.truststore.alias" : "",
> "ssl.client.truststore.location" : "/etc/security/clientKeys/all.jks",
> "ssl.client.truststore.password" : 
> "SECRET:ams-ssl-client:2:ssl.client.truststore.password",
> "ssl.client.truststore.type" : "jks"
>   }
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/metainfo.xml
>  377e74c 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metainfo.xml 
> b4f1058 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml
>  a56ff10 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> fd7f2f6 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
> 049705d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/metainfo.xml 
> 0f4d520 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/metainfo.xml 
> e5558c8 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
> 25e242b 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHBASE/metainfo.xml
>  059deff 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml
>  99cedd9 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEYARN/metainfo.xml
>  e07f3a7 
> 
> 
> Diff: https://reviews.apache.org/r/57209/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 56977: Not able to compute the table statistics for partitioned table

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56977/#review167293
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 1, 2017, 5:37 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56977/
> ---
> 
> (Updated March 1, 2017, 5:37 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20113
> https://issues.apache.org/jira/browse/AMBARI-20113
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the case of partitioned table in analyze query generation.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  1d68407 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
>  e433dc4 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
>  89b9d84 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56977/diff/2/
> 
> 
> Testing
> ---
> 
> AnalyzeTableQueryGeneratorSpecTest unit test case added.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 56977: Not able to compute the table statistics for partitioned table

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56977/
---

(Updated March 1, 2017, 5:37 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Changes
---

resolved conflicts and uploaded new patch


Bugs: AMBARI-20113
https://issues.apache.org/jira/browse/AMBARI-20113


Repository: ambari


Description
---

corrected the case of partitioned table in analyze query generation.


Diffs (updated)
-

  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
 1d68407 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
 e433dc4 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
 89b9d84 
  
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
 PRE-CREATION 


Diff: https://reviews.apache.org/r/56977/diff/2/

Changes: https://reviews.apache.org/r/56977/diff/1-2/


Testing
---

AnalyzeTableQueryGeneratorSpecTest unit test case added.


Thanks,

Nitiraj Rathore

Review Request 57204: After regenerate keytabs post Ambari upgrade yarn.nodemanager.linux-container-executor.cgroups.mount-path property got added with blank value

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57204/
---

Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-20237
https://issues.apache.org/jira/browse/AMBARI-20237


Repository: ambari


Description
---

STR
1. Deployed cluster with Ambari version: 2.4.1 and HDP version: 2.5.0(secure 
cluster)
2. Upgrade Ambari to 2.5
3. Regenerate keytabs for missing hosts and let it complete
4. Go to YARN - configs
Result
Observed that yarn.nodemanager.linux-container-executor.cgroups.mount-path got 
added as a property with blank value


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 39a129d 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 64536cb 
  
ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_5_infra_solr.json
 172ad05 


Diff: https://reviews.apache.org/r/57204/diff/1/


Testing
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [1.412s]
[INFO] Apache Ambari Project POM . SUCCESS [0.063s]
[INFO] Ambari Web  SUCCESS [2:43.041s]
[INFO] Ambari Views .. SUCCESS [2.060s]
[INFO] Ambari Admin View . SUCCESS [53.373s]
[INFO] utility ... SUCCESS [0.964s]
[INFO] ambari-metrics  SUCCESS [0.232s]
[INFO] Ambari Metrics Common . SUCCESS [6.656s]
[INFO] Ambari Server . SUCCESS [26:02.995s]
[INFO] Ambari Agent .. SUCCESS [1:23.748s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 31:15.402s
[INFO] Finished at: Wed Mar 01 17:58:13 EET 2017
[INFO] Final Memory: 242M/2931M
[INFO] 


Thanks,

Eugene Chekanskiy

Re: Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57196/
---

(Updated March 1, 2017, 3:46 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Changes
---

Fixed merge conflict


Bugs: AMBARI-20251
https://issues.apache.org/jira/browse/AMBARI-20251


Repository: ambari


Description
---

Tez UI errors are handled in query page, button to maximise and minimise Tez UI 
is given, issue of creation of duplicate tabs is solved by using ID in route 
instead of title, issues in saving a query and opening the saved query have 
been solved as we are now using tab instead if title.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js 
f2af6bc 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
62e5562 
  
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js
 c85db19 
  contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 5369f8e 
  contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js 
943d002 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs 6fc7486 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs
 edc1e8e 


Diff: https://reviews.apache.org/r/57196/diff/3/

Changes: https://reviews.apache.org/r/57196/diff/2-3/


Testing
---

Manual testing done


Thanks,

venkat sairam

Review Request 57202: Sometimes the Hosts page shows a different page for page 1

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57202/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20255
https://issues.apache.org/jira/browse/AMBARI-20255


Repository: ambari


Description
---

I've seen cases where you go back to the Hosts page and the paging filter on 
the bottom is showing page 1, but page 2 results are shown.
Repro scenario:
Go to Hosts page
Apply a valid filter (Host Status: Slave Down)
Go to page 2
Click on "Services" from the top nav
Go back to Hosts page. Initially, the hosts from the original filter are shown 
(but the filter is cleared). Then the hosts with no filters show up, but the 
page is still showing 2


Diffs
-

  ambari-web/app/controllers/global/update_controller.js 75b4a00 
  ambari-web/app/controllers/main/host.js 336bd25 
  ambari-web/app/mixins/common/table_server_view_mixin.js 4e982d7 
  ambari-web/app/views/common/table_view.js 9fcefc7 
  ambari-web/app/views/main/host.js 8959dde 
  ambari-web/test/mixins/common/table_server_view_mixin_test.js 2a9c409 
  ambari-web/test/views/common/table_view_test.js 37dd911 
  ambari-web/test/views/main/host_test.js a5fce45 


Diff: https://reviews.apache.org/r/57202/diff/1/


Testing
---

20574 passing (34s)
153 pending


Thanks,

Andrii Tkach

Re: Review Request 57203: Log Search upgrade to 2.5 should handle renamed properties safely

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57203/#review167279
---


Ship it!




Ship It!

- Oliver Szabo


On March 1, 2017, 3:10 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57203/
> ---
> 
> (Updated March 1, 2017, 3:10 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20257
> https://issues.apache.org/jira/browse/AMBARI-20257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search upgrade to 2.5 renames some variables. If for some reason the 
> upgrade is repeated, it tries to rename them again, which causes some 
> problem, as the original variables are not present anymore.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  39a129d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  d57b98b 
> 
> 
> Diff: https://reviews.apache.org/r/57203/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster by upgrading it, re-set 2.4.2 in the database, then 
> upgradeing it again.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 57203: Log Search upgrade to 2.5 should handle renamed properties safely

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57203/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-20257
https://issues.apache.org/jira/browse/AMBARI-20257


Repository: ambari


Description
---

Log Search upgrade to 2.5 renames some variables. If for some reason the 
upgrade is repeated, it tries to rename them again, which causes some problem, 
as the original variables are not present anymore.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 39a129d 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
 d57b98b 


Diff: https://reviews.apache.org/r/57203/diff/1/


Testing
---

Tested on local cluster by upgrading it, re-set 2.4.2 in the database, then 
upgradeing it again.


Thanks,

Miklos Gergely

Review Request 57201: Service Alert Popup - Unexpected User Experience

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57201/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-20254
https://issues.apache.org/jira/browse/AMBARI-20254


Repository: ambari


Description
---

AMBARI-19049 introduced some UI changes that causes regression in UX for the 
Service Alert popup.

With the change, the user has to click on the expander to see any alert 
context. And the expander UX is strange too. Clicking anywhere (including the 
hyperlinked text as well as the background) in the header takes the user to the 
alerts page. This is not the experience the user would expect based on 
conventions.

The cases in which too much context is displayed and therefore needs special 
handling is not the norm, so crippling UX for the special case is not the way 
to go.


Diffs
-

  ambari-web/app/controllers/main/service/info/summary.js b3d7b35 
  ambari-web/app/models/alerts/alert_definition.js 4da7199 
  ambari-web/app/styles/alerts.less e31ea30 
  ambari-web/app/templates/main/service/info/service_alert_popup.hbs 6ab6b3f 


Diff: https://reviews.apache.org/r/57201/diff/1/


Testing
---

Verified Manually.

Ambari-web unit tests pass
20571 passing (19s)
153 pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57196/#review167271
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On March 1, 2017, 12:41 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57196/
> ---
> 
> (Updated March 1, 2017, 12:41 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20251
> https://issues.apache.org/jira/browse/AMBARI-20251
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Tez UI errors are handled in query page, button to maximise and minimise Tez 
> UI is given, issue of creation of duplicate tabs is solved by using ID in 
> route instead of title, issues in saving a query and opening the saved query 
> have been solved as we are now using tab instead if title.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js 
> f2af6bc 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 4ac93db 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js
>  c85db19 
>   contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 
> 5369f8e 
>   contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js 
> 943d002 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs 
> 6fc7486 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs
>  edc1e8e 
> 
> 
> Diff: https://reviews.apache.org/r/57196/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/#review167270
---


Ship it!




Ship It!

- Robert Levas


On March 1, 2017, 6:18 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56980/
> ---
> 
> (Updated March 1, 2017, 6:18 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20140
> https://issues.apache.org/jira/browse/AMBARI-20140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2 and Spark1 shares the same principal name. This casuses a problem when 
> adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
> keytab to Spark2 because it thinks it already exists.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> cf7eeba 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
> 01ee87e 
> 
> 
> Diff: https://reviews.apache.org/r/56980/diff/4/
> 
> 
> Testing
> ---
> 
> - Created a cluster with Spark
> - Enabled Kerberos
> - Added Spark2
> - Checked if Spark2 started successfully 
> - removed spark
> - restarted spark2 successfully, checked the exitance of the spark keytab
> 
> Existing tests ran without failure.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57147: Added support for processing custom command script timeout

[Laszlo Puskas]

> On Feb. 28, 2017, 6:32 p.m., Alejandro Fernandez wrote:
> >

Thanks Alejanro, i wasn't ware of that; I'll do the modification to the other 
approach then.


> On Feb. 28, 2017, 6:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml
> > Lines 64 (patched)
> > 
> >
> > What happens if a rebalance command is issued and one is already 
> > running?
> > 
> > I don't want a process running on Ambari for up to 2 hours. And for 
> > very large clusters (1000+ nodes), it may still timeout.
> 
> Alejandro Fernandez wrote:
> HDFS stores a file in /system/balancer.id while the balancer is on-going. 
> As soon as it finishes, it is deleted.
> You can use that to make the call return right away and run in the 
> background, and also prevent subsequent calls from launching another 
> rebalancer.

This is intended to be a workaround as the current implementation caused 
problems when the rebalancing process took a long time. While i also think that 
having long running custom command is not ideal, this approach seemed to be the 
right compromise on having some feedback from the process.

If two users trigger/start the rebalancing separately, the second will fail 
with "another balancer is running", as it happens today.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57147/#review167117
---


On Feb. 28, 2017, 6:01 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57147/
> ---
> 
> (Updated Feb. 28, 2017, 6:01 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20175
> https://issues.apache.org/jira/browse/AMBARI-20175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS rebalance operation can last for a long time (hours/days) thus when 
> triggered from the UI the command may be timed out by the Ambari server.
> This behavior may confuse users, making them to trigger the rebalancer again 
> which will fail with "another balancer is running"  error.
> 
> The patch provides support for setting a reasonably long timeout for the 
> rebalance custo action so that Ambari server doesnt time out the command.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  867ebff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> fd7f2f6 
> 
> 
> Diff: https://reviews.apache.org/r/57147/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests OK.
> Manually tested on local dev-env.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57196/
---

(Updated March 1, 2017, 12:41 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20251
https://issues.apache.org/jira/browse/AMBARI-20251


Repository: ambari


Description
---

Tez UI errors are handled in query page, button to maximise and minimise Tez UI 
is given, issue of creation of duplicate tabs is solved by using ID in route 
instead of title, issues in saving a query and opening the saved query have 
been solved as we are now using tab instead if title.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js 
f2af6bc 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
4ac93db 
  
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js
 c85db19 
  contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 5369f8e 
  contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js 
943d002 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs 6fc7486 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs
 edc1e8e 


Diff: https://reviews.apache.org/r/57196/diff/2/

Changes: https://reviews.apache.org/r/57196/diff/1-2/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

[Vishal Suvagia via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/
---

(Updated March 1, 2017, 12:36 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.


Changes
---

updating patch to fix overlooked scenarios.


Bugs: AMBARI-20208
https://issues.apache.org/jira/browse/AMBARI-20208


Repository: ambari


Description
---

Adding dependency of kafka broker's listeners config to populate accurate port 
for Atlas atlas.kafka.bootstrap.servers property.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
 15cc73b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
6f3dfa7 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py cf1c0ee 


Diff: https://reviews.apache.org/r/57139/diff/2/

Changes: https://reviews.apache.org/r/57139/diff/1-2/


Testing
---

Verified dependency of : listeners propert for following cases: 

1) Simple environment with listener's value as : PLAINTEXT://localhost:

2) Kerberos environment with listener's value as : 
PLAINTEXTSASL://localhost:

3) Kerberos environment with listener's value as : 
PLAINTEXTSASL://localhost:,PLAINTEXT://localhost:

4) Kerberos environment with listener's value as : PLAINTEXT://localhost: 
:: in this case it will pickup the port given for PLAINTEXT protocol only (as 
SASL port is not specified).


Thanks,

Vishal Suvagia

Re: Review Request 57198: HiveView2.0: Can not create a table with space in column name with upload table feature

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57198/#review167268
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On March 1, 2017, 10:23 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57198/
> ---
> 
> (Updated March 1, 2017, 10:23 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20181
> https://issues.apache.org/jira/browse/AMBARI-20181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added back ticks in the query
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java
>  9f179d1 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGenerator.java
>  eab3a4b 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
>  42cec0a 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGeneratorTest.java
>  f5a9778 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57198/diff/1/
> 
> 
> Testing
> ---
> 
> added InsertFromQueryGeneratorSpecTest.groovy test class
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57137: Table statistics is not getting computed when 'include columns' is checked

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57137/#review167269
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 28, 2017, 11:24 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57137/
> ---
> 
> (Updated Feb. 28, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20091
> https://issues.apache.org/jira/browse/AMBARI-20091
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) analyze table compute stats for columns
> 2) analyze table compute stats
>  
> First one is to collect column statistics and second one is to collect basic 
> stats. numRows, dataSize etc. is computed via 2)
> To get all stats one has to run both statements. 
> 
> Hence implemented in that way.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  902d959 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57137/diff/1/
> 
> 
> Testing
> ---
> 
> added spock test AnalyzeTableQueryGeneratorSpecTest.groovy
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57179: AMBARI-20131.Workflow details are lost upon refreshing the browser

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57179/#review167262
---


Ship it!




Ship It!

- Gaurav Nagar


On March 1, 2017, 6:34 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57179/
> ---
> 
> (Updated March 1, 2017, 6:34 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20131
> https://issues.apache.org/jira/browse/AMBARI-20131
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by creating the tabs observer after tabs are initializes
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  74de3b7 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js
>  2e937e5 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 9fd8286 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js 
> 7c59f40 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js
>  e77ef7f 
> 
> 
> Diff: https://reviews.apache.org/r/57179/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 57181: AMBARI-20206.Workflow manager is allowing to have empty action node

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57181/#review167263
---


Ship it!




Ship It!

- Gaurav Nagar


On March 1, 2017, 7:25 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57181/
> ---
> 
> (Updated March 1, 2017, 7:25 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20206
> https://issues.apache.org/jira/browse/AMBARI-20206
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified validation to check for empty action node name.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 2d326d1 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 8aac32b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs
>  00cb8a6 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs 
> d96be85 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js
>  86e5182 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-kill-node-name.js
>  b8770c2 
> 
> 
> Diff: https://reviews.apache.org/r/57181/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/#review167261
---


Ship it!




Ship It!

- Sebastian Toader


On March 1, 2017, 12:18 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56980/
> ---
> 
> (Updated March 1, 2017, 12:18 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20140
> https://issues.apache.org/jira/browse/AMBARI-20140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2 and Spark1 shares the same principal name. This casuses a problem when 
> adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
> keytab to Spark2 because it thinks it already exists.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> cf7eeba 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
> 01ee87e 
> 
> 
> Diff: https://reviews.apache.org/r/56980/diff/4/
> 
> 
> Testing
> ---
> 
> - Created a cluster with Spark
> - Enabled Kerberos
> - Added Spark2
> - Checked if Spark2 started successfully 
> - removed spark
> - restarted spark2 successfully, checked the exitance of the spark keytab
> 
> Existing tests ran without failure.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57137: Table statistics is not getting computed when 'include columns' is checked

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57137/#review167260
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 28, 2017, 11:24 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57137/
> ---
> 
> (Updated Feb. 28, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20091
> https://issues.apache.org/jira/browse/AMBARI-20091
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) analyze table compute stats for columns
> 2) analyze table compute stats
>  
> First one is to collect column statistics and second one is to collect basic 
> stats. numRows, dataSize etc. is computed via 2)
> To get all stats one has to run both statements. 
> 
> Hence implemented in that way.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  902d959 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57137/diff/1/
> 
> 
> Testing
> ---
> 
> added spock test AnalyzeTableQueryGeneratorSpecTest.groovy
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57198: HiveView2.0: Can not create a table with space in column name with upload table feature

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57198/#review167259
---


Ship it!




Ship It!

- Gaurav Nagar


On March 1, 2017, 10:23 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57198/
> ---
> 
> (Updated March 1, 2017, 10:23 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20181
> https://issues.apache.org/jira/browse/AMBARI-20181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added back ticks in the query
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java
>  9f179d1 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGenerator.java
>  eab3a4b 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
>  42cec0a 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGeneratorTest.java
>  f5a9778 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57198/diff/1/
> 
> 
> Testing
> ---
> 
> added InsertFromQueryGeneratorSpecTest.groovy test class
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/
---

(Updated March 1, 2017, 11:18 a.m.)


Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
and Sebastian Toader.


Changes
---

dropping the previous approach, let's use the same keytab file in both cases


Bugs: AMBARI-20140
https://issues.apache.org/jira/browse/AMBARI-20140


Repository: ambari


Description (updated)
---

Spark2 and Spark1 shares the same principal name. This casuses a problem when 
adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
keytab to Spark2 because it thinks it already exists.


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
cf7eeba 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
01ee87e 


Diff: https://reviews.apache.org/r/56980/diff/4/

Changes: https://reviews.apache.org/r/56980/diff/3-4/


Testing (updated)
---

- Created a cluster with Spark
- Enabled Kerberos
- Added Spark2
- Checked if Spark2 started successfully 
- removed spark
- restarted spark2 successfully, checked the exitance of the spark keytab

Existing tests ran without failure.


Thanks,

Attila Magyar

Re: Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57196/#review167251
---


Ship it!




Ship It!

- Gaurav Nagar


On March 1, 2017, 10:32 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57196/
> ---
> 
> (Updated March 1, 2017, 10:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20251
> https://issues.apache.org/jira/browse/AMBARI-20251
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Tez UI errors are handled in query page, button to maximise and minimise Tez 
> UI is given, issue of creation of duplicate tabs is solved by using ID in 
> route instead of title, issues in saving a query and opening the saved query 
> have been solved as we are now using tab instead if title.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js 
> f2af6bc 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 4ac93db 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js
>  c85db19 
>   contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 
> 5369f8e 
>   contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js 
> 943d002 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs 
> 6fc7486 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs
>  edc1e8e 
> 
> 
> Diff: https://reviews.apache.org/r/57196/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 57196: Tez UI throwing 404 error, Button to minimise TEZ UI, Worksheet save issues, creation of duplicate tabs and other tab issues

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57196/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20251
https://issues.apache.org/jira/browse/AMBARI-20251


Repository: ambari


Description
---

Tez UI errors are handled in query page, button to maximise and minimise Tez UI 
is given, issue of creation of duplicate tabs is solved by using ID in route 
instead of title, issues in saving a query and opening the saved query have 
been solved as we are now using tab instead if title.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js 
f2af6bc 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
4ac93db 
  
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js
 c85db19 
  contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 5369f8e 
  contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js 
943d002 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs 6fc7486 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs
 edc1e8e 


Diff: https://reviews.apache.org/r/57196/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 57197: Add ability to use brace expansion in the dependent keys

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57197/#review167248
---


Ship it!




Ship It!

- Denys Buzhor


On March 1, 2017, 10:15 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57197/
> ---
> 
> (Updated March 1, 2017, 10:15 a.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20252
> https://issues.apache.org/jira/browse/ambari-20252
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {{'a.b', 'a.c'}}  {{'a.{b,c}'}}
> 
> Such ability exists in the Ember for a few years and may be implemented in 
> Ambari.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/ember_reopen.js c7f93af 
>   ambari-web/test/utils/ember_reopen_test.js aa50a50 
> 
> 
> Diff: https://reviews.apache.org/r/57197/diff/1/
> 
> 
> Testing
> ---
> 
> 20571 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Re: Review Request 57075: hive-site.xml, hbase-site.xml, etc. are not found in class path for Zeppelin

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57075/#review167246
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 1, 2017, 7:35 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57075/
> ---
> 
> (Updated March 1, 2017, 7:35 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20200
> https://issues.apache.org/jira/browse/AMBARI-20200
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> hive-site.xml, hbase-site.xml, etc. are not found in class path for 
> Zeppelin's interpreter.
> 
> As a result of which JDBC:phoenix  on kerberos mode doesn't work.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  677158c 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  8a1fad6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  16a2782 
> 
> 
> Diff: https://reviews.apache.org/r/57075/diff/6/
> 
> 
> Testing
> ---
> 
> Manually on CentOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 57075: hive-site.xml, hbase-site.xml, etc. are not found in class path for Zeppelin

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57075/#review167245
---


Ship it!




Ship It!

- Renjith Kamath


On March 1, 2017, 7:35 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57075/
> ---
> 
> (Updated March 1, 2017, 7:35 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20200
> https://issues.apache.org/jira/browse/AMBARI-20200
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> hive-site.xml, hbase-site.xml, etc. are not found in class path for 
> Zeppelin's interpreter.
> 
> As a result of which JDBC:phoenix  on kerberos mode doesn't work.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  677158c 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  8a1fad6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  16a2782 
> 
> 
> Diff: https://reviews.apache.org/r/57075/diff/6/
> 
> 
> Testing
> ---
> 
> Manually on CentOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 57189: AMBARI-20246.Not able to preview the xml for coordinator

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57189/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20246
https://issues.apache.org/jira/browse/AMBARI-20246


Repository: ambari


Description
---

Fixed by changing slainfo property to slaInfo


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
b5592a6 
  contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js 
be5d6f9 
  
contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
 5101181 


Diff: https://reviews.apache.org/r/57189/diff/1/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 57189: AMBARI-20246.Not able to preview the xml for coordinator

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57189/#review167243
---


Ship it!




Ship It!

- belliraj hb


On March 1, 2017, 9:55 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57189/
> ---
> 
> (Updated March 1, 2017, 9:55 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20246
> https://issues.apache.org/jira/browse/AMBARI-20246
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by changing slainfo property to slaInfo
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> b5592a6 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js 
> be5d6f9 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
>  5101181 
> 
> 
> Diff: https://reviews.apache.org/r/57189/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 57188: HiveView2.0: Misplaced download results popup when result set is longer causing UI to appear as hung

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57188/#review167241
---


Ship it!




Ship It!

- Gaurav Nagar


On March 1, 2017, 9:17 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57188/
> ---
> 
> (Updated March 1, 2017, 9:17 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20250
> https://issues.apache.org/jira/browse/AMBARI-20250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a CSS to ovveride the default css.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2824dc6 
> 
> 
> Diff: https://reviews.apache.org/r/57188/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 57188: HiveView2.0: Misplaced download results popup when result set is longer causing UI to appear as hung

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57188/#review167240
---


Ship it!




Ship It!

- venkat sairam


On March 1, 2017, 9:17 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57188/
> ---
> 
> (Updated March 1, 2017, 9:17 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20250
> https://issues.apache.org/jira/browse/AMBARI-20250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a CSS to ovveride the default css.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2824dc6 
> 
> 
> Diff: https://reviews.apache.org/r/57188/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 57188: HiveView2.0: Misplaced download results popup when result set is longer causing UI to appear as hung

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57188/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20250
https://issues.apache.org/jira/browse/AMBARI-20250


Repository: ambari


Description
---

Added a CSS to ovveride the default css.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2824dc6 


Diff: https://reviews.apache.org/r/57188/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha