Review Request 57268: AMBARI-20287 - Filter in Customize Services Page doesn't bring up all properties that matches

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57268/
---

Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-20287
https://issues.apache.org/jira/browse/AMBARI-20287


Repository: ambari


Description
---

Take subSectionTab into consideration on show/hide


Diffs
-

  ambari-web/app/models/configs/theme/sub_section.js 7274569 
  ambari-web/app/models/configs/theme/sub_section_tab.js 2262882 
  ambari-web/app/views/common/configs/service_config_layout_tab_view.js 466a88d 
  ambari-web/test/models/configs/theme/sub_section_tab_test.js 0c3b98c 


Diff: https://reviews.apache.org/r/57268/diff/1/


Testing
---

Manully tested on live cluster. All unit tests passed.
  20560 passing (25s)
  153 pending


Thanks,

Richard Zang

Re: Review Request 57267: AMBARI-20247. Show full error while importing the workflow from encrypted file

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57267/#review167796
---


Ship it!




Ship It!

- belliraj hb


On March 3, 2017, 6:46 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57267/
> ---
> 
> (Updated March 3, 2017, 6:46 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20247
> https://issues.apache.org/jira/browse/AMBARI-20247
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Showing the full stack trace on the UI if there is an exception. And also 
> added the loggers.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  c4e5bbd 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
>  3355c85 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java
>  fd4ce80 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
>  e1a5808 
> 
> 
> Diff: https://reviews.apache.org/r/57267/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 57267: AMBARI-20247. Show full error while importing the workflow from encrypted file

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57267/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20247
https://issues.apache.org/jira/browse/AMBARI-20247


Repository: ambari


Description
---

Showing the full stack trace on the UI if there is an exception. And also added 
the loggers.


Diffs
-

  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
 c4e5bbd 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
 3355c85 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java
 fd4ce80 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
 e1a5808 


Diff: https://reviews.apache.org/r/57267/diff/1/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

[Sriharsha Chintalapani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167793
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On March 2, 2017, 10:52 a.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> ---
> 
> (Updated March 2, 2017, 10:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding dependency of kafka broker's listeners config to populate accurate 
> port for Atlas atlas.kafka.bootstrap.servers property.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  15cc73b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> a450d4d 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 2d7bcd3 
> 
> 
> Diff: https://reviews.apache.org/r/57139/diff/3/
> 
> 
> Testing
> ---
> 
> Verified dependency of : listeners propert for following cases: 
> 
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:
> 
> 2) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:
> 
> 3) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:,PLAINTEXT://localhost:
> 
> 4) Kerberos environment with listener's value as : 
> PLAINTEXT://localhost: :: in this case it will pickup the port given 
> for PLAINTEXT protocol only (as SASL port is not specified).
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 57265: null in heapmap page

[alice zhangxiaolu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57265/
---

(Updated 三月 3, 2017, 3:15 a.m.)


Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Yusaku Sako.


Bugs: AMBARI-20290
https://issues.apache.org/jira/browse/AMBARI-20290


Repository: ambari


Description
---

The value, which obtained from method "this.get('displayName')" with name 
attribute and is inside of method "drawWidget", is always null. Probably should 
use "this.get('displayName')" method to assign the obtained value to 
"this.get('content.widgetName')"


Diffs
-

  ambari-web/app/views/common/widget/heatmap_widget_view.js a7a919b 


Diff: https://reviews.apache.org/r/57265/diff/1/


Testing
---

done it


File Attachments (updated)


AMBARI-20290.patch
  
https://reviews.apache.org/media/uploaded/files/2017/03/03/6f22b669-2cd5-4cd7-ae66-693a736811b0__AMBARI-20290.patch


Thanks,

alice zhangxiaolu

Review Request 57265: null in heapmap page

[alice zhangxiaolu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57265/
---

Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Yusaku Sako.


Bugs: AMBARI-20290
https://issues.apache.org/jira/browse/AMBARI-20290


Repository: ambari


Description
---

The value, which obtained from method "this.get('displayName')" with name 
attribute and is inside of method "drawWidget", is always null. Probably should 
use "this.get('displayName')" method to assign the obtained value to 
"this.get('content.widgetName')"


Diffs
-

  ambari-web/app/views/common/widget/heatmap_widget_view.js a7a919b 


Diff: https://reviews.apache.org/r/57265/diff/1/


Testing
---

done it


Thanks,

alice zhangxiaolu

Review Request 57263: Fix values of ATS config params for HDP stack

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57263/
---

Review request for Ambari, Alejandro Fernandez and Swapan Shridhar.


Bugs: AMBARI-20284
https://issues.apache.org/jira/browse/AMBARI-20284


Repository: ambari


Description
---

Fix values of ATS config params for HDP stack


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
000e902 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 7c9fb67 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
9f3f42d 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
8b00b05 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 c2e185d 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
edc227a 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
da036cf 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 f232118 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
f0a4f05 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml
 70a2cbe 


Diff: https://reviews.apache.org/r/57263/diff/1/


Testing
---

Ran all unit tests and manually tested through EU.


Thanks,

Sumit Mohanty

Re: Review Request 57258: AMBARI-20279. HiveServerInteractive. Set value for "num_llap_nodes_for_llap_daemons" only if it exists in hive-interactive-site.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57258/#review167776
---


Ship it!




Ship It!

- Sumit Mohanty


On March 2, 2017, 10:32 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57258/
> ---
> 
> (Updated March 2, 2017, 10:32 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20279
> https://issues.apache.org/jira/browse/AMBARI-20279
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Given that "num_llap_nodes_for_llap_daemons" only exists in 2.6 HDP stack, 
> there can be a scenario  where "num_llap_nodes_for_llap_daemons" doesnt exist 
> in hive-interactive-site. This can happen if we upgrade from Ambari 2.4 (with 
> HDP 2.5) to Ambari 2.5.
> 
> **Fix:** Set this config in SA only if it present in hive-interactive-env.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
>  3629f30 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> a450d4d 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 2d7bcd3 
> 
> 
> Diff: https://reviews.apache.org/r/57258/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 57259: AMBARI-20285. Spark2 Thrift Server stopped due to incompletely uploaded tar.gz

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57259/
---

Review request for Ambari, Bikas Saha, Laszlo Puskas, Sandor Magyari, and 
Sebastian Toader.


Bugs: AMBARI-20285
https://issues.apache.org/jira/browse/AMBARI-20285


Repository: ambari


Description
---

Explicitly set permissions.


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
 12988c8 


Diff: https://reviews.apache.org/r/57259/diff/1/


Testing
---

Manual test: create cluster via blueprint, verify 
`/tmp/spark2/spark2-hdp-yarn-archive.tar.gz` is world readable, and that Spark2 
Thrift Server does not stop soon after start.

Existing unit tests:

```
$ mvn -am -pl ambari-server -DskipSurefireTests clean test
...
Total run:1192
Total errors:0
Total failures:0
OK
...
[INFO] BUILD SUCCESS
```


Thanks,

Attila Doroszlai

Re: Review Request 57258: AMBARI-20279. HiveServerInteractive. Set value for "num_llap_nodes_for_llap_daemons" only if it exists in hive-interactive-site.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57258/#review167756
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 2, 2017, 10:32 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57258/
> ---
> 
> (Updated March 2, 2017, 10:32 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20279
> https://issues.apache.org/jira/browse/AMBARI-20279
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Given that "num_llap_nodes_for_llap_daemons" only exists in 2.6 HDP stack, 
> there can be a scenario  where "num_llap_nodes_for_llap_daemons" doesnt exist 
> in hive-interactive-site. This can happen if we upgrade from Ambari 2.4 (with 
> HDP 2.5) to Ambari 2.5.
> 
> **Fix:** Set this config in SA only if it present in hive-interactive-env.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
>  3629f30 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> a450d4d 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 2d7bcd3 
> 
> 
> Diff: https://reviews.apache.org/r/57258/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 57258: AMBARI-20279. HiveServerInteractive. Set value for "num_llap_nodes_for_llap_daemons" only if it exists in hive-interactive-site.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57258/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-20279
https://issues.apache.org/jira/browse/AMBARI-20279


Repository: ambari


Description
---

Given that "num_llap_nodes_for_llap_daemons" only exists in 2.6 HDP stack, 
there can be a scenario  where "num_llap_nodes_for_llap_daemons" doesnt exist 
in hive-interactive-site. This can happen if we upgrade from Ambari 2.4 (with 
HDP 2.5) to Ambari 2.5.

**Fix:** Set this config in SA only if it present in hive-interactive-env.


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 3629f30 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
a450d4d 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3 


Diff: https://reviews.apache.org/r/57258/diff/1/


Testing
---


Thanks,

Swapan Shridhar

Re: Review Request 57251: AMBARI-20276 : Perf - AMS scale test for 3000 node cluster

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57251/#review167751
---


Ship it!




Ship It!

- Sid Wagle


On March 2, 2017, 7:38 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57251/
> ---
> 
> (Updated March 2, 2017, 7:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20276
> https://issues.apache.org/jira/browse/AMBARI-20276
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This Jira tracks effort of AMS load simulation testing and end goal is to 
> capture the tuning required to get AMS and Grafana working on a 3K node load 
> simulated metrics system.
> 
> INFERENCES
> AMS has performance bottlenecks due to the 5 min Host aggregation and 2min 
> cluster aggregator. The aggregators are not able to aggregate a huge amount 
> of data in a monolithic way in which they are implemented now. AMS with 
> whitelisted 500 metrics stays up for >1 day without Async processess getting 
> queued up.
> 
> PATCH CONTENTS
> Fixed issues in AMS load simulator.
> Added HIVE metrics to simulated data and Metrics list that is used for 
> calculating split points.
> Added App based whitelisting for AMS. 
> 
> Future work planned.
> Metric Schema optimization. 
> Host aggregator minute & Cluster Aggregator Second optimization.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/LoadRunner.java
>  203a88bc 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/MetricsLoadSimulator.java
>  09db9b5 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/data/AppID.java
>  a130171 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  ab1716a 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
>  0fe979e 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/AMS-HBASE.dat
>  63ac9f3 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/DATANODE.dat
>  e157630 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/FLUME_HANDLER.dat
>  bd5852f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HIVEMETASTORE.dat
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HIVESERVER2.dat
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HOST.dat
>  9295692 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/NAMENODE.dat
>  6e98a9c 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/NODEMANAGER.dat
>  239b3d4 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/RESOURCEMANAGER.dat
>  ec698db 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/jmetertest/AMSJMeterLoadTest.java
>  c34ac20 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
>  73c66fe 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/README
>  39e5365 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/ams-jmeter.properties
>  2c44d89 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/resources/test_data/metric_whitelist.dat
>  9f5e25c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/FLUME.txt
>  b3bfec3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HDFS.txt
>  84576e9 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HIVE.txt
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HOST.txt
>  4b759c6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/KAFKA.txt
>  1e2017c 
>   ambari-server/src/test/python/s

Re: Review Request 57250: NPE thrown if downscale is performed before all hosts registered with cluster.

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57250/#review167746
---


Ship it!




Ship It!

- Attila Doroszlai


On March 2, 2017, 8:31 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57250/
> ---
> 
> (Updated March 2, 2017, 8:31 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-20270
> https://issues.apache.org/jira/browse/AMBARI-20270
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It is normal to have TopologyHostRequest entities with host name being null. 
> That indicates that the Blueprint processing is waiting for a host to join 
> Ambari server that matches the host request.
> 
> When a downscale is performed we iterate through in-memory host request 
> object collections to remove the ones that correspond to the host being 
> removed from the cluster. This logic is not prepared for host request with 
> null host name thus throwing NPE when comparing against the host name being 
> removed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
>  0039e35 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
>  ef4f615 
> 
> 
> Diff: https://reviews.apache.org/r/57250/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing with Blueprint + downscale.
> 
> Unit tests:
> Results :
> 
> Tests run: 4936, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 57256: Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57256/
---

(Updated March 2, 2017, 9:43 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-20281
https://issues.apache.org/jira/browse/AMBARI-20281


Repository: ambari


Description
---

Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP 
from following bugs:

1. AMBARI-19827
2. AMBARI-19760
3. AMBARI-19686
4. AMBARI-19814
5. AMBARI-19971
6. AMBARI-19760


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 18938a3 


Diff: https://reviews.apache.org/r/57256/diff/1/


Testing
---


Thanks,

Swapan Shridhar

Re: Review Request 57256: Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57256/#review167742
---


Ship it!




Ship It!

- Sumit Mohanty


On March 2, 2017, 9:29 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57256/
> ---
> 
> (Updated March 2, 2017, 9:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19827
> https://issues.apache.org/jira/browse/AMBARI-19827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for 
> LLAP from following bugs:
> 
> 1. AMBARI-19827
> 2. AMBARI-19760
> 3. AMBARI-19686
> 4. AMBARI-19814
> 5. AMBARI-19971
> 6. AMBARI-19760
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
>  18938a3 
> 
> 
> Diff: https://reviews.apache.org/r/57256/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 57251: AMBARI-20276 : Perf - AMS scale test for 3000 node cluster

[Aravindan Vijayan]

> On March 2, 2017, 8:18 p.m., Sid Wagle wrote:
> > Can we consolidate the simualtor files and the ones used for split point 
> > calculation? The stack should be only source of truth.

Created AMBARI-20283 to track the effort for the consolidation.


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57251/#review167726
---


On March 2, 2017, 7:38 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57251/
> ---
> 
> (Updated March 2, 2017, 7:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20276
> https://issues.apache.org/jira/browse/AMBARI-20276
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This Jira tracks effort of AMS load simulation testing and end goal is to 
> capture the tuning required to get AMS and Grafana working on a 3K node load 
> simulated metrics system.
> 
> INFERENCES
> AMS has performance bottlenecks due to the 5 min Host aggregation and 2min 
> cluster aggregator. The aggregators are not able to aggregate a huge amount 
> of data in a monolithic way in which they are implemented now. AMS with 
> whitelisted 500 metrics stays up for >1 day without Async processess getting 
> queued up.
> 
> PATCH CONTENTS
> Fixed issues in AMS load simulator.
> Added HIVE metrics to simulated data and Metrics list that is used for 
> calculating split points.
> Added App based whitelisting for AMS. 
> 
> Future work planned.
> Metric Schema optimization. 
> Host aggregator minute & Cluster Aggregator Second optimization.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/LoadRunner.java
>  203a88bc 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/MetricsLoadSimulator.java
>  09db9b5 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/data/AppID.java
>  a130171 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  ab1716a 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
>  0fe979e 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/AMS-HBASE.dat
>  63ac9f3 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/DATANODE.dat
>  e157630 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/FLUME_HANDLER.dat
>  bd5852f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HIVEMETASTORE.dat
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HIVESERVER2.dat
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HOST.dat
>  9295692 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/NAMENODE.dat
>  6e98a9c 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/NODEMANAGER.dat
>  239b3d4 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/RESOURCEMANAGER.dat
>  ec698db 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/jmetertest/AMSJMeterLoadTest.java
>  c34ac20 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
>  73c66fe 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/README
>  39e5365 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/ams-jmeter.properties
>  2c44d89 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/resources/test_data/metric_whitelist.dat
>  9f5e25c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/FLUME.txt
>  b3bfec3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HDFS.txt
>  84576e9 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HIVE.txt
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI

Re: Review Request 57255: Pre-Upgrade check message for disabling Auto Start is difficult to understand and take action on

[Nate Cole]

> On March 2, 2017, 4:04 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
> > Lines 322 (patched)
> > 
> >
> > "Turn the toggle switch off to Disabled and hit Save"
> > 
> > Can we reword this to makie it clearer? Maybe, something like: 
> > 
> > "Disable the feature via the toggle switch and then select Save."

This is taken direct from the UI person that approved this message.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57255/#review167736
---


On March 2, 2017, 4:01 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57255/
> ---
> 
> (Updated March 2, 2017, 4:01 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20280
> https://issues.apache.org/jira/browse/AMBARI-20280
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change the description for the Auto Start Disabled check.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  2d1468f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java
>  c1e2ce7 
> 
> 
> Diff: https://reviews.apache.org/r/57255/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 57256: Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57256/
---

(Updated March 2, 2017, 9:29 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-19827
https://issues.apache.org/jira/browse/AMBARI-19827


Repository: ambari


Description (updated)
---

Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP 
from following bugs:

1. AMBARI-19827
2. AMBARI-19760
3. AMBARI-19686
4. AMBARI-19814
5. AMBARI-19971
6. AMBARI-19760


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 18938a3 


Diff: https://reviews.apache.org/r/57256/diff/1/


Testing
---


Thanks,

Swapan Shridhar

Re: Review Request 57256: Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57256/
---

(Updated March 2, 2017, 9:29 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated Summary.


Summary (updated)
-

Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP.


Bugs: AMBARI-19827
https://issues.apache.org/jira/browse/AMBARI-19827


Repository: ambari


Description
---

Porting changes made 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP. 
from following bugs:

1. AMBARI-19827
2. AMBARI-19760
3. AMBARI-19686
4. AMBARI-19814
5. AMBARI-19971
6. AMBARI-19760


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 18938a3 


Diff: https://reviews.apache.org/r/57256/diff/1/


Testing
---


Thanks,

Swapan Shridhar

Review Request 57256: ADDENDUM. AMBARI-19827. HiveServer2 Interactive won't start in clusters with less memory. (changes for service_advisor).

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57256/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-19827
https://issues.apache.org/jira/browse/AMBARI-19827


Repository: ambari


Description
---

Porting changes made 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP. 
from following bugs:

1. AMBARI-19827
2. AMBARI-19760
3. AMBARI-19686
4. AMBARI-19814
5. AMBARI-19971
6. AMBARI-19760


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 18938a3 


Diff: https://reviews.apache.org/r/57256/diff/1/


Testing
---


Thanks,

Swapan Shridhar

Re: Review Request 57255: Pre-Upgrade check message for disabling Auto Start is difficult to understand and take action on

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57255/#review167736
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
Lines 322 (patched)


"Turn the toggle switch off to Disabled and hit Save"

Can we reword this to makie it clearer? Maybe, something like: 

"Disable the feature via the toggle switch and then select Save."


- Jonathan Hurley


On March 2, 2017, 4:01 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57255/
> ---
> 
> (Updated March 2, 2017, 4:01 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20280
> https://issues.apache.org/jira/browse/AMBARI-20280
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change the description for the Auto Start Disabled check.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  2d1468f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java
>  c1e2ce7 
> 
> 
> Diff: https://reviews.apache.org/r/57255/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 57255: Pre-Upgrade check message for disabling Auto Start is difficult to understand and take action on

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57255/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-20280
https://issues.apache.org/jira/browse/AMBARI-20280


Repository: ambari


Description
---

Change the description for the Auto Start Disabled check.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 2d1468f 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java
 c1e2ce7 


Diff: https://reviews.apache.org/r/57255/diff/1/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 57250: NPE thrown if downscale is performed before all hosts registered with cluster.

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57250/#review167732
---


Ship it!




Ship It!

- Sandor Magyari


On March 2, 2017, 7:31 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57250/
> ---
> 
> (Updated March 2, 2017, 7:31 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-20270
> https://issues.apache.org/jira/browse/AMBARI-20270
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It is normal to have TopologyHostRequest entities with host name being null. 
> That indicates that the Blueprint processing is waiting for a host to join 
> Ambari server that matches the host request.
> 
> When a downscale is performed we iterate through in-memory host request 
> object collections to remove the ones that correspond to the host being 
> removed from the cluster. This logic is not prepared for host request with 
> null host name thus throwing NPE when comparing against the host name being 
> removed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
>  0039e35 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
>  ef4f615 
> 
> 
> Diff: https://reviews.apache.org/r/57250/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing with Blueprint + downscale.
> 
> Unit tests:
> Results :
> 
> Tests run: 4936, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 57253: Credential Store should be enabled by default on fresh installs

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57253/#review167727
---


Ship it!




Ship It!

- Sumit Mohanty


On March 2, 2017, 7:48 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57253/
> ---
> 
> (Updated March 2, 2017, 7:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20275
> https://issues.apache.org/jira/browse/AMBARI-20275
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Credential Store should be enabled by default on fresh installs (Hive, Oozie, 
> Logsearch)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 245a94d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
> 4230dd4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml 
> 75aa9d9 
> 
> 
> Diff: https://reviews.apache.org/r/57253/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing
> ===
> *Scenario - 1 FRESH INSTALL*
> 
> Deploy Ambari 2.5 - HDP 2.6
> 0. Add services Hive, Oozie, Logsearch
> 1. GET http://:8080/api/v1/clusters/cl1/services/HIVE  - Hive 
> Credential Store enabled on fresh install
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "true",
> "credential_store_supported": "true",
> ….
> }
> 2. GET http://:8080/api/v1/clusters/cl1/services/OOZIE - Oozie 
> Credential Store enabled on fresh install
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "true",
> "credential_store_supported": "true",
> …
> }
> 3. GET http://:8080/api/v1/clusters/cl1/services/LOGSEARCH - Logsearch 
> Credential Store enabled on fresh install
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/LOGSEARCH",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "true",
> "credential_store_supported": "true",
> …
> }
> 4. User is able to disable Hive and Oozie CS
> PUT 
> http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(HIVE)
> {"ServiceInfo": {"credential_store_enabled": "false"}}
> 
> GET http://:8080/api/v1/clusters/cl1/services/HIVE
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "false",
> "credential_store_supported": "true",
> …
> }
> 
> PUT 
> http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(OOZIE)
> {"ServiceInfo": {"credential_store_enabled": "false"}}
> 
> GET http://:8080/api/v1/clusters/cl1/services/OOZIE
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "false",
> "credential_store_supported": "true",
> ….
> }
> 
> 5. User is not able to disable Logsearch
> PUT 
> http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(LOGSEARCH)
> {"ServiceInfo": {"credential_store_enabled": "false"}}
> Response:
> {
>   "status" : 400,
>   "message" : "java.lang.IllegalArgumentException: Invalid arguments, cannot 
> disable credential store as it is required by the service. Service=LOGSEARCH"
> }
> 
> *Scenario - 1 AMBARI UPGRADE*
> 1. Ambari upgrade 2.4->2.5 (HDP 2.5.0)
>Hive, Oozie, Logsearch - disabled
> 2. User is able to enable Credential Store for Hive, Oozie, Logsearch post 
> upgrade
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57251: AMBARI-20276 : Perf - AMS scale test for 3000 node cluster

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57251/#review167726
---



Can we consolidate the simualtor files and the ones used for split point 
calculation? The stack should be only source of truth.

- Sid Wagle


On March 2, 2017, 7:38 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57251/
> ---
> 
> (Updated March 2, 2017, 7:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20276
> https://issues.apache.org/jira/browse/AMBARI-20276
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This Jira tracks effort of AMS load simulation testing and end goal is to 
> capture the tuning required to get AMS and Grafana working on a 3K node load 
> simulated metrics system.
> 
> INFERENCES
> AMS has performance bottlenecks due to the 5 min Host aggregation and 2min 
> cluster aggregator. The aggregators are not able to aggregate a huge amount 
> of data in a monolithic way in which they are implemented now. AMS with 
> whitelisted 500 metrics stays up for >1 day without Async processess getting 
> queued up.
> 
> PATCH CONTENTS
> Fixed issues in AMS load simulator.
> Added HIVE metrics to simulated data and Metrics list that is used for 
> calculating split points.
> Added App based whitelisting for AMS. 
> 
> Future work planned.
> Metric Schema optimization. 
> Host aggregator minute & Cluster Aggregator Second optimization.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/LoadRunner.java
>  203a88bc 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/MetricsLoadSimulator.java
>  09db9b5 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/data/AppID.java
>  a130171 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  ab1716a 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
>  0fe979e 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/AMS-HBASE.dat
>  63ac9f3 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/DATANODE.dat
>  e157630 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/FLUME_HANDLER.dat
>  bd5852f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HIVEMETASTORE.dat
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HIVESERVER2.dat
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HOST.dat
>  9295692 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/NAMENODE.dat
>  6e98a9c 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/NODEMANAGER.dat
>  239b3d4 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/RESOURCEMANAGER.dat
>  ec698db 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/jmetertest/AMSJMeterLoadTest.java
>  c34ac20 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
>  73c66fe 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/README
>  39e5365 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/ams-jmeter.properties
>  2c44d89 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/resources/test_data/metric_whitelist.dat
>  9f5e25c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/FLUME.txt
>  b3bfec3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HDFS.txt
>  84576e9 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HIVE.txt
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HOST.txt
>  4b759c6 
>   
> ambari-server/src/main/resources/common-services/

Re: Review Request 57250: NPE thrown if downscale is performed before all hosts registered with cluster.

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57250/#review167723
---


Ship it!




Ship It!

- Robert Nettleton


On March 2, 2017, 7:31 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57250/
> ---
> 
> (Updated March 2, 2017, 7:31 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-20270
> https://issues.apache.org/jira/browse/AMBARI-20270
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It is normal to have TopologyHostRequest entities with host name being null. 
> That indicates that the Blueprint processing is waiting for a host to join 
> Ambari server that matches the host request.
> 
> When a downscale is performed we iterate through in-memory host request 
> object collections to remove the ones that correspond to the host being 
> removed from the cluster. This logic is not prepared for host request with 
> null host name thus throwing NPE when comparing against the host name being 
> removed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
>  0039e35 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
>  ef4f615 
> 
> 
> Diff: https://reviews.apache.org/r/57250/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing with Blueprint + downscale.
> 
> Unit tests:
> Results :
> 
> Tests run: 4936, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 57253: Credential Store should be enabled by default on fresh installs

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57253/
---

(Updated March 2, 2017, 7:48 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-20275
https://issues.apache.org/jira/browse/AMBARI-20275


Repository: ambari


Description
---

Credential Store should be enabled by default on fresh installs (Hive, Oozie, 
Logsearch)


Diffs
-

  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
245a94d 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
4230dd4 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml 
75aa9d9 


Diff: https://reviews.apache.org/r/57253/diff/1/


Testing (updated)
---

Manual Testing
===
*Scenario - 1 FRESH INSTALL*

Deploy Ambari 2.5 - HDP 2.6
0. Add services Hive, Oozie, Logsearch
1. GET http://:8080/api/v1/clusters/cl1/services/HIVE  - Hive Credential 
Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
….
}
2. GET http://:8080/api/v1/clusters/cl1/services/OOZIE - Oozie Credential 
Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
3. GET http://:8080/api/v1/clusters/cl1/services/LOGSEARCH - Logsearch 
Credential Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/LOGSEARCH",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
4. User is able to disable Hive and Oozie CS
PUT 
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(HIVE)
{"ServiceInfo": {"credential_store_enabled": "false"}}

GET http://:8080/api/v1/clusters/cl1/services/HIVE
{
"href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
…
}

PUT 
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(OOZIE)
{"ServiceInfo": {"credential_store_enabled": "false"}}

GET http://:8080/api/v1/clusters/cl1/services/OOZIE
{
"href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
….
}

5. User is not able to disable Logsearch
PUT 
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(LOGSEARCH)
{"ServiceInfo": {"credential_store_enabled": "false"}}
Response:
{
  "status" : 400,
  "message" : "java.lang.IllegalArgumentException: Invalid arguments, cannot 
disable credential store as it is required by the service. Service=LOGSEARCH"
}

*Scenario - 1 AMBARI UPGRADE*
1. Ambari upgrade 2.4->2.5 (HDP 2.5.0)
   Hive, Oozie, Logsearch - disabled
2. User is able to enable Credential Store for Hive, Oozie, Logsearch post 
upgrade


Thanks,

Madhuvanthi Radhakrishnan

Review Request 57253: Credential Store should be enabled by default on fresh installs

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57253/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-20275
https://issues.apache.org/jira/browse/AMBARI-20275


Repository: ambari


Description
---

Credential Store should be enabled by default on fresh installs (Hive, Oozie, 
Logsearch)


Diffs
-

  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
245a94d 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
4230dd4 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml 
75aa9d9 


Diff: https://reviews.apache.org/r/57253/diff/1/


Testing
---

Manual Testing
===
*Scenario - 1 FRESH INSTALL*

Deploy Ambari 2.5 - HDP 2.6
0. Add services Hive, Oozie, Logsearch
1. GET http://:8080/api/v1/clusters/cl1/services/HIVE  - Hive Credential 
Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
….
}
2. GET http://:8080/api/v1/clusters/cl1/services/OOZIE - Oozie Credential 
Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
3. GET http://:8080/api/v1/clusters/cl1/services/LOGSEARCH - Logsearch 
Credential Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/LOGSEARCH",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
4. User is able to disable Hive and Oozie CS
PUT 
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(HIVE)
{"ServiceInfo": {"credential_store_enabled": "false"}}

GET http://:8080/api/v1/clusters/cl1/services/HIVE
{
"href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
…
}

PUT 
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(OOZIE)
{"ServiceInfo": {"credential_store_enabled": "false"}}

GET http://:8080/api/v1/clusters/cl1/services/OOZIE
{
"href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
….
}

5. User is not able to disable Logsearch
PUT 
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(LOGSEARCH)
{"ServiceInfo": {"credential_store_enabled": "false"}}
Response:
{
  "status" : 400,
  "message" : "java.lang.IllegalArgumentException: Invalid arguments, cannot 
disable credential store as it is required by the service. Service=LOGSEARCH"
}
6. Ambari upgrade 2.4->2.5 (HDP 2.5.0)
   Hive, Oozie, Logsearch - disabled
   User is able to enable Credential Store for Hive, Oozie, Logsearch post 
upgrade


Thanks,

Madhuvanthi Radhakrishnan

Review Request 57251: AMBARI-20276 : Perf - AMS scale test for 3000 node cluster

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57251/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-20276
https://issues.apache.org/jira/browse/AMBARI-20276


Repository: ambari


Description
---

This Jira tracks effort of AMS load simulation testing and end goal is to 
capture the tuning required to get AMS and Grafana working on a 3K node load 
simulated metrics system.

INFERENCES
AMS has performance bottlenecks due to the 5 min Host aggregation and 2min 
cluster aggregator. The aggregators are not able to aggregate a huge amount of 
data in a monolithic way in which they are implemented now. AMS with 
whitelisted 500 metrics stays up for >1 day without Async processess getting 
queued up.

PATCH CONTENTS
Fixed issues in AMS load simulator.
Added HIVE metrics to simulated data and Metrics list that is used for 
calculating split points.
Added App based whitelisting for AMS. 

Future work planned.
Metric Schema optimization. 
Host aggregator minute & Cluster Aggregator Second optimization.


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/LoadRunner.java
 203a88bc 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/MetricsLoadSimulator.java
 09db9b5 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/data/AppID.java
 a130171 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 ab1716a 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
 0fe979e 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/AMS-HBASE.dat
 63ac9f3 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/DATANODE.dat
 e157630 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/FLUME_HANDLER.dat
 bd5852f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HIVEMETASTORE.dat
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HIVESERVER2.dat
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/HOST.dat
 9295692 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/NAMENODE.dat
 6e98a9c 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/NODEMANAGER.dat
 239b3d4 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/resources/metrics_def/RESOURCEMANAGER.dat
 ec698db 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/jmetertest/jmetertest/AMSJMeterLoadTest.java
 c34ac20 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
 73c66fe 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/README
 39e5365 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/resources/loadsimulator/ams-jmeter.properties
 2c44d89 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/resources/test_data/metric_whitelist.dat
 9f5e25c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/FLUME.txt
 b3bfec3 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HDFS.txt
 84576e9 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HIVE.txt
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/HOST.txt
 4b759c6 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/service-metrics/KAFKA.txt
 1e2017c 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
157a582 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py fa97604 


Diff: https://reviews.apache.org/r/57251/diff/1/


Testing
---

Load simulation manually done.
App whitelisting unit tested.


Thanks,

Aravindan Vijayan

Re: Review Request 57250: NPE thrown if downscale is performed before all hosts registered with cluster.

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57250/#review167720
---


Ship it!




Ship It!

- Robert Levas


On March 2, 2017, 2:31 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57250/
> ---
> 
> (Updated March 2, 2017, 2:31 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-20270
> https://issues.apache.org/jira/browse/AMBARI-20270
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It is normal to have TopologyHostRequest entities with host name being null. 
> That indicates that the Blueprint processing is waiting for a host to join 
> Ambari server that matches the host request.
> 
> When a downscale is performed we iterate through in-memory host request 
> object collections to remove the ones that correspond to the host being 
> removed from the cluster. This logic is not prepared for host request with 
> null host name thus throwing NPE when comparing against the host name being 
> removed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
>  0039e35 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
>  ef4f615 
> 
> 
> Diff: https://reviews.apache.org/r/57250/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing with Blueprint + downscale.
> 
> Unit tests:
> Results :
> 
> Tests run: 4936, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Review Request 57250: NPE thrown if downscale is performed before all hosts registered with cluster.

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57250/
---

Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, and 
Sandor Magyari.


Bugs: AMBARI-20270
https://issues.apache.org/jira/browse/AMBARI-20270


Repository: ambari


Description
---

It is normal to have TopologyHostRequest entities with host name being null. 
That indicates that the Blueprint processing is waiting for a host to join 
Ambari server that matches the host request.

When a downscale is performed we iterate through in-memory host request object 
collections to remove the ones that correspond to the host being removed from 
the cluster. This logic is not prepared for host request with null host name 
thus throwing NPE when comparing against the host name being removed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
 0039e35 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
 ef4f615 


Diff: https://reviews.apache.org/r/57250/diff/1/


Testing
---

Manual testing with Blueprint + downscale.

Unit tests:
Results :

Tests run: 4936, Failures: 0, Errors: 0, Skipped: 39


Thanks,

Sebastian Toader

Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167711
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 2, 2017, 10:52 a.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> ---
> 
> (Updated March 2, 2017, 10:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding dependency of kafka broker's listeners config to populate accurate 
> port for Atlas atlas.kafka.bootstrap.servers property.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  15cc73b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> a450d4d 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 2d7bcd3 
> 
> 
> Diff: https://reviews.apache.org/r/57139/diff/3/
> 
> 
> Testing
> ---
> 
> Verified dependency of : listeners propert for following cases: 
> 
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:
> 
> 2) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:
> 
> 3) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:,PLAINTEXT://localhost:
> 
> 4) Kerberos environment with listener's value as : 
> PLAINTEXT://localhost: :: in this case it will pickup the port given 
> for PLAINTEXT protocol only (as SASL port is not specified).
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 57147: Added support for processing custom command script timeout

[Alejandro Fernandez]

> On March 1, 2017, 7:07 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml
> > Lines 64 (patched)
> > 
> >
> > I'm still opposed to this patch fundamentally because no command should 
> > be able to run for 2 hours. That will block other commands on the client 
> > that decided to run it, which is extremely problematic.
> > 
> > Please make this call return right away and check the existence of the 
> > /system/balancer.id file
> 
> Laszlo Puskas wrote:
> OK, i'll drop this patch. The rebalance operation will return imediately 
> after the command is issued; in case nother balancer is running (the above 
> file exists on hdfs). there will be no feedback about the success/failure of 
> the command.

We would need the notion of background commands for this. In other words, a 
request command that doesn't block execution of other requests, or that can 
poll for status.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57147/#review167547
---


On Feb. 28, 2017, 6:01 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57147/
> ---
> 
> (Updated Feb. 28, 2017, 6:01 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20175
> https://issues.apache.org/jira/browse/AMBARI-20175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS rebalance operation can last for a long time (hours/days) thus when 
> triggered from the UI the command may be timed out by the Ambari server.
> This behavior may confuse users, making them to trigger the rebalancer again 
> which will fail with "another balancer is running"  error.
> 
> The patch provides support for setting a reasonably long timeout for the 
> rebalance custo action so that Ambari server doesnt time out the command.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  867ebff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> fd7f2f6 
> 
> 
> Diff: https://reviews.apache.org/r/57147/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests OK.
> Manually tested on local dev-env.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57248: Visual explain is not routing to visual explain tab

[Abhishek Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57248/#review167699
---


Ship it!




Ship It!

- Abhishek Kumar


On March 2, 2017, 6:08 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57248/
> ---
> 
> (Updated March 2, 2017, 6:08 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20274
> https://issues.apache.org/jira/browse/AMBARI-20274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> changed the logic to re-direct to visual explain route if 'visual explain' 
> button is clicked.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> cf51ff7 
> 
> 
> Diff: https://reviews.apache.org/r/57248/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 57248: Visual explain is not routing to visual explain tab

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57248/#review167697
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 2, 2017, 6:08 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57248/
> ---
> 
> (Updated March 2, 2017, 6:08 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20274
> https://issues.apache.org/jira/browse/AMBARI-20274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> changed the logic to re-direct to visual explain route if 'visual explain' 
> button is clicked.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> cf51ff7 
> 
> 
> Diff: https://reviews.apache.org/r/57248/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 57248: Visual explain is not routing to visual explain tab

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57248/
---

Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20274
https://issues.apache.org/jira/browse/AMBARI-20274


Repository: ambari


Description
---

changed the logic to re-direct to visual explain route if 'visual explain' 
button is clicked.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
cf51ff7 


Diff: https://reviews.apache.org/r/57248/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 57247: Create Widget: Metrics select is empty after refresh

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57247/#review167693
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Март 2, 2017, 5:49 п.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57247/
> ---
> 
> (Updated Март 2, 2017, 5:49 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20273
> https://issues.apache.org/jira/browse/AMBARI-20273
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> Open Create Widget wizard
> Go to second step
> Refresh page
> Try to select metrics
> Actual result:
> Metrics select is empty
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/service/widgets/create/expression_view.js c4a1a3e 
> 
> 
> Diff: https://reviews.apache.org/r/57247/diff/1/
> 
> 
> Testing
> ---
> 
> 20574 passing (34s)
> 153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Review Request 57247: Create Widget: Metrics select is empty after refresh

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57247/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20273
https://issues.apache.org/jira/browse/AMBARI-20273


Repository: ambari


Description
---

Steps to reproduce:
Open Create Widget wizard
Go to second step
Refresh page
Try to select metrics
Actual result:
Metrics select is empty


Diffs
-

  ambari-web/app/views/main/service/widgets/create/expression_view.js c4a1a3e 


Diff: https://reviews.apache.org/r/57247/diff/1/


Testing
---

20574 passing (34s)
153 pending


Thanks,

Andrii Tkach

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

[Anita Jebaraj]

> On March 1, 2017, 4:28 p.m., Di Li wrote:
> > ambari-server/conf/unix/ambari-blacklist.properties
> > Lines 1 (patched)
> > 
> >
> > I am not sure Ambari should ship with empty files.
> > 
> > I would suggest you to add an optional property to ambari.property that 
> > points to the blacklist properties file.
> > 
> > Let's say we call it property.mask.file, its value should be the 
> > absolute path of a properties file.
> > 
> > Logic can be:
> > If "property.mask.file" does not exist in ambari.properties - no action
> > If "property.mask.file" does not point to an existing property file - 
> > print some log but no further action
> > Else - mask
> > 
> > Write a wiki on Apache Ambari wiki on how to use this optional property.

I have updated the patch as per your suggestions..Please review the new changes


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review167286
---


On March 2, 2017, 1:05 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 2, 2017, 1:05 a.m.)
> 
> 
> Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  eaecf35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  51114f8 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/3/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57245: Call to fetch Quick Links host fails

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57245/#review167689
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Март 2, 2017, 4:30 п.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57245/
> ---
> 
> (Updated Март 2, 2017, 4:30 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20271
> https://issues.apache.org/jira/browse/AMBARI-20271
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> Go to Hosts page
> Switch page of hosts
> Go to Dashboard page
> Actual Result:
> Call to 
> api/v1/clusters/perf/hosts?Hosts/host_name.in()&fields=Hosts/public_host_name&minimal_response=true
>  fails with error:
> {
>   "status" : 400,
>   "message" : "Unable to compile query predicate: IN operator is missing a 
> required right operand."
> }
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mappers/hosts_mapper.js b64bd8d 
>   ambari-web/app/views/common/quick_view_link_view.js bb21b9f 
> 
> 
> Diff: https://reviews.apache.org/r/57245/diff/1/
> 
> 
> Testing
> ---
> 
> 20574 passing (32s)
> 153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Review Request 57245: Call to fetch Quick Links host fails

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57245/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20271
https://issues.apache.org/jira/browse/AMBARI-20271


Repository: ambari


Description
---

Steps to reproduce:
Go to Hosts page
Switch page of hosts
Go to Dashboard page
Actual Result:
Call to 
api/v1/clusters/perf/hosts?Hosts/host_name.in()&fields=Hosts/public_host_name&minimal_response=true
 fails with error:
{
  "status" : 400,
  "message" : "Unable to compile query predicate: IN operator is missing a 
required right operand."
}


Diffs
-

  ambari-web/app/mappers/hosts_mapper.js b64bd8d 
  ambari-web/app/views/common/quick_view_link_view.js bb21b9f 


Diff: https://reviews.apache.org/r/57245/diff/1/


Testing
---

20574 passing (32s)
153 pending


Thanks,

Andrii Tkach

Re: Review Request 57204: After regenerate keytabs post Ambari upgrade yarn.nodemanager.linux-container-executor.cgroups.mount-path property got added with blank value

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57204/#review167688
---


Ship it!




Ship It!

- Robert Levas


On March 2, 2017, 7:53 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57204/
> ---
> 
> (Updated March 2, 2017, 7:53 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20237
> https://issues.apache.org/jira/browse/AMBARI-20237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR
> 1. Deployed cluster with Ambari version: 2.4.1 and HDP version: 2.5.0(secure 
> cluster)
> 2. Upgrade Ambari to 2.5
> 3. Regenerate keytabs for missing hosts and let it complete
> 4. Go to YARN - configs
> Result
> Observed that yarn.nodemanager.linux-container-executor.cgroups.mount-path 
> got added as a property with blank value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  d6ff241 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  39d8785 
>   
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_5_infra_solr.json
>  172ad05 
> 
> 
> Diff: https://reviews.apache.org/r/57204/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [1.412s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.063s]
> [INFO] Ambari Web  SUCCESS [2:43.041s]
> [INFO] Ambari Views .. SUCCESS [2.060s]
> [INFO] Ambari Admin View . SUCCESS [53.373s]
> [INFO] utility ... SUCCESS [0.964s]
> [INFO] ambari-metrics  SUCCESS [0.232s]
> [INFO] Ambari Metrics Common . SUCCESS [6.656s]
> [INFO] Ambari Server . SUCCESS 
> [26:02.995s]
> [INFO] Ambari Agent .. SUCCESS [1:23.748s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 31:15.402s
> [INFO] Finished at: Wed Mar 01 17:58:13 EET 2017
> [INFO] Final Memory: 242M/2931M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57215: Startup Annotation Scanning Takes Too Long

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57215/
---

(Updated March 2, 2017, 10:48 a.m.)


Review request for Ambari, Nate Cole and Robert Levas.


Bugs: AMBARI-20262
https://issues.apache.org/jira/browse/AMBARI-20262


Repository: ambari


Description
---

Currently, Ambari uses Spring's {{ClassPathScanningCandidateComponentProvider}} 
along with an {{AnnotationTypeFilter}} to find classes annotated in our 
classpath:

```
  ClassPathScanningCandidateComponentProvider scanner =
  new ClassPathScanningCandidateComponentProvider(false);

  // match only singletons that are eager listeners
  for (Class cls : classes) {
scanner.addIncludeFilter(new AnnotationTypeFilter(cls));
  }

  beanDefinitions = scanner.findCandidateComponents(AMBARI_PACKAGE);
```

This takes roughly 19 seconds on normal deployments. We can reduce this time to 
roughly 8 seconds by switching over to Google's {{ClassPath}} via our internal 
{{ClasspathScannerUtils}}


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java
 d8b8466 
  
ambari-server/src/main/java/org/apache/ambari/server/cleanup/ClasspathScannerUtils.java
 01487f0 
  
ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupModule.java 
d2a7583 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 8646e51 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
 40c7e50 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 4d609b4 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetResourceProviderTest.java
 a4f6469 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
 3090108 


Diff: https://reviews.apache.org/r/57215/diff/2/

Changes: https://reviews.apache.org/r/57215/diff/1-2/


Testing (updated)
---

mvn clean test


Thanks,

Jonathan Hurley

Re: Review Request 57215: Startup Annotation Scanning Takes Too Long

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57215/#review167677
---


Ship it!




Ship It!

- Nate Cole


On March 1, 2017, 3:51 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57215/
> ---
> 
> (Updated March 1, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-20262
> https://issues.apache.org/jira/browse/AMBARI-20262
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, Ambari uses Spring's 
> {{ClassPathScanningCandidateComponentProvider}} along with an 
> {{AnnotationTypeFilter}} to find classes annotated in our classpath:
> 
> ```
>   ClassPathScanningCandidateComponentProvider scanner =
>   new ClassPathScanningCandidateComponentProvider(false);
> 
>   // match only singletons that are eager listeners
>   for (Class cls : classes) {
> scanner.addIncludeFilter(new AnnotationTypeFilter(cls));
>   }
> 
>   beanDefinitions = scanner.findCandidateComponents(AMBARI_PACKAGE);
> ```
> 
> This takes roughly 19 seconds on normal deployments. We can reduce this time 
> to roughly 8 seconds by switching over to Google's {{ClassPath}} via our 
> internal {{ClasspathScannerUtils}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java
>  d8b8466 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/ClasspathScannerUtils.java
>  01487f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupModule.java
>  d2a7583 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  8646e51 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
>  3090108 
> 
> 
> Diff: https://reviews.apache.org/r/57215/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 57238: Ambari shouldn't remove secure ACLs from /zkdtsm_

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57238/#review167675
---


Ship it!




Ship It!

- Robert Levas


On March 2, 2017, 7:39 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57238/
> ---
> 
> (Updated March 2, 2017, 7:39 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Robert Levas, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20267
> https://issues.apache.org/jira/browse/AMBARI-20267
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This node is used by LLAP to store secret keys and tokens, and used only in 
> secure mode. If the ACL is changed to unsecure, keys/tokens could be exposed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  a8a8282 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  ba610a0 
> 
> 
> Diff: https://reviews.apache.org/r/57238/diff/1/
> 
> 
> Testing
> ---
> 
> - created a cluster with hive
> - turned on kerberos
> - turned off kerberos
> - checked that ambari didn't touch zkdstm_ znodes
> 
> existing tests ran successfully.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57240: AMBARI-20268.WFM generates duplicate kill nodes in XML if decision paths have multiple transition to kill node.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57240/#review167674
---


Ship it!




Ship It!

- Gaurav Nagar


On March 2, 2017, 10:22 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57240/
> ---
> 
> (Updated March 2, 2017, 10:22 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20268
> https://issues.apache.org/jira/browse/AMBARI-20268
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by storing nodes by name instead of id in the visited nodes array
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js
>  eb8534b 
> 
> 
> Diff: https://reviews.apache.org/r/57240/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 57237: AMBARI-20266.Duplicate node error is shown if kill node transition exists from decision node in WFM

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57237/#review167673
---


Ship it!




Ship It!

- Gaurav Nagar


On March 2, 2017, 9:11 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57237/
> ---
> 
> (Updated March 2, 2017, 9:11 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20266
> https://issues.apache.org/jira/browse/AMBARI-20266
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added to check to avoid kill tranisitions while validating
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js
>  7336d6e 
> 
> 
> Diff: https://reviews.apache.org/r/57237/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 57238: Ambari shouldn't remove secure ACLs from /zkdtsm_

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57238/#review167672
---


Ship it!




Ship It!

- Sebastian Toader


On March 2, 2017, 1:39 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57238/
> ---
> 
> (Updated March 2, 2017, 1:39 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Robert Levas, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20267
> https://issues.apache.org/jira/browse/AMBARI-20267
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This node is used by LLAP to store secret keys and tokens, and used only in 
> secure mode. If the ACL is changed to unsecure, keys/tokens could be exposed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  a8a8282 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  ba610a0 
> 
> 
> Diff: https://reviews.apache.org/r/57238/diff/1/
> 
> 
> Testing
> ---
> 
> - created a cluster with hive
> - turned on kerberos
> - turned off kerberos
> - checked that ambari didn't touch zkdstm_ znodes
> 
> existing tests ran successfully.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57204: After regenerate keytabs post Ambari upgrade yarn.nodemanager.linux-container-executor.cgroups.mount-path property got added with blank value

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57204/#review167671
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 2, 2017, 2:53 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57204/
> ---
> 
> (Updated March 2, 2017, 2:53 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20237
> https://issues.apache.org/jira/browse/AMBARI-20237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR
> 1. Deployed cluster with Ambari version: 2.4.1 and HDP version: 2.5.0(secure 
> cluster)
> 2. Upgrade Ambari to 2.5
> 3. Regenerate keytabs for missing hosts and let it complete
> 4. Go to YARN - configs
> Result
> Observed that yarn.nodemanager.linux-container-executor.cgroups.mount-path 
> got added as a property with blank value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  d6ff241 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  39d8785 
>   
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_5_infra_solr.json
>  172ad05 
> 
> 
> Diff: https://reviews.apache.org/r/57204/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [1.412s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.063s]
> [INFO] Ambari Web  SUCCESS [2:43.041s]
> [INFO] Ambari Views .. SUCCESS [2.060s]
> [INFO] Ambari Admin View . SUCCESS [53.373s]
> [INFO] utility ... SUCCESS [0.964s]
> [INFO] ambari-metrics  SUCCESS [0.232s]
> [INFO] Ambari Metrics Common . SUCCESS [6.656s]
> [INFO] Ambari Server . SUCCESS 
> [26:02.995s]
> [INFO] Ambari Agent .. SUCCESS [1:23.748s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 31:15.402s
> [INFO] Finished at: Wed Mar 01 17:58:13 EET 2017
> [INFO] Final Memory: 242M/2931M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57204: After regenerate keytabs post Ambari upgrade yarn.nodemanager.linux-container-executor.cgroups.mount-path property got added with blank value

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57204/#review167670
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Березень 2, 2017, 12:53 після полудня, Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57204/
> ---
> 
> (Updated Березень 2, 2017, 12:53 після полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20237
> https://issues.apache.org/jira/browse/AMBARI-20237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR
> 1. Deployed cluster with Ambari version: 2.4.1 and HDP version: 2.5.0(secure 
> cluster)
> 2. Upgrade Ambari to 2.5
> 3. Regenerate keytabs for missing hosts and let it complete
> 4. Go to YARN - configs
> Result
> Observed that yarn.nodemanager.linux-container-executor.cgroups.mount-path 
> got added as a property with blank value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  d6ff241 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  39d8785 
>   
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_5_infra_solr.json
>  172ad05 
> 
> 
> Diff: https://reviews.apache.org/r/57204/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [1.412s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.063s]
> [INFO] Ambari Web  SUCCESS [2:43.041s]
> [INFO] Ambari Views .. SUCCESS [2.060s]
> [INFO] Ambari Admin View . SUCCESS [53.373s]
> [INFO] utility ... SUCCESS [0.964s]
> [INFO] ambari-metrics  SUCCESS [0.232s]
> [INFO] Ambari Metrics Common . SUCCESS [6.656s]
> [INFO] Ambari Server . SUCCESS 
> [26:02.995s]
> [INFO] Ambari Agent .. SUCCESS [1:23.748s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 31:15.402s
> [INFO] Finished at: Wed Mar 01 17:58:13 EET 2017
> [INFO] Final Memory: 242M/2931M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57204: After regenerate keytabs post Ambari upgrade yarn.nodemanager.linux-container-executor.cgroups.mount-path property got added with blank value

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57204/
---

(Updated March 2, 2017, 12:53 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Changes
---

simplified code and just remove property from kerberos descriptor if exists


Bugs: AMBARI-20237
https://issues.apache.org/jira/browse/AMBARI-20237


Repository: ambari


Description
---

STR
1. Deployed cluster with Ambari version: 2.4.1 and HDP version: 2.5.0(secure 
cluster)
2. Upgrade Ambari to 2.5
3. Regenerate keytabs for missing hosts and let it complete
4. Go to YARN - configs
Result
Observed that yarn.nodemanager.linux-container-executor.cgroups.mount-path got 
added as a property with blank value


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 d6ff241 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 39d8785 
  
ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_5_infra_solr.json
 172ad05 


Diff: https://reviews.apache.org/r/57204/diff/2/

Changes: https://reviews.apache.org/r/57204/diff/1-2/


Testing
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [1.412s]
[INFO] Apache Ambari Project POM . SUCCESS [0.063s]
[INFO] Ambari Web  SUCCESS [2:43.041s]
[INFO] Ambari Views .. SUCCESS [2.060s]
[INFO] Ambari Admin View . SUCCESS [53.373s]
[INFO] utility ... SUCCESS [0.964s]
[INFO] ambari-metrics  SUCCESS [0.232s]
[INFO] Ambari Metrics Common . SUCCESS [6.656s]
[INFO] Ambari Server . SUCCESS [26:02.995s]
[INFO] Ambari Agent .. SUCCESS [1:23.748s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 31:15.402s
[INFO] Finished at: Wed Mar 01 17:58:13 EET 2017
[INFO] Final Memory: 242M/2931M
[INFO] 


Thanks,

Eugene Chekanskiy

Review Request 57238: Ambari shouldn't remove secure ACLs from /zkdtsm_

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57238/
---

Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Robert Levas, and 
Sebastian Toader.


Bugs: AMBARI-20267
https://issues.apache.org/jira/browse/AMBARI-20267


Repository: ambari


Description
---

This node is used by LLAP to store secret keys and tokens, and used only in 
secure mode. If the ACL is changed to unsecure, keys/tokens could be exposed.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
 a8a8282 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 ba610a0 


Diff: https://reviews.apache.org/r/57238/diff/1/


Testing
---

- created a cluster with hive
- turned on kerberos
- turned off kerberos
- checked that ambari didn't touch zkdstm_ znodes

existing tests ran successfully.


Thanks,

Attila Magyar

Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

[Vishal Suvagia via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/
---

(Updated March 2, 2017, 10:52 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.


Changes
---

Updating code to remove leading and trailing whitespaces, adding testcases to 
cover sasl scenario.


Bugs: AMBARI-20208
https://issues.apache.org/jira/browse/AMBARI-20208


Repository: ambari


Description
---

Adding dependency of kafka broker's listeners config to populate accurate port 
for Atlas atlas.kafka.bootstrap.servers property.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
 15cc73b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
a450d4d 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3 


Diff: https://reviews.apache.org/r/57139/diff/3/

Changes: https://reviews.apache.org/r/57139/diff/2-3/


Testing
---

Verified dependency of : listeners propert for following cases: 

1) Simple environment with listener's value as : PLAINTEXT://localhost:

2) Kerberos environment with listener's value as : 
PLAINTEXTSASL://localhost:

3) Kerberos environment with listener's value as : 
PLAINTEXTSASL://localhost:,PLAINTEXT://localhost:

4) Kerberos environment with listener's value as : PLAINTEXT://localhost: 
:: in this case it will pickup the port given for PLAINTEXT protocol only (as 
SASL port is not specified).


Thanks,

Vishal Suvagia

Review Request 57240: AMBARI-20268.WFM generates duplicate kill nodes in XML if decision paths have multiple transition to kill node.

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57240/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20268
https://issues.apache.org/jira/browse/AMBARI-20268


Repository: ambari


Description
---

Fixed by storing nodes by name instead of id in the visited nodes array


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js
 eb8534b 


Diff: https://reviews.apache.org/r/57240/diff/1/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 57240: AMBARI-20268.WFM generates duplicate kill nodes in XML if decision paths have multiple transition to kill node.

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57240/#review167665
---


Ship it!




Ship It!

- belliraj hb


On March 2, 2017, 10:22 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57240/
> ---
> 
> (Updated March 2, 2017, 10:22 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20268
> https://issues.apache.org/jira/browse/AMBARI-20268
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by storing nodes by name instead of id in the visited nodes array
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js
>  eb8534b 
> 
> 
> Diff: https://reviews.apache.org/r/57240/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 57100: Select operators should not appear before fetch

[Abhishek Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57100/#review167658
---


Ship it!




Ship It!

- Abhishek Kumar


On Feb. 27, 2017, 7:29 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57100/
> ---
> 
> (Updated Feb. 27, 2017, 7:29 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20215
> https://issues.apache.org/jira/browse/AMBARI-20215
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> modified logic to show select node.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  a252498 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  196a514 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  01d6000 
> 
> 
> Diff: https://reviews.apache.org/r/57100/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 57237: AMBARI-20266.Duplicate node error is shown if kill node transition exists from decision node in WFM

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57237/#review167657
---


Ship it!




Ship It!

- belliraj hb


On March 2, 2017, 9:11 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57237/
> ---
> 
> (Updated March 2, 2017, 9:11 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20266
> https://issues.apache.org/jira/browse/AMBARI-20266
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added to check to avoid kill tranisitions while validating
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js
>  7336d6e 
> 
> 
> Diff: https://reviews.apache.org/r/57237/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Review Request 57237: AMBARI-20266.Duplicate node error is shown if kill node transition exists from decision node in WFM

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57237/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20266
https://issues.apache.org/jira/browse/AMBARI-20266


Repository: ambari


Description
---

Added to check to avoid kill tranisitions while validating


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js
 7336d6e 


Diff: https://reviews.apache.org/r/57237/diff/1/


Testing
---

Manual testing


Thanks,

Padma Priya N

Re: Review Request 57147: Added support for processing custom command script timeout

[Laszlo Puskas]

> On March 1, 2017, 7:07 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml
> > Lines 64 (patched)
> > 
> >
> > I'm still opposed to this patch fundamentally because no command should 
> > be able to run for 2 hours. That will block other commands on the client 
> > that decided to run it, which is extremely problematic.
> > 
> > Please make this call return right away and check the existence of the 
> > /system/balancer.id file

OK, i'll drop this patch. The rebalance operation will return imediately after 
the command is issued; in case nother balancer is running (the above file 
exists on hdfs). there will be no feedback about the success/failure of the 
command.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57147/#review167547
---


On Feb. 28, 2017, 6:01 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57147/
> ---
> 
> (Updated Feb. 28, 2017, 6:01 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20175
> https://issues.apache.org/jira/browse/AMBARI-20175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS rebalance operation can last for a long time (hours/days) thus when 
> triggered from the UI the command may be timed out by the Ambari server.
> This behavior may confuse users, making them to trigger the rebalancer again 
> which will fail with "another balancer is running"  error.
> 
> The patch provides support for setting a reasonably long timeout for the 
> rebalance custo action so that Ambari server doesnt time out the command.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  867ebff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> fd7f2f6 
> 
> 
> Diff: https://reviews.apache.org/r/57147/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests OK.
> Manually tested on local dev-env.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>