from:"\"Kevin Sweeney\""

Re: Review Request 34733: Fixing default TaskReconciler initial delay.

2015-05-27 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34733/#review85438
---

Ship it!



src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java
<https://reviews.apache.org/r/34733/#comment136996>

Move this validation to the constructor so that it will halt injector 
creation.


- Kevin Sweeney


On May 27, 2015, 1:52 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34733/
> ---
> 
> (Updated May 27, 2015, 1:52 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1339
> https://issues.apache.org/jira/browse/AURORA-1339
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The current default value leads to overflow. Fixed the value and added 
> validation.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 
>   src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 
> 23f5f648d3404495e3e9e878592c2638621ce89a 
>   src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java 
> f56ffd2d7c584042b5c47fa4dba83f35433762f5 
> 
> Diff: https://reviews.apache.org/r/34733/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 34501: Enabling TemporaryStorage to use flagged task store.

2015-05-27 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34501/#review85449
---

Ship it!


Ship It!

- Kevin Sweeney


On May 22, 2015, 5:31 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34501/
> ---
> 
> (Updated May 22, 2015, 5:31 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1322
> https://issues.apache.org/jira/browse/AURORA-1322
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allowing TemporaryStorage to use command line controlled task store.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java 
> 03dd5d99b269a1add709504b21fc197fdef9e18c 
>   src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
> f361caa6f4e3b28f4a1e4d57f1989a6aa6fe258e 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  23c0c1e73a183be748199610ddf03e5d654fef74 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 436d3841b9361df4db98a2217e61abb95e6e6bab 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 
> fe8e3f8f164732769fa0ae50a62e89c8aa77e9a5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  177d720b59ba601d59aada9650aba799babb9a73 
>   
> src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 
> 999d5e893897dc24659ca4a240ad3d4615cac0e5 
> 
> Diff: https://reviews.apache.org/r/34501/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Manual restore from backup in Vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 34661: Adds new documentation page listing Apache Aurora presentations (both videos and slides).

2015-05-27 Thread Kevin Sweeney



> On May 25, 2015, 10:51 p.m., Aurora ReviewBot wrote:
> > This patch does not apply cleanly on master (6db13ba), do you need to 
> > rebase?
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"
> 
> Dave Lester wrote:
> @ReviewBot retry

To get reviewbot to retry, you need to submit a new review rather than a 
comment. But I've never seen it accept a patch on a retry. It's probably just 
not able to accept a binary patch - can you push a branch somewhere for review?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34661/#review85151
---


On May 27, 2015, 3:42 p.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34661/
> ---
> 
> (Updated May 27, 2015, 3:42 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds new documentation page listing Apache Aurora presentations (both videos 
> and slides).
> 
> 
> Diffs
> -
> 
>   docs/README.md 508521fbd4fed8376e56b8c7e7eeabc301d1ef9e 
>   docs/images/presentations/02_19_2015_aurora_adopters_panel_thumb.png 
> PRE-CREATION 
>   docs/images/presentations/02_19_2015_aurora_at_tellapart_thumb.png 
> PRE-CREATION 
>   docs/images/presentations/02_19_2015_aurora_at_twitter_thumb.png 
> PRE-CREATION 
>   docs/images/presentations/02_28_2015_apache_aurora_thumb.png PRE-CREATION 
>   docs/images/presentations/03_25_2014_introduction_to_aurora_thumb.png 
> PRE-CREATION 
>   docs/images/presentations/04_30_2015_monolith_to_microservices_thumb.png 
> PRE-CREATION 
>   docs/images/presentations/08_21_2014_past_present_future_thumb.png 
> PRE-CREATION 
>   docs/presentations.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34661/diff/
> 
> 
> Testing
> ---
> 
> Markdown originally verified using Mou markdown editor/browser.
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 34739: Adding ChainedPathDetector into the GC executor.

2015-05-27 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/#review85478
---

Ship it!



src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py
<https://reviews.apache.org/r/34739/#comment137055>

Consider using PyHamcrest here, specifically  
http://pyhamcrest.readthedocs.org/en/release-1.8/object_matchers/#hamcrest.core.core.isinstanceof.instance_of
 with 
http://pyhamcrest.readthedocs.org/en/release-1.8/integration/#module-hamcrest.library.integration.match_equality


- Kevin Sweeney


On May 27, 2015, 5:03 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34739/
> ---
> 
> (Updated May 27, 2015, 5:03 p.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Bugs: AURORA-1025
> https://issues.apache.org/jira/browse/AURORA-1025
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This has escaped the previous set of changes in AURORA-1025 to enable 
> checkpoint dual-reading.
> 
> Extracted a method to faciliated unit testing as patching twitter.common.app 
> is not fun.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> 9e6508493abda4fe47213c485073d62ac81a99e4 
>   src/test/python/apache/aurora/executor/bin/BUILD 
> 918a76933a640ea5bed369a49a0b762e1e88 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py 
> d6998783eea0cb880f2ab1274e6c74104e3bd13c 
> 
> Diff: https://reviews.apache.org/r/34739/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast  src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34566/#review86710
---

Ship it!


Looks good, only style nits


src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
<https://reviews.apache.org/r/34566/#comment138773>

Either static import the above API_PATH or qualify H2_PATH, but please use 
a consistent style.



src/test/java/org/apache/aurora/scheduler/http/H2ConsoleModuleIT.java
<https://reviews.apache.org/r/34566/#comment138774>

Use a MediaType constant here.


- Kevin Sweeney


On June 4, 2015, 12:31 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34566/
> ---
> 
> (Updated June 4, 2015, 12:31 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1287
> https://issues.apache.org/jira/browse/AURORA-1287
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding support for connecting to H2 DB via management console: 
> http://www.h2database.com/html/quickstart.html
> 
> The H2 console servlet is put behind Shiro. Users are expected to have 
> `h2_management_console` permission or be a member of admin role to access the 
> console.
> 
> Vagrant example JDBC URL: jdbc:h2:mem:aurora
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 16515f6ce4518e0d7eec27dfcde6fe036ee05d1d 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
>  079ff5d2c30cc94bf4aef97cd4d791d480ebeab9 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java
>  0163ba1a6df647a644948a42f772bd838c2146ef 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java
>  28e6b98b39a073251bfae483575edd9635ae783a 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosPermissiveAuthenticationFilter.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/H2ConsoleModuleIT.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java
>  6743d06be828247b1c3a232aea145b0a0c492eca 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
>  33783c88b7c6c1a7343f3271523a7db39c73e4a1 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java
>  e335a439a6ccc301cf7c93e138c90660fbfdc6d0 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosPermissiveAuthenticationFilterTest.java
>  PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
> 6e9e3b2a8d731e51d0d55d0a5075b6d2d51a02ac 
> 
> Diff: https://reviews.apache.org/r/34566/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
> Connecting to H2 in Vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-06-04 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34300/#review86742
---

Ship it!



src/main/python/apache/aurora/config/thrift.py
<https://reviews.apache.org/r/34300/#comment138805>

Why set this at all? Does the scheduler read this field?


- Kevin Sweeney


On June 1, 2015, 11:05 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34300/
> ---
> 
> (Updated June 1, 2015, 11:05 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-739
> https://issues.apache.org/jira/browse/AURORA-739
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> It's possible to define nested refs that can cause the executor to stack 
> trace, e.g.
> {{derp[{{thermos.ports[http]}}]}} is perfectly valid but crashes the executor.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/config/__init__.py 
> dd2f89014a3da730364b14e01c499ac0f2c288c1 
>   src/main/python/apache/aurora/config/schema/base.py 
> a87524a8b3ad5aa0e337e0a0028cecb85865b4e6 
>   src/main/python/apache/aurora/config/thrift.py 
> 810febb637d168b07c4aea77984e1d1451a39af2 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> d110faf08135d94d9af95ad74613950c56248c09 
>   src/main/python/apache/thermos/config/dsl.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/main/python/apache/thermos/config/loader.py 
> d77ab9a52b16e9d65acdb95f01fd251ae8ab2b6e 
>   src/test/python/apache/aurora/client/test_config.py 
> c56779712b91f621261358aa7ebd6c4fc65446a0 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 654c0b5ae82c98db163c7a44301ff6b23e19b211 
>   src/test/python/apache/aurora/executor/common/test_task_info.py 
> 102ba531aa6c28f2d74bd0d7f1668e5861e3a6b8 
> 
> Diff: https://reviews.apache.org/r/34300/diff/
> 
> 
> Testing
> ---
> 
> Added some regression tests.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-06-05 Thread Kevin Sweeney



> On May 21, 2015, 5:22 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/api/__init__.py, line 114
> > <https://reviews.apache.org/r/34570/diff/2/?file=968393#file968393line114>
> >
> > Do we care that we're going from an immutable to a mutable set with 
> > this change (here and elsewhere)?

I don't think so - we haven't been strong on the "everything must be immutable" 
style in Python - this statement for example is already mutating a TaskQuery 
instance. I think it's somewhat the nature of the language that *everything* is 
mutable in practice and only immutable by convention - there are no final 
fields for example. I think using a consistent style across the codebase 
outweighs here, and if we want to make sure everything is immutable (as 
enforced by the language) later we should do a full refactor for that.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34570/#review84837
-------


On May 21, 2015, 4:28 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34570/
> ---
> 
> (Updated May 21, 2015, 4:28 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use Python 2.7 set-literal and set-comprehension syntax where possible.
> 
> There are theoretical performance gains here, for example we now often avoid 
> the creation of an intermediate list. The main reason I did this was 
> consistency though - as you'll see in this review there's no single 
> agreed-upon way to do this.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 439554d0980a4f3cd5b65a809547c7ac32d3cbf5 
>   src/main/python/apache/aurora/admin/admin.py 
> d2f7bd13ef335bdca7dc02177c031ac36574658d 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> c31e2a6fb0348c5e7074e46d61c2d2723afaf14d 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 4b9c48e84bc203fc7b28d7efd0b2e6b8a6f18302 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> 6ed815423f48301ecb3faaadcdfa1e46f50b6ca2 
>   src/main/python/apache/aurora/client/api/job_monitor.py 
> aa7e9760d0f4f74a5ddf97e0642bf53efc555644 
>   src/main/python/apache/aurora/client/api/sla.py 
> 5855685bda7188c55432dc6f1ad3c676a38309da 
>   src/main/python/apache/aurora/client/api/updater.py 
> acbce21e991981a2e85c1a00a68e57d88c5509bb 
>   src/main/python/apache/aurora/client/cli/command_hooks.py 
> e95b1b11e16b8e2cfc83ace8654e146be208d14e 
>   src/main/python/apache/aurora/client/cli/context.py 
> c850223588df9d9be4a644aa51adc6419a751af0 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 5f608419e1235f14836865b46be05d13963deb37 
>   src/main/python/apache/aurora/client/cli/task.py 
> b541d03d6e34dce7f4f1e38e2d970c71c8d94e08 
>   src/main/python/apache/aurora/config/__init__.py 
> dd2f89014a3da730364b14e01c499ac0f2c288c1 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/tail.py 
> 47b52eee7cb43a46f75d62b648d293a9c603efc3 
>   src/main/python/apache/thermos/common/planner.py 
> da5120f8f0c2489927a03e9d78ccb4f9b6eb275f 
>   src/main/python/apache/thermos/core/helper.py 
> 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/test/python/apache/aurora/BUILD 
> 0701440ae47034c580b5baae40e5f6feec4bb4fd 
>   src/test/python/apache/aurora/client/api/BUILD 
> 65b378b0b4c5fa11f9899ef04a4a10a211f37245 
>   src/test/python/apache/aurora/client/api/test_job_monitor.py 
> ccc8b551c15df2d726291675a90a62c30ad5ebd4 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 22b9f995eaa1deae9f5c5467e0939670c099f438 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 2130f1fa71be02a004cdf8e476a270c81a7105d3 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 9f32ca3474ea51529217db29b88911010fa73602 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> a545fece5e2b3e0017a61e1be9ac478372b1f34d 
>   src/test/python/apache/aurora/thrift_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34570/diff/
> 
> 
> Testing
> ---
> 
> I've left most of the tests out of the scope of this review to provide more 
> confidence; however, I&#x

Review Request 35219: Relax requirement for .ini file sections.

2015-06-08 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35219/
---

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-1342
https://issues.apache.org/jira/browse/AURORA-1342


Repository: aurora


Description
---

Relax requirement for .ini file sections.


Diffs
-

  
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java 
671b14fe4bcab933c2aaf3dff43ed6f9ef9c05fc 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java
 cb8b1add6b47a117b1f524759af2a35477a47561 
  
src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini
 5303c6e5d969c85025b36319f6e3d84a7da31ce3 
  
src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-no-sections.ini
 PRE-CREATION 

Diff: https://reviews.apache.org/r/35219/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 34661: Adds new documentation page listing Apache Aurora presentations (both videos and slides).

2015-06-09 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34661/#review87280
---

Ship it!


Ship It!

- Kevin Sweeney


On June 8, 2015, 11:40 a.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34661/
> ---
> 
> (Updated June 8, 2015, 11:40 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds new documentation page listing Apache Aurora presentations (both videos 
> and slides).
> 
> 
> Diffs
> -
> 
>   docs/README.md 508521fbd4fed8376e56b8c7e7eeabc301d1ef9e 
>   docs/images/presentations/02_19_2015_aurora_adopters_panel_thumb.png 
> PRE-CREATION 
>   docs/images/presentations/02_19_2015_aurora_at_tellapart_thumb.png 
> PRE-CREATION 
>   docs/images/presentations/02_19_2015_aurora_at_twitter_thumb.png 
> PRE-CREATION 
>   docs/images/presentations/02_28_2015_apache_aurora_thumb.png PRE-CREATION 
>   docs/images/presentations/03_25_2014_introduction_to_aurora_thumb.png 
> PRE-CREATION 
>   docs/images/presentations/04_30_2015_monolith_to_microservices_thumb.png 
> PRE-CREATION 
>   docs/images/presentations/08_21_2014_past_present_future_thumb.png 
> PRE-CREATION 
>   docs/presentations.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34661/diff/
> 
> 
> Testing
> ---
> 
> Markdown originally verified using Mou markdown editor/browser.
> 
> Also viewable on github: 
> https://github.com/davelester/incubator-aurora/blob/aurora-presentations-documentation/docs/presentations.md
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-06-09 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33778/#review82436
---


Looks mostly good, few comments below.


packaging/rpm/aurora.service
<https://reviews.apache.org/r/33778/#comment133178>

The scheduler should not run as root



packaging/rpm/aurora.spec
<https://reviews.apache.org/r/33778/#comment133172>

support for 1.7 will be dropped in 0.9.0, I'd prefer we not get new users 
stuck here and remove this branch.



packaging/rpm/aurora.spec
<https://reviews.apache.org/r/33778/#comment139602>

Java 8 is required in 0.9.0 - remove this branching entirely.



packaging/rpm/aurora.spec
<https://reviews.apache.org/r/33778/#comment139597>

Drop this entirely now that the project is on JDK8?



packaging/rpm/aurora.startup.sh
<https://reviews.apache.org/r/33778/#comment139598>

the RHS is redundant here if you change GLOG_V to GLOG_v in the sysconfig 
file.



packaging/rpm/aurora.startup.sh
<https://reviews.apache.org/r/33778/#comment139600>

RHS is redundant - you can just do

```
export GLOG_v LIBPROCESS_PORT LIBPROCES_IP
```



packaging/rpm/aurora.sysconfig
<https://reviews.apache.org/r/33778/#comment139596>

Is this needed? This is the default right?


- Kevin Sweeney


On May 19, 2015, 9:19 a.m., Steve Salevan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33778/
> ---
> 
> (Updated May 19, 2015, 9:19 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-1116
> https://issues.apache.org/jira/browse/AURORA-1116
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This review board adds support for building Red Hat-flavored packages for the 
> Aurora scheduler alongside its client and Thermos-related binaries:
> 
> aurora - Aurora Scheduler
> aurora-client - Aurora client and admin tool
> aurora-thermos - Thermos executor, runner, and observer
> aurora-debuginfo - Debugging symbols for Python/libmesos integration
> 
> If you'd like to give it a whirl, the following Make targets will spin up new 
> RPMs:
> 
> make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped 
> versioning, suitable for producing nightly updates
> make (release_srpm|release_rpm) - builds without timestamped versioning
> 
> Let me know what you think, and thanks!
> 
> 
> Diffs
> -
> 
>   packaging/rpm/Makefile PRE-CREATION 
>   packaging/rpm/aurora.init.sh PRE-CREATION 
>   packaging/rpm/aurora.logrotate PRE-CREATION 
>   packaging/rpm/aurora.service PRE-CREATION 
>   packaging/rpm/aurora.spec PRE-CREATION 
>   packaging/rpm/aurora.startup.sh PRE-CREATION 
>   packaging/rpm/aurora.sysconfig PRE-CREATION 
>   packaging/rpm/clusters.json PRE-CREATION 
>   packaging/rpm/thermos-observer.init.sh PRE-CREATION 
>   packaging/rpm/thermos-observer.logrotate PRE-CREATION 
>   packaging/rpm/thermos-observer.service PRE-CREATION 
>   packaging/rpm/thermos-observer.startup.sh PRE-CREATION 
>   packaging/rpm/thermos-observer.sysconfig PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33778/diff/
> 
> 
> Testing
> ---
> 
> Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 
> and F19
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>

Review Request 35274: Upgrade to requests-kerberos 0.7.0.

2015-06-09 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35274/
---

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-1346
https://issues.apache.org/jira/browse/AURORA-1346


Repository: aurora


Description
---

Upgrade to requests-kerberos 0.7.0.


Diffs
-

  3rdparty/python/requirements.txt 439554d0980a4f3cd5b65a809547c7ac32d3cbf5 

Diff: https://reviews.apache.org/r/35274/diff/


Testing
---

e2e test run pending


Thanks,

Kevin Sweeney

Re: Review Request 35274: Upgrade to requests-kerberos 0.7.0.

2015-06-09 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35274/
---

(Updated June 9, 2015, 4:05 p.m.)


Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-1346
https://issues.apache.org/jira/browse/AURORA-1346


Repository: aurora


Description (updated)
---

Upgrade to requests-kerberos 0.7.0.

Upstream changelog:
0.7.0: 2015-05-04

* Added Windows native authentication support by adding kerberos-sspi as an 
alternative backend.
* Prevent infinite recursion when a server returns 401 to an authorization 
attempt.
* Reduce the logging during successful responses.


Diffs
-

  3rdparty/python/requirements.txt 439554d0980a4f3cd5b65a809547c7ac32d3cbf5 

Diff: https://reviews.apache.org/r/35274/diff/


Testing
---

e2e test run pending


Thanks,

Kevin Sweeney

Re: Review Request 35483: Removing deprecated JobUpdateSummary fields.

2015-06-15 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35483/#review88011
---

Ship it!


Ship It!

- Kevin Sweeney


On June 15, 2015, 5:27 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35483/
> ---
> 
> (Updated June 15, 2015, 5:27 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1139
> https://issues.apache.org/jira/browse/AURORA-1139
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Finalizing `JobUpdateKey` migration.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> dd54e5b50050540b8599003786c79e4b033f3739 
>   api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
> 26c5db8a6564f6baa40da685c52d60b40e20f633 
>   src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 
> 3c6d4c992a6edcf9d4e438e75d8448021c886b17 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> 1a63169c26ff57467010cfea42d6ce33eb427c5b 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
> 159cb0cfb03255d1dff87549f07c4d049af78a23 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
> 4b9d7f5d292e42be4ab720aa61f457c69c58f5b2 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
>  b1b6f11ca25cf1c6c4566af35a6334514251922c 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> c58f531fdd9e860e67037605ec5804870ed0a79f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> c5e2323ef222cecc4ff30790e2f28f2c70dd1b54 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> e61a6b4ec914540cfbcec79235f7b9af9443faaf 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  1ca3a9bb58207d7a9167b2762e0fed24219722b5 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  1ebfa64edf578d0008b48b12438a5eae9237b809 
>   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
> 646647382b89d315bc1b31795228c0461940bac1 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  cf31cf8be43161b8146aa79cfc62e6cc17a71db3 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 1ff8d23e31e1c61e242079fba5056119f8d869b4 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  d1d7e799219627c0ed94061401e7c7f4c13c12a5 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> cbc2d38a9d73c725c3be7fb161c07b307ea3b2f2 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  982968af52fdaa9c39f51bdac6b082ae839b6c7a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  52c72620a381ee086d81a3751dfe397a3a6f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  21b40448e0da814831fc6b2ed62ddb326efda910 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 7aa19d43d243899682bca54210637a8286ca0b9c 
> 
> Diff: https://reviews.apache.org/r/35483/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-15 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/#review88013
---

Ship it!


Ship It!


docs/configuration-reference.md
<https://reviews.apache.org/r/32973/#comment140417>

s/it's/its/


- Kevin Sweeney


On June 12, 2015, 4:11 a.m., Brian Brazil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32973/
> ---
> 
> (Updated June 12, 2015, 4:11 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1257
> https://issues.apache.org/jira/browse/AURORA-1257
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix name of test for sigterm being ignored.
> 
> Based on 
> https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
>   src/main/python/apache/aurora/common/http_signaler.py 
> 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 837ad5c55b4a02215a8d509c211e80529536f705 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/test/python/apache/aurora/common/test_http_signaler.py 
> c6a21708eb997f213f4cca038891a84f6c5218d4 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf 
> 
> Diff: https://reviews.apache.org/r/32973/diff/
> 
> 
> Testing
> ---
> 
> Unittests and manually in vagrant cluster. Also verified that the flaky tests 
> pass.
> 
> 
> Thanks,
> 
> Brian Brazil
> 
>

Review Request 35535: Use Shiro identity if available in audit logs.

2015-06-16 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/
---

Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Use Shiro identity if available in audit logs.


Diffs
-

  config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
912e465793b42c81040a8cfe507c2e341932c205 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/35535/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 35535: Use Shiro identity if available in audit logs.

2015-06-16 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/
---

(Updated June 16, 2015, 2:54 p.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Changes
---

Use map instead of ofNullable within flatMap.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Use Shiro identity if available in audit logs.


Diffs (updated)
-

  config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
912e465793b42c81040a8cfe507c2e341932c205 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/35535/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 35535: Use Shiro identity if available in audit logs.

2015-06-16 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/
---

(Updated June 16, 2015, 3:06 p.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Changes
---

Review feedback.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Use Shiro identity if available in audit logs.


Diffs (updated)
-

  config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
912e465793b42c81040a8cfe507c2e341932c205 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/35535/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Review Request 35627: Explicitly bind SessionContext.

2015-06-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35627/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Explicitly bind SessionContext.


Diffs
-

  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
c89ff0fed60af04f04177e9cdfba6a24b62c2e97 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
57132ac480702c93934ada198475203b0648ad6a 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
0a842cb9cdd266690b2d3103126e831fe07b1735 
  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
4d6043a402a761fe44239e33b83c1c8872fe7068 

Diff: https://reviews.apache.org/r/35627/diff/


Testing
---

Ran kerberos e2e test and verified audit messages in UI.


Thanks,

Kevin Sweeney

Re: Review Request 35627: Explicitly bind SessionContext.

2015-06-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35627/
---

(Updated June 18, 2015, 2:35 p.m.)


Review request for Aurora and Bill Farner.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Explicitly bind SessionContext.


Diffs
-

  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
c89ff0fed60af04f04177e9cdfba6a24b62c2e97 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
57132ac480702c93934ada198475203b0648ad6a 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
0a842cb9cdd266690b2d3103126e831fe07b1735 
  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
4d6043a402a761fe44239e33b83c1c8872fe7068 

Diff: https://reviews.apache.org/r/35627/diff/


Testing (updated)
---

Ran kerberos e2e test.


Thanks,

Kevin Sweeney

Re: Review Request 35627: Explicitly bind SessionContext.

2015-06-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35627/
---

(Updated June 18, 2015, 2:40 p.m.)


Review request for Aurora and Bill Farner.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description (updated)
---

Explicitly bind SessionContext.

Discussion on bugs like this and a potential solution (enabling 
`requireExplicitBindings`) are here: https://github.com/google/guice/issues/740


Diffs
-

  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
c89ff0fed60af04f04177e9cdfba6a24b62c2e97 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
57132ac480702c93934ada198475203b0648ad6a 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
0a842cb9cdd266690b2d3103126e831fe07b1735 
  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
4d6043a402a761fe44239e33b83c1c8872fe7068 

Diff: https://reviews.apache.org/r/35627/diff/


Testing
---

Ran kerberos e2e test.


Thanks,

Kevin Sweeney

Re: Review Request 35627: Explicitly bind SessionContext.

2015-06-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35627/
---

(Updated June 18, 2015, 2:55 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

Add explanatory comment, use interface in SessionValidator as well.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Explicitly bind SessionContext.

Discussion on bugs like this and a potential solution (enabling 
`requireExplicitBindings`) are here: https://github.com/google/guice/issues/740


Diffs (updated)
-

  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
c89ff0fed60af04f04177e9cdfba6a24b62c2e97 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
57132ac480702c93934ada198475203b0648ad6a 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
0a842cb9cdd266690b2d3103126e831fe07b1735 
  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
4d6043a402a761fe44239e33b83c1c8872fe7068 

Diff: https://reviews.apache.org/r/35627/diff/


Testing
---

Ran kerberos e2e test.


Thanks,

Kevin Sweeney

Re: Review Request 35613: Fixing broken gradle dependency scanner.

2015-06-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/#review88464
---

Ship it!


Ship It!

- Kevin Sweeney


On June 18, 2015, 3:12 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35613/
> ---
> 
> (Updated June 18, 2015, 3:12 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Our current scanner plugin version does not work with gradle 2.4. 
> 
> Upgrading plugin version and a few other deps (those that did not conflict 
> with a mighty twitter.commons package):
> - junit: 
> https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.12.md
> - gson: https://sites.google.com/site/gson/gson-roadmap
> - slf4j: http://www.slf4j.org/news.html
> - mybatis: https://github.com/mybatis/mybatis-3/releases
> 
> 
> Diffs
> -
> 
>   build.gradle 700e1ade1470b99e9be390db150cf73aa06f17bc 
> 
> Diff: https://reviews.apache.org/r/35613/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35633: Fixing stylecheck errors.

2015-06-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35633/#review88465
---

Ship it!


Ship It!

- Kevin Sweeney


On June 18, 2015, 4:15 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35633/
> ---
> 
> (Updated June 18, 2015, 4:15 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Looks like regression from: https://reviews.apache.org/r/35627/
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
> 010e7146799381518436d410ce8272edbe3e0df9 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> 0226144ffecec611200077e3ec66ede6cee58a3a 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
> a8badd40f63433216d809cbbebe79c15c9427571 
> 
> Diff: https://reviews.apache.org/r/35633/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-06-22 Thread Kevin Sweeney



> On June 4, 2015, 4:55 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/config/thrift.py, line 218
> > <https://reviews.apache.org/r/34300/diff/3/?file=975774#file975774line218>
> >
> > Why set this at all? Does the scheduler read this field?
> 
> Brian Wickman wrote:
> it is not.  i will leave it up to AURORA-739 to remove support entirely 
> (or add it back in a sensible way.)

In that case, please drop this set from the client-side.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34300/#review86742
---


On June 1, 2015, 11:05 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34300/
> ---
> 
> (Updated June 1, 2015, 11:05 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-739
> https://issues.apache.org/jira/browse/AURORA-739
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> It's possible to define nested refs that can cause the executor to stack 
> trace, e.g.
> {{derp[{{thermos.ports[http]}}]}} is perfectly valid but crashes the executor.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/config/__init__.py 
> dd2f89014a3da730364b14e01c499ac0f2c288c1 
>   src/main/python/apache/aurora/config/schema/base.py 
> a87524a8b3ad5aa0e337e0a0028cecb85865b4e6 
>   src/main/python/apache/aurora/config/thrift.py 
> 810febb637d168b07c4aea77984e1d1451a39af2 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> d110faf08135d94d9af95ad74613950c56248c09 
>   src/main/python/apache/thermos/config/dsl.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/main/python/apache/thermos/config/loader.py 
> d77ab9a52b16e9d65acdb95f01fd251ae8ab2b6e 
>   src/test/python/apache/aurora/client/test_config.py 
> c56779712b91f621261358aa7ebd6c4fc65446a0 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 654c0b5ae82c98db163c7a44301ff6b23e19b211 
>   src/test/python/apache/aurora/executor/common/test_task_info.py 
> 102ba531aa6c28f2d74bd0d7f1668e5861e3a6b8 
> 
> Diff: https://reviews.apache.org/r/34300/diff/
> 
> 
> Testing
> ---
> 
> Added some regression tests.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 35813: Removing GC executor code.

2015-06-24 Thread Kevin Sweeney



> On June 23, 2015, 5:31 p.m., Brian Wickman wrote:
> > slightly overzealous deleting.  the thermos gc stuff should still be part 
> > of the thermos toolchain.
> 
> Maxim Khutornenko wrote:
> Should not we rather rely on task reconciliation to do any cleanup 
> instead? Force GCing a task does not seem to be a critical feature (in fact 
> it's currently broken AURORA-1347) but comes with a maintenance burden. Is 
> there a particular reason to hold on to it?
> 
> Maxim Khutornenko wrote:
> Actually meant "task reconciliation + mesos slave GC" above.
> 
> Brian Wickman wrote:
> if it's currently broken, then kill it with fire.

+1, and close https://issues.apache.org/jira/browse/AURORA-1347 as wontfix


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89104
---


On June 23, 2015, 5:22 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> ---
> 
> (Updated June 23, 2015, 5:22 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
> https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing GC executor code.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
> a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD 
> cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 0fbb0f1ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 
> 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 
> 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py 
> f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD 
> efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 
> 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 
> 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 
> 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py 
> aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD 
> f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 
> 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py 
> d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 
> 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 
> 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 
> 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-24 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/
---

Review request for Aurora, Bill Farner and Zameer Manji.


Repository: aurora


Description
---

Use java.util.Optional and streams in Lock*.

Taking advantage of some Java 8 features along the way, and introduced 
GuavaCollectors.toImmutableSet for compatibility with the streams API


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/LockManager.java 
e8303f914466ebe93518ec2970e1173dc39d9adb 
  src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
6aa281cb7b07e3e82c578c553eee8c7066cf2761 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
2be3eb0e9405e3d34533520095423429fe00a2ca 
  src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 
596a3787369616d30a2763a37bcb7b7cc39ad386 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
335d7a95e797fe940e71b10da44cbd97edea69ac 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
0670b2b4c3817becefb38f0294f111768386817b 
  src/main/java/org/apache/aurora/util/GuavaCollectors.java PRE-CREATION 
  src/main/resources/apache/aurora/client/cli/.auroraversion 
5ea35de7ada4edef3189e0b01b322d50e8f8a638 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 
ecbe1dd1eb1f0de07bea490b076c7a920f08bccb 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 38ef412a6d29dfef7b305e00cf44522818303965 
  src/test/java/org/apache/aurora/util/GuavaCollectorsTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/35842/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-24 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/
---

(Updated June 24, 2015, 2:52 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Revert .auroraversion change that snuck in.


Repository: aurora


Description
---

Use java.util.Optional and streams in Lock*.

Taking advantage of some Java 8 features along the way, and introduced 
GuavaCollectors.toImmutableSet for compatibility with the streams API


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/state/LockManager.java 
e8303f914466ebe93518ec2970e1173dc39d9adb 
  src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
6aa281cb7b07e3e82c578c553eee8c7066cf2761 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
2be3eb0e9405e3d34533520095423429fe00a2ca 
  src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 
596a3787369616d30a2763a37bcb7b7cc39ad386 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
335d7a95e797fe940e71b10da44cbd97edea69ac 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
0670b2b4c3817becefb38f0294f111768386817b 
  src/main/java/org/apache/aurora/util/GuavaCollectors.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 
ecbe1dd1eb1f0de07bea490b076c7a920f08bccb 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 38ef412a6d29dfef7b305e00cf44522818303965 
  src/test/java/org/apache/aurora/util/GuavaCollectorsTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/35842/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35847/#review89252
---



src/main/python/apache/aurora/config/schema/base.py (line 48)
<https://reviews.apache.org/r/35847/#comment141844>

Convention is to not capitalize acronyms like HTTP, but to render them as 
Http (here and below).


- Kevin Sweeney


On June 24, 2015, 2:55 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35847/
> ---
> 
> (Updated June 24, 2015, 2:55 p.m.)
> 
> 
> Review request for Aurora, Brian Brazil and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1368
> https://issues.apache.org/jira/browse/AURORA-1368
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Move shutdown endpoints to the Job config since the lifecycle is controlled 
> by Aurora and not Thermos.
> Split the lifecycle management into a composition layer that can more readily 
> be tested.
> 
> Also, derp, just realized I did not update the documentation.  Revision 
> forthcoming.
> (Also comment on the 'union' style here -- not sure what is preferable.)
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
>   src/main/python/apache/aurora/config/schema/base.py 
> 9a6f8a16f85c324ec75352710e19249443bf2c6b 
>   src/main/python/apache/aurora/config/thrift.py 
> 0a3e91011eccf8573feb296bd7f72913622e0ce0 
>   src/main/python/apache/aurora/executor/BUILD 
> cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/http_lifecycle.py PRE-CREATION 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 7bcd6c42f50665eac2e7f17b84e63f2ea7fb4d4f 
>   src/main/python/apache/thermos/config/schema_base.py 
> a85def9eea25fa01020ca2dda4e9cefe861c4a5f 
>   src/test/python/apache/aurora/executor/BUILD 
> f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/common/fixtures.py 
> 37d032beb66a67cfd3cfcea272747a2915a745ff 
>   src/test/python/apache/aurora/executor/test_http_lifecycle.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 3569a6abf84d5144d2e268b0a86c82285ffe2b2b 
> 
> Diff: https://reviews.apache.org/r/35847/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-25 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35498/#review89394
---

Ship it!



src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java (lines 129 
- 130)
<https://reviews.apache.org/r/35498/#comment141980>

Add getters for these fields and access them below via the getters rather 
than direct field access.


- Kevin Sweeney


On June 24, 2015, 12:09 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35498/
> ---
> 
> (Updated June 24, 2015, 12:09 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1350
> https://issues.apache.org/jira/browse/AURORA-1350
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Compute SLA stats for non-prod jobs
> 
> This is a first iteration closely following the design proposal of Maxim as 
> posted on the mailinglist. Feedback welcome.
> 
> 
> Diffs
> -
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   docs/sla.md 14e9108fda91200bbf56384c96b9cd926689311f 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 82f36d5ca15df18bdc8ebbbd868d3394db38e603 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> 64e986fb2e0f955dd4a9c7824eac9494728bf24e 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> cb98834e925793fc116814371548a30470830164 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d 
> 
> Diff: https://reviews.apache.org/r/35498/diff/
> 
> 
> Testing
> ---
> 
> `./gradlew -Pq build` and a manual verification in Vagrant.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-25 Thread Kevin Sweeney



> On June 24, 2015, 3:15 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/util/GuavaCollectors.java, line 36
> > <https://reviews.apache.org/r/35842/diff/2/?file=991612#file991612line36>
> >
> > I think this collector needs to be given the unordered characteristic 
> > because it is building a set where the order will be lost: 
> > https://docs.oracle.com/javase/8/docs/api/java/util/stream/Collector.Characteristics.html#UNORDERED

Added.


> On June 24, 2015, 3:15 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 263
> > <https://reviews.apache.org/r/35842/diff/2/?file=991611#file991611line263>
> >
> > I think we should be importing java.util.Optional at the top of the 
> > file and inlining use of com.google.common.base.Optional as necessary.
> > 
> > Now that we are on JDK 8 we should be prefering use of 
> > java.util.Optional. If that change is very noisey, can you check how 
> > difficult it would be to remove guava's Optional in these files?

This is the lower blast-radius change - this file is almost 1400 lines, and 
many of the APIs it calls are still written in terms of guava Optional.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/#review89257
---


On June 24, 2015, 2:52 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35842/
> ---
> 
> (Updated June 24, 2015, 2:52 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use java.util.Optional and streams in Lock*.
> 
> Taking advantage of some Java 8 features along the way, and introduced 
> GuavaCollectors.toImmutableSet for compatibility with the streams API
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/LockManager.java 
> e8303f914466ebe93518ec2970e1173dc39d9adb 
>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
> 6aa281cb7b07e3e82c578c553eee8c7066cf2761 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> 2be3eb0e9405e3d34533520095423429fe00a2ca 
>   src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 
> 596a3787369616d30a2763a37bcb7b7cc39ad386 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
> 335d7a95e797fe940e71b10da44cbd97edea69ac 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  0670b2b4c3817becefb38f0294f111768386817b 
>   src/main/java/org/apache/aurora/util/GuavaCollectors.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
> 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 
> ecbe1dd1eb1f0de07bea490b076c7a920f08bccb 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  38ef412a6d29dfef7b305e00cf44522818303965 
>   src/test/java/org/apache/aurora/util/GuavaCollectorsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35842/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-25 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/
---

(Updated June 25, 2015, 11:12 a.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Add UNORDERED characteristic.


Repository: aurora


Description
---

Use java.util.Optional and streams in Lock*.

Taking advantage of some Java 8 features along the way, and introduced 
GuavaCollectors.toImmutableSet for compatibility with the streams API


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/state/LockManager.java 
e8303f914466ebe93518ec2970e1173dc39d9adb 
  src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
6aa281cb7b07e3e82c578c553eee8c7066cf2761 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
2be3eb0e9405e3d34533520095423429fe00a2ca 
  src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 
596a3787369616d30a2763a37bcb7b7cc39ad386 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
335d7a95e797fe940e71b10da44cbd97edea69ac 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
0670b2b4c3817becefb38f0294f111768386817b 
  src/main/java/org/apache/aurora/util/GuavaCollectors.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 
ecbe1dd1eb1f0de07bea490b076c7a920f08bccb 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 38ef412a6d29dfef7b305e00cf44522818303965 
  src/test/java/org/apache/aurora/util/GuavaCollectorsTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/35842/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-25 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/
---

(Updated June 25, 2015, 11:32 a.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Move GuavaCollectors to existing GuiceUtils class.


Repository: aurora


Description
---

Use java.util.Optional and streams in Lock*.

Taking advantage of some Java 8 features along the way, and introduced 
GuavaCollectors.toImmutableSet for compatibility with the streams API


Diffs (updated)
-

  src/main/java/org/apache/aurora/GuavaUtils.java 
22104e6d005ae6706a06a21ffe4c730b14ecfe53 
  src/main/java/org/apache/aurora/scheduler/state/LockManager.java 
e8303f914466ebe93518ec2970e1173dc39d9adb 
  src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
6aa281cb7b07e3e82c578c553eee8c7066cf2761 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
2be3eb0e9405e3d34533520095423429fe00a2ca 
  src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 
596a3787369616d30a2763a37bcb7b7cc39ad386 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
335d7a95e797fe940e71b10da44cbd97edea69ac 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
0670b2b4c3817becefb38f0294f111768386817b 
  src/test/java/org/apache/aurora/GuavaUtilsTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 
ecbe1dd1eb1f0de07bea490b076c7a920f08bccb 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 38ef412a6d29dfef7b305e00cf44522818303965 

Diff: https://reviews.apache.org/r/35842/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Review Request 35886: Remove static modifier from test case.

2015-06-25 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35886/
---

Review request for Aurora, Bill Farner and Zameer Manji.


Repository: aurora


Description
---

Remove static modifier from test case, which was introduced in the last 
revision to https://reviews.apache.org/r/35842/

This fixes

[ant:checkstyle] 
/home/ksweeney/workspace/aurora/src/test/java/org/apache/aurora/GuavaUtilsTest.java:23:1:
 Utility classes should not have a public or default constructor.


Diffs
-

  src/test/java/org/apache/aurora/GuavaUtilsTest.java 
065a4bac48b7264c1c6aaf228c684f813f2a39ea 

Diff: https://reviews.apache.org/r/35886/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Kevin Sweeney



> On June 25, 2015, 10:59 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines 
> > 138-139
> > <https://reviews.apache.org/r/35498/diff/7/?file=991483#file991483line138>
> >
> > Add getters for these fields and access them below via the getters 
> > rather than direct field access.
> 
> Stephan Erb wrote:
> I can submit an updated patch tonight. I've somewhat expected that some 
> of you would point it out :-)
> 
> I thought about adding these when writing the patch but then decided 
> against them: Getters for final attributes on an inner class did not seem to 
> offer any meaningful encapsulation or help during refactoring.

In this case the class in question uses getters and direct field access 
inconsistently, I'd also be okay with removing all getters on that class and 
replacing them with direct field access. I think getters are more readable 
though (it's a code review red flag when I see a new direct field access). 
Other committers feel free to chime in here.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35498/#review89394
---


On June 26, 2015, 10:45 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35498/
> -------
> 
> (Updated June 26, 2015, 10:45 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1350
> https://issues.apache.org/jira/browse/AURORA-1350
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Compute SLA stats for non-prod jobs
> 
> This is a first iteration closely following the design proposal of Maxim as 
> posted on the mailinglist. Feedback welcome.
> 
> 
> Diffs
> -
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   docs/sla.md 14e9108fda91200bbf56384c96b9cd926689311f 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 82f36d5ca15df18bdc8ebbbd868d3394db38e603 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> 64e986fb2e0f955dd4a9c7824eac9494728bf24e 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> cb98834e925793fc116814371548a30470830164 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d 
> 
> Diff: https://reviews.apache.org/r/35498/diff/
> 
> 
> Testing
> ---
> 
> `./gradlew -Pq build` and a manual verification in Vagrant.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35932: Remove unnecessary uses of type witness.

2015-06-26 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35932/#review89531
---

Ship it!


Ship It!

- Kevin Sweeney


On June 26, 2015, 10:50 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35932/
> ---
> 
> (Updated June 26, 2015, 10:50 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Note that this does not remove _all_ type witnesses, as the compiler still 
> relies on them in several cases.  For example, chained method calls cannot 
> compile without them:
> 
> ```
> ImmutableSet.builder()
>   .add('a')
>   .add('b')
>   .build()
> ```
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 308bbd92943e331179bc5fad1f3fa0febba5ed1c 
>   src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
> d3e1295db9b933b5ab60d6446dfea453c6051795 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
> 3413b0a480073f39bc01a60bc93b211660d9e278 
>   src/main/java/org/apache/aurora/GuiceUtils.java 
> 5d0af1ebdccd0d0782f0fbc53d046a338c450167 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> 9e1f35a12205065f2f0cc783a49e14384bc4d50a 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 26093ef35f18eda5b05fe2a9351ac80fbeca3dc8 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
> 538cb755a5f80b9e70e3069205f219558053da9b 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 968aca6053a722dbaec6c5832c09e0816ae069ae 
>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
> f0dea48b3df69dedf620a55573731ed9451369c3 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
> f5a18338748da7c443b2fd2ec3a72adf75e7387f 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java
>  cd016af5621be76190ead81921096aae837b59c0 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
>  c1114a411c32c25785adc93e594ee8e291025969 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
> 41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
>   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
> 7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> df180a4f9dff75a04ae104462c219444ef605d9a 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 770672c85c06aaf4356b3b3580428b0323edb9d3 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 
>   src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
> bd74f892dde65e957f125a17979ee6c582b3043f 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java 
> ecba276f1882162d9578e0829b2139040876c7d0 
>   src/main/java/org/apache/aurora/scheduler/http/Cron.java 
> fd658e1ac5e73ef0c61c82685f6373c5f0eb6640 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> fcf5e4419b9908281858e591c916c586c707c6cd 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> d735cbc4169dbf3f7fb8dd1c13bf683ddcce548c 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  1e9b1c3b6e256fd994e94ad30d9340d12ce15f99 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java
>  b224983159c4979800fa384bbb082adc7b330b4c 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
>  7425b93f476ca1228a233a56363136f9e586a5e5 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
> 5bf4d9a659942c65290442fdcd4749bda046bfd8 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 7453680af5a518012f9779f82d0349e897c04994 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.

Review Request 36015: Fix terminology in cron docs.

2015-06-29 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36015/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Fix terminology in cron docs.


Diffs
-

  docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 

Diff: https://reviews.apache.org/r/36015/diff/


Testing
---


Thanks,

Kevin Sweeney

Re: Review Request 36060: Disabling h2 console by default.

2015-06-30 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36060/#review89948
---

Ship it!


Ship It!

- Kevin Sweeney


On June 30, 2015, 11:46 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36060/
> ---
> 
> (Updated June 30, 2015, 11:46 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> H2 console gives direct access (including modifications and deletions) to all 
> scheduler data. This is too powerful to be ON by default especially when 
> using scheduler in unsecure mode.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 3c9e13b52fd3f72ddf20c7869b5175761ac879cb 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> a44ea08950b9d4b33503f4cfc6e28a32c619b3c8 
>   src/test/java/org/apache/aurora/scheduler/http/H2ConsoleModuleIT.java 
> 9536fe3c484329066d8939edc40fa32525880ef5 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java
>  53ba949691768078ac17846b70d1baf440c444d4 
> 
> Diff: https://reviews.apache.org/r/36060/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 36063: Make e2e test fail when a command fails.

2015-06-30 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36063/
---

(Updated June 30, 2015, 1:10 p.m.)


Review request for Aurora and Bill Farner.


Bugs: AURORA-1378
https://issues.apache.org/jira/browse/AURORA-1378


Repository: aurora


Description
---

Make e2e test fail correctly.

This doesn't fix the test (still investigating the root cause there), but 
causes it to be properly broken.


Diffs
-

  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
79377c387232269094029314b677afeb21ee46ea 

Diff: https://reviews.apache.org/r/36063/diff/


Testing (updated)
---

```
+ + grep -q 'shiro_audit_logging_enabled 1'
+ curl -s localhost:8081/vars
+ tear_down 1
+ local retcode=1
+ sudo cp /vagrant/examples/vagrant/clusters.json /etc/aurora/clusters.json
+ sudo stop aurora-scheduler-kerberos
aurora-scheduler-kerberos stop/waiting
+ sudo rm -f /etc/init/aurora-scheduler-kerberos.conf
+ sudo start aurora-scheduler
aurora-scheduler start/running, process 13559
+ [[ 1 -ne 0 ]]
+ echo

+ echo '!!! FAILED'
!!! FAILED
+ echo
```


Thanks,

Kevin Sweeney

Review Request 36063: Make e2e test fail when a command fails.

2015-06-30 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36063/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1378
https://issues.apache.org/jira/browse/AURORA-1378


Repository: aurora


Description
---

Make e2e test fail correctly.

This doesn't fix the test (still investigating the root cause there), but 
causes it to be properly broken.


Diffs
-

  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
79377c387232269094029314b677afeb21ee46ea 

Diff: https://reviews.apache.org/r/36063/diff/


Testing
---

+ grep -q 'shiro_audit_logging_enabled 1'
+ curl -s localhost:8081/vars
+ tear_down 1
+ local retcode=1
+ sudo cp /vagrant/examples/vagrant/clusters.json /etc/aurora/clusters.json
+ sudo stop aurora-scheduler-kerberos
aurora-scheduler-kerberos stop/waiting
+ sudo rm -f /etc/init/aurora-scheduler-kerberos.conf
+ sudo start aurora-scheduler
aurora-scheduler start/running, process 13559
+ [[ 1 -ne 0 ]]
+ echo

+ echo '!!! FAILED'
!!! FAILED
+ echo


Thanks,

Kevin Sweeney

Re: Review Request 35928: Avoid unintentional use of TaskStatus.Reason default value.

2015-07-01 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35928/#review90077
---



src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java (lines 
228 - 230)
<https://reviews.apache.org/r/35928/#comment143027>

Do this above as well?


- Kevin Sweeney


On July 1, 2015, 10:30 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35928/
> ---
> 
> (Updated July 1, 2015, 10:30 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1327
> https://issues.apache.org/jira/browse/AURORA-1327
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Avoid unintentional use of TaskStatus.Reason default value.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 33749de538e9a6e08f6ec640ee44f8a5d74256e0 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> f08c79932f2ff9ed64b273a432c7d33c05ad95bd 
> 
> Diff: https://reviews.apache.org/r/35928/diff/
> 
> 
> Testing
> ---
> 
> The test methodology here is not great (though it's no worse than the 
> original).  For all intents and purposes, the test code is a carbon copy of 
> the application code.  Open to ideas, i couldn't quickly come up with 
> anything obviously better.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36100: Upgrade to rbt 0.7.4.

2015-07-01 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36100/#review90093
---

Ship it!


Ship It!

- Kevin Sweeney


On July 1, 2015, 11:29 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36100/
> ---
> 
> (Updated July 1, 2015, 11:29 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Release notes along the way:
> https://www.reviewboard.org/docs/releasenotes/rbtools/0.7.1/
> https://www.reviewboard.org/docs/releasenotes/rbtools/0.7.2/
> https://www.reviewboard.org/docs/releasenotes/rbtools/0.7.3/
> https://www.reviewboard.org/docs/releasenotes/rbtools/0.7.4/
> 
> 
> Diffs
> -
> 
>   rbt c082ab4e0f541ff0d8c94719b027902ad1aacb17 
> 
> Diff: https://reviews.apache.org/r/36100/diff/
> 
> 
> Testing
> ---
> 
> Posted this review.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36064: Perform leader redirect using HTTP status code 307

2015-07-01 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36064/#review90181
---

Ship it!



src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java (line 
46)
<https://reviews.apache.org/r/36064/#comment143178>

Use the `HttpHeaders.LOCATION` constant here instead.


- Kevin Sweeney


On June 30, 2015, 1:44 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36064/
> ---
> 
> (Updated June 30, 2015, 1:44 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Perform leader redirect using HTTP status code 307.
> 
> The scheduler used to redirect to its leading master using the HTTP status 
> code `302 Found`. Many browsers (including utilities like curl and python 
> requests) implement this status code wrongly. They are changing all PUT and 
> POST requests to GET (see https://en.wikipedia.org/wiki/HTTP_302). By using 
> the the new HTTP/1.1 code `307 Temporary Redirect` we remedy this situation.
> 
> Aurora is already using status code `307` within the MNAME-Feature. By using 
> it also for the leader redirect, we enable users to run commands like `curl 
> -X PUT http://non-leading-master/mname/...`
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 1c2b08de1e2c470d32baeb845ae0e0a7ce2b75aa 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> f8b134fa1f3fbbd7affef31acb077e7acd4f9761 
> 
> Diff: https://reviews.apache.org/r/36064/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 36220: Change docs to use a working git repo URL.

2015-07-06 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36220/#review90580
---

Ship it!


Ship It!

- Kevin Sweeney


On July 6, 2015, 2:37 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36220/
> ---
> 
> (Updated July 6, 2015, 2:37 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1382
> https://issues.apache.org/jira/browse/AURORA-1382
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Noticed this broken URL a few places on our site.
> 
> 
> Diffs
> -
> 
>   docs/vagrant.md 7b796b2d70c9adf4a8b88bda625dcf70fdfb0f73 
> 
> Diff: https://reviews.apache.org/r/36220/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33778/#review90566
---



build-support/packaging/rpm/aurora.service (line 20)
<https://reviews.apache.org/r/33778/#comment143669>

This is unnecessary according to [1]?

Alternatively you should consider doing `curl -X POST 
http://localhost:8081/quitquitquit`, which will invoke the scheduler graceful 
shutdown logic.

```
If this option is not specified, the process is terminated by sending the 
signal specified in KillSignal= when service stop is requested.
```

[1] 
http://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecStop=


- Kevin Sweeney


On July 6, 2015, 2:09 p.m., Steve Salevan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33778/
> ---
> 
> (Updated July 6, 2015, 2:09 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-1116
> https://issues.apache.org/jira/browse/AURORA-1116
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This review board adds support for building Red Hat-flavored packages for the 
> Aurora scheduler alongside its client and Thermos-related binaries:
> 
> aurora - Aurora Scheduler
> aurora-client - Aurora client and admin tool
> aurora-thermos - Thermos executor, runner, and observer
> aurora-debuginfo - Debugging symbols for Python/libmesos integration
> 
> If you'd like to give it a whirl, the following Make targets will spin up new 
> RPMs:
> 
> make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped 
> versioning, suitable for producing nightly updates
> make (release_srpm|release_rpm) - builds without timestamped versioning
> 
> Let me know what you think, and thanks!
> 
> 
> Diffs
> -
> 
>   build-support/packaging/rpm/Makefile PRE-CREATION 
>   build-support/packaging/rpm/README.md PRE-CREATION 
>   build-support/packaging/rpm/aurora.init.sh PRE-CREATION 
>   build-support/packaging/rpm/aurora.logrotate PRE-CREATION 
>   build-support/packaging/rpm/aurora.service PRE-CREATION 
>   build-support/packaging/rpm/aurora.spec PRE-CREATION 
>   build-support/packaging/rpm/aurora.startup.sh PRE-CREATION 
>   build-support/packaging/rpm/aurora.sysconfig PRE-CREATION 
>   build-support/packaging/rpm/clusters.json PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.service PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33778/diff/
> 
> 
> Testing
> ---
> 
> Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 
> and F19
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

2015-07-06 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36096/#review90523
---

Ship it!


+1 to this tactical fix. Which APIs need to be changed to use slaveID instead 
of hostName as the canonical identifier for mesos slaves within aurora?

- Kevin Sweeney


On July 1, 2015, 1:01 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36096/
> ---
> 
> (Updated July 1, 2015, 1:01 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1379
> https://issues.apache.org/jira/browse/AURORA-1379
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The idea of this change is to avoid displacing the top-level record in the 
> `host_attributes` table when mutating, but instead mutate specific fields.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/AttributeMapper.java 
> 3763f4dbd1b83b83c4b19a89784343ef9de100f1 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 
> 5f1cd2b7daec40a8a57095e16390698dbb0bcd24 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 
> d36b42a22ebf9bbe52e60fea9b8a2677c41bd598 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
>  db508cace922b20a19081a1d918cc082b255cd02 
> 
> Diff: https://reviews.apache.org/r/36096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 36490: wip

2015-07-14 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Use Provider> instead of @Nullable Provider.


Diffs
-

  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
f547c4485eab97e4fe149eec9fa73af3ce807748 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
 a3b0a6bd573f04ff275a54b16f0ab5ebf139868e 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
63917363f392e6d970fb7e0cb91b840ca5db173e 
  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
6e4a294d6ca7ffd3a733498211e66ad674ef0b39 

Diff: https://reviews.apache.org/r/36490/diff/


Testing
---

./gradlew build


Thanks,

Kevin Sweeney

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

2015-07-14 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/
---

(Updated July 14, 2015, 4:48 p.m.)


Review request for Aurora and Bill Farner.


Summary (updated)
-

Use Provider> instead of optional injection for Shiro audit 
logging.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description (updated)
---

Use injection of an optional value instead of optional injection.


Diffs
-

  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
f547c4485eab97e4fe149eec9fa73af3ce807748 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
 a3b0a6bd573f04ff275a54b16f0ab5ebf139868e 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
63917363f392e6d970fb7e0cb91b840ca5db173e 
  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
6e4a294d6ca7ffd3a733498211e66ad674ef0b39 

Diff: https://reviews.apache.org/r/36490/diff/


Testing
---

./gradlew build


Thanks,

Kevin Sweeney

Review Request 36492: Use aurora.local as hostname.

2015-07-14 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36492/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Use aurora.local as hostname.


Diffs
-

  examples/vagrant/provision-dev-cluster.sh 
853ccac35f2befa31716a9ed686df650cd913c90 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
85052ac8e4dde85fbcd85ce839d0647f5632d74b 
  examples/vagrant/upstart/aurora-scheduler.conf 
1c2390f0248e91e65a548e67f6af1be8d2526b0a 

Diff: https://reviews.apache.org/r/36492/diff/


Testing
---

end-to-end test gets past service discovery errors.


Thanks,

Kevin Sweeney

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

2015-07-14 Thread Kevin Sweeney



> On July 14, 2015, 4:52 p.m., Aurora ReviewBot wrote:
> > Master (d9dac92) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > :api:classesThriftEntities
> > :api:compileJava UP-TO-DATE
> > :api:generateThriftResources
> > :api:processResources UP-TO-DATE
> > :api:classes
> > :api:jar
> > :compileJavaNote: Writing 
> > file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java:136:
> >  error: incompatible types: no instance(s) of type variable(s) T exist so 
> > that Optional conforms to ? extends Optional
> >   bind(new TypeLiteral>() 
> > {}).toProvider(Optional::empty);
> >^
> >   where T is a type-variable:
> > T extends Object declared in method empty()
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java:143:
> >  error: no suitable method found for toProvider(SecurityUt[...]bject)
> > 
> > bind(Subject.class).toProvider(SecurityUtils::getSubject).in(RequestScoped.class);
> >^
> > method LinkedBindingBuilder.toProvider(com.google.inject.Provider > extends Subject>) is not applicable
> >   (argument mismatch; bad return type in method reference
> >   Subject cannot be converted to ? extends Subject)
> > method LinkedBindingBuilder.toProvider(Class > javax.inject.Provider>) is not applicable
> >   (argument mismatch; Class is not a functional interface)
> > method LinkedBindingBuilder.toProvider(TypeLiteral > javax.inject.Provider>) is not applicable
> >   (argument mismatch; TypeLiteral is not a functional interface)
> > method LinkedBindingBuilder.toProvider(Key > javax.inject.Provider>) is not applicable
> >   (argument mismatch; Key is not a functional interface)
> > Note: Some messages have been simplified; recompile with -Xdiags:verbose to 
> > get full output
> > 2 errors
> >  FAILED
> > 
> > FAILURE: Build failed with an exception.
> > 
> > * What went wrong:
> > Execution failed for task ':compileJava'.
> > > Compilation failed; see the compiler error output for details.
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or 
> > --debug option to get more log output.
> > 
> > BUILD FAILED
> > 
> > Total time: 1 mins 33.58 secs
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

This looks like: https://bugs.openjdk.java.net/browse/JDK-8051402


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/#review91683
---


On July 14, 2015, 4:48 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36490/
> ---
> 
> (Updated July 14, 2015, 4:48 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1352
> https://issues.apache.org/jira/browse/AURORA-1352
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use injection of an optional value instead of optional injection.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> f547c4485eab97e4fe149eec9fa73af3ce807748 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  a3b0a6bd573f04ff275a54b16f0ab5ebf139868e 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
> 63917363f392e6d970fb7e0cb91b840ca5db173e 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
> 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 
> 
> Diff: https://reviews.apache.org/r/36490/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

2015-07-14 Thread Kevin Sweeney



> On July 14, 2015, 4:52 p.m., Aurora ReviewBot wrote:
> > Master (d9dac92) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > :api:classesThriftEntities
> > :api:compileJava UP-TO-DATE
> > :api:generateThriftResources
> > :api:processResources UP-TO-DATE
> > :api:classes
> > :api:jar
> > :compileJavaNote: Writing 
> > file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java:136:
> >  error: incompatible types: no instance(s) of type variable(s) T exist so 
> > that Optional conforms to ? extends Optional
> >   bind(new TypeLiteral>() 
> > {}).toProvider(Optional::empty);
> >^
> >   where T is a type-variable:
> > T extends Object declared in method empty()
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java:143:
> >  error: no suitable method found for toProvider(SecurityUt[...]bject)
> > 
> > bind(Subject.class).toProvider(SecurityUtils::getSubject).in(RequestScoped.class);
> >^
> > method LinkedBindingBuilder.toProvider(com.google.inject.Provider > extends Subject>) is not applicable
> >   (argument mismatch; bad return type in method reference
> >   Subject cannot be converted to ? extends Subject)
> > method LinkedBindingBuilder.toProvider(Class > javax.inject.Provider>) is not applicable
> >   (argument mismatch; Class is not a functional interface)
> > method LinkedBindingBuilder.toProvider(TypeLiteral > javax.inject.Provider>) is not applicable
> >   (argument mismatch; TypeLiteral is not a functional interface)
> > method LinkedBindingBuilder.toProvider(Key > javax.inject.Provider>) is not applicable
> >   (argument mismatch; Key is not a functional interface)
> > Note: Some messages have been simplified; recompile with -Xdiags:verbose to 
> > get full output
> > 2 errors
> >  FAILED
> > 
> > FAILURE: Build failed with an exception.
> > 
> > * What went wrong:
> > Execution failed for task ':compileJava'.
> > > Compilation failed; see the compiler error output for details.
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or 
> > --debug option to get more log output.
> > 
> > BUILD FAILED
> > 
> > Total time: 1 mins 33.58 secs
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"
> 
> Kevin Sweeney wrote:
> This looks like: https://bugs.openjdk.java.net/browse/JDK-8051402

We should investigate using docker run for our CI so that we can be assured we 
have the same versions everywhere.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/#review91683
---


On July 14, 2015, 4:48 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36490/
> ---
> 
> (Updated July 14, 2015, 4:48 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1352
> https://issues.apache.org/jira/browse/AURORA-1352
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use injection of an optional value instead of optional injection.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> f547c4485eab97e4fe149eec9fa73af3ce807748 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  a3b0a6bd573f04ff275a54b16f0ab5ebf139868e 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
> 63917363f392e6d970fb7e0cb91b840ca5db173e 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
> 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 
> 
> Diff: https://reviews.apache.org/r/36490/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

2015-07-15 Thread Kevin Sweeney



> On July 15, 2015, 8:27 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java,
> >  lines 143-155
> > <https://reviews.apache.org/r/36490/diff/1/?file=1011891#file1011891line143>
> >
> > Is the `Subject` -> `Optional` layering necessary?  If not, 
> > consider simplifying by skipping the `toProvider` binding and call 
> > `SecurityUtils.getSubject()` in your provider method:
> > 
> > ```
> > @Provides
> > @RequestScoped
> > Optional provideOptionalSubject() {
> >   return Optional.of(SecurityUtils.getSubject());
> > }
> > ```

Classes within the package inject Provider directly (and get to skip 
the null check). Classes outside the package that attempt to do that should 
(and will) fail. This is the same behavior as Guice 4.0 OptionalBinder.


> On July 15, 2015, 8:27 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java,
> >  line 147
> > <https://reviews.apache.org/r/36490/diff/1/?file=1011891#file1011891line147>
> >
> > s/Bindings/Provider/

Fixed.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/#review91745
---


On July 14, 2015, 4:48 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36490/
> ---
> 
> (Updated July 14, 2015, 4:48 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1352
> https://issues.apache.org/jira/browse/AURORA-1352
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use injection of an optional value instead of optional injection.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> f547c4485eab97e4fe149eec9fa73af3ce807748 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  a3b0a6bd573f04ff275a54b16f0ab5ebf139868e 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
> 63917363f392e6d970fb7e0cb91b840ca5db173e 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
> 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 
> 
> Diff: https://reviews.apache.org/r/36490/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

2015-07-15 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/
---

(Updated July 15, 2015, 11:21 a.m.)


Review request for Aurora and Bill Farner.


Changes
---

wfarner's feedback


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Use injection of an optional value instead of optional injection.


Diffs (updated)
-

  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
f547c4485eab97e4fe149eec9fa73af3ce807748 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
 a3b0a6bd573f04ff275a54b16f0ab5ebf139868e 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
63917363f392e6d970fb7e0cb91b840ca5db173e 
  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
6e4a294d6ca7ffd3a733498211e66ad674ef0b39 

Diff: https://reviews.apache.org/r/36490/diff/


Testing
---

./gradlew build


Thanks,

Kevin Sweeney

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

2015-07-15 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/
---

(Updated July 15, 2015, 11:34 a.m.)


Review request for Aurora and Bill Farner.


Changes
---

Fix checkstyle for test sources too.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Use injection of an optional value instead of optional injection.


Diffs (updated)
-

  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
f547c4485eab97e4fe149eec9fa73af3ce807748 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
 a3b0a6bd573f04ff275a54b16f0ab5ebf139868e 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
63917363f392e6d970fb7e0cb91b840ca5db173e 
  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
6e4a294d6ca7ffd3a733498211e66ad674ef0b39 

Diff: https://reviews.apache.org/r/36490/diff/


Testing
---

./gradlew build


Thanks,

Kevin Sweeney

Re: Review Request 36289: Custom executor support for Scheduler

2015-07-15 Thread Kevin Sweeney



> On July 15, 2015, 12:08 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, lines 
> > 87-115
> > 
> >
> > In this change, we cannot remove these arguments as it breaks 
> > compatibility.  In this change, we'll need to synthesize an entry as though 
> > it were read from the json file, and log a big warning about the 
> > deprecation.

Can you elaborate on the compatibility breakage? IMO changing command-line args 
across releases doesn't rise to the level of a compatibility break, as long as 
the change is isolated to a single component. This doesn't change the way the 
scheduler behaves on the network from the perspective of other components. The 
deprecation warning could just as easily be an error, pointing to documentation 
for the new format.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36289/#review91793
---


On July 14, 2015, 6:13 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36289/
> ---
> 
> (Updated July 14, 2015, 6:13 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> What was done:
> ==
> Added support for custom executors in the Scheduler via a config file. 
> Removed command line arguments that were moved over to the config file.
> 
> Future:
> ===
> Extending the client to support custom executors and the mesos-executor.
> 
> Caveats:
> 
> This contains initial config file with support for thermos and limited 
> support for the mesos commandline executor. Mesos-command line executor needs 
> support from the client side in order to function at a better capacity. 
> 
> Currently, this uses the current client to launch both tasks, meaning as long 
> as the client sends a thrift call, the scheduler will schedule a task, be it 
> a mesos-command task with a preconfigured command temporarily set in the 
> config file or a custom executor task. 
> 
> *Support for custom executors in the client must be added in order to fully 
> utilize this feature.*
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 85052ac8e4dde85fbcd85ce839d0647f5632d74b 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f261c8dcc760151d5a41a986d867585c3a544123 
>   src/dist/etc/executors.json PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 554a380bdb4ef69561259cdbfbc361694041571e 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
> 325f55640648151ae19e0c18c6961aeff10bfac3 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> c0d165ad34e46653dad95918e0058ebd3f2ee57f 
>   
> src/test/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoaderTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 23c2693f1dfd589043c60ab22e302fb81e62335d 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
> ebd81775c5c9f0ef5c309869df1d12dca3ddbdd7 
>   
> src/test/resources/org/apache/aurora/scheduler/app/executor-settings-example.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36289/diff/
> 
> 
> Testing
> ---
> 
> Ran jenkins build test, passed all tests, code style checks, findbugs check, 
> and PMD.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Review Request 36526: Use HTTPS for Twitter Maven repository.

2015-07-15 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36526/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Use HTTPS for Twitter Maven repository.


Diffs
-

  build.gradle 87a809f0fd0ee63cae84cc0269dfa5431b7e893f 

Diff: https://reviews.apache.org/r/36526/diff/


Testing
---

rm -fr ~/.gradle/caches
./gradlew assemble


Thanks,

Kevin Sweeney

Re: Review Request 36561: Use the application-level storage lock to prevent DB-level deadlock when GCing rows.

2015-07-16 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36561/#review91990
---



src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java (line 120)
<https://reviews.apache.org/r/36561/#comment145782>

Can this be sent to slf4j instead? From 
http://www.h2database.com/html/features.html#trace_options it looks like this 
can be done with TRACE_LEVEL_FILE=4



src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java 
(line 92)
<https://reviews.apache.org/r/36561/#comment145788>

`deletedCount.get()`

Or just move `deletedCount` and this log statement into the work block


- Kevin Sweeney


On July 16, 2015, 4:44 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36561/
> ---
> 
> (Updated July 16, 2015, 4:44 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1401
> https://issues.apache.org/jira/browse/AURORA-1401
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use the application-level storage lock to prevent DB-level deadlock when 
> GCing rows.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 0b76caf717b6b7c36fcbbd41eb2adcac0cc0736b 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java 
> ba7c677039270a1e1b413b50ee7091697ea543a6 
>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
> 1597725ef67b98fb48569c0c3f36bea502ec6daf 
> 
> Diff: https://reviews.apache.org/r/36561/diff/
> 
> 
> Testing
> ---
> 
> Tried to explore options for repeatably reproducing this in a test case, but 
> came up with nothing.  With the lock mode we currently use (READ 
> UNCOMMITTED), i believe there is no way to acquire a lock and hold it after a 
> statement finishes executing.  This means that only joins are susceptible to 
> deadlock, which would be ~impossible to reproduce repeatably.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36561: Use the application-level storage lock to prevent DB-level deadlock when GCing rows.

2015-07-16 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36561/#review91995
---

Ship it!


Ship It!

- Kevin Sweeney


On July 16, 2015, 4:59 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36561/
> ---
> 
> (Updated July 16, 2015, 4:59 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1401
> https://issues.apache.org/jira/browse/AURORA-1401
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use the application-level storage lock to prevent DB-level deadlock when 
> GCing rows.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 0b76caf717b6b7c36fcbbd41eb2adcac0cc0736b 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java 
> ba7c677039270a1e1b413b50ee7091697ea543a6 
>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
> 1597725ef67b98fb48569c0c3f36bea502ec6daf 
> 
> Diff: https://reviews.apache.org/r/36561/diff/
> 
> 
> Testing
> ---
> 
> Tried to explore options for repeatably reproducing this in a test case, but 
> came up with nothing.  With the lock mode we currently use (READ 
> UNCOMMITTED), i believe there is no way to acquire a lock and hold it after a 
> statement finishes executing.  This means that only joins are susceptible to 
> deadlock, which would be ~impossible to reproduce repeatably.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 36703: Remove unnecessary uses of Guava Joiner.

2015-07-22 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36703/
---

Review request for Aurora, Joshua Cohen and Bill Farner.


Repository: aurora


Description
---

Remove unnecessary use of Guava Joiner.

This replaces a Guava-ism with the JDK8 standard library APIs. Most of the 
changes to use `String::join` instead of `Joiner.on(...).join(...)` should be 
noncontroversial; however in some cases the resulting code is more verbose. 
This is mostly due to the fact that the standard library requires that 
arguments be instances of `CharSequence`, requiring the caller to map over 
`Object::toString`. I'd argue minimizing use of Guava-isms when a standard lib 
alternative exists is preferable in these cases but don't feel strongly about 
it.

There are also some opportunistic changes to surrounding code to use lambdas, 
method references, and the standard `Streams` API instead of `FluentIterable` 
and `Ordering`.

`Joiner` is still used in its `withKeyValueSeparator` form, as no standard 
library alternative exists for it.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java 
2b7613741a729e7065bbe74690d543b45802c400 
  src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 
b4163435ea337a9976fae2f84850af0320ab9884 
  src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
a5ffa5e95b301e536a84acf02817ea0c080559d0 
  src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 
904dd72dbb9036d8c06353a953bf35b8f04cfdbc 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 
45e062d3acbd7b8565bd3773c1e994aae96378e0 
  src/main/java/org/apache/aurora/scheduler/http/CorsFilter.java 
e413ad9bdccc329777b3d0764ba8684539956679 
  src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
b64e18c4d5278e6cdb2e480043a45e6ec4f87484 
  src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
63c31eeb293771b6cc0a3e4cc62dd3a94853e727 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java 
ff8063c050e13b4bffda2661a817fdc023b80867 
  src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
7232f603e21bbc9dbb5e05aedd5e493de519158e 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
92c970c34ca9dc4f052760e5a3d3770a089d9a67 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
7c8f8b9b8d7deb082edc0f85a6d3da1536735545 

Diff: https://reviews.apache.org/r/36703/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 36666: Break apart async package and AsyncModule into purpose-specific equivalents.

2015-07-22 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3/#review92636
---

Ship it!


Ship It!

- Kevin Sweeney


On July 21, 2015, 4:51 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3/
> ---
> 
> (Updated July 21, 2015, 4:51 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've found myself wanting to split this multi-purpose package and module for 
> a while now.  Doing so in prep of addressing AURORA-1395 with a new 
> [Scheduled]ExecutorService facade.
> 
> This splits the contents of `org.apache.aurora.scheduler.async` into 4 
> packages under org.apache.aurora.scheduler:
> **offers**
> OfferManager
> RandomJitterReturnDelay
> 
> **preemptor**
> BiCache
> ClusterState[Impl]
> PendingTaskProcessor
> PreemptionProposal
> PreemptionVictim[Filter]
> Preemptor
> PreemptorMetrics
> 
> **pruning**
> TaskHistoryPruner
> JobUpdateHistoryPruner
> 
> **reconciliation**
> KillRetry
> TaskReconciler
> TaskTimeout
> 
> **scheduling**
> RescheduleCalculator
> TaskGroup[s]
> TaskScheduler
> TaskThrottler
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/Offers.java 
> b8e6cb574a76f5105bea2216bcfcc48db0c2ba92 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> d9e5199862f9328ba812e54f231f1c9a43d54c24 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> e08d16ed3260ca5c0d617a66d288ac928432a8df 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 
> 45849b52ce85dd8eb1f28d4ab0386d2eafd9209d 
>   
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java 
> 6d710128a2723dc9d39bb2d0ca7544d10739a6c8 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> 1a158b4e0be94762ad0480e8ce74b19bacc90c97 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> d2c172074092cd6e625a02646c9f12e37538b40b 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8c2d7512e58d34952d3c74d488c2bd5d4ea0d452 
>   src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 
> b4163435ea337a9976fae2f84850af0320ab9884 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
> b125c1c81309c521219f856c21a590f6e574c31c 
>   src/main/java/org/apache/aurora/scheduler/async/OfferManager.java 
> e60d01ed2de2a51dea3adb2682fe480fc623e002 
>   
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 
> 6a8c96791b21e1d8a91d5f4ada71486f81d3e275 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> 6a0c0a9b933546c1581d3e29ba53eb86c58fbc39 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java 
> 635419b2558f646cd46650013d9582e9f404582c 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> 1580404a36bbab6b612b8188c4a649d4a77118e0 
>   src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
> 7b6c0639fba6a322529f17c9a69c3b28ea7d2432 
>   src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 
> 68d2e77f198df31faa16bb85bd8333ed0dd3aa66 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> a500e55cb52fe89917d8499a42e2a2eb5032c109 
>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
> c8f2005eec87506d1133ab618ffa6195f074480f 
>   src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 
> e250f3330504c3c3737564174ecc2943cb7dd93b 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
> 382099f47b132065c159111754b91511e4b3fba1 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 
> 38610b21c5404dfcd938a2541c0f407a8fd259d2 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java
>  d7a0c54d4dc3434359e5d4618835a2d2730d23f0 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
>  1f1eb4c1f2f2b995d616b70ba9e3d149eea413d0 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionProposal.java
>  7a03168ab6997a9ad13ec3692249a2ac75f89bd6 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictim.java
>  f196b212d2b2562e941100d17364b2442bce058f 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVi

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-22 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36700/#review92639
---



build-support/packaging/debian/rules (line 37)
<https://reviews.apache.org/r/36700/#comment146861>

Can you delete the code these targets reference as well, as presumably 
there are now source files without BUILD file owners in our tree


- Kevin Sweeney


On July 22, 2015, 11:50 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36700/
> ---
> 
> (Updated July 22, 2015, 11:50 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The meaning of the targets under 
> `src/main/python/apache/thermos/cli/bin/BUILD` and 
> `src/main/python/apache/thermos/observer/bin/BUILD` changed recently, which 
> bit several people (including our own packaging).  This removes targets that 
> Aurora users should not be consuming.
> 
> 
> Diffs
> -
> 
>   build-support/packaging/debian/rules 
> 23828c02b73f007393d2ed4ce69c010cebf07e57 
>   build-support/packaging/rpm/aurora.spec 
> 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 
>   src/main/python/apache/thermos/BUILD 
> 8221aa0bd4efe5f519550cba716d6a564ba9ae44 
>   src/main/python/apache/thermos/cli/bin/BUILD 
> f33c7f838a6a0932abc737d0ecf7ca3a59580e2e 
>   src/main/python/apache/thermos/observer/BUILD 
> 41db2cc2e11234c434f58f55abec0b9f308096be 
>   src/main/python/apache/thermos/observer/bin/BUILD 
> 0abe2ccfe9c5ccb509ad731125385900114ba352 
> 
> Diff: https://reviews.apache.org/r/36700/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36703: Replace Guava Joiner with String::join where simpler

2015-07-22 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36703/
---

(Updated July 22, 2015, 3:08 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Review feedback.


Summary (updated)
-

Replace Guava Joiner with String::join where simpler


Repository: aurora


Description (updated)
---

Now that `String::join` is part of the standard library some uses of Guava's 
`Joiner` can be removed.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
a5ffa5e95b301e536a84acf02817ea0c080559d0 
  src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 
904dd72dbb9036d8c06353a953bf35b8f04cfdbc 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 
45e062d3acbd7b8565bd3773c1e994aae96378e0 
  src/main/java/org/apache/aurora/scheduler/http/CorsFilter.java 
e413ad9bdccc329777b3d0764ba8684539956679 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
7c8f8b9b8d7deb082edc0f85a6d3da1536735545 

Diff: https://reviews.apache.org/r/36703/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Review Request 36709: Remove generated FROM_BUILDER and TO_BUILDER methods.

2015-07-22 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36709/
---

Review request for Aurora, Joshua Cohen and Bill Farner.


Repository: aurora


Description
---

Remove generated FROM_BUILDER and TO_BUILDER methods.

With method references in Java 8 these are no longer needed. Method references 
have the additional advantage that they can be used in functions that take 
either `com.google.common.base.Function` or `java.util.function.Function` (or 
any other functional interface).


Diffs
-

  src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
05434f8bfdd8165ab8a333b15301e1f0f46578dd 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
 a95e1ecff92fb1e192baaa1edda1c0c837aabe0a 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 
1b274c8f1cc534aea65a1eecc05b3c9e85e35409 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbQuotaStore.java 
9371907374ffaf1082d8e9d224260d9a67ae1fb7 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
f3d92884dc1d35d576bbe84f70be6e46278444ed 
  
src/test/java/org/apache/aurora/scheduler/storage/entities/IHostAttributesTest.java
 05b31c2f75da9df53ab66007a1e907900ed90cd0 

Diff: https://reviews.apache.org/r/36709/diff/


Testing
---

./gradlew -Pq clean build


Thanks,

Kevin Sweeney

Re: Review Request 36709: Remove generated FROM_BUILDER and TO_BUILDER methods.

2015-07-22 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36709/
---

(Updated July 22, 2015, 3:51 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

rebase


Repository: aurora


Description
---

Remove generated FROM_BUILDER and TO_BUILDER methods.

With method references in Java 8 these are no longer needed. Method references 
have the additional advantage that they can be used in functions that take 
either `com.google.common.base.Function` or `java.util.function.Function` (or 
any other functional interface).


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
05434f8bfdd8165ab8a333b15301e1f0f46578dd 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
 a95e1ecff92fb1e192baaa1edda1c0c837aabe0a 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 
1b274c8f1cc534aea65a1eecc05b3c9e85e35409 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbQuotaStore.java 
9371907374ffaf1082d8e9d224260d9a67ae1fb7 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
f3d92884dc1d35d576bbe84f70be6e46278444ed 
  
src/test/java/org/apache/aurora/scheduler/storage/entities/IHostAttributesTest.java
 05b31c2f75da9df53ab66007a1e907900ed90cd0 

Diff: https://reviews.apache.org/r/36709/diff/


Testing
---

./gradlew -Pq clean build


Thanks,

Kevin Sweeney

Review Request 36711: Remove all public static com.google.common.base.Functions

2015-07-22 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36711/
---

Review request for Aurora, Bill Farner and Zameer Manji.


Repository: aurora


Description
---

Remove all public static com.google.common.base.Functions

This change removes all public static Functions and either replaces them with 
static methods or inlines them (if they could have been replaced by method 
references). The benefit of this change is that these library functions are now 
usable as `com.google.common.base.Function`s (in the case of guava methods), 
`java.util.function.Function`s (in the case of the Java 8 standard library), 
and directly (by callers that were previously invoking them via `.apply`).

This change was almost entirely IDE-driven, with the exception of the direct 
calls (IntelliJ inlines `Tasks.ASSIGNED_TO_ID.apply(assignedTask)` as 
`((Functionhttps://reviews.apache.org/r/36711/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Review Request 36713: Make Storage.Work an interface instead of an abstract class.

2015-07-22 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36713/
---

Review request for Aurora, Bill Farner and Zameer Manji.


Repository: aurora


Description
---

Make `Storage.Work` and friends interfaces instead of abstract classes.

This allows you to pass lambdas and method references to calls to 
`storage.work`. The main ripple is that as interface methods, `apply` and 
`execute` must be public. This was done programmatically with a sed script.


Diffs
-

  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
5716f23e7a3e4179624c3dddc6e3350a7074b4d8 
  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
3931d02810137c0b397a315323ef60c5fd2f191f 
  src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
c3f8b251d80d86323e364c978e77b5615d1f9f65 
  src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
cc4274103a8b4577fcbbbceac6d38496bac0c5cd 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
32751896b43e7b0e92b1b9166f7606ab816425ef 
  src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
ede8517ff2bf989bd091aca97e2a667c5c61d1f5 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
a33bb8ba7e70fd4a9bc3ad0f6f8c6ae661e65367 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
0081c5c95f8079a218078d62f47cf2d6f7a259c0 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
7c8a00809365b5d9f28acf9832147bbbdbbc2b48 
  src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 
ef88d98f621fc8a2320cadf66182e0dca8d2b97b 
  src/main/java/org/apache/aurora/scheduler/scheduling/TaskThrottler.java 
b86bd281082b37d415237009db0bdae7eb29a570 
  
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
 64aa10d15fb2caa8d5be08ed2b57cd2f6e7e1aa2 
  src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
21f6a642df48b66614e210be4a9a99d3cd823501 
  src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
fb0dbaec0f4cbd1ad12b808d795299b736552c6b 
  
src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 
d0156d330deb5d862fa54513fdbb6561d1c91548 
  src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java 
f1916a874798fa14faf588a8def02618a6ede698 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
82be3670338bfd976cf4ea0d93632c93703da016 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
64b5b9548506b25fecce5113341f25b35b0f0e47 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
22786dedd0db014f518eb5701a985559d189adad 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
ff067013f9b634506dbd7cbd015f9e129831e72a 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 
7894668854ff4fae68168719dce2790916c6b548 
  
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java
 b8d88c7e299aebaea5e6ed5ae91d70cc8461ed32 
  
src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 
25d8da67a3f8fe3d8b385932743a3d34dec4d25e 
  src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerTest.java 
52af3642eb64a8895a625539d7c5b29ac9d6aad4 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
262f6686ff4c4c4aa7e32ad026c65f813d15c8c5 
  src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java 
ed834bce2f1502605a8ef83d2812eea184bcc0a9 
  
src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 
c7329c93329811daa6341d6cd0e08de6d347671a 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
775bb71f94582020643c12fd19a15d0d6732c699 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
a76ae48fc63dfeff24c733507dd6bcac30ef2629 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 
a7de023249dc2f84eee9798d02181f6c52414547 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 
15a95897aff0a414c0087140a09e12ee3d67ace7 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
eabce167191b77cb7f44055f1b0edfc74dfdcf5a 
  src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 
77efffb3a89d8ae54e7e0e4879c5dda2a6d9b4c8 
  
src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java
 4ae194c4f86b609729cfdfdaeda369733efae0b2 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
f5e1dd0ad205bd6e87b660cc7849a0bd92c787a7 

Diff: https://reviews.apache.org/r/36713/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 36710: Add an executor service decorator that gates async operations.

2015-07-22 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36710/#review92685
---



src/main/java/org/apache/aurora/scheduler/async/GatedScheduledExecutorService.java
 (line 36)
<https://reviews.apache.org/r/36710/#comment146913>

Consider extending 
http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/util/concurrent/ForwardingListeningExecutorService.html
 instead, for the reasons outlined in 
https://code.google.com/p/guava-libraries/wiki/ListenableFutureExplained


- Kevin Sweeney


On July 22, 2015, 5:07 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36710/
> ---
> 
> (Updated July 22, 2015, 5:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1395
> https://issues.apache.org/jira/browse/AURORA-1395
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This will be used by the rest of the system to manage deferment of work until 
> a transaction has completed.
> 
> TODO(wfarner): I need to document the newly-added interfaces, please assume i 
> will add that shortly.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/DeferredWork.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/FlushableWorkQueue.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/async/GatedScheduledExecutorService.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/TimeDeferredWork.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> c85979dedd0ef2c515453a33c9a36d52865eb548 
>   
> src/test/java/org/apache/aurora/scheduler/async/GatedScheduledExecutorServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36710/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36710: Add an executor service decorator that gates async operations.

2015-07-22 Thread Kevin Sweeney



> On July 22, 2015, 5:11 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/async/GatedScheduledExecutorService.java,
> >  line 36
> > <https://reviews.apache.org/r/36710/diff/1/?file=1019150#file1019150line36>
> >
> > Consider extending 
> > http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/util/concurrent/ForwardingListeningExecutorService.html
> >  instead, for the reasons outlined in 
> > https://code.google.com/p/guava-libraries/wiki/ListenableFutureExplained
> 
> Bill Farner wrote:
> As you may not have noticed, i am returning `null` from all 
> Future-providing methods since we never actually use the return values (and 
> it would add complexity to support Futures).  If we go this route, the 
> richness of listenable futures is moot.

Is maintaining the ExecutorService interface necessary for some call sites you 
intend to replace? Would it be reasonable make this a new interface without the 
partial implementation?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36710/#review92685
---


On July 22, 2015, 5:07 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36710/
> -------
> 
> (Updated July 22, 2015, 5:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1395
> https://issues.apache.org/jira/browse/AURORA-1395
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This will be used by the rest of the system to manage deferment of work until 
> a transaction has completed.
> 
> TODO(wfarner): I need to document the newly-added interfaces, please assume i 
> will add that shortly.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/DeferredWork.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/FlushableWorkQueue.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/async/GatedScheduledExecutorService.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/TimeDeferredWork.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> c85979dedd0ef2c515453a33c9a36d52865eb548 
>   
> src/test/java/org/apache/aurora/scheduler/async/GatedScheduledExecutorServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36710/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36713: Make Storage.Work an interface instead of an abstract class.

2015-07-22 Thread Kevin Sweeney



> On July 22, 2015, 5:52 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/Storage.java, line 136
> > <https://reviews.apache.org/r/36713/diff/1/?file=1019274#file1019274line136>
> >
> > Unsure if making this non final is desired.

It's a limitation of interfaces due to backwards-compatibility - they can't 
impose restrictions on their implementers. In practice I don't think this is 
likely to be a problem as writing out `Void apply` is ugly and should trigger a 
code smell warning.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36713/#review92694
-----------


On July 22, 2015, 5:07 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36713/
> ---
> 
> (Updated July 22, 2015, 5:07 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make `Storage.Work` and friends interfaces instead of abstract classes.
> 
> This allows you to pass lambdas and method references to calls to 
> `storage.work`. The main ripple is that as interface methods, `apply` and 
> `execute` must be public. This was done programmatically with a sed script.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 5716f23e7a3e4179624c3dddc6e3350a7074b4d8 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 3931d02810137c0b397a315323ef60c5fd2f191f 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
> c3f8b251d80d86323e364c978e77b5615d1f9f65 
>   src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
> cc4274103a8b4577fcbbbceac6d38496bac0c5cd 
>   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
> 32751896b43e7b0e92b1b9166f7606ab816425ef 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
> ede8517ff2bf989bd091aca97e2a667c5c61d1f5 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> a33bb8ba7e70fd4a9bc3ad0f6f8c6ae661e65367 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 0081c5c95f8079a218078d62f47cf2d6f7a259c0 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 7c8a00809365b5d9f28acf9832147bbbdbbc2b48 
>   src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 
> ef88d98f621fc8a2320cadf66182e0dca8d2b97b 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskThrottler.java 
> b86bd281082b37d415237009db0bdae7eb29a570 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  64aa10d15fb2caa8d5be08ed2b57cd2f6e7e1aa2 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 21f6a642df48b66614e210be4a9a99d3cd823501 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> fb0dbaec0f4cbd1ad12b808d795299b736552c6b 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  d0156d330deb5d862fa54513fdbb6561d1c91548 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java 
> f1916a874798fa14faf588a8def02618a6ede698 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 82be3670338bfd976cf4ea0d93632c93703da016 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 64b5b9548506b25fecce5113341f25b35b0f0e47 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  22786dedd0db014f518eb5701a985559d189adad 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  ff067013f9b634506dbd7cbd015f9e129831e72a 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 
> 7894668854ff4fae68168719dce2790916c6b548 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java
>  b8d88c7e299aebaea5e6ed5ae91d70cc8461ed32 
>   
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java
>  25d8da67a3f8fe3d8b385932743a3d34dec4d25e 
>   src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerTest.java 
> 52af3642eb64a8895a625539d7c5b29ac9d6aad4 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 262f6686ff4c4c4aa7e32ad026c65f813d15c8c5 
>   src/test/java/org/

Re: Review Request 36711: Remove all public static com.google.common.base.Functions

2015-07-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36711/
---

(Updated July 23, 2015, 12:07 a.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

rebase


Repository: aurora


Description
---

Remove all public static com.google.common.base.Functions

This change removes all public static Functions and either replaces them with 
static methods or inlines them (if they could have been replaced by method 
references). The benefit of this change is that these library functions are now 
usable as `com.google.common.base.Function`s (in the case of guava methods), 
`java.util.function.Function`s (in the case of the Java 8 standard library), 
and directly (by callers that were previously invoking them via `.apply`).

This change was almost entirely IDE-driven, with the exception of the direct 
calls (IntelliJ inlines `Tasks.ASSIGNED_TO_ID.apply(assignedTask)` as 
`((Functionhttps://reviews.apache.org/r/36711/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 36735: Model DockerParameter in the database.

2015-07-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36735/#review92781
---

Ship it!


Ship It!

- Kevin Sweeney


On July 23, 2015, 10:57 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36735/
> ---
> 
> (Updated July 23, 2015, 10:57 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1407
> https://issues.apache.org/jira/browse/AURORA-1407
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Model DockerParameter in the database.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> c16aa4ccaf021f9da1f02fe2718e6c3a1dc63142 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> 30a258aae69efc5ddb21cdfc06e85d19f0a19cd6 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 48f19045885d82e8fb702949b3e64e86e97a6a8b 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  bbd67133ef19255e80d7910bac922020d1b917ba 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 52494afbb00e799e58ed9d76de56b70767ed0fda 
>   
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java
>  0bde4d8bab3a2ad09e53d024dd5c76b7fcbf3083 
> 
> Diff: https://reviews.apache.org/r/36735/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36745: Turn off strict host key checking for all hosts in vagrant.

2015-07-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36745/#review92857
---

Ship it!


Ship It!

- Kevin Sweeney


On July 23, 2015, 2:36 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36745/
> ---
> 
> (Updated July 23, 2015, 2:36 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1406
> https://issues.apache.org/jira/browse/AURORA-1406
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Turn off strict host key checking for all hosts in vagrant.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/provision-dev-cluster.sh 
> 06e32f19aa8d87f3e6ab1813834a5daa7769a91b 
> 
> Diff: https://reviews.apache.org/r/36745/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Kevin Sweeney



> On July 24, 2015, 10:57 a.m., Brian Wickman wrote:
> > src/main/python/apache/thermos/observer/BUILD, line 74
> > <https://reviews.apache.org/r/36700/diff/2/?file=1020365#file1020365line74>
> >
> > This puts an aurora dependency on thermos and I imagine causes a cycle 
> > in the build graph (pants may just silently ignore it.)
> > 
> > Let's just remove the thermos_observer entry point from this package 
> > entirely by deleting the .with_binaries clause.
> 
> Bill Farner wrote:
> This target (`src/main/python/apache/thermos/observer`) is a top-level 
> target, only used by `build-support/release/make-python-sdists`, so i think 
> we're safe from a cycle.  I'm not strictly against removing the 
> `with_binaries`, but i assume it is there for a reason and something would 
> break?  Or do we just not use the sdists [this way]?
> 
> Brian Wickman wrote:
> Afaik nobody uses these in practice.  They're only useful for when you 
> install the sdists via pip or pex directly.  Instead we always build pex 
> binaries using pants which delegates to the python_binary target.

I answered someone's question in IRC with a gist ~2yrs ago 
https://gist.github.com/kevints/8361414 so it does seem likely these are used 
in practice. Okay with removing them but a NEWS entry would be good form.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36700/#review92944
---


On July 23, 2015, 5 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36700/
> -------
> 
> (Updated July 23, 2015, 5 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The meaning of the targets under 
> `src/main/python/apache/thermos/cli/bin/BUILD` and 
> `src/main/python/apache/thermos/observer/bin/BUILD` changed recently, which 
> bit several people (including our own packaging).  This removes targets that 
> Aurora users should not be consuming.
> 
> 
> Diffs
> -
> 
>   build-support/packaging/debian/rules 
> 23828c02b73f007393d2ed4ce69c010cebf07e57 
>   build-support/packaging/rpm/aurora.spec 
> 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 
>   src/main/python/apache/thermos/BUILD 
> 8221aa0bd4efe5f519550cba716d6a564ba9ae44 
>   src/main/python/apache/thermos/cli/bin/BUILD 
> f33c7f838a6a0932abc737d0ecf7ca3a59580e2e 
>   src/main/python/apache/thermos/cli/bin/thermos.py 
> fcef38d33e7ca2005f35c3bdb90ffee6aeade3af 
>   src/main/python/apache/thermos/observer/BUILD 
> 41db2cc2e11234c434f58f55abec0b9f308096be 
>   src/main/python/apache/thermos/observer/bin/BUILD 
> 0abe2ccfe9c5ccb509ad731125385900114ba352 
>   src/main/python/apache/thermos/observer/bin/thermos_observer.py 
> 39d3994a6163746e853cd21fc4c3585edc2b54cb 
> 
> Diff: https://reviews.apache.org/r/36700/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> (as far as it currently gets on master, anyhow, due to AURORA-1409)
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Kevin Sweeney

Me too, but I'm okay with killing the sdist targets as an intermediate step
and reintroducing them with a non-pants build

On Friday, July 24, 2015, Brian Wickman  wrote:

>
>
> > On July 24, 2015, 5:57 p.m., Brian Wickman wrote:
> > > src/main/python/apache/thermos/observer/BUILD, line 74
> > > <
> https://reviews.apache.org/r/36700/diff/2/?file=1020365#file1020365line74>
> > >
> > > This puts an aurora dependency on thermos and I imagine causes a
> cycle in the build graph (pants may just silently ignore it.)
> > >
> > > Let's just remove the thermos_observer entry point from this
> package entirely by deleting the .with_binaries clause.
> >
> > Bill Farner wrote:
> > This target (`src/main/python/apache/thermos/observer`) is a
> top-level target, only used by `build-support/release/make-python-sdists`,
> so i think we're safe from a cycle.  I'm not strictly against removing the
> `with_binaries`, but i assume it is there for a reason and something would
> break?  Or do we just not use the sdists [this way]?
> >
> > Brian Wickman wrote:
> > Afaik nobody uses these in practice.  They're only useful for when
> you install the sdists via pip or pex directly.  Instead we always build
> pex binaries using pants which delegates to the python_binary target.
> >
> > Kevin Sweeney wrote:
> > I answered someone's question in IRC with a gist ~2yrs ago
> https://gist.github.com/kevints/8361414 so it does seem likely these are
> used in practice. Okay with removing them but a NEWS entry would be good
> form.
> >
> > Bill Farner wrote:
> > Should i just kill the sdists entirely?
>
> I'd prefer to go in the opposite direction and kill pants.
>
>
> - Brian
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36700/#review92944
> ---
>
>
> On July 24, 2015, midnight, Bill Farner wrote:
> >
> > -------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/36700/
> > ---
> >
> > (Updated July 24, 2015, midnight)
> >
> >
> > Review request for Aurora, Kevin Sweeney and Brian Wickman.
> >
> >
> > Bugs: AURORA-1381
> > https://issues.apache.org/jira/browse/AURORA-1381
> >
> >
> > Repository: aurora
> >
> >
> > Description
> > ---
> >
> > The meaning of the targets under
> `src/main/python/apache/thermos/cli/bin/BUILD` and
> `src/main/python/apache/thermos/observer/bin/BUILD` changed recently, which
> bit several people (including our own packaging).  This removes targets
> that Aurora users should not be consuming.
> >
> >
> > Diffs
> > -
> >
> >   build-support/packaging/debian/rules
> 23828c02b73f007393d2ed4ce69c010cebf07e57
> >   build-support/packaging/rpm/aurora.spec
> 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771
> >   src/main/python/apache/thermos/BUILD
> 8221aa0bd4efe5f519550cba716d6a564ba9ae44
> >   src/main/python/apache/thermos/cli/bin/BUILD
> f33c7f838a6a0932abc737d0ecf7ca3a59580e2e
> >   src/main/python/apache/thermos/cli/bin/thermos.py
> fcef38d33e7ca2005f35c3bdb90ffee6aeade3af
> >   src/main/python/apache/thermos/observer/BUILD
> 41db2cc2e11234c434f58f55abec0b9f308096be
> >   src/main/python/apache/thermos/observer/bin/BUILD
> 0abe2ccfe9c5ccb509ad731125385900114ba352
> >   src/main/python/apache/thermos/observer/bin/thermos_observer.py
> 39d3994a6163746e853cd21fc4c3585edc2b54cb
> >
> > Diff: https://reviews.apache.org/r/36700/diff/
> >
> >
> > Testing
> > ---
> >
> > ./build-support/jenkins/build.sh
> >
> > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> > (as far as it currently gets on master, anyhow, due to AURORA-1409)
> >
> >
> > Thanks,
> >
> > Bill Farner
> >
> >
>
>

-- 
Sent from Gmail Mobile

Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

2015-07-24 Thread Kevin Sweeney

 sidebar (#2289)
Replace references of Gittip with Gratipay (#2282)
Add link to changelog in sidebar (#2273)
2.4.3 (2014-10-06)
Bugfixes

Unicode URL improvements for Python 2.
Re-order JSON param for backwards compat.
Automatically defrag authentication schemes from host/pass URIs. (#2249)
2.4.2 (2014-10-05)
Improvements

FINALLY! Add json parameter for uploads! (#2258)
Support for bytestring URLs on Python 3.x (#2238)
Bugfixes

Avoid getting stuck in a loop (#2244)
Multiple calls to iter* fail with unhelpful error. (#2240, #2241)
Documentation

Correct redirection introduction (#2245)
Added example of how to send multiple files in one request. (#2227)
Clarify how to pass a custom set of CAs (#2248)
2.4.1 (2014-09-09)
Now has a “security” package extras set, $ pip install requests[security]
Requests will now use Certifi if it is available.
Capture and re-raise urllib3 ProtocolError
Bugfix for responses that attempt to redirect to themselves forever (wtf?).
2.4.0 (2014-08-29)
Behavioral Changes

Connection: keep-alive header is now sent automatically.
Improvements

Support for connect timeouts! Timeout now accepts a tuple (connect, read) which 
is used to set individual connect and read timeouts.
Allow copying of PreparedRequests without headers/cookies.
Updated bundled urllib3 version.
Refactored settings loading from environment – new 
Session.merge_environment_settings.
Handle socket errors in iter_content.
```


Diffs
-

  3rdparty/python/requirements.txt 44217469a9583ec50233f34d54a32c105e6bab2c 
  src/main/python/apache/aurora/client/api/BUILD 
d71cc31b2bb86d1a7321e78cd7716a32ff47e47d 

Diff: https://reviews.apache.org/r/36797/diff/


Testing
---

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Kevin Sweeney

Re: Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

2015-07-24 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36797/#review92997
---


@ReviewBot retry

- Kevin Sweeney


On July 24, 2015, 2:38 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36797/
> ---
> 
> (Updated July 24, 2015, 2:38 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove twitter.common.rpc dependency and upgrade requests.
> 
> requests changelog, including a CVE:
> 
> ```
> 2.7.0 (2015-05-03)
> This is the first release that follows our new release process. For more, see 
> [our 
> documentation](http://docs.python-requests.org/en/latest/community/release-process/).
> 
> Bugfixes
> 
> Updated urllib3 to 1.10.4, resolving several bugs involving chunked transfer 
> encoding and response framing.
> 2.6.2 (2015-04-23)
> Bugfixes
> 
> Fix regression where compressed data that was sent as chunked data was not 
> properly decompressed. (#2561)
> 2.6.1 (2015-04-22)
> Bugfixes
> 
> Remove VendorAlias import machinery introduced in v2.5.2.
> Simplify the PreparedRequest.prepare API: We no longer require the user to 
> pass an empty list to the hooks keyword argument. (c.f. #2552)
> Resolve redirects now receives and forwards all of the original arguments to 
> the adapter. (#2503)
> Handle UnicodeDecodeErrors when trying to deal with a unicode URL that cannot 
> be encoded in ASCII. (#2540)
> Populate the parsed path of the URI field when performing Digest 
> Authentication. (#2426)
> Copy a PreparedRequest’s CookieJar more reliably when it is not an instance 
> of RequestsCookieJar. (#2527)
> 2.6.0 (2015-03-14)
> Bugfixes
> 
> CVE-2015-2296: Fix handling of cookies on redirect. Previously a cookie 
> without a host value set would use the hostname for the redirected URL 
> exposing requests users to session fixation attacks and potentially cookie 
> stealing. This was disclosed privately by Matthew Daley of BugFuzz. This 
> affects all versions of requests from v2.1.0 to v2.5.3 (inclusive on both 
> ends).
> Fix error when requests is an install_requires dependency and python setup.py 
> test is run. (#2462)
> Fix error when urllib3 is unbundled and requests continues to use the 
> vendored import location.
> Include fixes to urllib3’s header handling.
> Requests’ handling of unvendored dependencies is now more restrictive.
> Features and Improvements
> 
> Support bytearrays when passed as parameters in the files argument. (#2468)
> Avoid data duplication when creating a request with str, bytes, or bytearray 
> input to the files argument.
> 2.5.3 (2015-02-24)
> Bugfixes
> 
> Revert changes to our vendored certificate bundle. For more context see 
> (#2455, #2456, and http://bugs.python.org/issue23476)
> 2.5.2 (2015-02-23)
> Features and Improvements
> 
> Add sha256 fingerprint support. (shazow/urllib3#540)
> Improve the performance of headers. (shazow/urllib3#544)
> Bugfixes
> 
> Copy pip’s import machinery. When downstream redistributors remove 
> requests.packages.urllib3 the import machinery will continue to let those 
> same symbols work. Example usage in requests’ documentation and 3rd-party 
> libraries relying on the vendored copies of urllib3 will work without having 
> to fallback to the system urllib3.
> Attempt to quote parts of the URL on redirect if unquoting and then quoting 
> fails. (#2356)
> Fix filename type check for multipart form-data uploads. (#2411)
> Properly handle the case where a server issuing digest authentication 
> challenges provides both auth and auth-int qop-values. (#2408)
> Fix a socket leak. (shazow/urllib3#549)
> Fix multiple Set-Cookie headers properly. (shazow/urllib3#534)
> Disable the built-in hostname verification. (shazow/urllib3#526)
> Fix the behaviour of decoding an exhausted stream. (shazow/urllib3#535)
> Security
> 
> Pulled in an updated cacert.pem.
> Drop RC4 from the default cipher list. (shazow/urllib3#551)
> 2.5.1 (2014-12-23)
> Behavioural Changes
> 
> Only catch HTTPErrors in raise_for_status (#2382)
> Bugfixes
> 
> Handle LocationParseError from urllib3 (#2344)
> Handle file-like object filenames that are not strings (#2379)
> Unbreak HTTPDigestAuth handler. Allow new nonces to be negotiated (#2389)
> 2.5.0 (2014-12-01)
> Improvements
> 
> Allow usage of urllib3’s Retry object with H

Re: Review Request 36710: Add an executor service decorator that gates async operations.

2015-07-24 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36710/#review93000
---

Ship it!


Ship It!

- Kevin Sweeney


On July 23, 2015, 10:20 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36710/
> ---
> 
> (Updated July 23, 2015, 10:20 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1395
> https://issues.apache.org/jira/browse/AURORA-1395
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> In the current state of the scheduler, we start async work in the context of 
> a transaction.  As we have observed in the linked ticket, this work can read 
> data that is inconsistent with the transaction context if it starts before 
> the transaction completes.  The purpose of this utility is to let async work 
> queue until the originating transaction completes.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/DelayExecutor.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/FlushableWorkQueue.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/GatedDelayExecutor.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> c85979dedd0ef2c515453a33c9a36d52865eb548 
>   src/test/java/org/apache/aurora/scheduler/async/GatedDelayExecutorTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36710/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-27 Thread Kevin Sweeney



> On July 24, 2015, 10:57 a.m., Brian Wickman wrote:
> > src/main/python/apache/thermos/observer/BUILD, line 74
> > <https://reviews.apache.org/r/36700/diff/2/?file=1020365#file1020365line74>
> >
> > This puts an aurora dependency on thermos and I imagine causes a cycle 
> > in the build graph (pants may just silently ignore it.)
> > 
> > Let's just remove the thermos_observer entry point from this package 
> > entirely by deleting the .with_binaries clause.
> 
> Bill Farner wrote:
> This target (`src/main/python/apache/thermos/observer`) is a top-level 
> target, only used by `build-support/release/make-python-sdists`, so i think 
> we're safe from a cycle.  I'm not strictly against removing the 
> `with_binaries`, but i assume it is there for a reason and something would 
> break?  Or do we just not use the sdists [this way]?
> 
> Brian Wickman wrote:
> Afaik nobody uses these in practice.  They're only useful for when you 
> install the sdists via pip or pex directly.  Instead we always build pex 
> binaries using pants which delegates to the python_binary target.
> 
> Kevin Sweeney wrote:
> I answered someone's question in IRC with a gist ~2yrs ago 
> https://gist.github.com/kevints/8361414 so it does seem likely these are used 
> in practice. Okay with removing them but a NEWS entry would be good form.
> 
> Bill Farner wrote:
> Should i just kill the sdists entirely?
> 
> Brian Wickman wrote:
> I'd prefer to go in the opposite direction and kill pants.
> 
> Bill Farner wrote:
> I'd like to find a path to land a fix as packaging is currently 
> broken/blocked.  I believe the current diff is the closest thing to 
> compromise between the various opinions around this change.  Please let me 
> know what you think.

-1 as this fix breaks the observer entry point entirely and produces an sdist 
that is invalid

```
(observer.venv)~aurora git aurora/. 36700
% pip install -f dist apache.thermos.observer --pre   
You are using pip version 6.1.1, however version 7.1.0 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting apache.thermos.observer
  Could not find a version that satisfies the requirement 
apache.thermos.observer (from versions: 0.10.0-SNAPSHOT)
  No matching distribution found for apache.thermos.observer
```

so pants writes this sdist with a dependency on itself

since it's already broken I'd suggest removing the entry point entirely (so 
we're not advertising a feature we don't actually have).


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36700/#review92944
---


On July 23, 2015, 5 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36700/
> ---
> 
> (Updated July 23, 2015, 5 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The meaning of the targets under 
> `src/main/python/apache/thermos/cli/bin/BUILD` and 
> `src/main/python/apache/thermos/observer/bin/BUILD` changed recently, which 
> bit several people (including our own packaging).  This removes targets that 
> Aurora users should not be consuming.
> 
> 
> Diffs
> -
> 
>   build-support/packaging/debian/rules 
> 23828c02b73f007393d2ed4ce69c010cebf07e57 
>   build-support/packaging/rpm/aurora.spec 
> 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 
>   src/main/python/apache/thermos/BUILD 
> 8221aa0bd4efe5f519550cba716d6a564ba9ae44 
>   src/main/python/apache/thermos/cli/bin/BUILD 
> f33c7f838a6a0932abc737d0ecf7ca3a59580e2e 
>   src/main/python/apache/thermos/cli/bin/thermos.py 
> fcef38d33e7ca2005f35c3bdb90ffee6aeade3af 
>   src/main/python/apache/thermos/observer/BUILD 
> 41db2cc2e11234c434f58f55abec0b9f308096be 
>   src/main/python/apache/thermos/observer/bin/BUILD 
> 0abe2ccfe9c5ccb509ad731125385900114ba352 
>   src/main/python/apache/thermos/observer/bin/thermos_observer.py 
> 39d3994a6163746e853cd21fc4c3585edc2b54cb 
> 
> Diff: https://reviews.apache.org/r/36700/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> (as far as it currently gets on master, anyhow, due to AURORA-1409)
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36700: Remove references to binary build targets that are not currently for general consumption.

2015-07-27 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36700/#review93209
---

Ship it!


Ship It!

- Kevin Sweeney


On July 27, 2015, 5:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36700/
> ---
> 
> (Updated July 27, 2015, 5:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The meaning of the targets under 
> `src/main/python/apache/thermos/cli/bin/BUILD` and 
> `src/main/python/apache/thermos/observer/bin/BUILD` changed recently, which 
> bit several people (including our own packaging).  This removes targets that 
> Aurora users should not be consuming.
> 
> 
> Diffs
> -
> 
>   README.md f3b23247cf3f7e550c1714b4fb8227a2baab3b41 
>   build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 
>   build-support/packaging/debian/rules 
> 23828c02b73f007393d2ed4ce69c010cebf07e57 
>   build-support/packaging/rpm/aurora.spec 
> 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 
>   build-support/release/make-python-sdists 
> 9608f68e16243da01434ce2fc7d61bb7c7efd712 
> 
> Diff: https://reviews.apache.org/r/36700/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> (as far as it currently gets on master, anyhow, due to AURORA-1409)
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36700: Remove references to binary build targets that are not currently for general consumption.

2015-07-27 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36700/#review93211
---



README.md 
<https://reviews.apache.org/r/36700/#comment147530>

Is there any reason to remove the `./gradlew distTar` guidance?


- Kevin Sweeney


On July 27, 2015, 5:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36700/
> ---
> 
> (Updated July 27, 2015, 5:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The meaning of the targets under 
> `src/main/python/apache/thermos/cli/bin/BUILD` and 
> `src/main/python/apache/thermos/observer/bin/BUILD` changed recently, which 
> bit several people (including our own packaging).  This removes targets that 
> Aurora users should not be consuming.
> 
> 
> Diffs
> -
> 
>   README.md f3b23247cf3f7e550c1714b4fb8227a2baab3b41 
>   build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 
>   build-support/packaging/debian/rules 
> 23828c02b73f007393d2ed4ce69c010cebf07e57 
>   build-support/packaging/rpm/aurora.spec 
> 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 
>   build-support/release/make-python-sdists 
> 9608f68e16243da01434ce2fc7d61bb7c7efd712 
> 
> Diff: https://reviews.apache.org/r/36700/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> (as far as it currently gets on master, anyhow, due to AURORA-1409)
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 36874: Fix typo in the scheduler deployment documentation

2015-07-27 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36874/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

Fix typo in scheduler deployment documentation

The command should be run on schedulers, not masters.


Diffs
-

  docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d 

Diff: https://reviews.apache.org/r/36874/diff/


Testing
---


Thanks,

Kevin Sweeney

Re: Review Request 36945: Use the correct (aurora-specific) python build targets in RPM and deb scripts.

2015-07-30 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36945/#review93615
---

Ship it!


Ship It!

- Kevin Sweeney


On July 30, 2015, 9:13 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36945/
> ---
> 
> (Updated July 30, 2015, 9:13 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Pulled this out of https://reviews.apache.org/r/36700/ to address separately, 
> as it is the more pressing issue.
> 
> 
> Diffs
> -
> 
>   build-support/packaging/debian/rules 
> 23828c02b73f007393d2ed4ce69c010cebf07e57 
>   build-support/packaging/rpm/aurora.spec 
> 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 
> 
> Diff: https://reviews.apache.org/r/36945/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 36972: One python_library per exported setup.py project

2015-07-30 Thread Kevin Sweeney

ccfe9c5ccb509ad731125385900114ba352 
  src/main/python/apache/thermos/observer/bin/__init__.py  
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
39d3994a6163746e853cd21fc4c3585edc2b54cb 
  src/main/python/apache/thermos/observer/http/BUILD 
0bd770453dc78b043c9e6171dc7439da19c5872e 
  src/main/python/apache/thermos/testing/BUILD 
8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 
  src/test/python/apache/aurora/BUILD c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 
  src/test/python/apache/aurora/admin/BUILD 
69da2c97cb08025a27ca276bb2ad6fcc43db1b10 
  src/test/python/apache/aurora/client/BUILD 
c55adfe9825b77f418e41fa9a4ba43926bd991ed 
  src/test/python/apache/aurora/client/api/BUILD 
65b378b0b4c5fa11f9899ef04a4a10a211f37245 
  src/test/python/apache/aurora/client/cli/BUILD 
0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
  src/test/python/apache/aurora/client/hooks/BUILD 
0b924ccfbcdb4800f99b80067ff8a78252f99907 
  src/test/python/apache/aurora/common/BUILD 
9b1d4d876e10cb759202240931e4787ce673d897 
  src/test/python/apache/aurora/config/BUILD 
c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 
  src/test/python/apache/aurora/executor/BUILD 
8fff66ef8858af892ba1124454fefb07715943d7 
  src/test/python/apache/aurora/executor/bin/BUILD 
713ce9529e36c70e1dde17a724efe7631c7aca4c 
  src/test/python/apache/aurora/executor/common/BUILD 
b3da27bb83c44a228851b256cc09f093d1e2eb87 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
cc326562db59eee807b22c4ee16d753abb3c6468 
  src/test/python/apache/thermos/cli/BUILD 
087b1740de4d8a30c74c7776eb83f9784e0049cc 
  src/test/python/apache/thermos/cli/commands/BUILD 
5465b19be5ab8bdf7252e7b1fa7a4ef95063193d 
  src/test/python/apache/thermos/common/BUILD 
bb70867e0e070ee9651f018f30990bd9ff0dd88f 
  src/test/python/apache/thermos/config/BUILD 
a06af36c83fc7ec00ecd00df7e424faae3118131 
  src/test/python/apache/thermos/core/BUILD 
d637c24f098468776fb8b0758f5990b83ec362c5 
  src/test/python/apache/thermos/monitoring/BUILD 
f4ad7fc1245980ef727c7c4a30af89b2d8d1293a 
  src/test/python/apache/thermos/observer/BUILD 
ff92a52fe7a88379e8aa1c1b2385c065bd375a68 
  src/test/python/apache/thermos/observer/http/BUILD 
0cdaafc3e71d21d48c35e0dac68910c53d003fae 

Diff: https://reviews.apache.org/r/36972/diff/


Testing
---

./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists

TODO: test RPMs
TODO: test DEBs
TODO: test E2E


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-30 Thread Kevin Sweeney

e 
  src/main/python/apache/thermos/config/bin/config_repl.py 
ae9ca3b2812f719b0a6185081434d557492ac825 
  src/main/python/apache/thermos/core/BUILD 
d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea 
  src/main/python/apache/thermos/monitoring/BUILD 
e8851026cb7ff59f0fd719837fdb0110be356c31 
  src/main/python/apache/thermos/observer/BUILD 
41db2cc2e11234c434f58f55abec0b9f308096be 
  src/main/python/apache/thermos/observer/bin/BUILD 
0abe2ccfe9c5ccb509ad731125385900114ba352 
  src/main/python/apache/thermos/observer/bin/__init__.py  
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
39d3994a6163746e853cd21fc4c3585edc2b54cb 
  src/main/python/apache/thermos/observer/http/BUILD 
0bd770453dc78b043c9e6171dc7439da19c5872e 
  src/main/python/apache/thermos/testing/BUILD 
8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 
  src/test/python/apache/aurora/BUILD c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 
  src/test/python/apache/aurora/admin/BUILD 
69da2c97cb08025a27ca276bb2ad6fcc43db1b10 
  src/test/python/apache/aurora/client/BUILD 
c55adfe9825b77f418e41fa9a4ba43926bd991ed 
  src/test/python/apache/aurora/client/api/BUILD 
65b378b0b4c5fa11f9899ef04a4a10a211f37245 
  src/test/python/apache/aurora/client/cli/BUILD 
0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
  src/test/python/apache/aurora/client/hooks/BUILD 
0b924ccfbcdb4800f99b80067ff8a78252f99907 
  src/test/python/apache/aurora/common/BUILD 
9b1d4d876e10cb759202240931e4787ce673d897 
  src/test/python/apache/aurora/config/BUILD 
c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 
  src/test/python/apache/aurora/executor/BUILD 
8fff66ef8858af892ba1124454fefb07715943d7 
  src/test/python/apache/aurora/executor/bin/BUILD 
713ce9529e36c70e1dde17a724efe7631c7aca4c 
  src/test/python/apache/aurora/executor/common/BUILD 
b3da27bb83c44a228851b256cc09f093d1e2eb87 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
cc326562db59eee807b22c4ee16d753abb3c6468 
  src/test/python/apache/thermos/cli/BUILD 
087b1740de4d8a30c74c7776eb83f9784e0049cc 
  src/test/python/apache/thermos/cli/commands/BUILD 
5465b19be5ab8bdf7252e7b1fa7a4ef95063193d 
  src/test/python/apache/thermos/common/BUILD 
bb70867e0e070ee9651f018f30990bd9ff0dd88f 
  src/test/python/apache/thermos/config/BUILD 
a06af36c83fc7ec00ecd00df7e424faae3118131 
  src/test/python/apache/thermos/core/BUILD 
d637c24f098468776fb8b0758f5990b83ec362c5 
  src/test/python/apache/thermos/monitoring/BUILD 
f4ad7fc1245980ef727c7c4a30af89b2d8d1293a 
  src/test/python/apache/thermos/observer/BUILD 
ff92a52fe7a88379e8aa1c1b2385c065bd375a68 
  src/test/python/apache/thermos/observer/http/BUILD 
0cdaafc3e71d21d48c35e0dac68910c53d003fae 

Diff: https://reviews.apache.org/r/36972/diff/


Testing (updated)
---

./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists

E2E test gets as far as it usually does.
Manually checked that `thermos status` works.

I don't have a test environment for the debian package or the spec file.


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney

 src/main/python/apache/thermos/cli/bin/thermos.py 
fcef38d33e7ca2005f35c3bdb90ffee6aeade3af 
  src/main/python/apache/thermos/cli/commands/BUILD 
552eeb4f61693033d8828e789bd22e680b957d1d 
  src/main/python/apache/thermos/common/BUILD 
942fc15f5a5d6a5ff58385b10f3783ac476a4f82 
  src/main/python/apache/thermos/config/BUILD 
d9099c5806eadb1190d2028142a7ec711023d39f 
  src/main/python/apache/thermos/config/bin/config_load.py 
d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e 
  src/main/python/apache/thermos/config/bin/config_repl.py 
ae9ca3b2812f719b0a6185081434d557492ac825 
  src/main/python/apache/thermos/core/BUILD 
d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea 
  src/main/python/apache/thermos/monitoring/BUILD 
e8851026cb7ff59f0fd719837fdb0110be356c31 
  src/main/python/apache/thermos/observer/BUILD 
41db2cc2e11234c434f58f55abec0b9f308096be 
  src/main/python/apache/thermos/observer/bin/BUILD 
0abe2ccfe9c5ccb509ad731125385900114ba352 
  src/main/python/apache/thermos/observer/bin/__init__.py  
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
39d3994a6163746e853cd21fc4c3585edc2b54cb 
  src/main/python/apache/thermos/observer/http/BUILD 
0bd770453dc78b043c9e6171dc7439da19c5872e 
  src/main/python/apache/thermos/testing/BUILD 
8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 
  src/test/python/apache/aurora/BUILD c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 
  src/test/python/apache/aurora/admin/BUILD 
69da2c97cb08025a27ca276bb2ad6fcc43db1b10 
  src/test/python/apache/aurora/client/BUILD 
c55adfe9825b77f418e41fa9a4ba43926bd991ed 
  src/test/python/apache/aurora/client/api/BUILD 
65b378b0b4c5fa11f9899ef04a4a10a211f37245 
  src/test/python/apache/aurora/client/cli/BUILD 
0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
  src/test/python/apache/aurora/client/hooks/BUILD 
0b924ccfbcdb4800f99b80067ff8a78252f99907 
  src/test/python/apache/aurora/common/BUILD 
9b1d4d876e10cb759202240931e4787ce673d897 
  src/test/python/apache/aurora/config/BUILD 
c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 
  src/test/python/apache/aurora/executor/BUILD 
8fff66ef8858af892ba1124454fefb07715943d7 
  src/test/python/apache/aurora/executor/bin/BUILD 
713ce9529e36c70e1dde17a724efe7631c7aca4c 
  src/test/python/apache/aurora/executor/common/BUILD 
b3da27bb83c44a228851b256cc09f093d1e2eb87 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
cc326562db59eee807b22c4ee16d753abb3c6468 
  src/test/python/apache/thermos/cli/BUILD 
087b1740de4d8a30c74c7776eb83f9784e0049cc 
  src/test/python/apache/thermos/cli/commands/BUILD 
5465b19be5ab8bdf7252e7b1fa7a4ef95063193d 
  src/test/python/apache/thermos/common/BUILD 
bb70867e0e070ee9651f018f30990bd9ff0dd88f 
  src/test/python/apache/thermos/config/BUILD 
a06af36c83fc7ec00ecd00df7e424faae3118131 
  src/test/python/apache/thermos/core/BUILD 
d637c24f098468776fb8b0758f5990b83ec362c5 
  src/test/python/apache/thermos/monitoring/BUILD 
f4ad7fc1245980ef727c7c4a30af89b2d8d1293a 
  src/test/python/apache/thermos/observer/BUILD 
ff92a52fe7a88379e8aa1c1b2385c065bd375a68 
  src/test/python/apache/thermos/observer/http/BUILD 
0cdaafc3e71d21d48c35e0dac68910c53d003fae 

Diff: https://reviews.apache.org/r/36972/diff/


Testing
---

./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists

E2E test gets as far as it usually does.
Manually checked that `thermos status` works.

I don't have a test environment for the debian package or the spec file.


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney



> On July 31, 2015, 10:19 a.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/common/BUILD, line 61
> > <https://reviews.apache.org/r/36972/diff/2/?file=1025868#file1025868line61>
> >
> > This is probably the toughest one to swallow.  Pulling in aurora.common 
> > just for aurora_job_key now requires a native dependency (kerberos via 
> > requests-kerberos.)
> > 
> > I'd rather see auth get pulled into a top-level package (i.e. 
> > aurora.auth) than see it taint aurora.common with a number of heavyweight 
> > dependencies.

I've extracted an `apache.aurora.kerberos` package that provides the Kerberized 
client and admin client and moved the Kerberos dependency there.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93744
-------


On July 31, 2015, 10:56 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36972/
> ---
> 
> (Updated July 31, 2015, 10:56 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Publishing this review now for early feedback, don't intend to ship until 
> most of the TODOs are addressed.
> 
> This is a mostly red code diff and makes the pants build work similar to how 
> it already works in an IDE environment while minimizing duplicated 
> information. This change also removes the confusing versions of `thermos` and 
> `thermos_observer` in favor of new ones. Because of the way "covering 
> dependencies" were required it was easier to do this refactor than more 
> tactically create a working `setup_py` target for `apache.aurora.tools` 
> without cycles and without duplicated files.
> 
> * Remove the `apache.thermos` package.
> * Rename the `apache.gen.aurora` package to `apache.aurora.thrift`.
> * Rename the `apache.gen.thermos` package to `apache.thermos.thrift`.
> * Introduce a new `apache.aurora.tools` package with the `thermos` and 
> `thermos_observer` binaries.
> * Create apache.thermos.runner package, rename `thermos/bin` to 
> `thermos/runner`.
> * Remove all `*-packaged` and virtual dependency trees, as well as the phrase 
> "covering dependencies."
> * Use `_`-prefix naming convention for private target names.
> * Replace manual list of targets in `make-python-sdists` with 
> automatically-generated one (using new convention).
> * Introduce a new `apache.aurora.kerberos` package with the `kaurora` and 
> `kaurora_admin` binaries.
> * Remove all `BUILD` files in `src/main` that don't contain an exported 
> `setup.py` library (except one mentioned in TODO).
> * Use dictionary syntax in `with_binaries` (TODO: replace the underscores in 
> binary names with dashes?).
> * Remove unused/unreachable binaries (most `bin/` dirs under `thermos/`).
> * Create blank `__init__.py` files in directories that pants warns aren't 
> packages.
> * Added `thermos` command to vagrant image.
> 
> * TODO: Write NEWS entry
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> d196fefc2c5e5ee32d0cf9c901cffe7d247379d1 
>   api/src/main/thrift/org/apache/thermos/BUILD 
> d0d789a6ee3971e3070f9397d53929563a77f7ea 
>   build-support/packaging/debian/rules 
> 17e00c02a3cb3294d5107516d795a73587ca4f70 
>   build-support/packaging/rpm/aurora.spec 
> 7cf8de6f7b99788ca461a90fc4aefba7dccd7b63 
>   build-support/release/make-python-sdists 
> 9608f68e16243da01434ce2fc7d61bb7c7efd712 
>   examples/vagrant/aurorabuild.sh fbaa6ae9ef7ff2910af8c9c0d6b8ef90ea3e152a 
>   src/main/python/apache/aurora/admin/BUILD 
> 22bf3f9943ea11258ba681bdb80feb00206bb926 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 1c39717b656465bb1966073340f9fe80be01a085 
>   src/main/python/apache/aurora/client/BUILD 
> e73cd52289209bb9658b16bb77dc0b0a9c811a1a 
>   src/main/python/apache/aurora/client/api/BUILD 
> a030a67b78fc4bc4682d0df169e27efc6810dce3 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 973d05971bd940c7e38c48ce6bfbf5c8e1654c5a 
>   src/main/python/apache/aurora/client/cli/client.py 
> c0974f3bef59f8f7c2320398d367cb4dd9048d2b 
>   src/main/python/apache/aurora/client/hooks/BUILD 
> ddf813b5d2e7d63507a8e08745ebf6cb3dbac8e1 
>   src/main/python/apache/aurora/common/BUILD

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney



> On July 31, 2015, 7:39 a.m., Joshua Cohen wrote:
> > src/main/python/apache/thermos/bin/BUILD, line 40
> > <https://reviews.apache.org/r/36972/diff/2/?file=1025877#file1025877line40>
> >
> > Should this read from .auroraversion?

Good catch! (leftover from my example email). Fixed.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93722
---


On July 31, 2015, 10:56 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36972/
> ---
> 
> (Updated July 31, 2015, 10:56 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Publishing this review now for early feedback, don't intend to ship until 
> most of the TODOs are addressed.
> 
> This is a mostly red code diff and makes the pants build work similar to how 
> it already works in an IDE environment while minimizing duplicated 
> information. This change also removes the confusing versions of `thermos` and 
> `thermos_observer` in favor of new ones. Because of the way "covering 
> dependencies" were required it was easier to do this refactor than more 
> tactically create a working `setup_py` target for `apache.aurora.tools` 
> without cycles and without duplicated files.
> 
> * Remove the `apache.thermos` package.
> * Rename the `apache.gen.aurora` package to `apache.aurora.thrift`.
> * Rename the `apache.gen.thermos` package to `apache.thermos.thrift`.
> * Introduce a new `apache.aurora.tools` package with the `thermos` and 
> `thermos_observer` binaries.
> * Create apache.thermos.runner package, rename `thermos/bin` to 
> `thermos/runner`.
> * Remove all `*-packaged` and virtual dependency trees, as well as the phrase 
> "covering dependencies."
> * Use `_`-prefix naming convention for private target names.
> * Replace manual list of targets in `make-python-sdists` with 
> automatically-generated one (using new convention).
> * Introduce a new `apache.aurora.kerberos` package with the `kaurora` and 
> `kaurora_admin` binaries.
> * Remove all `BUILD` files in `src/main` that don't contain an exported 
> `setup.py` library (except one mentioned in TODO).
> * Use dictionary syntax in `with_binaries` (TODO: replace the underscores in 
> binary names with dashes?).
> * Remove unused/unreachable binaries (most `bin/` dirs under `thermos/`).
> * Create blank `__init__.py` files in directories that pants warns aren't 
> packages.
> * Added `thermos` command to vagrant image.
> 
> * TODO: Write NEWS entry
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> d196fefc2c5e5ee32d0cf9c901cffe7d247379d1 
>   api/src/main/thrift/org/apache/thermos/BUILD 
> d0d789a6ee3971e3070f9397d53929563a77f7ea 
>   build-support/packaging/debian/rules 
> 17e00c02a3cb3294d5107516d795a73587ca4f70 
>   build-support/packaging/rpm/aurora.spec 
> 7cf8de6f7b99788ca461a90fc4aefba7dccd7b63 
>   build-support/release/make-python-sdists 
> 9608f68e16243da01434ce2fc7d61bb7c7efd712 
>   examples/vagrant/aurorabuild.sh fbaa6ae9ef7ff2910af8c9c0d6b8ef90ea3e152a 
>   src/main/python/apache/aurora/admin/BUILD 
> 22bf3f9943ea11258ba681bdb80feb00206bb926 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 1c39717b656465bb1966073340f9fe80be01a085 
>   src/main/python/apache/aurora/client/BUILD 
> e73cd52289209bb9658b16bb77dc0b0a9c811a1a 
>   src/main/python/apache/aurora/client/api/BUILD 
> a030a67b78fc4bc4682d0df169e27efc6810dce3 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 973d05971bd940c7e38c48ce6bfbf5c8e1654c5a 
>   src/main/python/apache/aurora/client/cli/client.py 
> c0974f3bef59f8f7c2320398d367cb4dd9048d2b 
>   src/main/python/apache/aurora/client/hooks/BUILD 
> ddf813b5d2e7d63507a8e08745ebf6cb3dbac8e1 
>   src/main/python/apache/aurora/common/BUILD 
> abc122b0775bb17b1df67bdb946c472010219b9b 
>   src/main/python/apache/aurora/common/auth/BUILD 
> 0abac94eeeb71e6af43ed191ea690e5f96a6be23 
>   src/main/python/apache/aurora/common/auth/kerberos.py 
> 2d782b63b611a9d2604ef0ab1116d3e68fb86dc7 
>   src/main/python/apache/aurora/config/BUILD 
> 0a3a93fa6bb785903f71bc067aecc79c0e45a0b5 
>   src/main/python/apache/aurora/config/schema/BUILD 
> 171f42a24ec7ddc2846eb68b6a60e7d8dec43

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney

8d33e7ca2005f35c3bdb90ffee6aeade3af 
  src/main/python/apache/thermos/cli/commands/BUILD 
552eeb4f61693033d8828e789bd22e680b957d1d 
  src/main/python/apache/thermos/common/BUILD 
942fc15f5a5d6a5ff58385b10f3783ac476a4f82 
  src/main/python/apache/thermos/config/BUILD 
d9099c5806eadb1190d2028142a7ec711023d39f 
  src/main/python/apache/thermos/config/bin/config_load.py 
d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e 
  src/main/python/apache/thermos/config/bin/config_repl.py 
ae9ca3b2812f719b0a6185081434d557492ac825 
  src/main/python/apache/thermos/core/BUILD 
d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea 
  src/main/python/apache/thermos/monitoring/BUILD 
e8851026cb7ff59f0fd719837fdb0110be356c31 
  src/main/python/apache/thermos/observer/BUILD 
41db2cc2e11234c434f58f55abec0b9f308096be 
  src/main/python/apache/thermos/observer/bin/BUILD 
0abe2ccfe9c5ccb509ad731125385900114ba352 
  src/main/python/apache/thermos/observer/bin/__init__.py  
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
39d3994a6163746e853cd21fc4c3585edc2b54cb 
  src/main/python/apache/thermos/observer/http/BUILD 
0bd770453dc78b043c9e6171dc7439da19c5872e 
  src/main/python/apache/thermos/testing/BUILD 
8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 
  src/test/python/apache/aurora/BUILD c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 
  src/test/python/apache/aurora/admin/BUILD 
69da2c97cb08025a27ca276bb2ad6fcc43db1b10 
  src/test/python/apache/aurora/client/BUILD 
c55adfe9825b77f418e41fa9a4ba43926bd991ed 
  src/test/python/apache/aurora/client/api/BUILD 
65b378b0b4c5fa11f9899ef04a4a10a211f37245 
  src/test/python/apache/aurora/client/cli/BUILD 
0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
  src/test/python/apache/aurora/client/hooks/BUILD 
0b924ccfbcdb4800f99b80067ff8a78252f99907 
  src/test/python/apache/aurora/common/BUILD 
9b1d4d876e10cb759202240931e4787ce673d897 
  src/test/python/apache/aurora/config/BUILD 
c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 
  src/test/python/apache/aurora/executor/BUILD 
8fff66ef8858af892ba1124454fefb07715943d7 
  src/test/python/apache/aurora/executor/bin/BUILD 
713ce9529e36c70e1dde17a724efe7631c7aca4c 
  src/test/python/apache/aurora/executor/common/BUILD 
b3da27bb83c44a228851b256cc09f093d1e2eb87 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
cc326562db59eee807b22c4ee16d753abb3c6468 
  src/test/python/apache/thermos/cli/BUILD 
087b1740de4d8a30c74c7776eb83f9784e0049cc 
  src/test/python/apache/thermos/cli/commands/BUILD 
5465b19be5ab8bdf7252e7b1fa7a4ef95063193d 
  src/test/python/apache/thermos/common/BUILD 
bb70867e0e070ee9651f018f30990bd9ff0dd88f 
  src/test/python/apache/thermos/config/BUILD 
a06af36c83fc7ec00ecd00df7e424faae3118131 
  src/test/python/apache/thermos/core/BUILD 
d637c24f098468776fb8b0758f5990b83ec362c5 
  src/test/python/apache/thermos/monitoring/BUILD 
f4ad7fc1245980ef727c7c4a30af89b2d8d1293a 
  src/test/python/apache/thermos/observer/BUILD 
ff92a52fe7a88379e8aa1c1b2385c065bd375a68 
  src/test/python/apache/thermos/observer/http/BUILD 
0cdaafc3e71d21d48c35e0dac68910c53d003fae 

Diff: https://reviews.apache.org/r/36972/diff/


Testing
---

./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists

E2E test gets as far as it usually does.
Manually checked that `thermos status` works.

I don't have a test environment for the debian package or the spec file.


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney



> On July 31, 2015, 9:01 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/admin/BUILD, lines 84-92
> > <https://reviews.apache.org/r/36972/diff/2/?file=1025863#file1025863line84>
> >
> > Are we completely abondoning the idea of having a non-kerberized client 
> > version with this? This was one of the sticking points in 
> > https://reviews.apache.org/r/32541/.
> 
> Bill Farner wrote:
> FWIW i think we should indeed abandon that idea.  The goal of 
> reducing/eliminating native dependncies is a good one, but i don't find it 
> beneficial to distribute different builds based on the features present.

Given where this was factored it would've added a new native dependency to the 
executor which could complicate our already not-great deployment story. I've 
kicked it into its own package for now but happy to revisit in another diff.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93731
-------


On July 31, 2015, 11:03 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36972/
> ---
> 
> (Updated July 31, 2015, 11:03 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Publishing this review now for early feedback, don't intend to ship until 
> most of the TODOs are addressed.
> 
> This is a mostly red code diff and makes the pants build work similar to how 
> it already works in an IDE environment while minimizing duplicated 
> information. This change also removes the confusing versions of `thermos` and 
> `thermos_observer` in favor of new ones. Because of the way "covering 
> dependencies" were required it was easier to do this refactor than more 
> tactically create a working `setup_py` target for `apache.aurora.tools` 
> without cycles and without duplicated files.
> 
> * Remove the `apache.thermos` package.
> * Rename the `apache.gen.aurora` package to `apache.aurora.thrift`.
> * Rename the `apache.gen.thermos` package to `apache.thermos.thrift`.
> * Introduce a new `apache.aurora.tools` package with the `thermos` and 
> `thermos_observer` binaries.
> * Create apache.thermos.runner package, rename `thermos/bin` to 
> `thermos/runner`.
> * Remove all `*-packaged` and virtual dependency trees, as well as the phrase 
> "covering dependencies."
> * Use `_`-prefix naming convention for private target names.
> * Replace manual list of targets in `make-python-sdists` with 
> automatically-generated one (using new convention).
> * Introduce a new `apache.aurora.kerberos` package with the `kaurora` and 
> `kaurora_admin` binaries.
> * Remove all `BUILD` files in `src/main` that don't contain an exported 
> `setup.py` library (except one mentioned in TODO).
> * Use dictionary syntax in `with_binaries` (TODO: replace the underscores in 
> binary names with dashes?).
> * Remove unused/unreachable binaries (most `bin/` dirs under `thermos/`).
> * Create blank `__init__.py` files in directories that pants warns aren't 
> packages.
> * Added `thermos` command to vagrant image.
> 
> * TODO: Write NEWS entry
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> d196fefc2c5e5ee32d0cf9c901cffe7d247379d1 
>   api/src/main/thrift/org/apache/thermos/BUILD 
> d0d789a6ee3971e3070f9397d53929563a77f7ea 
>   build-support/packaging/debian/rules 
> 17e00c02a3cb3294d5107516d795a73587ca4f70 
>   build-support/packaging/rpm/aurora.spec 
> 7cf8de6f7b99788ca461a90fc4aefba7dccd7b63 
>   build-support/release/make-python-sdists 
> 9608f68e16243da01434ce2fc7d61bb7c7efd712 
>   examples/vagrant/aurorabuild.sh fbaa6ae9ef7ff2910af8c9c0d6b8ef90ea3e152a 
>   src/main/python/apache/aurora/admin/BUILD 
> 22bf3f9943ea11258ba681bdb80feb00206bb926 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 1c39717b656465bb1966073340f9fe80be01a085 
>   src/main/python/apache/aurora/client/BUILD 
> e73cd52289209bb9658b16bb77dc0b0a9c811a1a 
>   src/main/python/apache/aurora/client/api/BUILD 
> a030a67b78fc4bc4682d0df169e27efc6810dce3 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 973d05971bd940c7e38c48ce6bfbf5c8e1654c5a 
>   src/main/python/apache/aurora/client/cli/client.py 
> c0974f3bef59f8f7c2320

Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

2015-07-31 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36998/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1409
https://issues.apache.org/jira/browse/AURORA-1409


Repository: aurora


Description
---

Use hostname instead of IP in Kerberos end to end test.


Diffs
-

  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
02c9e6a4109376c62b93d75921686548d2d795f9 
  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
760997c8420e9e430912de406cef494a9118897a 

Diff: https://reviews.apache.org/r/36998/diff/


Testing
---

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney

n/apache/thermos/cli/bin/thermos.py 
fcef38d33e7ca2005f35c3bdb90ffee6aeade3af 
  src/main/python/apache/thermos/cli/commands/BUILD 
552eeb4f61693033d8828e789bd22e680b957d1d 
  src/main/python/apache/thermos/common/BUILD 
942fc15f5a5d6a5ff58385b10f3783ac476a4f82 
  src/main/python/apache/thermos/config/BUILD 
d9099c5806eadb1190d2028142a7ec711023d39f 
  src/main/python/apache/thermos/config/bin/config_load.py 
d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e 
  src/main/python/apache/thermos/config/bin/config_repl.py 
ae9ca3b2812f719b0a6185081434d557492ac825 
  src/main/python/apache/thermos/core/BUILD 
d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea 
  src/main/python/apache/thermos/monitoring/BUILD 
e8851026cb7ff59f0fd719837fdb0110be356c31 
  src/main/python/apache/thermos/observer/BUILD 
41db2cc2e11234c434f58f55abec0b9f308096be 
  src/main/python/apache/thermos/observer/bin/BUILD 
0abe2ccfe9c5ccb509ad731125385900114ba352 
  src/main/python/apache/thermos/observer/bin/__init__.py  
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
39d3994a6163746e853cd21fc4c3585edc2b54cb 
  src/main/python/apache/thermos/observer/http/BUILD 
0bd770453dc78b043c9e6171dc7439da19c5872e 
  src/main/python/apache/thermos/testing/BUILD 
8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 
  src/test/python/apache/aurora/BUILD c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 
  src/test/python/apache/aurora/admin/BUILD 
69da2c97cb08025a27ca276bb2ad6fcc43db1b10 
  src/test/python/apache/aurora/client/BUILD 
c55adfe9825b77f418e41fa9a4ba43926bd991ed 
  src/test/python/apache/aurora/client/api/BUILD 
65b378b0b4c5fa11f9899ef04a4a10a211f37245 
  src/test/python/apache/aurora/client/cli/BUILD 
0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
  src/test/python/apache/aurora/client/hooks/BUILD 
0b924ccfbcdb4800f99b80067ff8a78252f99907 
  src/test/python/apache/aurora/common/BUILD 
9b1d4d876e10cb759202240931e4787ce673d897 
  src/test/python/apache/aurora/config/BUILD 
c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 
  src/test/python/apache/aurora/executor/BUILD 
8fff66ef8858af892ba1124454fefb07715943d7 
  src/test/python/apache/aurora/executor/bin/BUILD 
713ce9529e36c70e1dde17a724efe7631c7aca4c 
  src/test/python/apache/aurora/executor/common/BUILD 
b3da27bb83c44a228851b256cc09f093d1e2eb87 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
cc326562db59eee807b22c4ee16d753abb3c6468 
  src/test/python/apache/thermos/cli/BUILD 
087b1740de4d8a30c74c7776eb83f9784e0049cc 
  src/test/python/apache/thermos/cli/commands/BUILD 
5465b19be5ab8bdf7252e7b1fa7a4ef95063193d 
  src/test/python/apache/thermos/common/BUILD 
bb70867e0e070ee9651f018f30990bd9ff0dd88f 
  src/test/python/apache/thermos/config/BUILD 
a06af36c83fc7ec00ecd00df7e424faae3118131 
  src/test/python/apache/thermos/core/BUILD 
d637c24f098468776fb8b0758f5990b83ec362c5 
  src/test/python/apache/thermos/monitoring/BUILD 
f4ad7fc1245980ef727c7c4a30af89b2d8d1293a 
  src/test/python/apache/thermos/observer/BUILD 
ff92a52fe7a88379e8aa1c1b2385c065bd375a68 
  src/test/python/apache/thermos/observer/http/BUILD 
0cdaafc3e71d21d48c35e0dac68910c53d003fae 

Diff: https://reviews.apache.org/r/36972/diff/


Testing (updated)
---

./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Manually checked that `thermos status` works.

I don't have a test environment for the debian package or the spec file.


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney

n/apache/thermos/cli/commands/BUILD 
552eeb4f61693033d8828e789bd22e680b957d1d 
  src/main/python/apache/thermos/common/BUILD 
942fc15f5a5d6a5ff58385b10f3783ac476a4f82 
  src/main/python/apache/thermos/config/BUILD 
d9099c5806eadb1190d2028142a7ec711023d39f 
  src/main/python/apache/thermos/config/bin/config_load.py 
d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e 
  src/main/python/apache/thermos/config/bin/config_repl.py 
ae9ca3b2812f719b0a6185081434d557492ac825 
  src/main/python/apache/thermos/core/BUILD 
d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea 
  src/main/python/apache/thermos/monitoring/BUILD 
e8851026cb7ff59f0fd719837fdb0110be356c31 
  src/main/python/apache/thermos/observer/BUILD 
41db2cc2e11234c434f58f55abec0b9f308096be 
  src/main/python/apache/thermos/observer/bin/BUILD 
0abe2ccfe9c5ccb509ad731125385900114ba352 
  src/main/python/apache/thermos/observer/bin/__init__.py  
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
39d3994a6163746e853cd21fc4c3585edc2b54cb 
  src/main/python/apache/thermos/observer/http/BUILD 
0bd770453dc78b043c9e6171dc7439da19c5872e 
  src/main/python/apache/thermos/testing/BUILD 
8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 
  src/test/python/apache/aurora/BUILD c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 
  src/test/python/apache/aurora/admin/BUILD 
69da2c97cb08025a27ca276bb2ad6fcc43db1b10 
  src/test/python/apache/aurora/client/BUILD 
c55adfe9825b77f418e41fa9a4ba43926bd991ed 
  src/test/python/apache/aurora/client/api/BUILD 
65b378b0b4c5fa11f9899ef04a4a10a211f37245 
  src/test/python/apache/aurora/client/cli/BUILD 
0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
  src/test/python/apache/aurora/client/hooks/BUILD 
0b924ccfbcdb4800f99b80067ff8a78252f99907 
  src/test/python/apache/aurora/common/BUILD 
9b1d4d876e10cb759202240931e4787ce673d897 
  src/test/python/apache/aurora/config/BUILD 
c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 
  src/test/python/apache/aurora/executor/BUILD 
8fff66ef8858af892ba1124454fefb07715943d7 
  src/test/python/apache/aurora/executor/bin/BUILD 
713ce9529e36c70e1dde17a724efe7631c7aca4c 
  src/test/python/apache/aurora/executor/common/BUILD 
b3da27bb83c44a228851b256cc09f093d1e2eb87 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
cc326562db59eee807b22c4ee16d753abb3c6468 
  src/test/python/apache/thermos/cli/BUILD 
087b1740de4d8a30c74c7776eb83f9784e0049cc 
  src/test/python/apache/thermos/cli/commands/BUILD 
5465b19be5ab8bdf7252e7b1fa7a4ef95063193d 
  src/test/python/apache/thermos/common/BUILD 
bb70867e0e070ee9651f018f30990bd9ff0dd88f 
  src/test/python/apache/thermos/config/BUILD 
a06af36c83fc7ec00ecd00df7e424faae3118131 
  src/test/python/apache/thermos/core/BUILD 
d637c24f098468776fb8b0758f5990b83ec362c5 
  src/test/python/apache/thermos/monitoring/BUILD 
f4ad7fc1245980ef727c7c4a30af89b2d8d1293a 
  src/test/python/apache/thermos/observer/BUILD 
ff92a52fe7a88379e8aa1c1b2385c065bd375a68 
  src/test/python/apache/thermos/observer/http/BUILD 
0cdaafc3e71d21d48c35e0dac68910c53d003fae 

Diff: https://reviews.apache.org/r/36972/diff/


Testing
---

./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Manually checked that `thermos status` works.

I don't have a test environment for the debian package or the spec file.


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney



> On July 31, 2015, 3:21 p.m., Brian Wickman wrote:
> > I think it makes sense to split into two binary-exporting packages: one 
> > client-side and one server-side.  The client side (aurora.client) should 
> > contain aurora client and aurora admin client. The server-side (reuse 
> > aurora.executor?) should contain aurora executor, thermos cli, thermos 
> > observer and thermos runner.

I like this suggestion and would like to refactor the code to fit it into this 
framework. Would you accept that in a follow-up review?

Specifically there would then be 3 top-level packages (5 if you count the 
thrift API bindings, which I would also like to export to allow folks to write 
clients)

```
src/main/python/apache/aurora
  common/
  client/
  executor/
```

```
% pip install apache.aurora.executor
# thermos
# thermos-executor
# thermos-observer
# thermos-runner

% pip install apache.aurora.client
# aurora
# aurora-admin
```

Everything else would remain more-or-less organized the same but move to a 
subpackage of one of the top-level targets. The rule is simple - if both 
server-side and client-side import something it goes under common/, otherwise 
it goes under client/ or executor/ as appropriate.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93793
---


On July 31, 2015, 3:30 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36972/
> ---
> 
> (Updated July 31, 2015, 3:30 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Publishing this review now for early feedback, don't intend to ship until 
> most of the TODOs are addressed.
> 
> This is a mostly red code diff and makes the pants build work similar to how 
> it already works in an IDE environment while minimizing duplicated 
> information. This change also removes the confusing versions of `thermos` and 
> `thermos_observer` in favor of new ones. Because of the way "covering 
> dependencies" were required it was easier to do this refactor than more 
> tactically create a working `setup_py` target for `apache.aurora.tools` 
> without cycles and without duplicated files.
> 
> * Remove the `apache.thermos` package.
> * Rename the `apache.gen.aurora` package to `apache.aurora.thrift`.
> * Rename the `apache.gen.thermos` package to `apache.thermos.thrift`.
> * Introduce a new `apache.aurora.tools` package with the `thermos` and 
> `thermos_observer` binaries.
> * Create apache.thermos.runner package, rename `thermos/bin` to 
> `thermos/runner`.
> * Remove all `*-packaged` and virtual dependency trees, as well as the phrase 
> "covering dependencies."
> * Use `_`-prefix naming convention for private target names.
> * Replace manual list of targets in `make-python-sdists` with 
> automatically-generated one (using new convention).
> * Introduce a new `apache.aurora.kerberos` package with the `kaurora` and 
> `kaurora_admin` binaries.
> * Remove all `BUILD` files in `src/main` that don't contain an exported 
> `setup.py` library (except one mentioned in TODO).
> * Use dictionary syntax in `with_binaries`.
> * Remove unused/unreachable binaries (most `bin/` dirs under `thermos/`).
> * Create blank `__init__.py` files in directories that pants warns aren't 
> packages.
> * Added `thermos` command to vagrant image.
> 
> 
> Diffs
> -
> 
>   NEWS 0a8500c524a92eaf51384125687128d2fbbb0b53 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> d196fefc2c5e5ee32d0cf9c901cffe7d247379d1 
>   api/src/main/thrift/org/apache/thermos/BUILD 
> d0d789a6ee3971e3070f9397d53929563a77f7ea 
>   build-support/packaging/debian/rules 
> 17e00c02a3cb3294d5107516d795a73587ca4f70 
>   build-support/packaging/rpm/aurora.spec 
> 7cf8de6f7b99788ca461a90fc4aefba7dccd7b63 
>   build-support/release/make-python-sdists 
> 9608f68e16243da01434ce2fc7d61bb7c7efd712 
>   examples/vagrant/aurorabuild.sh fbaa6ae9ef7ff2910af8c9c0d6b8ef90ea3e152a 
>   src/main/python/apache/aurora/admin/BUILD 
> 22bf3f9943ea11258ba681bdb80feb00206bb926 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 1c39717b656465bb1966073340f9fe80be01a085 
>   src/main/python/apache/aurora/client/BUILD 
> e73cd52289209bb9658b16bb77dc0b0a9c811a1a 
>   src/main/python/apache/aurora/client/a

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney

7d1d 
  src/main/python/apache/thermos/common/BUILD 
942fc15f5a5d6a5ff58385b10f3783ac476a4f82 
  src/main/python/apache/thermos/config/BUILD 
d9099c5806eadb1190d2028142a7ec711023d39f 
  src/main/python/apache/thermos/config/bin/config_load.py 
d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e 
  src/main/python/apache/thermos/config/bin/config_repl.py 
ae9ca3b2812f719b0a6185081434d557492ac825 
  src/main/python/apache/thermos/core/BUILD 
d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea 
  src/main/python/apache/thermos/monitoring/BUILD 
e8851026cb7ff59f0fd719837fdb0110be356c31 
  src/main/python/apache/thermos/observer/BUILD 
41db2cc2e11234c434f58f55abec0b9f308096be 
  src/main/python/apache/thermos/observer/bin/BUILD 
0abe2ccfe9c5ccb509ad731125385900114ba352 
  src/main/python/apache/thermos/observer/bin/__init__.py  
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
39d3994a6163746e853cd21fc4c3585edc2b54cb 
  src/main/python/apache/thermos/observer/http/BUILD 
0bd770453dc78b043c9e6171dc7439da19c5872e 
  src/main/python/apache/thermos/testing/BUILD 
8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 
  src/test/python/apache/aurora/BUILD c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 
  src/test/python/apache/aurora/admin/BUILD 
69da2c97cb08025a27ca276bb2ad6fcc43db1b10 
  src/test/python/apache/aurora/client/BUILD 
c55adfe9825b77f418e41fa9a4ba43926bd991ed 
  src/test/python/apache/aurora/client/api/BUILD 
65b378b0b4c5fa11f9899ef04a4a10a211f37245 
  src/test/python/apache/aurora/client/cli/BUILD 
0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
  src/test/python/apache/aurora/client/hooks/BUILD 
0b924ccfbcdb4800f99b80067ff8a78252f99907 
  src/test/python/apache/aurora/common/BUILD 
9b1d4d876e10cb759202240931e4787ce673d897 
  src/test/python/apache/aurora/config/BUILD 
c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 
  src/test/python/apache/aurora/executor/BUILD 
8fff66ef8858af892ba1124454fefb07715943d7 
  src/test/python/apache/aurora/executor/bin/BUILD 
713ce9529e36c70e1dde17a724efe7631c7aca4c 
  src/test/python/apache/aurora/executor/common/BUILD 
b3da27bb83c44a228851b256cc09f093d1e2eb87 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
cc326562db59eee807b22c4ee16d753abb3c6468 
  src/test/python/apache/thermos/cli/BUILD 
087b1740de4d8a30c74c7776eb83f9784e0049cc 
  src/test/python/apache/thermos/cli/commands/BUILD 
5465b19be5ab8bdf7252e7b1fa7a4ef95063193d 
  src/test/python/apache/thermos/common/BUILD 
bb70867e0e070ee9651f018f30990bd9ff0dd88f 
  src/test/python/apache/thermos/config/BUILD 
a06af36c83fc7ec00ecd00df7e424faae3118131 
  src/test/python/apache/thermos/core/BUILD 
d637c24f098468776fb8b0758f5990b83ec362c5 
  src/test/python/apache/thermos/monitoring/BUILD 
f4ad7fc1245980ef727c7c4a30af89b2d8d1293a 
  src/test/python/apache/thermos/observer/BUILD 
ff92a52fe7a88379e8aa1c1b2385c065bd375a68 
  src/test/python/apache/thermos/observer/http/BUILD 
0cdaafc3e71d21d48c35e0dac68910c53d003fae 

Diff: https://reviews.apache.org/r/36972/diff/


Testing
---

./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Manually checked that `thermos status` works.

I don't have a test environment for the debian package or the spec file.


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney

che/thermos/cli/bin/thermos.py 
fcef38d33e7ca2005f35c3bdb90ffee6aeade3af 
  src/main/python/apache/thermos/cli/commands/BUILD 
552eeb4f61693033d8828e789bd22e680b957d1d 
  src/main/python/apache/thermos/common/BUILD 
942fc15f5a5d6a5ff58385b10f3783ac476a4f82 
  src/main/python/apache/thermos/config/BUILD 
d9099c5806eadb1190d2028142a7ec711023d39f 
  src/main/python/apache/thermos/config/bin/config_load.py 
d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e 
  src/main/python/apache/thermos/config/bin/config_repl.py 
ae9ca3b2812f719b0a6185081434d557492ac825 
  src/main/python/apache/thermos/core/BUILD 
d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea 
  src/main/python/apache/thermos/monitoring/BUILD 
e8851026cb7ff59f0fd719837fdb0110be356c31 
  src/main/python/apache/thermos/observer/BUILD 
41db2cc2e11234c434f58f55abec0b9f308096be 
  src/main/python/apache/thermos/observer/bin/BUILD 
0abe2ccfe9c5ccb509ad731125385900114ba352 
  src/main/python/apache/thermos/observer/bin/__init__.py  
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
39d3994a6163746e853cd21fc4c3585edc2b54cb 
  src/main/python/apache/thermos/observer/http/BUILD 
0bd770453dc78b043c9e6171dc7439da19c5872e 
  src/main/python/apache/thermos/testing/BUILD 
8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 
  src/test/python/apache/aurora/BUILD c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 
  src/test/python/apache/aurora/admin/BUILD 
69da2c97cb08025a27ca276bb2ad6fcc43db1b10 
  src/test/python/apache/aurora/client/BUILD 
c55adfe9825b77f418e41fa9a4ba43926bd991ed 
  src/test/python/apache/aurora/client/api/BUILD 
65b378b0b4c5fa11f9899ef04a4a10a211f37245 
  src/test/python/apache/aurora/client/cli/BUILD 
0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
  src/test/python/apache/aurora/client/hooks/BUILD 
0b924ccfbcdb4800f99b80067ff8a78252f99907 
  src/test/python/apache/aurora/common/BUILD 
9b1d4d876e10cb759202240931e4787ce673d897 
  src/test/python/apache/aurora/config/BUILD 
c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 
  src/test/python/apache/aurora/executor/BUILD 
8fff66ef8858af892ba1124454fefb07715943d7 
  src/test/python/apache/aurora/executor/bin/BUILD 
713ce9529e36c70e1dde17a724efe7631c7aca4c 
  src/test/python/apache/aurora/executor/common/BUILD 
b3da27bb83c44a228851b256cc09f093d1e2eb87 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
cc326562db59eee807b22c4ee16d753abb3c6468 
  src/test/python/apache/thermos/cli/BUILD 
087b1740de4d8a30c74c7776eb83f9784e0049cc 
  src/test/python/apache/thermos/cli/commands/BUILD 
5465b19be5ab8bdf7252e7b1fa7a4ef95063193d 
  src/test/python/apache/thermos/common/BUILD 
bb70867e0e070ee9651f018f30990bd9ff0dd88f 
  src/test/python/apache/thermos/config/BUILD 
a06af36c83fc7ec00ecd00df7e424faae3118131 
  src/test/python/apache/thermos/core/BUILD 
d637c24f098468776fb8b0758f5990b83ec362c5 
  src/test/python/apache/thermos/monitoring/BUILD 
f4ad7fc1245980ef727c7c4a30af89b2d8d1293a 
  src/test/python/apache/thermos/observer/BUILD 
ff92a52fe7a88379e8aa1c1b2385c065bd375a68 
  src/test/python/apache/thermos/observer/http/BUILD 
0cdaafc3e71d21d48c35e0dac68910c53d003fae 

Diff: https://reviews.apache.org/r/36972/diff/


Testing (updated)
---

./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Manually checked that `thermos status` works.

I don't have a test environment for the debian package or the spec file.

Documentation pushed to 
https://github.com/kevints/aurora/blob/36972/docs/build-system.md


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney



> On July 31, 2015, 3:57 p.m., Joshua Cohen wrote:
> > I'm -1 to shipping without something under docs/ explaining this 
> > organizational structure.
> 
> Bill Farner wrote:
> maybe a README.md under `src/main/python/apache` instead?

I've added a new file docs/build-system.md


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93805
---


On July 31, 2015, 4:18 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36972/
> ---
> 
> (Updated July 31, 2015, 4:18 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is a mostly red code diff and makes the pants build work similar to how 
> it already works in an IDE environment while minimizing duplicated 
> information. This change also removes the confusing versions of `thermos` and 
> `thermos_observer` in favor of new ones. Because of the way "covering 
> dependencies" were required it was easier to do this refactor than more 
> tactically create a working `setup_py` target for `apache.aurora.tools` 
> without cycles and without duplicated files.
> 
> * Remove the `apache.thermos` package.
> * Rename the `apache.gen.aurora` package to `apache.aurora.thrift`.
> * Rename the `apache.gen.thermos` package to `apache.thermos.thrift`.
> * Introduce a new `apache.aurora.tools` package with the `thermos` and 
> `thermos_observer` binaries.
> * Create apache.thermos.runner package, rename `thermos/bin` to 
> `thermos/runner`.
> * Remove all `*-packaged` and virtual dependency trees, as well as the phrase 
> "covering dependencies."
> * Use `_`-prefix naming convention for private target names.
> * Replace manual list of targets in `make-python-sdists` with 
> automatically-generated one (using new convention).
> * Introduce a new `apache.aurora.kerberos` package with the `kaurora` and 
> `kaurora_admin` binaries.
> * Remove all `BUILD` files in `src/main` that don't contain an exported 
> `setup.py` library (except one mentioned in TODO).
> * Use dictionary syntax in `with_binaries`.
> * Remove unused/unreachable binaries (most `bin/` dirs under `thermos/`).
> * Create blank `__init__.py` files in directories that pants warns aren't 
> packages.
> * Added `thermos` command to vagrant image.
> 
> 
> Diffs
> -
> 
>   NEWS 0a8500c524a92eaf51384125687128d2fbbb0b53 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> d196fefc2c5e5ee32d0cf9c901cffe7d247379d1 
>   api/src/main/thrift/org/apache/thermos/BUILD 
> d0d789a6ee3971e3070f9397d53929563a77f7ea 
>   build-support/packaging/debian/rules 
> 17e00c02a3cb3294d5107516d795a73587ca4f70 
>   build-support/packaging/rpm/aurora.spec 
> 7cf8de6f7b99788ca461a90fc4aefba7dccd7b63 
>   build-support/release/make-python-sdists 
> 9608f68e16243da01434ce2fc7d61bb7c7efd712 
>   docs/README.md 9893763cb75faf1aeb66ed905e9f696d4b532d16 
>   docs/build-system.md PRE-CREATION 
>   examples/vagrant/aurorabuild.sh fbaa6ae9ef7ff2910af8c9c0d6b8ef90ea3e152a 
>   src/main/python/apache/aurora/admin/BUILD 
> 22bf3f9943ea11258ba681bdb80feb00206bb926 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> 1c39717b656465bb1966073340f9fe80be01a085 
>   src/main/python/apache/aurora/client/BUILD 
> e73cd52289209bb9658b16bb77dc0b0a9c811a1a 
>   src/main/python/apache/aurora/client/api/BUILD 
> a030a67b78fc4bc4682d0df169e27efc6810dce3 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 973d05971bd940c7e38c48ce6bfbf5c8e1654c5a 
>   src/main/python/apache/aurora/client/cli/client.py 
> c0974f3bef59f8f7c2320398d367cb4dd9048d2b 
>   src/main/python/apache/aurora/client/hooks/BUILD 
> ddf813b5d2e7d63507a8e08745ebf6cb3dbac8e1 
>   src/main/python/apache/aurora/common/BUILD 
> abc122b0775bb17b1df67bdb946c472010219b9b 
>   src/main/python/apache/aurora/common/auth/BUILD 
> 0abac94eeeb71e6af43ed191ea690e5f96a6be23 
>   src/main/python/apache/aurora/common/auth/kerberos.py 
> 2d782b63b611a9d2604ef0ab1116d3e68fb86dc7 
>   src/main/python/apache/aurora/config/BUILD 
> 0a3a93fa6bb785903f71bc067aecc79c0e45a0b5 
>   src/main/python/apache/aurora/config/schema/BUILD 
> 171f42a24ec7ddc2846eb68b6a60e7d8dec4383b 
>   src/main/python/apache/aurora/executor/BUILD 
&g

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney

che/thermos/cli/commands/BUILD 
552eeb4f61693033d8828e789bd22e680b957d1d 
  src/main/python/apache/thermos/common/BUILD 
942fc15f5a5d6a5ff58385b10f3783ac476a4f82 
  src/main/python/apache/thermos/config/BUILD 
d9099c5806eadb1190d2028142a7ec711023d39f 
  src/main/python/apache/thermos/config/bin/config_load.py 
d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e 
  src/main/python/apache/thermos/config/bin/config_repl.py 
ae9ca3b2812f719b0a6185081434d557492ac825 
  src/main/python/apache/thermos/core/BUILD 
d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea 
  src/main/python/apache/thermos/monitoring/BUILD 
e8851026cb7ff59f0fd719837fdb0110be356c31 
  src/main/python/apache/thermos/observer/BUILD 
41db2cc2e11234c434f58f55abec0b9f308096be 
  src/main/python/apache/thermos/observer/bin/BUILD 
0abe2ccfe9c5ccb509ad731125385900114ba352 
  src/main/python/apache/thermos/observer/bin/__init__.py  
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
39d3994a6163746e853cd21fc4c3585edc2b54cb 
  src/main/python/apache/thermos/observer/http/BUILD 
0bd770453dc78b043c9e6171dc7439da19c5872e 
  src/main/python/apache/thermos/testing/BUILD 
8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 
  src/test/python/apache/aurora/BUILD c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 
  src/test/python/apache/aurora/admin/BUILD 
69da2c97cb08025a27ca276bb2ad6fcc43db1b10 
  src/test/python/apache/aurora/client/BUILD 
c55adfe9825b77f418e41fa9a4ba43926bd991ed 
  src/test/python/apache/aurora/client/api/BUILD 
65b378b0b4c5fa11f9899ef04a4a10a211f37245 
  src/test/python/apache/aurora/client/cli/BUILD 
0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
  src/test/python/apache/aurora/client/hooks/BUILD 
0b924ccfbcdb4800f99b80067ff8a78252f99907 
  src/test/python/apache/aurora/common/BUILD 
9b1d4d876e10cb759202240931e4787ce673d897 
  src/test/python/apache/aurora/config/BUILD 
c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 
  src/test/python/apache/aurora/executor/BUILD 
8fff66ef8858af892ba1124454fefb07715943d7 
  src/test/python/apache/aurora/executor/bin/BUILD 
713ce9529e36c70e1dde17a724efe7631c7aca4c 
  src/test/python/apache/aurora/executor/common/BUILD 
b3da27bb83c44a228851b256cc09f093d1e2eb87 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
cc326562db59eee807b22c4ee16d753abb3c6468 
  src/test/python/apache/thermos/cli/BUILD 
087b1740de4d8a30c74c7776eb83f9784e0049cc 
  src/test/python/apache/thermos/cli/commands/BUILD 
5465b19be5ab8bdf7252e7b1fa7a4ef95063193d 
  src/test/python/apache/thermos/common/BUILD 
bb70867e0e070ee9651f018f30990bd9ff0dd88f 
  src/test/python/apache/thermos/config/BUILD 
a06af36c83fc7ec00ecd00df7e424faae3118131 
  src/test/python/apache/thermos/core/BUILD 
d637c24f098468776fb8b0758f5990b83ec362c5 
  src/test/python/apache/thermos/monitoring/BUILD 
f4ad7fc1245980ef727c7c4a30af89b2d8d1293a 
  src/test/python/apache/thermos/observer/BUILD 
ff92a52fe7a88379e8aa1c1b2385c065bd375a68 
  src/test/python/apache/thermos/observer/http/BUILD 
0cdaafc3e71d21d48c35e0dac68910c53d003fae 

Diff: https://reviews.apache.org/r/36972/diff/


Testing
---

./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Manually checked that `thermos status` works.

I don't have a test environment for the debian package or the spec file.

Documentation pushed to 
https://github.com/kevints/aurora/blob/36972/docs/build-system.md


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-08-01 Thread Kevin Sweeney

che/thermos/cli/bin/thermos.py 
fcef38d33e7ca2005f35c3bdb90ffee6aeade3af 
  src/main/python/apache/thermos/cli/commands/BUILD 
552eeb4f61693033d8828e789bd22e680b957d1d 
  src/main/python/apache/thermos/common/BUILD 
942fc15f5a5d6a5ff58385b10f3783ac476a4f82 
  src/main/python/apache/thermos/config/BUILD 
d9099c5806eadb1190d2028142a7ec711023d39f 
  src/main/python/apache/thermos/config/bin/config_load.py 
d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e 
  src/main/python/apache/thermos/config/bin/config_repl.py 
ae9ca3b2812f719b0a6185081434d557492ac825 
  src/main/python/apache/thermos/core/BUILD 
d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea 
  src/main/python/apache/thermos/monitoring/BUILD 
e8851026cb7ff59f0fd719837fdb0110be356c31 
  src/main/python/apache/thermos/observer/BUILD 
41db2cc2e11234c434f58f55abec0b9f308096be 
  src/main/python/apache/thermos/observer/bin/BUILD 
0abe2ccfe9c5ccb509ad731125385900114ba352 
  src/main/python/apache/thermos/observer/bin/__init__.py  
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
39d3994a6163746e853cd21fc4c3585edc2b54cb 
  src/main/python/apache/thermos/observer/http/BUILD 
0bd770453dc78b043c9e6171dc7439da19c5872e 
  src/main/python/apache/thermos/testing/BUILD 
8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 
  src/test/python/apache/aurora/BUILD c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 
  src/test/python/apache/aurora/admin/BUILD 
69da2c97cb08025a27ca276bb2ad6fcc43db1b10 
  src/test/python/apache/aurora/client/BUILD 
c55adfe9825b77f418e41fa9a4ba43926bd991ed 
  src/test/python/apache/aurora/client/api/BUILD 
65b378b0b4c5fa11f9899ef04a4a10a211f37245 
  src/test/python/apache/aurora/client/cli/BUILD 
0d85f5fba9d19ae0e9c36546f130b93664b4f6de 
  src/test/python/apache/aurora/client/hooks/BUILD 
0b924ccfbcdb4800f99b80067ff8a78252f99907 
  src/test/python/apache/aurora/common/BUILD 
9b1d4d876e10cb759202240931e4787ce673d897 
  src/test/python/apache/aurora/config/BUILD 
c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 
  src/test/python/apache/aurora/executor/BUILD 
8fff66ef8858af892ba1124454fefb07715943d7 
  src/test/python/apache/aurora/executor/bin/BUILD 
713ce9529e36c70e1dde17a724efe7631c7aca4c 
  src/test/python/apache/aurora/executor/common/BUILD 
b3da27bb83c44a228851b256cc09f093d1e2eb87 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
cc326562db59eee807b22c4ee16d753abb3c6468 
  src/test/python/apache/thermos/cli/BUILD 
087b1740de4d8a30c74c7776eb83f9784e0049cc 
  src/test/python/apache/thermos/cli/commands/BUILD 
5465b19be5ab8bdf7252e7b1fa7a4ef95063193d 
  src/test/python/apache/thermos/common/BUILD 
bb70867e0e070ee9651f018f30990bd9ff0dd88f 
  src/test/python/apache/thermos/config/BUILD 
a06af36c83fc7ec00ecd00df7e424faae3118131 
  src/test/python/apache/thermos/core/BUILD 
d637c24f098468776fb8b0758f5990b83ec362c5 
  src/test/python/apache/thermos/monitoring/BUILD 
f4ad7fc1245980ef727c7c4a30af89b2d8d1293a 
  src/test/python/apache/thermos/observer/BUILD 
ff92a52fe7a88379e8aa1c1b2385c065bd375a68 
  src/test/python/apache/thermos/observer/http/BUILD 
0cdaafc3e71d21d48c35e0dac68910c53d003fae 

Diff: https://reviews.apache.org/r/36972/diff/


Testing (updated)
---

./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
./build-support/python/make-pycharm-virtualenv

Manually checked that `thermos status` works.

I don't have a test environment for the debian package or the spec file.

Documentation pushed to 
https://github.com/kevints/aurora/blob/36972/docs/build-system.md


Thanks,

Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

2015-08-03 Thread Kevin Sweeney



> On July 31, 2015, 3:21 p.m., Brian Wickman wrote:
> > I think it makes sense to split into two binary-exporting packages: one 
> > client-side and one server-side.  The client side (aurora.client) should 
> > contain aurora client and aurora admin client. The server-side (reuse 
> > aurora.executor?) should contain aurora executor, thermos cli, thermos 
> > observer and thermos runner.
> 
> Kevin Sweeney wrote:
> I like this suggestion and would like to refactor the code to fit it into 
> this framework. Would you accept that in a follow-up review?
> 
> Specifically there would then be 3 top-level packages (5 if you count the 
> thrift API bindings, which I would also like to export to allow folks to 
> write clients)
> 
> ```
> src/main/python/apache/aurora
>   common/
>   client/
>   executor/
> ```
> 
> ```
> % pip install apache.aurora.executor
> # thermos
> # thermos-executor
> # thermos-observer
> # thermos-runner
> 
> % pip install apache.aurora.client
> # aurora
> # aurora-admin
> ```
> 
> Everything else would remain more-or-less organized the same but move to 
> a subpackage of one of the top-level targets. The rule is simple - if both 
> server-side and client-side import something it goes under common/, otherwise 
> it goes under client/ or executor/ as appropriate.
> 
> Brian Wickman wrote:
> This seems reasonable.  I'd prefer to keep the name aurora-executor but 
> it probably merits public debate.

The name aurora-executor is fine with me, in this case I've left it unchanged 
as "thermos_executor". But I agree a debate on the proposed renaming can take 
place on another review.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93793
---


On Aug. 1, 2015, 3:38 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36972/
> ---
> 
> (Updated Aug. 1, 2015, 3:38 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
> https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is a mostly red code diff and makes the pants build work similar to how 
> it already works in an IDE environment while minimizing duplicated 
> information. This change also removes the confusing versions of `thermos` and 
> `thermos_observer` in favor of new ones. Because of the way "covering 
> dependencies" were required it was easier to do this refactor than more 
> tactically create a working `setup_py` target for `apache.aurora.tools` 
> without cycles and without duplicated files.
> 
> * Remove the `apache.thermos` package.
> * Rename the `apache.gen.aurora` package to `apache.aurora.thrift`.
> * Rename the `apache.gen.thermos` package to `apache.thermos.thrift`.
> * Introduce a new `apache.aurora.tools` package with the `thermos` and 
> `thermos_observer` binaries.
> * Create apache.thermos.runner package, rename `thermos/bin` to 
> `thermos/runner`.
> * Remove all `*-packaged` and virtual dependency trees, as well as the phrase 
> "covering dependencies."
> * Use `_`-prefix naming convention for private target names.
> * Replace manual list of targets in `make-python-sdists` with 
> automatically-generated one (using new convention).
> * Introduce a new `apache.aurora.kerberos` package with the `kaurora` and 
> `kaurora_admin` binaries.
> * Remove all `BUILD` files in `src/main` that don't contain an exported 
> `setup.py` library (except one mentioned in TODO).
> * Use dictionary syntax in `with_binaries`.
> * Remove unused/unreachable binaries (most `bin/` dirs under `thermos/`).
> * Create blank `__init__.py` files in directories that pants warns aren't 
> packages.
> * Added `thermos` command to vagrant image.
> 
> 
> Diffs
> -
> 
>   NEWS 0a8500c524a92eaf51384125687128d2fbbb0b53 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> d196fefc2c5e5ee32d0cf9c901cffe7d247379d1 
>   api/src/main/thrift/org/apache/thermos/BUILD 
> d0d789a6ee3971e3070f9397d53929563a77f7ea 
>   build-support/packaging/debian/rules 
> 17e00c02a3cb3294d5107516d795a73587ca4f70 
>   build-support/packaging/rpm/aurora.spec 
> 7cf8de6f7b99788ca461a90fc4aefba7dccd7b63 
>   build-support/

Re: Review Request 36874: Fix typo in the scheduler deployment documentation

2015-08-03 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36874/#review93943
---


ping

- Kevin Sweeney


On July 27, 2015, 8:01 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36874/
> ---
> 
> (Updated July 27, 2015, 8:01 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix typo in scheduler deployment documentation
> 
> The command should be run on schedulers, not masters.
> 
> 
> Diffs
> -
> 
>   docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d 
> 
> Diff: https://reviews.apache.org/r/36874/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Review Request 37047: Build Kerberos clients in RPM.

2015-08-03 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37047/
---

Review request for Aurora, Steve Salevan and Bill Farner.


Bugs: AURORA-1410
https://issues.apache.org/jira/browse/AURORA-1410


Repository: aurora


Description
---

Build Kerberos clients in RPM.


Diffs
-

  build-support/packaging/rpm/aurora.spec 
3003ced1451f20b8e33d8532645fab85fffbca74 

Diff: https://reviews.apache.org/r/37047/diff/


Testing
---

None - I don't have a test environment for RPMs.


Thanks,

Kevin Sweeney

1 2 3 >

1 - 100 of 273 matches

Mail list logo