date:20141114

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Maxim Khutornenko



> On Nov. 14, 2014, 2:24 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 226
> > 
> >
> > To get the data we want, some extra analysis is needed.  Specifically - 
> > if we want to figure out how often a scheduling attempt is vetoed _only_ 
> > for static reasons (e.g. insufficient resources), these stats will lack 
> > signal.
> > 
> > Instead, we probably want two counters:
> > - scheduling_veto_static
> > - scheduling_veto_dynamic
> > 
> > Does that make sense?
> 
> Maxim Khutornenko wrote:
> I don't see how more granular data would prevent us from aggregating into 
> static/dynamic groups. However, having aggregate metrics instead will make it 
> impossible to do any further analysis when needed. Why not going the more 
> specific route instead? I would have hard time figuring out what 
> "scheduling_veto_static" means without digging through the sources, whereas 
> something like "scheduling_veto_INSUFFICIENT_RESOURCES" would immediately 
> make sense by itself.
> 
> Bill Farner wrote:
> The problem is that you can't discern when a task didn't match due to 
> _only_ static reasons.  Relevant code in `SchedulingFilterImpl`:
> 
> return ImmutableSet.builder()
> .addAll(getConstraintFilter(attributeAggregate, 
> attributes).apply(task))
> .addAll(getResourceVetoes(offer, task))
> .build();
> 
> On the other end when you incrmeent counters:
> 
> for (Veto veto : event.getVetoes()) {
>   counters.getUnchecked(vetoStatName(veto)).increment();
> }
> 
> At this point, you might get vetoes like: `insufficient CPU`, 
> `insufficient RAM`, `insufficient ports`, `limit not satisfied: host`.
> You'll end up with these counter deltas:
> 
> `INSUFFICIENT_RESOURCES 3`
> `LIMIT_NOT_SATISFIED 1`
> 
> As a result, i don't see how we could look at the stats and convince 
> ourselves which optimization has the greatest payoff, since a single 
> scheduling round affects multiple counters disproportionately.

Isn't it the same problem with the aggregate counters? I.e. in the above 
example we would still see static=1 (or 3?) and dynamic=1.

To address your concern of excessive counting, how about maintaining unique 
veto type counters instead? Something like this:
```java
ListMultimap index = Multimaps.index(event.getVetoes(), 
VETO_TO_VETO_TYPE);
for (VetoType vetoType : index.keys()) {
  counters.getUnchecked(vetoStatName(vetoType)).increment();
}
```
For the above example, it would produce:

scheduling_veto_INSUFFICIENT_RESOURCES 1
scheduling_veto_LIMIT_NOT_SATISFIED  1


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review61385
---


On Nov. 14, 2014, 12:30 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> ---
> 
> (Updated Nov. 14, 2014, 12:30 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
> https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> e2ba8b8fe978a58d1edcd01963ea020e54529353 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c1c5f26723f1eac3000e09e061b4582f922fded6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> cc6b53b3265253f76c1e954c0108aa5936f5cc36 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 87203690f09456ac1ca5e9da2b82826d60cbd723 
>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
> aaedb3b5ec2cb27550449435efa8f335c6a9baad 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 12ea4c67350c2992f59bacd21a99d1413b60b757 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  94f0a179b786649775899f855f7c1a0caab7290f 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  e113eba1f304279b5ee3d70db1d1ea558efd63ac 
>   src/test/java/org/apache

Review Request 28048: Fix task_util dependency and add it to all target.

2014-11-14 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28048/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

Fix task_util dependency and add it to all target.


Diffs
-

  src/test/python/apache/aurora/client/api/BUILD 
b4f08c6192e6bf6b38665197e98db7235751ae86 

Diff: https://reviews.apache.org/r/28048/diff/


Testing
---

Before:
[tw-mbp-zmanji aurora (master)]$ ./pants 
src/test/python/apache/aurora/client/api:task_util
Build operating on top level addresses: 
set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD,
 task_util)])
 test session starts 

platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
plugins: cov, timeout
collected 0 items / 1 errors

== ERRORS 
===
 ERROR collecting 
src/test/python/apache/aurora/client/api/test_task_util.py 

src/test/python/apache/aurora/client/api/test_task_util.py:22: in 
from ..api.api_util import SchedulerThriftApiSpec
src/test/python/apache/aurora/client/api/api_util.py:1: in 
from apache.aurora.client.api.scheduler_client import SchedulerProxy
E   ImportError: No module named scheduler_client
== 1 error in 0.18 seconds 
==
src.test.python.apache.aurora.client.api.task_util  
.   FAILURE

After:
[tw-mbp-zmanji aurora (fix-task-util-test)]$ ./pants 
src/test/python/apache/aurora/client/api:task_util
Build operating on top level addresses: 
set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD,
 task_util)])
 test session starts 

platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
plugins: cov, timeout
collected 2 items

src/test/python/apache/aurora/client/api/test_task_util.py ..

= 2 passed in 0.45 seconds 
==
src.test.python.apache.aurora.client.api.task_util  
.   SUCCESS


Thanks,

Zameer Manji

Re: Review Request 28048: Fix task_util dependency and add it to all target.

2014-11-14 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28048/#review61475
---

Ship it!


Ship It!

- Maxim Khutornenko


On Nov. 14, 2014, 7 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28048/
> ---
> 
> (Updated Nov. 14, 2014, 7 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix task_util dependency and add it to all target.
> 
> 
> Diffs
> -
> 
>   src/test/python/apache/aurora/client/api/BUILD 
> b4f08c6192e6bf6b38665197e98db7235751ae86 
> 
> Diff: https://reviews.apache.org/r/28048/diff/
> 
> 
> Testing
> ---
> 
> Before:
> [tw-mbp-zmanji aurora (master)]$ ./pants 
> src/test/python/apache/aurora/client/api:task_util
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD,
>  task_util)])
>  test session starts 
> 
> platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
> plugins: cov, timeout
> collected 0 items / 1 errors
> 
> == ERRORS 
> ===
>  ERROR collecting 
> src/test/python/apache/aurora/client/api/test_task_util.py 
> 
> src/test/python/apache/aurora/client/api/test_task_util.py:22: in 
> from ..api.api_util import SchedulerThriftApiSpec
> src/test/python/apache/aurora/client/api/api_util.py:1: in 
> from apache.aurora.client.api.scheduler_client import SchedulerProxy
> E   ImportError: No module named scheduler_client
> == 1 error in 0.18 
> seconds ==
> src.test.python.apache.aurora.client.api.task_util
>   .   FAILURE
> 
> After:
> [tw-mbp-zmanji aurora (fix-task-util-test)]$ ./pants 
> src/test/python/apache/aurora/client/api:task_util
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD,
>  task_util)])
>  test session starts 
> 
> platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
> plugins: cov, timeout
> collected 2 items
> 
> src/test/python/apache/aurora/client/api/test_task_util.py ..
> 
> = 2 passed in 0.45 
> seconds ==
> src.test.python.apache.aurora.client.api.task_util
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28048: Fix task_util dependency and add it to all target.

2014-11-14 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28048/#review61482
---

Ship it!


Master (e9f135d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 14, 2014, 7 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28048/
> ---
> 
> (Updated Nov. 14, 2014, 7 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix task_util dependency and add it to all target.
> 
> 
> Diffs
> -
> 
>   src/test/python/apache/aurora/client/api/BUILD 
> b4f08c6192e6bf6b38665197e98db7235751ae86 
> 
> Diff: https://reviews.apache.org/r/28048/diff/
> 
> 
> Testing
> ---
> 
> Before:
> [tw-mbp-zmanji aurora (master)]$ ./pants 
> src/test/python/apache/aurora/client/api:task_util
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD,
>  task_util)])
>  test session starts 
> 
> platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
> plugins: cov, timeout
> collected 0 items / 1 errors
> 
> == ERRORS 
> ===
>  ERROR collecting 
> src/test/python/apache/aurora/client/api/test_task_util.py 
> 
> src/test/python/apache/aurora/client/api/test_task_util.py:22: in 
> from ..api.api_util import SchedulerThriftApiSpec
> src/test/python/apache/aurora/client/api/api_util.py:1: in 
> from apache.aurora.client.api.scheduler_client import SchedulerProxy
> E   ImportError: No module named scheduler_client
> == 1 error in 0.18 
> seconds ==
> src.test.python.apache.aurora.client.api.task_util
>   .   FAILURE
> 
> After:
> [tw-mbp-zmanji aurora (fix-task-util-test)]$ ./pants 
> src/test/python/apache/aurora/client/api:task_util
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD,
>  task_util)])
>  test session starts 
> 
> platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
> plugins: cov, timeout
> collected 2 items
> 
> src/test/python/apache/aurora/client/api/test_task_util.py ..
> 
> = 2 passed in 0.45 
> seconds ==
> src.test.python.apache.aurora.client.api.task_util
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Maxim Khutornenko



> On Nov. 14, 2014, 2:24 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 226
> > 
> >
> > To get the data we want, some extra analysis is needed.  Specifically - 
> > if we want to figure out how often a scheduling attempt is vetoed _only_ 
> > for static reasons (e.g. insufficient resources), these stats will lack 
> > signal.
> > 
> > Instead, we probably want two counters:
> > - scheduling_veto_static
> > - scheduling_veto_dynamic
> > 
> > Does that make sense?
> 
> Maxim Khutornenko wrote:
> I don't see how more granular data would prevent us from aggregating into 
> static/dynamic groups. However, having aggregate metrics instead will make it 
> impossible to do any further analysis when needed. Why not going the more 
> specific route instead? I would have hard time figuring out what 
> "scheduling_veto_static" means without digging through the sources, whereas 
> something like "scheduling_veto_INSUFFICIENT_RESOURCES" would immediately 
> make sense by itself.
> 
> Bill Farner wrote:
> The problem is that you can't discern when a task didn't match due to 
> _only_ static reasons.  Relevant code in `SchedulingFilterImpl`:
> 
> return ImmutableSet.builder()
> .addAll(getConstraintFilter(attributeAggregate, 
> attributes).apply(task))
> .addAll(getResourceVetoes(offer, task))
> .build();
> 
> On the other end when you incrmeent counters:
> 
> for (Veto veto : event.getVetoes()) {
>   counters.getUnchecked(vetoStatName(veto)).increment();
> }
> 
> At this point, you might get vetoes like: `insufficient CPU`, 
> `insufficient RAM`, `insufficient ports`, `limit not satisfied: host`.
> You'll end up with these counter deltas:
> 
> `INSUFFICIENT_RESOURCES 3`
> `LIMIT_NOT_SATISFIED 1`
> 
> As a result, i don't see how we could look at the stats and convince 
> ourselves which optimization has the greatest payoff, since a single 
> scheduling round affects multiple counters disproportionately.
> 
> Maxim Khutornenko wrote:
> Isn't it the same problem with the aggregate counters? I.e. in the above 
> example we would still see static=1 (or 3?) and dynamic=1.
> 
> To address your concern of excessive counting, how about maintaining 
> unique veto type counters instead? Something like this:
> ```java
> ListMultimap index = 
> Multimaps.index(event.getVetoes(), VETO_TO_VETO_TYPE);
> for (VetoType vetoType : index.keys()) {
>   counters.getUnchecked(vetoStatName(vetoType)).increment();
> }
> ```
> For the above example, it would produce:
> 
> scheduling_veto_INSUFFICIENT_RESOURCES 1
> scheduling_veto_LIMIT_NOT_SATISFIED  1

Discussed with Bill offline. There is more logic to it. It's not just about 
gouping metrics but rather reporting the group when ALL of the Vetos issued 
fall into the same group. For example: 
- insufficient RAM, limit not satisfied - only "static" vetos -> increment 
"static" counter;
- constraint mismatch, insufficient RAM - mixed "static" and "dynamic" vetos -> 
increment "mixed" counter;
- constraint mismatch - only "dynamic" vetos -> increment "dynamic" counter;


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review61385
---


On Nov. 14, 2014, 12:30 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> ---
> 
> (Updated Nov. 14, 2014, 12:30 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
> https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> e2ba8b8fe978a58d1edcd01963ea020e54529353 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c1c5f26723f1eac3000e09e061b4582f922fded6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> cc6b53b3265253f76c1e954c0108aa5936f5cc36 
>   src/main/java/org/apache/aurora/scheduler/meta

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-14 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61506
---

Ship it!


Ship It!

- David McLaughlin


On Nov. 14, 2014, 1:30 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28026/
> ---
> 
> (Updated Nov. 14, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
> branch coverage.  The remaining pieces are legitimately difficult to capture.
> 
> I also uncovered a few minor bugs along the way, most noteworthy being AOP 
> interceptor ordering leading to the standard API response not always being 
> applied.
> 
> Additionally, i removed a bunch of unnecessary exception handling that is now 
> done by an AOP interceptor.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> dca855c522d21924821fc47e636da39689aec4b7 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/28026/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

2014-11-14 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27698/#review61513
---

Ship it!



src/test/python/apache/aurora/client/api/test_scheduler_client.py


nit: our python style uses `**kws` instead of `**kwargs`


- Kevin Sweeney


On Nov. 13, 2014, 5:03 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27698/
> ---
> 
> (Updated Nov. 13, 2014, 5:03 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Brian Wickman, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The underlying Kazoo code here has an uninterruptable wait on the main 
> thread, which means if there are any problems establishing a connection then 
> you need to hard kill the client process. Moving the code to a separate 
> thread.  
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 3a851cc9f53380b4bf2e9df47080e7c476c3e38e 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1f1c6e0ab686cc63bf0a6b7a36e7eef688644e74 
> 
> Diff: https://reviews.apache.org/r/27698/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client:all
> src.test.python.apache.aurora.client.api.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.mux  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.restarter
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater_util 
>   .   SUCCESS
> src.test.python.apache.aurora.client.binding_helper   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.bridge   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.config   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.cron 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.help 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.inspect  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.job  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.logging  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.quota
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.supdate  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.task 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.update   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.admin   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.core
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.hooks   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.run 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh 
>   .   SUCCESS
> src.test.python.apache.aurora.client.config   
>   .   SUCCESS
> src.test.python.apache.aurora.clien

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

2014-11-14 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27698/
---

(Updated Nov. 14, 2014, 9:58 p.m.)


Review request for Aurora, Kevin Sweeney, Brian Wickman, and Zameer Manji.


Changes
---

Use kws.


Repository: aurora


Description
---

The underlying Kazoo code here has an uninterruptable wait on the main thread, 
which means if there are any problems establishing a connection then you need 
to hard kill the client process. Moving the code to a separate thread.  


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/scheduler_client.py 
3a851cc9f53380b4bf2e9df47080e7c476c3e38e 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
1f1c6e0ab686cc63bf0a6b7a36e7eef688644e74 

Diff: https://reviews.apache.org/r/27698/diff/


Testing
---

./pants src/test/python/apache/aurora/client:all
src.test.python.apache.aurora.client.api.api
.   SUCCESS
src.test.python.apache.aurora.client.api.disambiguator  
.   SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher   
.   SUCCESS
src.test.python.apache.aurora.client.api.job_monitor
.   SUCCESS
src.test.python.apache.aurora.client.api.mux
.   SUCCESS
src.test.python.apache.aurora.client.api.quota_check
.   SUCCESS
src.test.python.apache.aurora.client.api.restarter  
.   SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client   
.   SUCCESS
src.test.python.apache.aurora.client.api.sla
.   SUCCESS
src.test.python.apache.aurora.client.api.updater
.   SUCCESS
src.test.python.apache.aurora.client.api.updater_util   
.   SUCCESS
src.test.python.apache.aurora.client.binding_helper 
.   SUCCESS
src.test.python.apache.aurora.client.cli.api
.   SUCCESS
src.test.python.apache.aurora.client.cli.bridge 
.   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks  
.   SUCCESS
src.test.python.apache.aurora.client.cli.config 
.   SUCCESS
src.test.python.apache.aurora.client.cli.cron   
.   SUCCESS
src.test.python.apache.aurora.client.cli.help   
.   SUCCESS
src.test.python.apache.aurora.client.cli.inspect
.   SUCCESS
src.test.python.apache.aurora.client.cli.job
.   SUCCESS
src.test.python.apache.aurora.client.cli.logging
.   SUCCESS
src.test.python.apache.aurora.client.cli.plugins
.   SUCCESS
src.test.python.apache.aurora.client.cli.quota  
.   SUCCESS
src.test.python.apache.aurora.client.cli.sla
.   SUCCESS
src.test.python.apache.aurora.client.cli.supdate
.   SUCCESS
src.test.python.apache.aurora.client.cli.task   
.   SUCCESS
src.test.python.apache.aurora.client.cli.update 
.   SUCCESS
src.test.python.apache.aurora.client.commands.admin 
.   SUCCESS
src.test.python.apache.aurora.client.commands.core  
.   SUCCESS
src.test.python.apache.aurora.client.commands.hooks 
.   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance   
.   SUCCESS
src.test.python.apache.aurora.client.commands.run   
.   SUCCESS
src.test.python.apache.aurora.client.commands.ssh   
.   SUCCESS
src.test.python.apache.aurora.client.config 
.   SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api   
.   SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api   
.   SUCCESS


Thanks,

David McLaughlin

Re: Review Request 27852: Ensure run verb returns an exit code.

2014-11-14 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27852/
---

(Updated Nov. 14, 2014, 2:15 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

Bill's feedback.


Bugs: AURORA-923
https://issues.apache.org/jira/browse/AURORA-923


Repository: aurora


Description
---

Ensure run verb returns an exit code.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/task.py 
91175facdc8c9fd59ab66781f86ee8b5940a 
  src/test/python/apache/aurora/client/cli/BUILD 
e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
  src/test/python/apache/aurora/client/cli/test_kill.py 
e3a366bf67074e50787394cad58d5e01359b641e 
  src/test/python/apache/aurora/client/cli/test_task_run.py 
8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b 

Diff: https://reviews.apache.org/r/27852/diff/


Testing
---

./pants build src/test/python/apache/aurora/client/cli::


Thanks,

Zameer Manji

Re: Review Request 27852: Ensure all verbs return an exit code.

2014-11-14 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27852/
---

(Updated Nov. 14, 2014, 2:16 p.m.)


Review request for Aurora and Bill Farner.


Summary (updated)
-

Ensure all verbs return an exit code.


Bugs: AURORA-923
https://issues.apache.org/jira/browse/AURORA-923


Repository: aurora


Description (updated)
---

Ensure all verbs return an exit code.

This patch ensures all verbs returns an exit code and all verbs implement the 
execute method.


Diffs
-

  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/task.py 
91175facdc8c9fd59ab66781f86ee8b5940a 
  src/test/python/apache/aurora/client/cli/BUILD 
e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
  src/test/python/apache/aurora/client/cli/test_kill.py 
e3a366bf67074e50787394cad58d5e01359b641e 
  src/test/python/apache/aurora/client/cli/test_task_run.py 
8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b 

Diff: https://reviews.apache.org/r/27852/diff/


Testing
---

./pants build src/test/python/apache/aurora/client/cli::


Thanks,

Zameer Manji

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/
---

(Updated Nov. 14, 2014, 10:16 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Converted from individual to group veto counters.


Bugs: AURORA-914
https://issues.apache.org/jira/browse/AURORA-914


Repository: aurora


Description
---

Adding @Timed to trace scheduling latencies and Veto counters per type.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
cf8f7584afee758c527798914181049051aef0d8 
  src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
e2ba8b8fe978a58d1edcd01963ea020e54529353 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
4821a7890b77ccb04c10bee6d8b4b9e7216940cc 
  src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
3839083f27ca5d4b93406152559b58b04e912a10 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
c1c5f26723f1eac3000e09e061b4582f922fded6 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
cc6b53b3265253f76c1e954c0108aa5936f5cc36 
  src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
87203690f09456ac1ca5e9da2b82826d60cbd723 
  src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
aaedb3b5ec2cb27550449435efa8f335c6a9baad 
  src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
12ea4c67350c2992f59bacd21a99d1413b60b757 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 94f0a179b786649775899f855f7c1a0caab7290f 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
e113eba1f304279b5ee3d70db1d1ea558efd63ac 
  src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
b60b004adbd6753ec6fef125fd70286be5071c56 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 

Diff: https://reviews.apache.org/r/27705/diff/


Testing
---

./gradlew -Pq build
Verified new stats in vagrant.


Thanks,

Maxim Khutornenko

Re: Review Request 27852: Ensure all verbs return an exit code.

2014-11-14 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27852/#review61527
---

Ship it!


Master (8741cdb) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 14, 2014, 10:16 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27852/
> ---
> 
> (Updated Nov. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-923
> https://issues.apache.org/jira/browse/AURORA-923
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Ensure all verbs return an exit code.
> 
> This patch ensures all verbs returns an exit code and all verbs implement the 
> execute method.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/task.py 
> 91175facdc8c9fd59ab66781f86ee8b5940a 
>   src/test/python/apache/aurora/client/cli/BUILD 
> e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> e3a366bf67074e50787394cad58d5e01359b641e 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b 
> 
> Diff: https://reviews.apache.org/r/27852/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python/apache/aurora/client/cli::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review61529
---


This patch does not apply cleanly on master (8741cdb), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 14, 2014, 10:16 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> ---
> 
> (Updated Nov. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
> https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> e2ba8b8fe978a58d1edcd01963ea020e54529353 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 4821a7890b77ccb04c10bee6d8b4b9e7216940cc 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c1c5f26723f1eac3000e09e061b4582f922fded6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> cc6b53b3265253f76c1e954c0108aa5936f5cc36 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 87203690f09456ac1ca5e9da2b82826d60cbd723 
>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
> aaedb3b5ec2cb27550449435efa8f335c6a9baad 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 12ea4c67350c2992f59bacd21a99d1413b60b757 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  94f0a179b786649775899f855f7c1a0caab7290f 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  e113eba1f304279b5ee3d70db1d1ea558efd63ac 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> b60b004adbd6753ec6fef125fd70286be5071c56 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/27705/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Verified new stats in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review61525
---



src/main/java/org/apache/aurora/scheduler/TaskVars.java


Please define static and dynamic vetos in a comment here.



src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java


I think this will fail checkStyle.


- Zameer Manji


On Nov. 14, 2014, 2:16 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> ---
> 
> (Updated Nov. 14, 2014, 2:16 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
> https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> e2ba8b8fe978a58d1edcd01963ea020e54529353 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 4821a7890b77ccb04c10bee6d8b4b9e7216940cc 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c1c5f26723f1eac3000e09e061b4582f922fded6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> cc6b53b3265253f76c1e954c0108aa5936f5cc36 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 87203690f09456ac1ca5e9da2b82826d60cbd723 
>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
> aaedb3b5ec2cb27550449435efa8f335c6a9baad 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 12ea4c67350c2992f59bacd21a99d1413b60b757 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  94f0a179b786649775899f855f7c1a0caab7290f 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  e113eba1f304279b5ee3d70db1d1ea558efd63ac 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> b60b004adbd6753ec6fef125fd70286be5071c56 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/27705/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Verified new stats in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review61537
---

Ship it!


Ship It!

- Zameer Manji


On Nov. 14, 2014, 2:16 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> ---
> 
> (Updated Nov. 14, 2014, 2:16 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
> https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> e2ba8b8fe978a58d1edcd01963ea020e54529353 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 4821a7890b77ccb04c10bee6d8b4b9e7216940cc 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c1c5f26723f1eac3000e09e061b4582f922fded6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> cc6b53b3265253f76c1e954c0108aa5936f5cc36 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 87203690f09456ac1ca5e9da2b82826d60cbd723 
>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
> aaedb3b5ec2cb27550449435efa8f335c6a9baad 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 12ea4c67350c2992f59bacd21a99d1413b60b757 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  94f0a179b786649775899f855f7c1a0caab7290f 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  e113eba1f304279b5ee3d70db1d1ea558efd63ac 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> b60b004adbd6753ec6fef125fd70286be5071c56 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/27705/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Verified new stats in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 28021: Remove dependency on commons-lang.

2014-11-14 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/#review61564
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 14, 2014, 1:07 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28021/
> ---
> 
> (Updated Nov. 14, 2014, 1:07 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove dependency on commons-lang.
> 
> 
> Diffs
> -
> 
>   build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  3661f8487985f631e3ea437fe6430e0296376a9e 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java
>  4eb4437b91906ae191dd105474e84ba5f40cf52e 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
> 48b403e155684861ec0307a61ccb0775cdb57a32 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
> 37176237fac336413267f3c8bb4e1b9a6255150c 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  a43e5d7748c22d60f56f03a8a3d52949faebeff2 
> 
> Diff: https://reviews.apache.org/r/28021/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Maxim Khutornenko



> On Nov. 14, 2014, 10:46 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 64
> > 
> >
> > Please define static and dynamic vetos in a comment here.

Thanks for reminding. Meant to do that but it slipped. Done.


> On Nov. 14, 2014, 10:46 p.m., Zameer Manji wrote:
> > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java, line 55
> > 
> >
> > I think this will fail checkStyle.

Damn intellij. Tweaked a few settings in CodeStyle -> Imports to hopefully 
never see it again.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review61525
---


On Nov. 14, 2014, 10:16 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> ---
> 
> (Updated Nov. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
> https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> e2ba8b8fe978a58d1edcd01963ea020e54529353 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 4821a7890b77ccb04c10bee6d8b4b9e7216940cc 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c1c5f26723f1eac3000e09e061b4582f922fded6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> cc6b53b3265253f76c1e954c0108aa5936f5cc36 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 87203690f09456ac1ca5e9da2b82826d60cbd723 
>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
> aaedb3b5ec2cb27550449435efa8f335c6a9baad 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 12ea4c67350c2992f59bacd21a99d1413b60b757 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  94f0a179b786649775899f855f7c1a0caab7290f 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  e113eba1f304279b5ee3d70db1d1ea558efd63ac 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> b60b004adbd6753ec6fef125fd70286be5071c56 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/27705/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Verified new stats in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/
---

(Updated Nov. 15, 2014, 12:15 a.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

CR comments.


Bugs: AURORA-914
https://issues.apache.org/jira/browse/AURORA-914


Repository: aurora


Description
---

Adding @Timed to trace scheduling latencies and Veto counters per type.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
cf8f7584afee758c527798914181049051aef0d8 
  src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
6bfa3ac425ed3045fa60d1b0ca547e9bf3cde37a 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
4821a7890b77ccb04c10bee6d8b4b9e7216940cc 
  src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
3839083f27ca5d4b93406152559b58b04e912a10 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
c1c5f26723f1eac3000e09e061b4582f922fded6 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
cc6b53b3265253f76c1e954c0108aa5936f5cc36 
  src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
87203690f09456ac1ca5e9da2b82826d60cbd723 
  src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
aaedb3b5ec2cb27550449435efa8f335c6a9baad 
  src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
12ea4c67350c2992f59bacd21a99d1413b60b757 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 94f0a179b786649775899f855f7c1a0caab7290f 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
e113eba1f304279b5ee3d70db1d1ea558efd63ac 
  src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
b60b004adbd6753ec6fef125fd70286be5071c56 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 608903268a0a0d67711bfdc81d2e5b29c335ead2 

Diff: https://reviews.apache.org/r/27705/diff/


Testing
---

./gradlew -Pq build
Verified new stats in vagrant.


Thanks,

Maxim Khutornenko

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review61578
---


Master (8741cdb) is red with this patch.
  ./build-support/jenkins/build.sh

  File "/usr/lib/python2.7/sysconfig.py", line 355, in _init_posix
raise IOError(msg)
IOError: invalid Python installation: unable to open 
/x1/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/local/include/python2.7/pyconfig.h
 (No such file or directory)

Build operating on top level addresses: 
set([BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/au
 th/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 base)), PythonLibrary
 
(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/
 workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 job_monitor)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 quota_check)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace
 /AuroraBot/src/main/python/apache/aurora/admin/BUILD, host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD,
 util)), 
PythonTests(Bui

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review61582
---


@ReviewBot retry

- Maxim Khutornenko


On Nov. 15, 2014, 12:15 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> ---
> 
> (Updated Nov. 15, 2014, 12:15 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
> https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 6bfa3ac425ed3045fa60d1b0ca547e9bf3cde37a 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 4821a7890b77ccb04c10bee6d8b4b9e7216940cc 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c1c5f26723f1eac3000e09e061b4582f922fded6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> cc6b53b3265253f76c1e954c0108aa5936f5cc36 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 87203690f09456ac1ca5e9da2b82826d60cbd723 
>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
> aaedb3b5ec2cb27550449435efa8f335c6a9baad 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 12ea4c67350c2992f59bacd21a99d1413b60b757 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  94f0a179b786649775899f855f7c1a0caab7290f 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  e113eba1f304279b5ee3d70db1d1ea558efd63ac 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> b60b004adbd6753ec6fef125fd70286be5071c56 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  608903268a0a0d67711bfdc81d2e5b29c335ead2 
> 
> Diff: https://reviews.apache.org/r/27705/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Verified new stats in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-14 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review61586
---

Ship it!


Master (8741cdb) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 15, 2014, 12:15 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> ---
> 
> (Updated Nov. 15, 2014, 12:15 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
> https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 6bfa3ac425ed3045fa60d1b0ca547e9bf3cde37a 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 4821a7890b77ccb04c10bee6d8b4b9e7216940cc 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c1c5f26723f1eac3000e09e061b4582f922fded6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> cc6b53b3265253f76c1e954c0108aa5936f5cc36 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 87203690f09456ac1ca5e9da2b82826d60cbd723 
>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
> aaedb3b5ec2cb27550449435efa8f335c6a9baad 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 12ea4c67350c2992f59bacd21a99d1413b60b757 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  94f0a179b786649775899f855f7c1a0caab7290f 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  e113eba1f304279b5ee3d70db1d1ea558efd63ac 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> b60b004adbd6753ec6fef125fd70286be5071c56 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  608903268a0a0d67711bfdc81d2e5b29c335ead2 
> 
> Diff: https://reviews.apache.org/r/27705/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Verified new stats in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 28066: Fixing flaky test.

2014-11-14 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28066/
---

Review request for Aurora and Kevin Sweeney.


Bugs: AURORA-798
https://issues.apache.org/jira/browse/AURORA-798


Repository: aurora


Description
---

Looking at the EeasyMock.Results it does not appear to be thread safe wrt call 
count recording. That resulted in about 20% flakiness that I could repro 
locally. Replacing the exact count expectations by .atLeastOnce() as the test 
conditions are still asserted by the CountdownLatch.


Diffs
-

  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
6e499d1d82d5748ffc0d578283139f39e93316a7 

Diff: https://reviews.apache.org/r/28066/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 28066: Fixing flaky test.

2014-11-14 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28066/#review61587
---


Master (8741cdb) is red with this patch.
  ./build-support/jenkins/build.sh

+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean
:bootstrapThrift
:checkPython
:generateSources
:compileGeneratedJavaNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:processGeneratedResources UP-TO-DATE
:generatedClasses
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:jsHint
:checkstyleMain
:compileTestJava
:processTestResources
:testClasses
:checkstyleTest[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java:41:8:
 Unused import - org.junit.Ignore.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleTest'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/test.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 32.266 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 15, 2014, 1:06 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28066/
> ---
> 
> (Updated Nov. 15, 2014, 1:06 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-798
> https://issues.apache.org/jira/browse/AURORA-798
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Looking at the EeasyMock.Results it does not appear to be thread safe wrt 
> call count recording. That resulted in about 20% flakiness that I could repro 
> locally. Replacing the exact count expectations by .atLeastOnce() as the test 
> conditions are still asserted by the CountdownLatch.
> 
> 
> Diffs
> -
> 
>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
> 6e499d1d82d5748ffc0d578283139f39e93316a7 
> 
> Diff: https://reviews.apache.org/r/28066/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 28021: Remove dependency on commons-lang.

2014-11-14 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/#review61588
---

Ship it!


Ship It!

- Kevin Sweeney


On Nov. 13, 2014, 5:07 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28021/
> ---
> 
> (Updated Nov. 13, 2014, 5:07 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove dependency on commons-lang.
> 
> 
> Diffs
> -
> 
>   build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  3661f8487985f631e3ea437fe6430e0296376a9e 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java
>  4eb4437b91906ae191dd105474e84ba5f40cf52e 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
> 48b403e155684861ec0307a61ccb0775cdb57a32 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
> 37176237fac336413267f3c8bb4e1b9a6255150c 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  a43e5d7748c22d60f56f03a8a3d52949faebeff2 
> 
> Diff: https://reviews.apache.org/r/28021/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28066: Fixing flaky test.

2014-11-14 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28066/
---

(Updated Nov. 15, 2014, 1:53 a.m.)


Review request for Aurora and Kevin Sweeney.


Changes
---

Adding missing import removal.


Bugs: AURORA-798
https://issues.apache.org/jira/browse/AURORA-798


Repository: aurora


Description
---

Looking at the EeasyMock.Results it does not appear to be thread safe wrt call 
count recording. That resulted in about 20% flakiness that I could repro 
locally. Replacing the exact count expectations by .atLeastOnce() as the test 
conditions are still asserted by the CountdownLatch.


Diffs (updated)
-

  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
6e499d1d82d5748ffc0d578283139f39e93316a7 

Diff: https://reviews.apache.org/r/28066/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 28021: Remove dependency on commons-lang.

2014-11-14 Thread Zameer Manji



> On Nov. 14, 2014, 5:16 p.m., Kevin Sweeney wrote:
> > Ship It!

Kevin, can you please commit this? Thanks.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/#review61588
---


On Nov. 13, 2014, 5:07 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28021/
> ---
> 
> (Updated Nov. 13, 2014, 5:07 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove dependency on commons-lang.
> 
> 
> Diffs
> -
> 
>   build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  3661f8487985f631e3ea437fe6430e0296376a9e 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java
>  4eb4437b91906ae191dd105474e84ba5f40cf52e 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
> 48b403e155684861ec0307a61ccb0775cdb57a32 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
> 37176237fac336413267f3c8bb4e1b9a6255150c 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  a43e5d7748c22d60f56f03a8a3d52949faebeff2 
> 
> Diff: https://reviews.apache.org/r/28021/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28066: Fixing flaky test.

2014-11-14 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28066/#review61610
---

Ship it!


Master (8741cdb) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 15, 2014, 1:53 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28066/
> ---
> 
> (Updated Nov. 15, 2014, 1:53 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-798
> https://issues.apache.org/jira/browse/AURORA-798
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Looking at the EeasyMock.Results it does not appear to be thread safe wrt 
> call count recording. That resulted in about 20% flakiness that I could repro 
> locally. Replacing the exact count expectations by .atLeastOnce() as the test 
> conditions are still asserted by the CountdownLatch.
> 
> 
> Diffs
> -
> 
>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
> 6e499d1d82d5748ffc0d578283139f39e93316a7 
> 
> Diff: https://reviews.apache.org/r/28066/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Review Request 28048: Fix task_util dependency and add it to all target.

Re: Review Request 28048: Fix task_util dependency and add it to all target.

Re: Review Request 28048: Fix task_util dependency and add it to all target.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

Re: Review Request 27852: Ensure run verb returns an exit code.

Re: Review Request 27852: Ensure all verbs return an exit code.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Re: Review Request 27852: Ensure all verbs return an exit code.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Re: Review Request 28021: Remove dependency on commons-lang.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

Review Request 28066: Fixing flaky test.

Re: Review Request 28066: Fixing flaky test.

Re: Review Request 28021: Remove dependency on commons-lang.

Re: Review Request 28066: Fixing flaky test.

Re: Review Request 28021: Remove dependency on commons-lang.

Re: Review Request 28066: Fixing flaky test.

27 matches

Site Navigation

Mail list logo

Footer information