[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
Michael Ho has posted comments on this change. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5940/3/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: PS3, Line 312: 102 Looks like this should be 101. -- To view, visit http://gerrit.cloudera.org:8080/5940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9878d7000b03a64ee06c2088a8c30e318fe1d2a3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic
Ambreen Kazi has uploaded a new patch set (#2). Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic This is part 2 of the work being done to genericize the Impala security topics. All references to Cloudera have been either marked 'hidden' or replaced with links to the relevant open-source docs. Note: -Links to the standalone Cloudera ODBC driver doc have not been removed. -External links to the MIT Kerberos docs and Hadoop security docs were added to impala_keydefs. Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_delegation.xml M docs/topics/impala_kerberos.xml M docs/topics/impala_ldap.xml 5 files changed, 56 insertions(+), 37 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/5962/2 -- To view, visit http://gerrit.cloudera.org:8080/5962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Ambreen KaziGerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/259/ -- To view, visit http://gerrit.cloudera.org:8080/5909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543d4d428d7240e0f710d67973867162f2fcabc8 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris TsirogiannisGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes
Bharath Vissapragada has uploaded a new patch set (#12). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of Impalads and Catalog server for debugging purposes. Currently, there is no way to do that without a restart of the daemons, which is not a viable option in production deployments. This patch addresses this supportability gap by exposing the ability to set dynamic logging levels using a simple web endpoint on Impalad and Catalog web pages. This includes setting VLOG levels (equivalent to --v flag) as well as setting log4j levels on the Frontend and the Catalog JVMs. Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 --- M be/src/catalog/catalog-server.cc M be/src/service/impala-http-handler.cc M be/src/statestore/statestore.cc M be/src/util/jni-util.cc M be/src/util/jni-util.h M be/src/util/logging-support.cc M be/src/util/logging-support.h M common/thrift/Logging.thrift M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/java/org/apache/impala/util/GlogAppender.java M tests/webserver/test_web_pages.py A www/log_level.tmpl 12 files changed, 475 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/5792/12 -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath VissapragadaGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Marcel Kornacker
[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 7: (16 comments) http://gerrit.cloudera.org:8080/#/c/5792/7/be/src/util/logging-support.cc File be/src/util/logging-support.cc: PS7, Line 225: result.insert(0, "Effective log level: "); > Mustache supports basic conditionals - you're using one already in the temp Oh makes sense. Thanks for explaining this. http://gerrit.cloudera.org:8080/#/c/5792/11/be/src/util/logging-support.cc File be/src/util/logging-support.cc: PS11, Line 81: ic jmethodID se > I don't think this is the default, but the originally set value (because th Done PS11, Line 96: MethodDescriptor get_log_ > anon namespace Ouch I thought I already put that. Got confused with the bracketing. Thanks for pointing that out. PS11, Line 217: s_name(log_setclass- > What information does Status::GetDetail() give you that just passing in the Any errors in the codepaths of calling jni methods (JniUtil::CallJniMethod()). PS11, Line 241: ::Parse > Although I see that this construction compiles in Impala, I can't make it c Done PS11, Line 251: > just 'classname' or similar. 'log_setclass' is hard to understand. Done PS11, Line 252: td::to_string > just 'level'? Prefer conciseness where you can reasonably do so without com Done Line 255: } else if (args.find("reset_glog_log") != args.end()) { > No SetErrorMessage()? Done PS11, Line 267: > empty Done PS11, Line 301: > if these are not used outside of this module, please put them in the anonym Done http://gerrit.cloudera.org:8080/#/c/5792/11/be/src/util/logging-support.h File be/src/util/logging-support.h: PS11, Line 22: #include "util/webserver.h" > not needed: just forward declare the class. Done Line 27: struct UTF8; > While you're here - re-wrap to 90 chars. Done Line 39: > std:: Done PS11, Line 39: > register_log4j_handlers? 'init_log4j' makes it sound like the log4j subsyst Done http://gerrit.cloudera.org:8080/#/c/5792/11/common/thrift/Logging.thrift File common/thrift/Logging.thrift: PS11, Line 34: // Helper structs for GetJavaLogLevel(), SetJavaLogLevel() and : // ResetJavaLogLevel() methods > This doesn't really help me - comment should say what they're used for. Done http://gerrit.cloudera.org:8080/#/c/5792/7/www/log_level.tmpl File www/log_level.tmpl: PS7, Line 76: > Look at the other templates to see how they do layout? Thanks for the pointer. Pretty helpful. Moved the code to bootstrap. Looks much better. -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath VissapragadaGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/259/ -- To view, visit http://gerrit.cloudera.org:8080/5909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543d4d428d7240e0f710d67973867162f2fcabc8 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris TsirogiannisGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 5510: Decimal8Value(4) > Yeah that's right. Rather than adjusting all this by hand, I think we shoul Sounds good. -- To view, visit http://gerrit.cloudera.org:8080/5959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan HechtGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 5510: Decimal8Value(4) > Probably doesn't matter but this can be Decimal4Value(), right ? Same below Yeah that's right. Rather than adjusting all this by hand, I think we should just convert this to the table-driven style (and then the correct Decimal*Value is chosen for us, and we can run these cases with v2=1). So how about I save that (looks like there's a handful of them using the wrong size). -- To view, visit http://gerrit.cloudera.org:8080/5959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan HechtGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 5510: Decimal8Value(4) Probably doesn't matter but this can be Decimal4Value(), right ? Same below. PS2, Line 5585: Decimal8Value Decimal4Value() ? -- To view, visit http://gerrit.cloudera.org:8080/5959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan HechtGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs This uses the existing infrastructure for codegening builtin UDAs and for codegening calls to UDFs. GetUdf() is refactored to support both UDFs and UDAs. IR UDAs are still not allowed by the frontend. It's unclear if we want to enable them going forward because of the difficulties in testing and supporting IR UDFs/UDAs. This also fixes some bugs with the Get*Type() methods of FunctionContext. GetArgType() and related methods now always return the logical input types of the aggregate function. Getting the tests to pass required fixing IMPALA-4878 because they called GetIntermediateType(). Testing: test_udfs.py tests UDAs with codegen enabled and disabled. Added some asserts to test UDAs to check that the correct types are passed in via the FunctionContext. Change-Id: Id1708eaa96eb76fb9bec5eeabf209f81c88eec2f Reviewed-on: http://gerrit.cloudera.org:8080/5161 Reviewed-by: Dan HechtTested-by: Impala Public Jenkins --- M be/src/codegen/codegen-anyval.cc M be/src/codegen/codegen-anyval.h M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/partitioned-aggregation-node.cc M be/src/exprs/agg-fn-evaluator.cc M be/src/exprs/agg-fn-evaluator.h M be/src/exprs/anyval-util.cc M be/src/exprs/anyval-util.h M be/src/exprs/expr.cc M be/src/exprs/expr.h M be/src/exprs/scalar-fn-call.cc M be/src/exprs/scalar-fn-call.h M be/src/exprs/timestamp-functions.cc M be/src/runtime/types.cc M be/src/runtime/types.h M be/src/testutil/test-udas.cc M be/src/testutil/test-udas.h M be/src/udf/udf-internal.h M be/src/udf/udf-ir.cc M be/src/udf/udf.h M common/thrift/Exprs.thrift M fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M testdata/workloads/functional-query/queries/QueryTest/uda.test M tests/query_test/test_udfs.py 26 files changed, 501 insertions(+), 248 deletions(-) Approvals: Impala Public Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1708eaa96eb76fb9bec5eeabf209f81c88eec2f Gerrit-PatchSet: 24 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/3/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: PS3, Line 297: round ? dv.ToIntVal(scale) : to_type(dv.whole_part(scale)); perhaps pass 'round' to ToInt() and move the "else" block in there since it's basically the truncation case. that way we're more symmetric. and then the to_type can stay here, and instead ToInt() can return the primitive (like whole_part() does), which would keep all the conversions between DecimalValue and udf::*IntVal types within this code, which I think makes more sense since this code is the UDF builtin code, whereas DecimalValue is the decimal slot representation code internal to impala. http://gerrit.cloudera.org:8080/#/c/5951/3/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: Line 88: return RESULT_T::null(); > That's a good idea. Should I still be returning raw UDF types (in which ca I would probably leave the UDF type (e.g. BigIntVal) out of here and just return the raw primitive, unless using the UDF type simplifies things for some reason. -- To view, visit http://gerrit.cloudera.org:8080/5951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach AmsdenGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/3/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: Line 84: auto divisor = DecimalUtil::GetScaleMultiplier(scale); > doesn't round, of course. Done. Turns out you can do this without branching. I think right now I have a branch but I can get rid of it. Line 88: return RESULT_T::null(); > how about sticking with the convention used in the rest of this file where That's a good idea. Should I still be returning raw UDF types (in which case I need to return the null version of the type). -- To view, visit http://gerrit.cloudera.org:8080/5951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach AmsdenGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4809: Codegen support for DECIMAL V2
Dan Hecht has posted comments on this change. Change subject: IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5950/1/be/src/exec/partitioned-aggregation-node.cc File be/src/exec/partitioned-aggregation-node.cc: PS1, Line 1740: output_type > Tim fixed this as well in https://gerrit.cloudera.org/#/c/5161/23. Same fix or, after seeing the full patch, i think you can just revert this to avoid the conflict. -- To view, visit http://gerrit.cloudera.org:8080/5950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2434d240f65b81389b8a8ba027f980a0e1d1f981 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael HoGerrit-Reviewer: Dan Hecht Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3586: Implement union passthrough
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/5816/4/be/src/exec/union-node.cc File be/src/exec/union-node.cc: Line 133: DCHECK(!IsInSubplan()); > Do we have coverage of that kind of plan shape though? If someone else come Done. Added a Union + subplan test to Planner tests and end to end tests. http://gerrit.cloudera.org:8080/#/c/5816/6/be/src/exec/union-node.cc File be/src/exec/union-node.cc: Line 103: if (!children_.empty()) RETURN_IF_ERROR(child(0)->Open(state)); > I think we need to reset 'child_batch_' here so that it has the correct 'ro I don't think we need to reset here. It already gets reset on line 179 in this file. Line 114: if (UNLIKELY(child_idx_ >= children_.size() && > My preference is to remove this code if it's not needed for correctness and Done Line 153: // Even though the child is at eos, it's not OK to Close() it here, like we do in > I think this comment over-explains some resource management things that are Done http://gerrit.cloudera.org:8080/#/c/5816/4/fe/src/main/java/org/apache/impala/planner/UnionNode.java File fe/src/main/java/org/apache/impala/planner/UnionNode.java: Line 266: Preconditions.checkState(exprList.size() == slots.size()); > nullableTupleIds_ in child PlanNode is essentially part of the row layout a Done http://gerrit.cloudera.org:8080/#/c/5816/4/testdata/workloads/functional-planner/queries/PlannerTest/union.test File testdata/workloads/functional-planner/queries/PlannerTest/union.test: Line 3103: > Was this addressed? Yes, added a union + join test with several joins in Planner and end to end tests. See PlannerTest/union.test and QueryTest/union.test -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras BobrovytskyGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9878d7000b03a64ee06c2088a8c30e318fe1d2a3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()
Dan Hecht has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 21: Is that just a rebase? Any fixes needed for the last failing run? -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 21 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach AmsdenGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2
Dan Hecht has uploaded a new patch set (#6). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. IMPALA-4370: Divide and modulo result types for DECIMAL version V2 Implement the new DECIMAL return type rules for divide and modulo expressions, active when query option DECIMAL_V2=1. See the comment in the code for more details. A couple of examples that show why new return type rules for divide are desirable. For modulo, the return types are actually equivalent, though the rules are expressed differently to have consistency with how precision fixups are handled for each version. DECIMAL Version 1: +---+ | cast(1 as decimal(20,0)) / cast(3 as decimal(20,0)) | +-+ | 0 | +---+ DECIMAL Version 2: +---+ | cast(1 as decimal(20,0)) / cast(3 as decimal(20,0)) | +-+ | 0.33| +---+ DECIMAL Version 1: +---+ | cast(1 as decimal(6,0)) / cast(0.1 as decimal(38,38)) | +---+ | NULL | +---+ WARNINGS: UDF WARNING: Expression overflowed, returning NULL DECIMAL Version 2: +---+ | cast(1 as decimal(6,0)) / cast(0.1 as decimal(38,38)) | +---+ | 10.00 | +---+ Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b --- M be/src/exprs/expr-test.cc M be/src/runtime/decimal-value.inline.h M be/src/testutil/impalad-query-executor.h M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/analysis/TypesUtil.java M fe/src/main/java/org/apache/impala/catalog/ScalarType.java M fe/src/main/java/org/apache/impala/catalog/Type.java A testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test M tests/query_test/test_decimal_queries.py 10 files changed, 325 insertions(+), 75 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/5952/6 -- To view, visit http://gerrit.cloudera.org:8080/5952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan HechtGerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden
[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()
Hello Impala Public Jenkins, Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#21). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser needs to be tweaked to allow this, since function names act as bare identifiers. It was difficult to get this to match performance of regexp_replace. For expanding patterns, the fact that regexp_replace copies the expansion inline means that it may in fact win on large strings with sparse matches that are > dcache size apart. Let's leave optimizing that for later. Testing: Added a full test for maximum size strings and got most of the boundary conditions I could identify. Manually ran queries on TPC-H dataset in impala to verify both performance and correctness. Added large string and exprs.test test clauses and ran the tests to verify they work as expected. Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 --- M be/src/exprs/expr-test.cc M be/src/exprs/string-functions-ir.cc M be/src/exprs/string-functions.h M be/src/gutil/bits.h M be/src/udf/udf-internal.h M be/src/udf/udf-test-harness.cc M be/src/udf/udf-test-harness.h M be/src/udf/udf.cc M be/src/udf/udf.h M common/function-registry/impala_functions.py M fe/src/main/cup/sql-parser.cup M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M testdata/workloads/functional-query/queries/QueryTest/exprs.test M testdata/workloads/functional-query/queries/QueryTest/large_strings.test 14 files changed, 401 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/5776/21 -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 21 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach AmsdenGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zach Amsden
[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types
Dan Hecht has uploaded a new patch set (#2). Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. IMPALA-4810: fix incorrect expr-test decimal types Many of the types for the decimal round/truncate and related tests are incorrect. This was never caught because the type was only used by the string parser, and larger types would work. The change for IMPALA-4370 adds validation of the expected type, so fix these. Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b --- M be/src/exprs/expr-test.cc M be/src/runtime/types.cc 2 files changed, 101 insertions(+), 87 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/5959/2 -- To view, visit http://gerrit.cloudera.org:8080/5959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan HechtGerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden
[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 2: Code-Review+2 Here is a screenshot from my dev box for the catalog/memz https://cloudera.box.com/s/uug5z4zpkfqhhkgxrrejskjvc9l2hh2u It's the same for the impalad/memz as well. -- To view, visit http://gerrit.cloudera.org:8080/5909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543d4d428d7240e0f710d67973867162f2fcabc8 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris TsirogiannisGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 1: Why doesn't this change also pull in the validation of the resulting Decimal types to validate the fixes ? -- To view, visit http://gerrit.cloudera.org:8080/5959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan HechtGerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/5959 Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. IMPALA-4810: fix incorrect expr-test decimal types Many of the types for the decimal round/truncate and related tests are incorrect. This was never caught because the type was only used by the string parser, and larger types would work. The change for IMPALA-4370 adds validation of the expected type, so fix these. Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b --- M be/src/exprs/expr-test.cc 1 file changed, 80 insertions(+), 80 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/5959/1 -- To view, visit http://gerrit.cloudera.org:8080/5959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht
[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu .. Patch Set 1: (1 comment) Nice! I think it looks good, just a comment about some additional test cases as we discussed. Maybe Alex/Marcel can think of other corner cases we need to consider but seems straightforward to me. http://gerrit.cloudera.org:8080/#/c/5958/1/testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test: would be good to add some negative test cases demonstrating why it doesn't make sense when there are casts: [localhost:21000] > select cast(1000 as tinyint); Query: select cast(1000 as tinyint) Query submitted at: 2017-02-09 14:23:55 (Coordinator: http://mj-desktop.ca.cloudera.com:25000) Query progress can be monitored at: http://mj-desktop.ca.cloudera.com:25000/query_plan?query_id=ed4cdbe536ffdca4:ad65d6a0 +---+ | cast(1000 as tinyint) | +---+ | 0 | +---+ Fetched 1 row(s) in 0.06s [localhost:21000] > select cast("1000" as tinyint); Query: select cast("1000" as tinyint) Query submitted at: 2017-02-09 14:24:09 (Coordinator: http://mj-desktop.ca.cloudera.com:25000) Query progress can be monitored at: http://mj-desktop.ca.cloudera.com:25000/query_plan?query_id=6146365d55608409:d09dc182 +-+ | cast('1000' as tinyint) | +-+ | NULL| +-+ Fetched 1 row(s) in 0.01s -- To view, visit http://gerrit.cloudera.org:8080/5958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c96fec8d41f77222879c0ffdd6940b168e47e65 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnellGerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. IMPALA-3410 [DOCS] Rework Impala security topics to be generic This is part 1 of the changes being made to the Impala authorization topics. References to CDH and Cloudera Manager docs/products have been either 'hidden' or removed completely. Examples with Sentry have been made more generic. Instances of Cloudera-specific folders or filenames have been removed. Change-Id: Ie5c4431f3236b18fc282343ed98513f0e578130e Reviewed-on: http://gerrit.cloudera.org:8080/5931 Reviewed-by: Jim AppleReviewed-by: John Russell Tested-by: Impala Public Jenkins --- M docs/shared/impala_common.xml M docs/topics/impala_authorization.xml M docs/topics/impala_security.xml M docs/topics/impala_security_install.xml M docs/topics/impala_ssl.xml 5 files changed, 84 insertions(+), 93 deletions(-) Approvals: Impala Public Jenkins: Verified Jim Apple: Looks good to me, but someone else must approve John Russell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5c4431f3236b18fc282343ed98513f0e578130e Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Ambreen Kazi Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5c4431f3236b18fc282343ed98513f0e578130e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Ambreen KaziGerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5958 Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu .. IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu This detects IS NULL / IS NOT NULL and creates a Kudu predicate to push this to Kudu. Since the KuduPredicate.newIsNullPredicate function is only available in a newer version of the Kudu Java client, that client version is bumped to 1.3.0. Change-Id: I9c96fec8d41f77222879c0ffdd6940b168e47e65 --- M bin/impala-config.sh M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test 4 files changed, 46 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/5958/1 -- To view, visit http://gerrit.cloudera.org:8080/5958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9c96fec8d41f77222879c0ffdd6940b168e47e65 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell
[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic
John Russell has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5c4431f3236b18fc282343ed98513f0e578130e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Ambreen KaziGerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/38/ -- To view, visit http://gerrit.cloudera.org:8080/5931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5c4431f3236b18fc282343ed98513f0e578130e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Ambreen KaziGerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 23: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/258/ -- To view, visit http://gerrit.cloudera.org:8080/5161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1708eaa96eb76fb9bec5eeabf209f81c88eec2f Gerrit-PatchSet: 23 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
Dan Hecht has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 23: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1708eaa96eb76fb9bec5eeabf209f81c88eec2f Gerrit-PatchSet: 23 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Bump Kudu version to latest Kudu master
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump Kudu version to latest Kudu master .. Bump Kudu version to latest Kudu master Change-Id: Ib72a0b63cdffb852bd17e69faa0a36edbfda22d7 Reviewed-on: http://gerrit.cloudera.org:8080/5929 Reviewed-by: Matthew JacobsTested-by: Impala Public Jenkins --- M bin/impala-config.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Matthew Jacobs: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib72a0b63cdffb852bd17e69faa0a36edbfda22d7 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] Bump Kudu version to latest Kudu master
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to latest Kudu master .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib72a0b63cdffb852bd17e69faa0a36edbfda22d7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew JacobsGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. IMPALA-4849: IllegalStateException from rewritten CASE expr In SelectList.reset(), we call reset() on each select list item's expr. reset() is supposed to remove implicit casts, by returning the reset expr with implicit cast exprs removed from the tree. Previously SelectList.reset() ignored the return value of the calls to Expr.reset(), meaning that if the top-most expr of the select list item is an implicit cast, it won't actually get removed, which causes problems with analysis since implicit casts are always treated as pre-analyzed. The solution is to set the select list item's exprs to the return value of reset(). Testing: - Added a regression test to exprs.test Change-Id: I16ff88716b185e1d72d2bc603a42bd06c60ec18e Reviewed-on: http://gerrit.cloudera.org:8080/5917 Reviewed-by: Alex BehmTested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/SelectList.java M testdata/workloads/functional-query/queries/QueryTest/exprs.test 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16ff88716b185e1d72d2bc603a42bd06c60ec18e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ff88716b185e1d72d2bc603a42bd06c60ec18e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-MarshallGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.
Ambreen Kazi has uploaded a new change for review. http://gerrit.cloudera.org:8080/5957 Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic. .. IMPALA-3411 [DOCS] Rework Impala governance topics to be generic. This set of edits removes references and links to Cloudera Navigator and Cloudera Manager from the auditing and lineage topics. Those were either marked as 'hidden' or replaced with a generic suggestion to use cluster management software with a focus on governance. Some paragraphs with overflowing lines were also fixed. Change-Id: I192bc2d1de89e55418c045d1a0e5433cf02cf782 --- M docs/topics/impala_auditing.xml M docs/topics/impala_lineage.xml 2 files changed, 58 insertions(+), 35 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/5957/1 -- To view, visit http://gerrit.cloudera.org:8080/5957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I192bc2d1de89e55418c045d1a0e5433cf02cf782 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Ambreen Kazi
[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/257/ -- To view, visit http://gerrit.cloudera.org:8080/5940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9878d7000b03a64ee06c2088a8c30e318fe1d2a3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
Dan Hecht has posted comments on this change. Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. Patch Set 2: > Uploaded patch set 2. buffer-block-mgr-test needed an update due to the error message text changing. -- To view, visit http://gerrit.cloudera.org:8080/5940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9878d7000b03a64ee06c2088a8c30e318fe1d2a3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5940 to look at the new patch set (#2). Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky .. IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky The test should allow Unpin() to fail with a scratch allocation error to handle the case where the first write fails and blacklists the scratch disk around the same time that the second write starts. Usually either the second write succeeds because it started before the first write failed or it fails with CANCELLED because the BufferedBlockMgr::is_cancelled_ flag is set. There is a small window for a race after the disk is blacklisted in TmpFileMgr but before BufferedBlockMgr::WriteComplete() is called. Testing: I was able to reproduce the problem locally by adding some delays to the test. I added a variant of the WriteError test that more reliably reproduces the bug. Ran both WriteError tests in a loop locally to try to flush out flakiness. Change-Id: I9878d7000b03a64ee06c2088a8c30e318fe1d2a3 --- M be/src/runtime/buffered-block-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc M common/thrift/generate_error_codes.py 3 files changed, 47 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/5940/2 -- To view, visit http://gerrit.cloudera.org:8080/5940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9878d7000b03a64ee06c2088a8c30e318fe1d2a3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: > > I'm not opposed to cleaning up the AnyVal stuff like that, but > > given that udf.h stuff dictates UDF compatibility, it's not > > completely trivial. It doesn't look like it would break binary > > compatibility though. But, in case something goes wrong, how > about > > we do that as a separate change so it could be backed out without > > affecting the decimal work? It doesn't look like the decimal > stuff > > will depend on it, right? > > No, but it gets a lot cleaner to test the limits by giving the > generic form an underlying type. I deliberately did not change > FloatVal, since the equality operator is currently kind of broken. > Everything else should be binary compatible. But you can get that by looking at *Val::val, no? Another thing to watch out for is that since users write and compile their own UDFs, we've had trouble in the past with accidently increasing the C++ version required to build these things. I don't remember the specific problems (maybe Michael or Tim do) and also don't know whether that's a real issue with this change. -- To view, visit http://gerrit.cloudera.org:8080/5951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach AmsdenGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Release note updates for Impala 2.8
Laurel Hale has posted comments on this change. Change subject: [DOCS] Release note updates for Impala 2.8 .. Patch Set 9: (3 comments) Some nits you can think about. http://gerrit.cloudera.org:8080/#/c/5668/9/docs/topics/impala_new_features.xml File docs/topics/impala_new_features.xml: PS9, Line 225: a flexible way to ingest, modify, or both data within a Kudu table. This phrase doesn't make sense to me because it tries to use "both" as a verb. Instead try, "a flexible way to ingest, modify, or perform both on data within a Kudu table." PS9, Line 330: : : : Impala can take advantage of the S3 encrypted credential : store, to avoid exposing the secret key when accessing : data stored on S3. : : : Not sure why this is a sub-set of the uber list. Doesn't look right in the build. I think this list item content should be added right after the colon that follows the bolded "Security" heading. PS9, Line 382: Impala debug web UI: Should this be bolded to call it out as a subheading like you did with "Security"? -- To view, visit http://gerrit.cloudera.org:8080/5668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c47f422e509cec6d3eb8aaa82294b584f393aed Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Silvius Rus Gerrit-HasComments: Yes
[Impala-ASF-CR] Bump Kudu version to latest Kudu master
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to latest Kudu master .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/256/ -- To view, visit http://gerrit.cloudera.org:8080/5929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib72a0b63cdffb852bd17e69faa0a36edbfda22d7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew JacobsGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial
Laurel Hale has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 2: Code-Review-1 (1 comment) Change the article before the keydef and you're golden. The value that replaces is "Apache Hadoop" and therefore requires the article "an" instead of "a." http://gerrit.cloudera.org:8080/#/c/5663/2/docs/topics/impala_tutorial.xml File docs/topics/impala_tutorial.xml: PS2, Line 60: a This should be "an" since the value that replaces "hadoop_distro" begins with the word, "Apache," a vowel. Sorry. :-( -- To view, visit http://gerrit.cloudera.org:8080/5663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44245b65ce6f247ae8771f582f4b33c3712145ae Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John RussellGerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1288: {{ false, 2230, 5, 3 }, { false, 2230, 5, 3 }} }, > this isn't super-easy to read, how about having the v1 and v2 results on se The next patch introduces actual differences, and lines up each pair of expected results: https://gerrit.cloudera.org/#/c/5952/ Line 1345: for (int v2 = 0; v2 <= 1; ++v2) { > for (int v2: {0, 1}) will do the same Thanks, added this to https://gerrit.cloudera.org/#/c/5952/ http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/testutil/impalad-query-executor.h File be/src/testutil/impalad-query-executor.h: Line 87: void pushExecOption(const std::string& exec_option) { > nit: fn names are not according to our style guide oops, i knew something didn't look right. fixed it in https://gerrit.cloudera.org/#/c/5952/ -- To view, visit http://gerrit.cloudera.org:8080/5933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan HechtGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2
Dan Hecht has uploaded a new patch set (#5). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. IMPALA-4370: Divide and modulo result types for DECIMAL version V2 Implement the new DECIMAL return type rules for divide and modulo expressions, active when query option DECIMAL_V2=1. See the comment in the code for more details. A couple of examples that show why new return type rules for divide are desirable. For modulo, the return types are actually equivalent, though the rules are expressed differently to have consistency with how precision fixups are handled for each version. DECIMAL Version 1: +---+ | cast(1 as decimal(20,0)) / cast(3 as decimal(20,0)) | +-+ | 0 | +---+ DECIMAL Version 2: +---+ | cast(1 as decimal(20,0)) / cast(3 as decimal(20,0)) | +-+ | 0.33| +---+ DECIMAL Version 1: +---+ | cast(1 as decimal(6,0)) / cast(0.1 as decimal(38,38)) | +---+ | NULL | +---+ WARNINGS: UDF WARNING: Expression overflowed, returning NULL DECIMAL Version 2: +---+ | cast(1 as decimal(6,0)) / cast(0.1 as decimal(38,38)) | +---+ | 10.00 | +---+ Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b --- M be/src/exprs/expr-test.cc M be/src/runtime/decimal-value.inline.h M be/src/runtime/types.cc M be/src/testutil/impalad-query-executor.h M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/analysis/TypesUtil.java M fe/src/main/java/org/apache/impala/catalog/ScalarType.java M fe/src/main/java/org/apache/impala/catalog/Type.java A testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test M tests/query_test/test_decimal_queries.py 11 files changed, 345 insertions(+), 81 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/5952/5 -- To view, visit http://gerrit.cloudera.org:8080/5952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht
[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2
Dan Hecht has uploaded a new patch set (#4). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. IMPALA-4370: Divide and modulo result types for DECIMAL version V2 Implement the new DECIMAL return type rules for divide and modulo expressions, active when query option DECIMAL_V2=1. See the comment in the code for more details. A couple of examples that show why new return type rules for divide are desirable. For modulo, the return types are actually equivalent, though the rules are expressed differently to have consistency with how precision fixups are handled for each version. DECIMAL Version 1: +---+ | cast(1 as decimal(20,0)) / cast(3 as decimal(20,0)) | +-+ | 0 | +---+ DECIMAL Version 2: +---+ | cast(1 as decimal(20,0)) / cast(3 as decimal(20,0)) | +-+ | 0.33| +---+ DECIMAL Version 1: +---+ | cast(1 as decimal(6,0)) / cast(0.1 as decimal(38,38)) | +---+ | NULL | +---+ WARNINGS: UDF WARNING: Expression overflowed, returning NULL DECIMAL Version 2: +---+ | cast(1 as decimal(6,0)) / cast(0.1 as decimal(38,38)) | +---+ | 10.00 | +---+ Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b --- M be/src/exprs/expr-test.cc M be/src/runtime/decimal-value.inline.h M be/src/runtime/types.cc M be/src/testutil/impalad-query-executor.h M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/analysis/TypesUtil.java M fe/src/main/java/org/apache/impala/catalog/ScalarType.java M fe/src/main/java/org/apache/impala/catalog/Type.java A testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test M tests/query_test/test_decimal_queries.py 11 files changed, 344 insertions(+), 80 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/5952/4 -- To view, visit http://gerrit.cloudera.org:8080/5952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht
[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version
Dan Hecht has uploaded a new patch set (#3). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version .. IMPALA-4370: Divide and modulo result types for DECIMAL version Implement the new DECIMAL return type rules for divide and modulo expressions, active when query option DECIMAL_V2=1. See the comment in the code for more details. A couple of examples that show why new return type rules for divide are desirable. For modulo, the return types are actually equivalent, though the rules are expressed differently to have consistency with how precision fixups are handled for each version. DECIMAL Version 1: +---+ | cast(1 as decimal(20,0)) / cast(3 as decimal(20,0)) | +-+ | 0 | +---+ DECIMAL Version 2: +---+ | cast(1 as decimal(20,0)) / cast(3 as decimal(20,0)) | +-+ | 0.33| +---+ DECIMAL Version 1: +---+ | cast(1 as decimal(6,0)) / cast(0.1 as decimal(38,38)) | +---+ | NULL | +---+ WARNINGS: UDF WARNING: Expression overflowed, returning NULL DECIMAL Version 2: +---+ | cast(1 as decimal(6,0)) / cast(0.1 as decimal(38,38)) | +---+ | 10.00 | +---+ Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b --- M be/src/exprs/expr-test.cc M be/src/runtime/decimal-value.inline.h M be/src/runtime/types.cc M be/src/testutil/impalad-query-executor.h M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/analysis/TypesUtil.java M fe/src/main/java/org/apache/impala/catalog/ScalarType.java M fe/src/main/java/org/apache/impala/catalog/Type.java A testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test M tests/query_test/test_decimal_queries.py 11 files changed, 344 insertions(+), 80 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/5952/3 -- To view, visit http://gerrit.cloudera.org:8080/5952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht
[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/255/ -- To view, visit http://gerrit.cloudera.org:8080/5917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ff88716b185e1d72d2bc603a42bd06c60ec18e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-MarshallGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/254/ -- To view, visit http://gerrit.cloudera.org:8080/5784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22cecfbe7c9a102f788d01eb80aa188579ef6d7e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim AppleGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1288: {{ false, 2230, 5, 3 }, { false, 2230, 5, 3 }} }, this isn't super-easy to read, how about having the v1 and v2 results on separate lines and lined up (so they're easy to compare)? or better yet, making expected[1] optional, and if it's missing it's an indication that v1 and v2 have the same result? Line 1345: for (int v2 = 0; v2 <= 1; ++v2) { for (int v2: {0, 1}) will do the same -- To view, visit http://gerrit.cloudera.org:8080/5933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan HechtGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 1: Rather than using a web page for making those changes, why not simply do it through a URL? (That's how it was handled at Google.) something like http://.../logv?level= or .../logv_module?= (I don't care about the actual syntax, that's just an example.) -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath VissapragadaGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: No