[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
Laurel Hale has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 2: Code-Review+1 Downloaded your changes and PDF, HTML look good. -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Thu, 09 Nov 2017 23:31:17 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Laurel Hale has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 ) Change subject: [DOCS] Fix alphabetical ordering of query options .. Patch Set 2: Code-Review+1 Absolutely perfect! Thanks! -- To view, visit http://gerrit.cloudera.org:8080/8265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8 Gerrit-Change-Number: 8265 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Comment-Date: Thu, 12 Oct 2017 20:23:38 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Laurel Hale has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 ) Change subject: [DOCS] Fix alphabetical ordering of query options .. Patch Set 1: The alphabetization of the statements that start with "D" look great, but shouldn't "SCHEDULE_RANDOM_REPLICA" be listed before "SCRATCH_LIMIT"? -- To view, visit http://gerrit.cloudera.org:8080/8265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8 Gerrit-Change-Number: 8265 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Comment-Date: Thu, 12 Oct 2017 20:02:16 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fold some lines
Laurel Hale has posted comments on this change. Change subject: [DOCS] Fold some lines .. Patch Set 1: Code-Review+1 PDF build looks good. -- To view, visit http://gerrit.cloudera.org:8080/7417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] Fix link to Hadoop ADLS page
Laurel Hale has posted comments on this change. Change subject: Fix link to Hadoop ADLS page .. Patch Set 1: Code-Review+1 I built the documentation and the link works perfectly. -- To view, visit http://gerrit.cloudera.org:8080/7672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bcbf31735f398a879595846aeb1a6e1c7def9a2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246
Laurel Hale has posted comments on this change. Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Patch Set 1: (1 comment) > (1 comment) http://gerrit.cloudera.org:8080/#/c/7397/1/impala-docs.html File impala-docs.html: PS1, Line 149: impala.pdf > OK. My motivation for this is probably of lesser importance: it bugs me the When I open the PDF (impala.pdf), there is no identification on the PDF that identifies it as documentation for 2.9 on the cover or in the intro parts of the guide. If you change the file name from "impala.pdf" to "impala-2.9.pdf" users will be able to at least identify the version by the file name. Since people frequently download PDFs to their hard drives, I think it makes sense to identify the version in the filename. -- To view, visit http://gerrit.cloudera.org:8080/7397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2209088d0120a7b1243113466b33159a4f8a25e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support
Laurel Hale has posted comments on this change. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7175/3/docs/topics/impala_adls.xml File docs/topics/impala_adls.xml: PS3, Line 158: > I'm relying to some extent on users to work out the precise details from th I was able to get Hive on MR2 to connect with John Zhuge's help, but the Microsoft documentation is complete, so this is fine. -- To view, visit http://gerrit.cloudera.org:8080/7175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5a98217741e5d540d9874e9b30e36f01644ef14 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: David Knupp Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support
Laurel Hale has posted comments on this change. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. Patch Set 3: (2 comments) Couple of issues found http://gerrit.cloudera.org:8080/#/c/7175/3/docs/topics/impala_adls.xml File docs/topics/impala_adls.xml: PS3, Line 134: statement Since the link text is "INSERT Statement" it is not necessary to include it again--creates a duplication of the word. Remove this "statement." PS3, Line 158: Do you tell users where they should get "your_client_id," "your_client_secret," and the "refresh_URL"? These values come from values you set when you create your ADLS service principal and the refresh URL comes from the "Endpoints" setting in the Azure portal (Azure Active Directory > App registrations > Endpoints). -- To view, visit http://gerrit.cloudera.org:8080/7175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5a98217741e5d540d9874e9b30e36f01644ef14 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: David Knupp Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4850 [DOCS] Create table "comment comes after "partioned by"
Laurel Hale has posted comments on this change. Change subject: IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7080/1/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: Line 172: > There seem to be a few things amiss. Done -- To view, visit http://gerrit.cloudera.org:8080/7080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543ff1dbfe1ab8a7e0a0a668130ab060e3af0a5f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4850 [DOCS] Create table "comment comes after "partioned by"
Laurel Hale has uploaded a new patch set (#2). Change subject: IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" .. IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" Corrected code example listed under "Column definitions inferred from data file." Change-Id: I543ff1dbfe1ab8a7e0a0a668130ab060e3af0a5f --- M docs/topics/impala_create_table.xml 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/7080/2 -- To view, visit http://gerrit.cloudera.org:8080/7080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I543ff1dbfe1ab8a7e0a0a668130ab060e3af0a5f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars
Laurel Hale has uploaded a new patch set (#4). Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars In the "Restrictions" section of the "APPX_MEDIAN Function" topic, added information about how the function truncates string values. Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 --- M docs/topics/impala_appx_median.xml 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/7094/4 -- To view, visit http://gerrit.cloudera.org:8080/7094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Peter Brejcak
[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars
Laurel Hale has posted comments on this change. Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7094/2/docs/topics/impala_appx_median.xml File docs/topics/impala_appx_median.xml: Line 76: > I think this white space is an artifact of Gerrit. It doesn't appear in the Done -- To view, visit http://gerrit.cloudera.org:8080/7094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Peter Brejcak Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3603 [DOCS] Document handling of NaN values
Laurel Hale has uploaded a new patch set (#3). Change subject: IMPALA-3603 [DOCS] Document handling of NaN values .. IMPALA-3603 [DOCS] Document handling of NaN values Added information in the "DOUBLE Data Type" (impala_double.html) and the "FLOAT Data Type" (impala_float.html) topics about how Impala handles NaN values. Change-Id: Id9485b6790d58fafdae32332d2634cbe893d7fb0 --- M docs/shared/impala_common.xml M docs/topics/impala_double.xml M docs/topics/impala_float.xml 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/7098/3 -- To view, visit http://gerrit.cloudera.org:8080/7098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id9485b6790d58fafdae32332d2634cbe893d7fb0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Will Berkeley
[Impala-ASF-CR] IMPALA-3603 [DOCS] Document handling of NaN values
Laurel Hale has posted comments on this change. Change subject: IMPALA-3603 [DOCS] Document handling of NaN values .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/7098/2//COMMIT_MSG Commit Message: PS2, Line 13: This information has been added to the subsection : "Usage Notes:" in each topic: : : "Impala does not evaluate NaN (not a number) values as : equal to any other numeric values, including NaN. For : example, the following statement, which evaluates : equality between two NaN values returns 'false': > The commit message doesn't need to be this detailed. I would just add a an okay. PS2, Line 23: For patch set #2 > The commit message shouldn't reference the revisions of the patch. It's mea Thanks. http://gerrit.cloudera.org:8080/#/c/7098/2/docs/shared/impala_common.xml File docs/shared/impala_common.xml: PS2, Line 2298: > Extra whitespace. Remove. Done PS2, Line 2300: (not a number) > Redundant. I disagree about including "(not a number)." It's a documentation best practice to always provide what an acronym stands for on first use in a topic to avoid ambiguity. I agree with removing "values" and will do that. PS2, Line 2302: returns > Consider "evaluates to" rather than "returns"...I slightly prefer the forme I think the subordinate clause is important for clarity and so will leave as is. PS2, Line 2301: , which evaluates equality : between two NaN values > Redundant. I disagree. Will leave it in. http://gerrit.cloudera.org:8080/#/c/7098/2/docs/topics/impala_double.xml File docs/topics/impala_double.xml: PS2, Line 80: > Extra whitespace. Done http://gerrit.cloudera.org:8080/#/c/7098/2/docs/topics/impala_float.xml File docs/topics/impala_float.xml: PS2, Line 74: > Extra whitespace. Done PS2, Line 76: > Extra whitespace. Done -- To view, visit http://gerrit.cloudera.org:8080/7098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9485b6790d58fafdae32332d2634cbe893d7fb0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3603 [DOCS] Document handling of NaN values
Laurel Hale has uploaded a new patch set (#2). Change subject: IMPALA-3603 [DOCS] Document handling of NaN values .. IMPALA-3603 [DOCS] Document handling of NaN values Added information in the "DOUBLE Data Type" (impala_double.html) and the "FLOAT Data Type" (impala_float.html) topics about how Impala handles NaN values. This information has been added to the subsection "Usage Notes:" in each topic: "Impala does not evaluate NaN (not a number) values as equal to any other numeric values, including NaN. For example, the following statement, which evaluates equality between two NaN values returns 'false': SELECT CAST('nan' AS DOUBLE|FLOAT)=CAST('nan' AS DOUBLE|FLOAT); For patch set #2, I tidied up a bit. I pulled the common verbiage into the /shared/impala_common.xml file and added the Jira number in a comment for auditing purposes. Change-Id: Id9485b6790d58fafdae32332d2634cbe893d7fb0 --- M docs/shared/impala_common.xml M docs/topics/impala_double.xml M docs/topics/impala_float.xml 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/7098/2 -- To view, visit http://gerrit.cloudera.org:8080/7098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id9485b6790d58fafdae32332d2634cbe893d7fb0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: John Russell Gerrit-Reviewer: Will Berkeley
[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars
Laurel Hale has posted comments on this change. Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. Patch Set 3: (2 comments) > Thanks a lot for change. It's ok for me. Thanks, Peter! http://gerrit.cloudera.org:8080/#/c/7094/2/docs/topics/impala_appx_median.xml File docs/topics/impala_appx_median.xml: Line 76: > remove whitespace I think this white space is an artifact of Gerrit. It doesn't appear in the source XML. Line 78: The APPX_MEDIAN function returns only the first 10 characters for > string,varchar,char Done -- To view, visit http://gerrit.cloudera.org:8080/7094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Peter Brejcak Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4850 [DOCS] Create table "comment comes after "partioned by"
Laurel Hale has posted comments on this change. Change subject: IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" .. Patch Set 1: (1 comment) > (1 comment) http://gerrit.cloudera.org:8080/#/c/7080/1/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: Line 172: [COMMENT 'table_comment'] > There seem to be a few things amiss. Thanks for your feedback. I don't see the reference to the PARTITIONED BY clause in the section of sql-parser.cup you pasted above. I looked at sql-parser.cup and don't see anything about the PARTITIONED BY clause other than the following section which follows the "tbl_options" section you pasted above: -- partitioned_data_layout ::= partition_param_list:partition_params {: RESULT = TableDataLayout.createKuduPartitionedLayout(partition_params); :} | /* empty */ {: RESULT = TableDataLayout.createEmptyLayout(); :} ; partition_column_defs ::= KW_PARTITIONED KW_BY LPAREN column_def_list:col_defs RPAREN {: RESULT = col_defs; :} ; // The PARTITION BY clause contains any number of HASH() clauses followed by exactly zero // or one RANGE clauses partition_param_list ::= KW_PARTITION KW_BY hash_partition_param_list:list {: RESULT = list; :} | KW_PARTITION KW_BY range_partition_param:rng {: RESULT = Lists.newArrayList(rng); :} | KW_PARTITION KW_BY hash_partition_param_list:list COMMA range_partition_param:rng {: list.add(rng); RESULT = list; :} ; - Also, I've been testing and am getting many errors on many of the code examples in this file. For example, SORT BY throws an error in a simple CREATE TABLE statement (not a CTAS): -- [vc0136.halxg.cloudera.com:21000] > create table laurel.komono (name string, number int, store_location string) > partitioned by (room string) > sort by store_location > comment 'impala-4850 test'; Query: create table laurel.komono (name string, number int, store_location string) partitioned by (room string) sort by store_location comment 'impala-4850 test' ERROR: AnalysisException: Syntax error in line 3: sort by store_location ^ Encountered: IDENTIFIER Expected: CACHED, COMMENT, LOCATION, ROW, STORED, TBLPROPERTIES, UNCACHED, WITH CAUSED BY: Exception: Syntax error -- This indicates that all of the code examples should be tested in this file, which exceeds the scope of this Jira. My testing did verify, however, that the table comment should be placed immediately after the PARTITIONED BY clause: -- [vc0136.halxg.cloudera.com:21000] > create table laurel.favorite_places (rating int, name string, country string, why string) > partitioned by (color string) > comment 'test of impala-4850'; Query: create table laurel.favorite_places (rating int, name string, country string, why string) partitioned by (color string) comment 'test of impala-4850' Fetched 0 row(s) in 0.13s [vc0136.halxg.cloudera.com:21000] > show tables; Query: show tables ++ | name | ++ | favorite_places| | favorite_words | | french_departments | ++ I will make that fix and discuss the other code examples with John Russell to decide how/when that work can be done. -- To view, visit http://gerrit.cloudera.org:8080/7080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543ff1dbfe1ab8a7e0a0a668130ab060e3af0a5f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars
Laurel Hale has uploaded a new patch set (#3). Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars In the "Restrictions" section of the "APPX_MEDIAN Function" topic, added information about how the function truncates string values: "The APPX_MEDIAN function returns only the first 10 characters for string values (varchar, char). Additional characters are truncated." In this patch, I added 'string' to the list of string values that are truncated by the APPX_MEDIAN function and checked the source XML for the white space called out in the review comment. It was not present in the source. I can only speculate that it was a distortion caused by the Gerrit UI. Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 --- M docs/topics/impala_appx_median.xml 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/7094/3 -- To view, visit http://gerrit.cloudera.org:8080/7094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-3603 [DOCS] Document handling of NaN values
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/7098 Change subject: IMPALA-3603 [DOCS] Document handling of NaN values .. IMPALA-3603 [DOCS] Document handling of NaN values Added information in the "DOUBLE Data Type" (impala_double.html) and the "FLOAT Data Type" (impala_float.html) topics about how Impala handles NaN values. This information has been added to the subsection "Usage Notes:" in each topic: "Impala does not evaluate NaN (not a number) values as equal to any other numeric values, including NaN. For example, the following statement, which evaluates equality between two NaN values returns 'false': SELECT CAST('nan' AS DOUBLE|FLOAT)=CAST('nan' AS DOUBLE|FLOAT); Change-Id: Id9485b6790d58fafdae32332d2634cbe893d7fb0 --- M docs/topics/impala_double.xml M docs/topics/impala_float.xml 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/7098/1 -- To view, visit http://gerrit.cloudera.org:8080/7098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id9485b6790d58fafdae32332d2634cbe893d7fb0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale
[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars
Laurel Hale has posted comments on this change. Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. Patch Set 1: The reporter (Peter Brejcak) does not come up as an option to add as a reviewer. -- To view, visit http://gerrit.cloudera.org:8080/7094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/7094 Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars In the "Restrictions" section of the "APPX_MEDIAN Function" topic, added information about how the function truncates string values: "The APPX_MEDIAN function returns only the first 10 characters for string values (varchar, char). Additional characters are truncated." Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 --- M docs/topics/impala_appx_median.xml 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/7094/1 -- To view, visit http://gerrit.cloudera.org:8080/7094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale
[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/7083 Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect .. IMPALA-3267 [DOCS] Docs about nan/inf are incorrect Switched the example for Infinity and NaN in the impala.common file so it will be correct every- where this example is used in the Impala documentation. Instead of saying, "pow(-1, 0.5) returns infinity and 1/0 returns NaN" it has been corrected to "1/0 returns infinity and pow(-1, 0.5) returns NaN." Change-Id: I0e5d950b250c2e4425bde7d9e0bccbb068a73e12 --- M docs/shared/impala_common.xml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/7083/1 -- To view, visit http://gerrit.cloudera.org:8080/7083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e5d950b250c2e4425bde7d9e0bccbb068a73e12 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale
[Impala-ASF-CR] IMPALA-4850 [DOCS] Create table "comment comes after "partioned by"
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/7080 Change subject: IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" .. IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" Corrected code example listed under "Column definitions inferred from data file." Moved the table comment ([COMMENT 'table_comment']) to the end of the code block after the SerDe properties. Also added a reference listing the release number of Impala and the Jira number. Change-Id: I543ff1dbfe1ab8a7e0a0a668130ab060e3af0a5f --- M docs/topics/impala_create_table.xml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/7080/1 -- To view, visit http://gerrit.cloudera.org:8080/7080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I543ff1dbfe1ab8a7e0a0a668130ab060e3af0a5f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale
[Impala-ASF-CR](asf-site) IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF site
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6604 to look at the new patch set (#3). Change subject: IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF site .. IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF site Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project. Removed both HTML files from the shared folder (ImpalaVariables.html and impala_common.html) Change-Id: Ibbf0818c4a7fe1e251e2f36da75cc7c3dd16dead --- A docs/build/html/commonltr.css A docs/build/html/commonrtl.css A docs/build/html/images/impala_arch.jpeg A docs/build/html/index.html A docs/build/html/topics/impala_abort_on_default_limit_exceeded.html A docs/build/html/topics/impala_abort_on_error.html A docs/build/html/topics/impala_admin.html A docs/build/html/topics/impala_admission.html A docs/build/html/topics/impala_aggregate_functions.html A docs/build/html/topics/impala_aliases.html A docs/build/html/topics/impala_allow_unsupported_formats.html A docs/build/html/topics/impala_alter_table.html A docs/build/html/topics/impala_alter_view.html A docs/build/html/topics/impala_analytic_functions.html A docs/build/html/topics/impala_appx_count_distinct.html A docs/build/html/topics/impala_appx_median.html A docs/build/html/topics/impala_array.html A docs/build/html/topics/impala_auditing.html A docs/build/html/topics/impala_authentication.html A docs/build/html/topics/impala_authorization.html A docs/build/html/topics/impala_avg.html A docs/build/html/topics/impala_avro.html A docs/build/html/topics/impala_batch_size.html A docs/build/html/topics/impala_bigint.html A docs/build/html/topics/impala_bit_functions.html A docs/build/html/topics/impala_boolean.html A docs/build/html/topics/impala_breakpad.html A docs/build/html/topics/impala_char.html A docs/build/html/topics/impala_cluster_sizing.html A docs/build/html/topics/impala_comments.html A docs/build/html/topics/impala_complex_types.html A docs/build/html/topics/impala_components.html A docs/build/html/topics/impala_compression_codec.html A docs/build/html/topics/impala_compute_stats.html A docs/build/html/topics/impala_concepts.html A docs/build/html/topics/impala_conditional_functions.html A docs/build/html/topics/impala_config.html A docs/build/html/topics/impala_config_options.html A docs/build/html/topics/impala_config_performance.html A docs/build/html/topics/impala_connecting.html A docs/build/html/topics/impala_conversion_functions.html A docs/build/html/topics/impala_count.html A docs/build/html/topics/impala_create_database.html A docs/build/html/topics/impala_create_function.html A docs/build/html/topics/impala_create_role.html A docs/build/html/topics/impala_create_table.html A docs/build/html/topics/impala_create_view.html A docs/build/html/topics/impala_databases.html A docs/build/html/topics/impala_datatypes.html A docs/build/html/topics/impala_datetime_functions.html A docs/build/html/topics/impala_ddl.html A docs/build/html/topics/impala_debug_action.html A docs/build/html/topics/impala_decimal.html A docs/build/html/topics/impala_default_order_by_limit.html A docs/build/html/topics/impala_delegation.html A docs/build/html/topics/impala_delete.html A docs/build/html/topics/impala_describe.html A docs/build/html/topics/impala_development.html A docs/build/html/topics/impala_disable_codegen.html A docs/build/html/topics/impala_disable_row_runtime_filtering.html A docs/build/html/topics/impala_disable_streaming_preaggregations.html A docs/build/html/topics/impala_disable_unsafe_spills.html A docs/build/html/topics/impala_disk_space.html A docs/build/html/topics/impala_distinct.html A docs/build/html/topics/impala_dml.html A docs/build/html/topics/impala_double.html A docs/build/html/topics/impala_drop_database.html A docs/build/html/topics/impala_drop_function.html A docs/build/html/topics/impala_drop_role.html A docs/build/html/topics/impala_drop_stats.html A docs/build/html/topics/impala_drop_table.html A docs/build/html/topics/impala_drop_view.html A docs/build/html/topics/impala_exec_single_node_rows_threshold.html A docs/build/html/topics/impala_explain.html A docs/build/html/topics/impala_explain_level.html A docs/build/html/topics/impala_explain_plan.html A docs/build/html/topics/impala_faq.html A docs/build/html/topics/impala_file_formats.html A docs/build/html/topics/impala_fixed_issues.html A docs/build/html/topics/impala_float.html A docs/build/html/topics/impala_functions.html A docs/build/html/topics/impala_functions_overview.html A docs/build/html/topics/impala_grant.html A docs/build/html/topics/impala_group_by.html A docs/build/html/topics/impala_group_concat.html A docs/build/html/topics/impala_hadoop.html A docs/build/html/topics/impala_having.html A docs/build/html/topics/impala_hbase.html A do
[Impala-ASF-CR](asf-site) IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF resources.
Laurel Hale has posted comments on this change. Change subject: IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF resources. .. Patch Set 2: > (1 comment) > > Laurel, HTML and PDF look good, but see comment. okay--I'll repush -- To view, visit http://gerrit.cloudera.org:8080/6604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf0818c4a7fe1e251e2f36da75cc7c3dd16dead Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF resources.
Laurel Hale has posted comments on this change. Change subject: IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF resources. .. Patch Set 2: > (1 comment) ok--I'll repush -- To view, visit http://gerrit.cloudera.org:8080/6604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf0818c4a7fe1e251e2f36da75cc7c3dd16dead Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF resources.
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6604 to look at the new patch set (#2). Change subject: IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF resources. .. IMPALA-4181 [DOCS] Publish rendered Impala documentation to ASF resources. Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project. Removed both HTML files from the shared folder (ImpalaVariables.html and impala_common.html) Change-Id: Ibbf0818c4a7fe1e251e2f36da75cc7c3dd16dead --- A docs/build/html/commonltr.css A docs/build/html/commonrtl.css A docs/build/html/images/impala_arch.jpeg A docs/build/html/index.html A docs/build/html/topics/impala_abort_on_default_limit_exceeded.html A docs/build/html/topics/impala_abort_on_error.html A docs/build/html/topics/impala_admin.html A docs/build/html/topics/impala_admission.html A docs/build/html/topics/impala_aggregate_functions.html A docs/build/html/topics/impala_aliases.html A docs/build/html/topics/impala_allow_unsupported_formats.html A docs/build/html/topics/impala_alter_table.html A docs/build/html/topics/impala_alter_view.html A docs/build/html/topics/impala_analytic_functions.html A docs/build/html/topics/impala_appx_count_distinct.html A docs/build/html/topics/impala_appx_median.html A docs/build/html/topics/impala_array.html A docs/build/html/topics/impala_auditing.html A docs/build/html/topics/impala_authentication.html A docs/build/html/topics/impala_authorization.html A docs/build/html/topics/impala_avg.html A docs/build/html/topics/impala_avro.html A docs/build/html/topics/impala_batch_size.html A docs/build/html/topics/impala_bigint.html A docs/build/html/topics/impala_bit_functions.html A docs/build/html/topics/impala_boolean.html A docs/build/html/topics/impala_breakpad.html A docs/build/html/topics/impala_char.html A docs/build/html/topics/impala_cluster_sizing.html A docs/build/html/topics/impala_comments.html A docs/build/html/topics/impala_complex_types.html A docs/build/html/topics/impala_components.html A docs/build/html/topics/impala_compression_codec.html A docs/build/html/topics/impala_compute_stats.html A docs/build/html/topics/impala_concepts.html A docs/build/html/topics/impala_conditional_functions.html A docs/build/html/topics/impala_config.html A docs/build/html/topics/impala_config_options.html A docs/build/html/topics/impala_config_performance.html A docs/build/html/topics/impala_connecting.html A docs/build/html/topics/impala_conversion_functions.html A docs/build/html/topics/impala_count.html A docs/build/html/topics/impala_create_database.html A docs/build/html/topics/impala_create_function.html A docs/build/html/topics/impala_create_role.html A docs/build/html/topics/impala_create_table.html A docs/build/html/topics/impala_create_view.html A docs/build/html/topics/impala_databases.html A docs/build/html/topics/impala_datatypes.html A docs/build/html/topics/impala_datetime_functions.html A docs/build/html/topics/impala_ddl.html A docs/build/html/topics/impala_debug_action.html A docs/build/html/topics/impala_decimal.html A docs/build/html/topics/impala_default_order_by_limit.html A docs/build/html/topics/impala_delegation.html A docs/build/html/topics/impala_delete.html A docs/build/html/topics/impala_describe.html A docs/build/html/topics/impala_development.html A docs/build/html/topics/impala_disable_codegen.html A docs/build/html/topics/impala_disable_row_runtime_filtering.html A docs/build/html/topics/impala_disable_streaming_preaggregations.html A docs/build/html/topics/impala_disable_unsafe_spills.html A docs/build/html/topics/impala_disk_space.html A docs/build/html/topics/impala_distinct.html A docs/build/html/topics/impala_dml.html A docs/build/html/topics/impala_double.html A docs/build/html/topics/impala_drop_database.html A docs/build/html/topics/impala_drop_function.html A docs/build/html/topics/impala_drop_role.html A docs/build/html/topics/impala_drop_stats.html A docs/build/html/topics/impala_drop_table.html A docs/build/html/topics/impala_drop_view.html A docs/build/html/topics/impala_exec_single_node_rows_threshold.html A docs/build/html/topics/impala_explain.html A docs/build/html/topics/impala_explain_level.html A docs/build/html/topics/impala_explain_plan.html A docs/build/html/topics/impala_faq.html A docs/build/html/topics/impala_file_formats.html A docs/build/html/topics/impala_fixed_issues.html A docs/build/html/topics/impala_float.html A docs/build/html/topics/impala_functions.html A docs/build/html/topics/impala_functions_overview.html A docs/build/html/topics/impala_grant.html A docs/build/html/topics/impala_group_by.html A docs/build/html/topics/impala_group_concat.html A docs/build/html/topics/impala_hadoop.html A docs/build/html/topics/impala_having.html A docs/build/html/topics/impala_hba
[Impala-ASF-CR](asf-site) Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project.
Laurel Hale has posted comments on this change. Change subject: Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project. .. Patch Set 1: > (2 comments) > > I'll do some proofreading as a separate pass. Just wanted to get > these comments in ASAP, about .html files that can be removed. Well, it looks like another patch set is in order. Please do your review fully and when you are done, let me know and I'll push another patch set with a good commit message. -- To view, visit http://gerrit.cloudera.org:8080/6604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf0818c4a7fe1e251e2f36da75cc7c3dd16dead Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project.
Laurel Hale has posted comments on this change. Change subject: Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project. .. Patch Set 1: > (1 comment) I can just create another patchset with a reworked commit message--is that correct? -- To view, visit http://gerrit.cloudera.org:8080/6604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf0818c4a7fe1e251e2f36da75cc7c3dd16dead Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project.
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/6604 Change subject: Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project. .. Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project. Change-Id: Ibbf0818c4a7fe1e251e2f36da75cc7c3dd16dead --- A docs/build/html/commonltr.css A docs/build/html/commonrtl.css A docs/build/html/images/impala_arch.jpeg A docs/build/html/index.html A docs/build/html/shared/ImpalaVariables.html A docs/build/html/shared/impala_common.html A docs/build/html/topics/impala_abort_on_default_limit_exceeded.html A docs/build/html/topics/impala_abort_on_error.html A docs/build/html/topics/impala_admin.html A docs/build/html/topics/impala_admission.html A docs/build/html/topics/impala_aggregate_functions.html A docs/build/html/topics/impala_aliases.html A docs/build/html/topics/impala_allow_unsupported_formats.html A docs/build/html/topics/impala_alter_table.html A docs/build/html/topics/impala_alter_view.html A docs/build/html/topics/impala_analytic_functions.html A docs/build/html/topics/impala_appx_count_distinct.html A docs/build/html/topics/impala_appx_median.html A docs/build/html/topics/impala_array.html A docs/build/html/topics/impala_auditing.html A docs/build/html/topics/impala_authentication.html A docs/build/html/topics/impala_authorization.html A docs/build/html/topics/impala_avg.html A docs/build/html/topics/impala_avro.html A docs/build/html/topics/impala_batch_size.html A docs/build/html/topics/impala_bigint.html A docs/build/html/topics/impala_bit_functions.html A docs/build/html/topics/impala_boolean.html A docs/build/html/topics/impala_breakpad.html A docs/build/html/topics/impala_char.html A docs/build/html/topics/impala_cluster_sizing.html A docs/build/html/topics/impala_comments.html A docs/build/html/topics/impala_complex_types.html A docs/build/html/topics/impala_components.html A docs/build/html/topics/impala_compression_codec.html A docs/build/html/topics/impala_compute_stats.html A docs/build/html/topics/impala_concepts.html A docs/build/html/topics/impala_conditional_functions.html A docs/build/html/topics/impala_config.html A docs/build/html/topics/impala_config_options.html A docs/build/html/topics/impala_config_performance.html A docs/build/html/topics/impala_connecting.html A docs/build/html/topics/impala_conversion_functions.html A docs/build/html/topics/impala_count.html A docs/build/html/topics/impala_create_database.html A docs/build/html/topics/impala_create_function.html A docs/build/html/topics/impala_create_role.html A docs/build/html/topics/impala_create_table.html A docs/build/html/topics/impala_create_view.html A docs/build/html/topics/impala_databases.html A docs/build/html/topics/impala_datatypes.html A docs/build/html/topics/impala_datetime_functions.html A docs/build/html/topics/impala_ddl.html A docs/build/html/topics/impala_debug_action.html A docs/build/html/topics/impala_decimal.html A docs/build/html/topics/impala_default_order_by_limit.html A docs/build/html/topics/impala_delegation.html A docs/build/html/topics/impala_delete.html A docs/build/html/topics/impala_describe.html A docs/build/html/topics/impala_development.html A docs/build/html/topics/impala_disable_codegen.html A docs/build/html/topics/impala_disable_row_runtime_filtering.html A docs/build/html/topics/impala_disable_streaming_preaggregations.html A docs/build/html/topics/impala_disable_unsafe_spills.html A docs/build/html/topics/impala_disk_space.html A docs/build/html/topics/impala_distinct.html A docs/build/html/topics/impala_dml.html A docs/build/html/topics/impala_double.html A docs/build/html/topics/impala_drop_database.html A docs/build/html/topics/impala_drop_function.html A docs/build/html/topics/impala_drop_role.html A docs/build/html/topics/impala_drop_stats.html A docs/build/html/topics/impala_drop_table.html A docs/build/html/topics/impala_drop_view.html A docs/build/html/topics/impala_exec_single_node_rows_threshold.html A docs/build/html/topics/impala_explain.html A docs/build/html/topics/impala_explain_level.html A docs/build/html/topics/impala_explain_plan.html A docs/build/html/topics/impala_faq.html A docs/build/html/topics/impala_file_formats.html A docs/build/html/topics/impala_fixed_issues.html A docs/build/html/topics/impala_float.html A docs/build/html/topics/impala_functions.html A docs/build/html/topics/impala_functions_overview.html A docs/build/html/topics/impala_grant.html A docs/build/html/topics/impala_group_by.html A docs/build/html/topics/impala_group_concat.html A docs/build/html/topics/impala_hadoop.html A docs/build/html/topics/impala_having.html A docs/build/html/topics/impala_hbase.html A docs/build/html/topics/impala_hbase_cache_blocks
[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.
Laurel Hale has abandoned this change. Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. Abandoned There were a couple problems with the publish procedure I followed so will abandon this review and re-do it. -- To view, visit http://gerrit.cloudera.org:8080/6601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If33c03c9d6e64f3974756df50b0777eeb1333ed8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.
Laurel Hale has posted comments on this change. Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. Patch Set 1: > (1 comment) I'm going to abandon this review because of an issue that Jim identified. The next one I do, I'll be sure to include the commit id used for the build. -- To view, visit http://gerrit.cloudera.org:8080/6601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If33c03c9d6e64f3974756df50b0777eeb1333ed8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.
Laurel Hale has posted comments on this change. Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. Patch Set 1: > (1 comment) I'll abandon this review and start over. Will delete the contents of the docs/build directory before I build. -- To view, visit http://gerrit.cloudera.org:8080/6601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If33c03c9d6e64f3974756df50b0777eeb1333ed8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/6601 Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. First publishing of Apache Impala (incubating) documentation to the Apache web site. Change-Id: If33c03c9d6e64f3974756df50b0777eeb1333ed8 --- A docs/build/html/commonltr.css A docs/build/html/commonrtl.css A docs/build/html/images/howto_access_control.png A docs/build/html/images/howto_per_node_peak_memory_usage.png A docs/build/html/images/howto_show_histogram.png A docs/build/html/images/howto_static_server_pools_config.png A docs/build/html/images/impala_arch.jpeg A docs/build/html/images/support_send_diagnostic_data.png A docs/build/html/index.html A docs/build/html/shared/ImpalaVariables.html A docs/build/html/shared/impala_common.html A docs/build/html/topics/impala_abort_on_default_limit_exceeded.html A docs/build/html/topics/impala_abort_on_error.html A docs/build/html/topics/impala_admin.html A docs/build/html/topics/impala_admission.html A docs/build/html/topics/impala_aggregate_functions.html A docs/build/html/topics/impala_aliases.html A docs/build/html/topics/impala_allow_unsupported_formats.html A docs/build/html/topics/impala_alter_table.html A docs/build/html/topics/impala_alter_view.html A docs/build/html/topics/impala_analytic_functions.html A docs/build/html/topics/impala_appx_count_distinct.html A docs/build/html/topics/impala_appx_median.html A docs/build/html/topics/impala_array.html A docs/build/html/topics/impala_auditing.html A docs/build/html/topics/impala_authentication.html A docs/build/html/topics/impala_authorization.html A docs/build/html/topics/impala_avg.html A docs/build/html/topics/impala_avro.html A docs/build/html/topics/impala_batch_size.html A docs/build/html/topics/impala_bigint.html A docs/build/html/topics/impala_bit_functions.html A docs/build/html/topics/impala_boolean.html A docs/build/html/topics/impala_breakpad.html A docs/build/html/topics/impala_char.html A docs/build/html/topics/impala_cluster_sizing.html A docs/build/html/topics/impala_comments.html A docs/build/html/topics/impala_complex_types.html A docs/build/html/topics/impala_components.html A docs/build/html/topics/impala_compression_codec.html A docs/build/html/topics/impala_compute_stats.html A docs/build/html/topics/impala_concepts.html A docs/build/html/topics/impala_conditional_functions.html A docs/build/html/topics/impala_config.html A docs/build/html/topics/impala_config_options.html A docs/build/html/topics/impala_config_performance.html A docs/build/html/topics/impala_connecting.html A docs/build/html/topics/impala_conversion_functions.html A docs/build/html/topics/impala_count.html A docs/build/html/topics/impala_create_database.html A docs/build/html/topics/impala_create_function.html A docs/build/html/topics/impala_create_role.html A docs/build/html/topics/impala_create_table.html A docs/build/html/topics/impala_create_view.html A docs/build/html/topics/impala_databases.html A docs/build/html/topics/impala_datatypes.html A docs/build/html/topics/impala_datetime_functions.html A docs/build/html/topics/impala_ddl.html A docs/build/html/topics/impala_debug_action.html A docs/build/html/topics/impala_decimal.html A docs/build/html/topics/impala_default_order_by_limit.html A docs/build/html/topics/impala_delegation.html A docs/build/html/topics/impala_delete.html A docs/build/html/topics/impala_describe.html A docs/build/html/topics/impala_development.html A docs/build/html/topics/impala_disable_codegen.html A docs/build/html/topics/impala_disable_row_runtime_filtering.html A docs/build/html/topics/impala_disable_streaming_preaggregations.html A docs/build/html/topics/impala_disable_unsafe_spills.html A docs/build/html/topics/impala_disk_space.html A docs/build/html/topics/impala_distinct.html A docs/build/html/topics/impala_dml.html A docs/build/html/topics/impala_double.html A docs/build/html/topics/impala_drop_database.html A docs/build/html/topics/impala_drop_function.html A docs/build/html/topics/impala_drop_role.html A docs/build/html/topics/impala_drop_stats.html A docs/build/html/topics/impala_drop_table.html A docs/build/html/topics/impala_drop_view.html A docs/build/html/topics/impala_exec_single_node_rows_threshold.html A docs/build/html/topics/impala_explain.html A docs/build/html/topics/impala_explain_level.html A docs/build/html/topics/impala_explain_plan.html A docs/build/html/topics/impala_faq.html A docs/build/html/topics/impala_file_formats.html A docs/build/html/topics/impala_fixed_issues.html A docs/build/html/topics/impala_float.html A docs/build/html/topics/impala_functions.html A docs/build/html/topics/impala_functions_overview.html A docs/build/html/topics/impala_grant.html A docs/build/html/topics/impala_group_by.html A docs/build/html/topics/impala_group_concat.html A docs/build/html/topics/impala_hadoop.h
[Impala-ASF-CR] IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports .. Patch Set 3: Code-Review+1 All good on my side. -- To view, visit http://gerrit.cloudera.org:8080/6515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I007e634f9da57289674683dd5bf64e3e3ca8f525 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports .. Patch Set 2: Code-Review+1 All of my issues have been addressed. Thank you. -- To view, visit http://gerrit.cloudera.org:8080/6515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I007e634f9da57289674683dd5bf64e3e3ca8f525 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Laurel Hale has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 7: > > Do we want to maintain the > > "make" command so users can simple 1) install the DITA-OT; 2) > > navigate to the "docs" directory; and 3) execute "make" to build > > HTML and PDF? I think this is the best way to go. > > Thanks. That means I have another patch set to do: adding dita to > PATH. I plan to remove all but 1 dita invocation example. That sounds right. -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Laurel Hale has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 7: > > Laurel, doe we still need to tell people how to generate SQL > > reference when the entire doc can be generated just fine? > > Laurel, can you comment on this question? No, we do not need to explain how to generate just the SQL reference. However, a larger issue is: Do we want to maintain the "make" command so users can simple 1) install the DITA-OT; 2) navigate to the "docs" directory; and 3) execute "make" to build HTML and PDF? I think this is the best way to go. -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Laurel Hale has posted comments on this change. Change subject: IMPALA-5140: improve docs building guidelines .. Patch Set 7: Code-Review+1 everything looks ok -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports .. Patch Set 1: (6 comments) There are some issues that I've listed in my comments. http://gerrit.cloudera.org:8080/#/c/6515/1/docs/topics/impala_fixed_issues.xml File docs/topics/impala_fixed_issues.xml: PS1, Line 573: fixed_issues_232 I looked in "impala_fixed_issues.xml" and there IS a concept id "fixed_issues_232". Not sure why this isn't working, but the link is not working. PS1, Line 2461: This points to empty search results: https://issues.apache.org/jira/issues/?jql=project%3Dimpala%20and%20fixVersion%3D%22Impala%202.0.5%22%20and%20resolution%3D%22Fixed%22 PS1, Line 2706: This points to empty search results: https://issues.apache.org/jira/issues/?jql=project%3Dimpala%20and%20fixVersion%3D%22Impala%202.0.4%22%20and%20resolution%3D%22Fixed%22 PS1, Line 2770: https://issues.apache.org/jira/issues/?jql=project%3Dimpala%20and%20fixVersion%3D%22Impala%202.0.3%22%20and%20resolution%3D%22Fixed%22 PS1, Line 2820: This points to empty search results: https://issues.apache.org/jira/issues/?jql=project%3Dimpala%20and%20fixVersion%3D%22Impala%202.0.2%22%20and%20resolution%3D%22Fixed%22 -- To view, visit http://gerrit.cloudera.org:8080/6515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I007e634f9da57289674683dd5bf64e3e3ca8f525 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Code-Review+1 Built cleanly, fixes display as expected in all files after a spot check (both html & pdf) -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Laurel Hale has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 4: Code-Review+1 Patch 4 builds cleanly and the content renders well in the html & pdf output. -- To view, visit http://gerrit.cloudera.org:8080/6439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Laurel Hale has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 3: Code-Review+1 Builds cleanly and renders well in both html & pdf. -- To view, visit http://gerrit.cloudera.org:8080/6439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions
Laurel Hale has posted comments on this change. Change subject: [DOCS] Genericize references to ODBC driver versions .. Patch Set 1: Code-Review+1 Builds cleanly and changes render well in both HTML & PDF. I agree with Jim that it would read well to remove the phrase, "versions of" in both places identified by him. -- To view, visit http://gerrit.cloudera.org:8080/6440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida0fa4f25934eaebf095b427413f20944f1a4f71 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Rewrite github URL for timezone source file
Laurel Hale has posted comments on this change. Change subject: [DOCS] Rewrite github URL for timezone source file .. Patch Set 1: Code-Review+1 Builds cleanly, displays perfectly in both html & pdf. -- To view, visit http://gerrit.cloudera.org:8080/6438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40bff9286d08f1de11abd9ab4b804855f0330cc2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize cdh sg component kms link
Laurel Hale has posted comments on this change. Change subject: [DOCS] Genericize cdh_sg_component_kms link .. Patch Set 1: (1 comment) sounds reasonable to me. http://gerrit.cloudera.org:8080/#/c/6396/1/docs/topics/impala_new_features.xml File docs/topics/impala_new_features.xml: PS1, Line 1868: cdh > There's a few like that and I'd like to consider those as a group, so leavi Sounds reasonable to me. -- To view, visit http://gerrit.cloudera.org:8080/6396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11fcac18533ea07ef03013034d246b8273882c96 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize admission config noncm page
Laurel Hale has posted comments on this change. Change subject: [DOCS] Genericize admission_config_noncm page .. Patch Set 1: I looked at the source and the comma is outside the tag. It's not super critical, but an English wog like me noticed it. :-) -- To view, visit http://gerrit.cloudera.org:8080/6391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize cdh sg component kms link
Laurel Hale has posted comments on this change. Change subject: [DOCS] Genericize cdh_sg_component_kms link .. Patch Set 1: Code-Review+1 (1 comment) Files build cleanly, content displays as expected in html & pdf, only displays in XML source. Only comment is can we eliminate references to 'cdh' in the token names? http://gerrit.cloudera.org:8080/#/c/6396/1/docs/topics/impala_new_features.xml File docs/topics/impala_new_features.xml: PS1, Line 1868: cdh Just a thought--can we eliminate all references to cdh by changing the name of this token? -- To view, visit http://gerrit.cloudera.org:8080/6396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11fcac18533ea07ef03013034d246b8273882c96 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize admission config noncm page
Laurel Hale has posted comments on this change. Change subject: [DOCS] Genericize admission_config_noncm page .. Patch Set 1: Code-Review+1 (1 comment) Files build cleanly, displays as expected in html & pdf, and source XML is clean. Only one small foobar where the comman should be placed within the quotations marks, but marking this +1. http://gerrit.cloudera.org:8080/#/c/6391/1/docs/topics/impala_admission.xml File docs/topics/impala_admission.xml: PS1, Line 38: . Period should be placed within the double quotation marks for American English. -- To view, visit http://gerrit.cloudera.org:8080/6391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia510a1eb53eba2f1127f57fa1f8bfe39525e0613 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Take out 'work in progress' language from impala intro
Laurel Hale has posted comments on this change. Change subject: [DOCS] Take out 'work in progress' language from impala_intro .. Patch Set 1: Code-Review+1 (1 comment) Files build cleanly, text displays as expected in html & pdf, all okay in source XML. I'm +1'ing this, but the comma and period should be placed within the double quotation marks. http://gerrit.cloudera.org:8080/#/c/6392/1/docs/topics/impala_intro.xml File docs/topics/impala_intro.xml: PS1, Line 54: , Typically in American English, the comma and periods are placed within the double quotation marks. In British English this is reversed. -- To view, visit http://gerrit.cloudera.org:8080/6392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3db9e1a9c1e4acf49ce072eceee2ba437590bf8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Remove comment from impala prereqs page
Laurel Hale has posted comments on this change. Change subject: [DOCS] Remove comment from impala_prereqs page .. Patch Set 1: Code-Review+1 Files build without error, display as expected in both html & pdf, and 'CDH' reference removed from source XML. Looks good! -- To view, visit http://gerrit.cloudera.org:8080/6394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40ff01ec1edfb25aa25334375334ec784c5c7da8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Remove CM comments from impala txtfile
Laurel Hale has posted comments on this change. Change subject: [DOCS] Remove CM comments from impala_txtfile .. Patch Set 1: Code-Review+1 Files build cleanly. Change displays as expected in html, pdf, and source. -- To view, visit http://gerrit.cloudera.org:8080/6395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b6668204aa28d1af276fe778ccd815f3f4c877 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Genericize link on impala parquet page
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Genericize link on impala_parquet page .. Patch Set 1: Code-Review+1 Files build without error and / substitution works perfectly in both html & pdf. -- To view, visit http://gerrit.cloudera.org:8080/6393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5889e8add9c05284bd75f2965d141a43f9a6071 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Laurel Hale has posted comments on this change. Change subject: IMPALA-3405: [DOCS] Pare down upgrading section .. Patch Set 4: Code-Review+1 (1 comment) Builds cleanly, looks good, except for one small typo described below. http://gerrit.cloudera.org:8080/#/c/6008/4/docs/topics/impala_upgrading.xml File docs/topics/impala_upgrading.xml: PS4, Line 80: host should be "hosts" -- To view, visit http://gerrit.cloudera.org:8080/6008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links .. Patch Set 1: (23 comments) Most of the issues were caused with inconsistencies in the referenced to the keydef ditamap or missing keydef/keyref references. Needs another patch set to +1. http://gerrit.cloudera.org:8080/#/c/6345/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: PS1, Line 319: Shouldn't this be "sg_hive_sql"? Here's an excerpt from the impala_keydefs_ditamap: the documentation for Apache Sentry PS1, Line 3110: If your cluster is running an older release that has this restriction, : to use both of these security features with Impala through a JDBC application, : use the Cloudera JDBC Connector as the JDBC driver. This is confusing. Try chunking this up into two sentences. For example: "If your cluster is running an older release that has this restriction, use Kerberos and SSL with Impala through a JDBC application. Then use the appropriate JDBC Connector as the JDBC driver." This makes it more "grokable" and removes the proprietary reference. http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_authorization.xml File docs/topics/impala_authorization.xml: PS1, Line 1293: : CREATE EXTERNAL TABLE : ALL, SELECT : Database (ALL), URI (SELECT) : : : SELECT : SELECT : Table, View; you can have SELECT privilege for a view without having SELECT privilege : for the underlying tables. See : : for details about column-level authorization. : Before column-level authorization was added in the way to implement : column-level security was by creating views that referenced particular sets of columns. : : : USE : Any privilege : Any object in the database : : Could this verbiage be deleted since it is commented out? It would reduce clutter and complexity. http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_fixed_issues.xml File docs/topics/impala_fixed_issues.xml: PS1, Line 1346: Issues Fixed in The "Impala 2.2.8" was dropped from the heading in the rendered docs (both html & pdf). When I looked in the impala_keydefs.ditamap, I see that it's missing from there. You must define "impala228" there. PS1, Line 1460: Issues Fixed in Same thing happened to this heading--the reference to "Impala 2.2.7" was dropped in the rendered doc (both html & pdf). Same as previous keyref, there is no definition for "impala227" in impala_keydefs.ditamap. PS1, Line 1886: Issues Fixed in "impala221" isn't defined in impala_keydefs.ditamap so it isn't showing up in the heading of rendered docs. (html & pdf) PS1, Line 2088: Issues Fixed in "impala2310" not defined in keydefs ditamap so dropped from rendered docs. PS1, Line 2098: Issues Fixed in "impala217" not defined in keydefs ditamap so dropped from rendered docs. http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_incompatible_changes.xml File docs/topics/impala_incompatible_changes.xml: PS1, Line 816: / Trailing forward slash should be removed from heading. Shows up in rendered doc (both html & pdf) http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_new_features.xml File docs/topics/impala_new_features.xml: PS1, Line 2153: impala_authorization.xml#authorization This value is not present in the keydefs ditamap, so it was dropped out the of rendered docs completely (both html & pdf). Sentence in rendered docs is, "See for details." PS1, Line 2373: impala_authorization.xml#authorization Same thing happened here. This value is not present in the keydefs ditamap so reference was completely dropped in the rendered doc (both html & pdf). Sentence in rendered doc reads, "See for details." http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_odbc.xml File docs/topics/impala_odbc.xml: PS1, Line 62: xref keyref="3mDesWddUS"> The URL that this points to in the keydefs ditamap 404's. PS1, Line 101: Cloudera-ODBC-Driver-for-Impala-Install-Guide.pdf Could this proprietary reference be removed? PS1, Line 104: ClouderaImpalaODBC.dmg Could this proprietary reference be removed? PS1, Line 112: Cloudera ODBC Driver for Impala Install Guide.pdf Could this proprietary reference be removed? PS1, Line 129: Sample Cloudera Impala DSN=Cloudera ODBC Driver for Impala Could this proprietary reference be removed? PS1, Line 131: Sample Cloudera Impala DSN Could this proprietary reference be removed? PS1, Line 138: cloudera/impalaodbc/lib/universal/libcloudera Could these proprietary references be removed? PS1, Line 170: cloudera Could thi
[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links .. Patch Set 1: Code-Review+1 Builds cleanly and the cdh_ig_hdfs_caching token replaces beautifully in the built content. Looks good. -- To view, visit http://gerrit.cloudera.org:8080/6338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ddb3d7f0a398e70a0f741410bc6b1a309bd1686 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. Patch Set 2: John--I removed the sections that you requested. Please take another look. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/6083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal
Laurel Hale has uploaded a new patch set (#3). Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal Removed references to "Cloudera Manager" mostly by hiding the paragraphs that contained the references and rewriting them for the upstreams docs without referencing CM. This removes the references in the rendered docs, but does not remove them from the source XML. That part of the removal will be done in a subsequent work item. Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c --- M docs/topics/impala_breakpad.xml M docs/topics/impala_faq.xml M docs/topics/impala_fixed_issues.xml M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_new_features.xml 5 files changed, 105 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/6083/3 -- To view, visit http://gerrit.cloudera.org:8080/6083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Laurel Hale has posted comments on this change. Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references .. Patch Set 1: (6 comments) Most of this looks great, but I was a little confused about your intended scoping and about one of the included topics not showing up in the build. However, it did build html & pdf without throwing any errors. http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala.xml File docs/topics/impala.xml: This file didn't get picked up in the build. The build didn't contain any "impala.html." Is that expected behavior? http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_fixed_issues.xml File docs/topics/impala_fixed_issues.xml: Shouldn't many of these CDH references have been removed as part of "Remove material related to big lists of CDH fixed JIRAs."? Maybe I don't understand the scoping? http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_incompatible_changes.xml File docs/topics/impala_incompatible_changes.xml: PS1, Line 1318: impala-lzo-cdh4 Is it impossible to remove this reference? http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: PS1, Line 356: CDH Don't "CDH" references like this fall into the cleanup categories of this patch? http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_misc_functions.xml File docs/topics/impala_misc_functions.xml: PS1, Line 75: eyword keyref="impala225" Your replacement mechanism works great! http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_new_features.xml File docs/topics/impala_new_features.xml: PS1, Line 1343: CDH Still 19 CDH references showing up in the built docs. -- To view, visit http://gerrit.cloudera.org:8080/6267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal .. Patch Set 2: Fixed merge conflicts. Please review and if appropriate +2 and push to master. -- To view, visit http://gerrit.cloudera.org:8080/6108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26fc661144ba906828d5f6b5b2ea2eca02693369 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal
Laurel Hale has uploaded a new patch set (#2). Change subject: IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal .. IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal Removed the topic "impala_howto_rm.xml" from the build because it was focused on resource management by using Cloudera Manager. Commented it out of impala.ditamap, impala_keydefs.ditamap, and from a reference to it in shared/impala_common.xml. This removes it completely from the rendered upstream docs. A later project will remove the source XML. Change-Id: I26fc661144ba906828d5f6b5b2ea2eca02693369 --- M docs/impala.ditamap M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml 3 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/6108/2 -- To view, visit http://gerrit.cloudera.org:8080/6108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I26fc661144ba906828d5f6b5b2ea2eca02693369 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. Patch Set 1: Fixed merge conflicts. Please review and if appropriate, +2 and push to master. -- To view, visit http://gerrit.cloudera.org:8080/6083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal
Laurel Hale has uploaded a new patch set (#2). Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal Removed references to "Cloudera Manager" mostly by hiding the paragraphs that contained the references and rewriting them for the upstreams docs without referencing CM. This removes the references in the rendered docs, but does not remove them from the source XML. That part of the removal will be done in a subsequent work item. Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c --- M docs/topics/impala_breakpad.xml M docs/topics/impala_faq.xml M docs/topics/impala_fixed_issues.xml M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_new_features.xml 5 files changed, 2,011 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/6083/2 -- To view, visit http://gerrit.cloudera.org:8080/6083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. Patch Set 5: Resolved merge conflicts, please review and if possible +2 to push to master. -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
Hello Jim Apple, Ambreen Kazi, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6069 to look at the new patch set (#6). Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera Manager in the rendered documentation. In a subsequent cleanup project, the "Cloudera Manager" mentions will be removed from the XML. Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 --- M docs/shared/impala_common.xml M docs/topics/impala_perf_resources.xml M docs/topics/impala_perf_skew.xml M docs/topics/impala_perf_testing.xml M docs/topics/impala_scalability.xml M docs/topics/impala_txtfile.xml 6 files changed, 76 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6069/6 -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs.
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs. .. Patch Set 4: Resolved merge conflict, please review and if all looks in order, +2 and push to master. -- To view, visit http://gerrit.cloudera.org:8080/6064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. .. Patch Set 2: Resolved the merge conflict. Please review and if all looks in order, +2 to push to master -- To view, visit http://gerrit.cloudera.org:8080/6067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
Laurel Hale has uploaded a new patch set (#3). Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. .. IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. Hid instances of CM and rewrote for upstream docs when necessary. This still leaves occurences of CM in the XML, but not in the rendered documentation. A later project will remove all occurrences of CM from the XML. Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d --- M docs/topics/impala_impala_shell.xml M docs/topics/impala_proxy.xml M docs/topics/impala_resource_management.xml M docs/topics/impala_timeouts.xml M docs/topics/impala_udf.xml 5 files changed, 124 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6067/3 -- To view, visit http://gerrit.cloudera.org:8080/6067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs.
Laurel Hale has uploaded a new patch set (#4). Change subject: IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs. .. IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs. Used DITA attribute 'audience=hidden' when needed to preserve information for a future clean-up step. When it made sense, 'Cloudera Manager' was removedĀ and sections were rewritten. This clean-up task does not completely remove 'Cloudera Manager' from the upstream docs source XML, but it is now hidden in these files so it won't show up in the rendered version. A subsequent cleanup project will remove references in the XML source. Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0 --- M docs/topics/impala_admission.xml M docs/topics/impala_config_performance.xml M docs/topics/impala_noncm_installation.xml M docs/topics/impala_prereqs.xml 4 files changed, 119 insertions(+), 61 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/6064/4 -- To view, visit http://gerrit.cloudera.org:8080/6064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. Patch Set 4: Jim Apple--took the last sentence out of the commit message. -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
Laurel Hale has uploaded a new patch set (#5). Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera Manager in the rendered documentation. In a subsequent cleanup project, the "Cloudera Manager" mentions will be removed from the XML. Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 --- M docs/shared/impala_common.xml M docs/topics/impala_perf_resources.xml M docs/topics/impala_perf_skew.xml M docs/topics/impala_perf_testing.xml M docs/topics/impala_scalability.xml M docs/topics/impala_txtfile.xml 6 files changed, 60 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6069/5 -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. Patch Set 1: Jim Apple, Michael Brown: I redid the commit message. Please take a look and if you can, please +1 -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
Laurel Hale has uploaded a new patch set (#4). Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera Manager in the rendered documentation. In a subsequent cleanup project, the "Cloudera Manager" mentions will be removed from the XML. This patch set (#4) reworks the commit message, inserting a blank line between the title and the commit message. Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 --- M docs/shared/impala_common.xml M docs/topics/impala_perf_resources.xml M docs/topics/impala_perf_skew.xml M docs/topics/impala_perf_testing.xml M docs/topics/impala_scalability.xml M docs/topics/impala_txtfile.xml 6 files changed, 60 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6069/4 -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs. .. Patch Set 3: (9 comments) Please review these so we can get them pushed to master http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_admission.xml File docs/topics/impala_admission.xml: PS2, Line 224: Although the Impala admission control feature uses a fair-scheduler.xml configuration file : behind the scenes, this file does not depend on which scheduler is used for YARN. > Should we duplicate content or only hide the sentence/phrase with Cloudera John's strategy was to hide the content in this pass and rewrite to NOT use "Cloudera Manager" and then the hidden content will be taken care of in a subsequent clean up task. Line 654: To configure admission control, use a combination of startup options for the Impala daemon and edit > add comma; the sentence left behind reads awkwardly -- you could probably r Rewrote to: To configure admission control, use a combination of startup options for the Impala daemon and edit or create the configuration files fair-scheduler.xml and llama-site.xml. PS2, Line 717: ing the > After hiding the CM section, you're left with only 1 example. Done http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_noncm_installation.xml File docs/topics/impala_noncm_installation.xml: PS2, Line 109: (For CDH 4, this is a different repository than for CDH.) > I think you can delete this. John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. Line 140: Cloudera recommends that you not install Impala on any HDFS NameNode. Installing Impala on NameNodes > hide? John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_prereqs.xml File docs/topics/impala_prereqs.xml: Line 86: software requirements > Explicitly list the supported OSs. They were originally hidden because we w John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. PS2, Line 93: The relevant supported operating systems : and versions for Impala are the same as for the corresponding CDH 5 > Remove or hide this sentence. John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_tutorial.xml File docs/topics/impala_tutorial.xml: Line 58: > assorted references to CDH and CM quickstart in this list. John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. Line 134: Copyright (c) 2012 Cloudera, Inc. All rights reserved. > Remove references to cloudera from all the code samples. Several scattered John asked me to confine my changes to only scrubbing for references to Cloudera Manager. Other proprietary references will be handled in subsequent "scrub" tasks. -- To view, visit http://gerrit.cloudera.org:8080/6064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. .. Patch Set 2: Please review these so we can get them pushed to master. -- To view, visit http://gerrit.cloudera.org:8080/6067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera .. Patch Set 3: Please review these so we can get them pushed to master. -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. Patch Set 1: Please review these so we can get them pushed to master. -- To view, visit http://gerrit.cloudera.org:8080/6083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal .. Patch Set 1: Please review these so we can get them pushed to master. -- To view, visit http://gerrit.cloudera.org:8080/6108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26fc661144ba906828d5f6b5b2ea2eca02693369 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera .. Patch Set 3: (6 comments) Ambreen, I addressed your comment about the audience=Cloudera in impala_common.xml. Please review and +1 if you can. Thanks. http://gerrit.cloudera.org:8080/#/c/6069/1//COMMIT_MSG Commit Message: PS1, Line 7: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. > In the commit message, have a blank line after this one. Otherwise it's tre Got the same comment from Jim. Stopped doing it this way. Not really a good use of time to redo for this. http://gerrit.cloudera.org:8080/#/c/6069/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: PS1, Line 1475: . : You can specify a single directory, or a comma-separated list of di > I would say just take out the whole phrase. Done http://gerrit.cloudera.org:8080/#/c/6069/2/docs/shared/impala_common.xml File docs/shared/impala_common.xml: PS2, Line 3665: "hidden"> > replace with 'hidden' -- There was a separate gerrit to replace all of thes Done http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_perf_resources.xml File docs/topics/impala_perf_resources.xml: PS1, Line 78: such as cgroups > Question for MJ, whether the reference to cgroups is appropriate anymore at Did you add him to the review? I don't see it. http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_perf_testing.xml File docs/topics/impala_perf_testing.xml: PS1, Line 46: : > Watch out for trailing spaces or tabs on these new blank lines. I'm very careful about these. I insert a space and then a return to keep the chunks of text manageable. Don't think any change is necessary here. http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_txtfile.xml File docs/topics/impala_txtfile.xml: PS1, Line 505: On systems using cluster management software or those not using cluster management : software > That's a little bit convoluted phrasing. Let's find an SME on the dev team Just checked in with Alex B. to find an LZO setup guru on the Impala team. -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s
Laurel Hale has uploaded a new patch set (#3). Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera .. IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera Manager in the rendered documentation. In a subsequent cleanup project, the "Cloudera Manager" mentions will be removed from the XML. This patch set (#3) includes another change to impala_common.xml requested by Ambreen. I've replaced three instances of 'audience="Cloudera"' with 'audience="hidden".' Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 --- M docs/shared/impala_common.xml M docs/topics/impala_perf_resources.xml M docs/topics/impala_perf_skew.xml M docs/topics/impala_perf_testing.xml M docs/topics/impala_scalability.xml M docs/topics/impala_txtfile.xml 6 files changed, 60 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6069/3 -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Matthew Jacobs
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. .. Patch Set 2: (8 comments) Ambreen, I've answered your comments, can you take a look and +1 if all looks in order? Thanks. http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: PS1, Line 336: > Isn't this too blunt an instrument to hide the whole ? Everything under Done http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: Line 114: Consider enabling sticky sessions. Cloudera recommends enabling this setting > 'Cloudera' John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks. PS2, Line 261: CDH Secu > CDH reference John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks. http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_resource_management.xml File docs/topics/impala_resource_management.xml: Line 357: > this whole concept is only left with one line -- which isn't even a limitat John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other issues will be addressed in subsequent cleanup tasks. http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_timeouts.xml File docs/topics/impala_timeouts.xml: PS1, Line 188: Various client applications > We may as well preserve part of this sentence, at least the example of: Done http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_timeouts.xml File docs/topics/impala_timeouts.xml: PS2, Line 43: CDH > Remove CDH. John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks. http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_udf.xml File docs/topics/impala_udf.xml: Line 425: Start at https://archive.cloudera.com/cdh5/"; scope="external" format="html"/> for the CDH 5 > Are there links to upstream repos that can replace these? John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks. PS2, Line 433: CDH 4 > CDH4-specific info you could probably delete. John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks. -- To view, visit http://gerrit.cloudera.org:8080/6067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.
Laurel Hale has uploaded a new patch set (#3). Change subject: IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs. .. IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs. Used DITA attribute 'audience=hidden' when needed to preserve information for a future clean-up step. When it made sense, 'Cloudera Manager' was removedĀ and sections were rewritten. This clean-up task does not completely remove 'Cloudera Manager' from the upstream docs source XML, but it is now hidden in these files so it won't show up in the rendered version. A subsequent cleanup project will remove references in the XML source. This patch set addresses Ambreen's comments on Patch set 2 with a couple of rewrites. Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0 --- M docs/topics/impala_admission.xml M docs/topics/impala_config_performance.xml M docs/topics/impala_noncm_installation.xml M docs/topics/impala_prereqs.xml M docs/topics/impala_tutorial.xml 5 files changed, 120 insertions(+), 74 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/6064/3 -- To view, visit http://gerrit.cloudera.org:8080/6064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal.
Hello John Russell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6070 to look at the new patch set (#4). Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. .. IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the upstream docs. This removes the CM references from the rendered docs. A subsequent cleanup project will remove occurrences of CM from the XML. This patch includes fixes to files in response to John Russell's first set of review comments. Change-Id: I4967fae275a8822274aece14a15107237445aba5 --- M docs/topics/impala_isilon.xml M docs/topics/impala_logging.xml M docs/topics/impala_s3.xml M docs/topics/impala_webui.xml 4 files changed, 35 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/6070/4 -- To view, visit http://gerrit.cloudera.org:8080/6070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4967fae275a8822274aece14a15107237445aba5 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Laurel Hale has posted comments on this change. Change subject: IMPALA-3405: [DOCS] Pare down upgrading section .. Patch Set 1: There is a merge conflict and after resolving it, the rendered file includes the full last line "To upgrade Impala, run these Linux commands on the appropriate hosts in your cluster:" According to the changes I see in gerrit, you removed then colon at the end of that sentence so perhaps my resolution of the merge conflict was not correct. Please remove the merge conflict so I can review the rendered file as you intend it. Otherwise, built without errors. -- To view, visit http://gerrit.cloudera.org:8080/6008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Laurel Hale has posted comments on this change. Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info .. Patch Set 2: Code-Review+1 (1 comment) Changes build cleanly and topic looks good. http://gerrit.cloudera.org:8080/#/c/6005/2/docs/topics/impala_install.xml File docs/topics/impala_install.xml: PS2, Line 43: Cloudera Enterprise Core I assume that removal of this string is slated for a subsequent cleanup task? -- To view, visit http://gerrit.cloudera.org:8080/6005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Construct "fixed issues" topic for 2.8 release notes
Laurel Hale has posted comments on this change. Change subject: [DOCS] Construct "fixed issues" topic for 2.8 release notes .. Patch Set 1: Code-Review+1 (1 comment) Did a build and no unexpected errors thrown. Rendered docs look good. http://gerrit.cloudera.org:8080/#/c/6125/1/docs/topics/impala_fixed_issues.xml File docs/topics/impala_fixed_issues.xml: PS1, Line 49: 5.10.x Is it possible to stop adding new CDH references? We are using the / attributes to switch out as appropriate for upstream/downstream rendered docs. -- To view, visit http://gerrit.cloudera.org:8080/6125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7033c61dafb2dbaf4f05a687bed3bd53883a6ff4 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Silvius Rus Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Fix build warning due to removal of FAQ entries.
Laurel Hale has posted comments on this change. Change subject: [DOCS] Fix build warning due to removal of FAQ entries. .. Patch Set 1: Code-Review+1 Clean build--no error messages thrown and change in doc looks good. -- To view, visit http://gerrit.cloudera.org:8080/6126 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d4d64e73ecbad0a3491c87bea0dfebc5eefa3ef Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic
Laurel Hale has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. Patch Set 7: Code-Review+1 I'm still getting some errors when it builds. Looks like there are some broken links to impala_faq.xml, but your changes are being picked up in the build, so rendered docs look okay. -- To view, visit http://gerrit.cloudera.org:8080/5962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Ambreen Kazi Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial
Laurel Hale has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 3: Code-Review+1 Looks good. -- To view, visit http://gerrit.cloudera.org:8080/5663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44245b65ce6f247ae8771f582f4b33c3712145ae Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/6108 Change subject: IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal .. IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal Removed the topic "impala_howto_rm.xml" from the build because it was focused on resource management by using Cloudera Manager. Commented it out of impala.ditamap, impala_keydefs.ditamap, and from a reference to it in shared/impala_common.xml. This removes it completely from the rendered upstream docs. A later project will remove the source XML. Change-Id: I26fc661144ba906828d5f6b5b2ea2eca02693369 --- M docs/impala.ditamap M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/6108/1 -- To view, visit http://gerrit.cloudera.org:8080/6108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I26fc661144ba906828d5f6b5b2ea2eca02693369 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.
Laurel Hale has uploaded a new patch set (#2). Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. .. IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. Hid instances of CM and rewrote for upstream docs when necessary. This still leaves occurences of CM in the XML, but not in the rendered documentation. A later project will remove all occurrences of CM from the XML. This patch set includes fixes made in response to John Russell's review. Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d --- M docs/topics/impala_impala_shell.xml M docs/topics/impala_proxy.xml M docs/topics/impala_resource_management.xml M docs/topics/impala_timeouts.xml M docs/topics/impala_udf.xml 5 files changed, 116 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6067/2 -- To view, visit http://gerrit.cloudera.org:8080/6067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell
[Impala-ASF-CR] IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.
Laurel Hale has uploaded a new patch set (#2). Change subject: IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs. .. IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs. Used DITA attribute 'audience=hidden' when needed to preserve information for a future clean-up step. When it made sense, 'Cloudera Manager' was removedĀ and sections were rewritten. This clean-up task does not completely remove 'Cloudera Manager' from the upstream docs source XML, but it is now hidden in these files so it won't show up in the rendered version. A subsequent cleanup project will remove references in the XML source. Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0 --- M docs/topics/impala_admission.xml M docs/topics/impala_config_performance.xml M docs/topics/impala_noncm_installation.xml M docs/topics/impala_prereqs.xml M docs/topics/impala_tutorial.xml 5 files changed, 72 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/6064/2 -- To view, visit http://gerrit.cloudera.org:8080/6064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 1 of removing 'Cloudera Manager'
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6049 to look at the new patch set (#2). Change subject: IMPALA-3401 [DOCS] Phase 1 of removing 'Cloudera Manager' .. IMPALA-3401 [DOCS] Phase 1 of removing 'Cloudera Manager' Rewrote sections to eliminate 'Cloudera Manager' from topics. Look for subsequent phases to remove remaining instances of CM. Change-Id: I02ff6c3fc74e2e59b5d130226bd38c23c9c094b7 --- M docs/shared/impala_common.xml M docs/topics/impala_config_options.xml M docs/topics/impala_upgrading.xml 3 files changed, 6 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/6049/2 -- To view, visit http://gerrit.cloudera.org:8080/6049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I02ff6c3fc74e2e59b5d130226bd38c23c9c094b7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the u
Laurel Hale has uploaded a new patch set (#2). Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the upstream docs. This removes the CM references from the rendered docs. A .. IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the upstream docs. This removes the CM references from the rendered docs. A subsequent cleanup project will remove occurrences of CM from the XML. This patch includes fixes to files in response to John Russell's first set of review comments. Change-Id: I4967fae275a8822274aece14a15107237445aba5 --- M docs/topics/impala_isilon.xml M docs/topics/impala_logging.xml M docs/topics/impala_s3.xml M docs/topics/impala_webui.xml 4 files changed, 37 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/6070/2 -- To view, visit http://gerrit.cloudera.org:8080/6070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4967fae275a8822274aece14a15107237445aba5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal
Laurel Hale has abandoned this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal .. Abandoned Made a mistake trying to create a second patch set. -- To view, visit http://gerrit.cloudera.org:8080/6099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Icfe3a7bd7d2a086fa5dcbc0c06ebeee1f52c5519 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s
Laurel Hale has uploaded a new patch set (#2). Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera .. IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera Manager in the rendered documentation. In a subsequent cleanup project, the "Cloudera Manager" mentions will be removed from the XML. This patch includes a fix to impala_common.xml requested by John Russell. Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 --- M docs/shared/impala_common.xml M docs/topics/impala_perf_resources.xml M docs/topics/impala_perf_skew.xml M docs/topics/impala_perf_testing.xml M docs/topics/impala_scalability.xml M docs/topics/impala_txtfile.xml 6 files changed, 56 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6069/2 -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Matthew Jacobs
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/6099 Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal .. IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal Fixed impala_common.xml as requested. Change-Id: Icfe3a7bd7d2a086fa5dcbc0c06ebeee1f52c5519 --- M docs/shared/impala_common.xml 1 file changed, 8 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/6099/1 -- To view, visit http://gerrit.cloudera.org:8080/6099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icfe3a7bd7d2a086fa5dcbc0c06ebeee1f52c5519 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/6083 Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal Removed references to "Cloudera Manager" mostly by hiding the paragraphs that contained the references and rewriting them for the upstreams docs without referencing CM. This removes the references in the rendered docs, but does not remove them from the source XML. That part of the removal will be done in a subsequent work item. Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c --- M docs/shared/impala_common.xml M docs/topics/impala_breakpad.xml M docs/topics/impala_faq.xml M docs/topics/impala_fixed_issues.xml M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_new_features.xml 6 files changed, 90 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/6083/1 -- To view, visit http://gerrit.cloudera.org:8080/6083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the u
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/6070 Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the upstream docs. This removes the CM references from the rendered docs. A .. IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the upstream docs. This removes the CM references from the rendered docs. A subsequent cleanup project will remove occurrences of CM from the XML. Change-Id: I4967fae275a8822274aece14a15107237445aba5 --- M docs/topics/impala_isilon.xml M docs/topics/impala_logging.xml M docs/topics/impala_s3.xml M docs/topics/impala_webui.xml 4 files changed, 78 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/6070/1 -- To view, visit http://gerrit.cloudera.org:8080/6070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4967fae275a8822274aece14a15107237445aba5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale
[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/6069 Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera .. IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera Manager in the rendered documentation. In a subsequent cleanup project, the "Cloudera Manager" mentions will be removed from the XML. Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 --- M docs/shared/impala_common.xml M docs/topics/impala_perf_resources.xml M docs/topics/impala_perf_skew.xml M docs/topics/impala_perf_testing.xml M docs/topics/impala_scalability.xml M docs/topics/impala_txtfile.xml 6 files changed, 49 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6069/1 -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale