[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Abandoned Will added corresponding functionality with 0355d373a, so this patch is no longer needed. -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 6: > After chatting with Alexey I added these as part of the "6/n" patch > 0355d373a. > > Alexey, think we can abandon this change now? > After chatting with Alexey I added these as part of the "6/n" patch > 0355d373a. > > Alexey, think we can abandon this change now? Ah, yes -- I think this patch is no longer needed. Thank you for the heads up! -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 10 May 2018 19:50:19 + Gerrit-HasComments: No
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 6: After chatting with Alexey I added these as part of the "6/n" patch 0355d373a. Alexey, think we can abandon this change now? -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 10 May 2018 17:56:01 + Gerrit-HasComments: No
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 6: Verified+1 Unrelated clock sync errors: Cannot initialize clock: Error reading clock. Clock considered unsynchronized -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 17 Apr 2018 21:42:51 + Gerrit-HasComments: No
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 5: (1 comment) > (1 comment) > > How does this behave with table and/or tablet filters? Can you > check what it does make sense and add a couple tests for it? Yes, it works as expected -- the summary displays the counters related to the entities that satisfy table/tablet filters. I added corresponding tests as well. http://gerrit.cloudera.org:8080/#/c/10054/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10054/5//COMMIT_MSG@27 PS5, Line 27: Masters| 1 > nit: Can we order it Done -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 17 Apr 2018 21:05:27 + Gerrit-HasComments: Yes
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10054 to look at the new patch set (#6). Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. [tools] minor enhancements on 'kudu cluster ksck' output Added information on table replication factor into the summary by table output. Also, added information on the total count of tables, tablets and replicas. A snippet from sample output: Summary by table Name | RF | Status | Total Tablets | Healthy | Recovering | Under-replicated | Unavailable --++-+---+-++--+- giga | 3 | HEALTHY | 8 | 8 | 0 | 0 | 0 mega | 1 | HEALTHY | 8 | 8 | 0 | 0 | 0 | Total Count +- Masters| 1 Tablet Servers | 3 Tables | 2 Tablets| 16 Replicas | 32 OK Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 3 files changed, 130 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10054/6 -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 5: (1 comment) How does this behave with table and/or tablet filters? Can you check what it does make sense and add a couple tests for it? http://gerrit.cloudera.org:8080/#/c/10054/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10054/5//COMMIT_MSG@27 PS5, Line 27: Masters| 1 nit: Can we order it masters tablet servers tables tablets replicas -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 13 Apr 2018 17:50:22 + Gerrit-HasComments: Yes
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10054 to look at the new patch set (#5). Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. [tools] minor enhancements on 'kudu cluster ksck' output Added information on table replication factor into the summary by table output. Also, added information on the total count of tables, tablets and replicas. A snippet from sample output: Summary by table Name | RF | Status | Total Tablets | Healthy | Recovering | Under-replicated | Unavailable --++-+---+-++--+- giga | 3 | HEALTHY | 8 | 8 | 0 | 0 | 0 mega | 1 | HEALTHY | 8 | 8 | 0 | 0 | 0 | Total Count +- Tables | 2 Tablets| 16 Replicas | 32 Tablet Servers | 3 Masters| 1 OK Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 3 files changed, 108 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10054/5 -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10054 to look at the new patch set (#4). Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. [tools] minor enhancements on 'kudu cluster ksck' output Added information on table replication factor into the summary by table output. Also, added information on the total count of tables, tablets and replicas. A snippet from sample output: Summary by table Name | RF | Status | Total Tablets | Healthy | Recovering | Under-replicated | Unavailable --++-+---+-++--+- giga | 3 | HEALTHY | 8 | 8 | 0 | 0 | 0 mega | 1 | HEALTHY | 8 | 8 | 0 | 0 | 0 | Total Count +- Tables | 2 Tablets| 16 Replicas | 32 Tablet Servers | 3 Masters| 1 OK Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 3 files changed, 108 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10054/4 -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10054 to look at the new patch set (#3). Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. [tools] minor enhancements on 'kudu cluster ksck' output Added information on table replication factor into the summary by table output. Also, added information on the total count of tables, tablets and replicas. A snippet from sample output: Summary by table Name | RF | Status | Total Tablets | Healthy | Recovering | Under-replicated | Unavailable --++-+---+-++--+- giga | 3 | HEALTHY | 8 | 8 | 0 | 0 | 0 mega | 1 | HEALTHY | 8 | 8 | 0 | 0 | 0 | Total Count +- Tables | 2 Tablets| 16 Replicas | 32 Tablet Servers | 3 Masters| 1 OK Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 --- M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 2 files changed, 24 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10054/3 -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc@536 PS2, Line 536: "Total:\n tables $0\n tablets $1\n replicas $2" > nit: I prefer to put output like this in a table, e.g. Good idea. I appreciate you overcome the issue with non-fixed fonts :) Maybe, you could just do that in an independent console editor and that copy-paste the result in here. However, from what I see here, the gerrit uses fixed-width font in the result rendering. http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc@870 PS2, Line 870: const int table_num_replicas = table->num_replicas(); > nit: Eliminate the local in favor of ts->replication_factor Done -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 13 Apr 2018 01:49:13 + Gerrit-HasComments: Yes
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc@536 PS2, Line 536: "Total:\n tables $0\n tablets $1\n replicas $2" nit: I prefer to put output like this in a table, e.g. | Total -+-- Tables | 10 Tablets | 180 Replicas | 540 Btw did you know gerrit's comment editor doesn't use a fixed-width font, so it's obnoxious to get a table to line up like that :). http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc@870 PS2, Line 870: const int table_num_replicas = table->num_replicas(); nit: Eliminate the local in favor of ts->replication_factor -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 12 Apr 2018 23:52:50 + Gerrit-HasComments: Yes
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10054 to look at the new patch set (#2). Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. [tools] minor enhancements on 'kudu cluster ksck' output Added information on table replication factor into the summary by table output. Also, added information on the total count of tables, tablets and replicas. A snippet from sample output: Summary by table Name | RF | Status | Total Tablets | Healthy | Recovering | Under-replicated | Unavailable --++-+---+-++--+- giga | 3 | HEALTHY | 8 | 8 | 0 | 0 | 0 mega | 1 | HEALTHY | 8 | 8 | 0 | 0 | 0 Total: tables 2 tablets 16 replicas 32 OK Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 --- M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 2 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10054/2 -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10054/1/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10054/1/src/kudu/tools/ksck.cc@516 PS1, Line 516: total_tablets += ts.TotalTablets(); > warning: 'ts' used after it was moved [misc-use-after-move] Done -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 12 Apr 2018 23:26:41 + Gerrit-HasComments: Yes
[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10054 Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. [tools] minor enhancements on 'kudu cluster ksck' output Added information on table replication factor into the summary by table output. Also, added information on the total count of tables, tablets and replicas. A snippet from sample output: Summary by table Name | RF | Status | Total Tablets | Healthy | Recovering | Under-replicated | Unavailable --++-+---+-++--+- giga | 3 | HEALTHY | 8 | 8 | 0 | 0 | 0 mega | 1 | HEALTHY | 8 | 8 | 0 | 0 | 0 Total: tables 2 tablets 16 replicas 32 OK Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 --- M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 2 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10054/1 -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
