Re: Review Request 44511: Add registry tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/
---

(Updated March 24, 2016, 8:35 a.m.)


Review request for mesos and Adam B.


Changes
---

Adressed comments of Adam.


Bugs: MESOS-4797
https://issues.apache.org/jira/browse/MESOS-4797


Repository: mesos


Description
---

Add registry tests for /weights endpoint.


Diffs (updated)
-

  src/tests/dynamic_weights_tests.cpp ee0c4b1cc20e76a35a8e4e445f6827a1fc33e6c6 
  src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 

Diff: https://reviews.apache.org/r/44511/diff/


Testing
---

Add three sub tests for /weights endpoint registry in this patch:

1. Tests whether the weights replicated log is initialized with the `--weights` 
flag when bootstrapping the cluster.
2. Tests whether the weights replicated log can be updated with `/weights` 
endpoint.
3. Tests whether the `--weights` flag is ignored and use the registry value 
instead when Mesos master subsequently starts with `--weights` flag still 
specified.

./src/mesos-tests --gtest_filter=Strict/RegistrarTest.UpdateWeights/*
[==] Running 2 tests from 1 test case.
[--] Global test environment set-up.
[--] 2 tests from Strict/RegistrarTest
[ RUN  ] Strict/RegistrarTest.UpdateWeights/0
[   OK ] Strict/RegistrarTest.UpdateWeights/0 (103 ms)
[ RUN  ] Strict/RegistrarTest.UpdateWeights/1
[   OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms)
[--] 2 tests from Strict/RegistrarTest (171 ms total)

[--] Global test environment tear-down
[==] 2 tests from 1 test case ran. (178 ms total)
[  PASSED  ] 2 tests.


make && make check.


Thanks,

Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Adam B]

> On March 21, 2016, 1:35 a.m., Adam B wrote:
> > Need to get rid of the unnecessary stringify/atof translation, but I like 
> > the new low-level registry Operation test.
> 
> Yongqiao Wang wrote:
> Adam, cloud you help to review and commit this patch firstly, then I will 
> update the all tests in `dynamic_weights_tests.cpp` to checkout the updated 
> results with /weights endpoint rather than /roles endpoint.

Of course. Updating tests to GET /weights before /roles has to happen after we 
get the GET /weights endpoint committed anyway. This can go in asap.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/#review124511
---


On March 22, 2016, 12:22 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44511/
> ---
> 
> (Updated March 22, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4797
> https://issues.apache.org/jira/browse/MESOS-4797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add registry tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/dynamic_weights_tests.cpp 
> ee0c4b1cc20e76a35a8e4e445f6827a1fc33e6c6 
>   src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 
> 
> Diff: https://reviews.apache.org/r/44511/diff/
> 
> 
> Testing
> ---
> 
> Add three sub tests for /weights endpoint registry in this patch:
> 
> 1. Tests whether the weights replicated log is initialized with the 
> `--weights` flag when bootstrapping the cluster.
> 2. Tests whether the weights replicated log can be updated with `/weights` 
> endpoint.
> 3. Tests whether the `--weights` flag is ignored and use the registry value 
> instead when Mesos master subsequently starts with `--weights` flag still 
> specified.
> 
> ./src/mesos-tests --gtest_filter=Strict/RegistrarTest.UpdateWeights/*
> [==] Running 2 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 2 tests from Strict/RegistrarTest
> [ RUN  ] Strict/RegistrarTest.UpdateWeights/0
> [   OK ] Strict/RegistrarTest.UpdateWeights/0 (103 ms)
> [ RUN  ] Strict/RegistrarTest.UpdateWeights/1
> [   OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms)
> [--] 2 tests from Strict/RegistrarTest (171 ms total)
> 
> [--] Global test environment tear-down
> [==] 2 tests from 1 test case ran. (178 ms total)
> [  PASSED  ] 2 tests.
> 
> 
> make && make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/#review125225
---


Fix it, then Ship it!




Looks great! I'd move the weightInfo setup right before it's used, but that's 
trivial enough I can do it before committing.


src/tests/registrar_tests.cpp (lines 912 - 915)


I would move this below the "prepare the registrar" step, just before the 
`registrar.apply()`



src/tests/registrar_tests.cpp (lines 929 - 933)


Ditto. Don't confuse me with new weights when you're about to check that 
the old weights are still there after recovery.


- Adam B


On March 22, 2016, 12:22 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44511/
> ---
> 
> (Updated March 22, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4797
> https://issues.apache.org/jira/browse/MESOS-4797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add registry tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/dynamic_weights_tests.cpp 
> ee0c4b1cc20e76a35a8e4e445f6827a1fc33e6c6 
>   src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 
> 
> Diff: https://reviews.apache.org/r/44511/diff/
> 
> 
> Testing
> ---
> 
> Add three sub tests for /weights endpoint registry in this patch:
> 
> 1. Tests whether the weights replicated log is initialized with the 
> `--weights` flag when bootstrapping the cluster.
> 2. Tests whether the weights replicated log can be updated with `/weights` 
> endpoint.
> 3. Tests whether the `--weights` flag is ignored and use the registry value 
> instead when Mesos master subsequently starts with `--weights` flag still 
> specified.
> 
> ./src/mesos-tests --gtest_filter=Strict/RegistrarTest.UpdateWeights/*
> [==] Running 2 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 2 tests from Strict/RegistrarTest
> [ RUN  ] Strict/RegistrarTest.UpdateWeights/0
> [   OK ] Strict/RegistrarTest.UpdateWeights/0 (103 ms)
> [ RUN  ] Strict/RegistrarTest.UpdateWeights/1
> [   OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms)
> [--] 2 tests from Strict/RegistrarTest (171 ms total)
> 
> [--] Global test environment tear-down
> [==] 2 tests from 1 test case ran. (178 ms total)
> [  PASSED  ] 2 tests.
> 
> 
> make && make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/
---

(Updated March 22, 2016, 7:22 a.m.)


Review request for mesos and Adam B.


Changes
---

Address comments of Adam.


Bugs: MESOS-4797
https://issues.apache.org/jira/browse/MESOS-4797


Repository: mesos


Description
---

Add registry tests for /weights endpoint.


Diffs (updated)
-

  src/tests/dynamic_weights_tests.cpp ee0c4b1cc20e76a35a8e4e445f6827a1fc33e6c6 
  src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 

Diff: https://reviews.apache.org/r/44511/diff/


Testing
---

Add three sub tests for /weights endpoint registry in this patch:

1. Tests whether the weights replicated log is initialized with the `--weights` 
flag when bootstrapping the cluster.
2. Tests whether the weights replicated log can be updated with `/weights` 
endpoint.
3. Tests whether the `--weights` flag is ignored and use the registry value 
instead when Mesos master subsequently starts with `--weights` flag still 
specified.

./src/mesos-tests --gtest_filter=Strict/RegistrarTest.UpdateWeights/*
[==] Running 2 tests from 1 test case.
[--] Global test environment set-up.
[--] 2 tests from Strict/RegistrarTest
[ RUN  ] Strict/RegistrarTest.UpdateWeights/0
[   OK ] Strict/RegistrarTest.UpdateWeights/0 (103 ms)
[ RUN  ] Strict/RegistrarTest.UpdateWeights/1
[   OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms)
[--] 2 tests from Strict/RegistrarTest (171 ms total)

[--] Global test environment tear-down
[==] 2 tests from 1 test case ran. (178 ms total)
[  PASSED  ] 2 tests.


make && make check.


Thanks,

Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/#review124531
---



Bad patch!

Reviews applied: [44511, 41790, 44512, 43863, 41681]

Failed command: ./support/apply-review.sh -n -r 44511

Error:
2016-03-21 11:19:24 URL:https://reviews.apache.org/r/44511/diff/raw/ 
[11292/11292] -> "44511.patch" [1]
error: patch failed: src/tests/dynamic_weights_tests.cpp:459
error: src/tests/dynamic_weights_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12073/console

- Mesos ReviewBot


On March 14, 2016, 1:52 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44511/
> ---
> 
> (Updated March 14, 2016, 1:52 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4797
> https://issues.apache.org/jira/browse/MESOS-4797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add registry tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/dynamic_weights_tests.cpp 
> a95663f633f376954d4201b6cfbe693429be9c39 
>   src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 
> 
> Diff: https://reviews.apache.org/r/44511/diff/
> 
> 
> Testing
> ---
> 
> Add three sub tests for /weights endpoint registry in this patch:
> 
> 1. Tests whether the weights replicated log is initialized with the 
> `--weights` flag when bootstrapping the cluster.
> 2. Tests whether the weights replicated log can be updated with `/weights` 
> endpoint.
> 3. Tests whether the `--weights` flag is ignored and use the registry value 
> instead when Mesos master subsequently starts with `--weights` flag still 
> specified.
> 
> ./src/mesos-tests --gtest_filter=Strict/RegistrarTest.UpdateWeights/*
> [==] Running 2 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 2 tests from Strict/RegistrarTest
> [ RUN  ] Strict/RegistrarTest.UpdateWeights/0
> [   OK ] Strict/RegistrarTest.UpdateWeights/0 (103 ms)
> [ RUN  ] Strict/RegistrarTest.UpdateWeights/1
> [   OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms)
> [--] 2 tests from Strict/RegistrarTest (171 ms total)
> 
> [--] Global test environment tear-down
> [==] 2 tests from 1 test case ran. (178 ms total)
> [  PASSED  ] 2 tests.
> 
> 
> make && make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/#review124511
---



Need to get rid of the unnecessary stringify/atof translation, but I like the 
new low-level registry Operation test.


src/tests/registrar_tests.cpp (line 196)


s/string/const string&/
And this is a static function, not using any class "state". Better off just 
making it a free-standing test helper function, outside of the class.



src/tests/registrar_tests.cpp (lines 909 - 913)


No need to make these `const`, but if you do, you might as well make them 
const-refs.



src/tests/registrar_tests.cpp (lines 910 - 915)


I don't understand why you stringify your double weights, then parse them 
and call atof just to get it back to a double to store in WeightInfo.

Could you write a helper function that instead makes a `vector` 
from a `vector, vector` or maybe just a `WeightInfo 
createWeightInfo(string, double)`? Neither require stringify/atof


- Adam B


On March 14, 2016, 6:52 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44511/
> ---
> 
> (Updated March 14, 2016, 6:52 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4797
> https://issues.apache.org/jira/browse/MESOS-4797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add registry tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/dynamic_weights_tests.cpp 
> a95663f633f376954d4201b6cfbe693429be9c39 
>   src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 
> 
> Diff: https://reviews.apache.org/r/44511/diff/
> 
> 
> Testing
> ---
> 
> Add three sub tests for /weights endpoint registry in this patch:
> 
> 1. Tests whether the weights replicated log is initialized with the 
> `--weights` flag when bootstrapping the cluster.
> 2. Tests whether the weights replicated log can be updated with `/weights` 
> endpoint.
> 3. Tests whether the `--weights` flag is ignored and use the registry value 
> instead when Mesos master subsequently starts with `--weights` flag still 
> specified.
> 
> ./src/mesos-tests --gtest_filter=Strict/RegistrarTest.UpdateWeights/*
> [==] Running 2 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 2 tests from Strict/RegistrarTest
> [ RUN  ] Strict/RegistrarTest.UpdateWeights/0
> [   OK ] Strict/RegistrarTest.UpdateWeights/0 (103 ms)
> [ RUN  ] Strict/RegistrarTest.UpdateWeights/1
> [   OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms)
> [--] 2 tests from Strict/RegistrarTest (171 ms total)
> 
> [--] Global test environment tear-down
> [==] 2 tests from 1 test case ran. (178 ms total)
> [  PASSED  ] 2 tests.
> 
> 
> make && make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/
---

(Updated March 14, 2016, 1:51 p.m.)


Review request for mesos and Adam B.


Changes
---

Addressed comments of Adam.


Bugs: MESOS-4797
https://issues.apache.org/jira/browse/MESOS-4797


Repository: mesos


Description
---

Add registry tests for /weights endpoint.


Diffs (updated)
-

  src/tests/dynamic_weights_tests.cpp a95663f633f376954d4201b6cfbe693429be9c39 
  src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 

Diff: https://reviews.apache.org/r/44511/diff/


Testing
---

Add three sub tests for /weights endpoint registry in this patch:

1. Tests whether the weights replicated log is initialized with the `--weights` 
flag when bootstrapping the cluster.
2. Tests whether the weights replicated log can be updated with `/weights` 
endpoint.
3. Tests whether the `--weights` flag is ignored and use the registry value 
instead when Mesos master subsequently starts with `--weights` flag still 
specified.


make && make check.


Thanks,

Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/
---

(Updated March 14, 2016, 1:52 p.m.)


Review request for mesos and Adam B.


Bugs: MESOS-4797
https://issues.apache.org/jira/browse/MESOS-4797


Repository: mesos


Description
---

Add registry tests for /weights endpoint.


Diffs
-

  src/tests/dynamic_weights_tests.cpp a95663f633f376954d4201b6cfbe693429be9c39 
  src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 

Diff: https://reviews.apache.org/r/44511/diff/


Testing (updated)
---

Add three sub tests for /weights endpoint registry in this patch:

1. Tests whether the weights replicated log is initialized with the `--weights` 
flag when bootstrapping the cluster.
2. Tests whether the weights replicated log can be updated with `/weights` 
endpoint.
3. Tests whether the `--weights` flag is ignored and use the registry value 
instead when Mesos master subsequently starts with `--weights` flag still 
specified.

./src/mesos-tests --gtest_filter=Strict/RegistrarTest.UpdateWeights/*
[==] Running 2 tests from 1 test case.
[--] Global test environment set-up.
[--] 2 tests from Strict/RegistrarTest
[ RUN  ] Strict/RegistrarTest.UpdateWeights/0
[   OK ] Strict/RegistrarTest.UpdateWeights/0 (103 ms)
[ RUN  ] Strict/RegistrarTest.UpdateWeights/1
[   OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms)
[--] 2 tests from Strict/RegistrarTest (171 ms total)

[--] Global test environment tear-down
[==] 2 tests from 1 test case ran. (178 ms total)
[  PASSED  ] 2 tests.


make && make check.


Thanks,

Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/#review123381
---



I like the test you have here as a higher-level integration test. Could you 
also add lower-level unit tests for the UpdateWeights Operation, similar to the 
RegistrarTest.UpdateQuota test in `registrar_tests.cpp`?


src/tests/dynamic_weights_tests.cpp (line 207)


Fix indent



src/tests/dynamic_weights_tests.cpp (line 217)


Fix indent


- Adam B


On March 9, 2016, 2:03 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44511/
> ---
> 
> (Updated March 9, 2016, 2:03 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4797
> https://issues.apache.org/jira/browse/MESOS-4797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add registry tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44511/diff/
> 
> 
> Testing
> ---
> 
> Add three sub tests for /weights endpoint registry in this patch:
> 
> 1. Tests whether the weights replicated log is initialized with the 
> `--weights` flag when bootstrapping the cluster.
> 2. Tests whether the weights replicated log can be updated with `/weights` 
> endpoint.
> 3. Tests whether the `--weights` flag is ignored and use the registry value 
> instead when Mesos master subsequently starts with `--weights` flag still 
> specified.
> 
> 
> make && make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/#review122722
---



Patch looks great!

Reviews applied: [41681, 43863, 44512, 41790, 44511]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 9, 2016, 10:03 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44511/
> ---
> 
> (Updated March 9, 2016, 10:03 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4797
> https://issues.apache.org/jira/browse/MESOS-4797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add registry tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44511/diff/
> 
> 
> Testing
> ---
> 
> Add three sub tests for /weights endpoint registry in this patch:
> 
> 1. Tests whether the weights replicated log is initialized with the 
> `--weights` flag when bootstrapping the cluster.
> 2. Tests whether the weights replicated log can be updated with `/weights` 
> endpoint.
> 3. Tests whether the `--weights` flag is ignored and use the registry value 
> instead when Mesos master subsequently starts with `--weights` flag still 
> specified.
> 
> 
> make && make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/
---

(Updated March 9, 2016, 10:03 a.m.)


Review request for mesos and Adam B.


Changes
---

Addressed comments of Adam.


Bugs: MESOS-4797
https://issues.apache.org/jira/browse/MESOS-4797


Repository: mesos


Description
---

Add registry tests for /weights endpoint.


Diffs (updated)
-

  src/tests/dynamic_weights_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44511/diff/


Testing (updated)
---

Add three sub tests for /weights endpoint registry in this patch:

1. Tests whether the weights replicated log is initialized with the `--weights` 
flag when bootstrapping the cluster.
2. Tests whether the weights replicated log can be updated with `/weights` 
endpoint.
3. Tests whether the `--weights` flag is ignored and use the registry value 
instead when Mesos master subsequently starts with `--weights` flag still 
specified.


make && make check.


Thanks,

Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/#review122698
---



Can you please describe in your "Testing Done" section what the new/updated 
tests are?

- Adam B


On March 8, 2016, 10:34 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44511/
> ---
> 
> (Updated March 8, 2016, 10:34 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4797
> https://issues.apache.org/jira/browse/MESOS-4797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add registry tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44511/diff/
> 
> 
> Testing
> ---
> 
> make && make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/
---

(Updated March 9, 2016, 6:34 a.m.)


Review request for mesos and Adam B.


Changes
---

Check with the /weights GET method.


Bugs: MESOS-4797
https://issues.apache.org/jira/browse/MESOS-4797


Repository: mesos


Description
---

Add registry tests for /weights endpoint.


Diffs (updated)
-

  src/tests/dynamic_weights_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44511/diff/


Testing
---

make && make check.


Thanks,

Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44511/#review122528
---



Patch looks great!

Reviews applied: [41681, 43863, 41790, 44511]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 8, 2016, 1:58 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44511/
> ---
> 
> (Updated March 8, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4797
> https://issues.apache.org/jira/browse/MESOS-4797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add registry tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44511/diff/
> 
> 
> Testing
> ---
> 
> make && make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>