Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133891
---


Fix it, then Ship it!




Thanks a lot, Zhitao! I'll push it shortly.


CHANGELOG (line 59)


Strictly speaking, ACLs are only for local authorizer, hence it's more 
inportant to say we deprecate actions. I'll rephrase.



CHANGELOG (line 60)


Please wrap.



docs/authorization.md (line 129)


"Updating" is a bit misleading. We want to reference all three actions: 
set, remove, and update. Let's say "Modifying".



docs/authorization.md (line 130)


Not yours, but let's s/Roles/Resource roles/ for consistency.



docs/authorization.md (line 525)


s/retrive/query.



docs/authorization.md (line 555)


s/principals/principal. Here and above



docs/quota.md (line 159)


s/retrieve/query



docs/quota.md (line 189)


s/information/information

We wrap at 80 chars for readability and diff'ability



docs/upgrades.md (line 169)


I'll do minor tweaks here.


- Alexander Rukletsov


On May 19, 2016, 4:34 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 19, 2016, 4:34 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
>   docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133881
---



Patch looks great!

Reviews applied: [47400]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 19, 2016, 4:34 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 19, 2016, 4:34 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
>   docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/
---

(Updated May 19, 2016, 4:34 a.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Changes
---

Review comments from Guangya.


Bugs: MESOS-5155 and MESOS-5336
https://issues.apache.org/jira/browse/MESOS-5155
https://issues.apache.org/jira/browse/MESOS-5336


Repository: mesos


Description
---

Documentation quota authorization changes in 0.29.


Diffs (updated)
-

  CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
  docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e 
  docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
  docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 

Diff: https://reviews.apache.org/r/47400/diff/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Zhitao Li]

> On May 19, 2016, 3:25 a.m., Guangya Liu wrote:
> > CHANGELOG, line 59
> > 
> >
> > s/set_quotas/`set_quotas`
> > s/remove_quotas/`remove_quotas`
> > 
> > s/in/in favor
> > 
> > Do we need to mention `get_quotas` here?

I don't think we need to mention get_quotas.


> On May 19, 2016, 3:25 a.m., Guangya Liu wrote:
> > CHANGELOG, line 61
> > 
> >
> > I think ` This is applicable to both local authorizer as well as any 
> > custom authorizer module.` can be removed.
> > 
> > The CHANGELOG only need to clarify the update

Hmm, I'd like to explicitly call it out, unless you see harm here.


> On May 19, 2016, 3:25 a.m., Guangya Liu wrote:
> > docs/upgrades.md, line 175
> > 
> >
> > Why moving this part to quota section?

I'm keeping all bulletpoints with an anchor before ones without.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133865
---


On May 18, 2016, 4:53 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 18, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
>   docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133865
---




CHANGELOG (line 59)


s/set_quotas/`set_quotas`
s/remove_quotas/`remove_quotas`

s/in/in favor

Do we need to mention `get_quotas` here?



CHANGELOG (line 60)


s/update_quotas/`update_quotas`



CHANGELOG (line 61)


I think ` This is applicable to both local authorizer as well as any custom 
authorizer module.` can be removed.

The CHANGELOG only need to clarify the update



docs/authorization.md (lines 128 - 129)


Can you please link the `quota` keyword to quota document?



docs/authorization.md (line 524)


blank line above



docs/authorization.md (line 551)


blank line above



docs/upgrades.md (line 175)


Does this belong to your patch? Why copy here?



docs/upgrades.md (line 175)


Why moving this part to quota section?


- Guangya Liu


On May 18, 2016, 4:53 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 18, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
>   docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133802
---



Patch looks great!

Reviews applied: [47400]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 18, 2016, 4:53 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 18, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
>   docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/
---

(Updated May 18, 2016, 4:53 p.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Changes
---

Rebase and review comments.


Bugs: MESOS-5155 and MESOS-5336
https://issues.apache.org/jira/browse/MESOS-5155
https://issues.apache.org/jira/browse/MESOS-5336


Repository: mesos


Description
---

Documentation quota authorization changes in 0.29.


Diffs (updated)
-

  CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
  docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e 
  docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
  docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 

Diff: https://reviews.apache.org/r/47400/diff/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133720
---



I've committed https://reviews.apache.org/r/46501/ , could you please update 
this review?

- Alexander Rukletsov


On May 17, 2016, 7:15 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 17, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 825366d771f3b1bf26cec2ec1cb87619e82f9c8f 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133659
---



Bad patch!

Reviews applied: [47400, 47399]

Failed command: ./support/apply-review.sh -n -r 47400

Error:
2016-05-17 23:28:43 URL:https://reviews.apache.org/r/47400/diff/raw/ 
[9744/9744] -> "47400.patch" [1]
error: patch failed: docs/upgrades.md:162
error: docs/upgrades.md: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13133/console

- Mesos ReviewBot


On May 17, 2016, 7:15 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 17, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 825366d771f3b1bf26cec2ec1cb87619e82f9c8f 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133622
---



Looks good to me. I'll commit https://reviews.apache.org/r/46501/ first 
(tomorrow), will ask you to rebase this and do a final pass afterwards. Thanks 
for the great job!


docs/authorization.md (line 359)


s/retrive/query x2
s/retrieve/query



docs/quota.md (line 159)


s/retrieve/query



docs/quota.md (line 189)


s/retrieve/query



docs/upgrades.md (line 169)


Let's mention `UPDATE_QUOTA_WITH_ROLE` as a substitute for deprecated 
actions. Also, please mentions authz actions first and ACLs second, since the 
latter are only for local authorizer.


- Alexander Rukletsov


On May 17, 2016, 7:15 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 17, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 825366d771f3b1bf26cec2ec1cb87619e82f9c8f 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/
---

(Updated May 17, 2016, 7:15 p.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Changes
---

Rebase, changelog, and review comments.


Bugs: MESOS-5155 and MESOS-5336
https://issues.apache.org/jira/browse/MESOS-5155
https://issues.apache.org/jira/browse/MESOS-5336


Repository: mesos


Description
---

Documentation quota authorization changes in 0.29.


Diffs (updated)
-

  CHANGELOG 825366d771f3b1bf26cec2ec1cb87619e82f9c8f 
  docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
  docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
  docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 

Diff: https://reviews.apache.org/r/47400/diff/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133579
---



Please be advised that if https://reviews.apache.org/r/46501/ lands before, 
you'll have to rebase this patch on top.


docs/authorization.md (line 13)


s/to see and change quotas/to query status and modify quotas ?



docs/authorization.md (lines 35 - 36)


Move these two after volumes before weights, please.



docs/authorization.md (line 359)


We don't support update yet and won't land it in 0.29 ; ). Please leave set 
and remove for now.



docs/authorization.md 


Do you want to write a section about get_quotas instead?



docs/quota.md (line 159)


s/which the principal is authorized to get/which principal is authorized to 
query status (if authorization is enabled)



docs/quota.md (line 188)


Notes are styled like this:
```
> NOTE: Start with a capital letter
```

s/see/query
s/quota info/quota information



docs/upgrades.md (line 169)


Thanks a lot for updating this! Please update the deprecations section in 
the changelog as well.

Also, please write down that SET_QUOTA_WITH_ROLE and 
DESTROY_QUOTA_WITH_PRINCIPAL actions are deprecated as well. This is even more 
important since they affect all authorizers, not just the local one.

Some minor comments:
s/modify/update (let's stick to one terminology; we use modify for all 3 
actions)



docs/upgrades.md (line 173)


s/retrieve/query status (for consistency in terminology)


- Alexander Rukletsov


On May 15, 2016, 5:43 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 15, 2016, 5:43 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133303
---



Patch looks great!

Reviews applied: [47274, 47399, 47400]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 15, 2016, 5:43 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 15, 2016, 5:43 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>