Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

[Joseph Wu]

> On May 25, 2016, 6:25 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 150-152
> > 
> >
> > Is this change absolutely necessary for the ticket?
> 
> Jie Yu wrote:
> Oh, i see that being useful in the following patch.
> 
> Jie Yu wrote:
> In fact, i still prefer iterating all the flags in the callers, just to 
> be more explicit. It's not clear to me here what toVector means by just 
> looking at the name.

Ok, I can drop this patch and the previous one 
(https://reviews.apache.org/r/47213/).  

And then modify the following patch (https://reviews.apache.org/r/47215/) to 
explicitly enumerate the flags.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47214/#review134892
---


On May 16, 2016, 11:01 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47214/
> ---
> 
> (Updated May 16, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44073146118b6c6e9e730b8c901852594080a3eb 
> 
> Diff: https://reviews.apache.org/r/47214/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

[Jie Yu]

> On May 26, 2016, 1:25 a.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 150-152
> > 
> >
> > Is this change absolutely necessary for the ticket?
> 
> Jie Yu wrote:
> Oh, i see that being useful in the following patch.

In fact, i still prefer iterating all the flags in the callers, just to be more 
explicit. It's not clear to me here what toVector means by just looking at the 
name.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47214/#review134892
---


On May 16, 2016, 6:01 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47214/
> ---
> 
> (Updated May 16, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44073146118b6c6e9e730b8c901852594080a3eb 
> 
> Diff: https://reviews.apache.org/r/47214/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

[Jie Yu]

> On May 26, 2016, 1:25 a.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 150-152
> > 
> >
> > Is this change absolutely necessary for the ticket?

Oh, i see that being useful in the following patch.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47214/#review134892
---


On May 16, 2016, 6:01 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47214/
> ---
> 
> (Updated May 16, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44073146118b6c6e9e730b8c901852594080a3eb 
> 
> Diff: https://reviews.apache.org/r/47214/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47214/#review134892
---




3rdparty/libprocess/src/subprocess.cpp (lines 150 - 152)


Is this change absolutely necessary for the ticket?


- Jie Yu


On May 16, 2016, 6:01 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47214/
> ---
> 
> (Updated May 16, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44073146118b6c6e9e730b8c901852594080a3eb 
> 
> Diff: https://reviews.apache.org/r/47214/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47214/#review134503
---


Ship it!




Ship It!

- Kapil Arya


On May 16, 2016, 2:01 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47214/
> ---
> 
> (Updated May 16, 2016, 2:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44073146118b6c6e9e730b8c901852594080a3eb 
> 
> Diff: https://reviews.apache.org/r/47214/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47214/
---

(Updated May 16, 2016, 11:01 a.m.)


Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.


Changes
---

Rebase on the flag alias change.


Bugs: MESOS-5350
https://issues.apache.org/jira/browse/MESOS-5350


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/src/subprocess.cpp 
44073146118b6c6e9e730b8c901852594080a3eb 

Diff: https://reviews.apache.org/r/47214/diff/


Testing
---

make check


Thanks,

Joseph Wu

Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47214/
---

Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.


Bugs: MESOS-5350
https://issues.apache.org/jira/browse/MESOS-5350


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 

Diff: https://reviews.apache.org/r/47214/diff/


Testing
---

make check


Thanks,

Joseph Wu