Re: Review Request 66408: Updated CSI helpers for v0.2.

2018-04-12 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66408/
---

(Updated April 12, 2018, 6:54 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed Jie's comment.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
---

This patch adds new helper classes for CSI plugin and node capabilities,
removed helpers for the removed csi.Version proto message, and makes
the VolumeState proto message uses csi::v0::VolumeCapability.

NOTE: This is not future-proof if there is a breaking change in
VolumeCapability, we might need to change VolumeState to support
multiple CSI versions in the future.


Diffs (updated)
-

  src/csi/state.hpp dcbc7aba84e0e66dd0e6caf7a64fb95aae69de0a 
  src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 
  src/csi/utils.hpp 58b071d4f1512e4cf10d077bd1e03e66626f6dff 
  src/csi/utils.cpp 9e0435762a16f2995bc5a04ec342af6ea231054a 


Diff: https://reviews.apache.org/r/66408/diff/3/

Changes: https://reviews.apache.org/r/66408/diff/2-3/


Testing
---

This patch cannot be compiled standalone. Tests done later in the chain.


Thanks,

Chun-Hung Hsiao

Re: Review Request 66408: Updated CSI helpers for v0.2.

2018-04-12 Thread Chun-Hung Hsiao 


> On April 12, 2018, 5:47 p.m., Jie Yu wrote:
> > src/csi/state.proto
> > Line 45 (original), 45 (patched)
> > 
> >
> > Please s/VolumeInfo/Volume/ here
> > 
> > ALso, a git grep shows some other references to VolumeInfo:
> > ```
> > Jies-MacBook-Pro:mesos jie$ git grep VolumeInfo
> > src/csi/state.proto:  // match the attributes of the `VolumeInfo` 
> > returned by
> > src/examples/test_csi_plugin.cpp:csi::VolumeInfo* info = 
> > response->add_entries()->mutable_volume_info();
> > src/resource_provider/storage/provider.cpp:  const 
> > csi::VolumeInfo& volumeInfo = response.volume_info();
> > src/tests/master_validation_tests.cpp:TEST_F(ResourceValidationTest, 
> > PersistentVolumeWithoutVolumeInfo)
> > ```

Will fix this comment. The `VolumeInfo` in the other files are fixed down in 
the chain.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66408/#review201024
---


On April 4, 2018, 3:59 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66408/
> ---
> 
> (Updated April 4, 2018, 3:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8717
> https://issues.apache.org/jira/browse/MESOS-8717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds new helper classes for CSI plugin and node capabilities,
> removed helpers for the removed csi.Version proto message, and makes
> the VolumeState proto message uses csi::v0::VolumeCapability.
> 
> NOTE: This is not future-proof if there is a breaking change in
> VolumeCapability, we might need to change VolumeState to support
> multiple CSI versions in the future.
> 
> 
> Diffs
> -
> 
>   src/csi/state.hpp dcbc7aba84e0e66dd0e6caf7a64fb95aae69de0a 
>   src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 
>   src/csi/utils.hpp 58b071d4f1512e4cf10d077bd1e03e66626f6dff 
>   src/csi/utils.cpp 9e0435762a16f2995bc5a04ec342af6ea231054a 
> 
> 
> Diff: https://reviews.apache.org/r/66408/diff/2/
> 
> 
> Testing
> ---
> 
> This patch cannot be compiled standalone. Tests done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 66408: Updated CSI helpers for v0.2.

2018-04-12 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66408/#review201024
---




src/csi/state.proto
Line 45 (original), 45 (patched)


Please s/VolumeInfo/Volume/ here

ALso, a git grep shows some other references to VolumeInfo:
```
Jies-MacBook-Pro:mesos jie$ git grep VolumeInfo
src/csi/state.proto:  // match the attributes of the `VolumeInfo` returned 
by
src/examples/test_csi_plugin.cpp:csi::VolumeInfo* info = 
response->add_entries()->mutable_volume_info();
src/resource_provider/storage/provider.cpp:  const csi::VolumeInfo& 
volumeInfo = response.volume_info();
src/tests/master_validation_tests.cpp:TEST_F(ResourceValidationTest, 
PersistentVolumeWithoutVolumeInfo)
```


- Jie Yu


On April 4, 2018, 3:59 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66408/
> ---
> 
> (Updated April 4, 2018, 3:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8717
> https://issues.apache.org/jira/browse/MESOS-8717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds new helper classes for CSI plugin and node capabilities,
> removed helpers for the removed csi.Version proto message, and makes
> the VolumeState proto message uses csi::v0::VolumeCapability.
> 
> NOTE: This is not future-proof if there is a breaking change in
> VolumeCapability, we might need to change VolumeState to support
> multiple CSI versions in the future.
> 
> 
> Diffs
> -
> 
>   src/csi/state.hpp dcbc7aba84e0e66dd0e6caf7a64fb95aae69de0a 
>   src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 
>   src/csi/utils.hpp 58b071d4f1512e4cf10d077bd1e03e66626f6dff 
>   src/csi/utils.cpp 9e0435762a16f2995bc5a04ec342af6ea231054a 
> 
> 
> Diff: https://reviews.apache.org/r/66408/diff/2/
> 
> 
> Testing
> ---
> 
> This patch cannot be compiled standalone. Tests done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 66408: Updated CSI helpers for v0.2.

2018-04-12 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66408/#review201015
---


Ship it!




Ship It!

- Jie Yu


On April 4, 2018, 3:59 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66408/
> ---
> 
> (Updated April 4, 2018, 3:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8717
> https://issues.apache.org/jira/browse/MESOS-8717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds new helper classes for CSI plugin and node capabilities,
> removed helpers for the removed csi.Version proto message, and makes
> the VolumeState proto message uses csi::v0::VolumeCapability.
> 
> NOTE: This is not future-proof if there is a breaking change in
> VolumeCapability, we might need to change VolumeState to support
> multiple CSI versions in the future.
> 
> 
> Diffs
> -
> 
>   src/csi/state.hpp dcbc7aba84e0e66dd0e6caf7a64fb95aae69de0a 
>   src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 
>   src/csi/utils.hpp 58b071d4f1512e4cf10d077bd1e03e66626f6dff 
>   src/csi/utils.cpp 9e0435762a16f2995bc5a04ec342af6ea231054a 
> 
> 
> Diff: https://reviews.apache.org/r/66408/diff/2/
> 
> 
> Testing
> ---
> 
> This patch cannot be compiled standalone. Tests done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 66408: Updated CSI helpers for v0.2.

2018-04-03 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66408/
---

(Updated April 4, 2018, 3:59 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description (updated)
---

This patch adds new helper classes for CSI plugin and node capabilities,
removed helpers for the removed csi.Version proto message, and makes
the VolumeState proto message uses csi::v0::VolumeCapability.

NOTE: This is not future-proof if there is a breaking change in
VolumeCapability, we might need to change VolumeState to support
multiple CSI versions in the future.


Diffs (updated)
-

  src/csi/state.hpp dcbc7aba84e0e66dd0e6caf7a64fb95aae69de0a 
  src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 
  src/csi/utils.hpp 58b071d4f1512e4cf10d077bd1e03e66626f6dff 
  src/csi/utils.cpp 9e0435762a16f2995bc5a04ec342af6ea231054a 


Diff: https://reviews.apache.org/r/66408/diff/2/

Changes: https://reviews.apache.org/r/66408/diff/1-2/


Testing
---

This patch cannot be compiled standalone. Tests done later in the chain.


Thanks,

Chun-Hung Hsiao

Review Request 66408: Updated CSI helpers for v0.2.

2018-04-03 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66408/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
---

This patch adds new helper classes for CSI plugin and node capabilities,
and removed helpers for the removed `csi.Version` proto message.


Diffs
-

  src/csi/utils.hpp 58b071d4f1512e4cf10d077bd1e03e66626f6dff 
  src/csi/utils.cpp 9e0435762a16f2995bc5a04ec342af6ea231054a 


Diff: https://reviews.apache.org/r/66408/diff/1/


Testing
---

This patch cannot be compiled standalone. Tests done later in the chain.


Thanks,

Chun-Hung Hsiao