Re: CVS commit: src/sys/ufs/ext2fs
On Tue, Feb 24, 2015 at 2:08 AM, Maxime Villard wrote: > Le 23/02/2015 14:51, Ryota Ozaki a écrit : >> Hi, >> >> On Sun, Feb 22, 2015 at 11:55 PM, Maxime Villard wrote: >>> Module Name:src >>> Committed By: maxv >>> Date: Sun Feb 22 14:55:23 UTC 2015 >>> >>> Modified Files: >>> src/sys/ufs/ext2fs: ext2fs_vfsops.c >>> >>> Log Message: >>> Merge _sbcompute() and _sbcheck() into _sbfill(). >>> >>> In ext2fs_sbfill(), check more fields of the superblock, to prevent >>> several kernel panics when mounting/unmounting a disk. >> >> This change seems to break ATF tests. >> http://releng.netbsd.org/b5reports/amd64/commits-2015.02.html#end >> >> Could you check what happens? >> > > Ok, I've switched back to more "simple" checks. > > I tested my changes with a Linux-formatted disk, and fuzzed several > times some fields. It did work. > > Thanks for pointing this out. http://releng.netbsd.org/b5reports/i386/commits-2015.02.html#end The tests recovered :) Thank you for the fix! ozaki-r
Re: CVS commit: src/sys/dev/pci
2015-02-24 0:25 GMT+09:00 Christos Zoulas : > Please revert the fix then, or check the coverity website for the > explanation why it thinks that the index can be 15. It does not > seem possible from my cursory examination and we don't sandbag the > code against impossible errors. It is probably a coverity false > positive. I've revert this change. I don't know how to look the full coverity report. Would you mind to teach me? Regards, -- NONAKA Kimihiro
Re: CVS commit: src/sys/ufs/ext2fs
Le 23/02/2015 14:51, Ryota Ozaki a écrit : > Hi, > > On Sun, Feb 22, 2015 at 11:55 PM, Maxime Villard wrote: >> Module Name:src >> Committed By: maxv >> Date: Sun Feb 22 14:55:23 UTC 2015 >> >> Modified Files: >> src/sys/ufs/ext2fs: ext2fs_vfsops.c >> >> Log Message: >> Merge _sbcompute() and _sbcheck() into _sbfill(). >> >> In ext2fs_sbfill(), check more fields of the superblock, to prevent >> several kernel panics when mounting/unmounting a disk. > > This change seems to break ATF tests. > http://releng.netbsd.org/b5reports/amd64/commits-2015.02.html#end > > Could you check what happens? > Ok, I've switched back to more "simple" checks. I tested my changes with a Linux-formatted disk, and fuzzed several times some fields. It did work. Thanks for pointing this out. > ozaki-r > >> >> >> To generate a diff of this commit: >> cvs rdiff -u -r1.188 -r1.189 src/sys/ufs/ext2fs/ext2fs_vfsops.c >> >> Please note that diffs are not public domain; they are subject to the >> copyright notices on the relevant files. >> >
Re: CVS commit: src/sys/dev/pci
On Feb 23, 11:13pm, nona...@gmail.com (NONAKA Kimihiro) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | I have not seen it. | At the moment, I don't think the problem happen. Please revert the fix then, or check the coverity website for the explanation why it thinks that the index can be 15. It does not seem possible from my cursory examination and we don't sandbag the code against impossible errors. It is probably a coverity false positive. christos
Re: CVS commit: src/sys/dev/pci
I have not seen it. At the moment, I don't think the problem happen. 2015-02-23 22:21 GMT+09:00 Christos Zoulas : > In article <20150223130937.ddec...@cvs.netbsd.org>, > NONAKA Kimihiro wrote: >>-=-=-=-=-=- >> >>Module Name: src >>Committed By: nonaka >>Date: Mon Feb 23 13:09:37 UTC 2015 >> >>Modified Files: >> src/sys/dev/pci: if_iwm.c >> >>Log Message: >>CID 1271021: Overrunning array "in->in_ridx" of 15 bytes at byte offset >>15 using index "i" (which evaluates to 15). >> >>http://mail-index.netbsd.org/coverity-updates/2015/02/21/msg000115.html > > Did you look at the full coverity report? I don't understand how this > can happen? > > christos >
Re: CVS commit: src/sys/ufs/ext2fs
Hi, On Sun, Feb 22, 2015 at 11:55 PM, Maxime Villard wrote: > Module Name:src > Committed By: maxv > Date: Sun Feb 22 14:55:23 UTC 2015 > > Modified Files: > src/sys/ufs/ext2fs: ext2fs_vfsops.c > > Log Message: > Merge _sbcompute() and _sbcheck() into _sbfill(). > > In ext2fs_sbfill(), check more fields of the superblock, to prevent > several kernel panics when mounting/unmounting a disk. This change seems to break ATF tests. http://releng.netbsd.org/b5reports/amd64/commits-2015.02.html#end Could you check what happens? ozaki-r > > > To generate a diff of this commit: > cvs rdiff -u -r1.188 -r1.189 src/sys/ufs/ext2fs/ext2fs_vfsops.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. >
Re: CVS commit: src/sys/dev/pci
In article <20150223130937.ddec...@cvs.netbsd.org>, NONAKA Kimihiro wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: nonaka >Date: Mon Feb 23 13:09:37 UTC 2015 > >Modified Files: > src/sys/dev/pci: if_iwm.c > >Log Message: >CID 1271021: Overrunning array "in->in_ridx" of 15 bytes at byte offset >15 using index "i" (which evaluates to 15). > >http://mail-index.netbsd.org/coverity-updates/2015/02/21/msg000115.html Did you look at the full coverity report? I don't understand how this can happen? christos
