Re: [Spacewalk-devel] kickstartTreeHandler

2008-12-12 Thread Mike McCune

Jesus M. Rodriguez wrote:

It's the right thing to do. /me hates having wordy method names when the
namespaces should be enough. Good job.

On Thu, Dec 11, 2008 at 10:33 PM, Partha Aji p...@redhat.com wrote:

Thanks zeus :) .. I had the right intentions but I wonder if I was being a
bit naive here.. Hopefully qa automation tests that were written for this
are easy enough to change ,... If thats too much to change feel free to
revert

Partha


this handler is new in 0.4 so I doubt anything has been written for that 
API yet...


As long as you left the old one alone in KickstartHandler, we should be 
fine.


Mike

--
Mike McCune
mmccune AT redhat.com
Engineering   | Portland, OR
RHN Satellite | 650.567.9039x79248

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] kickstartTreeHandler

2008-12-12 Thread Partha Aji

Yeah I realized it was new in sw 0.4 ...  Thats why I changed it :) ...

Partha

Mike McCune wrote:

Jesus M. Rodriguez wrote:

It's the right thing to do. /me hates having wordy method names when the
namespaces should be enough. Good job.

On Thu, Dec 11, 2008 at 10:33 PM, Partha Aji p...@redhat.com wrote:
Thanks zeus :) .. I had the right intentions but I wonder if I was 
being a
bit naive here.. Hopefully qa automation tests that were written for 
this

are easy enough to change ,... If thats too much to change feel free to
revert

Partha


this handler is new in 0.4 so I doubt anything has been written for that 
API yet...


As long as you left the old one alone in KickstartHandler, we should be 
fine.


Mike



___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel