[SSSD] [sssd PR#943][comment] files_ops: Fix cached password remove

2019-12-04 Thread alexey-tikhonov
  URL: https://github.com/SSSD/sssd/pull/943
Title: #943: files_ops: Fix cached password remove

alexey-tikhonov commented:
"""
Hi @elkoniu,

Thank you for your patch.

Please see comments inline.

In regards of `sysdb_delete_recursive_with_filter()` those are mostly nitpicks. 
There is only one [real 
concern](https://github.com/SSSD/sssd/pull/943#discussion_r353933715).

Changes of `files_ops.c` have some more serious issues.

But ultimately my fundamental concerns are as following:
1) files_provider's implementation is already very suboptimal. This patch 
doubles reading of db files (`enum_files_*()`) thus making it slower. Of 
course, most probably reading files is not a bottleneck (I guess updating sysdb 
is). Still I think this could (and better) be avoided even within current 
approach.
2) What happens if, for example, `uid` of a user was modified? Do we really 
want to keep password hash (and other custom attributes, if any) in this case? 
Or do we want to keep custom attributes of unchanged entries only? I am not 
sure. I would like to have this explained explicitly.

In general, from my point of view, proper approach would be to calculate and 
apply diff only, instead of full sysdb rebuild. This also would be beneficial 
from performance point of view. But this probably is not best candidate for a 
one of the very first PRs...
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/943#issuecomment-561885990
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#905][comment] Don't ignore host entries in Group Policy security filters

2019-12-04 Thread dmulder
  URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters

dmulder commented:
"""
Thanks for reviewing! I've fixed the issues you commented on, as well as one of 
my own. I noticed that the sssd-ad man page still contained a comment 
explaining that host entries in the Security Filter were not supported, so I 
removed that statement.

> The last commit contains few `FIXMEs`. Can you address them as well? Or what 
> are the consequences if they are not addressed?
> 
The FIXME in sysdb_set_computer would be an enhancement, but is not required 
for this to function.
The FIXME in ad_gpo_get_host_sid_retrieval_done is trivial, and not necessary.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/905#issuecomment-561767891
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#905][comment] Don't ignore host entries in Group Policy security filters

2019-12-04 Thread dmulder
  URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters

dmulder commented:
"""
@pbrezina Thanks for reviewing! I've fixed the issues you commented on, as well 
as one of my own. I noticed that the sssd-ad man page still contained a comment 
explaining that host entries in the Security Filter were not supported, so I 
removed that statement.

> The last commit contains few `FIXMEs`. Can you address them as well? Or what 
> are the consequences if they are not addressed?
> 
The FIXME in sysdb_set_computer would be an enhancement, but is not required 
for this to function.
The FIXME in ad_gpo_get_host_sid_retrieval_done is trivial, and not necessary.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/905#issuecomment-561767891
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#905][synchronized] Don't ignore host entries in Group Policy security filters

2019-12-04 Thread dmulder
   URL: https://github.com/SSSD/sssd/pull/905
Author: dmulder
 Title: #905: Don't ignore host entries in Group Policy security filters
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/905/head:pr905
git checkout pr905
From e01732c37ac8478a84228ec8894b78a39334955f Mon Sep 17 00:00:00 2001
From: David Mulder 
Date: Fri, 4 Oct 2019 13:04:01 -0600
Subject: [PATCH 1/4] SSSD should accept host entries from GPO's security
 filter

Not accepting host entries in the security filter
creates the need for sub-OU's, each with its own
GPO, otherwise one OU with an assigned GPO would
be sufficient.
---
 Makefile.am   |   2 +
 src/db/sysdb_computer.c   | 165 +
 src/db/sysdb_computer.h   |  49 +
 src/providers/ad/ad_gpo.c | 189 --
 src/providers/ad/ad_gpo_ndr.c |   2 +-
 5 files changed, 397 insertions(+), 10 deletions(-)
 create mode 100644 src/db/sysdb_computer.c
 create mode 100644 src/db/sysdb_computer.h

diff --git a/Makefile.am b/Makefile.am
index f6ae4f8de3..66319f29f1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -781,6 +781,7 @@ dist_noinst_HEADERS = \
 src/db/sysdb_services.h \
 src/db/sysdb_ssh.h \
 src/db/sysdb_domain_resolution_order.h \
+src/db/sysdb_computer.h \
 src/confdb/confdb.h \
 src/confdb/confdb_private.h \
 src/confdb/confdb_setup.h \
@@ -1245,6 +1246,7 @@ libsss_util_la_SOURCES = \
 src/db/sysdb_certmap.c \
 src/db/sysdb_domain_resolution_order.c \
 src/util/sss_pam_data.c \
+src/db/sysdb_computer.c \
 src/util/util.c \
 src/util/util_ext.c \
 src/util/util_preauth.c \
diff --git a/src/db/sysdb_computer.c b/src/db/sysdb_computer.c
new file mode 100644
index 00..dc8f33faa2
--- /dev/null
+++ b/src/db/sysdb_computer.c
@@ -0,0 +1,165 @@
+/*
+SSSD
+
+Authors:
+Samuel Cabrero 
+David Mulder 
+
+Copyright (C) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see .
+*/
+
+#include 
+
+#include "db/sysdb.h"
+#include "db/sysdb_private.h"
+#include "db/sysdb_computer.h"
+
+static errno_t
+sysdb_search_computer(TALLOC_CTX *mem_ctx,
+  struct sss_domain_info *domain,
+  const char *filter,
+  const char **attrs,
+  size_t *_num_hosts,
+  struct ldb_message ***_hosts)
+{
+errno_t ret;
+TALLOC_CTX *tmp_ctx;
+struct ldb_message **results;
+size_t num_results;
+struct ldb_dn *dn;
+
+tmp_ctx = talloc_new(NULL);
+if (!tmp_ctx) {
+return ENOMEM;
+}
+
+ret = sysdb_search_custom(tmp_ctx, domain, filter,
+  COMPUTERS_SUBDIR, attrs,
+  _results, );
+if (ret != EOK && ret != ENOENT) {
+DEBUG(SSSDBG_CRIT_FAILURE,
+  "Error looking up host [%d]: %s\n",
+   ret, strerror(ret));
+goto done;
+} else if (ret == ENOENT) {
+DEBUG(SSSDBG_TRACE_FUNC, "No such host\n");
+*_hosts = NULL;
+*_num_hosts = 0;
+goto done;
+}
+
+*_hosts = talloc_steal(mem_ctx, results);
+*_num_hosts = num_results;
+ret = EOK;
+
+done:
+talloc_free(tmp_ctx);
+
+return ret;
+}
+
+int
+sysdb_get_computer(TALLOC_CTX *mem_ctx,
+   struct sss_domain_info *domain,
+   const char *computer_name,
+   const char **attrs,
+   struct ldb_message **_computer)
+{
+TALLOC_CTX *tmp_ctx;
+errno_t ret;
+const char *filter;
+struct ldb_message **hosts;
+size_t num_hosts;
+
+tmp_ctx = talloc_new(NULL);
+if (!tmp_ctx) {
+return ENOMEM;
+}
+
+filter = talloc_asprintf(tmp_ctx, SYSDB_COMP_FILTER, computer_name);
+if (!filter) {
+ret = ENOMEM;
+goto done;
+}
+
+ret = sysdb_search_computer(tmp_ctx, domain, filter, attrs,
+_hosts, );
+if (ret != EOK) {
+goto done;
+}
+
+if (num_hosts != 1) {
+ret = EINVAL;
+DEBUG(SSSDBG_CRIT_FAILURE,
+  "Did not find a single host with name %s\n", computer_name);
+goto done;
+}
+
+*_computer = talloc_steal(mem_ctx, 

[SSSD] [sssd PR#947][comment] tests: fix race conditions in integration tests

2019-12-04 Thread alexey-tikhonov
  URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests

alexey-tikhonov commented:
"""
> about the race between adding e.g. the user to /etc/passwd and getting 
> inotify processed.
> 
> Isn't this similar to why calling `sss_cache` was added `useradd` and other 
> utilities from the shadow-utils package? Have you tried if instead of 
> increasing the delay calling `sss_cache -E` would work as well?

If I understand correctly `sss_cache` will reset mem-cache and re-write 
timestamps in sysdb cache but that's not enough because files_provider ignores 
timestamps in sysdb cache. So if inotify event have not been processed yet then 
files_provider still will return stale data from sysdb cache. I wrote [about 
it](https://bugzilla.redhat.com/show_bug.cgi?id=1693379#c6) (item 2) )

> I think whenever a cache is added in between this use case can only be 
> covered if the cache is explicitly invalidated after adding the new line

This is true in the limits of current design of files_provider.

But the problem is there are no "ready" means to invalidate sysdb cache for 
files_provider as it ignores timestamp (again, if I understand correctly)

To this extent I agree with @pbrezina that if case is expected to test current 
design then `sleep` is ok.

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/947#issuecomment-561645860
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#947][comment] tests: fix race conditions in integration tests

2019-12-04 Thread sumit-bose
  URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests

sumit-bose commented:
"""
Hi,

about the race between adding e.g. the user to /etc/passwd and getting inotify 
processed.

Isn't this similar to why calling `sss_cache` was added `useradd` and other 
utilities from the shadow-utils package? Have you tried if instead of 
increasing the delay calling `sss_cache -E` would work as well?

If I see it correctly the test just adds a new line to /etc/passwd and then 
tries to lookup the freshly added user. I think whenever a cache is added in 
between this use case can only be covered if the cache is explicitly 
invalidated after adding the new line (shadow-utils is also calling `nscd -i 
...` is `nscd` is used). Using inotify helps if invalidating the cache was 
forgotten but it is only best effort.

bye,
Sumit
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/947#issuecomment-561611980
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#953][-Accepted] sysdb_sudo: Enable LDAP time format compatibility

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/953
Title: #953: sysdb_sudo: Enable LDAP time format compatibility

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#953][closed] sysdb_sudo: Enable LDAP time format compatibility

2019-12-04 Thread pbrezina
   URL: https://github.com/SSSD/sssd/pull/953
Author: elkoniu
 Title: #953: sysdb_sudo: Enable LDAP time format compatibility
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/953/head:pr953
git checkout pr953
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#953][-Ready to push] sysdb_sudo: Enable LDAP time format compatibility

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/953
Title: #953: sysdb_sudo: Enable LDAP time format compatibility

Label: -Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#953][+Pushed] sysdb_sudo: Enable LDAP time format compatibility

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/953
Title: #953: sysdb_sudo: Enable LDAP time format compatibility

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#953][comment] sysdb_sudo: Enable LDAP time format compatibility

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/953
Title: #953: sysdb_sudo: Enable LDAP time format compatibility

pbrezina commented:
"""
* `master`
* 58a67cd38b8be9bef45ce70588763d851840dd65 - sysdb_sudo: Enable LDAP time 
format compatibility

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/953#issuecomment-561595568
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#953][+Accepted] sysdb_sudo: Enable LDAP time format compatibility

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/953
Title: #953: sysdb_sudo: Enable LDAP time format compatibility

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#950][comment] ad: Add support for passing --add-samba-data to adcli

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/950
Title: #950: ad: Add support for passing --add-samba-data to adcli

pbrezina commented:
"""
* `master`
* 1cdd43140e6069a10d59af0ba80d1c4e9427a0b4 - ad: Add support for passing 
--add-samba-data to adcli

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/950#issuecomment-561594329
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#953][comment] sysdb_sudo: Enable LDAP time format compatibility

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/953
Title: #953: sysdb_sudo: Enable LDAP time format compatibility

pbrezina commented:
"""
Thank you. Ack.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/953#issuecomment-561595135
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#953][+Ready to push] sysdb_sudo: Enable LDAP time format compatibility

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/953
Title: #953: sysdb_sudo: Enable LDAP time format compatibility

Label: +Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#950][+Pushed] ad: Add support for passing --add-samba-data to adcli

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/950
Title: #950: ad: Add support for passing --add-samba-data to adcli

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#950][closed] ad: Add support for passing --add-samba-data to adcli

2019-12-04 Thread pbrezina
   URL: https://github.com/SSSD/sssd/pull/950
Author: chenxiaolong
 Title: #950: ad: Add support for passing --add-samba-data to adcli
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/950/head:pr950
git checkout pr950
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#950][-Ready to push] ad: Add support for passing --add-samba-data to adcli

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/950
Title: #950: ad: Add support for passing --add-samba-data to adcli

Label: -Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#950][-Accepted] ad: Add support for passing --add-samba-data to adcli

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/950
Title: #950: ad: Add support for passing --add-samba-data to adcli

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#951][-Ready to push] sdap: Add randomness to ldap connection timeout

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/951
Title: #951: sdap: Add randomness to ldap connection timeout

Label: -Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#951][+Pushed] sdap: Add randomness to ldap connection timeout

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/951
Title: #951: sdap: Add randomness to ldap connection timeout

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#951][comment] sdap: Add randomness to ldap connection timeout

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/951
Title: #951: sdap: Add randomness to ldap connection timeout

pbrezina commented:
"""
* `master`
* bd201746f8cf0e95615b3e98868555451b5e66b8 - sdap: Add randomness to ldap 
connection timeout

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/951#issuecomment-561593924
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#951][closed] sdap: Add randomness to ldap connection timeout

2019-12-04 Thread pbrezina
   URL: https://github.com/SSSD/sssd/pull/951
Author: thalman
 Title: #951: sdap: Add randomness to ldap connection timeout
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/951/head:pr951
git checkout pr951
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#951][-Accepted] sdap: Add randomness to ldap connection timeout

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/951
Title: #951: sdap: Add randomness to ldap connection timeout

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#952][+Pushed] Remove extra word

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/952
Title: #952: Remove extra word

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#952][-Ready to push] Remove extra word

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/952
Title: #952: Remove extra word

Label: -Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#952][-Accepted] Remove extra word

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/952
Title: #952: Remove extra word

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#952][closed] Remove extra word

2019-12-04 Thread pbrezina
   URL: https://github.com/SSSD/sssd/pull/952
Author: yurchor
 Title: #952: Remove extra word
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/952/head:pr952
git checkout pr952
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#952][comment] Remove extra word

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/952
Title: #952: Remove extra word

pbrezina commented:
"""
* `master`
* 101082583a710a69e5d30bb257b3d8b5c4d90437 - Remove extra word

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/952#issuecomment-561591848
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#952][+Ready to push] Remove extra word

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/952
Title: #952: Remove extra word

Label: +Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#951][+Ready to push] sdap: Add randomness to ldap connection timeout

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/951
Title: #951: sdap: Add randomness to ldap connection timeout

Label: +Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#950][+Ready to push] ad: Add support for passing --add-samba-data to adcli

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/950
Title: #950: ad: Add support for passing --add-samba-data to adcli

Label: +Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#952][comment] Remove extra word

2019-12-04 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/952
Title: #952: Remove extra word

pbrezina commented:
"""
I'll amend it before pushing.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/952#issuecomment-561588919
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org