Re: Kirigami patches

[Dirk Hohndel]

-- 
Sent from my phone

On August 16, 2016 5:59:06 AM PDT, Marco Martin  wrote:
>On Tuesday 16 August 2016, Tomaz Canabrava wrote:
>> > > - use the .pri file when directly linking in kirigami into the
>(parent)
>> > > project (include directive in PROJECT.pro), then the
>Q_INIT_RESOURCE is
>> > > not necessary. using qmake this seems to be the easiest way and
>at
>> > > least seems to compile for different platforms.
>> > 
>> > subsurface is cmake based, so the pri file can't be used
>> 
>> Subsurface is cmake based only on all platforms besides ios, I didn't
>> managed to make the ios build work on cmake.
>
>ah.
>if it's qmake tThis is where I admit that I don't understand the subtleties..

Just to make sure I understand this correctly... You are suggesting that I 
shouldn't build Kirigami as a separate library, but that I should include the 
kirigami.pri file from the Subsurface-mobile.pro file? And I assume that i then 
don't need much of what I spent all weekend trying to make work?

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Kirigami patches

[Dirk Hohndel]

> On Aug 16, 2016, at 6:48 AM, Marco Martin  wrote:
> 
> On Tuesday 16 August 2016, Dirk Hohndel wrote:
>> Just to make sure I understand this correctly... You are suggesting that I
>> shouldn't build Kirigami as a separate library, but that I should include
>> the kirigami.pri file from the Subsurface-mobile.pro file? And I assume
>> that i then don't need much of what I spent all weekend trying to make
>> work?
> 
> ah, if what you have now works, then that's fine :)
> was something to try if it wasn't working yet :)

Well, the .pri approach means fewer changes to Subsurface (and Kirigami),
so in that sense I think it's preferable. I just need to test if it actually 
works
(it's still early morning here, haven't had time to try it)

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Kirigami patches

[Dirk Hohndel]

On Tue, Aug 16, 2016 at 03:48:49PM +0200, Marco Martin wrote:
> On Tuesday 16 August 2016, Dirk Hohndel wrote:
> > Just to make sure I understand this correctly... You are suggesting that I
> > shouldn't build Kirigami as a separate library, but that I should include
> > the kirigami.pri file from the Subsurface-mobile.pro file? And I assume
> > that i then don't need much of what I spent all weekend trying to make
> > work?
> 
> ah, if what you have now works, then that's fine :)
> was something to try if it wasn't working yet :)

So here are the kirigami patches that I now use. The last one I don't
think you want to take. But I'd love to see a property that a program
using Kirigami can use to overwrite the fairly narrow defauly of 20 grid
units.

/D
>From 12d43e899ee28493098bb8d78f17413bddd10fd2 Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Mon, 15 Aug 2016 16:39:21 -0700
Subject: [PATCH 1/4] More qmake fixes

The .pro file didn't include the resource file, which made things not work when
built with qmake.

Also, the .pri file was missing the enums .cpp/.h files.

Signed-off-by: Dirk Hohndel 
---
 kirigami.pri | 4 ++--
 kirigami.pro | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/kirigami.pri b/kirigami.pri
index fc88c4c..8bf35a3 100644
--- a/kirigami.pri
+++ b/kirigami.pri
@@ -1,7 +1,7 @@
 
 QT  += qml quick gui svg
-HEADERS += $$PWD/src/kirigamiplugin.h
-SOURCES += $$PWD/src/kirigamiplugin.cpp
+HEADERS += $$PWD/src/kirigamiplugin.h $$PWD/src/enums.h
+SOURCES += $$PWD/src/kirigamiplugin.cpp $$PWD/src/enums.cpp
 INCLUDEPATH += $$PWD/src
 DEFINES += KIRIGAMI_BUILD_TYPE_STATIC
 
diff --git a/kirigami.pro b/kirigami.pro
index f7d6fe6..87af61f 100644
--- a/kirigami.pro
+++ b/kirigami.pro
@@ -4,6 +4,7 @@ CONFIG += plugin
 QT  += qml quick gui svg
 HEADERS += $$PWD/src/kirigamiplugin.h $$PWD/src/enums.h
 SOURCES += $$PWD/src/kirigamiplugin.cpp $$PWD/src/enums.cpp
+RESOURCES   += $$PWD/kirigami.qrc
 
 API_VER=1.0
 
-- 
2.7.4 (Apple Git-66)

>From a7db5877074d1ee6edc258827b54337eb67ca8f1 Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Mon, 15 Aug 2016 16:42:08 -0700
Subject: [PATCH 2/4] Q_RESOURCE_INIT macro has to be called by user

Calling this from within the library doesn't seem to be the right thing to do,
according to the documentation at http://doc.qt.io/qt-5/resources.html

Signed-off-by: Dirk Hohndel 
---
 src/kirigamiplugin.cpp | 4 
 1 file changed, 4 deletions(-)

diff --git a/src/kirigamiplugin.cpp b/src/kirigamiplugin.cpp
index fc530b3..83b4dc2 100644
--- a/src/kirigamiplugin.cpp
+++ b/src/kirigamiplugin.cpp
@@ -43,10 +43,6 @@ QString KirigamiPlugin::componentPath(const QString &fileName) const
 
 void KirigamiPlugin::registerTypes(const char *uri)
 {
-#ifdef KIRIGAMI_BUILD_TYPE_STATIC
-Q_INIT_RESOURCE(kirigami);
-#endif
-
 Q_ASSERT(uri == QLatin1String("org.kde.kirigami"));
 const QString style = QString::fromLatin1(qgetenv("QT_QUICK_CONTROLS_STYLE"));
 
-- 
2.7.4 (Apple Git-66)

>From 6fcefdfd9cc8c44dda9334a84a5f35da23d62adf Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Mon, 15 Aug 2016 19:15:36 -0700
Subject: [PATCH 3/4] Don't exit the app on iOS.

iOS users perceive that as "the app has crashed"

Signed-off-by: Dirk Hohndel 
---
 src/controls/ApplicationWindow.qml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/controls/ApplicationWindow.qml b/src/controls/ApplicationWindow.qml
index 5060214..2526453 100644
--- a/src/controls/ApplicationWindow.qml
+++ b/src/controls/ApplicationWindow.qml
@@ -145,7 +145,7 @@ AbstractApplicationWindow {
 }
 }
 
-if (Settings.isMobile && !backEvent.accepted) {
+if (Settings.isMobile && !backEvent.accepted && Qt.platform.os !== "ios") {
         Qt.quit();
 }
 }
-- 
2.7.4 (Apple Git-66)

>From 555b0062b777e9120fb749ecde5a81c85156be6b Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Mon, 15 Aug 2016 19:58:12 -0700
Subject: [PATCH 4/4] 20 gridUnits is too narrow

Signed-off-by: Dirk Hohndel 
---
 src/controls/templates/private/PageRow.qml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/controls/templates/private/PageRow.qml b/src/controls/templates/private/PageRow.qml
index 00e25d6..2b154e7 100644
--- a/src/controls/templates/private/PageRow.qml
+++ b/src/controls/templates/private/PageRow.qml
@@ -61,7 +61,7 @@ Item {
  * Pages can override it with their Layout.fillWidth,
  * implicitWidth Layout.minimumWidth etc.
  */
-property int defaultColumnWidth: Units.gridUnit * 20
+property int defaultColumnWidth: Units.gridUnit * 30
 
 /**
  * interactive: bool
-- 
2.7.4 (Apple Git-66)

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Fix kirigami build

[Dirk Hohndel]

On Wed, Aug 17, 2016 at 06:50:35PM +0200, Anton Lundin wrote:
> This fixes the subsurface-mobile build on my Linux desktop and on
> android.
> 
> To get it to run on Linux desktop, set QT_QUICK_CONTROLS_STYLE to
> something that kirigami doesn't know about, like kakor. Otherwise it
> will detect Desktop and die on:
> qrc:/styles/Desktop/Icon.qml:23 module "org.kde.kquickcontrolsaddons" is not 
> installed
> 
> This works with kirigami 32c980c46, when 47fb7821 is reverted.
> 
> Signed-off-by: Anton Lundin 
> ---
> The cmake parts are sketchy at best, and should be fixed in a better way.
> 
> It would also be nice if kirigami static build did have a install target
> that created a dir contaning the needed parts.
> 
>  CMakeLists.txt  |  3 ++-
>  packaging/android/build.sh  | 13 +
>  scripts/build.sh| 10 +-
>  scripts/mobilecomponents.sh |  7 ---
>  4 files changed, 20 insertions(+), 13 deletions(-)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index a824d03..6328dc0 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -240,7 +240,8 @@ if(${SUBSURFACE_TARGET_EXECUTABLE} MATCHES 
> "MobileExecutable")
>   endif()
>   ADD_LIBRARY(kirigami_static_library STATIC IMPORTED)
>   SET_TARGET_PROPERTIES(kirigami_static_library PROPERTIES
> - IMPORTED_LOCATION 
> ${CMAKE_SOURCE_DIR}/../kirigami-build/src/libkirigamiplugin.a)
> + IMPORTED_LOCATION ${KIRIGAMI_LIBRARY})

No, that breaks the build as KIRIGAMI LIBRARY is not defined in the
CMakeLists.txt file. It's fine to have this work if the value is provided
buy a build script, but there must be a default value so existing builds
don't break with syntax error.


> diff --git a/packaging/android/build.sh b/packaging/android/build.sh
> index d844e8d..4b353e3 100644
> --- a/packaging/android/build.sh
> +++ b/packaging/android/build.sh
> @@ -316,11 +316,15 @@ if [ "$SUBSURFACE_MOBILE" = "ON" ] ; then
>   pushd $SUBSURFACE_SOURCE
>   bash ./scripts/mobilecomponents.sh
>   popd
> - rm -rf kirigami-build
> - mkdir -p kirigami-build
> - pushd kirigami-build
> - cmake $SUBSURFACE_SOURCE/mobile-widgets/qml/kirigami/ 
> -DSTATIC_LIBRARY=ON 
> -DCMAKE_PREFIX_PATH:UNINITIALIZED=${QT5_ANDROID}/android_${QT_ARCH}/lib/cmake
> + rm -rf kirigami-build-$ARCH
> + mkdir -p kirigami-build-$ARCH
> + pushd kirigami-build-$ARCH
> + cmake \
> + $SUBSURFACE_SOURCE/../kirigami/ \
> + -DSTATIC_LIBRARY=ON \
> + 
> -DCMAKE_PREFIX_PATH:UNINITIALIZED=${QT5_ANDROID}/android_${QT_ARCH}/lib/cmake
>   make -j4
> + 
> KIRIGAMI_LIBRARY="-DKIRIGAMI_LIBRARY=../kirigami-build-$ARCH/src/libkirigamiplugin.a"

I don't like this way of using a variable...

> @@ -361,6 +365,7 @@ cmake $MOBILE_CMAKE \
>   -DCMAKE_BUILD_TYPE=${BUILD_TYPE} \
>   -DMAKE_TESTS=OFF \
>   -DFTDISUPPORT=${FTDI} \
> + $KIRIGAMI_LIBRARY \

I'd rather have
-DKIRIGAMI_LIBRARY=$KIRIGAMI_LIBRARY


> diff --git a/scripts/build.sh b/scripts/build.sh
> index 02f1095..113ab6f 100755
> --- a/scripts/build.sh
> +++ b/scripts/build.sh
>   make -j4
> + 
> KIRIGAMI_LIBRARY="-DKIRIGAMI_LIBRARY=$SRC/kirigami-build/src/libkirigamiplugin.a"
>   fi
>   cmake -DCMAKE_BUILD_TYPE=Debug .. \
> + $KIRIGAMI_LIBRARY \
>   -DSUBSURFACE_TARGET_EXECUTABLE=$SUBSURFACE_EXECUTABLE \

Ditto.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Fix kirigami build

[Dirk Hohndel]

On Thu, Aug 18, 2016 at 12:42:32PM +0200, Anton Lundin wrote:
> > > +++ b/CMakeLists.txt
> > > @@ -240,7 +240,8 @@ if(${SUBSURFACE_TARGET_EXECUTABLE} MATCHES 
> > > "MobileExecutable")
> > >   endif()
> > >   ADD_LIBRARY(kirigami_static_library STATIC IMPORTED)
> > >   SET_TARGET_PROPERTIES(kirigami_static_library PROPERTIES
> > > - IMPORTED_LOCATION 
> > > ${CMAKE_SOURCE_DIR}/../kirigami-build/src/libkirigamiplugin.a)
> > > + IMPORTED_LOCATION ${KIRIGAMI_LIBRARY})
> > 
> > No, that breaks the build as KIRIGAMI LIBRARY is not defined in the
> > CMakeLists.txt file. It's fine to have this work if the value is provided
> > buy a build script, but there must be a default value so existing builds
> > don't break with syntax error.
> > 
> 
> This cmake part can be done better, as said above. I don't know how to
> create a mandatory parameter which is conditional on it being the
> MobileExecutable thats being built, so thats why i did it this way.
> 
> I agree that its bad to break peoples build dirs, but how is building a
> mobile version by just rebuilding subsurface at the moment?
> When built via the scripts, both scripts/build.sh and
> packaging/android/build.sh, they will add the relevant parameter, so
> that why i really don't see this as a big blocker.

Yes, it's all a mess right now. Mea culpa.

> The ios build script doesn't build kirigami at all as far as it looks to me.

Correct, because the qmake build simply links kirigami into the
executable, and I think I'll just do the same for the cmake builds.

> Anyhow, this will _never_ work with the android builds (and probably ios
> to) due to that kirigami library not being next to the subsurface dir.
> 
> Even worse, if one would do as i do and build multiple different arches
> at on the same machine, the library might exist but being built for the
> wrong arch.
> 
> So, cmake'ers: how do one create a conditional mandatory parameter?

No, let's not do that. Let me see if I can fix things differently.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Fix kirigami build

[Dirk Hohndel]

On Thu, Aug 18, 2016 at 09:27:55PM -0700, Dirk Hohndel wrote:
> No, let's not do that. Let me see if I can fix things differently.

My solution is pushed. Careful with the latest Kirigami master - I just
sent a patch to their mailing list, you need to delete the reference to
src/styles/Desktop/Icon.qml from the kirigami.qrc file for things to
build.

But once you do this I can successfully build and run Subsurface-mobile
both on Linux/Desktop and on Android.

I'll put a new apk up for testing.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: eon steel can't connect

[Dirk Hohndel]

> On Aug 21, 2016, at 1:27 AM, Gert-Jan Morsink  wrote:
> 
> Hello,
> Seem to have some problems connecting my eon steel with cable.
> It worked fine and made my last entry 21 of july this year but today I can’t 
> connect?
> Strange ?
>  
> Hoping you have an answer for me?

Which firmware version do you have on your EON Steel? There is a bug in the EON 
Steel
that was fixed in the very latest firmware where it sometimes just stops 
connecting.

It appears that a reboot temporarily fixes things. So switch to a different 
mode (Air / Nitrox / 
Custom) and back to the mode you want it to be in. Every time you switch mode 
the EON
Steel reboots. After the reboot it should connect again.

(the other thing to check first, of course, is that the contacts are completely 
dry...)

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Subsurface-mobile on Android 7.0 / Nougat

[Dirk Hohndel]

After reading a bit more of the documentation that Google provided regarding 
the 
change with regard to native libraries and reading about other projects cursing 
and 
complaining until they got this to work, I believe that my first attempt to fix 
this was 
exactly the wrong thing to do. 

Yes, you are not supposed to dynamically link against native libraries that 
aren’t 
part of the official API. But that doesn’t mean that you should statically link 
against 
them, instead I now believe that it means you should dynamically link against 
them 
and bundle them with your app.

So that’s what I tried to do: 4.5.2-1355 should be on its way to the Google Play
Alpha channel and is also already available for direct download on 
downloads/daily

I tested this on 6.0.1, but NOT YET on 7.0. So I don’t think I broke what worked
before, but I haven’t been able to verify that this actually fixes the problem 
on
Android 7.0 / Nougat.

I know that some of you have already received either a 7.0 preview or even the
final build on your devices. Please test -1355 so I know if this actually fixes 
things…

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: preferences - safe to merge (finally)

[Dirk Hohndel]

On Sat, Aug 27, 2016 at 08:58:08AM -0300, Tomaz Canabrava wrote:
> sorry for the long delay - life is a bit crazy.
> 
> For those who don't know yet, I'm trying to move to germany and I just went
> to the consulate here in brazil this tuesday - send me good vibes.

How did it go? I assume they beat you up, threw you on the ground, used
some tear gas on you and then threatened to sue you over the damage you
did to their carpet when throwing up?

> While this is mostly finished and a *bit* tested, I didn't do a ton of
> testing, so I'll send more patches over those, but this is a goos start, if
> I break anything on any preferences - you'd been warned, not finished, but
> mergeable.

It applies nicely. I did my usual rewriting of the commit messages and a
couple of tiny whitespace fixes.

> I'd say this is 80% ready. I'v foud a few places where a setting is changed
> the 'wrong' way (and by wrong way I mean that a setting is changed, the
> setting should trigger code but some unrelated signal is send that in turn
> will trigger the correct code. But the signal (or the class) shouldn't be
> doing that)

I compiled it and started testing. First thing I notice, I get asked if I
allow Subsurface to check for updates - and if I accept then it asks me
again, every time I start Subsurface. Only by declining can I get rid of
the dialog.

That's not what we want, is it? :-/

This is caused by your implementation losing sight of the fact that there
are THREE states. The DontCheckForUpdates can be unset, true, or false.
Your code turns this into a binary case. I added a commit to fix that.

I also noticed that when I make changes to the settings and then click
apply, I am told that in order to change language I had to restart
Subsurface (I didn't change the language...) and then when I clicked OK
Subsurface crashed.

I haven't had time to investigate this one, yet.

Nevertheless, in order to get more people to test and hopefully fix
things, I'll push all this to master.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: preferences - safe to merge (finally)

[Dirk Hohndel]

On Sat, Aug 27, 2016 at 12:36:25PM -0700, Dirk Hohndel wrote:
> 
> > While this is mostly finished and a *bit* tested, I didn't do a ton of
> > testing, so I'll send more patches over those, but this is a goos start, if
> > I break anything on any preferences - you'd been warned, not finished, but
> > mergeable.
> 
> It applies nicely. I did my usual rewriting of the commit messages and a
> couple of tiny whitespace fixes.
> 
> > I'd say this is 80% ready. I'v foud a few places where a setting is changed
> > the 'wrong' way (and by wrong way I mean that a setting is changed, the
> > setting should trigger code but some unrelated signal is send that in turn
> > will trigger the correct code. But the signal (or the class) shouldn't be
> > doing that)
> 
> I compiled it and started testing. First thing I notice, I get asked if I
> allow Subsurface to check for updates - and if I accept then it asks me
> again, every time I start Subsurface. Only by declining can I get rid of
> the dialog.
> 
> That's not what we want, is it? :-/
> 
> This is caused by your implementation losing sight of the fact that there
> are THREE states. The DontCheckForUpdates can be unset, true, or false.
> Your code turns this into a binary case. I added a commit to fix that.

Oh, and I noticed that you didn't make the corresponding changes for
Subsurface-mobile to keep compiling, so I added those as well.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: preferences - safe to merge (finally)

[Dirk Hohndel]

> On Aug 27, 2016, at 12:55 PM, Tomaz Canabrava  wrote:
> I also noticed that when I make changes to the settings and then click
> apply, I am told that in order to change language I had to restart
> Subsurface (I didn't change the language...) and then when I clicked OK
> Subsurface crashed. 
> 
> I haven't had time to investigate this one, yet.
> 
> I'm looking into it - it's a bit exausting, I'm checking all preferences to 
> see if they apply / restore, also I'm adding a unittest for the preferences.

Yes, this is a thorny part of the code that you are tackling.
I really appreciate that you are working on this.

Please make sure you pull master before continuing so that
your changes are on top of my two commits (and the small
changes that I made to your code).

Thanks

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Login Bug

[Dirk Hohndel]

> On Aug 27, 2016, at 5:16 PM, Kiliii Fish  wrote:
> 
> Hi folks, having trouble with the iOS cloud service sync.
> 
> user-id: A8F0PVM444GGQ9E3C1UKTCHR4F0X35
> email: kiliii.f...@gmail.com 
> 
> Seems to have trouble on the desktop side, showing me an incorrect user-id in 
> preferences that I cannot seem to change and have it stick. I can sync on the 
> desktop but the iOS version won’t find any dives. Thoughts?

You are not using Subsurface-mobile on iOS (which still is not generally 
available) but the Subsurface companion app.
The ID you show above is for the companion app. Its sole purpose is to track 
GPS locations of dives while on a dive boat.
Subsurface-mobile allows you to see your dive list on an iOS or Android device, 
but the iOS version is still only in closed beta testing.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Subsurface-mobile on Android

[Dirk Hohndel]

It seems that when I pushed the latest build (the one that works on Nougat) to 
production, things started to fail for a few of our users. And of course 
instead of sending email to ask for help, we are getting one and two star 
reviews instead. Great.

Anyway… could those on Android try if they can reproduce it? One person 
contacted me by email and the logs on his system are just strange…

2016-08-28 11:48:07,DEBUG,dalvikvm,Unknown,Trying to load lib 
/data/app-lib/org.subsurfacedivelog.mobile-1/libssl.so 0x41b3a160
2016-08-28 11:48:07,DEBUG,dalvikvm,Unknown,Added shared lib 
/data/app-lib/org.subsurfacedivelog.mobile-1/libssl.so 0x41b3a160
2016-08-28 11:48:07,DEBUG,dalvikvm,Unknown,No JNI_OnLoad found in 
/data/app-lib/org.subsurfacedivelog.mobile-1/libssl.so 0x41b3a160, skipping init
2016-08-28 11:48:07,DEBUG,dalvikvm,Unknown,Trying to load lib 
/data/app-lib/org.subsurfacedivelog.mobile-1/libcrypto.so 0x41b3a160
2016-08-28 11:48:07,DEBUG,dalvikvm,Unknown,Added shared lib 
/data/app-lib/org.subsurfacedivelog.mobile-1/libcrypto.so 0x41b3a160
2016-08-28 11:48:07,DEBUG,dalvikvm,Unknown,No JNI_OnLoad found in 
/data/app-lib/org.subsurfacedivelog.mobile-1/libcrypto.so 0x41b3a160, skipping 
init
2016-08-28 11:48:07,DEBUG,dalvikvm,Unknown,Trying to load lib 
/data/app-lib/org.subsurfacedivelog.mobile-1/libssh2.so 0x41b3a160
2016-08-28 
11:48:07,ERROR,dalvikvm,Unknown,dlopen("/data/app-lib/org.subsurfacedivelog.mobile-1/libssh2.so")
 failed: dlopen failed: cannot locate symbol "EVP_cast5_cbc" referenced by 
"libssh2.so"...


So it’s loading lib crypto.so successfully 

$ nm libcrypto.so | grep EVP_cast5
000c3a38 T EVP_cast5_cbc

which contains the symbol that it then claims it can’t find.

I’m completely baffled.

I don’t know, yet, if that’s the common problem for everyone, but more data 
points (or even better, a fix) would be very welcome.

Of course it works on the two Android phones I have tested it on (Nexus 6P with 
6.0.1 and 5X with 7.0)

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile on Android

[Dirk Hohndel]

On August 28, 2016 3:45:58 PM PDT, Rick Walsh  wrote:
>On 29 Aug 2016 04:55, "Dirk Hohndel"  wrote:
>>
>>
>> It seems that when I pushed the latest build (the one that works on
>Nougat) to production, things started to fail for a few of our users.
>And
>of course instead of sending email to ask for help, we are getting one
>and
>two star reviews instead. Great.
>>
>That's annoying. The way the Android store is set up, it makes it much
>easier to review than send an email. Having said that, no 2star reviews
>are
>showing up for me.

I responded to all of those reviews asking people to contact me. Maybe you 
don't see it because it was in German? I can still see it in the Google Play 
Console.

>The latest daily is working fine on my Galaxy S6, Android 6.01

Thanks. Same on my Nexus 6p. So it works on some 6.0.1 phones and fails on 
others. Very annoying.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile on Android

[Dirk Hohndel]

Please try

http://subsurface-divelog.org/downloads/daily/Subsurface-mobile-4.5.2.1564-release-arm.apk
 


This should both work on Android 7 (but someone please verify, I didn’t bring a 
phone with Android 7 to Las Vegas) and on the phones where the previous version 
failed.

I’d really appreciate if people could verify both of these statements.

Thanks

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile on Android

[Dirk Hohndel]

> On Aug 28, 2016, at 7:50 PM, Rick Walsh  wrote:
> 
> 
> 
> On 29 August 2016 at 12:41, Dirk Hohndel  <mailto:d...@hohndel.org>> wrote:
> 
> Please try
> 
> http://subsurface-divelog.org/downloads/daily/Subsurface-mobile-4.5.2.1564-release-arm.apk
>  
> <http://subsurface-divelog.org/downloads/daily/Subsurface-mobile-4.5.2.1564-release-arm.apk>
> 
> This should both work on Android 7 (but someone please verify, I didn’t bring 
> a phone with Android 7 to Las Vegas) and on the phones where the previous 
> version failed.
> 
> I’d really appreciate if people could verify both of these statements.
> 
> 
> I needed to uninstall the previous (1535) build before I could install the 
> latest.  Did you sign with the same key?

Yes. That’s the difference between the -release-arm.apk and the other one. 
I guess I can stop making that other one now… initially I only released the 
APKs on the website… and the release one had a different key. So I started
making two so people could seamlessly upgrade. No idea why this failed for you.

> Other than that, it seems to work in my 2 minutes of testing: I could enter 
> my credentials, sync with cloud, and view a few dives.  I didn't try anything 
> more sophisticated than that.

Well - “WORKS” is always a welcome test result.

Thanks for the immediate response!

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile on Android

[Dirk Hohndel]

> On Aug 28, 2016, at 7:54 PM, Richard DePas  wrote:
> 
> I was able to install it without uninstalling the previous version. It also 
> seems to be be working for me. Pulled up all my dives and was able to 
> navigate around just fine.

Excellent. That’s what I was hoping… Now I just need to see if the test also
succeeds for people on Android Nougat. I see no reason why it shouldn’t,
but you never know…

Thanks for the immediate response!

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH 1/2] QML UI: Enable cylinder edit

[Dirk Hohndel]

On Mon, Aug 29, 2016 at 09:35:05PM +0200, Joakim Bygdell wrote:
> + QStringList cylinders;
> + struct dive *d;
> + int i = 0;
> + for_each_dive (i, d) {
> + for (int j = 0; j < MAX_CYLINDERS; j++) {
> + QString cyl = d->cylinder[j].type.description;
> + if (cyl == EMPTY_DIVE_STRING)
> + continue;
> + cylinders << cyl;
> + }
> + }
> +
> + for (i = 0; i < 100 && tank_info[i].name != NULL; i++) {

Why are we looping to 100 here. That just seems odd to me.

> + // info for first cylinder
> + if (myDive->getCylinder() != cylinder) {
> + diveChanged = true;
> + int i, size, wp;
> + for (i = 0; i < 100 && tank_info[i].name != NULL; i++) {

Again this loop to 100

> + if (tank_info[i].name == cylinder ) {
> + if (tank_info[i].ml > 0){
> + size = tank_info[i].ml;
> + wp = tank_info[i].bar * 1000;
> + }
> + else {

That's not our coding style... } else {

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Subsurface-mobile for iOS is finally on iTunes

[Dirk Hohndel]

It took forever but more than six months after the first alpha I managed to get 
Subsurface-mobile for iOS into the Apple store.
I also managed to update the user manual and make sure that the version linked 
by the app actually doesn’t just talk about Android :-)

If you have access to an iPad or iPhone, please give it a spin.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Reset Cloud PassWd

[Dirk Hohndel]

No. I can reset.
Send me e-mail from the account you want reset

/D
-- 
Sent from my phone

On September 9, 2016 11:38:51 AM PDT, Oskar Sander  
wrote:
>Hi all,
>
>Any workaround for resetting password?
>
>I got the sync error and and probably misused the new password-filed as
>neither new nor old password seems to be working.
>
>If I understoood right, only workaround for the moment is to register a
>new
>temorary email account somewhere and start over?
>
>Cheers
>/O
>
>2016-07-25 17:25 GMT+02:00 Holger Schmermbeck :
>
>> Hey,
>>
>> is it possible to reset the Cloud Password for the Account
>> ho...@mailbox.org, pls?!
>>
>>
>> Greets
>>
>> Holger
>>
>>
>>
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>>
>http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>>
>>
>
>
>-- 
>/O
>
>
>
>
>___
>subsurface mailing list
>subsurface@subsurface-divelog.org
>http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: TestFlight feedback for Subsurface-mobile. Dropbox etc

[Dirk Hohndel]

> On Sep 10, 2016, at 8:25 AM, Jaspal Sahota  wrote:
> 
> Hi
> Any plans to support other 'cloud' storage (eg Dropbox/google drive/etc)?

Not really - I don't think there's a developer who has this as their goal.

> While I like the convenience of the subsurface cloud storage in many ways I 
> prefer using Dropbox mainly because it gives me a history of the last few 
> revisions (in case I screw up the log importing/bulk editing etc). It also 
> seems to be a bit more reliable I terms of saving - I often get 'could not 
> connect to cloud' type errors from the desktop subsurface  (I know that's 
> nothing to do with mobile, but it's another reason for me). 

That's a known "oddity" in the desktop version. I need to find time to release 
a 
new version of the desktop software - this has been fixed. If you want to switch
to our latest daily build, the problem will be gone.

And just for completeness... our storage format for the cloud is actually a git
backend, so you can go back to any arbitrary version that you have stored.
Unfortunately no one has written a UI to do this, so you'll have to manually
use the git command to go back to an earlier version. But it is possible to
retrieve older versions.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: TestFlight feedback for Subsurface-mobile. Dropbox etc

[Dirk Hohndel]

BTW - strangely TestFlight doesn't appear to show testers when the final version
of the app made it to the App Store. We finally released Subsurface-mobile 1.1
for iOS earlier this week

/D

> On Sep 10, 2016, at 8:25 AM, Jaspal Sahota  wrote:
> 
> 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile

[Dirk Hohndel]

Can you connect your phone to a computer via USB, turn on USB debugging on the 
phone and use adb on the computer to extract the logcat output?

/D
-- 
Sent from my phone

On September 10, 2016 9:26:40 PM PDT, brossmeisl  
wrote:
>I am getting "your application encountered a fatal error and cannot
>continue" when I try to start subsurface-mobile on my 6.0.1 marshmallow
>phone. I applied to be a beta tester and it still seems to happen there
>too. Do you have any recommendations? Thank you in advance.
>  Regards,
>Brian Rossmeisl
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile

[Dirk Hohndel]

Ha. I've stopped supporting x86 devices ages ago. Way too much work for no 
significant user base. Sorry.

/D

> On Sep 10, 2016, at 9:52 PM, brossmeisl  wrote:
> 
> Oh. I am running an intel atom phone asus zenfone 2. It looks like its trying 
> to load an arm ssl lib. Do you mind adding 32bit intel support?
> 
> 
> On Sep 11, 2016 00:41, "brossmeisl"  <mailto:brian.rossme...@gmail.com>> wrote:
> I am not a developer but it looks like it can't load some ssl lib
> 
> 09-11 00:39:28.489 21209 21209 D houdini : [21209] Load library 
> /data/app/org.subsurfacedivelog.mobile-1/lib/arm/libssl.so failed.
> 09-11 00:39:28.490 21209 21209 W System.err: Caused by: 
> java.lang.UnsatisfiedLinkError: dlopen failed: 
> "/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libssl.so" has unexpected 
> e_machine: 40
> 09-11 00:39:28.720   618   638 I ActivityManager: Displayed 
> org.subsurfacedivelog.mobile/org.qtproject.qt5.android.bindings.QtActivity: 
> +672ms
> 09-11 00:39:32.046   618  1553 I ActivityManager: START u0 
> {act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] 
> flg=0x1020 
> cmp=org.subsurfacedivelog.mobile/org.qtproject.qt5.android.bindings.QtActivity
>  (has extras)} from uid 10035 on display 0
> 09-11 00:39:32.149 21209 21209 D houdini : [21209] Load library 
> /data/app/org.subsurfacedivelog.mobile-1/lib/arm/libssl.so failed.
> 09-11 00:39:32.151 21209 21209 W System.err: Caused by: 
> java.lang.UnsatisfiedLinkError: dlopen failed: 
> "/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libssl.so" has unexpected 
> e_machine: 40
> 09-11 00:39:32.282   618   638 I ActivityManager: Displayed 
> org.subsurfacedivelog.mobile/org.qtproject.qt5.android.bindings.QtActivity: 
> +204ms
> 
> 
> On Sun, Sep 11, 2016 at 12:29 AM, Dirk Hohndel  <mailto:d...@hohndel.org>> wrote:
> Can you connect your phone to a computer via USB, turn on USB debugging on 
> the phone and use adb on the computer to extract the logcat output?
> 
> /D
> -- 
> Sent from my phone
> 
> 
> On September 10, 2016 9:26:40 PM PDT, brossmeisl  <mailto:brian.rossme...@gmail.com>> wrote:
> I am getting "your application encountered a fatal error and cannot continue" 
> when I try to start subsurface-mobile on my 6.0.1 marshmallow phone. I 
> applied to be a beta tester and it still seems to happen there too. Do you 
> have any recommendations? Thank you in advance.
>   Regards,
> Brian Rossmeisl
> 
> 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

updates to Subsurface and libdivecomputer

[Dirk Hohndel]

Thanks to Linus and Anton we have an updated Subsurface-branch for 
libdivecomputer.
This goes along with an update to Subsurface itself to adjust to the 
modified API for our serial code.

I’ve had problems with the native Bluetooth code for a while and feel
like I can’t quite figure out where the culprit is. I only had a chance to
test this on my Mac, though, and Bluetooth has always been a challenge
on the Mac.

I’d appreciate if some of you with Bluetooth dive computers could give
this a try and let me know if things work on Windows, Linux and Mac.

(I’ll make new daily builds available)

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: updates to Subsurface and libdivecomputer

[Dirk Hohndel]

On Sun, Sep 18, 2016 at 08:40:25AM +0200, Anton Lundin wrote:
> > 
> > I tested it on Linux, and it worked.
> > 
> > 
> > I saw the following earlier:
> > static const hw_ostc_layout_t hw_ostc_layout_frog = {
> > ...
> >32, /* firmware */ /* 32 or 34??? Anton says 32 (34 == battery), Jef 
> > says 34 */
> > 
> > That wasn't me, it was Dirk who said 32. I have no clue about how the hw
> > frog layout looks.

Since mine is based on docs that I had and Jef actually has a Frog, I'd
believe him on things like that :-)

> I also looked at the diff between Subsurface-branch and Jef's master,
> and there are some minor things that diff, that we probably should
> resync just to make future merges easier.

Just applied those

> Here are patches for a couple of them. There are 2-3 ones left that
> should probably be cleaned up to, one being tankinfo vs. tankvolume.

Well, we use the "info" vs. "volume" because we also characterize tanks as
DILUENT and O2. I think this is something where we should hope that Jef
eventuall picks up our changes...

> I also noted "Fix the gas mix parsing for the Aladin Tec 2G."
> (decfa24f92d148) in Jef's master that didn't make it into Linus merge.
> It merges cleanly so just pick it.

Done

Thanks for your work on this, Anton!

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: updates to Subsurface and libdivecomputer

[Dirk Hohndel]

On Sun, Sep 18, 2016 at 07:24:28AM -0700, Dirk Hohndel wrote:
> 
> Thanks for your work on this, Anton!

OK, I have fixed a couple small problems on Windows and now things seem to
compile everywhere. New daily builds for Windows, Mac, and Linux are on
the server.

I'm hoping to start a slow march towards a 4.6 release - so any testing is
welcome

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: updates to Subsurface and libdivecomputer

[Dirk Hohndel]

> On Sep 18, 2016, at 10:01 AM, Robert Helling  wrote:
> 
> Dirk,
> 
>> Am 18.09.2016 um 18:24 schrieb Dirk Hohndel > <mailto:d...@hohndel.org>>:
>> 
>> OK, I have fixed a couple small problems on Windows and now things seem to
>> compile everywhere. New daily builds for Windows, Mac, and Linux are on
>> the server.
> 
> I cannot run the binary from the daily builds:
> 
> <2LKtXVyDgfJnyAN1jK3c7_GlVKpjWgnFp5D180F3vRQ.png>
> 
> 
> and the report says:
> 
> Crashed Thread:0
> 
> Exception Type:EXC_BREAKPOINT (SIGTRAP)
> Exception Codes:   0x0002, 0x
> Exception Note:EXC_CORPSE_NOTIFY
> 
> Application Specific Information:
> dyld: launch, loading dependent libraries
> 
> Dyld Error Message:
>   Library not loaded: @executable_path/../Frameworks/libssh2.1.dylib
>   Referenced from: /Volumes/VOLUME/Subsurface.app/Contents/MacOS/Subsurface
>   Reason: Incompatible library version: Subsurface requires version 2.0.0 or 
> later, but libssh2.1.dylib provides version 1.0.0

Fun - different versions of libssh2 are being used. Oops. I'll look into it.

I wonder why it didn't crash when I tried it here, though :-(

Thanks

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: updates to Subsurface and libdivecomputer

[Dirk Hohndel]

> On Sep 18, 2016, at 12:44 PM, Dirk Hohndel  wrote:
> 
> 
>> On Sep 18, 2016, at 10:01 AM, Robert Helling > <mailto:hell...@atdotde.de>> wrote:
>> 
>> Dirk,
>> 
>>> Am 18.09.2016 um 18:24 schrieb Dirk Hohndel >> <mailto:d...@hohndel.org>>:
>>> 
>>> OK, I have fixed a couple small problems on Windows and now things seem to
>>> compile everywhere. New daily builds for Windows, Mac, and Linux are on
>>> the server.
>> 
>> I cannot run the binary from the daily builds:
>> 
>> <2LKtXVyDgfJnyAN1jK3c7_GlVKpjWgnFp5D180F3vRQ.png>
>> 
>> 
>> and the report says:
>> 
>> Crashed Thread:0
>> 
>> Exception Type:EXC_BREAKPOINT (SIGTRAP)
>> Exception Codes:   0x0002, 0x
>> Exception Note:EXC_CORPSE_NOTIFY
>> 
>> Application Specific Information:
>> dyld: launch, loading dependent libraries
>> 
>> Dyld Error Message:
>>   Library not loaded: @executable_path/../Frameworks/libssh2.1.dylib
>>   Referenced from: /Volumes/VOLUME/Subsurface.app/Contents/MacOS/Subsurface
>>   Reason: Incompatible library version: Subsurface requires version 2.0.0 or 
>> later, but libssh2.1.dylib provides version 1.0.0
> 
> Fun - different versions of libssh2 are being used. Oops. I'll look into it.
> 
> I wonder why it didn't crash when I tried it here, though :-(

It did crash - I had tested the wrong DMG :-(

Anyway, fixed and replaced on the web server.

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: updates to Subsurface and libdivecomputer

[Dirk Hohndel]

> On Sep 19, 2016, at 1:49 AM, Rick Walsh  wrote:
> On 18 September 2016 at 11:10, Dirk Hohndel  <mailto:d...@hohndel.org>> wrote:
> 
> Thanks to Linus and Anton we have an updated Subsurface-branch for
> libdivecomputer.
> This goes along with an update to Subsurface itself to adjust to the
> modified API for our serial code.
> 
> I’ve had problems with the native Bluetooth code for a while and feel
> like I can’t quite figure out where the culprit is. I only had a chance to
> test this on my Mac, though, and Bluetooth has always been a challenge
> on the Mac.
> 
> I’d appreciate if some of you with Bluetooth dive computers could give
> this a try and let me know if things work on Windows, Linux and Mac.
> 
> I tested on Linux (Fedora 24) with my Shearwater Petrel 2, and it worked 
> fine.  Built myself from latest master, running the build.sh to update 
> libdivecomputer.
> 
> I should correct what I wrote above.  Downloading the dives via Bluetooth 
> worked fine, but I was not able to select which Bluetooth controller to use 
> (onboard or USB dongle), or turn it on or off - previously I could.  I turned 
> on Bluetooth with the GUI tool included with KDE, and the default controller 
> was the one I wanted to use.
> 
> I've just tested again, and compared to a week-old build and the 4.5.4 
> Appimage.  The ability to control Bluetooth appears to have nothing to do 
> with recent changes in Subsurface or libdivecomputer.  I had Bluetooth 
> disabled through the KDE taskbar icon, and Subsurface couldn't power on 
> Bluetooth from that state.  If I enable Bluetooth through the system, then I 
> can power on and power off.

So we can say "works as designed"?

> I'll investigate further when I get the chance, but can someone else test?  
> You don't even need a Bluetooth dive computer; just see if you can power 
> Bluetooth on or off through Subsurface, select the controller if you have 
> more than one, and scan and try to pair a device (e.g. your phone).

I'd still love to see more people test. Ideally someone with a Mac and some 
time to figure out what's going on there.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

I completely agree with you. We should make a new release.
It's all a matter of how much time I have to spend on Subsurface.

I think the current daily is quite stable and usable (and it has the cloud 
storage authentication errors fixed). But I'm not convinced that it has 
received enough testing - especially the changes to the preferences.

So if people could really take it through its paces and report issues 
here and on trac - that would help.

Here's a specific request for testing:

Go through the preferences. Check whether "Apply" does the right
thing. Check whether "Cancel" does the right thing. Check if the 
settings gets remembered correctly if you exit  and restart the app. 

Test downloading from divecomputers. Via cable, via Bluetooth.
Test FB integration.
Test the dive planner.
Read the user manual and point our discrepancies.

There is a LOT everyone can do to help make a release happen.

/D

> On Sep 19, 2016, at 9:48 AM, Adric Norris  wrote:
> 
> 
> I added a number of additional dives to my log over the weekend, and every 
> single attempt to save resulted in the "Authentication to cloud storage 
> failed" error. Checking https://cloud.subsurface-divelog.org/ 
>  strongly implied that the data was 
> saved successfully, but since I couldn't be sure that all of the details were 
> included (as the website doesn't display everything) I would then followup 
> with Save to cloud storage... a minimum of 2 attempts was required in each 
> case, before I was able to get a "clean" save. The network was solid and 
> fast, and no other applications were encountering any issues.
> 
> I don't mean to be a downer (and I fully understand that I'm not owed 
> anything here), but it seems to me that this bug should be worth a point 
> release. I've recommended Subsurface to several people, and the "ignore any 
> save errors... it's a known issue, and likely - but not definitively - a 
> false alarm" discussion gets awkward rather quickly.
> 
> 
> On Tue, Jul 12, 2016 at 8:25 PM, Adric Norris  > wrote:
> Is anyone else frequently seeing the following error when saving changes?
> 
> Authentication to cloud storage failed.
> Cannot sync with cloud server, working with offline copy.
> 
> While this sometimes seems to be legitimate, often the error is displayed 
> even though the changes appear to have been saved successfully. For example 
> I'll change the Notes text for a recent dive and save (File -> Save), which 
> triggers the error. I then look it up my dives on 
> https://cloud.subsurface-divelog.org , 
> and (frequently, but not always) find that the changed text is indeed 
> present. Attempting to save multiple times in a row or choosing "Save to 
> cloud storage" will sometimes complete without error, but it's very 
> inconsistent.
> 
> This has been going on for awhile but I'd been assuming it was an issue with 
> my home network, or notebook installation... I'm running Ubuntu 16.04 
> (Xenial), with Subsurface installed from the PPA. However I recently upgraded 
> Subsurface (from either 4.5.2 or 4.5.3, IIRC) on my sister's macbook while we 
> were visiting family, and she encountered the same stream of errors when 
> saving her first new dive... we ended up trying to save about 4 times, before 
> being confident all was well. Since the notebook, OS, and network were all 
> different, I now believe this to be a more general issue.
> 
> Any idea how I can help to troubleshooting the issue? I'm happy to do 
> whatever I can, but am not really sure where to begin.
> 
> Thanx!
> 
> -- 
> "In the beginning the Universe was created. This has made a lot of people 
> very angry and been widely regarded as a bad move." -Douglas Adams
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

Hi Pedro

> On Sep 19, 2016, at 10:35 AM, Pedro Neves  wrote:
> 
> Hi Dirk:
> 
> Using the latest master (compiled on my Arch box), I get:
> 
> On 19-09-2016 18:20, Dirk Hohndel wrote:
>> Here's a specific request for testing:
>> 
>> Go through the preferences. Check whether "Apply" does the right
> 
> It does.
> 
>> thing. Check whether "Cancel" does the right thing.
> 
> It does.
> 
>> Check if the
>> settings gets remembered correctly if you exit  and restart the app.
> 
> No. If I change the language to Portuguese and press save and restart 
> Subsurface, the language remains in English.
> If I change the units (from personalize to imperial) I get a warning about 
> the need to restart subsurface in order to change the language!. After I 
> close the program and restart, the units are still the original.

Ah. That's a problem. I should have time to look at this tonight (or tomorrow 
night... not quite done for the day, yet)

Thanks!

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile 1.0.5 (4.5.2.1569) crashes

[Dirk Hohndel]

> On Sep 20, 2016, at 3:03 AM, Henrik Brautaset Aronsen  wrote:
> 
> Steps to reproduce:
> 
> - Clear all Subsurface application storage & caches
> - Start Subsurface and add cloud credentials
> - It starts reading from git, and crashes around 20%

So this is triggered by your data. And the backtrace isn't really telling me 
much:

09-20 10:56:55.320 27360 27376 F libc: Fatal signal 11 (SIGSEGV), code 1, 
fault addr 0x0 in tid 27376 (QtThread)
09-20 10:56:55.383   641   641 D clmlib  : Got activities:0x000E
09-20 10:56:55.394   641   641 F DEBUG   : *** *** *** *** *** *** *** *** *** 
*** *** *** *** *** *** ***
09-20 10:56:55.403   641   641 F DEBUG   : UUID: 
207e2fc8-d8f2-45d3-b27a-3ecb3289b097
09-20 10:56:55.403   641   641 F DEBUG   : Build fingerprint: 
'Sony/E5823/E5823:6.0.1/32.2.A.0.253/2701308494:user/release-keys'
09-20 10:56:55.403   641   641 F DEBUG   : Revision: '0'
09-20 10:56:55.403   641   641 F DEBUG   : ABI: 'arm'
09-20 10:56:55.404   641   641 F DEBUG   : pid: 27360, tid: 27376, name: 
QtThread  >>> org.subsurfacedivelog.mobile <<<
09-20 10:56:55.404   641   641 F DEBUG   : signal 11 (SIGSEGV), code 1 
(SEGV_MAPERR), fault addr 0x0
09-20 10:56:55.448   641   641 F DEBUG   : r0   r1 aca308a0  r2 
  r3 
09-20 10:56:55.449   641   641 F DEBUG   : r4 aca30168  r5 0002  r6 
  r7 
09-20 10:56:55.449   641   641 F DEBUG   : r8 df7cc8ac  r9   sl 
df7cc8bc  fp df7cc8b0
09-20 10:56:55.449   641   641 F DEBUG   : ip aca308a0  sp df7cc870  lr 
dfae6833  pc f738c7a4  cpsr a00e0010
09-20 10:56:55.453   641   641 F DEBUG   : 
09-20 10:56:55.453   641   641 F DEBUG   : backtrace:
09-20 10:56:55.453   641   641 F DEBUG   : #00 pc 000177a4  
/system/lib/libc.so (strcmp+48)
09-20 10:56:55.453   641   641 F DEBUG   : #01 pc 0011882f  
/data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so
09-20 10:56:55.453   641   641 F DEBUG   : #02 pc 0014cbdd  
/data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so 
(call_for_each_dc+384)
09-20 10:56:55.453   641   641 F DEBUG   : #03 pc 00124229  
/data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so
09-20 10:56:55.454   641   641 F DEBUG   : #04 pc 0012572d  
/data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so
09-20 10:56:55.454   641   641 F DEBUG   : #05 pc 00124621  
/data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so
09-20 10:56:55.454   641   641 F DEBUG   : #06 pc 00125f3d  
/data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so
09-20 10:56:55.454   641   641 F DEBUG   : #07 pc 001d8298  
/data/app/org.subsurfacedivelog.mobile-2/lib/arm/libsubsurface-mobile.so

> If I try starting Subsurface again, it crashes after a few seconds (while 
> still on the splash screen).

Likely it's reading the same data from git cache and crashes again.

Ok, looking at the two symbols that I see in the stack trace I am now guessing
that dc_match_serial is crashing for you. Let me see if I can add some 
protection
to not dereference NULL pointers in there.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Push Subsurface-daily to OBS

[Dirk Hohndel]

Looks like you fixed something on OBS a while ago and my script was too dumb to
realize that and it failed with a conflict. And since I don't look at OBS (or 
launchpad) 
anymore, I never noticed.

Pushed.

I see on the OBS website that there are some issue (Fedora 24 has an 
unresolvable
error, the armv6l build is blocked). Not sure if you want to look into that. 
I'm happy
to just focus on the AppImage (which of course won't help on arm)

/D


> On Sep 20, 2016, at 1:25 AM, Guillaume Gardet  
> wrote:
> 
> Hi Dirk,
> 
> could you please push the latest Subsurface-daily to OBS, please?
> 
> I think you have some scripts around for that.
> 
> 
> Guillaume
> 
> 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile 1.0.5 (4.5.2.1569) crashes

[Dirk Hohndel]

> On Sep 20, 2016, at 7:57 AM, Dirk Hohndel  wrote:
> 
> 
>> On Sep 20, 2016, at 3:03 AM, Henrik Brautaset Aronsen  
>> wrote:
>> 
>> Steps to reproduce:
>> 
>> - Clear all Subsurface application storage & caches
>> - Start Subsurface and add cloud credentials
>> - It starts reading from git, and crashes around 20%
> 
> Ok, looking at the two symbols that I see in the stack trace I am now guessing
> that dc_match_serial is crashing for you. Let me see if I can add some 
> protection
> to not dereference NULL pointers in there.

Henrik, can you download -1605 from downloads daily and try that?
I may have completely mis-guessed the backtrace, but on the flip side,
maybe I fixed it :-)

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

> On Sep 20, 2016, at 9:00 AM, John Smith  wrote:
> 
> Running 4.5.2-1600 on Windows 10
> 
> The SHARE ON button goes blue in clicking but doesn't open a window.

You mean the menu entry? That's where the FB export is 
supposed to be. Hmm. I'll look into that.

> Every time I try to import a csv file from my ccr using the import log files, 
> subsurface crashes.

Can you send one of those CSV files to the mailing list. 
Miika, our resident import expert will hopefully be able to 
see what's going on.

> Language always shows Bulgarian rather than English.

That could be a disappointment if you don't speak Bulgarian. 
I don't see that here but there's clearly something broken 
with the language switching. I'll look at that as well.

> If you do anything on the language page, it always gives a 'to use new 
> language' message even if you are changing time settings.

I was able to reproduce that but haven't quite figured out 
why. I'm sure it's related to the previous issue.

> What does the greyed out 'take cloud storage online' in the file menu do?

If you have errors connecting Subsurface switches you into 
offline mode. Assuming you fixed your network issues, with 
this entry you can go back online. But of course it's grayed 
out unless you have such an error. You should be able to test 
this by turning off wireless, trying to connect, waiting for it to 
time-out / fail, then turning on wireless and using this option... 
I'd be interested if this still works (I wrote this while on a dive 
boat without internet...)

Thank you so much for the testing and all the feedback. I 
clearly haven't used the Windows build in quite a while.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile 1.0.5 (4.5.2.1569) crashes

[Dirk Hohndel]

On Tue, Sep 20, 2016 at 09:11:21AM -0700, Linus Torvalds wrote:
> On Tue, Sep 20, 2016 at 9:10 AM, Linus Torvalds
>  wrote:
> >
> > Maybe something like this. You probably already did the dc_match_serial() 
> > part.
> 
> And by "probably", I mean "hopefully", since I had a missing "||" in
> my untested patch there.

I had already done that, I just finished building -1606 which is now
available for download.

Henrik, please test that one instead.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile 1.0.5 (4.5.2.1569) crashes

[Dirk Hohndel]

> On Sep 20, 2016, at 10:51 AM, Henrik Brautaset Aronsen  
> wrote:
> 
> 20. sep. 2016 18.30 skrev "Dirk Hohndel"  <mailto:d...@hohndel.org>>:
> >
> > I had already done that, I just finished building -1606 which is now
> > available for download.
> >
> > Henrik, please test that one instead.
> 
> It works! Thanks :)
> 
> All of these dives were imported from a single MacDive XML export. So that 
> importer might lack something.
> 

It looks like the dive computer model didn’t get filled in.

/D


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Build problem

[Dirk Hohndel]

On Tue, Sep 20, 2016 at 09:14:07PM +0200, Robert C. Helling wrote:
> Willem,
> 
> > Am 20.09.2016 um 21:06 schrieb Willem Ferguson 
> > :
> > 
> > Some finger trouble on my side here. What is the appropriate response?
> 
> There were some updates to libdivecomputer. I guess you need to run the build 
> script again. 

Yes, I mentioned this a day or two ago. We had changes in both the
Subsurface-branch of libdivecomputer and master of Subsurface that depend
on each other. So if you update one, you need to update the other.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

On Tue, Sep 20, 2016 at 09:09:03AM -0700, Dirk Hohndel wrote:
> 
> > Language always shows Bulgarian rather than English.
> 
> That could be a disappointment if you don't speak Bulgarian. 
> I don't see that here but there's clearly something broken 
> with the language switching. I'll look at that as well.
> 
> > If you do anything on the language page, it always gives a 'to use new 
> > language' message even if you are changing time settings.
> 
> I was able to reproduce that but haven't quite figured out 
> why. I'm sure it's related to the previous issue.

I rewrote that part of the new preferences code.

Can you please check it again (new binaries (-1612) have just been
uploaded). This seems to work for me, now (but I didn't have a chance to
test Windows).

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface mobile iOS 1.1.1

[Dirk Hohndel]

> On Sep 21, 2016, at 6:20 AM, John Smith  wrote:
> 
> The dive site in the top blue bar and the dive details don't always match.
> 
> 
> 
> It was fine a few days ago, it's only 're' appeared today.

I wish I knew what triggered this. It's a kirigami function that should get us 
the correct title.
I'll need to see if I can reproduce this here and track it down.

Thanks for the report

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: more unittests for preferences.

[Dirk Hohndel]

On Wed, Sep 21, 2016 at 01:23:04PM -0300, Tomaz Canabrava wrote:
> I'm on my last two days in brazil, things here are *crazy* right now.
> My next patch will be from munich - probably in a mini-hackaton with
> robert. :)

I love patches that add tests that fail :-)

Now I need to figure out WHY it fails and whether that means the test is
wrong or it actually identified an issue.

(and I also need to figure out what's going on with the parsing test)

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: more unittests for preferences.

[Dirk Hohndel]

On Wed, Sep 21, 2016 at 09:44:55AM -0700, Dirk Hohndel wrote:
> On Wed, Sep 21, 2016 at 01:23:04PM -0300, Tomaz Canabrava wrote:
> > I'm on my last two days in brazil, things here are *crazy* right now.
> > My next patch will be from munich - probably in a mini-hackaton with
> > robert. :)
> 
> I love patches that add tests that fail :-)
> 
> Now I need to figure out WHY it fails and whether that means the test is
> wrong or it actually identified an issue.

Umm. Tomaz, did you even run your tests?


diff --git a/tests/testpreferences.cpp b/tests/testpreferences.cpp
index 72ea73f88c63..14a40cb81277 100644
--- a/tests/testpreferences.cpp
+++ b/tests/testpreferences.cpp
@@ -61,7 +61,7 @@ void TestPreferences::testPreferences()
// Why this is short and not bool?
cloud->setSaveUserIdLocal(1);
TEST(cloud->saveUserIdLocal(), (short)1);
-   cloud->setSavePasswordLocal(0);
+   cloud->setSaveUserIdLocal(0);
TEST(cloud->saveUserIdLocal(), (short)0);
 
cloud->setUserId("Tomaz");
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

> On Sep 20, 2016, at 9:00 AM, John Smith  wrote:
> 
> Running 4.5.2-1600 on Windows 10
> 
> The SHARE ON button goes blue in clicking but doesn't open a window.

That should work now with the -1619 build. I even tested it on Windows (crazy, 
I know).

> Every time I try to import a csv file from my ccr using the import log files, 
> subsurface crashes.

I didn't notice that you had sent the test file just to me, I just forwarded it 
to Miika.

> Language always shows Bulgarian rather than English.

That should also be fixed in -1619

> If you do anything on the language page, it always gives a 'to use new 
> language' message even if you are changing time settings.

Ditto.

BUT: while setting the language works fine now on Linux, it's still not working 
on Windows and I don't quite understand why.

I'd appreciate if you could verify all this (and more testing would be 
extremely welcome, too) :-)

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

> On Sep 22, 2016, at 9:24 PM, Dirk Hohndel  wrote:
> 
> 
>> On Sep 20, 2016, at 9:00 AM, John Smith  wrote:
>> 
>> Running 4.5.2-1600 on Windows 10
>> 
>> The SHARE ON button goes blue in clicking but doesn't open a window.
> 
> That should work now with the -1619 build. I even tested it on Windows 
> (crazy, I know).

Replaced by -1620

>> Every time I try to import a csv file from my ccr using the import log 
>> files, subsurface crashes.
> 
> I didn't notice that you had sent the test file just to me, I just forwarded 
> it to Miika.
> 
>> Language always shows Bulgarian rather than English.
> 
> That should also be fixed in -1619
> 
>> If you do anything on the language page, it always gives a 'to use new 
>> language' message even if you are changing time settings.
> 
> Ditto.
> 
> BUT: while setting the language works fine now on Linux, it's still not 
> working on Windows and I don't quite understand why.

-1620 fixes this on Windows as well.

> I'd appreciate if you could verify all this (and more testing would be 
> extremely welcome, too) :-)

Still true. And please - not just John - we really need more people to test.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

It seems like I continue to have problems getting the libssh2 situation under 
control. Sorry about that, will try to create a new DMG shortly.

/D


> On Sep 23, 2016, at 8:42 AM, Martin de Weger  wrote:
> 
> Hi, 
> 
> I downloaded the daily build for the Mac and Installed it as an update on my 
> macbook running MacOS Sierra. The program wouldn’t start, It crashes 
> directly...
> 
> Kind regards,
> 
> Martin de Weger
> 
>> Op 23 sep. 2016, om 10:16 heeft Adric Norris > <mailto:landstander...@gmail.com>> het volgende geschreven:
>> 
>> I spent some time with the Windows build of -1620, and it does indeed appear 
>> to have fixed all of the cloud connectivity errors. I haven't noticed any 
>> issues with preference changes either.
>> 
>> Is there a Linux build available? My notebook isn't really up to the task of 
>> building from source, and I don't see anything at 
>> https://subsurface-divelog.org/downloads/daily/ 
>> <https://subsurface-divelog.org/downloads/daily/>.
>> 
>> On Fri, Sep 23, 2016 at 12:21 AM, Dirk Hohndel > <mailto:d...@hohndel.org>> wrote:
>> 
>> > On Sep 22, 2016, at 9:24 PM, Dirk Hohndel > > <mailto:d...@hohndel.org>> wrote:
>> >
>> >
>> >> On Sep 20, 2016, at 9:00 AM, John Smith > >> <mailto:nosey...@hotmail.com>> wrote:
>> >>
>> >> Running 4.5.2-1600 on Windows 10
>> >>
>> >> The SHARE ON button goes blue in clicking but doesn't open a window.
>> >
>> > That should work now with the -1619 build. I even tested it on Windows 
>> > (crazy, I know).
>> 
>> Replaced by -1620
>> 
>> >> Every time I try to import a csv file from my ccr using the import log 
>> >> files, subsurface crashes.
>> >
>> > I didn't notice that you had sent the test file just to me, I just 
>> > forwarded it to Miika.
>> >
>> >> Language always shows Bulgarian rather than English.
>> >
>> > That should also be fixed in -1619
>> >
>> >> If you do anything on the language page, it always gives a 'to use new 
>> >> language' message even if you are changing time settings.
>> >
>> > Ditto.
>> >
>> > BUT: while setting the language works fine now on Linux, it's still not 
>> > working on Windows and I don't quite understand why.
>> 
>> -1620 fixes this on Windows as well.
>> 
>> > I'd appreciate if you could verify all this (and more testing would be 
>> > extremely welcome, too) :-)
>> 
>> Still true. And please - not just John - we really need more people to test.
>> 
>> /D
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org <mailto:subsurface@subsurface-divelog.org>
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface 
>> <http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface>
>> 
>> 
>> 
>> -- 
>> "In the beginning the Universe was created. This has made a lot of people 
>> very angry and been widely regarded as a bad move." -Douglas Adams
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org <mailto:subsurface@subsurface-divelog.org>
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
> 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

Please try the -1620 DMG. That one should work.

/D

> On Sep 23, 2016, at 11:57 AM, Dirk Hohndel  wrote:
> 
> It seems like I continue to have problems getting the libssh2 situation under 
> control. Sorry about that, will try to create a new DMG shortly.
> 
> /D
> 
> 
>> On Sep 23, 2016, at 8:42 AM, Martin de Weger > <mailto:mar...@reef-it.nl>> wrote:
>> 
>> Hi, 
>> 
>> I downloaded the daily build for the Mac and Installed it as an update on my 
>> macbook running MacOS Sierra. The program wouldn’t start, It crashes 
>> directly...
>> 
>> Kind regards,
>> 
>> Martin de Weger
>> 
>>> Op 23 sep. 2016, om 10:16 heeft Adric Norris >> <mailto:landstander...@gmail.com>> het volgende geschreven:
>>> 
>>> I spent some time with the Windows build of -1620, and it does indeed 
>>> appear to have fixed all of the cloud connectivity errors. I haven't 
>>> noticed any issues with preference changes either.
>>> 
>>> Is there a Linux build available? My notebook isn't really up to the task 
>>> of building from source, and I don't see anything at 
>>> https://subsurface-divelog.org/downloads/daily/ 
>>> <https://subsurface-divelog.org/downloads/daily/>.
>>> 
>>> On Fri, Sep 23, 2016 at 12:21 AM, Dirk Hohndel >> <mailto:d...@hohndel.org>> wrote:
>>> 
>>> > On Sep 22, 2016, at 9:24 PM, Dirk Hohndel >> > <mailto:d...@hohndel.org>> wrote:
>>> >
>>> >
>>> >> On Sep 20, 2016, at 9:00 AM, John Smith >> >> <mailto:nosey...@hotmail.com>> wrote:
>>> >>
>>> >> Running 4.5.2-1600 on Windows 10
>>> >>
>>> >> The SHARE ON button goes blue in clicking but doesn't open a window.
>>> >
>>> > That should work now with the -1619 build. I even tested it on Windows 
>>> > (crazy, I know).
>>> 
>>> Replaced by -1620
>>> 
>>> >> Every time I try to import a csv file from my ccr using the import log 
>>> >> files, subsurface crashes.
>>> >
>>> > I didn't notice that you had sent the test file just to me, I just 
>>> > forwarded it to Miika.
>>> >
>>> >> Language always shows Bulgarian rather than English.
>>> >
>>> > That should also be fixed in -1619
>>> >
>>> >> If you do anything on the language page, it always gives a 'to use new 
>>> >> language' message even if you are changing time settings.
>>> >
>>> > Ditto.
>>> >
>>> > BUT: while setting the language works fine now on Linux, it's still not 
>>> > working on Windows and I don't quite understand why.
>>> 
>>> -1620 fixes this on Windows as well.
>>> 
>>> > I'd appreciate if you could verify all this (and more testing would be 
>>> > extremely welcome, too) :-)
>>> 
>>> Still true. And please - not just John - we really need more people to test.
>>> 
>>> /D
>>> ___
>>> subsurface mailing list
>>> subsurface@subsurface-divelog.org <mailto:subsurface@subsurface-divelog.org>
>>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface 
>>> <http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface>
>>> 
>>> 
>>> 
>>> -- 
>>> "In the beginning the Universe was created. This has made a lot of people 
>>> very angry and been widely regarded as a bad move." -Douglas Adams
>>> ___
>>> subsurface mailing list
>>> subsurface@subsurface-divelog.org <mailto:subsurface@subsurface-divelog.org>
>>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface 
>>> <http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface>
>> 
> 
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

> On Sep 23, 2016, at 7:16 AM, Adric Norris  wrote:
> 
> I spent some time with the Windows build of -1620, and it does indeed appear 
> to have fixed all of the cloud connectivity errors. I haven't noticed any 
> issues with preference changes either.

Good. Thanks for testing

> Is there a Linux build available? My notebook isn't really up to the task of 
> building from source, and I don't see anything at 
> https://subsurface-divelog.org/downloads/daily/ 
> .

There's now a new AppImage for -1620. That should run on most semi-recent Linux 
systems.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

> On Sep 24, 2016, at 5:41 AM, Steve  wrote:
> 1620 tested Bluetooth with DiveSystems ix3m reb and HW OSTC3+ On windows both 
> download dives well.

Thank you. That's excellent news!

We may indeed be on our way towards a 4.6 release. Finally.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

I saw Miika's response but let me add a few remarks

> On Sep 24, 2016, at 6:07 AM, Werner Macho  wrote:
> 
> Hi!
> 
> I'd really like to help with testing (Owning a OSTC Sport with
> bluetooth) but somehow I can only get the "stable" versions to run.
> 
> So no testing with development version. :(
> 
> Maybe it's me using debian stable as OS (Qt 5.3.2). But I cannot compile
> current master nor v4.5-branch using debian stable using the
> scripts/build.sh.

I'm always amused by Debian Antiques (aka stable). 5.3.2 is just a bit over two
years old... I /think/ we should still build with it, but I don't think anyone 
cares.

> [ 42%] Building CXX object
> core/CMakeFiles/subsurface_corelib.dir/qthelper.cpp.o
> In file included from
> /home/macho/dev/cpp/subsurface/subsurface/./desktop-widgets/mainwindow.h:16:0,
> from
> /home/macho/dev/cpp/subsurface/subsurface/qt-models/filtermodels.cpp:8:
> /home/macho/dev/cpp/subsurface/subsurface/build/ui_mainwindow.h:24:32:
> fatal error: notificationwidget.h: No such file or directory
> #include "notificationwidget.h"


The ui_* files sometimes get out of sync. I'd suggest removing your build
directory completely and starting again


But... as Miika said, unless you want to send me patches, compiling from source
isn't really necessary. I really appreciate it if people actually test the same 
binaries
that our "regular users" will use, which in case of Linux is mostly going to be 
the
AppImage.

> I can also test on Windows 10 but .. I can only find the "normal"
> "subsurface-4.5.6.exe" on the homepage.

http://subsurface-divelog.org/downloads/daily

> But I am more than willing to help testing (also on android).
> (Doing a diving trip in the beginning of october to Cairns.)

Yes, that's so generous of you to force yourself to Cairns, JUST to help
out. And testing of all three platforms (Linux, Windows, Android) is very,
very appreciated.

> Any hints for me how I can help in the best way?

Testing. And reading the user manual and providing feedback where it
doesn't match the current user experience.

Thanks so much!

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

DivelogImportDialog

[Dirk Hohndel]

Miika,

Can you take a look at the DivelogImportDialog for me? This code worries
me:

int DiveLogImportDialog::parseTxtHeader(QString fileName, char **params, int 
pnr)
{
QFile f(fileNames.first());

(and fileName is unused in the function)

The only two call sites of parseTxtHeader look like this:

pnr = parseTxtHeader(fileNames[i], params, pnr);

So the caller seems to think that the parseTxtHeader function will use
item number 'i' in the array of fileNames, but instead the function
ignores the parameter and always uses the first entry.

git blame tells me that you wrote this :-)

Thanks

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release

[Dirk Hohndel]

Hi John,

Thanks for all the testing!

> On Sep 24, 2016, at 8:38 AM, John Smith  wrote:
> 
> Windows 4.5.2.1620
> 
> Serial download from sunnto d4i - ok
> Bluetooth download from shearwater petrel 2 - ok
> Csv import - ok

Nice!

> Facebook integration is a little iffy. The connect to Facebook seems to work 
> then shows a 'to disconnect from Facebook click on button below' window - 
> there's no button. 
> I also can't upload a dive successfully.

Hrmpf. A killer feature that many people asked for and very very few people 
appear to ever use.
The disconnect message confusion should be easy to fix. The inability to upload 
is much more concerning. If you run this from a cmd.exe, are there any warnings 
on the console?

> Upload to dive logs.de works well.

Excellent.

Time permitting I'm hoping to cut a first Beta today. So please everyone keep 
testing!

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

towards 4.6 Beta 1

[Dirk Hohndel]

I just pushed a first attempt at ReleaseNotes out. I would love it if
people could add things that I'm forgetting. Given the 1600+ changes (with
the changes for Subsurface-mobile drowning out the ones for the desktop
version) it's a little hard to keep track ;-)

As I was playing around I noticed that

a) I can't seem to turn off dive computer reported ceiling (from the toolbar)
b) I can't seem to turn on the tissue / heat map; space is made on the
   profile for it, but nothing is drawn.

I wonder what else is broken still. So please, please keep testing, play
with all the knobs, buttons, menus, command line options, etc.

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: towards 4.6 Beta 1

[Dirk Hohndel]

On Sat, Sep 24, 2016 at 09:39:53AM -0700, Dirk Hohndel wrote:
> I just pushed a first attempt at ReleaseNotes out. I would love it if
> people could add things that I'm forgetting. Given the 1600+ changes (with
> the changes for Subsurface-mobile drowning out the ones for the desktop
> version) it's a little hard to keep track ;-)
> 
> As I was playing around I noticed that
> 
> a) I can't seem to turn off dive computer reported ceiling (from the toolbar)

I found and fixed that. This all happened when we untangled the Profile
code from the MainWindow (i.e., ages ago). Makes me think that no one ever
toggles this switch :-)

> b) I can't seem to turn on the tissue / heat map; space is made on the
>profile for it, but nothing is drawn.

Similar issue.

And oh, by the way. We need some decent explanation of what exactly this
visualizes :-)

-1630 has been pushed, daily builds for Windows, Mac, and Linux have been
uploaded.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: towards 4.6 Beta 1

[Dirk Hohndel]

> On Sep 24, 2016, at 1:57 PM, Rick Walsh  wrote:
> > > b) I can't seem to turn on the tissue / heat map; space is made on the
> > >profile for it, but nothing is drawn.
> >
> I noticed that yesterday on the Windows build.  But after opening the planner 
> after turning on the heat map it worked. Maybe it needs to be redrawn on 
> changing the setting
> 

Should also be fixed in the latest build :-)

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

On Sun, Sep 25, 2016 at 07:46:00AM -0400, Martin de Weger wrote:
> It looks if the default computer is no longer stored in the daily build.
> Before I updated to the daily build, my dive computer in the import
> function was always the computer I have. In the daily build it is the
> first model of the first brand in the list.

Fixed in latest master.

Preferences work best if we don't just write them but read them as well.
:-(

Thanks again for all the testing. Please keep the bug reports coming. I'd
rather fix the bugs BEFORE we do the next release :-)

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Next release [was Re: Frequent cloud storage authentication errors with Subsurface 4.5.6 (desktop)]

[Dirk Hohndel]

> On Sep 25, 2016, at 12:05 PM, John Smith  wrote:
> 
> I have a dive with three dive computers in it. If I turn on the n2 toggle, 
> the N2 graph appears below the tissue graph and therefore off screen. If I 
> flick to the second dc and then back, the n2 graph is visible and above the 
> tissue graph. - I'll get a couple of screen shots to show this properly

Oh joy. More mess with settings.

The amount of pain this “cleanup” has created is beyond ridiculous.

> Should the toggle all tissues and toggle calculated ceiling in 3m intervals 
> work even if the toggle calculated ceiling is off?

They have always been enabled (and just not had any visual impact). But it 
would be smarter to just hide them, I guess.
Not sure this is something I want to tackle for 4.6 given the mountain of other 
stuff that used to work and is now broken.

> The toggle photos requires you to click, then choose another dive, and then 
> returning to original dive before it shows the photos

Yet another case where a change to settings doesn’t trigger the appropriate 
level of redrawing.

Thanks for all the testing. I really appreciate it. It’s good to find these 
things before we make a public beta.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

BT on Mac

[Dirk Hohndel]

So we now have a few reports that this isn’t working anymore…
I can reproduce things here but have no clue how to fix it.

First I get this error

QObject::connect: Cannot queue arguments of type 'QBluetoothServiceInfo'
(Make sure 'QBluetoothServiceInfo' is registered using qRegisterMetaType().)

which appears to be caused by this code in qtserialbluetooth:

#elif defined(Q_OS_ANDROID) || (QT_VERSION >= 0x050500 && defined(Q_OS_MAC))
// Try to connect to the device using the uuid of the Serial Port 
Profile service
QBluetoothAddress remoteDeviceAddress(devaddr);
serial_port->socket->connectToService(remoteDeviceAddress, 
QBluetoothUuid(QBluetoothUuid::SerialPort));
timer.start(msec);
loop.exec();

(I’m running against Qt5.5)
And then I get this error:

Failed to connect to device  00:13:43:0D:2B:30 . Device state  
QBluetoothSocket::UnconnectedState . Error:  
QBluetoothSocket::ServiceNotFoundError
[1.525499] ERROR: Failed to open the serial port. [in 
../../src/shearwater_common.c:47 (shearwater_common_open)]

which happens just a few lines below:

if (serial_port->socket->state() != QBluetoothSocket::ConnectedState) {
// Get the latest error and try to match it with one from 
libdivecomputer
QBluetoothSocket::SocketError err = 
serial_port->socket->error();
qDebug() << "Failed to connect to device " << devaddr << ". 
Device state " << serial_port->socket->state() << ". Error: " << err;

So it does seem like the “connectToService” fails.

Any ideas?

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Re: towards 4.6 Beta 1

[Dirk Hohndel]

On Wed, Sep 28, 2016 at 01:14:19PM +1000, Rick Walsh wrote:
> 
> Sorry, I accidentally sent the patch twice.  One as an attachment, one with
> git send-email.  They are exactly the same

No problem. I appreciate the patch :-)

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

binaries for Beta 1

[Dirk Hohndel]

In downloads/daily are Linux/Mac/Windows binaries for 4.6 Beta 1.

I'd appreciate if people could give them some more testing. I haven't
pushed the tag, yet, so if we find anything stupid we can still fix it
before I officially release Beta 1 :-)

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: binaries for Beta 1

[Dirk Hohndel]

On Mon, Oct 03, 2016 at 09:31:03PM +0200, Robert Helling wrote:
> Dear friends,
> 
> > Am 03.10.2016 um 18:06 schrieb Robert C. Helling 
> > :
> > 
> > I have three patches on my laptop, one of which is a bugfix.  Will send 
> > tonight with proper internet connection. Hold the horses.
> 
> back home, so here we go:
> 
> 
> 
> These three patches are of different character:
> 
> There is no 0001.
> 
> 0002 is something I hacked so I can switch between Buehlmann and VPM-B
> from the preferences (rather than just from the planner). It is a bit
> rough (and should also grey out those preferences which do not apply to
> the active model, to be added later). We should have something like
> this, but this patch might need a bit more work and Tomaz promised
> something along these lines anyway.

So this should wait until after Beta 1?

> 0003 fixes a bug with the heat map when using VPM-B. The scale for the
> colors is set by the Buehlmann m-value, so we need to compute that even
> when not using Buehlmann. Yesterday, his bug was found by Willem.

This I'll look at and push now, before Beta 1

> 0004 is a stub for a CFD: Sometime ago, before starting with our
> template based printing, I had submitted some patches to print via TeX.
> Those were turned down because we don’t want to add TeX as a dependency,
> which I can understand. For my own use to print paper logbook pages, I
> kept rebasing this branch and use it for my own build. Now, I realized I
> presented this in the wrong way: This is not about printing. This should
> be presented as another file format we export to. There is no dependency
> to anything, this just writes a text file with data from the dive in the
> form of TeX macros. This can then be used to print out the dive, but
> only if the user wants to. So, philosophically, this is like many of the
> other exports: Those make only sense to use if the user has the other
> thing to reimport the data. This patch is only a stub with no real
> functionality (it exports only the dive number). The actual code to
> write TeX, I did not have with me when I wrote this earlier today on a
> train, but I will add this tomorrow if I don’t hear strong opinions to
> the opposite.

That makes sense to me. I guess I should just take this as well assuming
it doesn't break any existing functionality...

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: binaries for Beta 1

[Dirk Hohndel]

So I'm not opposed to adding this... but reading the code I can't help but
feel that this is a bit incomplete...

On Mon, Oct 03, 2016 at 09:31:03PM +0200, Robert Helling wrote:
> 
> diff --git a/desktop-widgets/divelogexportdialog.cpp 
> b/desktop-widgets/divelogexportdialog.cpp
> index 5b58d0c..395c494 100644
> --- a/desktop-widgets/divelogexportdialog.cpp
> +++ b/desktop-widgets/divelogexportdialog.cpp
> @@ -86,6 +86,8 @@ void DiveLogExportDialog::showExplanation()
>   ui->description->setText(tr("Subsurface native XML format."));
>   } else if (ui->exportImageDepths->isChecked()) {
>   ui->description->setText(tr("Write depths of images to file."));
> + } else if (ui->exportTeX->isChecked()) {
> + ui->description->setText(tr("Write dive as TeX macros to 
> file."));
>   }
>  }
>  
> @@ -162,6 +164,10 @@ void DiveLogExportDialog::on_buttonBox_accepted()
>   filename = QFileDialog::getSaveFileName(this, tr("Save 
> image depths"), lastDir);
>   if (!filename.isNull() && !filename.isEmpty())
>   export_depths(filename.toUtf8().data(), 
> ui->exportSelected->isChecked());
> + } else if (ui->exportTeX->isChecked()) {
> + filename = QFileDialog::getSaveFileName(this, 
> tr("Export to TeX file"), lastDir, tr("TeX files(*.tex)"));
> + if (!filename.isNull() && !filename.isEmpty())
> + export_TeX(filename.toUtf8().data(), 
> ui->exportSelected->isChecked());
>   }
>   break;
>   case 1:

OK, so we add the UI handling

> @@ -223,3 +229,30 @@ void DiveLogExportDialog::export_depths(const char 
> *filename, const bool selecte
>   }
>   free_buffer(&buf);
>  }
> +
> +void DiveLogExportDialog::export_TeX(const char *filename, const bool 
> selected_only)
> +{
> + FILE *f;
> + struct dive *dive;
> + depth_t depth;
> + int i;
> + const char *unit = NULL;
> +
> + struct membuffer buf = {};
> +
> + for_each_dive (i, dive) {
> + if (selected_only && !dive->selected)
> + continue;
> +
> + put_format(&buf, "\\number{%d}\n", dive->number);
> + }
> +
> + f = subsurface_fopen(filename, "w+");
> + if (!f) {
> + report_error(tr("Can't open file %s").toUtf8().data(), 
> filename);
> + } else {
> + flush_buffer(&buf, f); /*check for writing errors? */
> + fclose(f);
> + }
> + free_buffer(&buf);
> +}

We write the dive numbers.

> diff --git a/desktop-widgets/divelogexportdialog.h 
> b/desktop-widgets/divelogexportdialog.h
> index e7cde31..5d5ad14 100644
> --- a/desktop-widgets/divelogexportdialog.h
> +++ b/desktop-widgets/divelogexportdialog.h
> @@ -33,6 +33,7 @@ private:
>   void showExplanation();
>   void exportHtmlInit(const QString &filename);
>   void export_depths(const char *filename, const bool selected_only);
> + void export_TeX(const char *filename, const bool selected_only);
>  };
>  
>  #endif // DIVELOGEXPORTDIALOG_H
> diff --git a/desktop-widgets/divelogexportdialog.ui 
> b/desktop-widgets/divelogexportdialog.ui
> index 4713bf0..d01f817 100644
> --- a/desktop-widgets/divelogexportdialog.ui
> +++ b/desktop-widgets/divelogexportdialog.ui
> @@ -192,6 +192,16 @@
> 
>
>
> +   
> +
> + TeX
> +
> +
> + exportGroup
> +
> +   
> +  
> +  
> 
>  
>   I&mage depths

Add the UI


Ummm. There is more TeX somewhere, right?

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Manual not matching current user experience - facebook

[Dirk Hohndel]

> On Oct 6, 2016, at 9:07 PM, John Smith  wrote:
> 
> 4.6 Beta 1 Windows 10
> 
> Whilst making sure that I wasnt doing anything stupid whilst trying the 
> facebook integration, I actually read the manual!

Good man

> The manual doesn't reflect the current menu setup etc on windows when trying 
> to upload to facebook. ie logging on facebook through Share On rather than 
> Preferences.

The manual hasn’t been updated, yet. Patches are welcome!

> On the same subject, is facebook integration likely to be fixed for 4.6?

It works for me (well, ok, there are some oddities and inconsistencies - but in 
principle it works).

I don’t know if someone will step up and look at it, my time right now is way 
too limited.

I’m still waiting for a bunch of patches from Tomaz, TBH.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH]Re: VPM-B and the heat map

[Dirk Hohndel]

On Tue, Oct 11, 2016 at 01:53:37PM +0200, Robert Helling wrote:
> Willem,
> 
> > Am 11.10.2016 um 13:32 schrieb Willem Ferguson 
> > :
> > 
> > Heat maps on images 1 and 3 not consistent.
> 
> this is a bug for which I sent a patch a couple of days ago. Apparently it 
> never made it to master, so resending…

It was applied - but I forgot to push :-(

Sorry

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: binaries for Beta 1

[Dirk Hohndel]

On Tue, Oct 04, 2016 at 12:18:37PM +1100, Rick Walsh wrote:
> Hi Dirk,
> 
> On 4 October 2016 at 06:43, Dirk Hohndel  wrote:
> 
> > On Mon, Oct 03, 2016 at 09:31:03PM +0200, Robert Helling wrote:
> > > Dear friends,
> > >
> > > > Am 03.10.2016 um 18:06 schrieb Robert C. Helling <
> > rob...@euve10195.vserver.de>:
> > > >
> > > > I have three patches on my laptop, one of which is a bugfix.  Will
> > send tonight with proper internet connection. Hold the horses.
> > >
> > > back home, so here we go:
> > >
> > >
> > >
> > > These three patches are of different character:
> > >
> > > There is no 0001.
> > >
> > > 0002 is something I hacked so I can switch between Buehlmann and VPM-B
> > > from the preferences (rather than just from the planner). It is a bit
> > > rough (and should also grey out those preferences which do not apply to
> > > the active model, to be added later). We should have something like
> > > this, but this patch might need a bit more work and Tomaz promised
> > > something along these lines anyway.
> >
> > So this should wait until after Beta 1?
> >
> 
> If you plan on releasing Beta 1 prior to Tomaz's promised preferences
> patches, can you include note that there are known bugs with pending
> fixes?  E.g. preference to switch between Buhlmann and VPM-B for profile
> display (patch by Robert or Tomaz), and not saving the planner settings (I
> believe there is a pending fix by Tomaz).

No, I'm still waiting for Tomaz to send these patches. Much as I'd like to
get the Beta out, it seems silly not to include fixes that apparently have
already been written and just not sent out, yet.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Facebook problem

[Dirk Hohndel]

Hi Edi,

Thanks for sending patches for this. Really appreciated.
I have some feedback for you that I'd love for you to take a look at...

On Sat, Oct 15, 2016 at 04:53:36AM +, Edi Anderson wrote:
> Hi guys, i saw the problem listed in bugtracker (#1101) and I am sending
> some patchs.

> From 49ecb1c6f3a07a3733c20b808433711c5ec7d420 Mon Sep 17 00:00:00 2001
> From: Edi Anderson Lobo 
> Date: Sat, 15 Oct 2016 00:33:08 -0300
> Subject: [PATCH 3/4] Changed message.
> 
> I changed the message of success on login with facebook.

This commit message and the patch that goes along with it don't seem to
match. All the patch does is add a new private method in the header
file...

> diff --git a/desktop-widgets/plugins/facebook/facebookconnectwidget.h 
> b/desktop-widgets/plugins/facebook/facebookconnectwidget.h
> index e970978..91208cd 100644
> --- a/desktop-widgets/plugins/facebook/facebookconnectwidget.h
> +++ b/desktop-widgets/plugins/facebook/facebookconnectwidget.h
> @@ -50,6 +50,10 @@ public:
>   SocialNetworkDialog(QWidget *parent = 0);
>   QString text() const;
>   QString album() const;
> +
> +private:
> +   void shallEnableCheckBoxes() ;

This has white space issues. We indent with TAB (see CodingStyle)

>  public slots:
>   void selectionChanged();
>   void albumChanged();

> From 50ccdba674498cec66d4beb9643f831cc6145088 Mon Sep 17 00:00:00 2001
> From: Edi Anderson Lobo 
> Date: Fri, 14 Oct 2016 23:49:06 -0300
> Subject: [PATCH 1/4] Checkbox disabled.
> 
> I disabled the checkbox to activate them during the runtime.
> So when the data associated with checkbox is not null, the
> checkbox is enabled. So null data will not be sent to facebook

[...]

This one looked good

> From 8a136d88089390d20ff6ea713e2e21140e012531 Mon Sep 17 00:00:00 2001
> From: Edi Anderson Lobo 
> Date: Sat, 15 Oct 2016 00:45:04 -0300
> Subject: [PATCH 4/4] Added validation.
> 
> Added an new method for validate the
> values to be sending for facebook.
> 
> Signed-off-by: Edi Anderson Lobo 
> ---
>  .../plugins/facebook/facebookconnectwidget.cpp | 78 
> ++
>  1 file changed, 50 insertions(+), 28 deletions(-)
> 
> diff --git a/desktop-widgets/plugins/facebook/facebookconnectwidget.cpp 
> b/desktop-widgets/plugins/facebook/facebookconnectwidget.cpp
> index e0d2aab..d976c45 100644
> --- a/desktop-widgets/plugins/facebook/facebookconnectwidget.cpp
> +++ b/desktop-widgets/plugins/facebook/facebookconnectwidget.cpp
> @@ -160,8 +160,9 @@ void FacebookManager::setDesiredAlbumName(const QString& 
> a)
>  void FacebookManager::sendDive()
>  {
>   SocialNetworkDialog dialog(qApp->activeWindow());
> - if (dialog.exec() != QDialog::Accepted)
> +if (dialog.exec() != QDialog::Accepted){

More whitespace issues - I know, this may seem silly, but please look at
CodingStyle regarding indentation and adding a space between ')' and '{'
here.

> @@ -237,10 +238,13 @@ FacebookConnectWidget::FacebookConnectWidget(QWidget 
> *parent) : QDialog(parent),
>  
>  void FacebookConnectWidget::facebookLoggedIn()
>  {
> - ui->fbWebviewContainer->hide();
> - ui->fbWebviewContainer->setEnabled(false);
> - ui->FBLabel->setText(tr("To disconnect Subsurface from your Facebook 
> account, use the button below"));
> -}
> +hide();
> +QMessageBox::information(this,
> +tr("Facebook Login"),
> +tr("Your loggin on Facebook was realized with sucess."),

I'm not a native speaker of English, either, but how about "You have
successfully logged into Facebook." ?

> @@ -268,6 +272,25 @@ SocialNetworkDialog::SocialNetworkDialog(QWidget 
> *parent) :
>   connect(ui->Location, SIGNAL(clicked()), this, 
> SLOT(selectionChanged()));
>   connect(ui->Notes, SIGNAL(clicked()), this, SLOT(selectionChanged()));
>   connect(ui->album, SIGNAL(textChanged(QString)), this, 
> SLOT(albumChanged()));
> +   shallEnableCheckBoxes();
> +}
> +
> +void SocialNetworkDialog::shallEnableCheckBoxes()
> +{
> +struct dive *d = current_dive;
> +   if(d != NULL){
> +ui->duration->setEnabled(true);
> +if (get_short_dive_date_string(d->when) != "" )
> +ui->date->setEnabled(true);
> +if (get_dive_location(d) != NULL)
> +ui->Location->setEnabled(true);
> +if (d->buddy != NULL)
> +ui->Buddy->setEnabled(true);
> +if (d->divemaster != NULL)
> +ui->Divemaster->setEnabled(true);
> +if ( d->notes != NULL)
> +ui->Notes->setEnabled(true);
> +   }

This all needs some whitespace love. I assume you are using some IDE?
Please ensure that it's set up to use TAB for indentation.

> @@ -279,27 +302,28 @@ void SocialNetworkDialog::albumChanged()
>  void SocialNetworkDialog::selectionChanged()
>  {
>   struct dive *d = current_dive;
> - QString fullText;
> - if (ui->date->isChecked()) {
> - fullText += tr("Dive date: %1 
> \n").arg(get_short_dive_date_string(d->when));
> - }
> - if (ui->duration->isChecked()) {
> -  

Re: unittests (untested)

[Dirk Hohndel]

Since this just adds tests (even though several fail) I have pushed it to
master.

/D

On Mon, Oct 17, 2016 at 06:30:20PM +0200, Tomaz Canabrava wrote:
> bunch of unittests (untested) to apply
> I'll run them and fix everything they might raise, and they are safe to
> merge as they don't introduce anything new, just test stuff.
> 
> I'm almost finishing the unittests -- finally.
> 
> Tomaz

> From 30342569081418cca547795ba278319b4fc0ad00 Mon Sep 17 00:00:00 2001
> From: Tomaz Canabrava 
> Date: Mon, 17 Oct 2016 17:50:55 +0200
> Subject: [PATCH 1/4] Tests for Units Preferences.
> 
> Signed-off-by: Tomaz Canabrava 
> ---
>  core/subsurface-qt/SettingsObjectWrapper.cpp |  4 ++-
>  tests/testpreferences.cpp| 37 
> 
>  2 files changed, 40 insertions(+), 1 deletion(-)
> 
> diff --git a/core/subsurface-qt/SettingsObjectWrapper.cpp 
> b/core/subsurface-qt/SettingsObjectWrapper.cpp
> index 009ca64..101e665 100644
> --- a/core/subsurface-qt/SettingsObjectWrapper.cpp
> +++ b/core/subsurface-qt/SettingsObjectWrapper.cpp
> @@ -1557,7 +1557,9 @@ int UnitsSettings::verticalSpeedTime() const
>  
>  QString UnitsSettings::unitSystem() const
>  {
> - return QString(); /*FIXME: there's no char * units on the prefs. */
> + return prefs.unit_system == METRIC ? QStringLiteral("metric")
> + : prefs.unit_system == IMPERIAL ? 
> QStringLiteral("imperial")
> + : QStringLiteral("personalized");
>  }
>  
>  bool UnitsSettings::coordinatesTraditional() const
> diff --git a/tests/testpreferences.cpp b/tests/testpreferences.cpp
> index 6847958..50389a0 100644
> --- a/tests/testpreferences.cpp
> +++ b/tests/testpreferences.cpp
> @@ -410,6 +410,43 @@ void TestPreferences::testPreferences()
>   TEST(planner->decoSac(),112);
>  
>   TEST(planner->decoMode(),RECREATIONAL);
> +
> + auto units = pref->unit_settings;
> + units->setLength(0);
> + units->setPressure(0);
> + units->setVolume(0);
> + units->setTemperature(0);
> + units->setWeight(0);
> + units->setVerticalSpeedTime(0);
> + units->setUnitSystem(QStringLiteral("metric"));
> + units->setCoordinatesTraditional(false);
> +
> + TEST(units->length(),0);
> + TEST(units->pressure(),0);
> + TEST(units->volume(),0);
> + TEST(units->temperature(),0);
> + TEST(units->weight(),0);
> + TEST(units->verticalSpeedTime(),0);
> + TEST(units->unitSystem(),QStringLiteral("metric"));
> + TEST(units->coordinatesTraditional(),false);
> +
> + units->setLength(1);
> + units->setPressure(1);
> + units->setVolume(1);
> + units->setTemperature(1);
> + units->setWeight(1);
> + units->setVerticalSpeedTime(1);
> + units->setUnitSystem(QStringLiteral("fake-metric-system"));
> + units->setCoordinatesTraditional(true);
> +
> + TEST(units->length(),1);
> + TEST(units->pressure(),1);
> + TEST(units->volume(),1);
> + TEST(units->temperature(),1);
> + TEST(units->weight(),1);
> + TEST(units->verticalSpeedTime(),1);
> + TEST(units->unitSystem(),QStringLiteral("personalized"));
> + TEST(units->coordinatesTraditional(),true);
>  }
>  
>  QTEST_MAIN(TestPreferences)
> -- 
> 2.10.0
> 

> From f42562b23d4f4a895dc6fb58bf162586ed7459a0 Mon Sep 17 00:00:00 2001
> From: Tomaz Canabrava 
> Date: Mon, 17 Oct 2016 18:01:06 +0200
> Subject: [PATCH 2/4] Add general settings unittests.
> 
> Signed-off-by: Tomaz Canabrava 
> ---
>  tests/testpreferences.cpp | 38 ++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/tests/testpreferences.cpp b/tests/testpreferences.cpp
> index 50389a0..ba8e6fe 100644
> --- a/tests/testpreferences.cpp
> +++ b/tests/testpreferences.cpp
> @@ -447,6 +447,44 @@ void TestPreferences::testPreferences()
>   TEST(units->verticalSpeedTime(),1);
>   TEST(units->unitSystem(),QStringLiteral("personalized"));
>   TEST(units->coordinatesTraditional(),true);
> +
> + auto general = pref->general_settings;
> + general->setDefaultFilename   ("filename");
> + general->setDefaultCylinder   ("cylinder_2");
> + //TODOl: Change this to a enum.
> + general->setDefaultFileBehavior   (0);
> +
> + general->setDefaultSetPoint   (0);
> + general->setO2Consumption (0);
> + general->setPscrRatio (0);
> + general->setUseDefaultFile(true);
> +
> + TEST(general->defaultFilename(), QStringLiteral("filename"));
> + TEST(general->defaultCylinder(), QStringLiteral("cylinder_2"));
> + TEST(general->defaultFileBehavior(), (short)0);
> + TEST(general->defaultSetPoint(), 0);
> + TEST(general->o2Consumption(), 0);
> + TEST(general->pscrRatio(), 0);
> + TEST(general->useDefaultFile(), true);
> +
> + general->setDefaultFilename   ("no_file_name");
> + general->setDefaultCylinder   ("cylinder_1");
> + //TODOl: Change this to a enum.
> + general

Re: Daily build update?

[Dirk Hohndel]

I did a new Windows build yesterday. Should be able to do a Mac and Linux build 
this weekend.

/D
-- 
Sent from my phone

On October 21, 2016 6:39:51 AM PDT, Hartley Horwitz  wrote:
>I will be able to test some of the latest patches if the daily build
>gets
>updated (I've tried out the Oct 3 build for the preferences and general
>look & feel).  I can test PC and Mac.  If this is too much of a
>distraction
>given the current wave of changes, then please ignore this request.
>
>...Hartley
>
>
>
>
>___
>subsurface mailing list
>subsurface@subsurface-divelog.org
>http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Daily build update?

[Dirk Hohndel]

Mac and AppImage are up now as well.

I’m still puzzled what to do about the Beta. There are several known bugs that 
no one
seems to have the time to fix. It seems wrong to release a Beta like that.

/D

> On Oct 21, 2016, at 11:10 AM, Dirk Hohndel  wrote:
> 
> I did a new Windows build yesterday. Should be able to do a Mac and Linux 
> build this weekend.
> 
> /D
> -- 
> Sent from my phone
> 
> On October 21, 2016 6:39:51 AM PDT, Hartley Horwitz  wrote:
> I will be able to test some of the latest patches if the daily build gets 
> updated (I've tried out the Oct 3 build for the preferences and general look 
> & feel).  I can test PC and Mac.  If this is too much of a distraction given 
> the current wave of changes, then please ignore this request.
> 
> ...Hartley
> 
> 
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface 
> <http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface>
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Warn user about wrong characters in date/time format strings

[Dirk Hohndel]

On Sun, Oct 23, 2016 at 08:48:30AM -0700, Thiago Macieira wrote:
> On domingo, 23 de outubro de 2016 00:07:20 PDT Robert Helling wrote:
> > Subject: [PATCH] Warn user about wrong characters in date/time format
> > strings To: subsurface@subsurface-divelog.org
> > 
> > fixes #1098
> 
> Technically speaking, they aren't invalid. You are allowed to set the date 
> format to
> 
>   dd" de "MM" de "

Yeah, I agree that this patch goes a bit too far. Warning about characters
that seem odd seems like a better approach

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Reorganise preferences->graph panel --- proof of concept

[Dirk Hohndel]

> On Oct 31, 2016, at 1:54 AM, Tomaz Canabrava  wrote:
> 
> Safe to enter,
> my work is mainly in the background.
> 
> On Sat, Oct 29, 2016 at 3:29 PM, Willem Ferguson 
> mailto:willemfergu...@zoology.up.ac.za>> 
> wrote:
> Reorganise the Preferences-> Graph panel.
> 
> This file is meant as a proof of concept.
> 
> The graph panel has been somewhat unfocused. Firstly the two existing 
> headings (Show and Misc) were rather uninformative. I organised the graph 
> preferences under three headings: 1) Gas pressure display setup, 2) Ceiling 
> display setup and 3) Misc.
> 
> I did not change any variable names or names of members of classes. I only 
> reorganised the existing panel.
> 
> If my approach is agreed upon, there are a number of things that would need 
> to be finalised.
> 
> TOMAZ, does this affect any of the work you have been doing to the 
> preferences?
> ROBERT, when the graph tab is opened, the Bühlmann radio button is already 
> selected. However, the change in the way the ceiling is calculated only takes 
> effect once the Apply button is selected. On my machine it starts up with 
> VPMB.

It should start up with whatever was last selected and the radio button should 
match the mode it is in. 
This sounds like a preferences loading / storing bug. Tomaz, can you look into 
this?

> Even when the Apply button is selected, the option(s) (e.g. VPMB 
> conservatism, GFHigh, GFLow) are not greyed out in the appropriate way. This 
> only happens once either the VPMB or the Bühlmann radio button is selected.

That isn’t hard to do in the UI code. Do you need help with that?

> I found it difficult to right-align the text in some fields. At the moment 
> some alignment is done by inserting spaces on the left of the appropriate 
> string properties in the preferences_graph.ui file. This is not optimal at 
> all. There is a Qt::Alignment class member and I tried defining a property in 
> the XML and then setting this alignment property to Qt::AlignRight. This 
> works, but messes up the vertical alignment of the specific text lable. I 
> have not found a better solution than the present one but maybe someone knows 
> of a more elegant solution.

Aligning with spaces is a non-starter because it gets messed up with 
translations. We need to programmatically line things up correctly. Again, this 
is a Qt issue.

> There are a few small problems with the naming of properties in the XML. This 
> comes from the existing code but can easily be fixed.

Can you say more about that, please?

Thanks

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Reorganise preferences->graph panel --- proof of concept

[Dirk Hohndel]

> On Oct 31, 2016, at 09:04, Willem Ferguson  
> wrote:
> 
>> On 31/10/2016 15:13, Dirk Hohndel wrote:
>> Even when the Apply button is selected, the option(s) (e.g. VPMB 
>> conservatism, GFHigh, GFLow) are not greyed out in the appropriate way. This 
>> only happens once either the VPMB or the Bühlmann radio button is selected.
> 
>> That isn’t hard to do in the UI code. Do you need help with that?
> 
> Please give me a pointer or two.

Have a conditional on the 'enable' property that links it to the value of the 
checkbox.
So in the onTriggered() function of the checkbox, enable / disable the other 
elements accordingly.

>>>> I found it difficult to right-align the text in some fields. At the moment 
>>>> some alignment is done by inserting spaces on the left of the appropriate 
>>>> string properties in the preferences_graph.ui file. This is not optimal at 
>>>> all. There is a Qt::Alignment class member and I tried defining a property 
>>>> in the XML and then setting this alignment property to Qt::AlignRight. 
>>>> This works, but messes up the vertical alignment 
>>>> of the specific text lable. I have not found a better solution than the 
>>>> present one but maybe someone knows of a more elegant solution.
>> 
> I see on the language preference tab, the construct below is used for 
> spacing. But that tab has a vertical layout, not a grid layout.
> 
>
> 
>  Qt::Horizontal
> 
> 
>  
>   203
>   20
>  
> 
>
> 
> Any suggestion of what may work here?

I'm not a layout guru (and am on my iPad, not my computer)... maybe someone 
else could take a look?

>>>> There are a few small problems with the naming of properties in the XML. 
>>>> This comes from the existing code but can easily be fixed.
>> 
>> Can you say more about that, please?
>> 
> Generating ui_preferences_graph.h
> /home/willem/src/subsurface/desktop-widgets/preferences/preferences_graph.ui: 
> Warning: The name 'label_26' (QLabel) is already in use, defaulting to 
> 'label_261'.
> /home/willem/src/subsurface/desktop-widgets/preferences/preferences_graph.ui: 
> Warning: The name 'label_18' (QLabel) is already in use, defaulting to 
> 'label_181'.
> /home/willem/src/subsurface/desktop-widgets/preferences/preferences_graph.ui: 
> Warning: The name 'pSCR' (QLabel) is already in use, defaulting to 'pSCR1'.
> /home/willem/src/subsurface/desktop-widgets/preferences/preferences_graph.ui: 
> Warning: The name 'groupBox_5' (QGroupBox) is already in use, defaulting to 
> 'groupBox_51'.
> /home/willem/src/subsurface/desktop-widgets/preferences/preferences_graph.ui: 
> Warning: The name 'gridLayout_2' (QGridLayout) is already in use, defaulting 
> to 'gridLayout_21'.
> 
> Duplicate labels. I think trivial to fix.

It auto-fixes it for you, so this should be harmless.

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Default Preferences not saved

[Dirk Hohndel]

Tomaz, this looks like one of the problems I'm still hoping to see fixes for.

/D

> On Oct 31, 2016, at 09:17, Willem Ferguson  
> wrote:
> 
> I have a curious case where the font type on the Defaults preferences tab is 
> not saved. It comes up as Dejavu but I want Sans Serif. When I set it to Sans 
> Serif and select APPLY, then the font is changed to Dejavu. When I close 
> Subsurface and restart, the default font is back to Dejavu. In fact if I 
> APPLY any settings, even on other preferences tabs, the font is changed to 
> Dejavu. Could this be because of patch 5400759??
> 
> Actually I suspect this is not a coding problem, but a problem of the absence 
> or locations of setup files.
> Kind regards,
> willem
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Reorganise Preferences/Graph tab

[Dirk Hohndel]

On Tue, Nov 01, 2016 at 10:09:45AM +0200, Willem Ferguson wrote:
> 
> 1) Reorganise existing items in Graph tab so that all gass pressure
> items are together and all profile-related items are together.

This part I really appreciate

> 2) Provide units (mostly bar) for all settings having units.

Are any of these units that would have to switch if we switch from metric
to imperial? Obviously the partial pressures stay in bar. I think this is
all fine, but something to make sure that we keep in mind.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Patches to pref->graph

[Dirk Hohndel]

On Tue, Nov 01, 2016 at 03:15:13PM +0200, Willem Ferguson wrote:
> Dirk,
> I suspect the last of my two patches will not apply. There is a problem with
> character encoding in the raw text of the patch and I have no idea how to
> fix that. The subscript-2 of pO2 consequently appears unreadable.
> 
> If the second patch cannot be applied:
> If you apply the first of the two patches I will pull the latest version of
> the code from master and rewrite the second patch that removes pre-pended
> space characters.

Hmm. I had no problem appying the patch. pO₂ came across just fine.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: final patches for the preferences unittests

[Dirk Hohndel]

Tomaz,

Thanks for this long series of patches. Most of them I was able to
validate by reading the code, a couple will need more testing (especially
this last one that I'm responding to).

But a big THANKS for your work here, this was a big part of what I was
waiting for before continuing towards 4.6

May the testing commence. Please.

/D

On Tue, Nov 01, 2016 at 05:05:18PM +0100, Tomaz Canabrava wrote:
> This last patch should fix robert's issues with the different deco models
> for display and plan.
> Robert issues should be fixed with this path.
> The issue was that the preferences wasn't hoocked up (it was actually
> partially hoocked in the wrong pref)
> 
> 
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Deepblu COSMIQ?

[Dirk Hohndel]

> On Nov 8, 2016, at 5:15 AM, Davide DB  wrote:
> 
> On 7 November 2016 at 11:06, Anton Lundin  wrote:
>> 
>> I'd say contact the vendor and hope for the best.
> 
> 
> Thanks Anton,
> 
> I will try with them but I'm pessimist. All their business model seems
> rotate around their locked logbook similar to a social network.

That reminds me of the original Uemis. With the download protocol from hell
and their proprietary social network logbook. Is Deepblu a Swiss company
by any chance?

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Questions for user-manual

[Dirk Hohndel]

On Thu, Nov 10, 2016 at 04:23:54PM +0200, Willem Ferguson wrote:
> 1) In the File main menu item, what does the option "Take cloud storage
> online" do?

Slightly unintuitive, I'm open for better naming. If you are offline when
you start Subsurface, or if for some other reason the connection to cloud
storage fails, Subsurface will switch into offline mode and not try to
upload any changes to the server (otherwise it will keep "hanging" for
several seconds). So this option allows you to force it to try again.

> 2) In the Log main menu item, what does the option "Add GPS position here"
> do?

I had to go through the sources and look. It appears that I planned to
implement a way to add GPS locations even from the desktop version, if
that computer provides GPS service. And then I gave up on it since it
never worked, but didn't remove the code... Oops. I'll revert that.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

service outage

[Dirk Hohndel]

Hi there,

I have been planning a rebuild of my servers for a while now (and no, the 
outage today has nothing to do with it, nor is it the reason for the changes). 
Over the next few days (or weeks, depending how much time I find and how 
smoothly things go) there may be a few smaller outages.

The expectation is that no email should get lost (backup MX server is in place 
and tested) and hopefully the downtimes for web sites, bug tracker and git 
server will be fairly short. But given my track record I figured it might be 
smart to warn people ahead of time... :-)

The end result should be a somewhat more resilient infrastructure with better 
firewalls and better service isolation in place

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

email has moved to a new server

[Dirk Hohndel]

Which means almost certainly something is broken.

For example the archives currently don't work at all. I'll deal with that 
another time.

If you find anything else that's broken, you can keep it. Or you can let me 
know. Your call.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] QML UI: deal with multiple buddies correctly

[Dirk Hohndel]

Which platform? IOS or Android?

/D

> On Nov 22, 2016, at 6:25 AM, Martin Long  wrote:
> 
> Hi, 
> 
> Is there any changes of a new daily build with this patch? I've noticed that 
> this has been trashing the data for a load of my dives. 
> 
> Thanks
> 
> Martin
> 
> On Mon, 12 Sep 2016 at 19:30 Joakim Bygdell  > wrote:
> When editing adive in Subsurface-mobile we can only handle one buddy
> due to the limitations of the combobox. To prevent loss of data when editing
> a dive with more than one buddy we display "Multiple Buddies" in the buddy
> field. This creates a special case where no changes are written to the buddy 
> field
> unless the user changes buddy for that dive.
> ---
>  core/subsurface-qt/DiveObjectHelper.cpp |  1 +
>  mobile-widgets/qml/DiveDetails.qml  |  6 +-
>  mobile-widgets/qmlmanager.cpp   | 14 +++---
>  3 files changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/core/subsurface-qt/DiveObjectHelper.cpp 
> b/core/subsurface-qt/DiveObjectHelper.cpp
> index 37f954c..246e451 100644
> --- a/core/subsurface-qt/DiveObjectHelper.cpp
> +++ b/core/subsurface-qt/DiveObjectHelper.cpp
> @@ -425,6 +425,7 @@ QStringList DiveObjectHelper::buddyList() const
> QRegExp sep("(,\\s)");
> QStringList tempList = temp.split(sep);
> buddies << tempList;
> +   buddies << "Multiple Buddies";
> }
> }
> buddies.removeDuplicates();
> diff --git a/mobile-widgets/qml/DiveDetails.qml 
> b/mobile-widgets/qml/DiveDetails.qml
> index 7f6ca81..be34288 100644
> --- a/mobile-widgets/qml/DiveDetails.qml
> +++ b/mobile-widgets/qml/DiveDetails.qml
> @@ -156,7 +156,11 @@ Kirigami.Page {
> airtemp = 
> diveDetailsListView.currentItem.modelData.dive.airTemp
> watertemp = 
> diveDetailsListView.currentItem.modelData.dive.waterTemp
> suitIndex = 
> diveDetailsListView.currentItem.modelData.dive.suitList.indexOf(diveDetailsListView.currentItem.modelData.dive.suit)
> -   buddyIndex = 
> diveDetailsListView.currentItem.modelData.dive.buddyList.indexOf(diveDetailsListView.currentItem.modelData.dive.buddy)
> +   if 
> (diveDetailsListView.currentItem.modelData.dive.buddy.search(",")) {
> +   buddyIndex = 
> diveDetailsListView.currentItem.modelData.dive.buddyList.indexOf("Multiple 
> Buddies");
> +   } else {
> +   buddyIndex = 
> diveDetailsListView.currentItem.modelData.dive.buddyList.indexOf(diveDetailsListView.currentItem.modelData.dive.buddy)
> +   }
> divemasterIndex = 
> diveDetailsListView.currentItem.modelData.dive.divemasterList.indexOf(diveDetailsListView.currentItem.modelData.dive.divemaster)
> notes = diveDetailsListView.currentItem.modelData.dive.notes
> if 
> (diveDetailsListView.currentItem.modelData.dive.singleWeight) {
> diff --git a/mobile-widgets/qmlmanager.cpp b/mobile-widgets/qmlmanager.cpp
> index 9de5ac1..1b9aebe 100644
> --- a/mobile-widgets/qmlmanager.cpp
> +++ b/mobile-widgets/qmlmanager.cpp
> @@ -869,9 +869,17 @@ void QMLManager::commitChanges(QString diveId, QString 
> date, QString location, Q
> d->suit = strdup(qPrintable(suit));
> }
> if (myDive->buddy() != buddy) {
> -   diveChanged = true;
> -   free(d->buddy);
> -   d->buddy = strdup(qPrintable(buddy));
> +   if (myDive->buddy().contains(",")) {
> +   if (!buddy.contains("Multiple Buddies")) {
> +   diveChanged = true;
> +   free(d->buddy);
> +   d->buddy = strdup(qPrintable(buddy));
> +   }
> +   } else {
> +   diveChanged = true;
> +   free(d->buddy);
> +   d->buddy = strdup(qPrintable(buddy));
> +   }
> }
> if (myDive->divemaster() != diveMaster) {
> diveChanged = true;
> --
> 2.7.4
> 
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org 
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface 
> 
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Everything should be on the new servers

[Dirk Hohndel]

Everything (with the exception of the cloud storage - that's still hosted on 
AWS) has now been relocated to my new server.

If anything doesn't work as expected, please let me know

/D


> On Nov 20, 2016, at 10:31 PM, Dirk Hohndel  wrote:
> 
> 
> Which means almost certainly something is broken.
> 
> For example the archives currently don't work at all. I'll deal with that 
> another time.
> 
> If you find anything else that's broken, you can keep it. Or you can let me 
> know. Your call.
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Everything should be on the new servers

[Dirk Hohndel]

> On Nov 27, 2016, at 1:34 PM, Rick Walsh  wrote:
> 
> Hi Dirk,
> 
> On 26 November 2016 at 05:40, Dirk Hohndel  <mailto:d...@hohndel.org>> wrote:
> 
> Everything (with the exception of the cloud storage - that's still hosted on 
> AWS) has now been relocated to my new server.
> 
> If anything doesn't work as expected, please let me know
> 
> http://git.subsurface-divelog.org/index.cgi?p=subsurface.git;a=summary 
> <http://git.subsurface-divelog.org/index.cgi?p=subsurface.git;a=summary> 
> shows that the latest commit in Master is 
> 4d0d37b6903a65ade442fece35238d1670522df2 Show effective gradient factors for 
> VPMB-plans, but when I run git pull on my machine, the latest commit is four 
> earlier: 2aeb2b8d8b045b317efa595aabb356680dbf4978 Small fix for Ubuntu builds.
> 
> I noticed this on Friday, but thought it was wrong at my end as I'd just 
> updated my computer to Fedora 25 and thought the reason git said 'already up 
> to date' must have been because I'd messed something up with git or network 
> configuration, but I just confirmed then by doing a completely new 'git 
> clone', and it's still not fetching the most recent commits.


Without having looked at anything I bet you two bug fixes and a documentation 
patch that your git repository uses git.hohndel.org <http://git.hohndel.org/> 
instead of git.subsurface-divelog.org <http://git.subsurface-divelog.org/>...

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Everything should be on the new servers

[Dirk Hohndel]

> On Nov 27, 2016, at 3:43 PM, Anton Lundin  wrote:
> 
> On 27 November, 2016 - Robert C. Helling wrote:
> 
>> Hi
>> 
>>> Am 27.11.2016 um 22:34 schrieb Rick Walsh :
>>> 
>>> http://git.subsurface-divelog.org/index.cgi?p=subsurface.git;a=summary 
>>> shows that the latest commit in Master is 
>>> 4d0d37b6903a65ade442fece35238d1670522df2 Show effective gradient factors 
>>> for VPMB-plans, but when I run git pull on my machine, the latest commit is 
>>> four earlier: 2aeb2b8d8b045b317efa595aabb356680dbf4978 Small fix for Ubuntu 
>>> builds
>> 
>> Same here. 
>> 
> 
> git ls-remote git://subsurface-divelog.org/subsurface HEAD
> 2aeb2b8d8b045b317efa595aabb356680dbf4978  HEAD
> git ls-remote https://github.com/dirkhh/subsurface.git HEAD
> 4d0d37b6903a65ade442fece35238d1670522df2  HEAD
> 
> 2aeb2b8 Small fix for Ubuntu builds
> ...
> 4d0d37b Show effective gradient factors for VPMB-plans
> 
> 
> So, something in your push-magic is br0ken.

Actually, that wasn't it at all. The redirection of ports was off. I push via 
ssh
but you checked via the git and http protocols. http and ssh were pointing
to the new server, but git was still pointing to the old server.

Oops.

Thanks for catching this.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: git repository corrupted?

[Dirk Hohndel]

That's annoying. Can you try GitHub?

⁣-- 
>From my phone​


 Original Message 
From: Miika Turkia 
Sent: Sat Dec 03 21:00:49 PST 2016
To: Subsurface Mailing List 
Subject: git repository corrupted?

I just noticed that webgit doesn't give proper information and tried
to clone a completely new repository to verify:

---8<---
$ git clone git://subsurface-divelog.org/subsurface
Cloning into 'subsurface'...
remote: Counting objects: 53828, done.
remote: Compressing objects: 100% (14531/14531), done.
remote: Total 53828 (delta 40910), reused 51486 (delta 39109)
Receiving objects: 100% (53828/53828), 36.50 MiB | 4.31 MiB/s, done.
Resolving deltas: 100% (40910/40910), done.
Checking connectivity... done.
warning: remote HEAD refers to nonexistent ref, unable to checkout.
---8<---

Something is not working right.

miika
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: git repository corrupted?

[Dirk Hohndel]

Should be all better again

/D

> On Dec 3, 2016, at 9:57 PM, Miika Turkia  wrote:
> 
> Linus' github repo works.
> 
> On Sun, Dec 4, 2016 at 7:33 AM, Dirk Hohndel  wrote:
>> That's annoying. Can you try GitHub?
>> 
>> --
>> From my phone
>> 
>> From: Miika Turkia
>> Sent: Sat Dec 03 21:00:49 PST 2016
>> To: Subsurface Mailing List
>> Subject: git repository corrupted?
>> 
>> I just noticed that webgit doesn't give proper information and tried
>> to clone a completely new repository to verify:
>> 
>> ---8<---
>> $ git clone git://subsurface-divelog.org/subsurface
>> Cloning into 'subsurface'...
>> remote: Counting objects: 53828, done.
>> remote: Compressing objects: 100% (14531/14531), done.
>> remote: Total 53828 (delta 40910), reused 51486 (delta 39109)
>> Receiving objects: 100% (53828/53828), 36.50 MiB | 4.31 MiB/s, done.
>> Resolving deltas: 100% (40910/40910), done.
>> Checking connectivity... done.
>> warning: remote HEAD refers to nonexistent ref, unable to checkout.
>> ---8<---
>> 
>> Something is not working right.
>> 
>> miika
>> 
>> 
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Cannot save to cloud server: 4.5.6 on Ubuntu 16.10

[Dirk Hohndel]

> On Dec 9, 2016, at 11:45 AM, Richard Trinkner  
> wrote:
> 
> Apparently, I can open my cloud server file in 4.5.6, but after making a 
> change to the dive notes (e.g., adding a word), I cannot save to the cloud 
> server.  I receive a red-bar alert at the bottom of the app screen.

That's a known bug. I'm not sure if we have a newer daily build for 16.10 in 
the PPA, but you should be able to use the AppImage that you can find at 
http://subsurface-divelog.org/downloads/daily

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

4.6 - what's still missing

[Dirk Hohndel]

In a hopefully not entirely vain hope that maybe, just maybe I might have a 
little 
more spare time the last two weeks of the year... what needs to get fixed 
before 
4.6 can be released?

Or should I just cut a release, warts and all, and hope that 4.6.1 can fix 
what's
broken? That doesn't seem like a good plan, but it seems none of the usually 
active developers have much time to devote...

/D 
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: 4.6 - what's still missing

[Dirk Hohndel]

> On Dec 10, 2016, at 11:59 PM, Willem Ferguson 
>  wrote:
> 
> -- Forwarded message --
> From: "Willem Ferguson"  <mailto:willemfergu...@zoology.up.ac.za>>
> Date: 11 Dec 2016 08:48
> Subject: Re: 4.6 - what's still missing
> To: "Dirk Hohndel" mailto:d...@hohndel.org>>
> Cc: 
> 
> Bug # 1103 affects me quite strongly at the moment. It is not a showstopper 
> but it is not trivial either.
> 

I saw that - no idea what caused it. Have you tried bisecting the bug?

> Then there is the problem with makefile, preventing build of desktop 
> Subsurface with the - mobile flag.
> 

I missed that one. You're on Ubuntu, correct? I don't have a Ubuntu box here, 
but can bring up a VM
quite easily :-)

Now all I need is time.

/D


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: 4.6 - what's still missing

[Dirk Hohndel]

> On Dec 11, 2016, at 7:26 PM, Rick Walsh  wrote:
> 
> 
> 
> On 11 Dec 2016 15:00, "Dirk Hohndel"  <mailto:d...@hohndel.org>> wrote:
> 
> In a hopefully not entirely vain hope that maybe, just maybe I might have a 
> little
> more spare time the last two weeks of the year... what needs to get fixed 
> before
> 4.6 can be released?
> 
> I reported some issues with preferences not being saved or restored a few 
> weeks ago. 
> http://lists.subsurface-divelog.org/pipermail/subsurface/2016-November/026623.html
>  
> <http://lists.subsurface-divelog.org/pipermail/subsurface/2016-November/026623.html>
> 
> I haven't had a chance to check recently, but I don't think this has been 
> fixed.

Ideally for each of the issues you found, both a fix and a test case should be 
written.

I will try to cut a Beta 1 tonight. Maybe this way it will get some more 
broader testing.

I've spent the day trying to fix the AppImage problem - I don't think I 
succeeded. But
in the process I changed quite a bit about the infrastructure that I use to 
build the AppImage,
so that's at least progress.

I also pushed the latest strings to Transifex.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

4.6 Beta 1

[Dirk Hohndel]

This hasn't been announced anywhere, but it's tagged in the sources,
builds have been pushed and the DMG, EXE, and AppImage have been uploaded.

I'd love it if people could spend some time testing this. Assuming the
builds aren't completely hosed I'd love to announce this tomorrow.

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: 4.6 Beta 1

[Dirk Hohndel]

> On Dec 11, 2016, at 10:54 PM, Benjamin  wrote:
> 
> Good morning.
> A friend gave me his (not-so old) mac laptop, and I tried the last daily (not 
> the beta) on it.
> Before opening a bug, I just wanted to ask if the Facebook integration should 
> be working? 

It should but it appears not to :-(

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: 4.6 Beta 1

[Dirk Hohndel]

> On Dec 11, 2016, at 10:48 PM, Miika Turkia  wrote:
> 
> On Mon, Dec 12, 2016 at 7:22 AM, Dirk Hohndel  wrote:
>> This hasn't been announced anywhere, but it's tagged in the sources,
>> builds have been pushed and the DMG, EXE, and AppImage have been uploaded.
>> 
>> I'd love it if people could spend some time testing this. Assuming the
>> builds aren't completely hosed I'd love to announce this tomorrow.
> 
> I checked the Ubuntu PPA and it looks like yakkety is missing from
> there (16.10, the latest short term release). I didn't see any error
> mails from PPA, so I suspect that this version is not pushed there.
> The other versions appear to be available, but I only have yakkety on
> my hands currently, so cannot test anything else atm.

Trusty had problems building - those should be fixed. And I did indeed 
forget yakkety.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Transifex

[Dirk Hohndel]

> On Dec 13, 2016, at 3:04 AM, Benjamin  wrote:
> 
> Same for Hebrew
> 
> 
> On Tue, 13 Dec 2016, 12:55 Tim Wootton,  > wrote:
> Same for UK English
> 
> 
> On 13 December 2016 10:54:32 GMT+00:00, Pedro Neves  > wrote:
> Dirk: 
> 
> Despite having translated all new strings to Pt, Transifex still says that 
> there are 2 untranslated strings (which don't show up when I select 
> "Untranslated"). Ignore?
> 


I vaguely remember that I figured out what was going on a year ago. I think 
there
are two strings that are incorrectly formatted in our source file and I had to 
do
some magic to fix that and eventually just gave up. I'll look again.

Thanks to everyone for translating!

/D


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: 4.6 Beta 1

[Dirk Hohndel]

> On Dec 13, 2016, at 2:41 AM, Miika Turkia  wrote:
> 
> Installing subsurface to yakkety requires me to install also the
> following dependencies. I really dislike the idea of installing
> avahi-daeman and libnss-mdns. From my point of view, these are useless
> on any normally configured network, and I have so far never used
> network autoconfigurations... (Didn't look that carefully into other
> libraries.)
> 
> ---8<---
> The following additional packages will be installed:
>  avahi-daemon geoclue-2.0 iio-sensor-proxy libdouble-conversion1v5
> libgeoclue-2-0 libgrantlee-templates5
>  libnss-mdns libqt5bluetooth5 libqt5bluetooth5-bin libqt5concurrent5
> libqt5positioning5 libqt5qml5 libqt5quick5
>  libqt5script5 libqt5sql5 libqt5sql5-sqlite libqt5webkit5 libqt5xml5 libzip4
> ---8<---

Subsurface doesn't depend on avahi-daemon nor on libnss-mdns
Both of those must be implicit dependencies of other libraries we depend on :-(

> Anyway Subsurface was installed successfully. However, when I started
> Subsurface for the first time, declined checking of updates, imported
> an XML log, and hit quit (without saving), subsurface GUI disappeared,
> but the process keeps on running, apparently forever.

That's not good. If you attach to it with a debugger, what is it doing?

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: 4.6 Beta 1

[Dirk Hohndel]

> On Dec 13, 2016, at 2:37 AM, Pedro Neves  wrote:
> 
> On 13-12-2016 02:25, Steve wrote:
>> I'd love it if people could spend some time testing this. Assuming the 
>> builds aren't completely hosed I'd love to announce this tomorrow.
>> 
> 
> I'm running latest appimage on my Arch machine. A few things I've noticed:
> 
> - I had to install libselinux in order to run the app image;

I have noticed this. I don't know what causes that and I can't figure out how 
to work around it as including libselinux in the AppImage doesn't work.

> - some translated strings are not integrated on the image yet (e.g. 
> preferences);

Things that you have just translated? Or things that were translated at least a 
couple of days ago? 
If the latter, can you give specific strings so I can check what's going on?
> 
> - I still have a seg fault when trying to edit the cylinder on my dives 
> (Thomaz did you had a chance of looking into it?).

Have you filed a bug for that one?

> I'll keep testing...

Yes, please

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Beta announcement

[Dirk Hohndel]

In the continuing story of "I am not spending enough time on Subsurface", I 
just 
managed to post the Subsurface beta announcement on our own website.

https://subsurface-divelog.org/2016/12/announcing-subsurface-4-6-beta-1/

Could someone review this for idiocities, typos and other mis-features, please?
I gotta run to a meeting, but I hope to post announcements to FB and G+ later
today.

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Beta announcement

[Dirk Hohndel]

> On Dec 26, 2016, at 8:24 AM, Robert C. Helling  
> wrote:
> 
> Hi Dirk,
> 
> Merry Christmas to all of you!
> 
>> Am 26.12.2016 um 17:03 schrieb Dirk Hohndel :
>> 
>> Could someone review this for idiocities, typos and other mis-features, 
>> please?
> 
> Looks good to me. I am only on my phone, but I am under the impression that 
> you have not included all those patches I sent in the last few weeks. The 
> should all match \[PATCH in the subject line. Can later check once I am back 
> on my computer. 

I wanted to announce Beta 1.

I'll go through the patch queue and get any missing patches into master later 
this afternoon.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Beta announcement

[Dirk Hohndel]

> On Dec 26, 2016, at 8:28 AM, Miika Turkia  wrote:
> 
> On Mon, Dec 26, 2016 at 6:03 PM, Dirk Hohndel  wrote:
>> In the continuing story of "I am not spending enough time on Subsurface", I 
>> just
>> managed to post the Subsurface beta announcement on our own website.
>> 
>> https://subsurface-divelog.org/2016/12/announcing-subsurface-4-6-beta-1/
>> 
>> Could someone review this for idiocities, typos and other mis-features, 
>> please?
>> I gotta run to a meeting, but I hope to post announcements to FB and G+ later
>> today.
> 
> Generally it would be better to give a few positive points before
> going into details about release taking longer than we wanted. E.g.
> 
> The Subsurface developer team is proud to announce our first beta
> version of Subsurface 4.6. This version adds support for multiple new
> dive computers and introduces new visualization of tissue loading on
> deco dives. Plenty of bugs has been squashed along with improvements
> on dive planning and import/export functionality.

Good point. I'm not positive enough. How about now?

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Beta announcement

[Dirk Hohndel]

> On Dec 26, 2016, at 9:10 AM, Miika Turkia  wrote:
>> 
>> Good point. I'm not positive enough. How about now?
> 
> That's better. Didn't spot anything else that would need to be fixed...

Fixed the grammar error (Linus would never forgive me), added a picture,
and posted the announcement on FB, G+ and ScubaBoard. Feel free to
post elsewhere as well - given the algorithms at FB and G+, re-sharing of
the announcement posts apparently greatly increases their reach (the
more people re-share, the higher the percentage of the people who 
"follow" Subsurface who will actually ever get to see this announcement
to begin with).

Thanks

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface