Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915 drm2/radeon hatm
On Sat, Nov 30, 2013 at 10:16:38PM +, Eitan Adler wrote: Author: eadler Date: Sat Nov 30 22:16:37 2013 New Revision: 258779 URL: http://svnweb.freebsd.org/changeset/base/258779 Log: Similar to the (1 31) case it is not defined to do (2 30). Modified: ... head/sys/dev/drm2/i915/i915_reg.h Revert the drm2/i915 changes from this and following commits now. You did not contacted obvious maintainer of the file. The changes are pointless and make the import of upstream changes harder; for i915_reg.h, much harder. Not to mention that the whole churn is not needed if the -fno-strict-overflow flag is used. pgpw_d6f2JqmM.pgp Description: PGP signature
Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915 drm2/radeon hatm
On 1 Dec 2013, at 07:59, Konstantin Belousov kostik...@gmail.com wrote: Revert the drm2/i915 changes from this and following commits now. You did not contacted obvious maintainer of the file. The changes are pointless and make the import of upstream changes harder; for i915_reg.h, much harder. Not to mention that the whole churn is not needed if the -fno-strict-overflow flag is used. If supporting code that is obviously wrong (as in this case, as the compiler will happily tell you if you don't explicitly silence warnings) is the justification for wanting -fno-strict-overflow, then this is a very flimsy justification. David ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915 drm2/radeon hatm
On Sun, Dec 01, 2013 at 09:59:44AM +0200, Konstantin Belousov wrote: On Sat, Nov 30, 2013 at 10:16:38PM +, Eitan Adler wrote: Author: eadler Date: Sat Nov 30 22:16:37 2013 New Revision: 258779 URL: http://svnweb.freebsd.org/changeset/base/258779 Log: Similar to the (1 31) case it is not defined to do (2 30). Modified: ... head/sys/dev/drm2/i915/i915_reg.h Revert the drm2/i915 changes from this and following commits now. You did not contacted obvious maintainer of the file. The changes are pointless and make the import of upstream changes harder; for i915_reg.h, much harder. This is a valid concern. The change should be submitted to upstream; if upstream does not want the change, it is better to avoid the issue by adding -fno-strict-overflow for the offending files, matching upstream. Not to mention that the whole churn is not needed if the -fno-strict-overflow flag is used. I think the undefined shifts should be fixed where possible and not in contributed code. -- Jilles Tjoelker ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915 drm2/radeon hatm
On Sun, Dec 1, 2013 at 6:07 PM, Jilles Tjoelker jil...@stack.nl wrote: Revert the drm2/i915 changes from this and following commits now. You did not contacted obvious maintainer of the file. Of course I did not. This was discussed on arch@ and the change made mechanically. The changes are pointless and make the import of upstream changes harder; for i915_reg.h, much harder. This is a valid concern. The change should be submitted to upstream; if upstream does not want the change, it is better to avoid the issue by adding -fno-strict-overflow for the offending files, matching upstream. I will revert to the broken and incorrect code in sys/dev/drm2/i915. Upstream should be contacted with the patch. Not to mention that the whole churn is not needed if the -fno-strict-overflow flag is used. I think the undefined shifts should be fixed where possible and not in contributed code. Agreed. In addition, contributed code ought to be clearly differentiated in the directory hierarchy. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
