Re: [U-Boot] [PATCH] microblaze: usable uart16550 for big endian systems
Hi Stephan, Stephan Linz wrote: As a result of the commit 6833260 the uart16550 driver is broken for Microblaze big endian systems, because of the missing 3 byte offset. Other than as described, the U-Boot BSP does not treat properly the 3 byte offset. However, with the new 32 bit access to ns16550 registers we can enable correct register access for Microblaze big and little endian systems in the same manner. The reason why I have applied that patch is that baseaddress generation was moved to u-boot BSP out of u-boot configs. Here is example how addresses are generated. BE system: #define XILINX_UART16550 #define XILINX_UART16550_BASEADDR 0x83e3 LE system: #define XILINX_UART16550 #define XILINX_UART16550_BASEADDR 0x83e0 Then you can use origin config file and change is only in xparameters.h in board folder. Anyway you solution looks interesting and I will test it. Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 10/14] OMAP3 SPL: Add identify_nand_chip function
On 11/20/11 16:26, Tom Rini wrote: > On Sun, Nov 20, 2011 at 12:36 AM, Igor Grinberg > wrote: >> Hi Tom, >> >> On 11/19/11 00:48, Tom Rini wrote: >>> A number of boards are populated with a PoP chip for both DDR and NAND >>> memory. Other boards may simply use this as an easy way to identify >>> board revs. So we provide a function that can be called early to reset >>> the NAND chip and return the result of NAND_CMD_READID. All of this >>> code is put into spl_id_nand.c and controlled via CONFIG_SPL_OMAP3_ID_NAND. >>> >>> Signed-off-by: Tom Rini >>> --- >>> arch/arm/cpu/armv7/omap3/Makefile |3 + >>> arch/arm/cpu/armv7/omap3/spl_id_nand.c | 87 >>> +++ >>> arch/arm/include/asm/arch-omap3/sys_proto.h |1 + >>> 3 files changed, 91 insertions(+), 0 deletions(-) >>> create mode 100644 arch/arm/cpu/armv7/omap3/spl_id_nand.c >>> >>> diff --git a/arch/arm/cpu/armv7/omap3/Makefile >>> b/arch/arm/cpu/armv7/omap3/Makefile >>> index 8e85891..4b38e45 100644 >>> --- a/arch/arm/cpu/armv7/omap3/Makefile >>> +++ b/arch/arm/cpu/armv7/omap3/Makefile >>> @@ -31,6 +31,9 @@ COBJS += board.o >>> COBJS+= clock.o >>> COBJS+= mem.o >>> COBJS+= sys_info.o >>> +ifdef CONFIG_SPL_BUILD >>> +COBJS-$(CONFIG_SPL_OMAP3_ID_NAND)+= spl_id_nand.o >>> +endif >> >> You haven't responded to my question on the above stuff. >> Otherwise all the series look good to me. > > Missed that, sorry! > >> >> Original version available at: >> http://www.mail-archive.com/u-boot@lists.denx.de/msg68828.html >> >> Here is the relevant part: >> > diff --git a/arch/arm/cpu/armv7/omap3/Makefile > b/arch/arm/cpu/armv7/omap3/Makefile index 8e85891..772f3d4 100644 --- a/arch/arm/cpu/armv7/omap3/Makefile +++ b/arch/arm/cpu/armv7/omap3/Makefile @@ -31,6 +31,9 @@ COBJS += board.o COBJS += clock.o COBJS += mem.o COBJS += sys_info.o +ifdef CONFIG_SPL_BUILD +COBJS-$(CONFIG_SPL_OMAP3_POP_PROBE)+= spl_pop_probe.o +endif >> >> Can't CONFIG_SPL_OMAP3_..._PROBE symbol default to "no" >> and depend on CONFIG_SPL_BUILD, so you don't need to enclose >> it in #ifdef? But then it would build for both SPL and non-SPL cases. >> >> No, it should not. >> What do you think of the following: >> In the Makefile have only: >> COBJS-$(CONFIG_SPL_OMAP3_POP_PROBE) += spl_pop_probe.o >> >> Then in the spl_pop_probe.c have this type of check: >> #ifndef CONFIG_SPL_BUILD >> # error CONFIG_SPL_OMAP3_POP_PROBE requires CONFIG_SPL_BUILD >> #endif >> >> This way, you require the CONFIG_SPL_OMAP3_POP_PROBE symbol >> be a part of the CONFIG_SPL_BUILD symbols group. > > Well, if we always link this, but then #error, U-Boot won't build :) No you do not always link this... please, read more carefully... Only when CONFIG_SPL_OMAP3_POP_PROBE symbol is defined, the file will be compiled, but if CONFIG_SPL_OMAP3_POP_PROBE defined without CONFIG_SPL_BUILD being defined, then it will emit an error. > I guess the reason to not #ifndef CONFIG_SPL_BUILD the whole file is > that the normal style for SPL is to only include the file when > building for SPL. I don't understand the sentence above and the way it is related to my question. -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Allow for parallel builds and saved output
On Sun, Nov 20, 2011 at 11:15 PM, Simon Glass wrote:
> Hi Mike,
>
> On Sun, Nov 20, 2011 at 1:23 PM, Mike Frysinger wrote:
>> On Thursday 03 November 2011 03:28:29 Andy Fleming wrote:
>>
>> you don't need those semicolons. also, this is not as good as it should be:
>> if you're running 10 jobs in parallel, you fork 10, and then you wait for all
>> of them to finish before forking another set of 10.
>>
>> what you could do is something like:
>> JOB_IDX=0
>> JOB_IDX_FIRST=0
>> BUILD_NBUILDS=1
>>
>> ... foreach target ... ; do
>> build_target &
>> pids[$(( JOB_IDX++ ))]=$!
>> if [ $(( JOB_IDX - JOB_IDX_FIRST )) -ge ${BUILD_NBUILDS} ] ;
>> then
>> wait ${pids[$(( JOB_IDX_FIRST++ ))]}
>> fi
>> done
>> wait
>>
>> this isn't perfect as it assumes the first job launched will always finish
>> first,
>> but it's a lot closer than the current code.
>
> Since all the jobs are launched at the same time this is not really a
> valid assumption is it? IMO on this point it's good enough as it is
> for now...
Mike's idea led me to a slightly crazier one that (I think) works.
Basically, I have each build_targets invocation create a file named
LOG/build_N when it is done, where N is the value of TOTAL_CNT when it
is invoked. Then I keep track of the oldest uncompleted build #. When
we hit our build limit, the script scans for LOG/build_N, for N from
oldest to TOTAL_CNT, and updates the count of outstanding builds, as
appropriate (and moves the index of the oldest). If the scanning
completes without freeing up room for another build, it waits for a
second, and then re-scans.
I tried this on my 24-core system with BUILD_NBUILDS set to 8 and
BUILD_NCPUS set to 4, and pegged the system at ~24-30 the whole time.
I will note that it only shaved about a minute off the 15 minutes it
took to build all 85xx. I'm still debugging a bit (I want to try 16
builds/2 cores, and clean up a bit), but I figured I'd ask what people
thought of this approach.
My next patch will also address Mike's comments. If I'm feeling
inspired, I might address some of your suggestions (I think I can use
the build-completion files to coalesce some of the debug output).
Andy
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Efika: Configure additional regulators for HDMI output
> 2011/11/20 Marek Vasut > > > > HDMI output doesn't work with current u-boot-imx tree (no LCD output > > > > after > > > > > 'setenv stdout lcd'), > > > but works with current u-boot-marex/efikasb tree. > > > > Ok, so are you debugging it or not ? > > No, I thought that if it works with u-boot-marex/efikasb, it's only a > question of > getting some more patches into u-boot-imx. Ah ok, nevermind, it seems it can't work yet -- I'll have to recheck. M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Efika: Configure additional regulators for HDMI output
> 2011/11/20 Marek Vasut > > > > HDMI output doesn't work with current u-boot-imx tree (no LCD output > > > > after > > > > > 'setenv stdout lcd'), > > > but works with current u-boot-marex/efikasb tree. > > > > Ok, so are you debugging it or not ? > > No, I thought that if it works with u-boot-marex/efikasb, it's only a > question of > getting some more patches into u-boot-imx. Ok, I'll debug it myself later this week. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] PXA: Drop CERF250 board
> On Sunday 20 November 2011 03:41:49 Marek Vasut wrote: > > > no changelog as to why it's being dropped ? > > > > Nope. It's unmaintained ... let's see if the author will speak to us or > > not. > > does it fail to build ? is it missing some critical update ? > > a board that builds fine and probably works generally isn't considered from > removal just because no commits have been made to it in a long time ... > -mike It doesn't build, exactly. There was this machine-ID change and noone cares. Let's see what the author will tell us. If nothing, time to go. M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] mvgbe: remove setting of ethaddr within the driver
> -Original Message-
> From: Michael Walle [mailto:mich...@walle.cc]
> Sent: Friday, November 18, 2011 4:22 AM
> To: u-boot@lists.denx.de
> Cc: Wolfgang Denk; Michael Walle; Mike Frysinger; Prafulla
> Wadaskar; Valentin Longchamp; Eric Cooper; Jason Cooper;
> Siddarth Gore; Albert ARIBAUD; Simon Guinot
> Subject: [PATCH v2] mvgbe: remove setting of ethaddr within the
> driver
>
> A network driver should not touch the environment at all. This
> patch fixes
> this behaviour by removing the code for setting a
> default/randomized MAC
> address.
>
> Signed-off-by: Michael Walle
> Acked-by: Mike Frysinger
> Acked-by: Prafulla Wadaskar
> Cc: Mike Frysinger
> Cc: Prafulla Wadaskar
> Cc: Valentin Longchamp
> Cc: Eric Cooper
> Cc: Jason Cooper
> Cc: Siddarth Gore
> Cc: Albert ARIBAUD
> Cc: Simon Guinot
> ---
> drivers/net/mvgbe.c | 23 ---
> 1 files changed, 0 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c
> index c7f7446..21be642 100644
> --- a/drivers/net/mvgbe.c
> +++ b/drivers/net/mvgbe.c
> @@ -647,7 +647,6 @@ int mvgbe_initialize(bd_t *bis)
> struct mvgbe_device *dmvgbe;
> struct eth_device *dev;
> int devnum;
> - char *s;
> u8 used_ports[MAX_MVGBE_DEVS] = CONFIG_MVGBE_PORTS;
>
> for (devnum = 0; devnum < MAX_MVGBE_DEVS; devnum++) {
> @@ -702,16 +701,13 @@ error1:
> /* must be less than NAMESIZE (16) */
> sprintf(dev->name, "egiga%d", devnum);
>
> - /* Extract the MAC address from the environment */
> switch (devnum) {
> case 0:
> dmvgbe->regs = (void *)MVGBE0_BASE;
> - s = "ethaddr";
> break;
> #if defined(MVGBE1_BASE)
> case 1:
> dmvgbe->regs = (void *)MVGBE1_BASE;
> - s = "eth1addr";
> break;
> #endif
> default:/* this should never happen */
> @@ -720,25 +716,6 @@ error1:
> return -1;
> }
>
> - while (!eth_getenv_enetaddr(s, dev->enetaddr)) {
> - /* Generate Private MAC addr if not set */
> - dev->enetaddr[0] = 0x02;
> - dev->enetaddr[1] = 0x50;
> - dev->enetaddr[2] = 0x43;
> -#if defined (CONFIG_SKIP_LOCAL_MAC_RANDOMIZATION)
> - /* Generate fixed lower MAC half using devnum */
> - dev->enetaddr[3] = 0;
> - dev->enetaddr[4] = 0;
> - dev->enetaddr[5] = devnum;
> -#else
> - /* Generate random lower MAC half */
> - dev->enetaddr[3] = get_random_hex();
> - dev->enetaddr[4] = get_random_hex();
> - dev->enetaddr[5] = get_random_hex();
> -#endif
> - eth_setenv_enetaddr(s, dev->enetaddr);
> - }
> -
> dev->init = (void *)mvgbe_init;
> dev->halt = (void *)mvgbe_halt;
> dev->send = (void *)mvgbe_send;
> --
> 1.7.2.5
Ack for this patch
Acked-by: Prafulla Wadaskar
Regards..
Prafulla . . .
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Allow for parallel builds and saved output
Hi Mike,
On Sun, Nov 20, 2011 at 1:23 PM, Mike Frysinger wrote:
> On Thursday 03 November 2011 03:28:29 Andy Fleming wrote:
>> +if [ ! "${BUILD_NBUILDS}" ] ; then
>> + BUILD_NBUILDS="1"
>> +fi
>
> : ${BUILD_NBUILDS:=1}
>
>> + if [ ! "${BUILD_DIR}" ] ; then
>> + BUILD_DIR="./build"
>> + fi
>
> : ${BUILD_DIR:=./build}
>
>> + mkdir -p ${BUILD_DIR}/ERR
>
> mkdir -p "${BUILD_DIR}/ERR"
>
>> if [ ! "${BUILD_DIR}" ] ; then
>> BUILD_DIR="."
>> fi
>
> : ${BUILD_DIR:=.}
>
>> + mkdir -p ${output_dir}
>
> mkdir -p "${output_dir}"
>
>> + ${MAKE} clean
>> + find "${output_dir}" -type f -name '*.depend' | xargs rm
>
> why not use distclean and avoid the `find` ? otherwise, this find should be:
> find "${output_dir}" -type f -name '*.depend' -exec rm -f {} +
>
>> + ERR_CNT=$((ERR_CNT + 1))
>
> : $(( ERR_CNT += 1 ))
>
>> - build_target ${t}
>> + if [ "$BUILD_NBUILDS" -gt 1 ] ; then
>> + build_target ${t} &
>> + else
>> + build_target ${t}
>> + fi
>
> you could keep this one line as:
> build_target ${t} &
> [ ${BUILD_NBUILDS} -eq 1 ] && wait
>
>> + TOTAL_CNT=$((TOTAL_CNT + 1))
>
> : $(( TOTAL_CNT += 1 ))
>
>> + CURRENT_COUNT=$((CURRENT_COUNT + 1))
>
> : $(( CURRENT_COUNT += 1 ))
>
>> + # Limit number of parallel builds
>> + if [ ${CURRENT_COUNT} -gt ${BUILD_NBUILDS} ] ; then
>> + CURRENT_COUNT=0;
>> + wait;
>> fi
>
> you don't need those semicolons. also, this is not as good as it should be:
> if you're running 10 jobs in parallel, you fork 10, and then you wait for all
> of them to finish before forking another set of 10.
>
> what you could do is something like:
> JOB_IDX=0
> JOB_IDX_FIRST=0
> BUILD_NBUILDS=1
>
> ... foreach target ... ; do
> build_target &
> pids[$(( JOB_IDX++ ))]=$!
> if [ $(( JOB_IDX - JOB_IDX_FIRST )) -ge ${BUILD_NBUILDS} ] ;
> then
> wait ${pids[$(( JOB_IDX_FIRST++ ))]}
> fi
> done
> wait
>
> this isn't perfect as it assumes the first job launched will always finish
> first,
> but it's a lot closer than the current code.
Since all the jobs are launched at the same time this is not really a
valid assumption is it? IMO on this point it's good enough as it is
for now...
Regards,
Simon
>
>> + for file in `ls ${OUTPUT_PREFIX}/ERR/`; do
>> + ERR_LIST="${ERR_LIST} $file"
>> + done
>
> ERR_LIST=$(ls ${OUTPUT_PREFIX}/ERR/)
>
>> + ERR_CNT=`ls -l ${OUTPUT_PREFIX}/ERR/ | wc | awk '{print $1}'`
>
> you should use -1 instead of -l
> -mike
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] drivers/net/mvgbe.c: Fix GCC 4.6 warnings
> -Original Message-
> From: Anatolij Gustschin [mailto:ag...@denx.de]
> Sent: Sunday, November 20, 2011 12:30 AM
> To: u-boot@lists.denx.de
> Cc: Prafulla Wadaskar
> Subject: [PATCH] drivers/net/mvgbe.c: Fix GCC 4.6 warnings
>
> Fix:
> mvgbe.c: In function 'mvgbe_send':
> mvgbe.c:555:2: warning: dereferencing type-punned pointer will
> break strict-aliasing rules [-Wstrict-aliasing]
> mvgbe.c: In function 'mvgbe_recv':
> mvgbe.c:640:2: warning: dereferencing type-punned pointer will
> break strict-aliasing rules [-Wstrict-aliasing]
>
> Signed-off-by: Anatolij Gustschin
> Cc: Prafulla Wadaskar
> ---
> drivers/net/mvgbe.c |9 ++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c
> index fd13428..de7cdd7 100644
> --- a/drivers/net/mvgbe.c
> +++ b/drivers/net/mvgbe.c
> @@ -531,6 +531,7 @@ static int mvgbe_send(struct eth_device
> *dev, void *dataptr,
> struct mvgbe_txdesc *p_txdesc = dmvgbe->p_txdesc;
> void *p = (void *)dataptr;
> u32 cmd_sts;
> + u32 txuq0_reg_addr;
>
> /* Copy buffer if it's misaligned */
> if ((u32) dataptr & 0x07) {
> @@ -552,7 +553,8 @@ static int mvgbe_send(struct eth_device
> *dev, void *dataptr,
> p_txdesc->byte_cnt = datasize;
>
> /* Set this tc desc as zeroth TXUQ */
> - MVGBE_REG_WR(regs->tcqdp[TXUQ], (u32) p_txdesc);
> + txuq0_reg_addr = (u32)®s->tcqdp[TXUQ];
> + writel((u32) p_txdesc, txuq0_reg_addr);
>
> /* ensure tx desc writes above are performed before we
> start Tx DMA */
> isb();
> @@ -583,6 +585,7 @@ static int mvgbe_recv(struct eth_device
> *dev)
> struct mvgbe_rxdesc *p_rxdesc_curr = dmvgbe->p_rxdesc_curr;
> u32 cmd_sts;
> u32 timeout = 0;
> + u32 rxdesc_curr_addr;
>
> /* wait untill rx packet available or timeout */
> do {
> @@ -637,8 +640,8 @@ static int mvgbe_recv(struct eth_device
> *dev)
> p_rxdesc_curr->buf_size = PKTSIZE_ALIGN;
> p_rxdesc_curr->byte_cnt = 0;
>
> - writel((unsigned)p_rxdesc_curr->nxtdesc_p,
> - (u32) &dmvgbe->p_rxdesc_curr);
> + rxdesc_curr_addr = (u32)&dmvgbe->p_rxdesc_curr;
> + writel((unsigned)p_rxdesc_curr->nxtdesc_p,
> rxdesc_curr_addr);
>
> return 0;
> }
Acked-By: Prafulla Wadaskar
Regards..
Prafulla . .
> --
> 1.7.5.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] AT91: pio: Add PIO3 features
ping ... BR, Eric On 11/16/2011 06:47 PM, Hong Xu wrote: This patch adds the support for new PIO controller introduced by some AT91 SoCs. New features include * More peripheral multiplexing * Pull-down, Schmitt trigger, Debouncer * More irq trigger mode (may be not interesting in U-Boot) Signed-off-by: Hong Xu --- Change for v3 * CONFIG_CPU_HAS_PIO3 -> ATMEL_CPU_HAS_PIO3 PIO3 is a feature of CPU, not a configuration item arch/arm/include/asm/arch-at91/at91_pio.h | 48 ++- drivers/gpio/at91_gpio.c | 130 +++- 2 files changed, 171 insertions(+), 7 deletions(-) diff --git a/arch/arm/include/asm/arch-at91/at91_pio.h b/arch/arm/include/asm/arch-at91/at91_pio.h index 416cabf..069368d 100644 --- a/arch/arm/include/asm/arch-at91/at91_pio.h +++ b/arch/arm/include/asm/arch-at91/at91_pio.h @@ -4,6 +4,7 @@ * Copyright (C) 2005 Ivan Kokshaysky * Copyright (C) SAN People [...] ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] onenand:samsung Target dependent OneNAND chip probe function
On 11/20/11, Marek Vasut wrote:
>> Separate callback for probing OneNAND memory chip.
>> If no special function is defined, default implementation will be used.
>>
>> This approach gives more flexibility for OneNAND device probing.
>>
>> Signed-off-by: Lukasz Majewski
>> Signed-off-by: Kyungmin Park
>> ---
>> ./tools/checkpatch.pl -
>> total: 0 errors, 0 warnings, 108 lines checked
>>
>> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
>> MULTISTATEMENT_MACRO_USE_DO_WHILE
>>
>> ---
>> drivers/mtd/onenand/onenand_base.c | 43
>> +- drivers/mtd/onenand/samsung.c |
>> 10
>> include/linux/mtd/onenand.h |1 +
>> include/linux/mtd/samsung_onenand.h |2 +
>> 4 files changed, 49 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/mtd/onenand/onenand_base.c
>> b/drivers/mtd/onenand/onenand_base.c index 24e02c2..a557d48 100644
>> --- a/drivers/mtd/onenand/onenand_base.c
>> +++ b/drivers/mtd/onenand/onenand_base.c
>> @@ -2505,23 +2505,24 @@ out:
>> }
>>
>> /**
>> - * onenand_probe - [OneNAND Interface] Probe the OneNAND device
>> + * onenand_chip_probe - [OneNAND Interface] Probe the OneNAND chip
>> * @param mtd MTD device structure
>> *
>> * OneNAND detection method:
>> * Compare the the values from command with ones from register
>> */
>> -static int onenand_probe(struct mtd_info *mtd)
>> +static int onenand_chip_probe(struct mtd_info *mtd)
>> {
>> struct onenand_chip *this = mtd->priv;
>> -int bram_maf_id, bram_dev_id, maf_id, dev_id, ver_id;
>> -int density;
>> +int bram_maf_id, bram_dev_id, maf_id, dev_id;
>> int syscfg;
>>
>> /* Save system configuration 1 */
>> syscfg = this->read_word(this->base + ONENAND_REG_SYS_CFG1);
>> +
>> /* Clear Sync. Burst Read mode to read BootRAM */
>> -this->write_word((syscfg & ~ONENAND_SYS_CFG1_SYNC_READ), this->base +
>> ONENAND_REG_SYS_CFG1); + this->write_word((syscfg &
>> ~ONENAND_SYS_CFG1_SYNC_READ),
>> + this->base + ONENAND_REG_SYS_CFG1);
>>
>> /* Send the command for reading device ID from BootRAM */
>> this->write_word(ONENAND_CMD_READID, this->base + ONENAND_BOOTRAM);
>> @@ -2546,13 +2547,38 @@ static int onenand_probe(struct mtd_info *mtd)
>> /* Read manufacturer and device IDs from Register */
>> maf_id = this->read_word(this->base + ONENAND_REG_MANUFACTURER_ID);
>> dev_id = this->read_word(this->base + ONENAND_REG_DEVICE_ID);
>> -ver_id = this->read_word(this->base + ONENAND_REG_VERSION_ID);
>> -this->technology = this->read_word(this->base + ONENAND_REG_TECHNOLOGY);
>>
>> /* Check OneNAND device */
>> if (maf_id != bram_maf_id || dev_id != bram_dev_id)
>> return -ENXIO;
>>
>> +return 0;
>> +}
>> +
>> +/**
>> + * onenand_probe - [OneNAND Interface] Probe the OneNAND device
>> + * @param mtd MTD device structure
>> + *
>> + * OneNAND detection method:
>> + * Compare the the values from command with ones from register
>> + */
>> +int onenand_probe(struct mtd_info *mtd)
>> +{
>> +struct onenand_chip *this = mtd->priv;
>> +int maf_id, dev_id, ver_id;
>> +int density;
>> +int ret;
>> +
>> +ret = this->chip_probe(mtd);
>> +if (ret)
>> +return ret;
>> +
>> +/* Read manufacturer and device IDs from Register */
>> +maf_id = this->read_word(this->base + ONENAND_REG_MANUFACTURER_ID);
>> +dev_id = this->read_word(this->base + ONENAND_REG_DEVICE_ID);
>> +ver_id = this->read_word(this->base + ONENAND_REG_VERSION_ID);
>> +this->technology = this->read_word(this->base + ONENAND_REG_TECHNOLOGY);
>> +
>> /* Flash device information */
>> mtd->name = onenand_print_device_info(dev_id, ver_id);
>> this->device_id = dev_id;
>> @@ -2659,6 +2685,9 @@ int onenand_scan(struct mtd_info *mtd, int maxchips)
>> if (!this->write_bufferram)
>> this->write_bufferram = onenand_write_bufferram;
>>
>> +if (!this->chip_probe)
>> +this->chip_probe = onenand_chip_probe;
>> +
>> if (!this->block_markbad)
>> this->block_markbad = onenand_default_block_markbad;
>> if (!this->scan_bbt)
>> diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c
>> index 20b4912..1f4bd81 100644
>> --- a/drivers/mtd/onenand/samsung.c
>> +++ b/drivers/mtd/onenand/samsung.c
>> @@ -590,6 +590,16 @@ static void s3c_set_width_regs(struct onenand_chip
>> *this) }
>> #endif
>>
>> +int s5pc110_chip_probe(struct mtd_info *mtd)
>> +{
>> +return 0;
>> +}
>> +
>> +int s5pc210_chip_probe(struct mtd_info *mtd)
>> +{
>> +return 0;
>> +}
>> +
>
> Will there be a problem if you used the default chip_probe() method from the
> driver ?
Samsung SoCs have their own OneNAND controller and difficult to access
OneNAND directly. instead it provides the registers which is mapped
OneNAND registers.
e.g., Manufacture ID, device ID and so on.
Y
[U-Boot] Your new friend.
Hello Dear, How are you today, Hope all is well with you and your family? My name is Miss Rama Djirama. However it really pleases me to write you for a lovely and sincere friendship even if we haven’t met or seen each other before. I will so much appreciate to see your reply soon so that we can share pictures and know more about ourselves. I shall appreciate an urgent response from you, because i have something to discuss with you. With lots of love from your new friend, Miss Rama Djirama.___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Efika: Configure additional regulators for HDMI output
2011/11/20 Marek Vasut > > > HDMI output doesn't work with current u-boot-imx tree (no LCD output > after > > 'setenv stdout lcd'), > > but works with current u-boot-marex/efikasb tree. > > > > Ok, so are you debugging it or not ? > No, I thought that if it works with u-boot-marex/efikasb, it's only a question of getting some more patches into u-boot-imx. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Allow for parallel builds and saved output
On Thursday 03 November 2011 03:28:29 Andy Fleming wrote:
> +if [ ! "${BUILD_NBUILDS}" ] ; then
> + BUILD_NBUILDS="1"
> +fi
: ${BUILD_NBUILDS:=1}
> + if [ ! "${BUILD_DIR}" ] ; then
> + BUILD_DIR="./build"
> + fi
: ${BUILD_DIR:=./build}
> + mkdir -p ${BUILD_DIR}/ERR
mkdir -p "${BUILD_DIR}/ERR"
> if [ ! "${BUILD_DIR}" ] ; then
> BUILD_DIR="."
> fi
: ${BUILD_DIR:=.}
> + mkdir -p ${output_dir}
mkdir -p "${output_dir}"
> + ${MAKE} clean
> + find "${output_dir}" -type f -name '*.depend' | xargs rm
why not use distclean and avoid the `find` ? otherwise, this find should be:
find "${output_dir}" -type f -name '*.depend' -exec rm -f {} +
> + ERR_CNT=$((ERR_CNT + 1))
: $(( ERR_CNT += 1 ))
> - build_target ${t}
> + if [ "$BUILD_NBUILDS" -gt 1 ] ; then
> + build_target ${t} &
> + else
> + build_target ${t}
> + fi
you could keep this one line as:
build_target ${t} &
[ ${BUILD_NBUILDS} -eq 1 ] && wait
> + TOTAL_CNT=$((TOTAL_CNT + 1))
: $(( TOTAL_CNT += 1 ))
> + CURRENT_COUNT=$((CURRENT_COUNT + 1))
: $(( CURRENT_COUNT += 1 ))
> + # Limit number of parallel builds
> + if [ ${CURRENT_COUNT} -gt ${BUILD_NBUILDS} ] ; then
> + CURRENT_COUNT=0;
> + wait;
> fi
you don't need those semicolons. also, this is not as good as it should be:
if you're running 10 jobs in parallel, you fork 10, and then you wait for all
of them to finish before forking another set of 10.
what you could do is something like:
JOB_IDX=0
JOB_IDX_FIRST=0
BUILD_NBUILDS=1
... foreach target ... ; do
build_target &
pids[$(( JOB_IDX++ ))]=$!
if [ $(( JOB_IDX - JOB_IDX_FIRST )) -ge ${BUILD_NBUILDS} ] ;
then
wait ${pids[$(( JOB_IDX_FIRST++ ))]}
fi
done
wait
this isn't perfect as it assumes the first job launched will always finish
first,
but it's a lot closer than the current code.
> + for file in `ls ${OUTPUT_PREFIX}/ERR/`; do
> + ERR_LIST="${ERR_LIST} $file"
> + done
ERR_LIST=$(ls ${OUTPUT_PREFIX}/ERR/)
> + ERR_CNT=`ls -l ${OUTPUT_PREFIX}/ERR/ | wc | awk '{print $1}'`
you should use -1 instead of -l
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] 【アフィリ通信】1件紹介するだけで5,000円！！
こんばんは。お得な情報を提供するオレンジ通信、美優です。 累計800本を販売した商材が、アフィリ報酬を大幅に引き上げ、 再販売が開始されています。 アフィリエイト報酬は50%以上！ 成約率も非常に高い数値が出ています。 是非、紹介活動を行ってみてください。 さらにこのメールを受け取った方からの紹介でご購入された方には、 特別に「メールサポート30日間」をボーナスとして追加。 「完全返金制度」もついているので、あなたに損はありません。 もう高額な商材を無理にお勧めする必要もありません。 以下、紹介例文 件名：1日30分で収入150万円超え 超円高が続いていますが、あなたはこの状況で 何もせずに時間を過ごしているのですか？ もったいないことです。 http://alley.jp/USamazon/it/ こちらのページをご覧下さい。 オークション国内第一人者のあの加藤賢さんも絶賛した、 折り紙付きのノウハウです。 1秒でも早くこの内容を実践すれば、あなたは他の人より、 ずっと成功に近づきます。 そう、あなたは途中で眠ってしまうことのないウサギとなり、 たくさんの亀をごぼう抜きし、トップを独走できる可能性さえあります。 いつまで販売されているか分かりませんので、 すぐに購入されることをお勧めします。 この内容を知らなければ人生、かなり損をします。 さらに本メールの読者特典として「30日間メールサポート」ボーナスをお付けいたします。 返金制度もあるので、安心してご購入できます。 例文ここまで ※この無料メルマガは、無料レポートのご請求、 懸賞への参加、協賛登録、くじ、占いサイト、 e-book等で登録された方に配信しております。 覚えがない方にはご迷惑をおかけ致しました。 ━ 広告内容に関する質問等は直接事業者にお問合せ下さい。 このようなご案内が不要の方は、誠にお手数ですが下記連絡先に一報下さい。 拒否通告:orenji_parks_k...@yahoo.co.jp 配信会社 ： オレンジパーク お問い合わせ先 E-MAIL:orenji_parks_k...@yahoo.co.jp ━ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] worth submitting a patch to fix u-boot for lite 5200b?
from back in april, karim yaghmour pointed out a problem related to older lite5200 boards, and suggested a fix: http://old.nabble.com/-U-Boot---PATCH--Env.-vars-fix-for-lite5200-td31013626.html i checked my git clone of u-boot and it seems that the file include/configs/IceCube.h still contains the original code: #if defined(CONFIG_SYS_LOWBOOT16) #define CONFIG_ENV_ADDR (CONFIG_SYS_FLASH_BASE + 0x0004) #endif #endif /* CONFIG_SYS_LOWBOOT */ #endif /* CONFIG_LITE5200B */ would it be proper to submit a patch to change 0x0004 to 0x0005? i admit i don't know enough about what else might be affected or what else might also need to change, i know only that that change is necessary for u-boot to run properly on that type of board. thoughts? is that an appropriate standalone patch? rday -- Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add PR1 Appliance - ISDN PRI board
Hi Mike, Your patch is nice and working and OK for me. :) I have noticed however that you have removed the random MAC generation which I would consider as a good feature. What is your reasoning behind this? Best Regards Dimitar - Original Message - From: "Mike Frysinger" To: "Dimitar Penev" Cc: Sent: Saturday, November 19, 2011 10:17 PM Subject: Re: [U-Boot] [PATCH] Add PR1 Appliance - ISDN PRI board ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] PXA: Drop CERF250 board
On Sunday 20 November 2011 03:41:49 Marek Vasut wrote: > > no changelog as to why it's being dropped ? > > Nope. It's unmaintained ... let's see if the author will speak to us or > not. does it fail to build ? is it missing some critical update ? a board that builds fine and probably works generally isn't considered from removal just because no commits have been made to it in a long time ... -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Efika: Configure additional regulators for HDMI output
> 2011/11/19 Marek Vasut > > > > 2011/11/17 Marek Vasut > > > > > > > Jana, you have efikamx and I can get you HDMI cable. Can you recheck > > > > tomorrow ? > > > > > > > > M > > > > > > Ok, I can. > > > > So any updates? > > HDMI output doesn't work with current u-boot-imx tree (no LCD output after > 'setenv stdout lcd'), > but works with current u-boot-marex/efikasb tree. > > Regards, > Jana Rapava Ok, so are you debugging it or not ? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc/85xx: Add workaround for erratum A-003474
Erratum A-003474: Internal DDR calibration circuit is not supported
Impact:
Experience shows no significant benefit to device operation with
auto-calibration enabled versus it disabled. To ensure consistent timing
results, Freescale recommends this feature be disabled in future customer
products. There should be no impact to parts that are already operating
in the field.
Workaround:
Prior to setting DDR_SDRAM_CFG[MEM_EN]=1, do the following:
1. Write a value of 0x_0015 to the register at offset
CCSRBAR + DDR OFFSET + 0xf30
2. Write a value of 0x2400_ to the register at offset
CCSRBAR + DDR OFFSET + 0xf54
Signed-off-by: York Sun
---
arch/powerpc/cpu/mpc85xx/cmd_errata.c |3 +++
arch/powerpc/cpu/mpc85xx/ddr-gen3.c |5 +
arch/powerpc/include/asm/config_mpc85xx.h |7 +++
3 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/cpu/mpc85xx/cmd_errata.c
b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
index f7c0934..1da5fe4 100644
--- a/arch/powerpc/cpu/mpc85xx/cmd_errata.c
+++ b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
@@ -56,6 +56,9 @@ static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc,
char * const argv[])
#if defined(CONFIG_SYS_FSL_ERRATUM_CPU_A003999)
puts("Work-around for Erratum CPU-A003999 enabled\n");
#endif
+#if defined(CONFIG_SYS_FSL_ERRATUM_DDR_A003474)
+ puts("Work-around for Erratum DDR-A003473 enabled\n");
+#endif
#if defined(CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN)
puts("Work-around for DDR MSYNC_IN Erratum enabled\n");
#endif
diff --git a/arch/powerpc/cpu/mpc85xx/ddr-gen3.c
b/arch/powerpc/cpu/mpc85xx/ddr-gen3.c
index c8c84a1..18e9cc5 100644
--- a/arch/powerpc/cpu/mpc85xx/ddr-gen3.c
+++ b/arch/powerpc/cpu/mpc85xx/ddr-gen3.c
@@ -115,6 +115,11 @@ void fsl_ddr_set_memctl_regs(const fsl_ddr_cfg_regs_t
*regs,
for (i = 0; i < 32; i++)
out_be32(&ddr->debug[i], regs->debug[i]);
+#ifdef CONFIG_SYS_FSL_ERRATUM_DDR_A003474
+ out_be32(&ddr->debug[12], 0x0015);
+ out_be32(&ddr->debug[21], 0x2400);
+#endif /* CONFIG_SYS_FSL_ERRATUM_DDR_A003474 */
+
/* Set, but do not enable the memory */
temp_sdram_cfg = regs->ddr_sdram_cfg;
temp_sdram_cfg &= ~(SDRAM_CFG_MEM_EN);
diff --git a/arch/powerpc/include/asm/config_mpc85xx.h
b/arch/powerpc/include/asm/config_mpc85xx.h
index dba9eda..2d73458 100644
--- a/arch/powerpc/include/asm/config_mpc85xx.h
+++ b/arch/powerpc/include/asm/config_mpc85xx.h
@@ -317,6 +317,7 @@
#define CONFIG_SYS_FSL_ERRATUM_ESDHC111
#define CONFIG_SYS_FSL_ERRATUM_USB138
#define CONFIG_SYS_FSL_ERRATUM_CPU_A003999
+#define CONFIG_SYS_FSL_ERRATUM_DDR_A003474
#elif defined(CONFIG_PPC_P2041)
#define CONFIG_MAX_CPUS4
@@ -337,6 +338,7 @@
#define CONFIG_SYS_FSL_ERRATUM_ESDHC111
#define CONFIG_SYS_FSL_ERRATUM_USB138
#define CONFIG_SYS_FSL_ERRATUM_CPU_A003999
+#define CONFIG_SYS_FSL_ERRATUM_DDR_A003474
#elif defined(CONFIG_PPC_P3041)
#define CONFIG_MAX_CPUS4
@@ -357,6 +359,7 @@
#define CONFIG_SYS_FSL_ERRATUM_ESDHC111
#define CONFIG_SYS_FSL_ERRATUM_USB138
#define CONFIG_SYS_FSL_ERRATUM_CPU_A003999
+#define CONFIG_SYS_FSL_ERRATUM_DDR_A003474
#elif defined(CONFIG_PPC_P3060)
#define CONFIG_MAX_CPUS8
@@ -384,6 +387,7 @@
#define CONFIG_SYS_FSL_PCIE_COMPAT "fsl,p4080-pcie"
#define CONFIG_SYS_CCSRBAR_DEFAULT 0xfe00
#define CONFIG_SYS_FSL_ERRATUM_CPU_A003999
+#define CONFIG_SYS_FSL_ERRATUM_DDR_A003474
#elif defined(CONFIG_PPC_P4080)
#define CONFIG_MAX_CPUS8
@@ -413,6 +417,7 @@
#define CONFIG_SYS_P4080_ERRATUM_SERDES_A001
#define CONFIG_SYS_P4080_ERRATUM_SERDES_A005
#define CONFIG_SYS_FSL_ERRATUM_CPU_A003999
+#define CONFIG_SYS_FSL_ERRATUM_DDR_A003474
/* P5010 is single core version of P5020 */
#elif defined(CONFIG_PPC_P5010)
@@ -433,6 +438,7 @@
#define CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY
#define CONFIG_SYS_FSL_ERRATUM_ESDHC111
#define CONFIG_SYS_FSL_ERRATUM_USB138
+#define CONFIG_SYS_FSL_ERRATUM_DDR_A003474
#elif defined(CONFIG_PPC_P5020)
#define CONFIG_MAX_CPUS2
@@ -452,6 +458,7 @@
#define CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY
#define CONFIG_SYS_FSL_ERRATUM_ESDHC111
#define CONFIG_SYS_FSL_ERRATUM_USB138
+#define CONFIG_SYS_FSL_ERRATUM_DDR_A003474
#else
#error Processor type not defined for this platform
--
1.7.0.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Efika: Configure additional regulators for HDMI output
2011/11/19 Marek Vasut > > 2011/11/17 Marek Vasut > > > > > Jana, you have efikamx and I can get you HDMI cable. Can you recheck > > > tomorrow ? > > > > > > M > > > > Ok, I can. > > So any updates? > HDMI output doesn't work with current u-boot-imx tree (no LCD output after 'setenv stdout lcd'), but works with current u-boot-marex/efikasb tree. Regards, Jana Rapava ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC PATCH 3/3] tegra2: Add support for Paz00 (Toshiba AC100)
Hi Stephen, first, thanks for looking at this! On Sunday 20 November 2011 13:10:08 Thierry Reding wrote: > * Stephen Warren wrote: > > The Toshiba AC100 (code-name Paz00m a/k/a Dynabook AZ) is an netbook > > derived from the NVIDIA Tegra Harmony reference board. It ships with > > Ubuntu, but is often repurposed to run Linux. This patch adds just > > enough support to get a U-Boot serial console, and the ability access > > built-in eMMC and the external SD slot. > > > > FIXME: Since this board is not marketed by NVIDIA (Toshiba is the > > vendor, and Compal the ODM), this board should possibly be moved out of > > the board/nvidia directory. > > > > Signed-off-by: Stephen Warren > > --- > > > > MAINTAINERS |1 + > > board/nvidia/paz00/Makefile | 41 ++ > > board/nvidia/paz00/paz00.c | 81 > > +++ boards.cfg > >|1 + > > include/configs/paz00.h | 52 +++ > > 5 files changed, 176 insertions(+), 0 deletions(-) > > create mode 100644 board/nvidia/paz00/Makefile > > create mode 100644 board/nvidia/paz00/paz00.c > > create mode 100644 include/configs/paz00.h > > [...] > > > diff --git a/include/configs/paz00.h b/include/configs/paz00.h > > new file mode 100644 > > index 000..fcec6fa > > --- /dev/null > > +++ b/include/configs/paz00.h > > @@ -0,0 +1,52 @@ > > +/* > > + * Copyright (c) 2010,2011, NVIDIA CORPORATION. All rights reserved. > > + * > > + * See file CREDITS for list of people who contributed to this > > + * project. > > + * > > + * This program is free software; you can redistribute it and/or modify > > it + * under the terms and conditions of the GNU General Public > > License, + * version 2, as published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope it will be useful, but > > WITHOUT + * ANY WARRANTY; without even the implied warranty of > > MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > General Public License for + * more details. > > + */ > > + > > +#ifndef __CONFIG_H > > +#define __CONFIG_H > > + > > +#include > > +#include "tegra2-common.h" > > + > > +/* High-level configuration options */ > > +#define TEGRA2_SYSMEM "mem=384M@0M nvmem=128M@384M" > > Can we get rid of this? I think I remember some discussion about the same > topic going on the linux-tegra/devicetree mailing lists, where it was > decided that /mem-reserve/ entries should be dropped until some driver in > the mainline kernel was actually going to use this memory. Perhaps U-Boot > should take the same approach. I also vote for this. Additionally, most users prefer mem=448M here. The device was original ships with 448 MB user memory, which was later reduced to 384 MB, maybe because of flash player requirements. I'm also not sure if nvmem is needed at all (maybe for android original kernel only) > > +#define V_PROMPT "Tegra2 (Paz00) # " > > +#define CONFIG_TEGRA2_BOARD_STRING "NVIDIA Paz00" > > + > > +/* Board-specific serial config */ > > +#define CONFIG_SERIAL_MULTI > > +#define CONFIG_TEGRA2_ENABLE_UARTA > > +#define CONFIG_SYS_NS16550_COM1NV_PA_APB_UARTA_BASE > > + > > +#define CONFIG_MACH_TYPE MACH_TYPE_PAZ00 > > +/* > > + * The following should be 512MB, but I don't know how to set that > > value > > + * It doesn't matter, since this isn't really used any more > > + */ > > +#define CONFIG_SYS_BOARD_ODMDATA 0x200d8011 /* lp1, 1GB */ I don't know what is the effect of this paramter, but paz00 has 512 MB. The original valu was 0x8000c0085, AFAIK, which leaves most stuff on the default value. Marc > > + > > +#define CONFIG_BOARD_EARLY_INIT_F > > + > > +/* SD/MMC */ > > +#define CONFIG_MMC > > +#define CONFIG_GENERIC_MMC > > +#define CONFIG_TEGRA2_MMC > > +#define CONFIG_CMD_MMC > > + > > +#define CONFIG_DOS_PARTITION > > +#define CONFIG_EFI_PARTITION > > +#define CONFIG_CMD_EXT2 > > +#define CONFIG_CMD_FAT > > +#endif /* __CONFIG_H */ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC PATCH 0/3] tegra2: Add paz00 support
On Sunday 20 November 2011 13:05:58 Thierry Reding wrote: > * Stephen Warren wrote: > > This patch series adds support for the Toshiba AC100 Tegra netbook. > > > > I'm posting it as an RFC because: > > > > a) The AC100 is designed by Compal and marketed by Toshiba. Should we > > put > > the files into board/nvidia (since it uses an NVIDIA SoC), or create a > > board/toshiba or board/compal directory to contain this? > > I don't think it should go into board/nvidia. Directories below board are > supposed to be vendor directories and NVIDIA isn't the vendor of the AC100. > I have a slight tendency for preferring toshiba over compal mostly because I > think that's what people will be looking for first. we had this discussion during addition of devicetree support to paz00 in the linux kernel already. The balance tended more into the direction of Compal, because 1) there exist two machines with different names with this board (Toshiba AC100 and Dynabook AZ) and 2) Toshibas/Dynabooks code name seems to be "Procyon" while paz00 is the code name at Compal. Having compal/paz00 in the kernel and Toshiba/procyon in u-boot would just add confusion and renaming everything is maybe not worth the effort (Toshiba/paz00 is totaly wrong). Marc > > b) It'll need rebasing on top of some of the many outstanding Tegra > > patches before it can be applied. > > > > Stephen Warren (3): > > MAINTAINERS: Fix my email address > > tegra2: Fix conflicting pinmux for UARTA > > tegra2: Add support for Paz00 (Toshiba AC100) > > > > MAINTAINERS |3 +- > > board/nvidia/common/board.c | 12 ++ > > board/nvidia/paz00/Makefile | 49 > > board/nvidia/paz00/paz00.c | 88 > > +++ boards.cfg > >|1 + > > include/configs/paz00.h | 59 + > > 6 files changed, 211 insertions(+), 1 deletions(-) > > create mode 100644 board/nvidia/paz00/Makefile > > create mode 100644 board/nvidia/paz00/paz00.c > > create mode 100644 include/configs/paz00.h ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Allow for parallel builds and saved output
On Nov 20, 2011, at 12:11 AM, Simon Glass wrote:
> Hi Kumar,
>
> On Tue, Nov 8, 2011 at 5:48 AM, Kumar Gala wrote:
>>
>> On Nov 3, 2011, at 11:22 AM, Simon Glass wrote:
>>
>>> Hi Andy,
>>>
>>> On Thu, Nov 3, 2011 at 12:28 AM, Andy Fleming
>>> wrote:
The MAKEALL script cleverly runs make with the appropriate options
to use all of the cores on the system, but your average U-Boot build
can't make much use of more than a few cores. If you happen to have
a many-core server, your builds will leave most of the system idle.
In order to make full use of such a system, we need to build multiple
targets in parallel, and this requires directing make output into
multiple directories. We add a BUILD_NBUILDS variable, which allows
users to specify how many builds to run in parallel. I've found that
16 is too many on my system (fork starts to fail). When BUILD_NBUILDS
is set greater than 1, we redefine BUILD_DIR for each build to be
${BUILD_DIR}/${target}. Also, we make "./build" the default BUILD_DIR
when BUILD_NBUILDS is greater than 1.
Once each build finishes, we run make clean on its directory, to reduce
the footprint, and also remove all .depend files.
As a result, we are left with a build directory with all of the built
targets still there for use, which means anyone who wanted to use
MAKEALL as part of a test harness can now do so.
Signed-off-by: Andy Fleming
---
Inspired by all the MAKEALL improvements, I decided to clean up my old
one for parallel builds. I think this version addresses the concerns
raised last time...
>>>
>>
>> I see an issue if I have a build in working tree already. I think we might
>> need a distclean before starting
>>
>> I also it seems this does things in clumps of BUILD_NBUILDS. What I mean
>> is, if BUILD_NBUILDS is 4, you do 4 and wait for all 4 to finish before
>> starting the 5th job once the 1st is complete. Anything we can do about
>> that to always try and have 4 builds going until the end?
>>
>> - k
>
> What is the issue you see? Given that it uses an empty output dir for
> each build, I can't see what could be wrong.
I think if I have an existing build in my source tree it screws up between that
and the O= build.
> I am seeing a strange issue which is probably my fault. In a whole
> MAKEALL maybe one build (always mx31 so far) fails with errors like
> this:
>
> $ more logs/mx31pdk.ERR
> mv: cannot stat
> `/c/cosarm/buildall/u-boot/build/mx31pdk/include/autoconf.mk.tmp
> ': No such file or directory
> /c/cosarm/buildall/u-boot/include/timestamp.h:27: fatal error:
> generated/timesta
> mp_autogenerated.h: No such file or directory
> compilation terminated.
> make[1]: *** No rule to make target
> `/c/cosarm/buildall/u-boot/build/mx31pdk/arc
> h/arm/cpu/arm1136/.depend', needed by `_depend'. Stop.
> In file included from /c/cosarm/buildall/u-boot/include/version.h:27:0,
> from mkimage.c:26:
> /c/cosarm/buildall/u-boot/include/timestamp.h:27:47: fatal error:
> generated/time
> stamp_autogenerated.h: No such file or directory
> compilation terminated.
>
>
> /c/cosarm/buildall/u-boot/include/timestamp.h:27: fatal error:
> generated/timesta
> mp_autogenerated.h: No such file or directory
> compilation terminated.
> make[1]: *** No rule to make target
> `/c/cosarm/buildall/u-boot/build/imx31_phyco
> re/arch/arm/cpu/arm1136/.depend', needed by `_depend'. Stop.
> In file included from /c/cosarm/buildall/u-boot/include/version.h:27:0,
> from mkimage.c:26:
> /c/cosarm/buildall/u-boot/include/timestamp.h:27:47: fatal error:
> generated/time
> stamp_autogenerated.h: No such file or directory
> compilation terminated.
> make[1]: *** [/c/cosarm/buildall/u-boot/build/imx31_phycore/tools/mkimage.o]
> Err
> or 1
> make: *** [tools] Error 2
>
>
> I really can't see that Andy's change can affect this, but perhaps it
> provokes an existing bug by changing the timing. I see the issue when
> building 16 U-Boots at a time.
>
> I haven't looked into it in detail - maybe there is a dependency
> missing in the Makefile. But I would have thought that this line would
> ensure that these files exist before anything else is done:
>
> depend dep: $(TIMESTAMP_FILE) $(VERSION_FILE) \
> ...
>
> Regards,
> Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 10/14] OMAP3 SPL: Add identify_nand_chip function
On Sun, Nov 20, 2011 at 12:36 AM, Igor Grinberg wrote: > Hi Tom, > > On 11/19/11 00:48, Tom Rini wrote: >> A number of boards are populated with a PoP chip for both DDR and NAND >> memory. Other boards may simply use this as an easy way to identify >> board revs. So we provide a function that can be called early to reset >> the NAND chip and return the result of NAND_CMD_READID. All of this >> code is put into spl_id_nand.c and controlled via CONFIG_SPL_OMAP3_ID_NAND. >> >> Signed-off-by: Tom Rini >> --- >> arch/arm/cpu/armv7/omap3/Makefile | 3 + >> arch/arm/cpu/armv7/omap3/spl_id_nand.c | 87 >> +++ >> arch/arm/include/asm/arch-omap3/sys_proto.h | 1 + >> 3 files changed, 91 insertions(+), 0 deletions(-) >> create mode 100644 arch/arm/cpu/armv7/omap3/spl_id_nand.c >> >> diff --git a/arch/arm/cpu/armv7/omap3/Makefile >> b/arch/arm/cpu/armv7/omap3/Makefile >> index 8e85891..4b38e45 100644 >> --- a/arch/arm/cpu/armv7/omap3/Makefile >> +++ b/arch/arm/cpu/armv7/omap3/Makefile >> @@ -31,6 +31,9 @@ COBJS += board.o >> COBJS += clock.o >> COBJS += mem.o >> COBJS += sys_info.o >> +ifdef CONFIG_SPL_BUILD >> +COBJS-$(CONFIG_SPL_OMAP3_ID_NAND) += spl_id_nand.o >> +endif > > You haven't responded to my question on the above stuff. > Otherwise all the series look good to me. Missed that, sorry! > > Original version available at: > http://www.mail-archive.com/u-boot@lists.denx.de/msg68828.html > > Here is the relevant part: > diff --git a/arch/arm/cpu/armv7/omap3/Makefile b/arch/arm/cpu/armv7/omap3/Makefile >>> index 8e85891..772f3d4 100644 >>> --- a/arch/arm/cpu/armv7/omap3/Makefile >>> +++ b/arch/arm/cpu/armv7/omap3/Makefile >>> @@ -31,6 +31,9 @@ COBJS += board.o >>> COBJS += clock.o >>> COBJS += mem.o >>> COBJS += sys_info.o >>> +ifdef CONFIG_SPL_BUILD >>> +COBJS-$(CONFIG_SPL_OMAP3_POP_PROBE) += spl_pop_probe.o >>> +endif >>> >> >>> >> Can't CONFIG_SPL_OMAP3_..._PROBE symbol default to "no" >>> >> and depend on CONFIG_SPL_BUILD, so you don't need to enclose >>> >> it in #ifdef? >> > >> > But then it would build for both SPL and non-SPL cases. > > No, it should not. > What do you think of the following: > In the Makefile have only: > COBJS-$(CONFIG_SPL_OMAP3_POP_PROBE) += spl_pop_probe.o > > Then in the spl_pop_probe.c have this type of check: > #ifndef CONFIG_SPL_BUILD > # error CONFIG_SPL_OMAP3_POP_PROBE requires CONFIG_SPL_BUILD > #endif > > This way, you require the CONFIG_SPL_OMAP3_POP_PROBE symbol > be a part of the CONFIG_SPL_BUILD symbols group. Well, if we always link this, but then #error, U-Boot won't build :) I guess the reason to not #ifndef CONFIG_SPL_BUILD the whole file is that the normal style for SPL is to only include the file when building for SPL. -- Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] NAND: remove NAND_MAX_CHIPS definitions
This change follows the change by Wolfgang Grandegger (commit 6c869637fef),
which allows to remove useless NAND_MAX_CHIPS definitions in board config
files.
Signed-off-by: Vladimir Zapolskiy
Cc: Wolfgang Grandegger
Cc: Scott Wood
---
include/configs/P1_P2_RDB.h |3 +--
include/configs/SIMPC8313.h |3 +--
include/configs/VCMA9.h |1 -
include/configs/aria.h |4
include/configs/bf526-ezbrd.h |1 -
include/configs/bf527-ad7160-eval.h |1 -
include/configs/bf527-ezkit.h |1 -
include/configs/bf548-ezkit.h |1 -
include/configs/cm-bf527.h |1 -
include/configs/cpu9260.h |1 -
include/configs/da830evm.h |1 -
include/configs/da850_am18xxevm.h |1 -
include/configs/da850evm.h |1 -
include/configs/ea20.h |1 -
include/configs/hawkboard.h |1 -
include/configs/km/km_arm.h |1 -
include/configs/m28evk.h|1 -
include/configs/mecp5123.h |2 --
include/configs/mpc5121ads.h|1 -
include/configs/mv-common.h |1 -
include/configs/pdm360ng.h |2 --
include/configs/pm9261.h|1 -
include/configs/qi_lb60.h |1 -
include/configs/smdk2410.h |1 -
include/configs/tnetv107x_evm.h |1 -
25 files changed, 2 insertions(+), 32 deletions(-)
diff --git a/include/configs/P1_P2_RDB.h b/include/configs/P1_P2_RDB.h
index 00fa74d..cee788a 100644
--- a/include/configs/P1_P2_RDB.h
+++ b/include/configs/P1_P2_RDB.h
@@ -273,11 +273,10 @@ extern unsigned long get_board_sys_clk(unsigned long
dummy);
#endif
#endif
+#define CONFIG_CMD_NAND
#define CONFIG_SYS_NAND_BASE_LIST {CONFIG_SYS_NAND_BASE}
#define CONFIG_SYS_MAX_NAND_DEVICE 1
-#define NAND_MAX_CHIPS 1
#define CONFIG_MTD_NAND_VERIFY_WRITE
-#define CONFIG_CMD_NAND1
#define CONFIG_NAND_FSL_ELBC 1
#define CONFIG_SYS_NAND_BLOCK_SIZE (16 * 1024)
diff --git a/include/configs/SIMPC8313.h b/include/configs/SIMPC8313.h
index 77be360..0976077 100644
--- a/include/configs/SIMPC8313.h
+++ b/include/configs/SIMPC8313.h
@@ -144,10 +144,9 @@
#endif
#define CONFIG_SYS_FPGA_BASE 0xFF00
+#define CONFIG_CMD_NAND
#define CONFIG_SYS_MAX_NAND_DEVICE 1
-#define NAND_MAX_CHIPS 1
#define CONFIG_MTD_NAND_VERIFY_WRITE
-#define CONFIG_CMD_NAND1
#define CONFIG_NAND_FSL_ELBC 1
#define CONFIG_SYS_NAND_BR_PRELIM (CONFIG_SYS_NAND_BASE \
diff --git a/include/configs/VCMA9.h b/include/configs/VCMA9.h
index a370c15..5cc8ece 100644
--- a/include/configs/VCMA9.h
+++ b/include/configs/VCMA9.h
@@ -237,7 +237,6 @@
#define CONFIG_NAND_S3C2410
#define CONFIG_SYS_S3C2410_NAND_HWECC
#define CONFIG_SYS_MAX_NAND_DEVICE 1
-#define NAND_MAX_CHIPS 1
#define CONFIG_SYS_NAND_BASE 0x4E00
#define CONFIG_S3C24XX_CUSTOM_NAND_TIMING
#define CONFIG_S3C24XX_TACLS 1
diff --git a/include/configs/aria.h b/include/configs/aria.h
index cf2e7d4..c9f0076 100644
--- a/include/configs/aria.h
+++ b/include/configs/aria.h
@@ -247,13 +247,9 @@
*/
#define CONFIG_CMD_NAND/* enable NAND
support */
#define CONFIG_JFFS2_NAND /* with JFFS2 on it */
-
-
#define CONFIG_NAND_MPC5121_NFC
#define CONFIG_SYS_NAND_BASE 0x4000
-
#define CONFIG_SYS_MAX_NAND_DEVICE 1
-#define NAND_MAX_CHIPS CONFIG_SYS_MAX_NAND_DEVICE
/*
* Configuration parameters for MPC5121 NAND driver
diff --git a/include/configs/bf526-ezbrd.h b/include/configs/bf526-ezbrd.h
index 1945c03..0031093 100644
--- a/include/configs/bf526-ezbrd.h
+++ b/include/configs/bf526-ezbrd.h
@@ -70,7 +70,6 @@
#define CONFIG_DRIVER_NAND_BFIN
#define CONFIG_SYS_NAND_BASE 0 /* not actually used */
#define CONFIG_SYS_MAX_NAND_DEVICE 1
-#define NAND_MAX_CHIPS 1
#define CONFIG_CMD_NAND
#endif
diff --git a/include/configs/bf527-ad7160-eval.h
b/include/configs/bf527-ad7160-eval.h
index 9c35f2d..fa05103 100644
--- a/include/configs/bf527-ad7160-eval.h
+++ b/include/configs/bf527-ad7160-eval.h
@@ -69,7 +69,6 @@
#define CONFIG_DRIVER_NAND_BFIN
#define CONFIG_SYS_NAND_BASE 0 /* not actually used */
#define CONFIG_SYS_MAX_NAND_DEVICE 1
-#define NAND_MAX_CHIPS 1
#endif
diff --git a/include/configs/bf527-ezkit.h b/include/configs/bf527-ezkit.h
index 1256e81..d80eac2 100644
--- a/include/configs/bf527-ezkit.h
+++ b/include/configs/bf527-ezkit.h
@@ -69,7 +69,6 @@
#define CONFIG_DRIVER_NAND_BFIN
#define CONFIG_SYS_NAND_BASE 0 /* not actually used */
#define CONFIG_SYS_MAX_NAND_DEVICE 1
-#define NAND_MAX_CHIPS 1
#endif
diff --git a/include/configs/bf548-ezkit.h b/include/configs/bf548-ezkit.h
index 3eadcef..89adfef 100644
---
[U-Boot] [PATCH] NAND: remove remaining NAND_MAX_CHIPS definitions
This change follows the change by Wolfgang Grandegger (commit 6c869637fef), which allows to remove useless NAND_MAX_CHIPS definitions in board config files. The change is based on u-boot.git/master, this branch contains 3 new boards with the defined NAND_MAX_CHIPS macro, which are not present in u-boot-nand-flash.git/master. Vladimir Zapolskiy (1): NAND: remove NAND_MAX_CHIPS definitions include/configs/P1_P2_RDB.h |3 +-- include/configs/SIMPC8313.h |3 +-- include/configs/VCMA9.h |1 - include/configs/aria.h |4 include/configs/bf526-ezbrd.h |1 - include/configs/bf527-ad7160-eval.h |1 - include/configs/bf527-ezkit.h |1 - include/configs/bf548-ezkit.h |1 - include/configs/cm-bf527.h |1 - include/configs/cpu9260.h |1 - include/configs/da830evm.h |1 - include/configs/da850_am18xxevm.h |1 - include/configs/da850evm.h |1 - include/configs/ea20.h |1 - include/configs/hawkboard.h |1 - include/configs/km/km_arm.h |1 - include/configs/m28evk.h|1 - include/configs/mecp5123.h |2 -- include/configs/mpc5121ads.h|1 - include/configs/mv-common.h |1 - include/configs/pdm360ng.h |2 -- include/configs/pm9261.h|1 - include/configs/qi_lb60.h |1 - include/configs/smdk2410.h |1 - include/configs/tnetv107x_evm.h |1 - 25 files changed, 2 insertions(+), 32 deletions(-) -- 1.7.5.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC PATCH 3/3] tegra2: Add support for Paz00 (Toshiba AC100)
* Stephen Warren wrote: > The Toshiba AC100 (code-name Paz00m a/k/a Dynabook AZ) is an netbook derived > from the NVIDIA Tegra Harmony reference board. It ships with Ubuntu, but is > often repurposed to run Linux. This patch adds just enough support to get a > U-Boot serial console, and the ability access built-in eMMC and the external > SD slot. > > FIXME: Since this board is not marketed by NVIDIA (Toshiba is the vendor, and > Compal the ODM), this board should possibly be moved out of the board/nvidia > directory. > > Signed-off-by: Stephen Warren > --- > MAINTAINERS |1 + > board/nvidia/paz00/Makefile | 41 ++ > board/nvidia/paz00/paz00.c | 81 > +++ > boards.cfg |1 + > include/configs/paz00.h | 52 +++ > 5 files changed, 176 insertions(+), 0 deletions(-) > create mode 100644 board/nvidia/paz00/Makefile > create mode 100644 board/nvidia/paz00/paz00.c > create mode 100644 include/configs/paz00.h [...] > diff --git a/include/configs/paz00.h b/include/configs/paz00.h > new file mode 100644 > index 000..fcec6fa > --- /dev/null > +++ b/include/configs/paz00.h > @@ -0,0 +1,52 @@ > +/* > + * Copyright (c) 2010,2011, NVIDIA CORPORATION. All rights reserved. > + * > + * See file CREDITS for list of people who contributed to this > + * project. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + */ > + > +#ifndef __CONFIG_H > +#define __CONFIG_H > + > +#include > +#include "tegra2-common.h" > + > +/* High-level configuration options */ > +#define TEGRA2_SYSMEM"mem=384M@0M nvmem=128M@384M" Can we get rid of this? I think I remember some discussion about the same topic going on the linux-tegra/devicetree mailing lists, where it was decided that /mem-reserve/ entries should be dropped until some driver in the mainline kernel was actually going to use this memory. Perhaps U-Boot should take the same approach. Thierry > +#define V_PROMPT "Tegra2 (Paz00) # " > +#define CONFIG_TEGRA2_BOARD_STRING "NVIDIA Paz00" > + > +/* Board-specific serial config */ > +#define CONFIG_SERIAL_MULTI > +#define CONFIG_TEGRA2_ENABLE_UARTA > +#define CONFIG_SYS_NS16550_COM1 NV_PA_APB_UARTA_BASE > + > +#define CONFIG_MACH_TYPE MACH_TYPE_PAZ00 > +/* > + * The following should be 512MB, but I don't know how to set that value > + * It doesn't matter, since this isn't really used any more > + */ > +#define CONFIG_SYS_BOARD_ODMDATA 0x200d8011 /* lp1, 1GB */ > + > +#define CONFIG_BOARD_EARLY_INIT_F > + > +/* SD/MMC */ > +#define CONFIG_MMC > +#define CONFIG_GENERIC_MMC > +#define CONFIG_TEGRA2_MMC > +#define CONFIG_CMD_MMC > + > +#define CONFIG_DOS_PARTITION > +#define CONFIG_EFI_PARTITION > +#define CONFIG_CMD_EXT2 > +#define CONFIG_CMD_FAT > +#endif /* __CONFIG_H */ > -- > 1.7.5.4 > > > pgpkiHiWSyUqz.pgp Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC PATCH 0/3] tegra2: Add paz00 support
* Stephen Warren wrote: > This patch series adds support for the Toshiba AC100 Tegra netbook. > > I'm posting it as an RFC because: > > a) The AC100 is designed by Compal and marketed by Toshiba. Should we put > the files into board/nvidia (since it uses an NVIDIA SoC), or create a > board/toshiba or board/compal directory to contain this? I don't think it should go into board/nvidia. Directories below board are supposed to be vendor directories and NVIDIA isn't the vendor of the AC100. I have a slight tendency for preferring toshiba over compal mostly because I think that's what people will be looking for first. Thierry > b) It'll need rebasing on top of some of the many outstanding Tegra > patches before it can be applied. > > Stephen Warren (3): > MAINTAINERS: Fix my email address > tegra2: Fix conflicting pinmux for UARTA > tegra2: Add support for Paz00 (Toshiba AC100) > > MAINTAINERS |3 +- > board/nvidia/common/board.c | 12 ++ > board/nvidia/paz00/Makefile | 49 > board/nvidia/paz00/paz00.c | 88 > +++ > boards.cfg |1 + > include/configs/paz00.h | 59 + > 6 files changed, 211 insertions(+), 1 deletions(-) > create mode 100644 board/nvidia/paz00/Makefile > create mode 100644 board/nvidia/paz00/paz00.c > create mode 100644 include/configs/paz00.h > > -- > 1.7.5.4 > > > pgp9L7Ykpnwp9.pgp Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] PXA: Drop CERF250 board
> no changelog as to why it's being dropped ? > -mike Nope. It's unmaintained ... let's see if the author will speak to us or not. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
