Re: [U-Boot] [PATCH 00/17] arm: ls1021atwr: Convert to use driver model TSEC driver

[Joe Hershberger]

Hi Bin,

On Mon, Jan 25, 2016 at 8:45 PM, Bin Meng  wrote:
> On Wed, Jan 20, 2016 at 1:16 AM, york sun  wrote:
>> On 01/17/2016 09:16 PM, Bin Meng wrote:
>>> Joe, York,
>>>
>>> On Tue, Jan 12, 2016 at 2:41 PM, Bin Meng  wrote:
 This series adds driver model ethernet support to the Freescale
 TSEC ethernet driver and convert ls1021atwr board to use it.

 Enable the support in the ls1021atwr_nor_defconfig and
 ls1021atwr_nor_lpuart_defconfig configurations.


 Bin Meng (17):
   powerpc: bsc9132qds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
   powerpc: c29xpcie: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
   powerpc: mpc8572ds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
   powerpc: mpc8548cds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
   powerpc: p1010rdb: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
   arm: ls1021atwr: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>
>> I think separating TSEC from PCI eth is correct.
>>
   net: tsec: fsl_mdio: Fix several cosmetic issues
   net: tsec: Move rx_idx and tx_idx to struct tsec_private
   net: tsec: Move rxbd and txbd to struct tsec_private
>>
>> I don't see problem with above change. I didn't test them though.
>>
>
> Thanks York.
>
   net: tsec: Adjust orders to avoid forward declaration of tsec_send()
   net: tsec: Use tsec_private pointer as the parameter for internal
 routines
   doc: dt-bindings: Describe Freescale TSEC ethernet controller
   net: tsec: Add driver model ethernet support
   net: tsec: Use priv->tbiaddr to initialize TBI PHY address
   arm: ls102xa: Rewrite the logic of ft_fixup_enet_phy_connect_type()
>
> Hi Joe, I see this series are assigned to you. If the first 15 patches
> are OK, please apply it directly so that I can save some time
> including them in v2.

OK, I have reviewed the first 15 and will take them now for build testing.

   arm: ls1021atwr: Disable CONFIG_E1000 temporarily
   arm: ls1021atwr: Convert to use driver model TSEC driver
>>
>
> Since York has some comments regarding to CONFIG_E1000, I will work on
> the remaining 2 patches in v2, together with DM PCI conversion.
>
>> I haven't tested your patch. Just a reminder, please keep it in mind to have
>> "git bisect" always working, in case we need to find something later. My
>> previous comment on disabling E1000 for ls1021atwr still stands.
>>
>> York
>>
>
> Regards,
> Bin
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 00/17] arm: ls1021atwr: Convert to use driver model TSEC driver

[Bin Meng]

On Wed, Jan 20, 2016 at 1:16 AM, york sun  wrote:
> On 01/17/2016 09:16 PM, Bin Meng wrote:
>> Joe, York,
>>
>> On Tue, Jan 12, 2016 at 2:41 PM, Bin Meng  wrote:
>>> This series adds driver model ethernet support to the Freescale
>>> TSEC ethernet driver and convert ls1021atwr board to use it.
>>>
>>> Enable the support in the ls1021atwr_nor_defconfig and
>>> ls1021atwr_nor_lpuart_defconfig configurations.
>>>
>>>
>>> Bin Meng (17):
>>>   powerpc: bsc9132qds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>>   powerpc: c29xpcie: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>>   powerpc: mpc8572ds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>>   powerpc: mpc8548cds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>>   powerpc: p1010rdb: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>>   arm: ls1021atwr: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>
> I think separating TSEC from PCI eth is correct.
>
>>>   net: tsec: fsl_mdio: Fix several cosmetic issues
>>>   net: tsec: Move rx_idx and tx_idx to struct tsec_private
>>>   net: tsec: Move rxbd and txbd to struct tsec_private
>
> I don't see problem with above change. I didn't test them though.
>

Thanks York.

>>>   net: tsec: Adjust orders to avoid forward declaration of tsec_send()
>>>   net: tsec: Use tsec_private pointer as the parameter for internal
>>> routines
>>>   doc: dt-bindings: Describe Freescale TSEC ethernet controller
>>>   net: tsec: Add driver model ethernet support
>>>   net: tsec: Use priv->tbiaddr to initialize TBI PHY address
>>>   arm: ls102xa: Rewrite the logic of ft_fixup_enet_phy_connect_type()

Hi Joe, I see this series are assigned to you. If the first 15 patches
are OK, please apply it directly so that I can save some time
including them in v2.

>>>   arm: ls1021atwr: Disable CONFIG_E1000 temporarily
>>>   arm: ls1021atwr: Convert to use driver model TSEC driver
>

Since York has some comments regarding to CONFIG_E1000, I will work on
the remaining 2 patches in v2, together with DM PCI conversion.

> I haven't tested your patch. Just a reminder, please keep it in mind to have
> "git bisect" always working, in case we need to find something later. My
> previous comment on disabling E1000 for ls1021atwr still stands.
>
> York
>

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 00/17] arm: ls1021atwr: Convert to use driver model TSEC driver

[york sun]

On 01/17/2016 09:16 PM, Bin Meng wrote:
> Joe, York,
> 
> On Tue, Jan 12, 2016 at 2:41 PM, Bin Meng  wrote:
>> This series adds driver model ethernet support to the Freescale
>> TSEC ethernet driver and convert ls1021atwr board to use it.
>>
>> Enable the support in the ls1021atwr_nor_defconfig and
>> ls1021atwr_nor_lpuart_defconfig configurations.
>>
>>
>> Bin Meng (17):
>>   powerpc: bsc9132qds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>   powerpc: c29xpcie: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>   powerpc: mpc8572ds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>   powerpc: mpc8548cds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>   powerpc: p1010rdb: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>>   arm: ls1021atwr: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET

I think separating TSEC from PCI eth is correct.

>>   net: tsec: fsl_mdio: Fix several cosmetic issues
>>   net: tsec: Move rx_idx and tx_idx to struct tsec_private
>>   net: tsec: Move rxbd and txbd to struct tsec_private

I don't see problem with above change. I didn't test them though.

>>   net: tsec: Adjust orders to avoid forward declaration of tsec_send()
>>   net: tsec: Use tsec_private pointer as the parameter for internal
>> routines
>>   doc: dt-bindings: Describe Freescale TSEC ethernet controller
>>   net: tsec: Add driver model ethernet support
>>   net: tsec: Use priv->tbiaddr to initialize TBI PHY address
>>   arm: ls102xa: Rewrite the logic of ft_fixup_enet_phy_connect_type()
>>   arm: ls1021atwr: Disable CONFIG_E1000 temporarily
>>   arm: ls1021atwr: Convert to use driver model TSEC driver

I haven't tested your patch. Just a reminder, please keep it in mind to have
"git bisect" always working, in case we need to find something later. My
previous comment on disabling E1000 for ls1021atwr still stands.

York

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 00/17] arm: ls1021atwr: Convert to use driver model TSEC driver

[Bin Meng]

Joe, York,

On Tue, Jan 12, 2016 at 2:41 PM, Bin Meng  wrote:
> This series adds driver model ethernet support to the Freescale
> TSEC ethernet driver and convert ls1021atwr board to use it.
>
> Enable the support in the ls1021atwr_nor_defconfig and
> ls1021atwr_nor_lpuart_defconfig configurations.
>
>
> Bin Meng (17):
>   powerpc: bsc9132qds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>   powerpc: c29xpcie: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>   powerpc: mpc8572ds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>   powerpc: mpc8548cds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>   powerpc: p1010rdb: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>   arm: ls1021atwr: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
>   net: tsec: fsl_mdio: Fix several cosmetic issues
>   net: tsec: Move rx_idx and tx_idx to struct tsec_private
>   net: tsec: Move rxbd and txbd to struct tsec_private
>   net: tsec: Adjust orders to avoid forward declaration of tsec_send()
>   net: tsec: Use tsec_private pointer as the parameter for internal
> routines
>   doc: dt-bindings: Describe Freescale TSEC ethernet controller
>   net: tsec: Add driver model ethernet support
>   net: tsec: Use priv->tbiaddr to initialize TBI PHY address
>   arm: ls102xa: Rewrite the logic of ft_fixup_enet_phy_connect_type()
>   arm: ls1021atwr: Disable CONFIG_E1000 temporarily
>   arm: ls1021atwr: Convert to use driver model TSEC driver
>
>  arch/arm/cpu/armv7/ls102xa/cpu.c  |   2 +-
>  arch/arm/cpu/armv7/ls102xa/fdt.c  |  26 +-
>  arch/arm/dts/ls1021a-twr.dts  |  20 +
>  arch/arm/dts/ls1021a.dtsi |  18 +-
>  board/freescale/bsc9132qds/bsc9132qds.c   |   4 +-
>  board/freescale/c29xpcie/c29xpcie.c   |   4 +-
>  board/freescale/ls1021atwr/ls1021atwr.c   |   4 +-
>  board/freescale/mpc8548cds/mpc8548cds.c   |   4 +-
>  board/freescale/mpc8572ds/mpc8572ds.c |   4 +-
>  board/freescale/p1010rdb/p1010rdb.c   |   4 +-
>  configs/ls1021atwr_nor_defconfig  |   3 +-
>  configs/ls1021atwr_nor_lpuart_defconfig   |   3 +-
>  doc/device-tree-bindings/net/fsl-tsec-phy.txt |  64 +++
>  drivers/net/fsl_mdio.c|   4 +-
>  drivers/net/tsec.c| 536 
> ++
>  include/configs/ls1021atwr.h  |   4 +
>  include/fsl_mdio.h|   7 +-
>  include/tsec.h|  69 ++--
>  18 files changed, 546 insertions(+), 234 deletions(-)
>  create mode 100644 doc/device-tree-bindings/net/fsl-tsec-phy.txt
>

I wonder if you can post some review comments if any before I spin a v2?

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 00/17] arm: ls1021atwr: Convert to use driver model TSEC driver

[Bin Meng]

This series adds driver model ethernet support to the Freescale
TSEC ethernet driver and convert ls1021atwr board to use it.

Enable the support in the ls1021atwr_nor_defconfig and
ls1021atwr_nor_lpuart_defconfig configurations.


Bin Meng (17):
  powerpc: bsc9132qds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
  powerpc: c29xpcie: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
  powerpc: mpc8572ds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
  powerpc: mpc8548cds: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
  powerpc: p1010rdb: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
  arm: ls1021atwr: Do not wrap pci_eth_init() with CONFIG_TSEC_ENET
  net: tsec: fsl_mdio: Fix several cosmetic issues
  net: tsec: Move rx_idx and tx_idx to struct tsec_private
  net: tsec: Move rxbd and txbd to struct tsec_private
  net: tsec: Adjust orders to avoid forward declaration of tsec_send()
  net: tsec: Use tsec_private pointer as the parameter for internal
routines
  doc: dt-bindings: Describe Freescale TSEC ethernet controller
  net: tsec: Add driver model ethernet support
  net: tsec: Use priv->tbiaddr to initialize TBI PHY address
  arm: ls102xa: Rewrite the logic of ft_fixup_enet_phy_connect_type()
  arm: ls1021atwr: Disable CONFIG_E1000 temporarily
  arm: ls1021atwr: Convert to use driver model TSEC driver

 arch/arm/cpu/armv7/ls102xa/cpu.c  |   2 +-
 arch/arm/cpu/armv7/ls102xa/fdt.c  |  26 +-
 arch/arm/dts/ls1021a-twr.dts  |  20 +
 arch/arm/dts/ls1021a.dtsi |  18 +-
 board/freescale/bsc9132qds/bsc9132qds.c   |   4 +-
 board/freescale/c29xpcie/c29xpcie.c   |   4 +-
 board/freescale/ls1021atwr/ls1021atwr.c   |   4 +-
 board/freescale/mpc8548cds/mpc8548cds.c   |   4 +-
 board/freescale/mpc8572ds/mpc8572ds.c |   4 +-
 board/freescale/p1010rdb/p1010rdb.c   |   4 +-
 configs/ls1021atwr_nor_defconfig  |   3 +-
 configs/ls1021atwr_nor_lpuart_defconfig   |   3 +-
 doc/device-tree-bindings/net/fsl-tsec-phy.txt |  64 +++
 drivers/net/fsl_mdio.c|   4 +-
 drivers/net/tsec.c| 536 ++
 include/configs/ls1021atwr.h  |   4 +
 include/fsl_mdio.h|   7 +-
 include/tsec.h|  69 ++--
 18 files changed, 546 insertions(+), 234 deletions(-)
 create mode 100644 doc/device-tree-bindings/net/fsl-tsec-phy.txt

-- 
1.8.2.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot