Re: [U-Boot] [PATCH 00/11 V10] EXYNOS5420: Add SMDK5420 board support

2013-12-10 Thread Rajeshwari Birje
Hi Minkyu Kang,

Please do let me know if any coments on this patch set.

On Mon, Dec 9, 2013 at 2:20 PM, Rajeshwari S Shinde
 wrote:
> This patch adds basic board support for SMDK5420 board.
> These patches are tested for booting fine on EVT1 SMDK5420.
>
> Changes in V2:
> - Corrected a compilation issue for SMDK5420.
>
> Changes in V3:
> - Add patch to support variable size SPL support
> - Add patch to disable SMU for eMMC.
>
> Changes in V4:
> - Added check for MAX77686 pmic compilation.
> - Added correct calculation of gpio based addresses.
> - Rebased on the latest u-boot code.
> - Removed patches for UART and TZPC changes as
> they were not needed.
> - Added flag to disable SMU for eMMC.
>
> Changes in V5:
> - Moved functions board_mmc_init and board_eth_init
> to common/board.c in case of device tree support.
>
> Changes in V6:
> - Rebased on the latest mainline branch.
> - Moved the definitions for SMU to arch/arm dwmmc.h
>
> Changes in V7:
> - Removed below patch as it is already merged
> "DWMMC: SMDK5420: Disable SMU for eMMC"
> - Corrected the multi line comments and removal of
> blank spaces and lines.
> - Corrected the license.
>
> Changes in V8:
> - corrected the if loops with if conditions of
> pro_id and cpu_id.
>
> Changes in V9:
> - Added macros to get the base address
> - Rebased on latest code.
>
> Changes in V10:
> - Added new structures for Power and DMC registers for
> 5420.
> - Changed the input parameters for common dmc functions.
> - Removed unnecesarry blank lines and added where ever required.
>
> Rajeshwari S Shinde (11):
>   EXYNOS5: Create a common board file
>   Exynos5420: Add base addresses for 5420
>   EXYNOS5420: Add power register structure.
>   EXYNOS5420: Add dmc and phy_control register structure
>   Exynos5420: Add clock initialization for 5420
>   Exynos5420: Add DDR3 initialization for 5420
>   Exynos5420: Add support for 5420 in pinmux and gpio
>   Exynos5420: Add base patch for SMDK5420
>   DTS: Add dts support for SMDK5420
>   Config: Add initial config for SMDK5420
>   SPL: EXYNOS: Prepare for variable size SPL support
>
>  arch/arm/cpu/armv7/exynos/clock.c  | 280 -
>  arch/arm/cpu/armv7/exynos/clock_init.h |  17 +
>  arch/arm/cpu/armv7/exynos/clock_init_exynos5.c | 352 ++-
>  arch/arm/cpu/armv7/exynos/dmc_common.c |  60 +-
>  arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c  | 439 -
>  arch/arm/cpu/armv7/exynos/exynos5_setup.h  | 764 --
>  arch/arm/cpu/armv7/exynos/pinmux.c | 260 +++-
>  arch/arm/dts/exynos5.dtsi  | 198 ++
>  arch/arm/dts/exynos5250.dtsi   | 194 +-
>  arch/arm/dts/exynos5420.dtsi   |  70 +++
>  arch/arm/include/asm/arch-exynos/board.h   |  17 +
>  arch/arm/include/asm/arch-exynos/clk.h |   1 +
>  arch/arm/include/asm/arch-exynos/clock.h   | 494 +++
>  arch/arm/include/asm/arch-exynos/cpu.h |  52 +-
>  arch/arm/include/asm/arch-exynos/dmc.h | 177 ++
>  arch/arm/include/asm/arch-exynos/gpio.h| 143 -
>  arch/arm/include/asm/arch-exynos/periph.h  |   3 +
>  arch/arm/include/asm/arch-exynos/power.h   | 837 
> +
>  board/samsung/common/Makefile  |   4 +
>  board/samsung/common/board.c   | 410 
>  board/samsung/dts/exynos5420-smdk5420.dts  | 169 +
>  board/samsung/smdk5250/exynos5-dt.c| 352 +--
>  board/samsung/smdk5250/smdk5250.c  | 182 +-
>  board/samsung/smdk5420/Makefile|  11 +
>  board/samsung/smdk5420/smdk5420.c  | 159 +
>  board/samsung/smdk5420/smdk5420_spl.c  |  52 ++
>  boards.cfg |   1 +
>  include/configs/arndale.h  |   1 +
>  include/configs/exynos5-dt.h   | 289 +
>  include/configs/exynos5250-dt.h| 283 +
>  include/configs/smdk5420.h |  56 ++
>  spl/Makefile   |   7 +-
>  tools/Makefile |   3 +-
>  tools/mkexynosspl.c| 167 +++--
>  34 files changed, 5189 insertions(+), 1315 deletions(-)
>  create mode 100644 arch/arm/dts/exynos5.dtsi
>  create mode 100644 arch/arm/dts/exynos5420.dtsi
>  create mode 100644 arch/arm/include/asm/arch-exynos/board.h
>  create mode 100644 board/samsung/common/board.c
>  create mode 100644 board/samsung/dts/exynos5420-smdk5420.dts
>  create mode 100644 board/samsung/smdk5420/Makefile
>  create mode 100644 board/samsung/smdk5420/smdk5420.c
>  create mode 100644 board/samsung/smdk5420/smdk5420_spl.c
>  create mode 100644 include

Re: [U-Boot] [PATCH 00/11 V10] EXYNOS5420: Add SMDK5420 board support

2013-12-12 Thread Rajeshwari Birje
Hi Minkyu Kang,

Can we get this patch set reviewed..

On Wed, Dec 11, 2013 at 9:55 AM, Rajeshwari Birje
 wrote:
> Hi Minkyu Kang,
>
> Please do let me know if any coments on this patch set.
>
> On Mon, Dec 9, 2013 at 2:20 PM, Rajeshwari S Shinde
>  wrote:
>> This patch adds basic board support for SMDK5420 board.
>> These patches are tested for booting fine on EVT1 SMDK5420.
>>
>> Changes in V2:
>> - Corrected a compilation issue for SMDK5420.
>>
>> Changes in V3:
>> - Add patch to support variable size SPL support
>> - Add patch to disable SMU for eMMC.
>>
>> Changes in V4:
>> - Added check for MAX77686 pmic compilation.
>> - Added correct calculation of gpio based addresses.
>> - Rebased on the latest u-boot code.
>> - Removed patches for UART and TZPC changes as
>> they were not needed.
>> - Added flag to disable SMU for eMMC.
>>
>> Changes in V5:
>> - Moved functions board_mmc_init and board_eth_init
>> to common/board.c in case of device tree support.
>>
>> Changes in V6:
>> - Rebased on the latest mainline branch.
>> - Moved the definitions for SMU to arch/arm dwmmc.h
>>
>> Changes in V7:
>> - Removed below patch as it is already merged
>> "DWMMC: SMDK5420: Disable SMU for eMMC"
>> - Corrected the multi line comments and removal of
>> blank spaces and lines.
>> - Corrected the license.
>>
>> Changes in V8:
>> - corrected the if loops with if conditions of
>> pro_id and cpu_id.
>>
>> Changes in V9:
>> - Added macros to get the base address
>> - Rebased on latest code.
>>
>> Changes in V10:
>> - Added new structures for Power and DMC registers for
>> 5420.
>> - Changed the input parameters for common dmc functions.
>> - Removed unnecesarry blank lines and added where ever required.
>>
>> Rajeshwari S Shinde (11):
>>   EXYNOS5: Create a common board file
>>   Exynos5420: Add base addresses for 5420
>>   EXYNOS5420: Add power register structure.
>>   EXYNOS5420: Add dmc and phy_control register structure
>>   Exynos5420: Add clock initialization for 5420
>>   Exynos5420: Add DDR3 initialization for 5420
>>   Exynos5420: Add support for 5420 in pinmux and gpio
>>   Exynos5420: Add base patch for SMDK5420
>>   DTS: Add dts support for SMDK5420
>>   Config: Add initial config for SMDK5420
>>   SPL: EXYNOS: Prepare for variable size SPL support
>>
>>  arch/arm/cpu/armv7/exynos/clock.c  | 280 -
>>  arch/arm/cpu/armv7/exynos/clock_init.h |  17 +
>>  arch/arm/cpu/armv7/exynos/clock_init_exynos5.c | 352 ++-
>>  arch/arm/cpu/armv7/exynos/dmc_common.c |  60 +-
>>  arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c  | 439 -
>>  arch/arm/cpu/armv7/exynos/exynos5_setup.h  | 764 --
>>  arch/arm/cpu/armv7/exynos/pinmux.c | 260 +++-
>>  arch/arm/dts/exynos5.dtsi  | 198 ++
>>  arch/arm/dts/exynos5250.dtsi   | 194 +-
>>  arch/arm/dts/exynos5420.dtsi   |  70 +++
>>  arch/arm/include/asm/arch-exynos/board.h   |  17 +
>>  arch/arm/include/asm/arch-exynos/clk.h |   1 +
>>  arch/arm/include/asm/arch-exynos/clock.h   | 494 +++
>>  arch/arm/include/asm/arch-exynos/cpu.h |  52 +-
>>  arch/arm/include/asm/arch-exynos/dmc.h | 177 ++
>>  arch/arm/include/asm/arch-exynos/gpio.h| 143 -
>>  arch/arm/include/asm/arch-exynos/periph.h  |   3 +
>>  arch/arm/include/asm/arch-exynos/power.h   | 837 
>> +
>>  board/samsung/common/Makefile  |   4 +
>>  board/samsung/common/board.c   | 410 
>>  board/samsung/dts/exynos5420-smdk5420.dts  | 169 +
>>  board/samsung/smdk5250/exynos5-dt.c| 352 +--
>>  board/samsung/smdk5250/smdk5250.c  | 182 +-
>>  board/samsung/smdk5420/Makefile|  11 +
>>  board/samsung/smdk5420/smdk5420.c  | 159 +
>>  board/samsung/smdk5420/smdk5420_spl.c  |  52 ++
>>  boards.cfg |   1 +
>>  include/configs/arndale.h  |   1 +
>>  include/configs/exynos5-dt.h   | 289 +
>>  include/configs/exynos5250-dt.h| 283 +
>>  include/configs/smdk5420.h |  56 ++
>>  spl/Makefile   |   7 +-
>>  tools/Makefile |   3 +-
>>  tools/mkexynosspl.c| 167 +++--
>>  34 files changed, 5189 insertions(+), 1315 deletions(-)
>>  create mode 100644 arch/arm/dts/exynos5.dtsi
>>  create mode 100644 arch/arm/dts/exynos5420.dtsi
>>  create mode 100644 arch/arm/include/asm/arch-exynos/board.h
>>  create mode 100644 board/samsung/common/board.c
>>  create mode 100644 board/samsung/dts