Re: aspectj includes
Vincent,
This is the code I added to the plugin.jelly file in the aspectj-plugin
to make it weave into other jars.
This goes right below in the aspectj:weave-internal goal.
Also, I had to take out copyInJars from the task. You don't need
it with aspectj-1.1.1.
Try it out. Let me know your results.
Thanks.
Charlie
Vincent Massol wrote:
-Original Message-
From: Charles N. Harvey III [mailto:[EMAIL PROTECTED]
Sent: 09 February 2004 23:01
To: Maven Users List
Subject: Re: aspectj includes
I don't know why they aren't associated with the aspected jar.
Here's what happens, runs and creates my app.jar with class
files and resources (regular files). Then runs on that jar
since it cannot run on a filesystem. That task creates two jars,
app.jar and app-nonweaved.jar. The nonweaved.jar has the same
properties file as my original app.jar. But the new app.jar in the
target directory is completely resource free. It is really
aggravating.
Ah ok. I would need to look at the aspectj plugin code to remember
exactly what it's doing (sorry I did this some time ago). I'm sure you
are right
Do you see this happening? Am I nuts? I'll keep trying. Thanks for
the tip.
No you're not nuts! It's probably me not remembering how I implemented
the aspectj plugin. Sorry about that.
Oh yeah, one more thing... why does this appear every time?
[iajc] couldn't find aspectjrt.jar on classpath, checked:
Its just a warning, and the compile/package/weave works just fine.
But
I don't get why it always tells me it can't find that jar, when I know
it can because it compiles. Oh well.
I'd like to know too. This has been puzzling me, especially as
everything works fine. I haven't had the time to debug it and find the
reason (I've always suspected it was a bug in aspectj output but I may
be wrong).
Thanks
-Vincent
Charlie
Vincent Massol wrote:
You cannot compare ajc with jar. One is about compiling the other
about
packaging. You must compare ajc with javac. But yes, I see your point
about including resource in a jar. Fortunately it's quite easy to do
with Ant. Simply use the task using update="true" as an
attribute.
That said, what I don't understand is why these resources are not
packaged when you call the jar goal? Is it because these resources
are
only related to AOP?
Thanks
-Vincent
-Original Message-
From: Charles N. Harvey III [mailto:[EMAIL PROTECTED]
Sent: 09 February 2004 21:55
To: Maven Users List
Subject: Re: aspectj includes
As far as I can tell, the java (jar:jar) command does do it all in
one
step. This is because has "includes" and "excludes" as
part
of the task. So whatever specified gets included or excluded. I
don't
see a second step in the plugin.jelly file for the java or jar
plugin.
And, I guess I don't really get it. How do you copy files into a
zip
that has already been zipped? I guess that is possible, I just have
never done it.
Any tips?
Charlie
Vincent Massol wrote:
Charles,
Why do you want to have the copying happen in the ajc step? Why not
simply do it in a second copy step as it is done for the java
plugin?
Thanks
-Vincent
-Original Message-
From: Charles N. Harvey III [mailto:[EMAIL PROTECTED]
Sent: 09 February 2004 20:52
To: Maven Users List
Subject: Re: aspectj includes
Vincent,
I don't think it is possible yet. Since everything runs under the
task and that task does not have any properties that
include
files other than .java and .aj. The bug below shows that the goal
(possibly for 1.2) is to change "-injars" to "-inpath" so
directories
are supported. I asked if that means that all files in the
directory
will be included but have not yet heard back.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=46347
Charlie
Vincent Massol wrote:
Hi Charles,
The current version of the aspectj plugin does not support
copying
resource files. If you have time, please submit a patch :-)
Thanks
-Vincent
-Original Message-
From: Charles N. Harvey III [mailto:[EMAIL PROTECTED]
Sent: 02 February 2004 17:20
To: Maven Users List
Subject: aspectj includes
Hello.
'Nother aspectj question that probably can't be answered, but I
will
ask anyway. How can I include *.properties or *.xml files in my
aspected jar? No matter what I seem to do my static files are
never
copied over into the jar. Which, of course, makes my app fail.
It even strips them out when I do . The original jar
has
properti
RE: aspectj includes
> -Original Message- > From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] > Sent: 09 February 2004 23:01 > To: Maven Users List > Subject: Re: aspectj includes > > I don't know why they aren't associated with the aspected jar. > Here's what happens, runs and creates my app.jar with class > files and resources (regular files). Then runs on that jar > since it cannot run on a filesystem. That task creates two jars, > app.jar and app-nonweaved.jar. The nonweaved.jar has the same > properties file as my original app.jar. But the new app.jar in the > target directory is completely resource free. It is really aggravating. Ah ok. I would need to look at the aspectj plugin code to remember exactly what it's doing (sorry I did this some time ago). I'm sure you are right > > Do you see this happening? Am I nuts? I'll keep trying. Thanks for > the tip. No you're not nuts! It's probably me not remembering how I implemented the aspectj plugin. Sorry about that. > > > Oh yeah, one more thing... why does this appear every time? > > [iajc] couldn't find aspectjrt.jar on classpath, checked: > > Its just a warning, and the compile/package/weave works just fine. But > I don't get why it always tells me it can't find that jar, when I know > it can because it compiles. Oh well. I'd like to know too. This has been puzzling me, especially as everything works fine. I haven't had the time to debug it and find the reason (I've always suspected it was a bug in aspectj output but I may be wrong). Thanks -Vincent > > > Charlie > > > > Vincent Massol wrote: > > >You cannot compare ajc with jar. One is about compiling the other about > >packaging. You must compare ajc with javac. But yes, I see your point > >about including resource in a jar. Fortunately it's quite easy to do > >with Ant. Simply use the task using update="true" as an attribute. > > > >That said, what I don't understand is why these resources are not > >packaged when you call the jar goal? Is it because these resources are > >only related to AOP? > > > >Thanks > >-Vincent > > > > > > > >>-Original Message- > >>From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] > >>Sent: 09 February 2004 21:55 > >>To: Maven Users List > >>Subject: Re: aspectj includes > >> > >>As far as I can tell, the java (jar:jar) command does do it all in one > >>step. This is because has "includes" and "excludes" as part > >>of the task. So whatever specified gets included or excluded. I > >> > >> > >don't > > > > > >>see a second step in the plugin.jelly file for the java or jar plugin. > >> > >>And, I guess I don't really get it. How do you copy files into a zip > >>that has already been zipped? I guess that is possible, I just have > >>never done it. > >> > >>Any tips? > >> > >> > >>Charlie > >> > >> > >> > >>Vincent Massol wrote: > >> > >> > >> > >>>Charles, > >>> > >>>Why do you want to have the copying happen in the ajc step? Why not > >>>simply do it in a second copy step as it is done for the java plugin? > >>> > >>>Thanks > >>>-Vincent > >>> > >>> > >>> > >>> > >>> > >>>>-Original Message- > >>>>From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] > >>>>Sent: 09 February 2004 20:52 > >>>>To: Maven Users List > >>>>Subject: Re: aspectj includes > >>>> > >>>>Vincent, > >>>>I don't think it is possible yet. Since everything runs under the > >>>> task and that task does not have any properties that > >>>> > >>>> > >>>> > >>>> > >>>include > >>> > >>> > >>> > >>> > >>>>files other than .java and .aj. The bug below shows that the goal > >>>>(possibly for 1.2) is to change "-injars" to "-inpath" so > >>>> > >>>> > >directories > > > > > >>>>are supported. I asked if that means that all files in the > >>>> > >>>> > >directory > > > > > >>>>will be included but have not yet heard back.
Re: aspectj includes
I don't know why they aren't associated with the aspected jar. Here's what happens, runs and creates my app.jar with class files and resources (regular files). Then runs on that jar since it cannot run on a filesystem. That task creates two jars, app.jar and app-nonweaved.jar. The nonweaved.jar has the same properties file as my original app.jar. But the new app.jar in the target directory is completely resource free. It is really aggravating. Do you see this happening? Am I nuts? I'll keep trying. Thanks for the tip. Oh yeah, one more thing... why does this appear every time? [iajc] couldn't find aspectjrt.jar on classpath, checked: Its just a warning, and the compile/package/weave works just fine. But I don't get why it always tells me it can't find that jar, when I know it can because it compiles. Oh well. Charlie Vincent Massol wrote: You cannot compare ajc with jar. One is about compiling the other about packaging. You must compare ajc with javac. But yes, I see your point about including resource in a jar. Fortunately it's quite easy to do with Ant. Simply use the task using update="true" as an attribute. That said, what I don't understand is why these resources are not packaged when you call the jar goal? Is it because these resources are only related to AOP? Thanks -Vincent -Original Message- From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] Sent: 09 February 2004 21:55 To: Maven Users List Subject: Re: aspectj includes As far as I can tell, the java (jar:jar) command does do it all in one step. This is because has "includes" and "excludes" as part of the task. So whatever specified gets included or excluded. I don't see a second step in the plugin.jelly file for the java or jar plugin. And, I guess I don't really get it. How do you copy files into a zip that has already been zipped? I guess that is possible, I just have never done it. Any tips? Charlie Vincent Massol wrote: Charles, Why do you want to have the copying happen in the ajc step? Why not simply do it in a second copy step as it is done for the java plugin? Thanks -Vincent -Original Message- From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] Sent: 09 February 2004 20:52 To: Maven Users List Subject: Re: aspectj includes Vincent, I don't think it is possible yet. Since everything runs under the task and that task does not have any properties that include files other than .java and .aj. The bug below shows that the goal (possibly for 1.2) is to change "-injars" to "-inpath" so directories are supported. I asked if that means that all files in the directory will be included but have not yet heard back. https://bugs.eclipse.org/bugs/show_bug.cgi?id=46347 Charlie Vincent Massol wrote: Hi Charles, The current version of the aspectj plugin does not support copying resource files. If you have time, please submit a patch :-) Thanks -Vincent -Original Message- From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] Sent: 02 February 2004 17:20 To: Maven Users List Subject: aspectj includes Hello. 'Nother aspectj question that probably can't be answered, but I will ask anyway. How can I include *.properties or *.xml files in my aspected jar? No matter what I seem to do my static files are never copied over into the jar. Which, of course, makes my app fail. It even strips them out when I do . The original jar has properties files but the new aspected one does not. Pretty frustrating. Any tips would be much appreciated. Thanks. Charlie - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: aspectj includes
You cannot compare ajc with jar. One is about compiling the other about packaging. You must compare ajc with javac. But yes, I see your point about including resource in a jar. Fortunately it's quite easy to do with Ant. Simply use the task using update="true" as an attribute. That said, what I don't understand is why these resources are not packaged when you call the jar goal? Is it because these resources are only related to AOP? Thanks -Vincent > -Original Message- > From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] > Sent: 09 February 2004 21:55 > To: Maven Users List > Subject: Re: aspectj includes > > As far as I can tell, the java (jar:jar) command does do it all in one > step. This is because has "includes" and "excludes" as part > of the task. So whatever specified gets included or excluded. I don't > see a second step in the plugin.jelly file for the java or jar plugin. > > And, I guess I don't really get it. How do you copy files into a zip > that has already been zipped? I guess that is possible, I just have > never done it. > > Any tips? > > > Charlie > > > > Vincent Massol wrote: > > >Charles, > > > >Why do you want to have the copying happen in the ajc step? Why not > >simply do it in a second copy step as it is done for the java plugin? > > > >Thanks > >-Vincent > > > > > > > >>-Original Message- > >>From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] > >>Sent: 09 February 2004 20:52 > >>To: Maven Users List > >>Subject: Re: aspectj includes > >> > >>Vincent, > >>I don't think it is possible yet. Since everything runs under the > >> task and that task does not have any properties that > >> > >> > >include > > > > > >>files other than .java and .aj. The bug below shows that the goal > >>(possibly for 1.2) is to change "-injars" to "-inpath" so directories > >>are supported. I asked if that means that all files in the directory > >>will be included but have not yet heard back. > >> > >>https://bugs.eclipse.org/bugs/show_bug.cgi?id=46347 > >> > >> > >>Charlie > >> > >> > >>Vincent Massol wrote: > >> > >> > >> > >>>Hi Charles, > >>> > >>>The current version of the aspectj plugin does not support copying > >>>resource files. If you have time, please submit a patch :-) > >>> > >>>Thanks > >>>-Vincent > >>> > >>> > >>> > >>> > >>> > >>>>-Original Message- > >>>>From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] > >>>>Sent: 02 February 2004 17:20 > >>>>To: Maven Users List > >>>>Subject: aspectj includes > >>>> > >>>>Hello. > >>>>'Nother aspectj question that probably can't be answered, but I will > >>>>ask anyway. How can I include *.properties or *.xml files in my > >>>>aspected jar? No matter what I seem to do my static files are never > >>>>copied over into the jar. Which, of course, makes my app fail. > >>>> > >>>>It even strips them out when I do . The original jar has > >>>>properties files but the new aspected one does not. Pretty > >>>> > >>>> > >>>> > >>>> > >>>frustrating. > >>> > >>> > >>> > >>> > >>>>Any tips would be much appreciated. > >>>> > >>>>Thanks. > >>>> > >>>> > >>>>Charlie > >>>> > >>>> > >>>> > >>>> > >>>- > >>> > >>> > >>>>To unsubscribe, e-mail: [EMAIL PROTECTED] > >>>>For additional commands, e-mail: [EMAIL PROTECTED] > >>>> > >>>> > >>>> > >>>> > >>> > >>>- > >>>To unsubscribe, e-mail: [EMAIL PROTECTED] > >>>For additional commands, e-mail: [EMAIL PROTECTED] > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>- > >>To unsubscribe, e-mail: [EMAIL PROTECTED] > >>For additional commands, e-mail: [EMAIL PROTECTED] > >> > >> > > > > > > > >- > >To unsubscribe, e-mail: [EMAIL PROTECTED] > >For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: aspectj includes
As far as I can tell, the java (jar:jar) command does do it all in one step. This is because has "includes" and "excludes" as part of the task. So whatever specified gets included or excluded. I don't see a second step in the plugin.jelly file for the java or jar plugin. And, I guess I don't really get it. How do you copy files into a zip that has already been zipped? I guess that is possible, I just have never done it. Any tips? Charlie Vincent Massol wrote: Charles, Why do you want to have the copying happen in the ajc step? Why not simply do it in a second copy step as it is done for the java plugin? Thanks -Vincent -Original Message- From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] Sent: 09 February 2004 20:52 To: Maven Users List Subject: Re: aspectj includes Vincent, I don't think it is possible yet. Since everything runs under the task and that task does not have any properties that include files other than .java and .aj. The bug below shows that the goal (possibly for 1.2) is to change "-injars" to "-inpath" so directories are supported. I asked if that means that all files in the directory will be included but have not yet heard back. https://bugs.eclipse.org/bugs/show_bug.cgi?id=46347 Charlie Vincent Massol wrote: Hi Charles, The current version of the aspectj plugin does not support copying resource files. If you have time, please submit a patch :-) Thanks -Vincent -Original Message- From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] Sent: 02 February 2004 17:20 To: Maven Users List Subject: aspectj includes Hello. 'Nother aspectj question that probably can't be answered, but I will ask anyway. How can I include *.properties or *.xml files in my aspected jar? No matter what I seem to do my static files are never copied over into the jar. Which, of course, makes my app fail. It even strips them out when I do . The original jar has properties files but the new aspected one does not. Pretty frustrating. Any tips would be much appreciated. Thanks. Charlie - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: aspectj includes
Charles, Why do you want to have the copying happen in the ajc step? Why not simply do it in a second copy step as it is done for the java plugin? Thanks -Vincent > -Original Message- > From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] > Sent: 09 February 2004 20:52 > To: Maven Users List > Subject: Re: aspectj includes > > Vincent, > I don't think it is possible yet. Since everything runs under the > task and that task does not have any properties that include > files other than .java and .aj. The bug below shows that the goal > (possibly for 1.2) is to change "-injars" to "-inpath" so directories > are supported. I asked if that means that all files in the directory > will be included but have not yet heard back. > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=46347 > > > Charlie > > > Vincent Massol wrote: > > >Hi Charles, > > > >The current version of the aspectj plugin does not support copying > >resource files. If you have time, please submit a patch :-) > > > >Thanks > >-Vincent > > > > > > > >>-----Original Message- > >>From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] > >>Sent: 02 February 2004 17:20 > >>To: Maven Users List > >>Subject: aspectj includes > >> > >>Hello. > >>'Nother aspectj question that probably can't be answered, but I will > >>ask anyway. How can I include *.properties or *.xml files in my > >>aspected jar? No matter what I seem to do my static files are never > >>copied over into the jar. Which, of course, makes my app fail. > >> > >>It even strips them out when I do . The original jar has > >>properties files but the new aspected one does not. Pretty > >> > >> > >frustrating. > > > > > >>Any tips would be much appreciated. > >> > >>Thanks. > >> > >> > >>Charlie > >> > >> > >>- > >>To unsubscribe, e-mail: [EMAIL PROTECTED] > >>For additional commands, e-mail: [EMAIL PROTECTED] > >> > >> > > > > > > > >- > >To unsubscribe, e-mail: [EMAIL PROTECTED] > >For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: aspectj includes
Vincent, I don't think it is possible yet. Since everything runs under the task and that task does not have any properties that include files other than .java and .aj. The bug below shows that the goal (possibly for 1.2) is to change "-injars" to "-inpath" so directories are supported. I asked if that means that all files in the directory will be included but have not yet heard back. https://bugs.eclipse.org/bugs/show_bug.cgi?id=46347 Charlie Vincent Massol wrote: Hi Charles, The current version of the aspectj plugin does not support copying resource files. If you have time, please submit a patch :-) Thanks -Vincent -Original Message- From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] Sent: 02 February 2004 17:20 To: Maven Users List Subject: aspectj includes Hello. 'Nother aspectj question that probably can't be answered, but I will ask anyway. How can I include *.properties or *.xml files in my aspected jar? No matter what I seem to do my static files are never copied over into the jar. Which, of course, makes my app fail. It even strips them out when I do . The original jar has properties files but the new aspected one does not. Pretty frustrating. Any tips would be much appreciated. Thanks. Charlie - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: aspectj includes
I've been trying. Its tricky stuff. I'll try looking into the jar plugin to see how it reads the and try to copy that to the aspectj plugin. Oh yeah, with MavenNG, will it still use maven.xml - since maven.xml is jelly based and MavenNG does not seem to be using jelly? Just wondering where I should invest my efforts. :) Charlie Vincent Massol wrote: Hi Charles, The current version of the aspectj plugin does not support copying resource files. If you have time, please submit a patch :-) Thanks -Vincent -Original Message- From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] Sent: 02 February 2004 17:20 To: Maven Users List Subject: aspectj includes Hello. 'Nother aspectj question that probably can't be answered, but I will ask anyway. How can I include *.properties or *.xml files in my aspected jar? No matter what I seem to do my static files are never copied over into the jar. Which, of course, makes my app fail. It even strips them out when I do . The original jar has properties files but the new aspected one does not. Pretty frustrating. Any tips would be much appreciated. Thanks. Charlie - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: aspectj includes
Hi Charles, The current version of the aspectj plugin does not support copying resource files. If you have time, please submit a patch :-) Thanks -Vincent > -Original Message- > From: Charles N. Harvey III [mailto:[EMAIL PROTECTED] > Sent: 02 February 2004 17:20 > To: Maven Users List > Subject: aspectj includes > > Hello. > 'Nother aspectj question that probably can't be answered, but I will > ask anyway. How can I include *.properties or *.xml files in my > aspected jar? No matter what I seem to do my static files are never > copied over into the jar. Which, of course, makes my app fail. > > It even strips them out when I do . The original jar has > properties files but the new aspected one does not. Pretty frustrating. > > Any tips would be much appreciated. > > Thanks. > > > Charlie > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
aspectj includes
Hello. 'Nother aspectj question that probably can't be answered, but I will ask anyway. How can I include *.properties or *.xml files in my aspected jar? No matter what I seem to do my static files are never copied over into the jar. Which, of course, makes my app fail. It even strips them out when I do . The original jar has properties files but the new aspected one does not. Pretty frustrating. Any tips would be much appreciated. Thanks. Charlie - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
