Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18248/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2890/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1478/ : 0 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 3: Build Started (2/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18248/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 3: Build Started (3/3) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1478/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 3: Build Started (1/3) -> http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2890/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Better logging for network restoration.
Ido Barkan has posted comments on this change. Change subject: Better logging for network restoration. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/37506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc4be51ec3f8af210f2b4a0acdc52e372835239 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: fix call to super ctor
Nir Soffer has posted comments on this change. Change subject: jsonrpc: fix call to super ctor .. Patch Set 4: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/39781/4/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 31 Line 32 Line 33 Line 34 Line 35 Having an error code allow callers to do something with an error. We do want to keep the error code. Line 32 Line 33 Line 34 Line 35 Line 36 Just replace RuntimeError with JsonRpcError -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
Nir Soffer has posted comments on this change.
Change subject: stomp: add an option to create a stomp client
..
Patch Set 5:
(4 comments)
https://gerrit.ovirt.org/#/c/38491/5//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-04-21 11:24:09 +0300
Line 4: Commit: Yeela Kaplan
Line 5: CommitDate: 2015-04-21 11:24:09 +0300
Line 6:
Line 7: stomp: add an option to create a stomp client
Why protocol detector should be involved in creating a client?
If the reason for creating the client is the reactor, we should get the
reactor out of the protocol detector (it can be created by the application, and
the protocol detector can get it when creating a detector.
Please explain why this code should be here.
Line 8:
Line 9: Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231
https://gerrit.ovirt.org/#/c/38491/5/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 184: return sslctx
Line 185:
Line 186: def createStompClient(self, connected_socket):
Line 187: return self._acceptor.create_client(connected_socket,
Line 188: 'stomp')
Why do we need a connected socket for creating a client? A client is supposed
to connect to a server, not get connected socket.
Line 189:
Line 190: def _prepareXMLRPCBinding(self):
Line 191: if config.getboolean('vars', 'xmlrpc_enable'):
Line 192: try:
https://gerrit.ovirt.org/#/c/38491/5/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:
Line 197: def stop(self):
Line 198: self.log.debug("Stopping Acceptor")
Line 199: self._reactor.stop()
Line 200:
Line 201: def create_client(self, connected_socket, type):
How creating a client is related to the protocol detector?
Line 202: if type == "stomp":
Line 203: for handler in self._handlers:
Line 204: if handler.NAME == "stomp":
Line 205: return handler.createClient(connected_socket)
Line 201: def create_client(self, connected_socket, type):
Line 202: if type == "stomp":
Line 203: for handler in self._handlers:
Line 204: if handler.NAME == "stomp":
Line 205: return handler.createClient(connected_socket)
Getting a client from the detector?!
Line 206:
Line 207: return None
Line 208:
Line 209:
--
To view, visit https://gerrit.ovirt.org/38491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronheim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
Nir Soffer has posted comments on this change.
Change subject: sslutils: move createSSLContext from clientIF
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/36699/5/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 338: if not self._is_handshaking:
Line 339: self._handshake_finished_handler(dispatcher)
Line 340:
Line 341:
Line 342: def ssl_enabled():
> considering the module name, the 'ssl_' prefix is perhaps a bit redundant,
This was true if the module was called ssl (ssl.enabled()), but
sslutils.enabled() does not make much sense.
Line 343: return config.getboolean('vars', 'ssl')
Line 344:
Line 345:
Line 346: def create_ssl_context():
--
To view, visit https://gerrit.ovirt.org/36699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronheim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require lvm >= 2.02.100-8
Allon Mureinik has posted comments on this change. Change subject: spec: Require lvm >= 2.02.100-8 .. Patch Set 3: PING?! -- To view, visit https://gerrit.ovirt.org/37492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee80ffbbee55768aa632725c9f129813a8815d4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add systemd_run command modifier
Nir Soffer has posted comments on this change. Change subject: utils: Add systemd_run command modifier .. Patch Set 1: Systemd is available on Debian now: https://www.debian.org/releases/jessie/amd64/release-notes/ch-whats-new.en.html#systemd So I think it is ok to depend on it now. -- To view, visit https://gerrit.ovirt.org/40239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35bdae752228b6716c25f0b9975fc500897a592 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add systemd_run command modifier
Nir Soffer has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/40239/1/configure.ac
File configure.ac:
Line 327: AC_PATH_PROG([SUDO_PATH], [sudo], [/usr/bin/sudo])
Line 328: AC_PATH_PROG([SU_PATH], [su], [/bin/su])
Line 329: AC_PATH_PROG([SYSCTL_PATH], [sysctl], [/sbin/sysctl])
Line 330: AC_PATH_PROG([SYSTEMCTL_PATH], [systemctl], [/bin/systemctl])
Line 331: AC_PATH_PROG([SYSTEMD_RUN_PATH], [systemd-run],
[/usr/bin/systemd-run])
> if only one place uses it - define it there with CommandPath
We use it in two places (sudoers and cmdutils.py)
Line 332: AC_PATH_PROG([TAR_PATH], [tar], [/bin/tar])
Line 333: AC_PATH_PROG([TC_PATH], [tc], [/sbin/tc])
Line 334: AC_PATH_PROG([TEE_PATH], [tee], [/usr/bin/tee])
Line 335: AC_PATH_PROG([TOUCH_PATH], [touch], [/bin/touch])
https://gerrit.ovirt.org/#/c/40239/1/lib/vdsm/cmdutils.py
File lib/vdsm/cmdutils.py:
Line 52: command.extend(cmd)
Line 53: return command
Line 54:
Line 55:
Line 56: def systemd_run(cmd, scope=False, unit=None, slice=None):
> this is specific code for systemd - shouldn't be in vdsm core. either have
vdsm-tool is a command line tool - it does not make sense to start another
python process to do this.
We can create a compatibility layer in vdsm library, so it can be used in both
vdsm daemon and the tool - but the question is what should we use when systemd
is not available - cgexec?
So this should be abstract command, something like run_as_service?
Line 57: command = [constants.EXT_SYSTEMD_RUN]
Line 58: if scope:
Line 59: command.append('--scope')
Line 60: if unit:
https://gerrit.ovirt.org/#/c/40239/1/vdsm/sudoers.vdsm.in
File vdsm/sudoers.vdsm.in:
Line 12: @MV_PATH@ /etc/multipath.conf *, \
Line 13: @CP_PATH@ * /etc/iscsi/iscsid.conf, \
Line 14: @SERVICE_PATH@ iscsid *, \
Line 15: @BINDIR@/vdsm-tool service-restart multipathd, \
Line 16: @BINDIR@/vdsm-tool service-reload multipathd, \
> if adding any permission I would add vdsm-tool call for it which hides the
What do you mean by adding any permission?
Anyway, I think we should drop this and run this in supervdsm instead of sudo,
but this requires rather big change - running mount from supervdsm, and I don't
want to mix it with this fix.
Line 17: @ISCSIADM_PATH@ *, \
Line 18: @LVM_PATH@, \
Line 19: @CAT_PATH@ /sys/block/*/device/../../*, \
Line 20: @CAT_PATH@ /sys/devices/platform/host*, \
--
To view, visit https://gerrit.ovirt.org/40239
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic35bdae752228b6716c25f0b9975fc500897a592
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: avoid python3-inconsistent syntax
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18247/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1477/ : 0 -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: avoid python3-inconsistent syntax
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 3: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1477/ -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: use python3-compatible raising
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/860/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/869/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1414/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/99/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18246/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1476/ : 0 -- To view, visit https://gerrit.ovirt.org/40214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I991be53a5321e7950badce44359dc4bd13f70b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18245/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1475/ : 0 -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: use python3-compatible raising
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: Build Started (6/6) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1476/ -- To view, visit https://gerrit.ovirt.org/40214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I991be53a5321e7950badce44359dc4bd13f70b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 1: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1475/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: simplify flows
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: simplify flows .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18244/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1474/ : 0 -- To view, visit https://gerrit.ovirt.org/40326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide103d0ed9a694cc9ddd9b0b382e2d81a1bd48c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: avoid periodic operations on DOWN vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: avoid periodic operations on DOWN vms .. Patch Set 25: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18243/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1473/ : 0 -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: simplify flows
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: simplify flows .. Patch Set 1: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1474/ -- To view, visit https://gerrit.ovirt.org/40326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide103d0ed9a694cc9ddd9b0b382e2d81a1bd48c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: avoid periodic operations on DOWN vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: avoid periodic operations on DOWN vms .. Patch Set 25: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1473/ -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: remove not used client .. Patch Set 3: Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/557/ -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: remove not used client .. Patch Set 3: Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/102/ -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: remove not used client .. Patch Set 3: Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/102/ -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: remove not used client .. Patch Set 3: Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/960/ -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 46: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18242/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1472/ : 0 -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 46 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: remove not used client .. Patch Set 3: Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/544/ -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: remove not used client .. Patch Set 3: Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/962/ -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
Dan Kenigsberg has submitted this change and it was merged. Change subject: stomp: remove not used client .. stomp: remove not used client Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Signed-off-by: pkliczew Reviewed-on: https://gerrit.ovirt.org/40168 Reviewed-by: Yaniv Bronhaim Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M lib/yajsonrpc/stomp.py 1 file changed, 1 insertion(+), 117 deletions(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
automat...@ovirt.org has posted comments on this change. Change subject: stomp: remove not used client .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: remove not used client .. Patch Set 3: Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/548/ -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: remove not used client .. Patch Set 3: Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/925/ -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: remove not used client
Dan Kenigsberg has posted comments on this change. Change subject: stomp: remove not used client .. Patch Set 2: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/40168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf3ca273abb760ccd8257f67addc4eb28e79bb2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: avoid python3-inconsistent syntax
Nir Soffer has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/40215/3/Makefile.am File Makefile.am: Line 131: Line 132: .PHONY: python3 Line 133: python3: Line 134: if [ -x "$(PYTHON3)" ]; \ Line 135: then \ Will be nicer like this: if [ -x "$(PYTHON3)" ]; then \ Line 136: $(PYTHON3) -m compileall `find . -name '*.py' -o -name '*.py.in'`; \ Line 137: else \ Line 138: echo "Warning: skipping python3 syntax check"; \ Line 139: fi Line 132: .PHONY: python3 Line 133: python3: Line 134: if [ -x "$(PYTHON3)" ]; \ Line 135: then \ Line 136: $(PYTHON3) -m compileall `find . -name '*.py' -o -name '*.py.in'`; \ Does it compile inside the project? this should be done in a temporary directory if possible, or without creating py[co] files. Line 137: else \ Line 138: echo "Warning: skipping python3 syntax check"; \ Line 139: fi Line 140: Line 134: if [ -x "$(PYTHON3)" ]; \ Line 135: then \ Line 136: $(PYTHON3) -m compileall `find . -name '*.py' -o -name '*.py.in'`; \ Line 137: else \ Line 138: echo "Warning: skipping python3 syntax check"; \ This should not be a warning. Line 139: fi Line 140: Line 141: # Note: dependencies ordered by time needed to run them Line 142: check-recursive: gitignore python3 pyflakes pep8 Line 138: echo "Warning: skipping python3 syntax check"; \ Line 139: fi Line 140: Line 141: # Note: dependencies ordered by time needed to run them Line 142: check-recursive: gitignore python3 pyflakes pep8 I assume that python3 target is slower then gitignore, and fater then pyflakes - right? Line 143: Line 144: .PHONY: check-all Line 145: check-all: Line 146: $(MAKE) check NOSE_STRESS_TESTS=1 NOSE_SLOW_TESTS=1 -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 27: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/859/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/868/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1413/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/98/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18241/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1471/ : 0 -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 46: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1472/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 46 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: tests: add tests for sampling.SampleVMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: tests: add tests for sampling.SampleVMs .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18240/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1470/ : 0 -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 27: Build Started (6/6) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1471/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: use python3-compatible raising
Nir Soffer has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: Code-Review+1 If it works, I'm fine with this. Did you review six.reraise code? -- To view, visit https://gerrit.ovirt.org/40214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I991be53a5321e7950badce44359dc4bd13f70b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add logged CPopen command execution
Nir Soffer has posted comments on this change.
Change subject: utils: add logged CPopen command execution
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38831/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 596: logger.log(level, "%s (cwd %s)", _list2cmdline(printable), cwd)
Line 597:
Line 598: return CPopen(args, close_fds=close_fds, cwd=cwd, env=env,
Line 599: deathSignal=deathSignal, childUmask=childUmask)
Line 600:
We can do the logging like this - in the call site:
self.log.debug("Starting convert: %s", cmdutils.format_cmd(cmd, cwd=curdir))
proc = CPopen(...)
interact with it...
self.log.debug("Convert finished: %s, cmdutils.format_term(proc))
So we have both context of the call site and consistent formatting or command
line parameters and return value.
And we don't have to pass loggers around.
To avoid formatting when log level is disabled, we can do:
class Exit(object):
def __init__(self, proc):
self.proc = proc
def __str__(self):
if self.proc.returncode < 0:
return "%s terminated by signal %d" % (self.proc.name,
-self.proc.returncode)
else:
return "%s existed with rc =%s" % (self.proc.name,
self.proc.returncode)
So the call above will be:
self.log.debug("Finished convert: %s", cmdutils.Exit(proc))
This needs some more cooking of course.
Line 601:
Line 602: def execCmd(command, sudo=False, cwd=None, data=None, raw=False,
Line 603: printable=None, env=None, sync=True, nice=None,
ioclass=None,
Line 604: ioclassdata=None, setsid=False,
execCmdLogger=logging.root,
--
To view, visit https://gerrit.ovirt.org/38831
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e04bde10be24457fe12362456e42528f9fd7196
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add logged CPopen command execution
Nir Soffer has posted comments on this change. Change subject: utils: add logged CPopen command execution .. Patch Set 3: Code-Review+1 I would love if we introduce better logging instead of adding this loggedCPopen. -- To view, visit https://gerrit.ovirt.org/38831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e04bde10be24457fe12362456e42528f9fd7196 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: replace flag with Stage
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: replace flag with Stage .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18239/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1469/ : 0 -- To view, visit https://gerrit.ovirt.org/40322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b4fec4d609fe22e890de911342f80505de88c9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: tests: add tests for sampling.SampleVMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: tests: add tests for sampling.SampleVMs .. Patch Set 13: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1470/ -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: replace flag with Stage
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: replace flag with Stage .. Patch Set 1: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1469/ -- To view, visit https://gerrit.ovirt.org/40322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b4fec4d609fe22e890de911342f80505de88c9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: avoid periodic operations on DOWN vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: avoid periodic operations on DOWN vms .. Patch Set 24: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18238/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1468/ : 0 -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: use python3-compatible raising
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18246/ -- To view, visit https://gerrit.ovirt.org/40214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I991be53a5321e7950badce44359dc4bd13f70b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: avoid python3-inconsistent syntax
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18247/ -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18245/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: simplify flows
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: simplify flows .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18244/ -- To view, visit https://gerrit.ovirt.org/40326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide103d0ed9a694cc9ddd9b0b382e2d81a1bd48c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for usb devices
Francesco Romani has posted comments on this change.
Change subject: hostdev: add support for usb devices
..
Patch Set 4:
(3 comments)
one minor stylistic issue, which is not very important; two questions inside.
-1 for visibility only.
https://gerrit.ovirt.org/#/c/39715/4/vdsm/hostdev.py
File vdsm/hostdev.py:
Line 34:
Line 35:
Line 36: def address_to_name(device_type, address):
Line 37: return {'pci': pci_address_to_name,
Line 38: 'usb': usb_address_to_name}[device_type](**address)
very dense. Plase consider to sparsify it a bit:
def address_to_name(device_type, address):
translators = {
'pci': pci_address_to_name,
'usb': usb_address_to_name
}
to_name = translators[device_type]
return to_name(**address)
Line 39:
Line 40:
Line 41: def pci_address_to_name(domain, bus, slot, function):
Line 42: """
https://gerrit.ovirt.org/#/c/39715/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3808: # both addresses and determine the correct one.
Line 3809: if hostdev.address_to_name(device_type, address) ==
device:
Line 3810: try:
Line 3811: address = self._getUnderlyingDeviceAddress(x, 1)
Line 3812: except IndexError:
why this didn't raise before?
Line 3813: address = None
Line 3814:
Line 3815: known_device = False
Line 3816: for dev in self.conf['devices']:
https://gerrit.ovirt.org/#/c/39715/4/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:
Line 61
Line 62
Line 63
Line 64
Line 65
why is this if gone?
--
To view, visit https://gerrit.ovirt.org/39715
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9b4f302353f3006e1f945dd342d351039ba387
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: avoid periodic operations on DOWN vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: avoid periodic operations on DOWN vms .. Patch Set 25: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18243/ -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: avoid needless temporary list .. Patch Set 3: Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/101/ -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: avoid needless temporary list .. Patch Set 3: Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/547/ -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: avoid needless temporary list .. Patch Set 3: Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/101/ -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: avoid periodic operations on DOWN vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: avoid periodic operations on DOWN vms .. Patch Set 24: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1468/ -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 46: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18242/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 46 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: avoid needless temporary list .. Patch Set 3: Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/543/ -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: use python3-compatible raising
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/869/ -- To view, visit https://gerrit.ovirt.org/40214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I991be53a5321e7950badce44359dc4bd13f70b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: use python3-compatible raising
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1414/ -- To view, visit https://gerrit.ovirt.org/40214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I991be53a5321e7950badce44359dc4bd13f70b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: avoid needless temporary list .. Patch Set 3: Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/959/ -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 27: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18241/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: avoid needless temporary list .. Patch Set 3: Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/924/ -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: avoid needless temporary list .. Patch Set 3: Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/556/ -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 45: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18237/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1467/ : 0 -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 45 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: avoid needless temporary list .. Patch Set 3: Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/961/ -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: tests: add tests for sampling.SampleVMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: tests: add tests for sampling.SampleVMs .. Patch Set 13: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18240/ -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: use python3-compatible raising
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/99/ -- To view, visit https://gerrit.ovirt.org/40214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I991be53a5321e7950badce44359dc4bd13f70b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: replace flag with Stage
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: replace flag with Stage .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18239/ -- To view, visit https://gerrit.ovirt.org/40322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b4fec4d609fe22e890de911342f80505de88c9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: use python3-compatible raising
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/860/ -- To view, visit https://gerrit.ovirt.org/40214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I991be53a5321e7950badce44359dc4bd13f70b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 27: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1413/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: eliminate tuple_params
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: eliminate tuple_params .. Patch Set 7: Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/958/ -- To view, visit https://gerrit.ovirt.org/40078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I049adecda40deb6f715e3aea2e3ada4030b518a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: eliminate tuple_params
oVirt Jenkins CI Server has posted comments on this change. Change subject: python3: eliminate tuple_params .. Patch Set 7: Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/960/ -- To view, visit https://gerrit.ovirt.org/40078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I049adecda40deb6f715e3aea2e3ada4030b518a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 26: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/867/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1412/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/97/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18236/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1466/ : 0 -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 27: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/98/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: avoid python3-inconsistent syntax
automat...@ovirt.org has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: use python3-compatible raising
automat...@ovirt.org has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I991be53a5321e7950badce44359dc4bd13f70b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: lib2to3.fixes.fix_idioms
Dan Kenigsberg has abandoned this change. Change subject: python3: lib2to3.fixes.fix_idioms .. Abandoned temporary abandon non-critical patch -- To view, visit https://gerrit.ovirt.org/40125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I543c07a9fefb592dc5f132453643eb8ac0808c63 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: lib2to3.fixes.fix_idioms
automat...@ovirt.org has posted comments on this change. Change subject: python3: lib2to3.fixes.fix_idioms .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543c07a9fefb592dc5f132453643eb8ac0808c63 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 27: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/859/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 26: Build Started (6/6) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1466/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
Dan Kenigsberg has posted comments on this change.
Change subject: vm.py: avoid needless temporary list
..
Patch Set 2: Code-Review+2 Verified+1
Verified in the interpreter command-line.
>>> drive=dict(poolID=1, domainID=2, imageID=3, volumeID=4, bla=7)
>>> dict([(k, drive[k]) for k in 'poolID', 'domainID', 'imageID', 'volumeID'])
{'domainID': 2, 'imageID': 3, 'volumeID': 4, 'poolID': 1}
>>> dict((k, drive[k]) for k in ('poolID', 'domainID', 'imageID', 'volumeID'))
{'domainID': 2, 'imageID': 3, 'volumeID': 4, 'poolID': 1}
--
To view, visit https://gerrit.ovirt.org/40213
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
automat...@ovirt.org has posted comments on this change. Change subject: vm.py: avoid needless temporary list .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm.py: avoid needless temporary list .. vm.py: avoid needless temporary list Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/40213 Reviewed-by: Ondřej Svoboda Reviewed-by: Francesco Romani --- M vdsm/virt/vm.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondřej Svoboda: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 45: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18237/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 45 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make sure {true, apparent}size is str in conf
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make sure {true,apparent}size is str in conf
..
Patch Set 3:
Build Started (8/9) ->
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/99/
--
To view, visit https://gerrit.ovirt.org/40225
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a8259a3f05cb366b5a570f5a1f31ae2c9567ae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make sure {true, apparent}size is str in conf
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make sure {true,apparent}size is str in conf
..
Patch Set 3:
Build Started (7/9) ->
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/99/
--
To view, visit https://gerrit.ovirt.org/40225
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a8259a3f05cb366b5a570f5a1f31ae2c9567ae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move libvirt helpers in a module
Francesco Romani has posted comments on this change. Change subject: virt: move libvirt helpers in a module .. Patch Set 23: Let's considering libvirt_helpers subpackage. We can have something like vdsm/virt/ `- libvirt_helpers/ +- __init__.py # empty saved the copyriught boilerplate +- events.py # with to_string() function +- domain.py # list(), Notifying considering future expandibility, it seems to me that the above leans too much on the 'overkill' side. We're talking about 92 lines of code (gross count, including copyright boilerplate and blanks), which little if any chance to grow in the foreseeable future. I'm inclined to keep this as module, for the time being. -- To view, visit https://gerrit.ovirt.org/39332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: eliminate tuple_params
Dan Kenigsberg has posted comments on this change. Change subject: python3: eliminate tuple_params .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I049adecda40deb6f715e3aea2e3ada4030b518a3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: eliminate tuple_params
Dan Kenigsberg has submitted this change and it was merged. Change subject: python3: eliminate tuple_params .. python3: eliminate tuple_params I liked tuple arguments, but they are gone from Python 3 due to pep-3113, and their current use in Vdsm was unwarranted. Change-Id: I049adecda40deb6f715e3aea2e3ada4030b518a3 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/40078 Reviewed-by: Ondřej Svoboda Reviewed-by: Francesco Romani Reviewed-by: Ido Barkan --- M tests/functional/networkTests.py M vdsm/storage/spbackends.py M vdsm/virt/vm.py 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Ondřej Svoboda: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I049adecda40deb6f715e3aea2e3ada4030b518a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: eliminate tuple_params
automat...@ovirt.org has posted comments on this change. Change subject: python3: eliminate tuple_params .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I049adecda40deb6f715e3aea2e3ada4030b518a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make sure {true, apparent}size is str in conf
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make sure {true,apparent}size is str in conf
..
Patch Set 3:
Build Started (6/9) ->
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/922/
--
To view, visit https://gerrit.ovirt.org/40225
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a8259a3f05cb366b5a570f5a1f31ae2c9567ae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make sure {true, apparent}size is str in conf
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make sure {true,apparent}size is str in conf
..
Patch Set 3:
Build Started (5/9) ->
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/541/
--
To view, visit https://gerrit.ovirt.org/40225
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a8259a3f05cb366b5a570f5a1f31ae2c9567ae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 26: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18236/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: tests: add tests for sampling.SampleVMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: tests: add tests for sampling.SampleVMs .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18235/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1465/ : 0 -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make sure {true, apparent}size is str in conf
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make sure {true,apparent}size is str in conf
..
Patch Set 3:
Build Started (4/9) ->
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/545/
--
To view, visit https://gerrit.ovirt.org/40225
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a8259a3f05cb366b5a570f5a1f31ae2c9567ae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
automat...@ovirt.org has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 27: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: simplify flows
automat...@ovirt.org has posted comments on this change. Change subject: sampling: simplify flows .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide103d0ed9a694cc9ddd9b0b382e2d81a1bd48c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: avoid periodic operations on DOWN vms
automat...@ovirt.org has posted comments on this change. Change subject: WIP: virt: avoid periodic operations on DOWN vms .. Patch Set 25: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
